GitLab

This patch adds an AsDict call from Telemetry Values and implements it for
the various Value subtypes. The AsDict call will be used to produce the
intermediate representation of page test results for JSON output.

Patch set 1 pulls in the value system changes from 378633003

BUG=375541

Review URL: https://codereview.chromium.org/381723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283349 0039d316-1c4b-4281-b951-d872f2087c98

BUG=160586

Review URL: https://codereview.chromium.org/396493004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283348 0039d316-1c4b-4281-b951-d872f2087c98

This removes the restriction that forms must have method="POST" to be autofilled. FormData no longer tracks the method at all.

BUG=390713

Review URL: https://codereview.chromium.org/365783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283347 0039d316-1c4b-4281-b951-d872f2087c98

As part of the project PlzNavigate, this CL introduces a new IPC,
FrameHostMsg_BeginNavigation that should be sent from the renderer to the
browser on renderer-initiated navigation, or in response to a
FrameMsg_RequestNavigation (that will be introduced in a later CL) for browser
initiated ones.

Upon reception of FrameHostMsg_BeginNavigation, the UI thread will forward the relevant information to the IO thread (to the ResourceDispatcherHost). 

BUG=376014

Review URL: https://codereview.chromium.org/367653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283346 0039d316-1c4b-4281-b951-d872f2087c98

Test will follow in next patch, as it requires testing code refactoring.

BUG=393566,393855

Review URL: https://codereview.chromium.org/395793003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283345 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283344 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178201:178213&mode=html
TBR=falken@chromium.org,abarth@chromium.org,eseidel@chromium.org
BUG=

Review URL: https://codereview.chromium.org/396083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283343 0039d316-1c4b-4281-b951-d872f2087c98

Add UMA stats to track frequency and success rate of enrollment recovery.

BUG=389481

Review URL: https://codereview.chromium.org/385983007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283342 0039d316-1c4b-4281-b951-d872f2087c98

This is a regression of change r278331.  We should let the default dispatchKeyEvent handler to handle KEYCODE_BACK instead of forwarding it to the host.

BUG=393055

Review URL: https://codereview.chromium.org/390983008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283341 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/385163007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283340 0039d316-1c4b-4281-b951-d872f2087c98

Add and modify the BakedBezierInterpolator from Android to include the new interpolator curves
we need.

Originally from: https://android.googlesource.com/platform/frameworks/support/+/master/v4/java/android/support/v4/widget/BakedBezierInterpolator.java

BUG=375379

Review URL: https://codereview.chromium.org/380133004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283339 0039d316-1c4b-4281-b951-d872f2087c98

Use SkSrc_Mode in SkCanvasVideoRenderer, to prevent transparent video frames from blending with reused image buffer contents.

BUG=392733
TEST=SkCanvasVideoRendererTest.TransparentFrame

Review URL: https://codereview.chromium.org/388363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283338 0039d316-1c4b-4281-b951-d872f2087c98

It is divided into buffer.h, date_pipe.h, functions.h, handles.h,
macros.h and message_pipe.h.

BUG=386803
TEST=none
R=viettrungluu@chromium.org, darin@chromium.org

Review URL: https://codereview.chromium.org/392783006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283337 0039d316-1c4b-4281-b951-d872f2087c98

WebNavigationApi formerly passed around a lot of redundant state, but
now it just uses RenderFrameHost. Code that needs to know the routing
ID, parent, etc can just derive it from the RenderFrameHost.

Since WebNavigationApi is storing raw pointers to RenderFrameHost, it
also observers RFH deletions and removes them as needed. This fixes
some use-after-frees when other observers are incorrectly causing the
RenderFrameHost to be destroyed.

BUG=391058

Review URL: https://codereview.chromium.org/384993004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283336 0039d316-1c4b-4281-b951-d872f2087c98

Previously there care cases where those structs are only partially initialized.

TBR=ddorwin@chromium.org
BUG=393938

Review URL: https://codereview.chromium.org/390613004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283335 0039d316-1c4b-4281-b951-d872f2087c98

BUG=393346
R=yoshiki@chromium.org
TEST=Manually tested with external USB keyboard
Signed-off-by: Eduardo Lima (Etrunko) <eduardo.lima@intel.com>

Review URL: https://codereview.chromium.org/383313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283334 0039d316-1c4b-4281-b951-d872f2087c98

This routine used to be used by Drive tests only. However, File System Provider
API code would also like to take advantage of it.

Note, that this function should be used in tens of other places in Chromium
code base, instead SequencedWorkerPool::FlushForTesting() more than once if
several rounds of posting tasks to the blocking pool may happen.

TEST=Refactoring only. Compiles and passes all current tests.
BUG=392716

Review URL: https://codereview.chromium.org/380993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283333 0039d316-1c4b-4281-b951-d872f2087c98

PostTask in WebMessagePortChannelImpl::postMessage seems cross-thread, but
copying blink::WebString accross threads is not thread safe.

This CL converts blink::WebString to base::string16 before PostTask, making
the code thread-safe assuming base::string16 can be copied accross threads.

BUG=392410

Review URL: https://codereview.chromium.org/379773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283332 0039d316-1c4b-4281-b951-d872f2087c98

This CL fixes an issue where the app list folder animation would hide the
item label for its animation, causing the text to pop in at the end of
animation.

This is fixed by only hiding the icon rather than the entire AppListItemView
during the animation.

BUG=393207

Review URL: https://codereview.chromium.org/395653005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283331 0039d316-1c4b-4281-b951-d872f2087c98

We want to build Chrome with toolkit-views available, but port things
gradually.

This change converts a View* argument into a callback argument that
calls the required member function on View.

This lets us get rid of eleven #ifdef guards which would otherwise need
to change (now, and again once the download shelf is ported to use views
on Mac).

BUG=390755

Review URL: https://codereview.chromium.org/377223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283330 0039d316-1c4b-4281-b951-d872f2087c98

BUG=328417

Review URL: https://codereview.chromium.org/384063004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283329 0039d316-1c4b-4281-b951-d872f2087c98

Added a guard in |chromeos::EventRewriter::RewriteKeyEvent()|.
Moved |ui::XKeyEventKeyCode()| to share it. Added unit test cases.

BUG=390263
TEST=EventRewriterTest.TestRewriteModifiersRemapMany
R=derat@chromium.org,sadrul@chromium.org

Review URL: https://codereview.chromium.org/378503007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283328 0039d316-1c4b-4281-b951-d872f2087c98

BUG=349436

Review URL: https://codereview.chromium.org/383213007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283327 0039d316-1c4b-4281-b951-d872f2087c98

BUG=333429

Review URL: https://codereview.chromium.org/385533002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283326 0039d316-1c4b-4281-b951-d872f2087c98

This contains fixes for the following sorts of issues:
* Possibly-uninitialized local variable
* Signedness mismatch
* Assignment inside conditional

This also contains a small number of other cleanups/simplifications to nearby
 code.

BUG=81439
TEST=none

Review URL: https://codereview.chromium.org/368133005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283325 0039d316-1c4b-4281-b951-d872f2087c98

R=vsevik
BUG=375205

Review URL: https://codereview.chromium.org/363463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283324 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283317 0039d316-1c4b-4281-b951-d872f2087c98

R=davemoore@chromium.org

Review URL: https://codereview.chromium.org/390183009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283314 0039d316-1c4b-4281-b951-d872f2087c98

This simplifies things and better matches how we're actually using the
API.

BUG=389339
TEST=covered by unit tests
R=ben@chromium.org

Review URL: https://codereview.chromium.org/396703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283313 0039d316-1c4b-4281-b951-d872f2087c98

Remove the remaining overrides of View::HitTestRect() and
instead implement View::ViewTargeterDelegate::DoesIntersectRect().
Make View::HitTestRect() non-virtual.

BUG=388838
TEST=none

Review URL: https://codereview.chromium.org/380813003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283312 0039d316-1c4b-4281-b951-d872f2087c98

In the interest of conserving power, several incremental changes to timer slack have been committed over the last few weeks.  This CL disables those changes so we can get some numbers for the combined effect in terms of power usage and idle wakeup numbers.

This needs to be checked in because we can only get a good comparative measure for this when run on the bots in a controlled environment.

BUG=356804

Review URL: https://codereview.chromium.org/395763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283311 0039d316-1c4b-4281-b951-d872f2087c98

Initial patch.

Review URL: https://codereview.chromium.org/389263007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283310 0039d316-1c4b-4281-b951-d872f2087c98

BUG=375533
R=abodenha@chromium.org

Review URL: https://codereview.chromium.org/393673004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283309 0039d316-1c4b-4281-b951-d872f2087c98

Prior to crrev.com/274857 *only* android-chromium-testshell. Then until crrev.com/276628 *both* (android-chromium-testshell and
android-chrome-shell) work. After that rev 276628 *only* android-chrome-shell works. bisect-perf-reggresion.py script should
handle these cases and set appropriate browser type based on revision.

BUG=385324
NOTRY=true

Review URL: https://codereview.chromium.org/399463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283308 0039d316-1c4b-4281-b951-d872f2087c98

These things should be in a 'variables' block (otherwise they don't do
anything).

BUG=388270
NOTRY=true

Review URL: https://codereview.chromium.org/396823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283306 0039d316-1c4b-4281-b951-d872f2087c98

This contains fixes for the following sorts of issues:
* Signedness mismatch
* Assignment inside conditional
* Constant value was truncated
* Possibly-uninitialized local variable

BUG=81439
TEST=none

Review URL: https://codereview.chromium.org/377683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283305 0039d316-1c4b-4281-b951-d872f2087c98

Adds support for allowing users to change the appearance of 
distilled pages to different themes. The current themes are 
light, dark and sepia.

The theme of the page is controlled by the CSS class of the 
body element. When the page is loaded, this CSS class is set
 by inserting the CSS class into the HTML.  When a setting is 
changed while a distilled page is open, the CSS class is set 
by calling the JavaScript function useTheme which then updates 
the body element's CSS class.

BUG=383630

Review URL: https://codereview.chromium.org/341563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283303 0039d316-1c4b-4281-b951-d872f2087c98

* Fix typo.
* Remove unused code.
* Move IsFallbackFileBrowserHandler to file_tasks.cc since it is no more
 specific to fileBrowserHandler.

BUG=none

Review URL: https://codereview.chromium.org/391873003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283302 0039d316-1c4b-4281-b951-d872f2087c98

The previous comment was incorrect. It seems to be a leftover when
the flag changed from --enable-shared-worker to
--disable-shared-worker in https://codereview.chromium.org/395006.

Review URL: https://codereview.chromium.org/378523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283300 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/383123003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283299 0039d316-1c4b-4281-b951-d872f2087c98