- 05 Aug, 2019 40 commits
-
-
Christopher Gunadi authored
When policy is set on server, background and foreground of FilesApp will listen to changes in pref and hide/show the "Install with Linux (Beta)" context menu option Follow up CL to http://crosreview.com/1712667 Bug: 983997, 983998, 988375 Test: compile Change-Id: I666cb79e48e876cb222a0dead3e6cf96a5a0a28a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730907Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Christopher Gunadi <chrisgunadi@google.com> Cr-Commit-Position: refs/heads/master@{#683942}
-
Alexandre Courbot authored
We have a lot of chromium-style errors happening when enabling V4L2 for a non-Chrome OS build, e.g: ../../media/gpu/v4l2/v4l2_decode_surface.h:139:7: error: [chromium-style] Classes that are ref-counted should have explicit destructors that are declared protected or private. class V4L2RequestDecodeSurface : public V4L2DecodeSurface { and ../../media/gpu/v4l2/v4l2_slice_video_decoder.h:97:5: error: [chromium-style] Complex constructor has an inlined body. DecodeRequest(scoped_refptr<DecoderBuffer> buf, DecodeCB cb, int32_t id) This CL fixes these errors. Bug: 990690 Test: VDA unittest passes on Kukui. Change-Id: I3485c855f8affefb7ac99732e11fa78466081d60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736346Reviewed-by:Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#683941}
-
Alice Boxhall authored
Fixing issue found by FindIt https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzQ0NzBkNDFkYjA3NDIwOTBlOWYxYjQ5NmZhOTA2MDBmNDdjNTMyYTgM ... revealed by test added in https://crrev.com/c/1731634 Change-Id: Ic2f2c381a4aa714172ff3487e05dca10744213e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736206 Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#683940}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b976207c9e04..5a81193b1377 Created with: gclient setdep -r src-internal@5a81193b1377 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I655ed715cb9e148d14c18c7585b6872661e64946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736401Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683939}
-
Adam Rice authored
Split out code from DOMWebSocket that will be shared with WebSocketStream into a new class, WebSocketCommon. The major methods that have been moved are Connect() and CloseInternal(). Connect() in particular has some security-critical checks that should not be duplicated. Some members of DOMWebSocket have been moved to WebSocketCommon because they need to be modified by WebSocketCommon methods. The most important of these is |status_|. This is part of the implementation work for WebSocketStream. The design doc for the work as a whole is at https://docs.google.com/document/d/1XuxEshh5VYBYm1qRVKordTamCOsR-uGQBCYFcHXP4L0/edit BUG=983030 Change-Id: Idba0d5181b2a6946f65d10083f9e15a0fe5e7ec9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731010Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#683938}
-
Tomasz Moniuszko authored
The directive breaks jumbo build with "error : using namespace directive in global context in header". It's also against Google C++ Style Guide rules. Change-Id: I4b2bb154fca3b59bc0561727b1b4e12ca23ec103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731939Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Tomasz Moniuszko <tmoniuszko@opera.com> Cr-Commit-Position: refs/heads/master@{#683937}
-
Alex Danilo authored
Logic for deleting a summary panel was checking the total number of panels active, rather than the number of 'progress' panels. Use the count of progress panels as the criteria for removal of the summary panel display. Bug: 987931 Change-Id: I0ac1aa47fbcd297b916a1047b945c6682ee9884f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732589Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#683936}
-
Matt Giuca authored
This reverts commit 7a5df8d5. Reason for revert: Suspect it introduces timeout https://crbug.com/990692 DevToolsSanityTest.TestDeviceEmulation is reliably timing out with "[FAILED] Timeout exceeded: 20 sec". Original change's description: > Don't use NOTIFICATION_BROWSER_CLOSE_CANCELLED in tests > > Bug: 268984 > Change-Id: Ie41cb913d29ad690b9364d9c478c7a3c4771f607 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730591 > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#683662} TBR=avi@chromium.org,estade@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 268984, 990692 Change-Id: Ia1213f589b2cf3b966381886f2d60ff646ae7103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734735Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Commit-Queue: Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#683935}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a56838e0ef52..594583382d4e git log a56838e0ef52..594583382d4e --date=short --no-merges --format='%ad %ae %s' 2019-08-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 369f9e5df60b..dc2c5c5a419e (12 commits) 2019-08-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 01452feb..d67ae722 (443 commits) Created with: gclient setdep -r src/third_party/skia@594583382d4e The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@google.com Bug: chromium:None,chromium:None Change-Id: I02cd44793512b0769b2a4d7d4991e8cf66748579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736392Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683934}
-
David Staessens authored
This CL increases the timeout used when waiting for events in the video_decode_accelerator_perf_tests. The MeasureCappedPerformance test decodes the video in real-time, so we should make sure the timeout is at least as large as the video's duration. The timeout is also increased when writing video frames to disk in the video_decode_accelerator_tests, as this can take a lot of time. TEST=./video_decode_accelerator_tests on eve BUG=None Change-Id: Iaf92d32cae755e6d0afe50571a87bb44a87c561c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731641 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I481162f7297b7bfd1b3322ecba110155f2b45e1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736227Reviewed-by:
-
Hiroki Nakagawa authored
In WebSharedWorkerImpl::TerminateWorkerThread(), following if-conditions (1) if (shadow_page_ && !shadow_page_->WasInitialized()) (2) if (worker_thread_) are mutually exclusive, so we don't have to check the both conditions. Bug: 987850 Change-Id: Ibfac267d4ed684966853c606a09ab2fd8bb31e05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734733Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/75502974..a02d5ef7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I12e833bd76ce4de9293335c74f2da18b4b3b3e10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734831Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683930}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/747e495a62fa..b976207c9e04 Created with: gclient setdep -r src-internal@b976207c9e04 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: Iba6a8046c067f436af5731af0b3e6b57857aa65e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736263Reviewed-by:
-
Matt Falkenhagen authored
This fixes a race in the fast path taken by ServiceWorkerNavigationLoaderInterceptor when there is no in-scope registration for the navigation. In this path, the interceptor would elect to not handle the request, while posting a task to the IO thread to initialize the provider host. The navigation could commit before the provider host initialized. Before this CL ============== 1. The interceptor on the UI thread creates the inner interceptor and posts a task to the IO thread to start it. If there are no registrations, it also runs the callback with null, indicating it will not handle the request, so navigation continues. 2. The IO thread task creates the provider host and info. It sets the host in ServiceWorkerNavigationHandleCore and posts a task to pass info to the UI thread. 3. The UI thread task sets the info in ServiceWorkerNavigationHandle. 4. On navigation commit on the UI thread, the info from the navigation handle is sent to the renderer. The problem here is 3 and 4 can race, if the callback was run with null in step 1. After this CL ============= 1. The interceptor on the UI thread sets the info in ServiceWorkerNavigationHandle. As before, it creates the inner interceptor, and passes the other endpoints of the info to it, and as before, runs the callback with null if appropriate. 2. As before, the IO thread task creates the provider host, now binding it to the endpoints for info passed from the IO thread. It sets the host in ServiceWorkerNavigationHandleCore. 3. On navigation commit on the UI thread, the info from the navigation handle is sent to the renderer. Bug: 989863 Change-Id: I4c359827b28160fdb849621b1fdf547101b915ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734173 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#683928}
-
Tetsui Ohkubo authored
As ExoRawGamepadInfo is enabled by default since M77, we can now remove old code of ARC gamepad support. TEST=arc.Gamepad TEST=GamepadEventConverterEvdevTest BUG=b:138767224 Change-Id: I95649e34830c15b8a648a97702404de89e62c6d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728211 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Reviewed-by:
Mitsuru Oshima (OOO 8/5,6) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#683927}
-
Edvard Thörnros authored
This is the second commit in the series of updating all the old svg animation tests. The usage of testharness has replaced the older SVGAnimationTest.js for all where it's suitable. No functionality should have changed and the tests should cover almost the same. In all of the animations where there is a sampling at T=0, where it was assumed that no animations had started. Which didn't work flawlessly when moved to the new system. Bug: 985335 Change-Id: I789c1a020ee9004f4cfb7fe4292ba80f318aeeee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730904 Commit-Queue: Edvard Thörnros <edvardt@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#683926}
-
Moja Hsu authored
We need to reindex the entries of metadata after merge metadata from separated partial capture results. BUG=b:137810394 TEST=Check if we use correct index to get meatadata from 2nd partial result. Change-Id: I960276452175423aa238616013841ccb265e820c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735567Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Hsu Wei-Cheng <mojahsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#683925}
-
Miyoung Shin authored
This CL moves mojo files in //component/arc/common to //component/arc/mojom and replaces *_struct_traits.* to *_mojom_traits.*. *_struct_traits.* => *_mojom_traits.* //component/arc/common => //component/arc/mojom Bug: 806965 Change-Id: I4ac6131a6e0d4de60f58c5ef63b8cf6204084073 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699663 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
-
Takashi Toyoshima authored
This class should hold the BundledExchangesParserFactory instance so to keep the utility process alive. This fix leads a design change to pass a service connector at constructor rather than other open methods. Also, this adds an error check to SafeBundledExchangesParser::OpenFile. We could return a file open error and so on when BundledExchangesReader::ReadMetadata is called. Bug: 966753 Change-Id: I3174a88d0236f4afe0ebbad8348626800096b68d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732518Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#683923}
-
Matt Giuca authored
Has been failing on Linux MSan since it was introduced in r683785 (but reverting that would introduce a new crash, so disabling the test). Bug: 990691 Change-Id: I95513e01a39ebc66fdbac349406aca067e320ec5 Tbr: aboxhall@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734832Reviewed-by:
-
Alexey Baskakov authored
It allows BookmarkAppInstallFinalizer to mimic the "atomic write" of the web app into the registry (BookmarkAppRegistrar). The ideal behavior should match WebAppInstallFinalizer (that's our future): WebAppInstallFinalizer does real atomic write to disk (LevelDB) and registers the web app in WebAppRegistrar. Bug: 901226 Change-Id: Iaf9840cf02e9027f2822426c089a0b7a4e62803c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732700 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#683921}
-
Raymes Khoury authored
Currently chrome.management.installReplacementWebApp is only enabled for extensions. However we also want it to be usable from platform apps. Bug: 989799 Change-Id: I644c5bdff2aa53aa6af504388c9826b2375f1eb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735232Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#683920}
-
Kent Tamura authored
Implement element-type restriction for each of -webkit-appearance keywords. ComputedStyle::Appearnace() returns a parsed -webkit-appearance keyword as ever, and ComputedStyle::EffectiveAppearance() returns an appearance value which is the result of AdjustAppearanceWithElementType(). This CL has no behavior changes at this moment because the new behavior is behind the flag 'RestrictedWebkitAppearance'. Bug: 965432, 981720 Change-Id: Idb43bb98a67d081c1e843ad4d6658a1f3cd495bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735235Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#683919}
-
Christopher Lam authored
This CL makes the PendingAppManagerImpl unit test use the TestWebAppProvider paradigm for more consistent test flow. Bug: None Change-Id: Ifea2c7ebae72a87a75b75dfddb725e1d105033fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732699 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/dc85d3cb67d5..a56838e0ef52 git log dc85d3cb67d5..a56838e0ef52 --date=short --no-merges --format='%ad %ae %s' 2019-08-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader f63c4e51101a..060fcf777159 (3 commits) Created with: gclient setdep -r src/third_party/skia@a56838e0ef52 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@google.com Bug: chromium:None Change-Id: I06889cf76d7a8e75d06b48e56731118ae70e75e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735880Reviewed-by:
-
Alexandre Courbot authored
As we are about to introduce image processor support in the v4l2svda, a few members describing the output frame's format may now refer to the GL-capable device instead of the decoder. Add these members and use them where appropriate - since IP support is still lacking, for now they will always hold the same values as their decoder's counterpart. The V4L2VDA does something similar, albeit for EGL. Bug: b:132589320 Test: vdaunittest and vdatests pass on Minnie. Change-Id: I66ac72edeb0de279b30e486d54bd198dcf36a9e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730733Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#683916}
-
David Staessens authored
This CL fixes a small bug in the video_decode_accelerator_tests that can cause the video decoder tests to wait longer for an event than the maximum specified timeout. TEST=./video_decode_accelerator_tests on eve BUG=None Change-Id: I1febbf335afffc00166c3b5e21139367bc68ad91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735589Reviewed-by:
-
Leon Han authored
Previously watch ids were generated in the DeviceService. This CL switches to do that in Blink side, more specifically NFCProxy is responsible to generate/manage them, and still keeps their uniqueness over a given Mojo connection of device.mojom.NFC interface. This makes it easier for NFCProxy to track the set of active readers, specifically the 2 problems below can get solved. 1. a. NFCReader#start() --> device.mojom.NFC.Watch(options), we'll get the watch id via the response callback. b. in DeviceService the NFCImpl Watch() generates WATCH_ID_XXX and passes it back via the WatchResponse callback. c. in DeviceService NFCImpl gets a matched NDEFMessage from a NFC tag and call device.mojom.NFCClient.OnWatch(WATCH_ID_XXX, ndef_message). As NFC and NFCClient run on separated Mojo message pipes, the Mojo messages sent by the above a and b do not have any ordering guarantee, i.e. c may gets to NFCProxy earlier than b, then, because NFCProxy did not get WATCH_ID_XXX yet, it can not find the corresponding reader that should actually be the receiver of this NDEFMessage. 2. a. NFCReader#start() --> device.mojom.NFC.Watch(options) b. NFCReader#stop() --> can not call device.mojom.NFC.CancelWatch(id) because we did not get the watch id yet. c. the WATCH_ID_XXX for step a above comes back. This just leaves the watch session of WATCH_ID_XXX long live in NFCImpl without any chance to cancel it. BUG=520391 Change-Id: I136ee6aab54eb464e5dd684ed34a2d738d2f5198 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730515 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by:Reilly Grant <reillyg@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#683914}
-
David Staessens authored
This CL makes a small change to the VaapiVideoDecoder to not set the decoder thread's task runner and call set_parent_task_runner() on the video frame pool upon re-initialization. They are redundant and cause an assert in the video frame pool when executing in debug mode. TEST=./video_decode_accelerator_tests --use_vd on eve BUG=976507 Change-Id: Idb3712e5d835c4aa122ce7bc9f7efd2dd99600a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1686666 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
-
Matt Giuca authored
This reverts commit 6881d10f. Reason for revert: Introduces a use of uninitialized value. NativeThemeBase::PaintInnerSpinButton passes |arrow| to PaintArrowButton without initializing its |right_to_left| member. See https://crbug.com/990672 Original change's description: > Implemented fluent style for select multiple > > -Styled the in-page select, options, and optgroups via css. > -Modified the scrollbar to have rounded corners > (had to plumb the zoom factor through the Scrollbar so that the native > theme aura code can get the rounding correct at paint time) > > Bug: 987292 > Change-Id: Id11d1a47fe3d5b2be01aa578aa066f80577a9bbd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715553 > Commit-Queue: Allison Pastewka <alpastew@microsoft.com> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Mason Freed <masonfreed@chromium.org> > Cr-Commit-Position: refs/heads/master@{#683728} TBR=ellyjones@chromium.org,chrishtr@chromium.org,haraken@chromium.org,tkent@chromium.org,masonfreed@chromium.org,alpastew@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 987292, 990672 Change-Id: I778b09437c79061b23de1d5e8335c8f0cf124e12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735548Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#683912}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/bfc9cee5d3be..ccf805046ae3 git log bfc9cee5d3be..ccf805046ae3 --date=short --no-merges --format='%ad %ae %s' 2019-08-05 cwallez@chromium.org Make Snorm formats non-renderable Created with: gclient setdep -r src/third_party/dawn@ccf805046ae3 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I29712ded1a26da4e279006bf80abfb61961e247a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736226Reviewed-by:
-
Marina Sakai authored
Currently cross origin property returns the function of access source, but according to the HTML standard it should return the function of access destination when the origins are the same origin. This CL fixed the gap. Bug: 809011 Change-Id: I474083b22cc11c162dab1c14e41bc328c9cadcad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732751 Commit-Queue: Marina Sakai <marinasakai@google.com> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#683910}
-
Anand K. Mistry authored
Move the iron-dropdown element into the "suffix" slot of the cr-input. This allows for precise positioning of the dropdown element relative to the actual input field, as opposed to the cr-input as a whole (including label and error message). This change has two benefits: 1. It will allow the dropdown to be positioned immediately below the input, which is necessary to implement an updated UX. 2. It allows the dropdown position to properly adapt to changes in font size setting. BUG=977313,982230 Change-Id: I868063d9074ec8203b7c4f29c5d635be25a58412 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727550Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#683909}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f7a047eea7e8..747e495a62fa Created with: gclient setdep -r src-internal@747e495a62fa The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I4e20fdecfc6a1fc6088b42eb9bbb0596fa01fa1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736017Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ced601b40b37..dc85d3cb67d5 git log ced601b40b37..dc85d3cb67d5 --date=short --no-merges --format='%ad %ae %s' 2019-08-05 reed@google.com remove dead SK_SUPPORT_LEGACY_BICUBIC_FILTERING code Created with: gclient setdep -r src/third_party/skia@dc85d3cb67d5 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@google.com Bug: None Change-Id: Idc93ad9f54592a4461bc20fef29940d364c96b16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736018Reviewed-by:
-
Dominick Ng authored
Chrome's implementation of this web platform feature always requires a user gesture to trigger now. Remove the option and plumbing that passes the require_gesture boolean (which is now always set to true). TBR=mkwst@chromium.org BUG=869780 Change-Id: Iebdd435d8df3baf0996c01eda660b6074affde9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735089 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
-
Alexey Baskakov authored
This CL erases chrome/browser/extensions/bookmark_app_extension_util.cc completely. That's the last bookmark_app* prefixed file in extensions/. Cleaned up owners files. Bug: 973288 Change-Id: I1f1e094d8e64e9db75c49e4c6b7356124555810f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732170 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
-
Will Harris authored
This is causing crashes on some configurations and needs investigation. BUG=750886,990640 Change-Id: Idfdd06b219a95bed854cce9048860692ded011b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736106 Commit-Queue: Will Harris <wfh@chromium.org> Commit-Queue: James Forshaw <forshaw@chromium.org> Reviewed-by:
James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/master@{#683904}
-
tby authored
The original CL had a potential thread safety issue, which is fixed in this CL. This also adds a sequence checker to RecurrenceRanker to ensure this is fixed. PS1 is the original CL. PS2 is the fix and sequence checker. Original CL: crrev.com/c/1725032 Bug: 931149 Change-Id: Iaa5d87d38fa6a9bd5a5605b9feb9a5fd9154d3f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732269Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#683903}
-
