- 07 Dec, 2017 40 commits
-
-
Vaclav Brozek authored
If the settings do not show any saved passwords, the export button in the menu should still be present, but disabled. Note that the existence of "blacklisted" entries, i.e., entries where the user asked Chrome to never save a password, does not influence the state of the menu item, because those entries are not exported. Mocks: go chrome-pwd-export-mocks-android (currently slide 10, Google-internal only) General design: https://docs.google.com/a/chromium.org/document/d/1miKr2x0PTNIKgt3RQeur51ICQ66uszlYAmFXJONbG_0/edit?usp=sharing Bug: 788701 Change-Id: I1f5ad12eef9ef6ec1c9b0529c5b1ef16941c5298 Reviewed-on: https://chromium-review.googlesource.com/811186 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#522400}
-
Yuta Kitamura authored
Now WTF::Bind() returns base::OnceCallback, WTF::ConvertToBaseCallback() (for non-crossthread callbacks) is merely an identity function. This patch removes all the use sites of it in Blink. Note we still have WTF::ConvertToBaseCallback() for WTF::CrossThreadFunction, and it's not removed. Bug: 771087 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: If7903bd6fcef538999b42d5b0b31b7f23a19c34a Reviewed-on: https://chromium-review.googlesource.com/813654Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#522399}
-
Yuta Kitamura authored
WTF::RepeatingFunction is already an alias of base::RepeatingCallback. This patch replaces all the existing references to WTF::RepeatingFunction, completing the migration of WTF::RepeatingFunction. Bug: 771087 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I2d9f5264a0e5076bc6da8f2687188a5978bb18ca Reviewed-on: https://chromium-review.googlesource.com/813555Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
-
David Roger authored
Bug: 791948 Change-Id: Ie8f9c43ace98082e86d1bfbe01bc3ffe58a01fd6 Reviewed-on: https://chromium-review.googlesource.com/808979 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#522397}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/db654910e39e..16753e0633fc $ git log db654910e..16753e063 --date=short --no-merges --format='%ad %ae %s' 2017-12-06 perezju [Telemetry] Cleanup do_nothing forwarder Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Idb110e1206f7af95233a446b18a814f41232c621 Reviewed-on: https://chromium-review.googlesource.com/813595 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#522396}
-
Vaclav Brozek authored
This change adds a safeguard in PasswordReauthenticationFragment against repeated showing of the screen lock. If PasswordReauthenticationFragment gets killed during displaying the screen lock, this CL ensures that it won't attempt to display it again on re-creation. Bug: 791652 Change-Id: I7cc593906017bd059c6a4f3bd2b88d9b68488398 Reviewed-on: https://chromium-review.googlesource.com/806044 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
-
Dominik Röttsches authored
Previously a set if bechmark stories triggered the expensive glyph collection in GSUB and GPOS way too many times. This was found while investigating and hb_set performance issue 781794. browse:news:cnn triggered the call and GSUB/GPOS scanning method 1395 times, and was reduced to two. browse:news:hackernews 33 times reduced to 4, browse:social:twitter 58 times reduced to 4, browse:social:twitter_infinite_scroll 38 times reduced to 4 as well. We only need to do this work once per font face, independent of size - whereas previously it was once per Font object, which, depending on layout of the page, triggers much more frequently. Test: FontPlatformDataTest Bug: 791475 Change-Id: I15757abab2037677d5ea4c640ac26ab99da4649c Reviewed-on: https://chromium-review.googlesource.com/809106 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#522394}
-
Peter Collingbourne authored
The signal handlers interfere with the breakpad and sandbox tests, so we need to disable them there. We will also want to use the same set of UBSan options during executable tests as we do during instrumentation tests, so move the $UBSAN_OPTIONS value into the test harness, and pass it into the instrumentation test runner using a string extra. Bug: 469376 Change-Id: I76ffdd4a8221a54a23e257ac4d2321b8f28d2f42 Reviewed-on: https://chromium-review.googlesource.com/812982Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#522393}
-
Benoit Lize authored
Allows to collect profiling data from several page loads, and to scroll the screen while doing so. Bug: 758566 Change-Id: I4f0bb8fc167e69dea349dbd4b5ee733193996e41 Reviewed-on: https://chromium-review.googlesource.com/801016 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Reviewed-by:
Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#522392}
-
rhalavati@google.com authored
A temporary network traffic annotation tag is added to be used during refactoring of the socket classes. Network Traffic Annotation Auditor is updated to add this tag to reserved words and ignore it in tests. Bug: 690323 Change-Id: I79f570ced37a8572b6f495de478d18d998dc4189 Reviewed-on: https://chromium-review.googlesource.com/813674Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#522391}
-
Boris Sazonov authored
This CL switches the default state of AndroidSigninPromos feature to FEATURE_ENABLED_BY_DEFAULT. Bug: 792430 Change-Id: I09e7c26db6b899c593f69b9d459bbe03171a115b Reviewed-on: https://chromium-review.googlesource.com/810744Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#522390}
-
Hajime Hoshi authored
Bug: 765623 Change-Id: Ieaaa7a3f8fde471bb41a7af45ca0473d59f1a47b Reviewed-on: https://chromium-review.googlesource.com/672028Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
Refactor Tab (and its unit test) and WebControllerSnapshotHelper to directly use SnapshotCache (accessed via the SnapshotCacheFactory). Move -generateSnapshotForView:withRect:overlays: method (and helper functions) to WebControllerSnapshotHelper. Bug: 661642, 620465 Change-Id: Ie8cde629b99ca39b30cd1bc3354dac441cd5e562 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/810768Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#522388}
-
Eugene But authored
This method is not called and is probaly a cruft from CRWWebDelegate. Bug: 681867 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib6dd682c5889b540008b6807ffdc0bbd07ac83e4 Reviewed-on: https://chromium-review.googlesource.com/811291 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#522387}
-
chromeos-commit-bot@chromium.org authored
TBR=chrome-os-gardeners@google.com Change-Id: If89b985dc9be0a8b525a8d4dc1e807d3b0baeea1 Reviewed-on: https://chromium-review.googlesource.com/812548Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#522386}
-
Eddy Mead authored
Bug: 752745 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I43c650c37c33cb92d500e5e82d437f24faf6287a Reviewed-on: https://chromium-review.googlesource.com/795515Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Commit-Queue: meade_UTC10 <meade@chromium.org> Cr-Commit-Position: refs/heads/master@{#522385}
-
Makoto Shimazu authored
Currently ServiceWorkerVersion clears |pending_requests_| but not |request_timeouts_|, and it causes inconsistency after restart. This patch fixes it. Bug: 791451 Change-Id: I50778a81ab31d1094db5776a49137c0196c1fb5f Reviewed-on: https://chromium-review.googlesource.com/807835 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#522384}
-
Katie Dektar authored
This fixes a bug where the first time you open the select-to-speak settings page the highlight color drop-down doesn't have a color selected. Bug: 792728 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic6f1653d8108e5d47fdc48c555eb55c0bbed51d8 Reviewed-on: https://chromium-review.googlesource.com/812426 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#522383}
-
Hajime Hoshi authored
This is part of efforts to replace base::ThreadTaskRunnerHandle::Get() with other appropriate task runners in the renderer. Bug: 786332 Change-Id: I71f58741822d6515d72210b93edba326c84f89b9 Reviewed-on: https://chromium-review.googlesource.com/807867Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
-
Zhuoyu Qian authored
This patch makes ContentPosition and ContentDistributionType to be enum classes for better type safety. Bug: 684966 Signed-off-by:
Zhuoyu Qian <zhuoyu.qian@samsung.com> Change-Id: Id316e846b10d1aa5316fab78eb1189ce542a1404 Reviewed-on: https://chromium-review.googlesource.com/810406Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#522381}
-
Alexander Shalamov authored
This CL reverses axis signs for gyroscope, magnetometer and absolute orientation sensors. Before the change, wrong coordinate system was used based on the accelerometer's data. Integrating Motion and Orientation Sensors [1] document, explains what coordinate system must be used and why accelerometer's measurements differ from other platforms. [1] https://msdn.microsoft.com/en-us/library/windows/hardware/dn642102(v=vs.85).aspx Bug: 786252 Change-Id: I4afbc1a1d5fb03c3e2e0538a8ea7424c40020eca Reviewed-on: https://chromium-review.googlesource.com/804624Reviewed-by:
Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Jun Cai <juncai@chromium.org> Commit-Queue: Alexander Shalamov <alexander.shalamov@intel.com> Cr-Commit-Position: refs/heads/master@{#522380}
-
Mirko Bonadei authored
WebRTC is stopping to use `public_deps` in its targets. In https://webrtc-review.googlesource.com/c/src/+/29864 the removal of the public dependency from //third_party/webrtc/pc:peerconnection on //third_party/api:libjingle_peerconnection_api causes some errors in the 'gn analyze' step of Chromium bots. This CL is a forward compatible fix to allow WebRTC to land its CL. Bug: webrtc:8603 Change-Id: Iab1b80a90e0fc6557e079274b3d3871fea01d811 Reviewed-on: https://chromium-review.googlesource.com/810968Reviewed-by:
-
Hitoshi Yoshida authored
This CL defines a new set of Web IDL based classes under web_idl/. Collecitor class is the main API, which reads IDL files and stacks converted information. This CL also updates some BUILD.gn files to generate an intermediate dump file per component, which includes all information in IDL files in the component. Bug: 650150, 727971, 579896 Change-Id: Idc98be4485855afc7797b7fc3af21fb7ee68f0ed Reviewed-on: https://chromium-review.googlesource.com/648534 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#522378}
-
Alexandr Ilin authored
This reverts commit 844e4a30. Reason for revert: The bug that caused a compilation error if DCHECKs is off is fixed. Original change's description: > Revert "Replace WTF::Function with base::OnceCallback." > > This reverts commit d298a4dd. > > Reason for revert: > > Findit (https://goo.gl/kROfz5) identified CL at revision 521649 as the > culprit for failures in the build cycles as shown on: > https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2QyOThhNGRkNzMyZjA5YzlhMWMzMDZhMjA2NTA3YzEyM2EzNzYxZTIM > > Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Linux%20x64/24801 > > Change-Id: I60fec5e188923122bb3b090acc49cfd0f0363df1 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 771087 > Reviewed-on: https://chromium-review.googlesource.com/808224 > Cr-Commit-Position: refs/heads/master@{#521653} TBR=haraken@chromium.org,tzik@chromium.org Bug: 771087 Change-Id: I0b74afe02f37d128acfe909fc5027f68afedf773 Reviewed-on: https://chromium-review.googlesource.com/808704 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#522377}
-
tzik authored
This CL changes the ownership of base::Clock and base::TickClock from injectee-owned to injecter-owned. Before this CL, these instances are owned by the owner of the injectee or one of the injectees themselves. That makes the ownership complex. After this CL, the clock instances are always un-owned by injectees. Instead, an injecter owned one is used on testing, and the shared instance is used on production path. Bug: 789079 Change-Id: I155e0e7cbbd79340bbb0fe03b0f2697729c1cd71 Reviewed-on: https://chromium-review.googlesource.com/795280 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#522376}
-
Blake O'Hare authored
This observer method is redundant with the other methods. However it seems that some of the implementations are querying multiple aspects of the keyboard and performing an action based on that. For example, the Arc IME needs to know both changes in availability and the occluded bounds at the same time. Using the methods currently provided is unviable because it would require tracking state between the two calls and then invoking the system call to ARC++ once both calls have completed. This is cumbersome. In addition to this, I'd also like to eliminate direct calls to KeyboardController::GetInstance()->keyboard_locked() and so I am putting this property into the struct of this notification as well. There are only a couple of usages where this pattern is necessary and so most consumers should simply use the more specific existing methods. Bug: 786290 Change-Id: I3e2db92273f0a144c87caef29b860cb6b7f83995 Reviewed-on: https://chromium-review.googlesource.com/813147Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Blake O'Hare <blakeo@chromium.org> Cr-Commit-Position: refs/heads/master@{#522375}
-
Brett Wilson authored
This functions concatenate many strings at once, resulting in ~3x code size and >2x speed improvement compared to a sequence of "operator+". Some calls to JoinString that used an empty separator are replaced with the new StrCat function. I considered generating many overrides with different numbers of arguments. This generates different code. In some cases I observed the compiler generating more code vs. initializer_list, in others it seemed to generate slightly less. Even when it generates a little more code having a much simpler header file seemed preferable so I opted for the initializer list. Change-Id: Ie0fb52aabf60ad30ead55bdbeca1e586b33950fd Reviewed-on: https://chromium-review.googlesource.com/805115 Commit-Queue: Brett Wilson <brettw@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#522374}
-
tzik authored
This CL changes the ownership of base::Clock and base::TickClock from injectee-owned to injecter-owned. Before this CL, these instances are owned by the owner of the injectee or one of the injectees themselves. That makes the ownership complex. After this CL, the clock instances are always un-owned by injectees. Instead, an injecter owned one is used on testing, and the shared instance is used on production path. Bug: 789079 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I19fe124cf9b0a9f3c229d5e209352384930ebc1b Reviewed-on: https://chromium-review.googlesource.com/795272 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#522373}
-
Kunihiko Sakamoto authored
TBR=warx@chromium.org Bug: 665296 Change-Id: I69c487f17ce5ee1170fd7f1dc190b2f185e3643f Reviewed-on: https://chromium-review.googlesource.com/813457Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#522372}
-
Khushal authored
If the unbound state is invalid, cloning the connector can fail and returns null. Instead create a new Connector with invalid state to avoid having callers guard against this case. R=rockot@chromium.org Bug: 792340 Change-Id: I39ba3253048f4599586d0fb94d7f1d91404f1ace Reviewed-on: https://chromium-review.googlesource.com/812498 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#522371}
-
Luciano Pacheco authored
Convert FrameHostMsg_DidChangeName, FrameHostMsg_DidSetFramePolicyHeaders and FrameHostMsg_EnforceInsecureRequestPolicy from IPC calls to mojo. Create mojo conversions for enum FeaturePolicyFeature and struct ParsedFeaturePolicyDeclaration. Update third_party/WebKit/common/feature_policy/OWNERS with IPC SECURITY_OWNERS settings for new mojo files. Bug: 786836 Change-Id: I18d18956197d3c7c5a713c61dd9856c8a31c06f7 Reviewed-on: https://chromium-review.googlesource.com/784372 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#522370}
-
Victor Costan authored
This is extracted from the WASM + IndexedDB code into a separate CL, for better reviewability. Serializing WASM modules will add a format to the value-wrapping logic, pushing the total complexity to the point where the benefits of having clearly separated lifecycle steps for IDBValueWrapper exceed the benefits of having a terse API. Therefore, this CL introduces a clear separation between the stages of an IDBValueWrapper's lifecycle, which are: 1) Cloning (a structured clone may be needed to compute index values) 2) Wrapping 3) Extracting information for the backend -- the data bytes and the Blob list The CL also introduces logic for including byte vectors in wrappers, which will be needed for the V8 snapshot version -- details in https://docs.google.com/document/d/1IgUeRLza0WC3uAzXxla5rH1bs5jUHKbLjsfU--zdYag Last, this CL makes it possible to call IDBValueWrapper::WrapIfBiggerThan() multiple times, which will come in handy for the new wrapping format -- details in https://crrev.com/c/709596/17/third_party/WebKit/Source/modules/indexeddb/IDBValueWrapping.cpp Bug: 719007 Change-Id: Ie74ddfd4ec849d4777ab9a3af5dc254fc5b14837 Reviewed-on: https://chromium-review.googlesource.com/804969 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#522369}
-
Koji Ishii authored
Following bot results are included. 2395 2396 2399 2400 2405 2407 2414 2415 2417 2419 2422 9 lines were removed by consecutive passes since 2387. TBR=eae@chromium.org NOTRY=true Bug: 591099 Change-Id: I3ddab203ddb73e8c0a11268c6f71ee1810ad9087 Reviewed-on: https://chromium-review.googlesource.com/813143 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#522368}
-
Yuta Kitamura authored
We are now mostly ready to start replacing WTF::Function with base callbacks. This patch updates DEPS and audit-non-blink-usage.py so we can use base callback stuff in Blink. Bug: 771087, 763980 Change-Id: I8b41ab2c3e9e72279039685960b6dd1b558ee457 Reviewed-on: https://chromium-review.googlesource.com/807754Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5ce45836..b463eed7 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Id5a2274d54acd2bf5d6f7d4e12cac2e73a64f663 Reviewed-on: https://chromium-review.googlesource.com/812997Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#522366}
-
tanvir.rizvi authored
Minor typo fix in EditorCommand.cpp Replaced ModifySelectionyWithPageGranularity with ModifySelectionWithPageGranularity. Bug: Change-Id: I5f1f60c7788b0e5b4a483d01434b640cfe1d67b8 Reviewed-on: https://chromium-review.googlesource.com/811024 Commit-Queue: yosin (OOO Dec 11 to Jan 8) <yosin@chromium.org> Reviewed-by:
yosin (OOO Dec 11 to Jan 8) <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#522365}
-
Eve Martin-Jones authored
Bug: Change-Id: I65ea69fbd0ab29b29ffd13f7c61fd47a12bda5df Reviewed-on: https://chromium-review.googlesource.com/812305Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Commit-Queue: Eve Martin-Jones <evem@chromium.org> Cr-Commit-Position: refs/heads/master@{#522364}
-
Eve Martin-Jones authored
This change is for files in the path //third_party/WebKit/Source/core/style/. Added the include for base/macros.h where needed and moved the macro to the end of the class as per the code guidelines enforced by lint. This CL introduces no logic changes. Bug: 565932 Change-Id: I83e5103f69e36fbd39d227d6c5153cc14be8225c Reviewed-on: https://chromium-review.googlesource.com/813136Reviewed-by:
-
Raymes Khoury authored
This adds more tests to SearchPermissionsService to test: -The cases where the kGrantNotificationsToDSE flag is disabled -The case where the kGrantNotificationsToDSE is enabled and then changes back to disabled. This also fixes a bug where resetting DSE notifications permissions would happen even when the feature flag was disabled. Bug: 799534 Change-Id: I907f03308936a1a502fa9fba04aae80325c3a3ee Reviewed-on: https://chromium-review.googlesource.com/813140Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#522362}
-
Eve Martin-Jones authored
This change is for files in the path //third_party/WebKit/Source/core/clipboard/. Added the include for base/macros.h where needed and moved the macro to the end of the class as per the code guidelines enforced by lint. This CL introduces no logic changes. Bug: 565932 Change-Id: Ie725fb237db6d86efc373e415c7dfbf4dea42a2f Reviewed-on: https://chromium-review.googlesource.com/812366Reviewed-by:
-
