- 25 Mar, 2020 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1aff54a5..754d46b1 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibbb6152a21d4d6fdfd55ce6572b607de7d53c781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119311Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753360}
-
Omer Katz authored
This reverts commit 2f69de56. Reason for revert: quick resolution to issue 1059655 Original change's description: > heap: Enable concurrent marking for HashTable based collections > > All known data races in HashTable based collections have been resolved. > > Bug: 986235 > Change-Id: Ia7a22d707aaaea1ab3ebc70c47da0876fc426aa9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078617 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Omer Katz <omerkatz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#746694} TBR=haraken@chromium.org,mlippautz@chromium.org,omerkatz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 986235 Change-Id: Ia3e3f4ef5dd20c4826b3a8a96adc33c3401e5eb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120477Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#753359}
-
Brian Sheedy authored
Increases the sharding values for chrome_public_test_vr_apk-ddready-ddview and chrome_public_test_vr_apk-ddready-cardboard. The tests are currently taking about 54 and 21 minutes to run, respectively, so the sharding values are increased to get the per-shard runtime down to the 10-15 minute range. Change-Id: I34fd76dc643e06d166559496016ae530000e9f57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118697 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#753358}
-
Jarryd authored
This histogram tracks whether or not the user even uses the installed app warning dialog. This metric will make it easier for us to see if it's worth keeping this extra dialog, which is extra friction in the clear browsing data flow. Bug: 997258 Change-Id: I8e4235ca901a0b44ded4f62efe29388b03e1d2b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116310Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#753357}
-
Antonio Gomes authored
Original patch: https://bugs.webkit.org/show_bug.cgi?id=92667 BUG=1063749 R=dgrogan@chromium.org, robertma@chromium.org Change-Id: Ie6d3152184e6c944e0657df1b9ed5fd2364cfa2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120853 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
David Grogan <dgrogan@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#753356}
-
Ted Choc authored
BUG= Change-Id: Ic4dd009f130a46c39af547d7e045783f061f18ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113791Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#753355}
-
Lukasz Anforowicz authored
This CL deletes CrossOriginXHR.AllURLs and replaces it with a new CrossOriginReadBlockingExtensionAllowlistingTest FromProgrammaticContentScript_PermissionToAllUrls test. Notes: *) The <all_urls> aspect is the only difference between the new test and the old test at FromProgrammaticContentScript_NoSniffXml. Still, it seems worthwhile to preserve test coverage of the <all_urls> aspect even though this aspect is also covered somewhat by the unit tests that were tweaked by https://codereview.chromium.org/8138004/ *) The old/deleted test was introduced in https://codereview.chromium.org/8138004/ which was fixing https://crbug.com/98418. Initially the manifest.json of the test had a "plugins" entry, but this aspect of the test was removed by r521122. *) I don't really understand why there were 2 test cases in the deleted test (domainOne and domainTwo). I also don't understand the navigate-and-then-retest aspect (mentioned in the repro steps of https://crbug.com/98418 but not really covered by the deleted test). Bug: 1061567 Change-Id: Idcbd4a0908aeb094391deaafc941ee482e7abb03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106448 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#753354}
-
David Tseng authored
Unfortunately, to resolve base::Location for each api call, we cannot support chaining. However, shortening the variable name for |speech_monitor_| to |sm_| and not having to indent, we actually save some indent space. Also, this change now includes all pending utterances (for understanding the state when the test is waiting). Sample output: [158567:158567:0325/082550.588956:ERROR:speech_monitor.cc(276)] Still waiting for expectation(s). Unsatisfied expectations... ExpectSpeech("Fail!Rate 19 percent") RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:931 Call() RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:933 ExpectSpeech("Pitch 50 percent") RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:934 Call() RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:936 ExpectSpeech("Reset text to speech settings to default values") RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:938 Call() RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:941 ExpectSpeech("Rate 19 percent") RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:942 Call() RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:943 ExpectSpeech("Pitch 50 percent") RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:944 pending speech utterances... Volume 100 percent Rate 19 percent Satisfied expectations... Call() RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:926 ExpectSpeech("Reset text to speech settings to default values") RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:928 Call() RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:930 Change-Id: If1bdbfb517014e681cb233800eab3f62f608188f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120741Reviewed-by:Akihiro Ota <akihiroota@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#753353}
-
Camillo Bruni authored
The ParametrizedModuleHelper can be used to parametrize existing tests to run both with kTopLevelAwait enabled and disabled. Additionally ParamatrizedModuleTestParamName is provided for better better test names when using the INSTANTIATE_TEST_SUITE_P macro. Bug: 1022182, v8:9344 Change-Id: Ib263ebe46d523ef7967bd3392546bcf31b4da287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105378 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#753352}
-
Peng Huang authored
This reverts commit 3bb52934. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1064732 Original change's description: > Fix use of invalid DisplaySnapshot pointer while updating HDCP > > HDCP updates are asynchronous. Do not pass display state pointers > between async calls since display configuration may have changed. > > Instead query the display state and validate that the requested > displays are valid. > > BUG=1058030 > TEST=display_unittest > > Change-Id: I7e037a44f06156b5b1da3f2672330ba8a18ca950 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118771 > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753203} TBR=oshima@chromium.org,dnicoara@chromium.org Change-Id: I57fd6ee3708900914c15e8b844dc8ad772ec35e1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1058030 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121084Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#753351}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/0eff2a2b463f..046389926f10 git log 0eff2a2b463f..046389926f10 --date=short --first-parent --format='%ad %ae %s' 2020-03-25 bryan.bernhart@intel.com D3D12: Add end2end tests for small shader-visible heaps. Created with: gclient setdep -r src/third_party/dawn@046389926f10 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Id5fd4a298854aa8449fdc06fb11283071dfdc3ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120904Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753350}
-
Xiaocheng Hu authored
SVG use elements with data URI may carry arbitrary content. Hence, we also sanitize it before pasting it into document. Bug: 1040755 Change-Id: Iad8701174c7c0f13dc5affb9e011d645990ef754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119198 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#753349}
-
Dana Fried authored
Convenience method for debugging and testing, similar to most other geometry and small data structs in Chrome. Change-Id: Ic5ad787f8b361c5b5a25b71dce2db6dbae4b8731 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116555Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#753348}
-
Jeremy Apthorp authored
This allows customizing the prototype of the constructed object. Change-Id: Id302d6f3202468963f6659e6df64726bb6bdc9d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119183 Commit-Queue: Jeremy Apthorp <jeremya@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#753347}
-
Kyle Milka authored
Record a metric that tracks the time from a share being initiated until the user selects a share target. Bug: 1009124 Change-Id: If32a3f36ed27f4224b2352c4e9348d89b43e3a74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117315 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#753346}
-
Chris Hamilton authored
Since M69 it has been possible for tabs to restore and not be loaded for an indefinite period of time. This new tab state was not reflected in the tabs extension API. Concretely, this adds a third "unloaded" state to the "status" enum, which previously was one of "loading" or "complete". BUG=1061209 Change-Id: Icadb41fe033ae47630affeabffb38fa5b3e9d79e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105564 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#753345}
-
Alexander Cooper authored
Moves the XrConsentHelper and XrConsentPromptLevel interfaces to content/public and moves the windows-specific implementation out of chrome/browser/vr/service. Creates a wrapper method for the windows- specific singleton to better fit the pattern of the other consent helpers. Note that the XrConsentHelpers are currently disabled by default and intended to be removed once the switch to use permissions has shipped, but due to the current release changes, this is looking further out. Thus, these methods are moved temporarily to enable VRService to move. Bug: 1031622 Change-Id: I54b0ee16d27e0cf95dbe562e064e0f24b7ac30e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118579 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#753344}
-
Ahmed authored
This CL adds a flag to enable users, who prefer, to limit the windows in Alt-Tab to the ones in the current active desk. The flag is disabled by default. BUG=1023445 TEST=Manually, Added a new test. Change-Id: I343e724eb5d01e3ec3521af446e4669178acbb76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118830 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#753343}
-
Caleb Rouleau authored
tools/perf/OWNERS: John is now TL and primary reviewer. update_wpr: John will review these. media_cases: John and I aren't on this team anymore. Change-Id: I95a11c1bb62e74670142a2b30def3884e4f9acbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120749 Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#753342}
-
Robbie McElrath authored
This CL removes the ANDROID_SITE_SETTINGS_UI_REFRESH feature, which has been enabled by default since April 2019. This removes a dependency on //chrome from site settings, which will help componentize it for WebLayer. Bug: 1058597, 1057950 Change-Id: I85d34ef3f46fb59490f07d35def2a15084714809 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103395 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Kamila Hasanbega <hkamila@chromium.org> Cr-Commit-Position: refs/heads/master@{#753341}
-
Matt Menke authored
It's no longer used. Also remove the net/ callback methods used to invoke it. Bug: None Change-Id: I0fe0dea935c1ea36257275a9d1449e951d37f414 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116892Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#753340}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f11e33152460..988ce0490a11 git log f11e33152460..988ce0490a11 --date=short --first-parent --format='%ad %ae %s' 2020-03-25 kjlubick@google.com remove localmatrix parameter from Blend and Lerp compose shaders 2020-03-25 csmartdalton@google.com Properly detect integer support on WebGL 2.0 2020-03-25 csmartdalton@google.com Bootstrap a very simple viewer implementation in CanvasKit 2020-03-25 csmartdalton@google.com Don't add offsets to nullptr in GrGLOpsRenderPass Created with: gclient setdep -r src/third_party/skia@988ce0490a11 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: Ifc188c636f91ea3f2adad39fff76df14ccf8cebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120903Reviewed-by:
-
Theresa Wellington authored
Add FLAG_ACTIVITY_NEW_TASK to intents used to launch new activities in TabModelMergintTest, and reenable #testMergeOnColdStartIntoChromeTabbedActivity2 on Pie. BUG=1036551 Change-Id: I995f1f4e5aeeb0c533e55fc9b8000e534613e9aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120748 Auto-Submit: Theresa <twellington@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#753338}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0eb6932a. With Chromium commits locally applied on WPT: bb6643e9 "Simplify image-loading-subpixel-clip.html." d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I31d07fd5ba99d9a0cb7a9714fccba99f778ec728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120793Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753337}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4504b6a42842..21a3f16268e9 git log 4504b6a42842..21a3f16268e9 --date=short --first-parent --format='%ad %ae %s' 2020-03-25 treehugger-gerrit@google.com Merge "Include progname in malloc hook logs." 2020-03-25 treehugger-gerrit@google.com Merge "Acknowledge flushes / stop with unknown data sources." Created with: gclient setdep -r src/third_party/perfetto@21a3f16268e9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ie8afd80901cbd6ac93be83b7f4d27f6be2ee6ca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120902Reviewed-by:
-
Brian Cui authored
This small CL disables the elements-tab-stops test in order to land DevTools Settings discoverability improvements [1]. [1] adds a new Settings button to the top-level toolbar, which appears as a tab-stop in this test. [2] fixes the test so that the new tab stop is in the expectations file. [1] https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2049183 [2] https://chromium-review.googlesource.com/c/chromium/src/+/2118870 Bug: 1050855 Change-Id: I6fd5386f84220f22d00e54255a7bdcfe8b4cb9e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117328 Commit-Queue: Brian Cui <brcui@microsoft.com> Auto-Submit: Brian Cui <brcui@microsoft.com> Reviewed-by:
John Emau <John.Emau@microsoft.com> Cr-Commit-Position: refs/heads/master@{#753335}
-
Kevin Ellis authored
Disabling the tests pending a more thorough investigation into the underlying causes. Bug: 1064065, 1064127, 1064463 Change-Id: I1748cd23f1509bbc8ea4b7b37a1cac27f8b74dab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120745 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#753334}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/540bdf92531d..8cef397d7dec git log 540bdf92531d..8cef397d7dec --date=short --first-parent --format='%ad %ae %s' 2020-03-25 bclayton@google.com CMake: Don't export LLVM_INCLUDE_DIR to PARENT_SCOPE 2020-03-25 bclayton@google.com CMake: Move LLVM rules out to third_party/llvm-7.0 2020-03-25 bclayton@google.com Add missing copyright header to CMakeLists.txt Created with: gclient setdep -r src/third_party/swiftshader@8cef397d7dec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I3504ce618e05eaa4c9bc9904ae74001e18259b56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120901Reviewed-by:
-
Elly Fong-Jones authored
A common problem when writing integration tests for Views UI is that the involved UI is hidden behind an interface which hides the Widget, since it is usually an implementation detail. Specifically, it is common to have a function like so: static void MyDialog::Show(...); which internally creates a Widget, initializes it, shows it, etc, and invokes some callbacks or notifies some controller when the Widget is done. However, this makes it difficult for tests that expect to touch that UI to actually get ahold of it, which leads to various hacky approaches, like adding globals to track the last Widget created by MyDialog and similar. However, even this hack is considerably ugly when the UI is instead shown via something like: MyController::WaitUntilReadyAndThenShow(...); because the test can rarely tell when the UI is actually being displayed, which results in ad-hoc things like spinning the RunLoop a set number of times. To achieve that, this change: 1) Adds a class AnyWidgetObserver, which can be used to observe events that happen on any Widget instance without needing to specifically register for that Widget instance; 2) Adds a class AnyWidgetObserverSingleton, which is what the AnyWidgetObservers actually register as observers of; 3) Has Widget notify AnyWidgetObserverSingleton of various interesting events; 4) Adds some tests for AnyWidgetObserver. Bug: None Change-Id: I36c9b3c59bcae3bbe889731720e797339e5675d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110812Reviewed-by:
Dana Fried <dfried@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#753332}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d34983e8718f..26abd91781d5 Created with: gclient setdep -r src-internal@26abd91781d5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1063994 Tbr: jbudorick@google.com Change-Id: If6aa1eeae014894160f0793de7e3ce40d12880ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120900Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753331}
-
Chris Harrelson authored
Bug: 1043619 Change-Id: I8a9a1c5f1c7a51e83685aebc02a336ffab6a8011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116936Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#753330}
-
Michael Thiessen authored
Calls to GURL#ensureNativeInitializedForGURL are much more common than anticipated (~7% of startups according to UMA), but I'm unable to hit this during startup locally, so I'd like to collect stacks from Canary to see where users are hitting this. Bug: 783819 Change-Id: If9b3681c9b6c786be77c5f1e82c8a7c757fdecf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120916Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#753329}
-
Nektarios Paisios authored
The use of ComPtr::GetAddressOf is banned see http://crbug.com/914910 Either the "&" operator or the ReleaseAndGetAddressOf method should be used. Also, the "CopyTo" method could be replaced with the "As" method which is easier to type and call. R=aleventhal@chromium.org, kbabbitt@microsoft.com RelNotes: N/A Bug: 914910 Change-Id: I4fda494dfe9d51247bd7e82c9ec80b3e5ad5813f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120093 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#753328}
-
Victor Costan authored
This is a scaffolding CL for NativeIO, a.k.a. Low-Level Storage. Most details will probably change over time, but the overall architecture is intended to be stable. To facilitate review, this CL aims to introduce enough aspects of the API for readers to reason about IPC security and general architectural concerns in the browser and in Blink. The summary below is also intended to facilitate review. * NativeIO introduces new per-origin storage. The per-origin model matches other existing storage APIs, so no new permissions are added. * NativeIO storage is structured as files in a flat per-origin namespace. Files are stored in a per-origin directory under the user's profile. * The browser-side implementation enforces access control at the file level. Once a renderer is allowed to open a file, the browser passes the file descriptor to the renderer. This approach aims to minimize the latency of I/O operations. * The renderer exposes two API flavors to web pages -- an asynchronous version and a synchronous version. The latter is only available in dedicated workers. The goal is to allow developers to experiment with both flavors of the API, and report back on performance and stability. * In the asynchronous API, all file I/O is done on tasks posted to Blink's worker thread pool. This avoids jank on the main thread, at the cost of two thread hops per I/O operation. This CL adds two READMEs with some minimal information. * //third_party/blink/renderer/modules/native_io/README.md * //third_party/blink/web_tests/external/wpt/native-io/README.md An API explainer is available at https://github.com/fivedots/nativeio-explainer Binary-Size: New Web Platform feature. Fugu P1. Bug: 914488 Change-Id: I2c8c794837c5332d81bfbab2ed0827e1f26f7cf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093918 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#753327}
-
Aaron Gable authored
This reverts commit c00c874f. Reason for revert: Caused compile failures on non-RBE Goma See o/51853436 for context. See https://ci.chromium.org/p/chromium/builders/ci/ios-simulator-cronet/103497 for sample failure. Original change's description: > clang build.py: change LLVM_ENABLE_ZLIB from ON to FORCE_ON > > This uses the FORCE_ON option to enable zlib to ensure that clang > actually finds and uses zlib. Also moved this setting out of > base_cmake_args so that it is only used in the main clang build, > since there is another 32-bit build that can't use this zlib. > > Also changed to remove and re-download the zlib source on > every build. > > Change-Id: Ifceabc2ba06e4e4a56464f18de80610a0f043641 > Bug: 1061189 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118674 > Commit-Queue: Amy Huang <akhuang@google.com> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753301} TBR=thakis@chromium.org,hans@chromium.org,rnk@chromium.org,akhuang@google.com Change-Id: I9dad136109c540c0c700d67632573639b2596e5c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1061189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121078Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#753326}
-
Michael Thiessen authored
There were some formatting errors that caused information to be missed, and I've added some clarifying examples, details, and debugging tips. Change-Id: I7dc35b1fe6085339aedcbdae91ba1af635d5dc5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121037Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#753325}
-
Olga Gerchikov authored
Bug: 1058888 Change-Id: Id09b04349960c2b8a47fa30c5c2a67b8ad8b4cc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119254Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/bdb8301ab9c1..4a1f482cf07e git log bdb8301ab9c1..4a1f482cf07e --date=short --first-parent --format='%ad %ae %s' 2020-03-25 khokhlov@google.com [tracing] Ignore renderers without mainThread when computing metrics Created with: gclient setdep -r src/third_party/catapult@4a1f482cf07e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1059726 Tbr: skyostil@google.com Change-Id: I84b7e48c5c5881f83e52736197d9b75672d913f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120897Reviewed-by:
-
Sahel Sharify authored
This is a reland of 352154b4 Original change's description: > [Payments][Android] Move PayerData.java into components/payments/.. > > This cl moves PayerData.java class into components/payments so that > the WebPaymentIntentHelper.java class can use it without depending on > chrome/browser. It also introduces a new Address class and its > converter utility class so that PayerData.java does not depend on > mojom.PaymentAddress. > > Change-Id: Idb737bc2697212af7542d3abbd1488461a7d3074 > Bug: 1026667 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110678 > Commit-Queue: Sahel Sharify <sahel@chromium.org> > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#752597} TBR=kenrb@chromium.org,rouslan@chromium.org Bug: 1026667 Change-Id: I2d7eb6016a51060ae10d6d9aed73eba841aea68c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120963Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#753322}
-
Omer Katz authored
This reverts commit 5dba9870. Reason for revert: quick resolution to regressions in issue 1063593 Original change's description: > heap: Trace Vector buffer up to capacity > > Tracing to capacity means we don't need to check size_ during > tracing anymore. > > Bug: 986235 > Change-Id: Idae046fcbb6a1705c1522d56479d560091415ea4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107983 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Omer Katz <omerkatz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#751353} TBR=haraken@chromium.org,mlippautz@chromium.org,omerkatz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 986235 Change-Id: Ib5b207d4f81966fae2f2522bd1c806071ff82c55 Tbr: haraken@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119519 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
