GitLab

This reverts commit d8a530f9.

Reason for reland: initial CL had a bug when a native nested loop
goes idle multiple times in a row. It needs to be able to reuse the
existing native timer instead of assuming there isn't one (there won't
be one the first time the native loop goes idle but there'll be one
one all other idle phases unless we're out of delayed tasks).

Original change's description:
> Revert "[base] Migrate the Win MessagePump to DoSomeWork"
>
> This reverts commit 8c5fb8cb.
>
> Reason for revert: DCHECK(!installed_native_timer_); in dev builds
> when moving and resizing windows. Seems interactive_ui_tests might
> not cover those cases..?
>
> Original change's description:
> > [base] Migrate the Win MessagePump to DoSomeWork
> >
> > This CL migrates both MessagePumpForUI and ForIO as they use the same
> > base class and it's easier to do both at once.
> >
> > Tweaks to MessagePumpBase and/or both pumps:
> >  * Use DoSomeWork() instead of DoWork()/DoDelatedWork()
> >  * Replace |delayed_work_time_| by a timeout value computed on the stack
> >    from the result of DoSomeWork(). Conversely making
> >    ScheduleDelayedWork() a no-op as desired.
> >  * Refactor GetCurrentDelay() into GetSleepTimeoutMs() and use modern
> >    safe_conversions.h to perform the math.
> >
> > MessagePumpForUI specific tweaks:
> >  * Fixed crbug.com/929263: ::SetTimer() used 0 as an nIDEvent but
> >    ::KillTimer() used |this| so they weren't even interacting...
> >  * Fixed bug: even with the previous bug fixed. HandleTimerMessage()
> >    could be invoked while in a non-native DoRunLoop() (e.g. since
> >    KillTimer doesn't remove WM_TIMER messages already enqueued) and as
> >    such result in redundant sources of scheduling since it would then
> >    continue to RescheduleTimer() and confusing state for DoRunLoop()).
> >  * Ignore WM_TIMER messages which weren't scheduled by our ::SetTimer().
> >  * Simplified usage of native ::SetTimer(). We now *only* rely on it
> >    when in a native nested loop and kill it immediately after to avoid
> >    double-scheduling.
> >
> > Note: MessageLoopTest.PostDelayedTask_SharedTimer_SubPump tests the
> > necessity for a native timer when entering a native nested loop and
> > confirms that the new behavior is WAI.
> >
> > Also adding regression tests for a tricky use case (and finding that
> > it's already broken on ToT..!). Filed crbug.com/930940 to follow-up.

(regression tests relanded separately in crrev.com/631918)

> >
> > Bug: 885371, 929263, 930940
> > Change-Id: I7f2d18a1a5a494c6a4f31fcc0fad9b4de25d70a7
> > Reviewed-on: https://chromium-review.googlesource.com/c/1455266
> > Reviewed-by: Alex Clarke <alexclarke@chromium.org>
> > Reviewed-by: François Doray <fdoray@chromium.org>
> > Commit-Queue: Gabriel Charette <gab@chromium.org>
> > Auto-Submit: Gabriel Charette <gab@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#631231}
>
> TBR=gab@chromium.org,fdoray@chromium.org,alexclarke@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 885371, 929263, 930940
> Change-Id: Ic179d0493d01d4f44330927d9ccdb0f1454d2e78
> Reviewed-on: https://chromium-review.googlesource.com/c/1471254
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Commit-Queue: Gabriel Charette <gab@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#631885}

R=fdoray@chromium.org,alexclarke@chromium.org

Bug: 885371, 929263, 931871
Change-Id: I10277d92cb780ba17dc5b9a359dc26b381e85ef4
Reviewed-on: https://chromium-review.googlesource.com/c/1471257
Commit-Queue: Gabriel Charette <gab@chromium.org>
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636474}

Add expectation for flaky external/wpt/fullscreen/api/element-request-fullscreen-and-remove-manual.html

This test seems to be flaky on multiple bots.

TBR=foolip@chromium.org

Bug: 936827
Change-Id: Id91065f4df77d03721eed2e6f1ca17d2a5f17ac4
Reviewed-on: https://chromium-review.googlesource.com/c/1494875Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636473}

We need to port matchers to ObjC in order to be accessible in EG2 to
the Test and the App processes. Also created
shell_matchers_shorthand.h/mm to minimize the changes to call sites.

Bug: 930859
Change-Id: Ibff34f59962bac87fa50d48c1393451b63955271
Reviewed-on: https://chromium-review.googlesource.com/c/1494896
Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636472}

TBR: lukasza@chromium.org
No-Try: true
Bug: 835573
Change-Id: Idb6f7588e0953d838f15d2fb3395d7580ac3d0be
Reviewed-on: https://chromium-review.googlesource.com/c/1495435Reviewed-by: Ella Ge <eirage@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636471}

A source node does not have pending activity if the context state is "closed".
Previously we were checking that the context was basically being destructed,
but since source nodes have a reference to the context, the context is still
alive and can't yet be destroyed.

Bug: 894322
Change-Id: I5b001e07069deab7ccf818b21b37f1652be53035
Reviewed-on: https://chromium-review.googlesource.com/c/1478074Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636470}

In order to do this move, change callers to SetBackgroundColor() to
check if there is a local main frame, instead of checking for a null
LayerTreeView.

This means that when the main frame is remote, the compositor will
(rightfully) stop being updated. But when a local main frame is
attached the compositor must be updated. In the future this will be
a new compositor attached to the LocalFrame. So we add a method to
LocalFrameClient that is called for a local frame being
attached to the Page, and have it inform the WebViewImpl.

R=dcheng@chromium.org

Bug: 912193
Change-Id: I9ff250d46d3a7e352f9a11ab8b892e2f464a99cb
Reviewed-on: https://chromium-review.googlesource.com/c/1478258
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636469}

This patch gets rid of redundant parameter |storage| from |NGInlineNode::
GetOffsetMapping()| as follow-up of CL[1] for improving code health.


[1] http://crrev.com/c/1488479 Make LayoutBlockFlowRareData to hold
NGOffsetMapping for legacy layout

Change-Id: I265c7287f625a74bbf52be040e962c752a572fed
Reviewed-on: https://chromium-review.googlesource.com/c/1488400
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Auto-Submit: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636468}

 * caps-lock-indicator
 * -internal-media-cast-off-button
 * -internal-media-closed-captions-icon
 * -internal-media-download-button
 * -internal-media-overflow-button
 * -internal-media-overlay-cast-off-button
 * -internal-media-remoting-cast-icon
 * -internal-media-subtitles-icon
 * -internal-media-track-selection-checkmark

They don't have style adjustment code, don't have painting code,
and are not used in the UA stylesheets.


Change-Id: I38adc95be356618e76374b68135bb7e03deb398f
Bug: 936301
Reviewed-on: https://chromium-review.googlesource.com/c/1491233
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Auto-Submit: Kent Tamura <tkent@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636467}

We divert touchscreen pinch events performed over an OOPIF to the root
view, as only the root view can change page scale. It is also necessary
for touchscreen gesture pinch events to occur within a gesture scroll
sequence. This requires the diverted pinch events to be wrapped in a
scroll sequence if the root does not otherwise have an ongoing scroll
sequence.

Currently, the pinch events are wrapped without considering scroll
bubbling. If a scroll begin is bubbled to the root, but the
corresponding pinch begin was diverted to the root and therefore another
scroll begin was created to wrap it, then the root already has an
ongoing scroll gesture and should not receive another GSB. Furthermore,
once we have established that scroll is bubbling to the root, there is
no longer any need to wrap the pinch in a scroll end, as the root will
eventually receive a scroll end through bubbling.

Bug: 897216, 923226
Change-Id: I4bb61c2d58ce9168a4c224f0e088d17b68d4a198
Reviewed-on: https://chromium-review.googlesource.com/c/1467242Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636466}

All source files referenced in jni_headers is under chrome/android, so
moving the target here to make it easier to edit when working under
chrome/android.

Bug: 935583
Change-Id: I2dd55db8df80c4e068c065076488938bec612084
Reviewed-on: https://chromium-review.googlesource.com/c/1492931
Commit-Queue: Peter Wen <wnwen@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636465}

This patch extends ScrimView.ScrimParams to allow:

- specifying a Drawable instead of just a color, to allow greater
  customization of the apparence

- specifying an EventFilter, to allow some touch events to go through
  the scrim

The goal is to refactor Autofill Assistant to use this view instead of a
custom view, TouchEventFilterView.

For background, see go/aa-bottomsheet

Change-Id: I6bdaf0f6959e8bac03ba3a04ecfb1ce7f718b7e8
Bug: 933070
Reviewed-on: https://chromium-review.googlesource.com/c/1473230
Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636464}

A single place to include all the base module/apk java deps.

Bug: 846440
Change-Id: Ie1381cdb6ce5c413d6a6ee380ba6301b3f367245
Reviewed-on: https://chromium-review.googlesource.com/c/1494824
Auto-Submit: Peter Wen <wnwen@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636463}

Speculative fix for UBSAN vptr build breakage.

Bug: 936859
Change-Id: I8db59ddf0cc6bfc9b1bb6d15287cb6bd2eaafa42
Reviewed-on: https://chromium-review.googlesource.com/c/1494977Reviewed-by: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636462}

Bug: 863341
Change-Id: Id62135ec73a545c21a6c4ec7d173e540f6cc031f
Reviewed-on: https://chromium-review.googlesource.com/c/1494657
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Karolina Soltys <ksolt@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636461}

AxObjectCacheBase is the only direct subclass of AxObjectCache,
so it is safe to unconditionally downcast from later to the former.

This CL enforces that premise by making AxObjectCache's ctor private,
and stating AxObjectCacheBase as a friend class of it.

Additionally, the CL:
- removes the macro-based cast helper ToAXObjectCacheBase from being
used in t_p/blink/renderer/core/editing/finder/text_finder.cc, and
uses implicit cast.

- switches t_p/blink/renderer/core/exported/web_page_popup_impl.cc
to use the newly added downcast trait helper.

BUG=891908

Change-Id: Iab8f129b1bd330306b1761de58bc4b17ee2ed6a8
Reviewed-on: https://chromium-review.googlesource.com/c/1494677Reviewed-by: Sergio Villar <svillar@igalia.com>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#636460}

... now that all users got switched over to using the simple ctor
instead.

In other words, this CL eliminates IdentityTestEnvironment constructor
that allows tests to pass backing objects (the one that takes compose
signin:internals target) for IdentityTestEnvironment to construct
IdentityManager from.

Note that there is still complex IdentityTestEnvironment *private*
constructors, but these are only accessible by
IdentityTestEnvironment{Profile,ChromeBrowserState}Adaptor friend
classes.

BUG=928677

Change-Id: I962806b6061105ccb4795399f0cdd67aeaca03d3
Reviewed-on: https://chromium-review.googlesource.com/c/1494675Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#636459}

As part of the work to support drag-and-drop of Outlook.exe emails and
attachments to a Chromium drop target:

https://chromium-review.googlesource.com/c/chromium/src/+/1487798/1

common code to get a unique file path was found. It was suggested in
that code review that the implementation of the helper function GetUniquePath
be put in a separate pull request.  The helper is now used in
three places that had the same logic depending on GetUniquePathNumber,
and the helper will be also used in the change above.

Bug: 322605
Change-Id: I4f6cbc676be64967af8e11e1c219722b144888dd
Reviewed-on: https://chromium-review.googlesource.com/c/1490854Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Darwin Huang <huangdarwin@chromium.org>
Commit-Queue: Bruce Long <brlong@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#636458}

ASW that are in construction should be ignored as their dispatch methods
are not properly set up and they are kept alive via stack scan.

Bug: 936817
Change-Id: I0398c319a3ba9e1454e33d97691caf07fe90a09b
Reviewed-on: https://chromium-review.googlesource.com/c/1494874
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Auto-Submit: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636457}

Recent DCHECK failure in DCHECK enabled builds suggest that unexpected
behavior takes place at initial merger where the bridge isn't aware of
all the passwords in the login database.

This CL remove the problematic DCHECK until the underlying cause is
addressed.

More details are in crbug.com/936823

Bug: 936823,933711
Change-Id: I5aa7340e0ebc144d845115764453407495d7249d
Reviewed-on: https://chromium-review.googlesource.com/c/1494878
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636456}

If an AudioContext has been closed or suspended (via a call to close(),
or suspend()), then set the pending activity to false, because nothing
is happening on the context.

Bug: 927731
Test: 
Change-Id: I9330921c9eac621349c1ff8b27324b55123ba815
Reviewed-on: https://chromium-review.googlesource.com/c/1490395
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636455}

This reverts commit 7802af1d.

Reason for revert: crbug.com/936336#c20

TBR=jbudorick@chromium.org,benmason@chromium.org

Bug: 928422, 936336
Change-Id: Ia3864bd03f1284cd1daaac85929a082972c4dcc0
Reviewed-on: https://chromium-review.googlesource.com/c/1495037Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636454}

In an effort to reduce or even ban variable shadowing, this renames a
couple of variables. I'm interested in prohibiting shadowing because I
think it might prevent potential jumbo problems.

The exact error this avoids is:
third_party/blink/renderer/core/frame/frame_serializer.cc:301:12: error: declaration shadows a local variable [-Werror,-Wshadow]
      KURL url =
           ^
third_party/blink/renderer/core/frame/frame_serializer.cc:261:8: note: previous declaration is here
  KURL url = document.Url();
       ^
third_party/blink/renderer/core/frame/frame_serializer.cc:307:14: error: declaration shadows a local variable [-Werror,-Wshadow]
        KURL url = input->Src();
             ^
third_party/blink/renderer/core/frame/frame_serializer.cc:261:8: note: previous declaration is here
  KURL url = document.Url();
       ^
third_party/blink/renderer/core/frame/frame_serializer.cc:313:14: error: declaration shadows a local variable [-Werror,-Wshadow]
        KURL url =
             ^
third_party/blink/renderer/core/frame/frame_serializer.cc:261:8: note: previous declaration is here
  KURL url = document.Url();
       ^
third_party/blink/renderer/core/frame/local_frame_ukm_aggregator.cc:110:14: error: declaration shadows a local variable [-Werror,-Wshadow]
      String uma_name = uma_percentage_preamble;
             ^
third_party/blink/renderer/core/frame/local_frame_ukm_aggregator.cc:94:10: note: previous declaration is here
    auto uma_name = uma_preamble;
         ^
third_party/blink/renderer/core/frame/rotation_viewport_anchor.cc:52:21: error: declaration shadows a local variable [-Werror,-Wshadow]
    HitTestLocation location(point + point_offset);
                    ^
third_party/blink/renderer/core/frame/rotation_viewport_anchor.cc:30:19: note: previous declaration is here
  HitTestLocation location(point);
                  ^

Bug: 923510
Change-Id: I9bd46559f31e6b3fdb412cf7787b764ae84c775b
Reviewed-on: https://chromium-review.googlesource.com/c/1494659
Commit-Queue: Daniel Bratell <bratell@opera.com>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Auto-Submit: Daniel Bratell <bratell@opera.com>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#636453}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/ef04c3c7..21541ca9

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I00019ec9aa11746cf419eeb616a5aef24967c3c0
Reviewed-on: https://chromium-review.googlesource.com/c/1494718Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#636452}

BUG=890790

Change-Id: Ia0e9d5c2276676ecc5e4f551218ee1aecbb62d74
Reviewed-on: https://chromium-review.googlesource.com/c/1494515
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636451}

This reverts commit 68320b85.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Android: ensuring onDestroy called between each test
> 
> The previous onDestroy in tests change only blocked until onDestroy with certain
> subclasses of ChromeActivityTestRule which called launchActivity. This change
> blocks all tests on onDestroy.
> 
> Bug: 908174
> Change-Id: I074054c28d002e012d0f6ebc95a53aadf4175eaa
> Reviewed-on: https://chromium-review.googlesource.com/c/1473330
> Commit-Queue: Sam Maier <smaier@chromium.org>
> Auto-Submit: Sam Maier <smaier@chromium.org>
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#636023}

TBR=agrieve@chromium.org,smaier@chromium.org

Change-Id: Idc5c2b186615b73cd4b6a49c29c29466cce30973
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 908174
Reviewed-on: https://chromium-review.googlesource.com/c/1494717
Commit-Queue: Sam Maier <smaier@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636450}

Before this CL, SyncAuthManager's |last_auth_error_| member could be
populated either by an error from Chrome's identity/token system, or by
an error from the Sync server. This was confusing and inconsistent, since
these errors have different lifetimes: An error from the Sync server
should be cleared when Sync is shut down, but an error from the identity
system should only be cleared on signout (and optimally, we wouldn't need
to cache these errors at all).
As a first step, this CL makes it so |last_auth_error_| only refers to
errors from the identity system. Errors from the Sync server are instead
generated on-the-fly, from already-existing information.

Bug: 921553
Change-Id: I646ea21220e19849df96d771ed35f1b54e4fb0ec
Reviewed-on: https://chromium-review.googlesource.com/c/1489232
Auto-Submit: Marc Treib <treib@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636449}

This CL takes the newly split out InterfaceFactory::Create*Renderer
methods and exposes them directly in the MojoRendererFactory.

Classes that used to wrap the MojoRendererFactory and use its return
values opaquely now have direct knowledge of the Mojo layer.

FlingingRendererClientFactory is moved to content/ because it cannot
depend on media/mojo. It also no longer needs to provide a
|type_specific_id|.

Bug: 936116
Change-Id: I37509c8c68c52dc6e2cb3488e2f41bed9c7b8396
Reviewed-on: https://chromium-review.googlesource.com/c/1489904
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636448}

At the moment the Contained Shell launches any time its feature flag is
enabled. But since we want users to toggle the experience from settings,
we added a pref to control it. This change actually enforces this new
pref by aways checking it when we try to launch the experience.

Bug: 922687
Change-Id: Icf1ffa2422bbb68fda80e22f626d48bcbe8c8c18
Reviewed-on: https://chromium-review.googlesource.com/c/1477821
Commit-Queue: Lucas Tenório <ltenorio@chromium.org>
Reviewed-by: Mitsuru Oshima (OOO til 3/4) <oshima@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636447}

mime_util does not take extensions with a leading dot, and if you
pass in an extension with a leading dot, you will not successfully
look up a mime type.

BUG=84003
TEST=as in bug

Change-Id: I37d9b0946df61a557b3423ae8a13ae447ed6c7c1
Reviewed-on: https://chromium-review.googlesource.com/c/1493473
Auto-Submit: Avi Drissman <avi@chromium.org>
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636446}

This CL is a part of OnionSoup effort. It moves
third_party/blink/public/mojom/color_chooser/color_chooser.mojom to
third_party/blink/public/mojom/choosers/ and port other dependent
files to refer to a new include path.

Bug: 935938
Change-Id: I9dc107b6842a5ccdf5b116624ee7266923e07f50
Reviewed-on: https://chromium-review.googlesource.com/c/1488410
Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636445}

A unit test includes prefs_names.cc which in some builds
caused duplicate symbol errors in linking.

(I get a feeling we need a presubmit check for this because
it has happened several times recently)

TBR=gayane@chromium.org

Bug: 931806
Change-Id: I942ba67f7570feed59b32694a55402db169e109c
Reviewed-on: https://chromium-review.googlesource.com/c/1494884Reviewed-by: Daniel Bratell <bratell@opera.com>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#636444}

Change-Id: Ia899557b839d7c0340f1d89dbd086adeee834e73
Reviewed-on: https://chromium-review.googlesource.com/c/1489234
Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636443}

Speculative fix for leak_detection benchmark, which should not have
been overriding the CustomizeBrowserOptions method.

TBR=yuzus@chromium.org,keishi@chromium.org

Bug: 936805
Change-Id: If949793f605925de8754dd0fc02b8de2c2608404
Reviewed-on: https://chromium-review.googlesource.com/c/1494879Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636442}

When Perfetto is enabled but used by the legacy Coordinator/Agent
Mojo layer, tracing is enabled through a different set of message
pipes (the Perfetto Consumer/Producer interfaces). To fully ensure
that the legacy Coordinator only calls the BeginTracing callback
when tracing is enabled for all currently running sub-processes,
we add a new API call which explicitly waits for the TraceLog to
become enabled for that sub-process before calling the callback.

This should fix some flaky tests in the perfetto_content_browsertests
suite.

BUG=839084,935642
R=dcheng@chromium.org,eseckler@chromium.org

Change-Id: I0d72cf3f393c5e68d54a489e6c7a17699e02a4e7
Reviewed-on: https://chromium-review.googlesource.com/c/1490901Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636441}

Reland Note:
{
  Previously landed:
  https://crrev.com/258ed8d55e4f8b4d99fcde72c3569b9450198092
  Reverted:
  https://crrev.com/716496fe0909bc918c410a56f6566390b12adedc

  Revert was due to failing Leak Detector bot. Issue was that the
  browser still held a reference to the V8 function for the gesture
  completion callback which was never resolved. This CL resolves
  callback when the BlinkTestRunner is reset. Original CL uploaded in
  PS1.
}

This CL makes synthetic input - the kind used in web tests and
telemetry (e.g. gpuBenchmarking.scrollBy) - wait until a CompositorFrame
has been submitted by the renderer and displayed by the display
compositor before resolving the completion callback. This means client
code that wants to wait until any observable side-effects of this input
is visible to further input need only wait on the gesture's completion
callback.

To give a motivating example: suppose we wish to write a test that
scrolls an out-of-process iframe into view and clicks on a button in the
frame. The code might look something like this:

gpuBenchmarking.smoothScroll(1000, () => {
  gpuBenchmarking.tap(0, 0);
});

This code contains a race today. The callback for smoothScroll is
invoked as soon as the ScrollEnd is received in the renderer. However,
until a new compositor frame is submitted from the renderer, the tap
may occur against stale hit testing geometry. This is a major source of
flakiness in our tests.

This CL fixes the problem by forcing the renderer to perform a full
redraw at the end of each gesture. The redraw produces a compositor
frame and we invoke the callback once the compositor frame is displayed.
We do this by reusing the RequestPresentation mechanism in RenderWidget.
RequestPresentation required two modifications to work in web tests
which use a single thread proxy with no scheduler:

 - LayerTreeHost::Composite needs to check the forced redraw flag to
   determine whether we need to raster, otherwise it won't produce a
   frame
 - RequestPresentation must request a main frame since there's no
   scheduler to perform the commit, which is what SetNeedsForcedRedraw
   requests.

The timing change exposed an issue in the
overlay-play-button-tap-to-hide.html test so this CL also cleans that
test up to listen to the animation changes in media controls properly.

Finally, it's possible we may get input in a RenderWidget that's not
currently displayed. e.g. A click event sent via ChromeDriver causes a
TouchStart followed by a TouchEnd. The TouchStart causes a window.open
which opens and focuses a new tab. The TouchEnd then happens on the
background tab. In this case, we should resolve the callback rather than
waiting on a CompositorFrame that'll never come. See ChromeDriver test
testNetworkConnectionTypeIsAppliedToAllTabs for an example of this.


TBR=dtapuska@chromium.org,nzolghadr@chromium.org,samans@chromium.org

Bug: 902446
Change-Id: Ia2f0a5a6ae51216582bf4cc1d03cb5ba724ddffd
Reviewed-on: https://chromium-review.googlesource.com/c/1490757Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636440}

Rather than just using the basename of zip paths, use the full path to
generate the temporary name so the build does not depend on resource
and string targets having unique names.

Bug: 935576
Change-Id: I8aa2d1474e768659be444db2ba7c0e6dd7e5eb79
Reviewed-on: https://chromium-review.googlesource.com/c/1492835
Auto-Submit: Peter Wen <wnwen@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636439}

This change adds a std::unique_ptr overload to base::Owned and changes
base::internal::OwnedWrapper to use an std::unique_ptr as backing
storage, simplifying its implementation.

Bug: 554299
Change-Id: Ia3eb1bf3857c7be6593d77c59e495ed90932d24b
Reviewed-on: https://chromium-review.googlesource.com/c/1482890
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636438}

https://skia.googlesource.com/skia.git/+log/1179d5dfaf8d..b7b2da871e95


git log 1179d5dfaf8d..b7b2da871e95 --date=short --no-merges --format='%ad %ae %s'
2019-02-28 mtklein@google.com set -fcolor-diagnostics when is_clang


Created with:
  gclient setdep -r src/third_party/skia@b7b2da871e95

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=scroggo@chromium.org

Change-Id: If61244d414b764c9f31bd88f9f351a7a1360a5ed
Reviewed-on: https://chromium-review.googlesource.com/c/1494818Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#636437}

Start: if we fail to find a free display or Xvfb fails to start
otherwise, r_w_t now quits with a non-zero exit code instead of
continuing to run the tests without Xvfb.

Stop: we first try to send SIGTERM to Xvfb and give it some time to exit
gracefully (especially to clean up the lock file); SIGKILL is only used
as the last resort.

Add test cases to test the exit code and to cover the new behaviour
introduced in https://crrev.com/c/1480700 earlier.

Bug: 933523
Change-Id: Ide791f229e54b3f98db6eb698afa162e4f17e81f
Reviewed-on: https://chromium-review.googlesource.com/c/1493201Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636436}

No intended behavior change. (It implicitly adds the flag for is_nacl
I believe, but that seems to work.)

Bug: 935588,926235
Change-Id: I785d5b5a75092be1370be77559ec9fa5d0c795f7
Reviewed-on: https://chromium-review.googlesource.com/c/1489900Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636435}