- 26 Feb, 2020 40 commits
-
-
Ryan Harrison authored
BUG=dawn:345,dawn:354 Change-Id: I0ef71cc18397aa4854e8dc3e310e4031ab7be731 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075044 Commit-Queue: Ryan Harrison <rharrison@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Auto-Submit: Ryan Harrison <rharrison@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#744832}
-
Collin Baker authored
Bug: 1055100 Change-Id: Ifd93d22fa73036fef81396db2b82ccc2bc73ca37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069020 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#744831}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e93f058d4492..9abfc467c79f git log e93f058d4492..9abfc467c79f --date=short --first-parent --format='%ad %ae %s' 2020-02-26 bsheedy@chromium.org [Telemetry] Fix shlex.split on Windows Created with: gclient setdep -r src/third_party/catapult@9abfc467c79f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1056281 Tbr: sadrul@google.com Change-Id: Ic37f70e3c56506d55292b73de426a41324877d15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075961Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744830}
-
Sebastien Marchand authored
This CL adds a new policy that will emit critical memory pressure signals when Chrome's total PMF exceeds is too high. "Too high" is defined as 1.5x the total amount of RAM on the machine by default (but this value can be modified via Finch). This code is behind a feature flag, in the disabled by default state. Bug: 1055889 Change-Id: If57e7ac5dce601fc83ef50c50838617ece35dcb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044330Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#744829}
-
Henrique Nakashima authored
CachedFeatureFlags should only have generic methods. Bug: 1012975 Change-Id: Ib40ce5713862dd07666b862044ab1379e725f35a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068678 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#744828}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b01f8fe7eb22..d9a5b6e2c1d2 git log b01f8fe7eb22..d9a5b6e2c1d2 --date=short --first-parent --format='%ad %ae %s' 2020-02-26 jalyn@microsoft.com Fix disappearing focus in Performance and Coverage 2020-02-26 sigurds@chromium.org [issues-panel] Correctly update issues upon navigation 2020-02-26 bmeurer@chromium.org Allow long strings to wrap in the console. Created with: gclient setdep -r src/third_party/devtools-frontend/src@d9a5b6e2c1d2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1055375,chromium:1056284 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0dd795828bad2eeab177340c509f7f663c654eb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075960Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9731a14ff8ec..206d46750780 git log 9731a14ff8ec..206d46750780 --date=short --first-parent --format='%ad %ae %s' 2020-02-26 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 0bba1cec..95bde2f2 (744590:744714) Created with: gclient setdep -r src/third_party/webrtc@206d46750780 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I6594c7fa2c1e12df248b2625c757d6743137e784 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076240Reviewed-by:
-
David Benjamin authored
Many servers which negotiate SHA-1 server signatures in TLS 1.2 actually support SHA-2 but preferentially sign SHA-1 if available. Likewise, some 3DES-negotiating servers support AES if 3DES is removed. To get more accurate metrics, initially connect with SHA-1 and 3DES disabled. If this fails, retry with them enabled. This keeps the legacy algorithms working for now, but they will only appear in metrics and DevTools if the site relies on them. Add a feature flag so that if problems arise (e.g. we're not conditioning on the right error codes), we can turn this off easily. See https://groups.google.com/a/chromium.org/forum/m/#!topic/blink-dev/yaJcs4p9LNI for more details. Bug: 658905, 691888 Change-Id: I94ad87b2c71cdd6c85060a4372b198e4119ffee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063689 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#744825}
-
Istiaque Ahmed authored
This CL makes ContentVerifier::ShouldVerifyAnyPaths take canonical relative paths instead of unix style relative paths, so that it can take OS specific canonicalization into account. This affects all paths specified in manifest.json: background JS, background html, content script, locales, etc. Previously ShouldVerifyAnyPaths would have returned false for case variants of those resources on win/mac, and content-verification wouldn't run for them as there wouldn't be any ContentVerifyJobs for them. An example of this is on win/mac, a script specified as script.js in manifest.json, but accessed as Script.js on win/mac will now be verified with this CL. The same applies to _locales, locale path accessed in different case now would correctly skip verification (e.g. en_gb instead of en_GB), instead of incorrectly causing content verification failure. ContentVerifierObserver now exposes did_hash_mismatch, which would be slightly better to observe CVDelegate::VerifyFailed from tests. This CL adds unittests for the change in content_verifier_unittest.cc This CL also adds a real world like unittest under //chrome, so the browser image paths and other manifest paths are verified (and not mocked like content_verifier_unittest) end-to-end. This is chrome_content_verifier_unittest.cc BUG=1051401,796395 Change-Id: I74161a043a6e65b80c7bf06c249cf42813f867a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049125 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#744824}
-
Peter Kasting authored
Use this to refactor lots of repeated manual boilerplate. Bug: none Change-Id: I310b310871cc5c8b55bee50fc859f135e1be0819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070955 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#744823}
-
Moe Ahmadi authored
Currently, "NtpRealbox", "NtpRealboxMatchOmniboxTheme", and "OmniboxSuggestionTransparencyOptions" features are under the study named "NTPZeroPrefixSuggestions" in fieldtrial_testing_config.json. This CL moves them under "OmniboxBundledExperimentV1" so they can be found together with "OmniboxOnFocusSuggestions" as expected by Finch presubmit. Change-Id: I3aa42d345a70479aa3c92301c4bbf32e594be650 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073164Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#744822}
-
Joel Hockey authored
Terminal app should not show favicon. Moved favicon::ShouldDisplayFavicon to TabStripModelDelegate and Browser where AppBrowserController can also detect system apps. Bug: 1033339 Change-Id: Ib5bf715aff6e2c3ebb0044a4168ca039ddf56d7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066493Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#744821}
-
zhaoyangli authored
- Modified comments for |-ensureAppLaunchedWithConfiguration:| method of |AppLaunchManager| reminding users to choose suitable place to call this method for better efficiency. - Changed default value of |RelaunchPolicy| in |AppLaunchConfiguration| to |NoForceRelaunchAndResetState| which is more commonly used when user relaunches the app for different enabled features. Bug: 1009017 Change-Id: I523304d387d5f873a33cc0b72023d9eafe6e7c20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073137Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#744820}
-
dpapad authored
This regressed in r744505 but apparently no test caught it, since they only run on official bots. Bug: 1026426 Change-Id: I22c44643527cde8cb618f1507974badf03d81cab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075900 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
-
Tom Anderson authored
BUG=914974 R=pkasting Change-Id: Ia017ddb1cb1314bea83c29b5dd9a313cf60e717b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076098 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
John Budorick authored
Should be a no-op when running against a single attached device, but should facilitate the upcoming multi-instance emulator case. Bug: 922145 Change-Id: I6ef32a592155d0ff248033f7c2d7bf3d531e113e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075047Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#744817}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8ec13300cd6d..6422722cbaf6 git log 8ec13300cd6d..6422722cbaf6 --date=short --first-parent --format='%ad %ae %s' 2020-02-26 bsalomon@google.com Reland "Remove GrDeviceSpaceTextureDecalFragmentProcessor." Created with: gclient setdep -r src/third_party/skia@6422722cbaf6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jlavrova@google.com Change-Id: I3379a6a3ded0ea03b8447f2300eab90cc7709940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075918Reviewed-by:
-
Esmael El-Moslimany authored
The "dir" attribute for <html> is not being respected when the browser is using an RTL language. Bug: 1049541 Change-Id: I6530cba90b05a18be277937644c6188237b813dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042433Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#744815}
-
Toni Barzic authored
BUG=1008963 Change-Id: I1f40729b3338c12360be783c300bca3ac5c7d7d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069438 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#744814}
-
Michael Spang authored
This reverts commit 334077c8. Reason for revert: Breaks vulkan on fuchsia, see http://crbug.com/1056089 Original change's description: > Vulkan: support Android devices without Android hardware buffer > > Some Android P devices don't support vulkan extension > VK_ANDROID_external_memory_android_hardware_buffer. For those devices, > chrome will fallback to ExternalVkImageBacking which uses > VK_KHR_external_memory_fd extension or pixel copy for GL and Vulkan > inerop. > > Bug: 1049864 > Change-Id: I101a4c83a2dbfcfdbade29084a863e7563f631e6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067290 > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > Reviewed-by: Michael Spang <spang@chromium.org> > Commit-Queue: Peng Huang <penghuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#743931} TBR=penghuang@chromium.org,spang@chromium.org,vasilyt@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1049864 Change-Id: Id57d5f42b65239d9e80ccfda8f373b0441f9a8a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075050Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#744813}
-
Nohemi Fernandez authored
SceneController calls AddAccountCoordinator from an ApplicationCommand. A user that directly triggers this command, for example by adding an account through accounts.google.com/addsession, will crash the app. Bug: 1054861 Change-Id: Id589d69fc3bd4332e9db827e814f52b62902da16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074504 Auto-Submit: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#744812}
-
Gauthier Ambard authored
This enables the flag by default on Canary. The idea is to ship it to 100%, with a kill switch by Finch. Bug: 1038034 Change-Id: I0ea6097bd844db1940eff683d99d555f1654189d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062979 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#744811}
-
Jeff Yoon authored
We don't guarantee that xcode installed and set before we use otool, so we want to ensure that it's installed first. This CL pulls this out of the constructor and into run.py, such that we don't need to pass xcode_build_version, xcode_path and mac_toolchain into the constructor of every single runner class. Change-Id: Id8f315645c22c07448ad6d0211511bc83a9af46e Bug: 1055330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044305 Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#744810}
-
Mehran Mahmoudi authored
This employs post_task.h to make some operations in PlayerCompositorDelegate asynchronous. It also fixes an issue in CreateFileMapFromProto where an invalid file path resulted in an unexpected behaviour. Bug: 1034111 Change-Id: I2f29845766bd7bc339255b93845346ca41eff2ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075957Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#744809}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ibe4b7b97204524b503871a75d1d2c5f30ff4cf3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075778 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Andrew Grieve authored
Change-Id: I457dd7e9cc616038b50122e1fc12266ca24df92f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075037 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#744807}
-
Devlin Cronin authored
ExtensionInstallPrompt started out life as a prompt to install an extension, but has since grown into a franken-prompt used for many different pieces of extension functionality. This leads to technical debt and complexity, hard-to-reason about code, excessive redirection, etc, and a number of bugs have been filed about trying to simplify it (e.g. crbug.com/567839). Add a comment in ExtensionInstallPrompt discouraging the addition of any new types that don't actually prompt to install an extension. New code that needs a dialog should implement a new dialog, rather than piggy- backing on this class. Bug: None Change-Id: I00476b3d4cda8efbbe2b7cf4ae3c39935f004402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075083Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#744806}
-
Parastoo Geranmayeh authored
flaky test. TBR="xiyuan@chromium.org, tbarzic@chromium.org" Bug: 1056302 Change-Id: I65cbd1acadb5e68e3394f7cfeb7fa491f8c0abf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076377Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#744805}
-
Kramer Ge authored
The purpose is to indicate where (0,0) is in an output surface. Originally boolean value flipped_output_surface was not descriptive. This CL adds SurfaceOrigin components/viz. Because GLSurface exposes FlipsVertically() this enum is expected to move to ui/gfx Bug: 1051970 Change-Id: I8ba63ea08c4bb6d0b8faf1a49c3d2e417f7c6ad7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067350 Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#744804}
-
Sammie Quon authored
The back gesture will now have special behaviour for ARC apps. The first swipe will animate in the shelf and hotseat, and the second swipe will send a back event. I changed the container the back affordance is in because: 1) AlwaysOnTop container is watched by the workspace, which means adding/removing/hiding/etc the affordance window will trigger backdrop/shelf/etc updates. 2) AlwaysOnTop container is underneath the shelf container, which would make it tricky the part with the second swipe without the shelf pre event handler eating the event and hiding the shelf. 3) AlwaysOnTop container is still underneath a lot of things. I spoke with Ben and he seems to want sometime that is even above the power menu button. I think maybe we'll have our own GesturesContainer but for now the OverlayContainer (autoclick, laser) should work fine. The affordance was also creating a renderpass at the end which I removed. It was small, but should help out with the large minimize animation that commonly follows. Test: manual Bug: 1031268 Change-Id: I4f3be651604ac91cf0d2a07a24aa0f51efd44023 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073199Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#744803}
-
Mustaq Ahmed authored
A past fix for activation propagation from an extension button to extension script seems to have added additional user activation propagation path from tab-strip to all installed extensions: https://chromiumcodereview.appspot.com/10821120/ This crack caused every tab-switching to activate /all/ installed extensions, which seems bad. Because of this, we encountered a security issue with unintended top frame navigation from an iframe. (Luckily only tab switching was affected, not tab clicking.) A user interaction with the tab-strip is different from an interaction with extension buttons. Tab-strip interactions are similar to those on any browser-provided UI element like top menu: they don't at all indicate the user's intention to interact with any extension or website. Therefore, like clicks on top-menu and unlike clicks on extension buttons, tab-switching should suppress activating any background script thus prevent access to use user-activation gated APIs like popup, fullscreen, navigation, etc. Bug: 957633, 1035315 Change-Id: I8d56e02a3a2966521b7bbc4f4efadf67e1acc371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072654Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#744802}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e3621dca1542..4d40271e3f09 git log e3621dca1542..4d40271e3f09 --date=short --first-parent --format='%ad %ae %s' 2020-02-26 amaiorano@google.com Subzero: add support for large stacks on Windows Created with: gclient setdep -r src/third_party/swiftshader@4d40271e3f09 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I0261aea1960262f4018b31fb43eddf4341fa58fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075445Reviewed-by:
-
Denis Kuznetsov authored
Bug: 1054935 Change-Id: I2da8e4c8240647614728c21e351a6b2e940aaae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074882Reviewed-by:
-
Andres Calderon Jaramillo authored
This CL fixes the VaapiVideoDecodeAccelerator to advertise the visible size as the coded size for decoded video frames. Here's the background: CL:2011583 changed the VA-API decoding pipeline so that the EGLImage backing a VideoFrame's service-side texture is created using the visible size instead of the coded size. This is correct because the graphics API does not care about the non-visible area. This was done to avoid a green line error: making the size of the EGLImage equal to the visible size allows the texture sampler to not sample beyond the visible area, so the green line (part of the non-visible area) is avoided. The problem is that the coded size of the VideoFrame sent to the client still contained the non-visible area. This is arguably strange because as far as the client is concerned, this non-visible area does not exist. This was also causing problems when PaintCanvasVideoRenderer requested a copy from the VideoFrame's texture: the coded size was bigger than the visible size used to create the EGLImage. This caused black images to be displayed some times (e.g., thumbnails of videos in the Camera Capture App) because the GL commands sent from the client didn't pass validation in the service side (e.g., "GL ERROR :GL_INVALID_VALUE : glCopySubTextureCHROMIUM: source texture bad dimensions"). This CL changes VaapiVideoDecodeAccelerator so that the coded size of the VideoFrame only includes visible data. Additionally, it is possible for a decoded frame to end up as an overlay plane. In that case, the size of the DRM framebuffer should match the visible area of the frame. This is important so that the non-visible area doesn't appear in the overlay path. Therefore, this CL plumbs the desired framebuffer size all the way through Ozone. There is a caveat, however: there is an unusual corner case where an H.264 video includes information about a visible rectangle whose origin is not at (0, 0). Therefore some of the top and left parts of the video should not be displayed. However, Chrome does not currently deal well with this case, and this CL doesn't change that (i.e., those non-visible areas are still displayed). Note: follow-up CLs will deal with V4L2 and the VideoDecoder interface variations. Bug: 1045597 Test: Record video in nocturne's CCA and inspect thumbnail. Change-Id: I7076b66bfa7cb2284f6a5431968e98053f9b8103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056285 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#744799}
-
Mohamed Heikal authored
Change-Id: I654b012aa61ba9c782c22e2a8fe2ade32186a7cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076100 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#744798}
-
James Cook authored
I missed a couple of references to identity service code when I migrated the assistant to the in-process IdentityManager. Original migration CL: https://chromium-review.googlesource.com/c/chromium/src/+/2033572 Bug: none Change-Id: Ic9226edf99e08657cdae6c4fd58cd4fd64abf933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071048Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Yue Li <updowndota@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#744797}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8995c0468a44..9bda3eea9509 git log 8995c0468a44..9bda3eea9509 --date=short --first-parent --format='%ad %ae %s' 2020-02-26 rsavitski@google.com Merge "traced_perf: bump fd timeout and add more cts logging" Created with: gclient setdep -r src/third_party/perfetto@9bda3eea9509 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ie2e28bd8ae02712223d16b32a6d9d52fce1a906b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075447Reviewed-by:
-
Stefan Zager authored
The root cause of the linked bug is that IntersectionObserverController continues to track an observer after the observer's root element is deleted. This CL tightens up the conditions for which objects are tracked: - Explicit root observers with observations, if the root is connected - Implicit root observations, if the target is connected BUG=1046897 R=vmpstr@chromium.org Change-Id: Ib98a0dd3c948e61200cd270011cfe18b8776d7fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068860Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#744795}
-
Xiao Yang authored
1. Added null check for submenu Host in RenderViewContextMenuViews:: Show() to avoid crash. Bug: 1054962 Change-Id: Iff52355a89c64038dd3f7828a638b804563d4ae2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070960Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
Evan Stade authored
The flake seems to occur when the touch is handled by selecting text on the page, so switch to a page that doesn't have text in the way of the touch. This also puts a timeout on each CountDownLatch since an unbounded await() leads to very unhelpful (i.e. non-existent) error output. Bug: 1052802 Change-Id: I44393c4a821413e626eb3a5ef4c2e16609022040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074812 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#744793}
-
