GitLab

BUG=91843
Review URL: http://codereview.chromium.org/7584009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95639 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

R=evan@chromium.org

Review URL: http://codereview.chromium.org/7550026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95638 0039d316-1c4b-4281-b951-d872f2087c98

Adds suppressions for leaks introduced with r95607.  Reordering suppressions.

BUG=91816
TEST=Valgrind and HeapCheck bots turn green.
TBR=tzik@chromium.org

Review URL: http://codereview.chromium.org/7582013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95636 0039d316-1c4b-4281-b951-d872f2087c98

If the current context was ever nil, sending a "restore" message would be a no-op and would likely leave an out-of-scope context as current.

BUG=90140
TEST=repeatedly select items in an open file dialog in column mode; no crash

Review URL: http://codereview.chromium.org/7572031

TBR=avi@chromium.org
Review URL: http://codereview.chromium.org/7541043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95631 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95629 0039d316-1c4b-4281-b951-d872f2087c98

Note: This was a TODO for tc.

BUG=None
TEST=None

R=tony@chromium.org

Review URL: http://codereview.chromium.org/7585001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95628 0039d316-1c4b-4281-b951-d872f2087c98

R=agl@chromium.org
BUG=91458
TEST=none

Review URL: http://codereview.chromium.org/7572043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95627 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=Manually on chromebook


Review URL: http://codereview.chromium.org/7569006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95626 0039d316-1c4b-4281-b951-d872f2087c98

It makes the refresh button on the file manager working in intuitive manner. Also now it's possible to set a bookmark to a specific directory or enter directory path in the omnibox.

BUG=chromium-os:17787
TEST=None


Review URL: http://codereview.chromium.org/7584004

TBR=serya@chromium.org
Review URL: http://codereview.chromium.org/7550035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95625 0039d316-1c4b-4281-b951-d872f2087c98

Adds suppressions for leaks introduced with r95607.

BUG=91816
TEST=Valgrind and HeapCheck bots turn green.

Review URL: http://codereview.chromium.org/7491060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95624 0039d316-1c4b-4281-b951-d872f2087c98

Move actual tests out of chrome/tests,
closer to code being tested.

Remove empty directory.

BUG=90905
Review URL: http://codereview.chromium.org/7576018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95623 0039d316-1c4b-4281-b951-d872f2087c98

This is a fix needed for experiments with using unpatched sqlite.

BUG=22208

Review URL: http://codereview.chromium.org/7575027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95622 0039d316-1c4b-4281-b951-d872f2087c98

It makes the refresh button on the file manager working in intuitive manner. Also now it's possible to set a bookmark to a specific directory or enter directory path in the omnibox.

BUG=chromium-os:17787
TEST=None


Review URL: http://codereview.chromium.org/7584004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95621 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7464040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95620 0039d316-1c4b-4281-b951-d872f2087c98

TBR=rvargas@chromium.org
Review URL: http://codereview.chromium.org/7582007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95619 0039d316-1c4b-4281-b951-d872f2087c98

R=rvargas
Review URL: http://codereview.chromium.org/7461141

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95618 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7491059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95617 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95616 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95615 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7541041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95614 0039d316-1c4b-4281-b951-d872f2087c98

If the current context was ever nil, sending a "restore" message would be a no-op and would likely leave an out-of-scope context as current.

BUG=90140
TEST=repeatedly select items in an open file dialog in column mode; no crash

Review URL: http://codereview.chromium.org/7572031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95611 0039d316-1c4b-4281-b951-d872f2087c98

TBR=eroman

BUG=91799
TEST=NetInternalsTest.NetInternalsPrerenderView
Review URL: http://codereview.chromium.org/7491058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95610 0039d316-1c4b-4281-b951-d872f2087c98

This replaces a lot of custom code with an implementation that reuses the
architecture of the menubar Bookmarks menu.

This CL introduces two minor regressions (bugs pending):
* Hover state is lost after menu is opened. Mousing out/back over fixes.
* The off-the-side menu contains all items from the bookmark bar.

BUG=78151
TEST=Click on a bookmark folder button. A menu opens.

Review URL: http://codereview.chromium.org/7465090

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95609 0039d316-1c4b-4281-b951-d872f2087c98

BookmarkBarEnabled policy also sets the kShowBookmarkBar pref, so that the pref is disabled in the preferences UI.

BUG=90731
TEST=Set the BookmarkBarEnabled policy. When true, the bookmark bar is always shown on the NTP. When false, it is never shown anywhere. In either case, it can't be modified by the user.


Review URL: http://codereview.chromium.org/7564011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95608 0039d316-1c4b-4281-b951-d872f2087c98

BUG=88644
TEST='BrowsingDataQuotaHelperTest.*'


Review URL: http://codereview.chromium.org/7387007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95607 0039d316-1c4b-4281-b951-d872f2087c98

Testing infrastructure and tests for the cloud policy subsystem.

Review URL: http://codereview.chromium.org/7264019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95606 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95605 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=canary

Review URL: http://codereview.chromium.org/7541039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95604 0039d316-1c4b-4281-b951-d872f2087c98

TBR=bruening
Review URL: http://codereview.chromium.org/7569007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95603 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:18611
TEST=Manual

Review URL: http://codereview.chromium.org/7566039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95602 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95601 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=canary
TBR=jianli

Review URL: http://codereview.chromium.org/7583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95600 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/7562006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95597 0039d316-1c4b-4281-b951-d872f2087c98

TBR=bruening
BUG=79933,76354,78784,82716,88640,91465
Review URL: http://codereview.chromium.org/7491051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95596 0039d316-1c4b-4281-b951-d872f2087c98

TBR=mkwst
TEST=builds OK
Review URL: http://codereview.chromium.org/7583004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95595 0039d316-1c4b-4281-b951-d872f2087c98

Toplevel widgets need to be a native widget even when --use-pure-views.

BUG=None
TEST=No crashes on start-up with --use-pure-views.


Review URL: http://codereview.chromium.org/7574007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95594 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95593 0039d316-1c4b-4281-b951-d872f2087c98

BUG=90996
TEST=test_shell_tests


Review URL: http://codereview.chromium.org/7533013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95591 0039d316-1c4b-4281-b951-d872f2087c98

A tiny fallout from issue 7489038

BUG=none
TEST=green bots

Review URL: http://codereview.chromium.org/7511008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95581 0039d316-1c4b-4281-b951-d872f2087c98

Enum may take 3 values:
* ENABLED (default) - both normal and incognito modes are allowed.
* DISABLED - incognito mode cannot be used.
* FORCED - browsing is only possible in incognito mode.

Mapped IncognitoEnabled::false to IncognitoModeAvailability::DISABLED when IncognitoModeAvailability policy/pref is not set.
Removed IncognitoEnabled pref (no longer used).

BUG=69580
TEST=


Review URL: http://codereview.chromium.org/7520023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95580 0039d316-1c4b-4281-b951-d872f2087c98