- 02 Jun, 2020 40 commits
-
-
Hugo Benichi authored
This was migrated to kMeteredProperty in Change-Id I83f4ca01521947edb39785053308cb88b658a69e. BUG=b:156302252 TEST=Compiled. Change-Id: If6ad3879d96232b640e5f13cf2b8981cd4031eb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217683Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Hugo Benichi <hugobenichi@google.com> Cr-Commit-Position: refs/heads/master@{#773990}
-
Chromium WPT Sync authored
Using wpt-import in Chromium cb2717b7. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org, mstensho@chromium.org: external/wpt/css/CSS2 NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I0b8ccf1c1f14204ae7e8b74496924dacf89be427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225877Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773989}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/011959aafddc..859bfe8981d6 2020-05-28 dmauro@google.com Googletest export 2020-05-28 dmauro@google.com Googletest export 2020-05-28 absl-team@google.com Googletest export 2020-05-28 dmauro@google.com Merge pull request #2767 from mvoorsluys:OutputXmlSkipped 2020-05-28 dmauro@google.com Googletest export 2020-05-28 dmauro@google.com Merge pull request #2862 from prehistoric-penguin:prehistoric-penguin-patch-1 2020-05-28 dmauro@google.com Merge pull request #2845 from matepek:readme-update-with-opensource-proj 2020-05-28 dmauro@google.com Merge pull request #2677 from IYP-Programer-Yeah:fix-file-path-normalize-function 2020-05-28 dmauro@google.com Merge pull request #2698 from aribibek:patch-1 2020-05-28 absl-team@google.com Googletest export 2020-05-28 absl-team@google.com Googletest export 2020-05-28 durandal@google.com Googletest export 2020-05-28 absl-team@google.com Googletest export 2020-05-28 absl-team@google.com Googletest export If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/googletest-chromium-autoroll Please CC isamsonov@google.com,pwnall@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_cfi_rel_ng;luci.chrome.try:win-chrome Tbr: isamsonov@google.com,pwnall@chromium.org Change-Id: I352391966ec7e41632b92dee97aaf09f9f057fe9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225712Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#773988}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1591041546-66c2ea2b6b7d4112794a73d0a3fdd90d1b4804af.profdata to chrome-win64-master-1591055861-b616b8ef5787fabc8c6bebc449f3453e58d43322.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I013346875989ec62ee145ca3fab14bb6d03a3a00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226039Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/f32ae562fe52..634973155ab5 2020-06-02 thestig@chromium.org Use more RetainPtrs in CXFA_FFTabOrderPageWidgetIterator. 2020-06-02 thestig@chromium.org Clean up CXFA_FFTabOrderPageWidgetIterator. 2020-06-02 thestig@chromium.org Fix an UnownedPtr error in CXFA_FFTabOrderPageWidgetIterator. 2020-06-02 thestig@chromium.org Mass rewrite dtors to use "= default". 2020-06-02 thestig@chromium.org Remove unused CXFA_FFPageWidgetIterator members. 2020-06-02 thestig@chromium.org Remove DeviceType::kUnknown. 2020-06-01 nigi@chromium.org Update comments and add an embeddertest for FPDF_LCD_TEXT. 2020-06-01 thestig@chromium.org Mark CFX_RenderDevice::SetDeviceDriver() as protected. 2020-06-01 thestig@chromium.org Mark CFX_RenderDevice ctor as protected. 2020-06-01 thestig@chromium.org Make CPDFXFA_Page annot iteration methods more consistent. 2020-06-01 pdfium-autoroll@skia-public.iam.gserviceaccount.com Roll Code Coverage from a8f20a1dacc2 to a70177d4a2e5 (3 revisions) 2020-06-01 pdfium-autoroll@skia-public.iam.gserviceaccount.com Roll Catapult from 31b81b84c957 to 91fa1462a88f (119 revisions) 2020-05-29 nigi@chromium.org Remove repetitive |FXTEXT_CLEARTYPE| usages in fxbarcode/oned/. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:980116,chromium:980161 Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ie371134e4b5618bb5dbef9d2fd0ae33d76e4bae6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226041Reviewed-by:
-
David Bokan authored
This CL specifically fixes behavior for the test LayerTreeHostImplTest.ScrollBeforeRootLayerAttached as well as some others that check the "viewport fallback" behavior when the scroll unification flag is enabled. This test was a regression test for a crash that was occurring when a scroll occurred prior to a root layer being attached. In this case, we hit test to a nullptr for the layer. Today, we drop the scroll in this case. The initial scroll unification implementation inappropriately requestes a main thread hit test. The fix here replicates this logic in the kScrollUnification branch of ScrollBegin so that behavior is unchanged. When a hit test doesn't hit any layers, we currently fallback to using the inner viewport scroll node. There are some cases where the inner viewport scroll node doesn't exist: - UI Comopsitor never has viewport nodes - OOPIF never has viewport nodes - Have not committed from Blink yet The key problem here was that the scroll node hit test returning nullptr is actually two distinct cases that we weren't distinguishing: 1. The compositor realizes it doesn't have enough information to perform the hit test (e.g. hit a non-fast scrolling region) 2. The compositor is able to perform the hit test and there simply isn't a ScrollNode. 1 requires a main thread hit test where 2 must drop the scroll. The HitTestScrollNode method is modified here to return the additional information and makes this explicit. Bug: 1047182,1086625 Change-Id: Id547e73dc307f0118b6c8cd3625a26661b57a45d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222140 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#773985}
-
François Degros authored
Fixed comments. Made zipFileCannotOpen more consistent with zipCannotZipFile. BUG=912236 TEST=browser_tests --gtest_filter="*/zip*" Change-Id: I8ff87195fff80435e1f78ffc29fee509b06bac1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225996 Commit-Queue: François Degros <fdegros@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#773984}
-
chrome://histogramsJun Kokatsu authored
This change removes dummy histograms in chrome://histograms Bug: 1085912 Change-Id: I4fda6a684a20ce2effd601e78a7d601cdd29f4ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214041Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Jun Kokatsu <Jun.Kokatsu@microsoft.com> Auto-Submit: Jun Kokatsu <Jun.Kokatsu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#773983}
-
Harkiran Bolaria authored
As a note - this patch jumps from 47 to 49 in WebSchedulerTrackedFeature so as to prevent merge conflicts with the patch here: https://chromium-review.googlesource.com/c/chromium/src/+/2212934 Some background on why we sometimes need to disable bfcache: https://docs.google.com/document/d/1NjZeusdS1kyEkZyfLggndU1A6qVt0Y1sa-LRUxnMoK8 Change-Id: I884e7b5262938c453cea7e1792b505c3a55447bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225355 Commit-Queue: Harkiran Bolaria <hbolaria@google.com> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#773982}
-
Kenneth Russell authored
This is occasionally causing GPU process crashes, leading to random flakiness throughout the test suite. This will be handled more generally soon. Bug: 1085899, 1088465 Tbr: bsheedy@chromium.org Change-Id: I90b40c7232a1dc0238e8a7792b577a4290b84535 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225979Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#773981}
-
Gyuyoung Kim authored
This CL converts VideoDecodeClientPtr to mojo::PendingRemote<VideoDecodeClient> in the all uses of VideoDecodeClientPtr. Bug: 955171 Change-Id: Ia18b3d9ed4bd4062e2b0c94dc499f6ba84c7dcbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223837Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#773980}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=bindusuvarna@chromium.org Change-Id: I622f9f642fb456f6c540f206f8e968ab4f1b6a54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224021Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773979}
-
John Lee authored
The CSS rules in the --cr-section mixin are moved into the only CSS class left using it. A TODO has been added to address the similarity of cr-row and settings-box, but this should not be considered high priority. Bug: 973674 Change-Id: I34437c39cb38b6fe0568a243a1eee41900ab6490 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216646Reviewed-by:
-
Jarryd authored
Currently, quota internals exposes a button that is used to test the storage pressure notification, which is not yet available on Android. This change hides that section on quota internals to prevent users from crashing the browser when testing this unavailable feature. Bug: 1076794 Change-Id: I1b25cb52856be9cb419185b74b8bfd89e50f5f13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207772 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
-
Evan Stade authored
The BackgroundTask id to class mapping is provided by ChromeBackgroundTaskFactory and this param is unused. Bug: none Change-Id: Ib6e96a759a1a481de030a6ad3185c31f2cdd6e73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219313Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#773976}
-
Gyuyoung Kim authored
This CL converts the uses of CameraService interface as below, - Convert CameraServicePtr to mojo::Remote - Convert CameraServicePtrInfo to mojo::PendingRemote Bug: 955171 Change-Id: I5200a2773dfa9ef121de645bedb73d5238a823f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222087 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5c91cb1c2f1d..24e74c9857fa 2020-06-01 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-06-01 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-06-01 sokcevic@google.com Remove rev-parse --verify FETCH_HEAD If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1049610 Tbr: agable@chromium.org Change-Id: I645d96ff4a41cab3614bf670fd5ca887867b5cd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225713Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/721d6792f75d..c43545625d9c 2020-06-02 rwkeane@google.com Force CI build for Code Coverage bot test If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Ieb5205965307cb398e6e2638c8443f0b0c6ddbd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225715Reviewed-by:
-
Koji Ishii authored
When |NGLineTruncator| sets |IsHiddenForPaint|, it does so by cloning the original fragment. When hiding atomic inlines, the fragment in the inline formatting context is cloned and |IsHiddenForPaint| set, but the fragment cached in |LayoutBox| is kept unchanged, without |IsHiddenForPaint|. When such fragment has self-painting layer, the one in |LayoutBox| is painted. To hide such fragments, we moved them to outside of the clipping area, but this had visible side effects to |scrollWidth|. This patch stops moving them, but instead, check the fragment in the inline formatting context when painting and hit- testing. Bug: 1005645 Change-Id: I8d1d55afd2a2f1b6c1b6672d5090476872cb4dee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220405Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#773972}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9482d3f25987..d74336e50254 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tguilbert@google.com,ortuno@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:812428 Tbr: tguilbert@google.com,ortuno@google.com Change-Id: I9834a9748ba5b0c86e4c18b5eabdf520476be6b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225710Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773971}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fce28fa091ae..a0f5e475c56d 2020-06-01 landrey@webrtc.org Move kUsedBufferSize to header 2020-06-01 caseyfischer@google.com Revert "Add trace of enqueued and sent RTP packets" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I7e3475b7800b872a9d05d71b989ab7b84676436a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225714Reviewed-by:
-
Maggie Chen authored
This is to handle the swap chain creation failure in direct composition and direct composition overlay. By setting context lost, it has a chance to restart a new GPU command buffer without direct composition/overlay support. GL Renderer has already set context lost when SetDrawRectangles() or PostSubBuffer() fails. But this logic is missing in Skia Renderer. Bug: 1086750 Change-Id: Ie04c1437271f87b7c9838e79b61cdecb60f787e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213778 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#773969}
-
Abhijeet Singh authored
Announce the user-consent notice for Quick Answers when screen-reader is enabled. The accessibility name for the view is composed of all of its text content concatenated, by default. The accessible name and description are overridden for the view, and the announcement is made when the user-consent view is displayed. Bug: b:152059023 Test: Tested on Chrome OS Atlas test device. Change-Id: I222b139263ea748293112c26df37c226b0e43634 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222126 Commit-Queue: Abhijeet Singh <siabhijeet@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#773968}
-
Jinsuk Kim authored
https://crrev.com/c/2214802 was still instantiating EphemeralTabCoordinator for every Tab object. This CL ensures that there will be a single instance for CustomTabActivity. Bug: 1084731, 1086860 Change-Id: I04697f82397376befa63b05e47575d19d636aadf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216148 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
-
Bo Liu authored
There is no PII in this crash key. Bug: 1072407, 1075495 Change-Id: I9e13599166e9e9dfdd642fa4dd7026a9644308fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225956Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#773966}
-
Bartek Nowierski authored
There are all related to 'static_cast not related by inheritance' error. However, some may be also related to trouble appending |.get()| inside macros for |XDisplay*| Details here: https://docs.google.com/document/d/1cnpd5Rwesq7DCZiD8FIJfPGHvQN3-Gul6xib_4hwfBg/edit?ts=5ed2d317#heading=h.d05331ous77n Bug: 1069567 Change-Id: I54bc0f57f2eea492f8cd26432a09b09a7d1a8afb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222056Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#773965}
-
Gyuyoung Kim authored
This CL applies pending_receiver to the all methods in VideoAcceleratorFactory interface. Bug: 955171 Change-Id: I7c8920cd8c9f267c3ddc73733be4d72e0462cafe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223836Reviewed-by:
-
Gyuyoung Kim authored
This CL converts all uses of VideoEncodeClient to mojo::PendingRemote and mojo::Remote. Bug: 955171 Change-Id: I469adb26f11ce589f017654e70f234f43fe095c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223693Reviewed-by:
-
James Cook authored
Mustash/mash was shut down over a year ago. However, the checks for ash::Shell::HasInstance() are still needed for tests. Bug: none Change-Id: I8164a5b36c1d77286e4a092c9a5f6c4cf33878f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225377 Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
-
Peter Wen authored
java_header_group and java_impl_group have a lot of code in common. This new template adds a group_name variable and combines the original two templates. Seems like the direct non-java-lib deps are still necessary for these targets. e.g. library A depends on java_group B which has its own resource dependency. In this case, A's header requires B's resource dependency's srcjar for R.java. Also fix __res name to __resources to match other naming conventions. Bug: None Change-Id: If0d3c05225bc41c14cc2efb7eb9ea47a45ebbfc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225579 Auto-Submit: Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#773961}
-
Ayu Ishii authored
Change-Id: Icaf40f4d8da83df21e433dc9ac71c9ac7ed4fca3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225226 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
-
rbpotter authored
Closure compile: -advanced_item_test -button_strip_test -button_strip_interactive_test Bug: 1000989 Change-Id: I48fe01c9a2c25a4aca3f7b44fe59f4b78cd0dac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223373 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Bartek Nowierski authored
This allows to compare wrapped pointer directly against 0, saving us trouble to extract the pointer. Bug: 1073933 Change-Id: I071ddff9aaea723c13fcb09acb91dc4c139d7554 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223694Reviewed-by:
-
Yutaka Hirano authored
Currently web accessible resources in Chrome extensions[A] cannot be loaded as an iframe via content scripts from two reasons. 1. The response does not have a cross-origin-embedder-policy header. 2. The response does not have a cross-origin-resource-policy header. To fix the issue, we make iframes inherit parent COEP implicitly for chrome-extension:// URLs. This is similar to blob:// URLs. We also attach cross-origin-resource-policy: cross-origin to every web accessible resource. This is aligned with the fact that it also has access-control-allow-origin: *. A: https://developer.chrome.com/extensions/manifest/web_accessible_resources Bug: 1085915 Change-Id: I4574b4dbf55ab2d815e9b6ab22fd7b0a8ab28887 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212200 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#773957}
-
Gabriel Charette authored
Task APIs v3 will all have an explicit destination. In the past "default traits" meant ThreadPool. These CLs are thus a no-op except for the few callers that clearly wanted to post a QuitClosure() on the current thread (posting a QuitClosure() to a parallel task will merely bounce it back to the current thread anyways). Those few callers were migrated to ThreadTaskRunnerHandle::Get(). These changes are thus required to phase out task APIs v2 (post_task.h) Design doc: https://docs.google.com/document/d/1tssusPykvx3g0gvbvU4HxGyn3MjJlIylnsH13-Tv6s4/edit This specific change is a subset of https://chromium-review.googlesource.com/c/chromium/src/+/2216733 This CL was uploaded by git cl split. R=toyoshim@chromium.org Bug: 1026641 Change-Id: Iccaebd459d36f82f2d3ae21ffa6bb83a19321ead Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216738Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#773956}
-
Sujie Zhu authored
Only when nickname input field is focused, we will display the nickname character count (e.g. 0/25) as the suffix of the nickname input field. Local build test video (googlers only): https://drive.google.com/file/d/15B8pArRvKaJ_B_scNttkPtr4x861mLgf/view?usp=sharing Bug: 1082013 Change-Id: Ieb4f2d8d6f162911c2cb64ecf130da28c3a37b97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219304 Commit-Queue: Sujie Zhu <sujiezhu@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#773955}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1591041546-a410a758e06ddb76997f15201c691b94ce14829b.profdata to chrome-mac-master-1591055861-2c929ca1d8463b09aee877402f62f07b9528b0a1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I6dbcfd6b219729eb927e4103bfba2ad46f95e38b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226037Reviewed-by:
-
Findit authored
This reverts commit 5210afae. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 773937 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzUyMTBhZmFlZDIxOWUyMTliOGQ1YjA3NGI3MmEyYTFhNDEzMTg3YjcM Sample Failed Build: https://ci.chromium.org/b/8878645669363890464 Sample Failed Step: compile Original change's description: > Migrate md5sum tool to portable zlib utils > > Use the set of portable code from zlib that shouldn't have > extra dependencies (e.g. 'base'). > > Also allow building the tool for other targets (e.g. Linux, > OSX, etc) as that allows easier testing and profiling. > > Bug: 1076580, 1087999 > Change-Id: I3130ba77681ae66dc34c3539c2ed10476e754d86 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211008 > Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> > Reviewed-by: Adenilson Cavalcanti <cavalcantii@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#773937} Change-Id: I936d0382bc96b798b11157fddf43322d4b6df116 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1076580, 1087999 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226078 Cr-Commit-Position: refs/heads/master@{#773953}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/91fa1462a88f..e9a386951413 2020-06-01 bashi@chromium.org Fix ServiceWorkerTabTest.testClearDataForOrigin If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1055677 Tbr: nuskos@google.com Change-Id: I581b0671f016e7b63cf022159816bce26912c97c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225708Reviewed-by:
-
Sophey Dong authored
This will be used alongside ShareParams, and will contain Chrome-specific sharing parameters since ShareParams has now moved to components.browser_ui. Bug: 1079467 Change-Id: Id48c22e3f1d39d5ef18341871490fee9e69dae12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207912Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Commit-Queue: Sophey Dong <sophey@chromium.org> Cr-Commit-Position: refs/heads/master@{#773951}
-
