- 07 Jan, 2021 1 commit
-
-
Scott Violet authored
It looks like UsageStatsBridge is never destroyed. This ensures the observer it adds to HistoryService is properly removed. BUG=1158388 TEST=none Change-Id: I8640dde7b2eaf2d5701827cf800e5c52edb605d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613587Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#840831}
-
- 06 Jan, 2021 39 commits
-
-
Max Curran authored
This CL adds the methods to track the user's first interactions with the Translate UI, and the total number of interactions over the course of a page load. These values will later be logged to UKM. The CL includes the Translate compact infobar UI, but the bubble UI will be added in a later CL. Full design doc: https://docs.google.com/document/d/1dyWh1Xw5VgUA00VA-5PTgKQ6ItziPBnSyeDR8saJ9vM/edit?usp=sharing Bug: 1114868 Change-Id: I03b3945c2af1c05431907b1eb15fef5e4b1a5fbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572129 Commit-Queue: Max Curran <curranmax@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#840830}
-
chrome://flags/#enable-desktop-pwas-link-capturingAlan Cutter authored
This CL adds a feature flag for the prototype implementation of declarative link capturing for web apps. Bug: 1163398 Change-Id: I464d51bc47db9d2fa611c8aa4df939dab684df92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612606Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#840829}
-
Mitsuru Oshima authored
This reverts commit cdb0f5bb. Reason for revert: crbug.com/1157664. The fix was landed but lacros will also be pushed to m88 ash-chrome. Instead of merging the fix, we'll revert the change now and revert the revert after m89 branch cut. Original change's description: > Allow compositor server to resize the menu when necessary > > This allow the menu to resize, which in turn will enable scrolling > so that a user can use all menu options. > > I'll work on a wrap around behavior in a separate CL. > > Bug: 1099880 > Change-Id: If2f92894fb25684f12dd0f232758f9b968c8e0ad > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542854 > Commit-Queue: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: Antonio Gomes <tonikitoo@igalia.com> > Cr-Commit-Position: refs/heads/master@{#828558} TBR=oshima@chromium.org,tonikitoo@igalia.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1099880 Change-Id: Iaf399d762affb0aef65f5682082b17fd9b6301b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613646Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#840828}
-
Zhaoyang Li authored
iOS 14.3 is the 14.X runtime in the current beta Xcode version. Bug: 1158906 Change-Id: I1373c4dc6e6e513ab7252baf7451828926beb386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612494Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#840827}
-
Etienne Pierre-doray authored
This CL extracts the logic of querying battery state from PowerDrainRecorder into a new BatteryLevelProvider, to eventually reuse on other platforms. BatteryLevelProvider is platform specific. This CL implements mac only. Other platforms will be implemented in follow-up CLs. Bug: 1153193 Change-Id: I56bca3b851428483395e5edf6279087cd293e7e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574438 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#840826}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1bd38fed1b9e..f902efb9511c 2021-01-06 primiano@google.com Merge "sdk: Make examples build with MSVC" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ia51e7318d1469a20cb314e8abd97e506f7079551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612389Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840825}
-
Brian Sheedy authored
Updates the GPU documentation on adding new builders/testers to clarify what to do if adding both a new parent builder and a tester triggered by it, as it turns out that it's not as simple as performing the tester-only steps two separate times. Change-Id: Iddb3336db0fc12a22e8cb73ac6aa3dffe13f0ffe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613667 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#840824}
-
Gavin Williams authored
Margin added to the end to match the margin in the start. Before: http://screen/4rxikjreQEFFyzF After: http://screen/8fdyGdR58egL2oY Bug: 1059779 Change-Id: I01e9a6061e3d1d6efa1ccb43aa79e54e529840df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613784Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#840823}
-
Dom Schulz authored
The approach is to add the system app type to a new proto, SystemWebAppData on the web app and use that for all the IsSystemWebApp logic. This won't actually wait until an update is finished to allow an SWA to start. But it'll leverage the existing storage to have all the right metadata to allow it to start as an SWA. This has a couple of consequences, first, the SWAs will always be able tostart with the right window treatments and be a real SWA. Second, the race condition has moved, so that it's still possible to start an SWA before the upgrade has finished. In practical terms, all the code has been updated with the system image by the time we start the upgrade process, so it's just going to be metadata stuff like the icon that won't be updated. Bug: 1096887 Change-Id: I2d62dcf2c92e78e014e77a1fb085c0dc59736b29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544982 Commit-Queue: Dominic Schulz <dominicschulz@google.com> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Jiewei Qian <qjw@chromium.org> Cr-Commit-Position: refs/heads/master@{#840822}
-
Findit authored
This reverts commit da4ef766. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 840628 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2RhNGVmNzY2NTdjMWMzM2RjMGM0MWU5YTY1NzE0M2U4NDNjZWM2ODYM Sample Failed Build: https://ci.chromium.org/b/8858824985500220208 Sample Failed Step: browser_tests Original change's description: > Clean up the NoTrustedTypesViolation test > > This change clean up unnecessary test cases in the > NoTrustedTypesViolation test. Also added few things that makes > debugging of the test failure more easier. > > Bug: 1115643 > Change-Id: I12e77b3038046337f8002850f5c28806dd722acd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610486 > Reviewed-by: dpapad <dpapad@chromium.org> > Commit-Queue: Jun Kokatsu <Jun.Kokatsu@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#840628} Change-Id: Icefeac0f9258222a5deb35ec91e9abfb6ef4ebce No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1115643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613590 Cr-Commit-Position: refs/heads/master@{#840821}
-
Bettina authored
The histogram is still being used to check if the Reporter was not loaded correctly due to configuration errors. Bug: 1160889 Change-Id: Ia55166e3bab419034a2fdffc8cf82ad766bf8ef6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600241Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#840820}
-
chromium-autoroll authored
https://chromium.googlesource.com/vulkan-deps.git/+log/cbab637962d0..5cb564b68580 2021-01-06 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 4ed1f4fce9e7 to aa005e8bd435 (1 revision) 2021-01-06 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from af3a3d481f6e to 4ed1f4fce9e7 (1 revision) 2021-01-06 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 94d1a80159e3 to af3a3d481f6e (1 revision) 2021-01-06 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 98382948dfea to cc435b55410a (2 revisions) 2021-01-06 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from f77085c307fc to 480f6039e072 (1 revision) 2021-01-06 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 6d05ed8410b4 to 94d1a80159e3 (1 revision) 2021-01-06 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 37c03859de9e to 6d05ed8410b4 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-chromium-autoroll Please CC enga@google.com,radial-bots+chrome-roll@google.com,ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: enga@google.com,radial-bots+chrome-roll@google.com,ianelliott@google.com Change-Id: Ic0ee06691bdf5befaa634cb177a068d3b47382ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613325Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1609945018-bd62f654af21e53a7b023fe22e6c76c3ab0d03ca.profdata to chrome-win32-master-1609955739-17392bee52c5ddaf377dfb436abb48268c54a32a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic9e97282744fbd059616f301ce50bc4ac3fa132a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612375Reviewed-by:
-
Evan Stade authored
Use PermissionsClient to get HostContentSettingsMap. Only SiteEngagementService is updated because other files are not going to be moved to //components. This includes important_sites_util, which is not needed in //components, and site_engagement_service_unittest, which depends on Chrome code (such as incognito profiles and SiteEngagementServiceFactory). Bug: 1147274 Change-Id: I9506e2482452de1db195ccc0d5652f3def0e2f06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601451 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#840817}
-
Peter Kasting authored
Also adds a builder for TabIconView and converts to using it. Bug: 1159562,1159563 Change-Id: Ib4f10159a609b676571ea9cb9f8250a82e3f6a38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613010 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#840816}
-
Gavin Williams authored
Change-Id: Ie0c6060859a2a1b95301d55bee2ac788ee063ad1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613561 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Auto-Submit: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#840815}
-
Andrey Kosyakov authored
Doc: https://docs.google.com/document/d/180kO9C3yWs5uWuopmCuDjNtGVUNkWY8el07-tyGW7Yk Bug: 1138441 Change-Id: Ied7342d5bc638564d9a98ae6a0babf7a3d0a21fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612504 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#840814}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a8b962b78978..dc2cf6fc370e 2021-01-06 jmadill@chromium.org Roll third_party/vulkan-deps/ b08eace32..cbab63796 (17 commits; 1 trivial rolls) 2021-01-06 jmadill@chromium.org Remove "init" from VaryingPacking. 2021-01-06 jmadill@chromium.org Organize VaryingPacking methods. 2021-01-06 jmadill@chromium.org Remove ProgramLinkedResources from ProgramExecutable. 2021-01-06 timvp@google.com Capture/Replay: Don't force built-in attribs to have a location 2021-01-06 syoussefi@chromium.org Vulkan: Remove duplicate shaderType parameter to SPIR-V transformer If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Test: Test: Capture "World War Doh" Change-Id: Iecaf606d44fc49b9b67d4bc06999a516a8370981 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611211Reviewed-by:
-
Eric Willigers authored
If browser windows currently cannot be opened for the given profile, LaunchSystemWebApp exits early instead of attempting to launch a system web app. Reland of CL 2607978, with test changes to avoid failures reading profile from closed Browser. Bug: 1121894 Change-Id: If2cb1bb6576423e87f42abad476ced0a3bc24686 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610414 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#840812}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4dde23fea599..ca7d9ee2a720 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I5299b8e8b9e60f41827068392c8c3717525a01c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612270Reviewed-by:
-
Jia Meng authored
Also add thanhdng@ as an owner. Change-Id: Idb829e0186979b9d73581dc4dff7c8c42ef0b6c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612784Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#840810}
-
Dave Tapuska authored
FrameMsg_SetPepperVolume is converted to a message on the PepperPluginInstance channel. BUG=1157519 Change-Id: I507b25b951d1a231e99741ea996ff6ec2f186441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611944 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#840809}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1609945018-70431859900ba317039e4e8fedf6f4732373dd6e.profdata to chrome-win64-master-1609955739-bf9ad8193fca8e166eb0096fb68a4e9db5e69d48.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I553e85c8dfb7b4918389c51b1ec44697a1101793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611215Reviewed-by:
-
David Maunder authored
To reduce QPS to our server which serves shopping metadata, we estimate if the website is a shopping website or not and do not call the server if we do not believe the site is a shopping website (based on the bloom filter). Bug: 1158883 Change-Id: Idc4df439bdfe00d113b2411c364024cfb3bbe383 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594175 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#840807}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2ca6ad8ed38e..8e3bef4f079d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC collinbaker@google.com,tinazwang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1117773,chromium:1145728 Tbr: collinbaker@google.com,tinazwang@google.com Change-Id: Ic32b7730382bf8e9ecdfd50f08c9b24fbfbfb009 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612479Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840806}
-
Scott Violet authored
HistoryObserverImpl was adding an observer, but never removing it. This leads to a use-after-free when the class is deleted and historyservice notifies observers. BUG=1158388 TEST=none Change-Id: I596fb10791dd9a40743fae86f9e24a60a10d8aa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610991Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#840805}
-
Daniel Hosseinian authored
Add a skeleton document properties dialog element containing the fields when the document properties will get populated. Bug: 93619 Change-Id: Ied7ad9d8301c263cc64e902aa390d86438ac3eeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605971 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#840804}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/cee13faaf357..1bd38fed1b9e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I3c9e32847f3f5fa44ca806d5661c16a6afe74275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613585Reviewed-by:
-
Jeremy Roman authored
This saves a copy. Bug: None Change-Id: Id48a8cd618527f640af44dc3f7807877213f5fa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597001Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#840802}
-
Mattias Nissler authored
The existing code had a user_id_ check, but that is not sufficient for owner settings writes to go through, the private key must be present as well. Replace the check with a proper IsOwner() check. This misbehavior is only observed in DeviceSettingsServiceTest.Observer, getting exposed by a DCHECK added in [1]. It's hopefully not hit in production (otherwise tentative owner settings might get lost), but better to fix the root cause than avoiding the offending edge case in the test. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2287290/11/chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc#800 BUG=chromium:1073940 TEST=unit tests pass Change-Id: I6d5a5f17e8aeaa28600d57c7f0fcfad661434e33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611720Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Mattias Nissler <mnissler@chromium.org> Cr-Commit-Position: refs/heads/master@{#840801}
-
Daniel Murphy authored
This patch creates the new OnWebAppUninstalled event. Follow up patches will migrate systems that rely on this behavior from OnWebAppWillBeUninstalled to OnWebAppUninstalled. Patch also does a little cleanup in the sync integration tests. Bug: 1162339, 1097050, 1126404, 1111533, 1159651, 1159482 Change-Id: I5081f25f0ad0d4aa9e4245023e8b00845d43d817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606668Reviewed-by:
Phillis Tang <phillis@chromium.org> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#840800}
-
Wenbin Zhang authored
Clean up on the settings when removing reference build. Bug: chromium:1108663 Change-Id: Ie0a4211b9e3895f1dd84fb4a97cbe3ec1f230666 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612566 Commit-Queue: John Chen <johnchen@chromium.org> Auto-Submit: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#840799}
-
Sky Malice authored
Bug: 1162103 Change-Id: I0d7d17dbbedc52dead61fa79c08c32266bdaf464 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605393Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#840798}
-
Ana Salazar authored
We introduce a new option in the chrome context menu. To draw attention to this feature, we will add a new nudge next to the option. This addition will be controlled by a flag which will be initially activated in 89 stable. Bug: 1156270 Change-Id: I774fec96960eca04299f3afcde69df51b8569d8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613526Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Ana Salazar <anasalazar@chromium.org> Cr-Commit-Position: refs/heads/master@{#840797}
-
Peter Kasting authored
Bug: 1121788, 1122880 Change-Id: Icbaf40c1f58531b929d3670899c3b9e840652608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613546 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#840796}
-
Thomas Lukaszewicz authored
Bug: 1162474 Change-Id: I5a53f3c330ea7a022339cc14d54e3dde967a2a4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606672 Auto-Submit: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#840795}
-
David Black authored
In order to gauge the impact/effectiveness of the holding space welcome banner, record the interval from the time the banner is first shown to the time of the first pin to holding space from the Files app. If the first pin to holding space from the Files app occurs prior to having seen the welcome banner, record zero. Note that this CL also fixes the `metrics.recordValue()` API which was previously unused but was not correctly mapped to the private metrics API's expectations. Bug: 1163237 Change-Id: I416a3f6349163b96aead469b01ef58cc46aaa363 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610939 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#840794}
-
Collin Baker authored
This reverts commit 2d4506ca. Reason for revert: build failure https://ci.chromium.org/p/chromium/builders/ci/win-archive-rel/20860? Original change's description: > Build the BoringSSL command-line tool > > It contains a benchmarking command that should help confirm the > impact of https://chromium-review.googlesource.com/c/chromium/src/+/2595350. > > Change-Id: Id69232190a3b29538162c46568cf12558606fd44 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595253 > Commit-Queue: David Benjamin <davidben@chromium.org> > Commit-Queue: Adam Langley <agl@chromium.org> > Auto-Submit: David Benjamin <davidben@chromium.org> > Reviewed-by: Adam Langley <agl@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840764} TBR=davidben@chromium.org,agl@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I7385f137a68b92becbbe4765b1c67b797211f2b3 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613519Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#840793}
-
cfredric authored
writes and reads. Change-Id: Ib071d8444d8fa67409d69cdaaafd75998db2d35a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611965Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Cr-Commit-Position: refs/heads/master@{#840792}
-
