- 16 May, 2019 40 commits
-
-
Daniel Rubery authored
This change updates unrar to 5.7.3 and reconciles the old patch file in the few places where we have merge conflicts. Bug: 936112 Change-Id: I34da1c92e232167fbfe088730f111c3670332273 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591871Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#660571}
-
Yuwei Huang authored
* Move MuxingSignalStrategy's logic into a Core, so that caller can delete the signal strategy inside an OnSignalStrategyStateChange() callback. * It2MeNativeMessagingHost needs to create MuxingSignalStrategy on the main thread then use it on the network thread, which means MuxingSignalStrategy cannot touch the underlying signal strategies directly on the ctor. We now delay construction of the core until it is first used. Bug: 962765 Change-Id: I6fc68921ebb7ac4b629d732cb7be9aefb388e624 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615821 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#660570}
-
Zhenyao Mo authored
This is for the purpose of moving DirectCompositionSurfaceWin and its related classes to ui/gl, including: child_window_win dc_layer_tree direct_composition_surface_win direct_composition_child_surface_win swap_chain_presenter This CL also refacors direct_composition_surface_win_unittest a bit, creating DirectCompositionSurfaceTest so common code can be shared. BUG=909827 TEST=bots,gl_tests R=sunnyps@chromium.org,piman@chromium.org Change-Id: I787a437aa756c3b381445730abcb171473d12f51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600962 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Maggie Chen <magchen@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#660569}
-
Cathy Li authored
Bug: 964084 Change-Id: I1d2413dc96b72d45976d332c933528aea357045a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614684 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#660568}
-
Mitsuru Oshima authored
Bug: None Test: Run --gtest_repeat=30 and passed Change-Id: Id439d10658e3c0a32ad3921cd50b6de28e9168a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614796 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#660567}
-
Xianzhu Wang authored
This covers most of the code under renderer/core/layout, EXCEPT for those related to - Outlines - Hit testing - Multi column - Legacy inline layout TBR=fserb@chromium.org (for one line passive change in third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d.cc) Change-Id: I66e08af4dba748ea51aa53abc33a892b3f9c42af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608381Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#660566}
-
Sinan Sahin authored
Also see https://crbug.com/943873. Bug: 963385 Change-Id: Ie1849a0252771113d7cc89c13fc9a31177e7c020 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615703Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#660565}
-
Christopher Cameron authored
Metal has an extremely elevated crash rate on macOS 10.12, across all GPU vendors. Bug: 963000 Change-Id: I206f3035d9a1bbf0aa1bb1fefe23278542c58e03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614464Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#660564}
-
Maksym Onufriienko authored
Also removed unused imports for both #import "ios/chrome/test/app/web_view_interaction_test_util.h" #import "ios/web/public/test/web_view_interaction_test_util.h" This is part of EG1 to EG2 migration, which involves moving EarlGrey code from app-side helpers into test code. For GREYAsserts, the policy is to take assert- containing-helpers, modify them to return NSError* with localizedDescription containing the assert failure (in the event of a failure), and then assert on the result of the helper on the test side. Also cleaned code in internal_os repository(submit only after this cl) https://chrome-internal-review.googlesource.com/c/chrome/ios_internal/+/1284395 Bug: 922813 Change-Id: I8c1dcc1abf61a7b3886dd6886174ea6eca1b6413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604428 Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#660563}
-
Alex Moshchuk authored
On Android, we will turn on site isolation only for sites where users enter passwords. However, we can only protect such sites for navigations that occur after observing password entry, which means that passwords entered during the very first login may be unprotected (unless the site is on our whitelist of isolated sites). This CL adds a metric to measure how often this happens in practice, i.e. what fraction of password form submissions happen in processes that are locked to a single site vs those that happen in non-isolated processes. This should help understand how many password forms we're protecting in practice. Bug: 944640 Change-Id: I8e9dcc803e48aa142b972faa5f384c7002481612 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614521Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#660562}
-
Jacob DeWitt authored
The test uses a mock Daydream controller to send button and touchpad inputs. Then, the JS code checks that the input data made it through. The test also checks that the exposed Gamepad on the XRInputSource has the expected mapping and number of buttons and input axes. Changed JS functions in test_webxr_gamepad_support.html to run synchronously and have the Java and C++ code call PollJavaScriptBooleanOrFail to avoid race conditions in tests. Also updated README with some caveats. Bug: 947581 Change-Id: If5cf01b47bae525c245f561807b651fb669d2d4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601814 Commit-Queue: Jacob DeWitt <jacde@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#660561}
-
Jonathan Backer authored
Support for OOP-R for GL is determined by SupportsOOPRaster in gpu/config/gpu_info_collector.cc. This checks that GL has the extensions the Skia needs to create a GrContext. This code is not applicable to Vulkan. We will only return a valid VulkanInProcessContextProvider if Skia is able to create a GrContext with Vulkan. Bug: 962617 Change-Id: I01783c8dbb88538bc6e3c2f7c348c84c7d7ff195 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615369 Auto-Submit: Jonathan Backer <backer@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#660560}
-
Maggie Chen authored
Bug:961662 Change-Id: I094104499332bbbb08c1244995e551cd0c474d00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615803 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
-
Aaron Colwell authored
Removing reference cycle between BrowsingInstance and default SiteInstance that was accidentally introduced in http://crrev.com/c/1452714 . This is an updated version of http://crrev.com/c/1610991 which fixes the two issues in that original change. - It fixes a bug where the default SiteInstance was accidentally getting added to |site_instance_map_| - It prevents the new test case from running on build bots that run with --site-per-process since default SiteInstances are not created in that situation. Bug: 958683 Change-Id: I6803898c96604998380dd2ec56b7fdba2527b573 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614497 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#660558}
-
Kyle Spiers authored
Replace the buckets in UpgradeDetector.TimeBeforeUpgrade to use linear buckets in days rather than exponential buckets in milliseconds. because it takes users days rather than hours to update this will give us the granularity where we need it. Change-Id: Ic05d57cf3081c5d1f6e58930a33ce2b9bddfe31c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610881 Commit-Queue: Kyle Spiers <ksspiers@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#660557}
-
John Lee authored
Use 'spell check' as 2 words, update titlecase strings of spell check confirmation modal action buttons to match non-titlecase strings Bug: 961396, 961408 Change-Id: Ibb2703bbb21efb9fc9d70a130f89b32f30cffe09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603409Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#660556}
-
Martin Kreichgauer authored
This reverts commit 62ed0cea. Reason for revert: This apparently breaks an Android build where CREDENTIAL_NOT_RECOGNIZED is referenced. Original change's description: > webauthn: remove the CREDENTIAL_NOT_RECOGNIZED status > > The WebAuthn spec says that during a WebAuthn get() request, if an > authenticator returns an error in response to the request, the browser > should simply ignore that device and let the user try a different one > until the user cancels or the request times out, at which point the > browser returns a "NotAllowedError" DOMException. > > Chrome diverges from the WebAuthn spec a little in that errors from the > authenticator can cause termination of the entire request (depending on > the exact nature of the authenticator's response). Originally, this > resulted in the WebAuthn request's promise to be rejected with an error > immediately. > > To allow the relying party (RP) to distinguish a request that was > terminated due to a security key not recognizing any of the presented > credential IDs from other errors (such as the user clicking "Cancel" in > the UI), Chrome therefore returned an InvalidStateError for this > particular case, such that the RP could then inform the user that the > security key that they tapped wasn't registered with the site. > > Later, Chrome's WebAuthn implementation added an error to its own UI for > this case that informs the user that their security key wasn't > recognized. But Chrome still returns the InvalidState error with a > special message. This change aligns Chrome's behavior with the spec and > makes it return NotAllowedError in this case. > > Change-Id: Ib2a3c3134555cfc87da451a5c5738b59df674139 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602745 > Commit-Queue: Martin Kreichgauer <martinkr@google.com> > Reviewed-by: Mike West <mkwst@chromium.org> > Reviewed-by: Adam Langley <agl@chromium.org> > Cr-Commit-Position: refs/heads/master@{#660519} TBR=agl@chromium.org,martinkr@google.com,mkwst@chromium.org Change-Id: Icc31c71dbfdea5a741bf0511223e48874852ac0a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614254Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#660555}
-
Collin Baker authored
This reverts commit ad6eabaf. Reason for revert: causing error in Linux CFI builder: https://ci.chromium.org/p/chromium/builders/ci/Linux%20CFI/13578 Original change's description: > Update V8 to version 7.6.202. > > Summary of changes available at: > https://chromium.googlesource.com/v8/v8/+log/09be7f2f..8e003ab0 > > Please follow these instructions for assigning/CC'ing issues: > https://v8.dev/docs/triage-issues > > Please close rolling in case of a roll revert: > https://v8-roll.appspot.com/ > This only works with a Google account. > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel > > TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com > > Change-Id: Ib6654e2255046cfbda0dd00bed069859aa4f0241 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615624 > Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#660530} TBR=bcwhite@chromium.org,hablich@chromium.org,v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iedb5a41536b34d11313dc2a8d928ec2d00703fd8 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614701 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#660554}
-
Jun Mukai authored
Bug: 958467 Test: trybot Change-Id: I10b01e432d6f2301931852b31f6ef76412f4e933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614685Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#660553}
-
Elly Fong-Jones authored
Bug: None Change-Id: I1ee41d1b8c13fd5a25445fe4e4b5bbf658e71a9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614148 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#660552}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/31136552bc0c..226d32fcf4fa git log 31136552bc0c..226d32fcf4fa --date=short --no-merges --format='%ad %ae %s' 2019-05-16 tsepez@chromium.org Remove some bare |delete| from tests in favor of unique_ptr<>. 2019-05-16 thestig@chromium.org Make FPDF_StructElement_GetTitle() handle UTF-16BE correctly. Created with: gclient setdep -r src/third_party/pdfium@226d32fcf4fa The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Change-Id: Id4fab00b84598f78ca762f07ae966fb3838db575 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614528Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#660551}
-
Eric Willigers authored
The CSS WG is proposing to order the overflow values by block/inline instead of x/y https://github.com/w3c/csswg-drafts/issues/2988 Use count to investigate feasibility of the proposed change. Change-Id: I4e41e7b48ce1b4afa75852ac2288aeba5ff02342 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615404Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#660550}
-
Robert Liao authored
All thread checking code in Chromium should use the modern THREAD_CHECKER API, which automatically gets removed when !DCHECK_IS_ON(). BUG= Change-Id: I70d3f12915445dc14be7f03c554c32c7fc12e2b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612377Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#660549}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/72ee2533b189..ea05691e76b6 git log 72ee2533b189..ea05691e76b6 --date=short --no-merges --format='%ad %ae %s' 2019-05-16 crouleau@chromium.org [Telemetry] Deflake unittest Created with: gclient setdep -r src/third_party/catapult@ea05691e76b6 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:963978 TBR=simonhatch@google.com Change-Id: If4f0e9ca697c546215ceb23c5be999df55e217e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614524Reviewed-by:
-
Ross McIlroy authored
Multiple flags can be passed to V8 using --js-flags="--flag1 --flag2", however the requirement to quote the flags can make passing these flags via telemetry and other scripts difficult where the quoting might be lost. This CL adds the ability to pass multiple flags as --js-flags=--flag1,--flag2 to avoid the need for quoting. Change-Id: If5fcc9b3d88d933ce63068bb6e6bd138ac1c4cf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614185 Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#660547}
-
Ehsan Karamad authored
Frame-based MHV does not respect permissions now. This CL disables the test to unblock adding a test config and tracks permission support in its own bug. TBR=wjmaclean@chromium.org Bug: 963694 Change-Id: Idcf99cfcd1caa42ed82adda519892c8e97aa7f4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615500Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#660546}
-
Madeleine Barowsky authored
This change defines the logic to do WebP YUV decoding only for lossy, non-alpha images without color profiles and only when the kDecodeLossyWebPImagesToYUV flag is on. For now, we continue to veto YUV decoding until all data is received because supporting "incremental" YUV decoding in Chromium is a separate task crbug.com/943519. It also adds a few initialization calls to ImageFrameGenerator to set up plane sizes. The YUV decoding path will initially be implemented for in-process GPU rasterization and later for OOPR (Out of Process Rasterization). See bit.ly/webp-decoding-into-yuv for the design document and crrev.com/c/1338461 for a prototype CL summarizing all changes. Bug: 900589 Change-Id: I7f40517273a62288a9bf0060176f864bf30d5aca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1393003 Commit-Queue: Madeleine Barowsky <mbarowsky@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Leon Scroggins <scroggo@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#660545}
-
Weiliang Chen authored
OverlayCandidateValidator is used to validate overlay and is only used inside OverlayProcessor. This is the first CL to move the ownership of the validator to the overlay processor. This reduces the usage of trying to get the validator from the output surface. R=rjkroege Bug: 963597 Change-Id: I3541b8c4210db98862e430d23479eb8cb83698ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613581 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#660544}
-
chrome://discardsSigurdur Asgeirsson authored
Change-Id: I22847d87db876b27bc424fc53afdccf1d85b4903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611112 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#660543}
-
Yusuke Sato authored
When the user clicks a removable storage volume on the left pane, this CL shows a toast when the user has to change the ARC preference for ARC apps to access the storage. UI mock: go/filesapp-arc-extdriveaccess BUG=936814 TEST=browser_tests --enable-pixel-output-in-tests --use-gpu-in-tests \ --gtest_filter='*fileDisplayUsb*' TEST=ninja -j1500 -C out/Release ui/file_manager:closure_compile Change-Id: Id86de321c076493ed65fd2131e4a092c3f3dcc92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610507 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#660542}
-
Daniel Nicoara authored
views::Widget no longer checks for a ViewsDelegate, so create a stub so any widgets created don't cause crashes. Bug: b/132715995 Test: Run cast_shell_browsertests Change-Id: Ie9578fbff050da4c5f9f08e717953770578dbdd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615498 Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#660541}
-
Eric Roman authored
Change-Id: I4f42113c0c44209347dede29e768844299e214b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613751Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#660540}
-
Adrienne Walker authored
The new rounded corner feature on quads should prevent quads with such effects from being turned into CA layers. In the future, we could special case times where the rounded corner applies to the quad's corners directly and set this on the CA layer itself. Bug: 952137 Change-Id: Iddf7905f9558e6f606ad2bed5ead5d9af0a6907e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614498 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#660539}
-
Jun Mukai authored
TBR=tsepez@chromium.org Bug: 958198 Test: trybot Change-Id: If8f75baae9b1a9677c53bfb8d7620def30fb100f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613699Reviewed-by:
Jun Mukai <mukai@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#660538}
-
Dave Tapuska authored
Add some details how freezing and pausing works. Change-Id: I4777c3e8107d7170f90721d8d71734263934f573 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615362 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#660537}
-
Tom Anderson authored
This change just removes some python files from the sources of a static_library/source_set. No behavior changes. BUG=gn:77 R=pkasting Change-Id: I3fa44e01bf4e59b3a82090b256cd4cf8269871d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614147 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
Brandon Jones authored
Adds a new 'none' value to the XREye enum to indicate times when a view is not instrinsically associated with any specific eye. Ensured that views for inline sessions report an eye of 'none'. Bug: 963158 Change-Id: I6c091240d1c68cf658bb5f496308c08bde35e541 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615541 Commit-Queue: Brandon Jones <bajones@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#660535}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1091f02b40de..c6568afa0b63 git log 1091f02b40de..c6568afa0b63 --date=short --no-merges --format='%ad %ae %s' 2019-05-16 brianosman@google.com Remove Nima from DEPS, experiments, Viewer, etc. 2019-05-16 jvanverth@google.com Revise Mac windowing and context creation. Created with: gclient setdep -r src/third_party/skia@c6568afa0b63 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Change-Id: Id551796c8d547165ff042fe6b0556b94f44b4473 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614970Reviewed-by:
-
Peter Kasting authored
Bug: none Change-Id: I3fd98deca2b4d054613ebc678d2a79680c68d98c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615677 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#660533}
-
Peng Huang authored
This CL uses _NET_WM_SYNC_REQUEST to synchronize with desktop compositor during resize. Without this CL, resize steps are: 1. Desktop compositor(WM) resizes chrome browser window. 2. Desktop compositor draws a new frame with the current browser window without waiting chrome to complete handle the ConfigureNotify event. For SW rendering, compositor uses the content before resizing. It will out of synced size between compositor and chrome. For GPU rendering, compositor uses the framebuffer before resizing, the behavior is undefined. It cause weird artifacts. 4. Desktop compositor go to step 1, to issue a new resize. 5. Chrome finished handle the ConfigureNotify and rendered a new frame. 6. Desktop compositor draws a new frame again with right size. With this CL, resize steps are: 1. Desktop compositor sends client message _NET_WM_SYNC_REQUEST to notify about the incoming resize 2. Desktop compositor WM resizes chrome browser window. 3. Desktop compositor waits on an alert on value change of a XSYNC counter on chrome window. 4. Chrome handles the ConfigureNotify event, and renders a new frame. 5. Chrome increases the XSYNC counter on chrome window. 6. Desktop compositor gets the alert of counter change, and draws a new frame with new content from chrome. 7. Desktop compositor responses user mouse move events, and starts a new resize process, go to step 1. Change-Id: I51aafe03b8aac73ce6570976bbe36c6f4d86531a Bug: 961858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602285 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
