- 14 Apr, 2020 40 commits
-
-
Ian Clelland authored
This imports all of the tests from the public test repository at https://github.com/httpwg/structured-header-tests, which have been automatically converted from JSON to C++ unit tests. Tests which were already present in structured_headers_unittest.cc have been removed from that file, to avoid needless redundancy. Bug: 1069790 Change-Id: I05536c36cb66c7dda43aab2f6c5ae77961120a6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146237 Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#759015}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3e2809f4f0cd..fea8b94591c3 git log 3e2809f4f0cd..fea8b94591c3 --date=short --first-parent --format='%ad %ae %s' 2020-04-14 peah@webrtc.org Reland "APM: Remove the usage of AudioFrame in the AudioProcessing interface" 2020-04-14 eshr@google.com Fix wrong unit in log in VideoStreamEncoder Created with: gclient setdep -r src/third_party/webrtc@fea8b94591c3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia8c7e29782c84b8aa6a2c6c1fdc128429ced7c23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149521Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759014}
-
Matt Menke authored
We want to get rid of the single argument AddHeader() method as the two argument AddHeader() and SetHeader() methods are safer and more flexible. Bug: 1068194 Change-Id: I378a1d1252d29b53cc5f49cc8d54eb29e126fed1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149630 Commit-Queue: Robert Ogden <robertogden@chromium.org> Auto-Submit: Matt Menke <mmenke@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#759013}
-
Matt Menke authored
We want to get rid of the single argument AddHeader() method as the two argument AddHeader() and SetHeader() methods are safer and more flexible. Bug: 1068194 Change-Id: Iee2e0768724c1fb666a9cb9be27c13370781b818 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148022 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Auto-Submit: Matt Menke <mmenke@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#759012}
-
James Cook authored
Push the titles down a bit so the icons are more vertically centered. http://screen/k8RkhsSz3ps Bug: 1067212 Change-Id: Idd8784cd4a1d0aceb7a64679110f439d1c99fef4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148024 Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#759011}
-
Patrick Noland authored
Bug: 1069829 Change-Id: Ia78655f876347774423a26cfa98b8b363d498c87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148025Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#759010}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I94234579ecdfb4830cc8a67dfeb7af2ca736cfcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149497Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#759009}
-
Bettina authored
SafeBrowsingEnabled pref is turned on when Enhanced or standard protection is turned on. It is always turned off if no safe browsing is selected. Devices can be out of sync or not on the most updated versions. This means that enhanced protection may not be offered on these devices. To make sure that all safe browsing is kept consistent, SafeBrowsingEnhanced needs to also check SafeBrowsingEnabled. If the user has no safe browsing on a device and syncs user pref, all devices should not have safe browsing on unless they select a different safe browsing afterwards on any device. Bug: 1068777 Change-Id: I9a13c8347c30c965d8e0da4e704856ba9b054c30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148433 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#759008}
-
Noel Gordon authored
Mainly for my research needs: allow unusal zlib compression strategies for comparison purposes (R_HUFFMAN_ONLY, Z_RLE). Bug: 798943 Change-Id: I8a699e68a055df12c08f38d7156769f10f12e90f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148912 Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Cr-Commit-Position: refs/heads/master@{#759007}
-
Wenyu Fu authored
As follow-up of the creation of SettingsActivityTestRule. Move all the calls of ChromeActivityTestRule#startSettingsActivity to SettingsActivityTestRule#startSettingsActivity. Bug: 1066660 Change-Id: I71749ab1a3278bc0d7d1591156c2e4f9e38af49e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135146 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
-
bttk authored
This flag needs caching, because AppHooks#getCustomizationProvider() is often called before native is initialized. See also crbug.com/1069609 Bug: 1069609 Change-Id: I5113ed8277f55290db37476955ce87ed2eba72b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146056Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Ender <ender@google.com> Commit-Queue: bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#759005}
-
Peng Huang authored
WebGL 2.0 may modify texture unit 0 & sampler unit 0. However we create Skia GrContext with a ES2 context. So the skia isn't aware of the sampler unit and it will not restore sampler unit when GrContext::resetContext() is called. Fix the problem by restoring sampler unit 0 to ground state in ContextState::RestoreAllTextureUnitAndSamplerBindings() Bug: 1057271 Change-Id: I9d4c15d975236e50bfa726669eb8cbdf25b736b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148953Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#759004}
-
David Grogan authored
Turns out we've not been getting perf data or a 50/50 experiment. I verified it this time by running out/Release/content_shell --enable-features=FlexNG both before and after this change. Before: legacy flex. After: FlexNG. Bug: 845235 Change-Id: Ie053bd9a8e188f8f42b540f3c1f8e03627714f64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148655Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#759003}
-
Megan Jablonski authored
Bug: 976352 Change-Id: Ie3b9594bb28b764adda2609fe85994707def955b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136227Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#759002}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/decaee5ce9bf..75144cbad183 git log decaee5ce9bf..75144cbad183 --date=short --first-parent --format='%ad %ae %s' 2020-04-14 mathias@chromium.org Reformat front_end/emulated_devices/module.json 2020-04-14 tvanderlippe@chromium.org Port linter check to Node 2020-04-14 tvanderlippe@chromium.org Run npm audit fix to bump transitive dependencies 2020-04-14 tvanderlippe@chromium.org Update instructions for rolling Chromium dependencies 2020-04-14 pfaffe@chromium.org Fix closing the edit breakpoint dialog Created with: gclient setdep -r src/third_party/devtools-frontend/src@75144cbad183 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1066415,chromium:1070492,chromium:921504 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ibdf6e5334003ddd00d3cc9b25f1032c637a841c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148888Reviewed-by:
-
Jamie Madill authored
This regresses with a recent ANGLE CL. May be a driver bug: conformance/textures/misc/default-texture.html See bug for more details. Bug: angleproject:4569 Tbr: ynovikov@chromium.org Change-Id: Ic78513f6997e6e45b36d9e78132bfc67c071ef2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149625Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#759000}
-
Matt Menke authored
We want to get rid of the single argument AddHeader() method as the two argument AddHeader() and SetHeader() methods are safer and more flexible. In this case, switching to SetHeader() to make clear that there's only one instance of each of the headers being set. Bug: 1068194 Change-Id: Id17aba78bb54c47d4087324726b1c32920f29233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148021Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#758999}
-
George Burgess IV authored
This is a reland of 5c44b2a9. Originally reverted by I57aafeaa0e4f6bb60c22f8ea0b085282869fffd7. Original change's description: > compiler: remove `!is_android` from CrOS thinlto checks > > This was originally added for linux-chromeos builds. Now that we have > is_chromeos_device here, it's redundant, and it unintentionally disables > ThinLTO/CFI for ARC pieces of non-linux CrOS builds. > > Bug: 1062713, 1050199 > Change-Id: I27022ed72597a90ae7d2bb385729550fa8d772e6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108822 > Reviewed-by: Bob Haarman <inglorion@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Ben Pastene <bpastene@chromium.org> > Commit-Queue: George Burgess <gbiv@chromium.org> > Cr-Commit-Position: refs/heads/master@{#751505} Bug: 1062713, 1050199 Change-Id: I2116e2d80ebc11881deab80320b6530286c48ce3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146994Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#758998}
-
Aran Gilman authored
This is part of a series of changes re-implementing (and hopefully improving upon) cleanup performed in https://crrev.com/c/1922788. The intent is to reduce the number of changes not directly related to the new feature when relanding the CL. Bug: 1027612 Change-Id: Ibbc6967e43695f348f53655e46d05a547f8bd2ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144674Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Aran Gilman <gilmanmh@google.com> Auto-Submit: Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#758997}
-
Roberto Carrillo authored
R=nodir,chanli,bpastene Bug: 1027762 Change-Id: I50843a32bdedcd21c749531f5f9569365d34e11b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149290Reviewed-by:
-
Wei Li authored
App info label used gray dashed rectangle as its focus ring. That is not consistent with other places which use regular blue focus ring. This CL changes app info label to use FocusRing as well to make the appearance consistent. Since this was the only caller for canvas' DrawFocusRect() and DrawDashedRect(). We remove all those custom calls. Before and after screenshots are at https://bit.ly/2VlOdyy BUG=553726, 1059867 Change-Id: If8a2a32002ccb4ae11a28ef229a3964a662c0233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141221Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#758995}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/5bc1f981df4d..671aece845dd git log 5bc1f981df4d..671aece845dd --date=short --first-parent --format='%ad %ae %s' 2020-04-14 thestig@chromium.org Add FPDFAnnotEmbedderTest.FocusableAnnotRendering. 2020-04-14 thestig@chromium.org Update .gitignore after moving from YASM to NASM. 2020-04-14 tsepez@chromium.org Retain widgets across SetFocus() calls in CXFA_FFWidgetHandler. 2020-04-14 no-reply@google.com Mark static const class/struct members as constexpr 2020-04-14 tsepez@chromium.org Add missing brace to bug_1069700.in 2020-04-14 thestig@chromium.org Sanitize mouse wheel code. 2020-04-14 thestig@chromium.org Add FORM_OnMouseWheel(). 2020-04-14 dhoss@chromium.org Add FPDF_GetFileIdentifier() to public API Created with: gclient setdep -r src/third_party/pdfium@671aece845dd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1069700,chromium:1069789 Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ic36a9ccb58506e566bce820ea6a7b20595f610ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149524Reviewed-by:
-
Ahmed Mehfooz authored
Bug: 1035647 Change-Id: I8fa699b0dcb7ecae115d90377ab1f384cdd78859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148169Reviewed-by:
-
Brian Salomon authored
Bug: skia:10139 Change-Id: Id2b5d6beeddeb12fcc2f2e1ce0f7c1ad3c9ca4d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149628 Auto-Submit: Brian Salomon <bsalomon@google.com> Reviewed-by:
Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com> Cr-Commit-Position: refs/heads/master@{#758992}
-
Alexei Svitkine authored
This matches the CHECK in chrome/app/chrome_main_delegate.cc with the same message. These errors are not recoverable, and currently result in a CHECK being hit later in VariationsService::EnsureLocaleEquals(), which is trying to guard for locale mismatch issues. Also expands header comments to mention the empty string return value being the failure case. See ResourceBundle::LoadLocaleResources() implementation for the failure details (i.e. if empty string was returned, we either didn't load the pack file at all, or got an error loading it). Bug: 1022934 Change-Id: I4cc670cf669ed824c3b2073586941931fd38e364 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141010Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#758991}
-
Sujie Zhu authored
Replace NetworkAndLastFourDigits() with NicknameOrNetworkAndLastFourDigits() in CreditCard::LabelPiece(). The LabelPiece is used to set CreditCardEntry.metadata.summaryLabel value for the creditCardLabel (display text) in settings page. Changes of the creditCardLabel in the settings page's credit card list: Before: "Network ****2345" After: "Nickname ****2345" More details (googlers only): https://docs.google.com/document/d/1SfrBduc3gJrouT4zLmQHWtUPtcE-9JbkBGLHYgFLTFc/edit?ts=5e50549a#bookmark=id.g3yosdii8zfn Bug: 1059087 Change-Id: Iad062d727f0f0a88fd6e61d0903faf6864b8d889 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148274 Commit-Queue: Sujie Zhu <sujiezhu@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#758990}
-
Mohamed Amir Yosef authored
This table will carry the user ids for the users who prefers not to move this credential to their account store within the context of Butter 4 Passwords. Bug: 1032992 Change-Id: Id26eff2ed6f709ff4b9236b47888e6ad7fb2d288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126293 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#758989}
-
John Z Wu authored
Change-Id: Ic7bbe6dfa0bb8322b76bf674cc336fd83f2383bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145562Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#758988}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/1926de0638b6..a10a0b33493e git log 1926de0638b6..a10a0b33493e --date=short --first-parent --format='%ad %ae %s' 2020-04-14 rharrison@google.com Add warning signs about unsupported downloads (#1041) 2020-04-14 rharrison@google.com Rolling 5 dependencies and updating expectations (#1044) Created with: gclient setdep -r src/third_party/shaderc/src@a10a0b33493e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com Change-Id: Ia78ae597b9c7fd48aab6d93916a276f4b3b5e2a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149607Reviewed-by:
-
Raymond Toy authored
The node already correctly handles k-rate inputs to the two AudioParams. Thus, we just add a test for this. Bug: 1015760 Test: k-rate-audiobuffersource-connections.html Change-Id: I5ef616692ba5ba836906c39cf8593624fe782728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145701Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#758986}
-
Albert Chaulk authored
Chromecast is seeing issues when the active layer releases its resources, disabling the memory pressure listener fixes it. It is possible that because chromecast devices set critical memory pressure to very low amounts (<30MB) coupled with the gpu driver not being able to actually free memory until existing rendering commands have completed, the memory pressure handler freeing things that then get reallocated right away for the next frame can actually increase memory pressure, triggering an actual OOM condition on device Bug: b/118774931 Test: None Change-Id: Iff393de370b7250ebe5c4ec21a1f225e3887c0f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140608 Commit-Queue: Albert Chaulk <achaulk@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#758985}
-
Robbie McElrath authored
This CL moves favicon loading into SiteSettingsClient so uses of the currently uncomponentized FaviconHelper can be encapsulated in ChromeSiteSettingsClient. The SiteSettingsClient method defined here may change or go away in the future depending on how we componentize FaviconHelper. Bug: 1058597 Change-Id: I27f8ec33e18942a55e15865d4fd21280c187e4f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136283 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#758984}
-
David Van Cleve authored
This is part of a sequence of CLs implementing data removal logic for Trust Tokens [*], a prototype feature that enables annotating requests with some lightweight cryptographic state. The internal storage stores the results of these cryptographic operations, including some state necessary for maintaining privacy invariants. The first CL in the series expanded the Trust Tokens storage system to satisfy deletion requests parameterized by a network::mojom::ClearDataFilter. This CL extends NetworkContext with a Trust Tokens deletion interface and adds a call to this interface in BrowsingDataRemoverImpl. The control flow is quite similar to that for clearing reporting data (which is also scoped per-NetworkContext and deleted from BrowsingDataRemoverImpl whenever cookies are cleared). [*] https://docs.google.com/document/u/1/d/1TNnya6B8pyomDK2F1R9CL3dY10OAmqWlnCxsWyOBDVQ/edit R=csharrison Bug: 1064747 Change-Id: I989790c932d1fff2f2fe6245b9c66b456f07b31b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120102Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#758983}
-
Aran Gilman authored
Change-Id: I60ac5aebc117aa4282536ae4ada54f847f8c04ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128589Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
-
David Black authored
Previously, the STOP button would cause the timer to stop ringing. This was sufficient because we only showed a notification for ringing timers. Since we will now show notifications for ticking timers, the STOP button needs to actually remove the associated timer. This CL: - Removes the StopRinging API as it is no longer needed, and there is no need for it anytime soon (to my knowledge). - Adds a RemoveAlarmTimer API. - Updates DeepLinkUtil to reflect changes in possible AlarmTimerActions. - Updates unittests and creates a new browsertest verifying changes. Note that this CL adds assistant_timers_browsertest as assistant_browsertest is growing large. A follow up CL will migrate existing timer browsertests to the new location. Also note that this CL removes support for in-Assistant notification types since it was the sole user of the StopRinging API and there is no plan to launch the feature following standalone UI deprecation. The pipeline to support notifications of multiple types has *not* been removed at this time as it may prove useful later. Bug: b:149570650 Change-Id: I4cbf0da246237f8402b075ace0f0e1c98348e296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132622 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#758981}
-
danakj authored
The enableUseZoomForDSF method is not used in tests. The check for it being enabled does not need to go through WebTestDelegate anymore. R=avi@chromium.org Bug: 866140 Change-Id: I19d23b5e0835d2f2428fa88ae5c35bc0fa035b7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148816Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#758980}
-
chrome://discardsSigurdur Asgeirsson authored
Special-casing the 'Discards' tab to the empty tab makes the initial page load navigation entry consistent with entry on back navigation. Bug: 1070554 Change-Id: Ib1d6f271e12d97db31cd03708f89b41a26009e64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148539 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#758979}
-
Jesse Schettler authored
CHECKs were added to investigate the cause of the crashes occurring in the PrintRenderFrameHelper when OnPrintPreviewDialogClosed() is called. Remove these CHECKs now that they are no longer needed for the investigation. Bug: 1019847 Change-Id: I38b8c2ff4d7b467871a076d0f19a96665f163858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149284Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#758978}
-
Mark Schillaci authored
This CL modifies the implementation of the ACTION_IME_ENTER action on Android to now use the EditorInfo.IME_ACTION_UNSPECIFIED value as the editor action to perform. Previously this was set to IME_ACTION_NEXT and in some cases was preventing the form from being submitted. Bug: 1057254 Change-Id: I7c429224bc7a1597ca347f079eaef463aacaea84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145959Reviewed-by:
Mark Schillaci <mschillaci@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Anton Vayvod <avayvod@chromium.org> Commit-Queue: Mark Schillaci <mschillaci@google.com> Cr-Commit-Position: refs/heads/master@{#758977}
-
David Bertoni authored
The HistoryApiTest.MiscSearch and HistoryApiTest.TimedSearch tests are no longer flaky. This CL also removes an obsolete test and some broken retry code that is not exercised. Bug: 119505 Change-Id: I21640126da76c61a23558f89c6728f41e1a34fac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147681Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#758976}
-
