Commits · 069df0de88954d9be194300af0d3c44b718d536c · eriksson monteiro / tangled

02 Jul, 2009 40 commits

Disable IPCSyncChannelTest.* under Valgrind · 069df0de

nirnimesh@chromium.org authored Jul 02, 2009

Times out too often under Valgrind on Mac
Tracking bug: crbug.com/15817

Review URL: http://codereview.chromium.org/150218

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19846 0039d316-1c4b-4281-b951-d872f2087c98

069df0de

Add empty strings localized_strings to fix build breakage. · 583f25b4

jorlow@chromium.org authored Jul 02, 2009

BUG=15854
TEST=none

Review URL: http://codereview.chromium.org/149141

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19845 0039d316-1c4b-4281-b951-d872f2087c98

583f25b4

Fix some issues with extension messaging: · b9eea128

mpcomplete@chromium.org authored Jul 02, 2009

- Disconnect ports properly (javascript mistake).
- Use the right port ID when dispatching the disconnect event.
- Fix a bug with 2 extensions loaded in the same process.

BUG=12686
BUG=15798
TEST=Load an extension that uses messaging, and make sure it disconnects when you navigate or close the connecting.

Review URL: http://codereview.chromium.org/152003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19844 0039d316-1c4b-4281-b951-d872f2087c98

b9eea128

Fix the Linux2 build. · 87638af7

brettw@chromium.org authored Jul 02, 2009

I removed the extra argument from WidgetGTK::Init but didn't update these sites.

Review URL: http://codereview.chromium.org/155006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19843 0039d316-1c4b-4281-b951-d872f2087c98

87638af7

Fix scrollwheel in beachdemo · 337c60f7

gman@google.com authored Jul 02, 2009


Review URL: http://codereview.chromium.org/149139

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19842 0039d316-1c4b-4281-b951-d872f2087c98

337c60f7

Add a couple of more extension unit tests for page · ae7fe717

finnur@chromium.org authored Jul 02, 2009

actions. One for the helper function that parses
a page action from the manifest and another that
tests the page action api.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/151181

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19840 0039d316-1c4b-4281-b951-d872f2087c98

ae7fe717

GTK: when doing a drag from a web page, pass a recent mouse down to... · 50a441d8

estade@chromium.org authored Jul 02, 2009

GTK: when doing a drag from a web page, pass a recent mouse down to gtk_drag_begin() so it has a better idea what time to pass to gdk_grab_pointer().

I believe the following was happening:
- render view gets mouse down, forwards to webkit
- render view gets motion, forwards to webkit
- user releases mouse button, that event is added to the queue
- browser gets message from webkit that a drag has begun, calls gtk_drag_begin() with no event
- gtk_drag_begin initiates a cursor grab, but it only applies to events that have not yet been added to the queue
- mouse release comes up in queue; passed to render view rather than the drag widget

TEST=You can't get stuck in really short render view drags. Whereas it was really easy to repro before (especially in Xephyr), I can repro no longer.
BUG=http://crbug.com/15768

Review URL: http://codereview.chromium.org/150204

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19839 0039d316-1c4b-4281-b951-d872f2087c98

50a441d8

Fix bookmark util crash · 2fc90935

estade@chromium.org authored Jul 02, 2009

BUG=http://crbug.com/15853
TEST=none

Review URL: http://codereview.chromium.org/155004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19838 0039d316-1c4b-4281-b951-d872f2087c98

2fc90935

Pop-up chrome. · c33ab08d

jrg@chromium.org authored Jul 02, 2009

BUG=http://crbug.com/15727

TEST=Load a web page that has a popup.  Example:
  <!DOCTYPE html>
  Click button to open a new window.
  <br>
  <button onclick="w = window.open('http://www.google.com', 'New Window', 'width=512,height=512'); w.moveTo(300,300);">Open with w,h</button>

Now click on the button to get a pop-up.  In the new window, make sure
there is no "tab" area above the URL bar, and no "new tab" button.
Hit Cmd-T to create a new tab, and make sure it gets created in the
OTHER window.

More work is needed to minimize pop-up chrome more, but this'll
prevent the most brutal failures (e.g. team meeting "demo" today).


Review URL: http://codereview.chromium.org/151135

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19837 0039d316-1c4b-4281-b951-d872f2087c98

c33ab08d

Reverting 19834. · dbd43729

jorlow@chromium.org authored Jul 02, 2009

Review URL: http://codereview.chromium.org/149137

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19836 0039d316-1c4b-4281-b951-d872f2087c98

dbd43729

linux: more cleanup of passing plugin tests · 954afb37

evan@chromium.org authored Jul 02, 2009

Moved some QuickTime-dependent tests into a bug.

Review URL: http://codereview.chromium.org/150195

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19835 0039d316-1c4b-4281-b951-d872f2087c98

954afb37

Add empty strings localized_strings to fix build breakage. · 17161fd6

jorlow@chromium.org authored Jul 02, 2009

BUG=15854
TEST=none

Review URL: http://codereview.chromium.org/149134

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19834 0039d316-1c4b-4281-b951-d872f2087c98

17161fd6

Add morejs to page cycler tests. · 79eaa7db

cmp@google.com authored Jul 02, 2009

BUG=12357
TEST=page cycler runs to completion

Review URL: http://codereview.chromium.org/155003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19833 0039d316-1c4b-4281-b951-d872f2087c98

79eaa7db

Fix a typo I came across while debugging. · be8880ee

eroman@chromium.org authored Jul 02, 2009

BUG=None
TEST=None
TBR=brettw

Review URL: http://codereview.chromium.org/149128

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19832 0039d316-1c4b-4281-b951-d872f2087c98

be8880ee

Suppress valgrind errors in Apple libraries · 82dbf598

nirnimesh@chromium.org authored Jul 02, 2009

TEST=check Mac valgrind bot
BUG=15819

Review URL: http://codereview.chromium.org/149129

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19831 0039d316-1c4b-4281-b951-d872f2087c98

82dbf598

Add more functionality to the gtk task manager: · c4029f33

jhawkins@chromium.org authored Jul 02, 2009

* Columns are resizable.
* Resource icon displayed by resource name.

BUG=11392
TEST=none

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19830 0039d316-1c4b-4281-b951-d872f2087c98

c4029f33

Change status bubble so that it expands to accommodate URL's that are abridged... · 955be75d

mirandac@chromium.org authored Jul 02, 2009

Change status bubble so that it expands to accommodate URL's that are abridged in the standard width.

BUG= http://crbug.com/1455
TEST= Mouse over a link which is abridged in the status bubble. Hover for 2 seconds. Link should expand to show as much as possible without extending out of the view in which it is contained.

Review URL: http://codereview.chromium.org/146043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19829 0039d316-1c4b-4281-b951-d872f2087c98

955be75d

Move the NULLing out of WebViewImpl::delegate_ until after we close the page. · 13805a61

mpcomplete@chromium.org authored Jul 02, 2009

This allows us to receive notifications like when the V8 context is destroyed.

BUG=12686
TEST=no

Review URL: http://codereview.chromium.org/150186

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19828 0039d316-1c4b-4281-b951-d872f2087c98

13805a61

GTK: Clean up some bookmark related UI hacks. · 0d0f98ac

estade@chromium.org authored Jul 02, 2009

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/150203

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19827 0039d316-1c4b-4281-b951-d872f2087c98

0d0f98ac

Linux: rebaselining complex text layout tests. · e74a2a1c

agl@chromium.org authored Jul 02, 2009

Now that we have complex text working on Linux, I'm working on
reviewing and rebaselining the tests that we now pass.

BUG=9768,10296


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19826 0039d316-1c4b-4281-b951-d872f2087c98

e74a2a1c

Linux: rebaselining complex text layout tests. · b1caec17

agl@chromium.org authored Jul 02, 2009

Now that we have complex text working on Linux, I'm working on
reviewing and rebaselining the tests that we now pass.

BUG=10296,10344,10293,11613,10346,10459,12053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19825 0039d316-1c4b-4281-b951-d872f2087c98

b1caec17

Roll WebKit deps 45460:45473 · b03e2d9f

jorlow@chromium.org authored Jul 02, 2009

BUG=15837
TEST=new layout tests that are excluded


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19824 0039d316-1c4b-4281-b951-d872f2087c98

b03e2d9f

DevTools: Revert 19813 since it creates more problems than solves. · 4466656b
pfeldman@chromium.org authored Jul 02, 2009
```
TBR=yurys


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19823 0039d316-1c4b-4281-b951-d872f2087c98
```
4466656b

Implement Add and Update for PasswordStoreMac. · 75d112d2

stuartmorgan@chromium.org authored Jul 02, 2009

Modify LoginDatabase slightly to give PasswordStoreMac enough information to do the right thing.
Add creator code for keychain items we create, and unit tests to make sure.

BUG=11745
TEST=Visit a site for which you have a password in the Keychain. Type your username, unfocus the field, and then log in with the filled password. Log out, return to the login page, and the username and password should now autofill without user interaction.
Review URL: http://codereview.chromium.org/151176

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19822 0039d316-1c4b-4281-b951-d872f2087c98

75d112d2

Update Valgrind watchlist · 28a750d8

nirnimesh@chromium.org authored Jul 02, 2009

Review URL: http://codereview.chromium.org/150217

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19821 0039d316-1c4b-4281-b951-d872f2087c98

28a750d8

Convert menu strings to UTF16, fix some views-GTK build errors. · a5176daf

brettw@chromium.org authored Jul 02, 2009

Review URL: http://codereview.chromium.org/150171

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19820 0039d316-1c4b-4281-b951-d872f2087c98

a5176daf

Make ConnectJob::ReleaseSocket() return NULL on connection error. · 8e12ae06

willchan@chromium.org authored Jul 02, 2009

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/150205

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19819 0039d316-1c4b-4281-b951-d872f2087c98

8e12ae06

Set the WebViewDelegate earlier during WebView creation to ensure that · 78a3a6f8

darin@chromium.org authored Jul 02, 2009

DidCreateDataSource gets called when constructing the initial data source
for the WebView's main frame.

This ensures that the NavigationState associated with a WebDataSource
can never be null.  I went ahead and removed some of the null-checks
that were added to avoid other related crashes.  (To fix bug 15594, I
really really didn't want to add another one of those null checks.)

BUG=15594
TEST=partially covered by existing ui tests
R=dglazkov

Review URL: http://codereview.chromium.org/150208

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19818 0039d316-1c4b-4281-b951-d872f2087c98

78a3a6f8

TBR: · 574d5c16

rafaelw@chromium.org authored Jul 02, 2009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19817 0039d316-1c4b-4281-b951-d872f2087c98

574d5c16

Switch over to use V8 code generator upstream. · 2141664b

dglazkov@google.com authored Jul 02, 2009

R=darin
BUG=3319
TEST=no layout test regressions


Review URL: http://codereview.chromium.org/147210

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19816 0039d316-1c4b-4281-b951-d872f2087c98

2141664b

DevTools: switch to KeyboardShortcut.js from WebKit. · 170519c0

yurys@google.com authored Jul 02, 2009

Review URL: http://codereview.chromium.org/151210

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19814 0039d316-1c4b-4281-b951-d872f2087c98

170519c0

DevTools: Set up utility context earlier (prevent from crash). · 4ea5fcf6

pfeldman@chromium.org authored Jul 02, 2009

Review URL: http://codereview.chromium.org/150220

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19813 0039d316-1c4b-4281-b951-d872f2087c98

4ea5fcf6

reenable RenderViewHostManager browertest, add DownloadsCompleteObserver to ui_test_utils. · 0799d64a

rafaelw@chromium.org authored Jul 02, 2009

R=aa

Review URL: http://codereview.chromium.org/151189

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19811 0039d316-1c4b-4281-b951-d872f2087c98

0799d64a

This reverts 2 CLs that worked around a problem with NSGradient on 10.6, · f098c9fb

jeremy@chromium.org authored Jul 02, 2009

the underlying issue is fixed in the latest seed so we don't need the workaround anymore:

* r16073 "Fixup colors for inactive tab."
* r15328 "Fixes for 10.6" (only the changes to tab_cell.mm)

Review URL: http://codereview.chromium.org/151197

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19810 0039d316-1c4b-4281-b951-d872f2087c98

f098c9fb

We recently enabled reading sysctl values from inside the sandbox. This CL... · 0203ed71

jeremy@chromium.org authored Jul 02, 2009

We recently enabled reading sysctl values from inside the sandbox. This CL removes workarounds needed when sysctl reads where blocked.

Review URL: http://codereview.chromium.org/151202

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19809 0039d316-1c4b-4281-b951-d872f2087c98

0203ed71

Update V8 to version 1.2.11.1 to fix crashes when calling · 49751ba4

ager@chromium.org authored Jul 02, 2009

non-functions on the global object.

Review URL: http://codereview.chromium.org/150223

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19808 0039d316-1c4b-4281-b951-d872f2087c98

49751ba4

Add split with devtools container into the browser view. · 73863b5c

pfeldman@chromium.org authored Jul 02, 2009

Review URL: http://codereview.chromium.org/151150

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19807 0039d316-1c4b-4281-b951-d872f2087c98

73863b5c

DevTools: Move InspectorController message filtering to the injected side. · 40247a92

pfeldman@chromium.org authored Jul 02, 2009

Review URL: http://codereview.chromium.org/150219

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19806 0039d316-1c4b-4281-b951-d872f2087c98

40247a92

Update V8 to version 1.2.11. · 01b463f6

ager@chromium.org authored Jul 02, 2009

This version contains a bug fix and various performance
improvements. I particular it contains a reworking of the
representation of the global object to improve performance.

Rebaselining one layout test because of changes to the line numbers at
which an error is reported.

BUG=12548
TEST=none
Review URL: http://codereview.chromium.org/151196

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19805 0039d316-1c4b-4281-b951-d872f2087c98

01b463f6

Fix: Off-by-one errors in loops over key codes in render_view_unittest.cc · 44ce8376

yuzo@chromium.org authored Jul 02, 2009

BUG=none
TEST=n/a

Review URL: http://codereview.chromium.org/151194

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19804 0039d316-1c4b-4281-b951-d872f2087c98

44ce8376