Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 27 Apr, 2009 12 commits
  3. 26 Apr, 2009 10 commits
  5. 25 Apr, 2009 17 commits
    • beidson@apple.com's avatar
      2009-04-25 Brady Eidson <beidson@apple.com> · 42237ef8
      beidson@apple.com authored 
              Reviewed by Sam Weinig

        Some *obvious* style cleanup in my last patch.

        * History/WebBackForwardList.mm:
        (bumperCarBackForwardHackNeeded):



git-svn-id: svn://svn.chromium.org/blink/trunk@42871 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      42237ef8
    • beidson@apple.com's avatar
      2009-04-25 Brady Eidson <beidson@apple.com> · ff1399db
      beidson@apple.com authored 
              Reviewed by Oliver Hunt

        <rdar://problem/6817607> BumperCar 2.2 crashes going back (invalid WebHistoryItem)

        BumperCar was holding a pointer to a WebHistoryItem they never retain, then later
        tried to go to it.  In some cases it would be dealloc'ed first.
        When WebHistoryItems were pure Objective-C they probably got away with this more often.
        With the WebCore/Obj-C mixed WebHistoryItems it's more likely to crash.

        * History/WebBackForwardList.mm:
        (bumperCarBackForwardHackNeeded):
        (-[WebBackForwardList backListWithLimit:]):  If this is BumperCar, hang on to the
          NSArray of WebHistoryItems until the next time this method is called.
        (-[WebBackForwardList forwardListWithLimit:]):  Ditto.

        * Misc/WebKitVersionChecks.h: Added WEBKIT_FIRST_VERSION_WITHOUT_BUMPERCAR_BACK_FORWARD_QUIRK.



git-svn-id: svn://svn.chromium.org/blink/trunk@42870 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ff1399db
    • adele@apple.com's avatar
      WebCore: · 82ae4469
      adele@apple.com authored 
      2009-04-25  Adele Peterson  <adele@apple.com>

        Reviewed by Oliver Hunt.

        Fix for <rdar://problem/6712771> REGRESSION(34681): Text is no longer underlined after delete
        https://bugs.webkit.org/show_bug.cgi?id=25396

        Test: editing/deleting/delete-br-013.html

        * editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs):
         Only preserve an empty paragraph's style when moving paragraphs around if the selection is still 
         in an empty paragraph after the move occurs.  This was causing the empty paragraph's style to overwrite
         the previous paragraph's style during a delete of an empty paragraph.

LayoutTests:

2009-04-25  Adele Peterson  <adele@apple.com>

        Reviewed by Oliver Hunt.

        Test for <rdar://problem/6712771> REGRESSION(34681): Text is no longer underlined after delete
        https://bugs.webkit.org/show_bug.cgi?id=25396

        * editing/deleting/delete-br-013.html: Added.
        * platform/mac/editing/deleting/delete-br-013-expected.checksum: Added.
        * platform/mac/editing/deleting/delete-br-013-expected.png: Added.
        * platform/mac/editing/deleting/delete-br-013-expected.txt: Added.



git-svn-id: svn://svn.chromium.org/blink/trunk@42869 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      82ae4469
    • eric.carlson@apple.com's avatar
      2009-04-25 Eric Carlson <eric.carlson@apple.com> · 6fd0c25e
      eric.carlson@apple.com authored 
              Reviewed by Darin Adler.

        <rdar://problem/6808171> REGRESSION (3-4): Standalone media documents don't 
        properly display non-linear media

        If a media engine claims it can support the MIME type, WebCore now creates a <video>
        element for document mode media files instead of an <embed> element. Because WebCore's 
        QuickTime backed media players do not support every kind of media the QuickTime plug-in
        supports, and because it is not always possible to tell what type of media is in a file 
        without opening and parsing it, some types of media that used to be displayed properly
        by a plug-in are no longer supported properly. To fix this, if the media engine
        sees that it can not completely support a media file it now informs the media 
        document, which replaces the <video> element with an <embed>.
        
        r42301 landed support for OSX. This patch modifies those changes slighly and adds support
        for Windows.

        * loader/MediaDocument.cpp:
        (WebCore::MediaDocument::MediaDocument): Initialize m_replaceMediaElementTimer.
        (WebCore::MediaDocument::mediaElementSawUnsupportedTracks): Don't replace the <video> 
        element immediately.
        (WebCore::MediaDocument::replaceMediaElementTimerFired): Renamed from replaceVideoWithEmbed.
        Set body margin-width and margin-height to 0 as that is what a PluginDocument uses.
        * loader/MediaDocument.h:

        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::loadStateChanged): Don't do anything if m_hasUnsupportedTracks.
        (WebCore::MediaPlayerPrivate::rateChanged): Ditto.
        (WebCore::MediaPlayerPrivate::timeChanged): Ditto.
        (WebCore::MediaPlayerPrivate::didEnd): Ditto.
        (WebCore::MediaPlayerPrivate::repaint): Ditto.
        (WebCore::MediaPlayerPrivate::paint): Ditto.
        (WebCore::MediaPlayerPrivate::sawUnsupportedTracks): Set m_hasUnsupportedTracks before callback.

        * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
        (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Initialize m_totalTrackCount and m_hasUnsupportedTracks.
        (WebCore::MediaPlayerPrivate::updateStates): Call sawUnsupportedTracks if the movie has unsupported
        media type(s) or if it fails completely.
        (WebCore::MediaPlayerPrivate::sawUnsupportedTracks): New, disable the movie object and tell the
        media player client we won't play this movie correctly.
        (WebCore::MediaPlayerPrivate::didEnd): Don't do anything if m_hasUnsupportedTracks.
        (WebCore::MediaPlayerPrivate::setSize): Ditto.
        (WebCore::MediaPlayerPrivate::setVisible): Ditto.
        (WebCore::MediaPlayerPrivate::paint): Ditto.
        (WebCore::MediaPlayerPrivate::movieEnded): Ditto.
        (WebCore::MediaPlayerPrivate::movieLoadStateChanged): Ditto.
        (WebCore::MediaPlayerPrivate::movieTimeChanged): Ditto.
        (WebCore::MediaPlayerPrivate::movieNewImageAvailable): Ditto.
        * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:

        * platform/graphics/win/QTMovieWin.cpp:
        (QTMovieWinPrivate::task): Stop the task timer if we were disabled during the load state
        change callback.
        (QTMovieWinPrivate::drawingComplete): Don't do anything if disabled.
        (QTMovieWin::QTMovieWin): Initialize m_disabled.
        (QTMovieWin::disableUnsupportedTracks): Return total number of tracks.
        (QTMovieWin::setDisabled): New, set m_disabled flag.
        * platform/graphics/win/QTMovieWin.h:



git-svn-id: svn://svn.chromium.org/blink/trunk@42868 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      6fd0c25e
    • kov@webkit.org's avatar
      2009-04-25 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> · 17952444
      kov@webkit.org authored 
              Reviewed by Xan Lopez.

        https://bugs.webkit.org/show_bug.cgi?id=24786
        WebKitDownload sometimes suggests peculiar filenames

        Refactor the emission of the download-requested signal so that we
        have less code duplication.

        * WebCoreSupport/ContextMenuClientGtk.cpp:
        (WebKit::ContextMenuClient::downloadURL):
        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::startDownload):
        * webkit/webkitprivate.h:
        * webkit/webkitwebview.cpp:

git-svn-id: svn://svn.chromium.org/blink/trunk@42867 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      17952444
    • jmalonzo@webkit.org's avatar
      2009-04-25 Jan Michael Alonzo <jmalonzo@webkit.org> · fd2d51dc
      jmalonzo@webkit.org authored 
              Reviewed by Xan Lopez.

        [GTK] Error reporting
        https://bugs.webkit.org/show_bug.cgi?id=18344

        Fix the SOUP resource handle to report SOUP_HTTP_ERROR for Soup
        errors and G_IO_ERROR for gio errors.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::finishedCallback):
        (WebCore::ResourceHandle::startHttp):
        (WebCore::ResourceHandle::start):
        (WebCore::readCallback):
        (WebCore::openCallback):
        (WebCore::queryInfoCallback):
        (WebCore::ResourceHandle::startGio):

2009-04-25  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Xan Lopez.

        [GTK] Error reporting
        https://bugs.webkit.org/show_bug.cgi?id=18344

        Update FrameLoad errors to use WebKitErrors.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::cancelledError):
        (WebKit::FrameLoaderClient::blockedError):
        (WebKit::FrameLoaderClient::cannotShowURLError):
        (WebKit::FrameLoaderClient::interruptForPolicyChangeError):
        (WebKit::FrameLoaderClient::cannotShowMIMETypeError):
        (WebKit::FrameLoaderClient::fileDoesNotExistError):
        (WebKit::FrameLoaderClient::pluginWillHandleLoadError):
        (WebKit::FrameLoaderClient::shouldFallBack):
        * webkit/webkiterror.h: Added.
        * webkit/webkiterror.cpp: Added.

2009-04-25  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Xan Lopez.

        [GTK] Error reporting
        https://bugs.webkit.org/show_bug.cgi?id=18344

        Add webkiterror to the build.

        * GNUmakefile.am:

git-svn-id: svn://svn.chromium.org/blink/trunk@42866 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      fd2d51dc
    • jmalonzo@webkit.org's avatar
      2009-04-25 Jan Michael Alonzo <jmalonzo@webkit.org> · 6154a4d4
      jmalonzo@webkit.org authored 
               Reviewed by Xan Lopez.

         [GTK] Error reporting
         https://bugs.webkit.org/show_bug.cgi?id=18344

         Add the default error page for installation.

         * GNUmakefile.am:

2009-04-25  Jan Michael Alonzo  <jmalonzo@webkit.org>

         Reviewed by Xan Lopez.

         Display a default error page for load errors.

         * WebCoreSupport/FrameLoaderClientGtk.cpp:
         (WebKit::FrameLoaderClient::dispatchDidFailLoad):
         * resources/error.html: Added.

git-svn-id: svn://svn.chromium.org/blink/trunk@42865 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      6154a4d4
    • jmalonzo@webkit.org's avatar
      2009-04-25 Jan Michael Alonzo <jmalonzo@webkit.org> · 5757029f
      jmalonzo@webkit.org authored 
               Reviewed by Xan Lopez.

         [GTK] Error reporting
         https://bugs.webkit.org/show_bug.cgi?id=18344

         Add a WebKitWebFrame API to load alternate content for unreachable URLs.
         Also add a new signal "load-error" for handling load errors.

         * WebCoreSupport/FrameLoaderClientGtk.cpp:
         (WebKit::FrameLoaderClient::postProgressFinishedNotification):
         (WebKit::FrameLoaderClient::dispatchDidFailLoading):
         (WebKit::FrameLoaderClient::dispatchDidFailProvisionalLoad):
         (WebKit::FrameLoaderClient::dispatchDidFailLoad):
         * webkit/webkitwebframe.cpp:
         * webkit/webkitwebframe.h:
         * webkit/webkitwebview.cpp:

git-svn-id: svn://svn.chromium.org/blink/trunk@42864 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      5757029f
    • oliver@apple.com's avatar
      Build fix. · ddc4a7b5
      oliver@apple.com authored 
      
git-svn-id: svn://svn.chromium.org/blink/trunk@42863 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ddc4a7b5
    • jmalonzo@webkit.org's avatar
      2009-04-25 Jan Michael Alonzo <jmalonzo@webkit.org> · e8829099
      jmalonzo@webkit.org authored 
              Reviewed by Oliver Hunt.

        Gtk build fix - check if we have MADV_FREE before using it.

        * interpreter/RegisterFile.cpp:
        (JSC::RegisterFile::releaseExcessCapacity):
        * wtf/Platform.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@42862 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      e8829099
    • kov@webkit.org's avatar
      2009-04-25 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> · dacfe7ad
      kov@webkit.org authored 
              Reviewed by Mark Rowe.

        Only set the new URL once for the request. Doing it a second time
        after the call to willSendRequest was causing crashes when
        redirected requests got cancelled.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::restartedCallback):

git-svn-id: svn://svn.chromium.org/blink/trunk@42861 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      dacfe7ad
    • kevino@webkit.org's avatar
      wx build fix. Switching JSCore from a static lib to a dynamic lib to match the... · f6a3a134
      kevino@webkit.org authored 
      wx build fix. Switching JSCore from a static lib to a dynamic lib to match the Apple build and fix symbol exports.


git-svn-id: svn://svn.chromium.org/blink/trunk@42860 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      f6a3a134
    • kevino@webkit.org's avatar
      wx build fix. Adding ScriptEventListener.cpp. · 3cdb1253
      kevino@webkit.org authored 
      
git-svn-id: svn://svn.chromium.org/blink/trunk@42859 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      3cdb1253
    • jmalonzo@webkit.org's avatar
      2009-04-24 Laszlo Gombos <laszlo.1.gombos@nokia.com> · 9008d83f
      jmalonzo@webkit.org authored 
              Rubber-stamped by Mark Rowe.

        https://bugs.webkit.org/show_bug.cgi?id=25337
        Move ThreadingQt.cpp under the qt directory.

        * JavaScriptCore.pri:
        * wtf/ThreadingQt.cpp: Removed.
        * wtf/qt/ThreadingQt.cpp: Copied from JavaScriptCore/wtf/ThreadingQt.cpp.



git-svn-id: svn://svn.chromium.org/blink/trunk@42858 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      9008d83f
    • jmalonzo@webkit.org's avatar
      2009-04-24 Laszlo Gombos <laszlo.1.gombos@nokia.com> · a05ed31a
      jmalonzo@webkit.org authored 
              Rubber-stamped by Mark Rowe.

        https://bugs.webkit.org/show_bug.cgi?id=25338
        Move ThreadingGtk.cpp under the gtk directory.

        * GNUmakefile.am:
        * wtf/ThreadingGtk.cpp: Removed.
        * wtf/gtk/ThreadingGtk.cpp: Copied from JavaScriptCore/wtf/ThreadingGtk.cpp.



git-svn-id: svn://svn.chromium.org/blink/trunk@42857 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      a05ed31a
    • jmalonzo@webkit.org's avatar
      2009-04-24 Jan Michael Alonzo <jmalonzo@webkit.org> · b4f87842
      jmalonzo@webkit.org authored 
              Rubber-stamped by Gustavo Noronha.

        Fix braces to comply with style guidelines.

        * WebCoreSupport/PasteboardHelperGtk.cpp:
        (WebKit::PasteboardHelperGtk::getClipboard):
        (WebKit::PasteboardHelperGtk::getCopyTargetList):
        (WebKit::PasteboardHelperGtk::getPasteTargetList):

git-svn-id: svn://svn.chromium.org/blink/trunk@42856 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      b4f87842
    • jmalonzo@webkit.org's avatar
      2009-04-24 Sergio García-Cuevas <sergio_gcg@telefonica.net> · 73f2badf
      jmalonzo@webkit.org authored 
              Reviewed by Gustavo Noronha.

        https://bugs.webkit.org/show_bug.cgi?id=17267
        [GTK] Primary selection/clipboard support

        Copy the link location to the primary selection as well as the
        clipboard selection when using the "copy link selection" context
        menu entry.

        * platform/gtk/PasteboardGtk.cpp:
        (WebCore::Pasteboard::writeURL):
        * platform/gtk/PasteboardHelper.h:

2009-04-24  Sergio García-Cuevas  <sergio_gcg@telefonica.net>

        Reviewed by Gustavo Noronha.

        https://bugs.webkit.org/show_bug.cgi?id=17267
        [GTK] Primary selection/clipboard support

        Add a method for getting the primary selection.

        * WebCoreSupport/PasteboardHelperGtk.cpp:
        (WebKit::PasteboardHelperGtk::getPrimary):
        * WebCoreSupport/PasteboardHelperGtk.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@42855 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      73f2badf
  7. 24 Apr, 2009 1 commit