GitLab

This was most recently reverted in
https://chromium-review.googlesource.com/c/chromium/src/+/1906545
due to failures on some ChromeOS platforms, which lack the necessary
tables to allow stack-trace unwinding.

Bug: 999737, 706728
Change-Id: I7889416cd2ae9b6a09caf9eebb68a5ccf8bf4ca3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911680
Auto-Submit: Wez <wez@chromium.org>
Commit-Queue: Albert J. Wong <ajwong@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714735}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/92ac890fc48d..6d06b6613559

git log 92ac890fc48d..6d06b6613559 --date=short --no-merges --format='%ad %ae %s'
2019-11-12 lamontjones@chromium.org Revert "cbuildbot: run PaygenStage after ArchiveStage finishes."

Created with:
  gclient setdep -r src/third_party/chromite@6d06b6613559

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: Ic9f4edd5d746f481d8378a8eb8688a530cb26805
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913383Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#714734}

GLES2DecoderImpl hooks into GLStateRestorer for virtual context
switching. These hooks work even without enabling virtual contexts and
are used in DirectContextProvider::SetGLRendererCopierRequiredState.

GLES2DecoderPassthroughImpl does not have any state restoration hooks.
This CL explicitly sets state used by GLRendererCopier, GLScaler, and
GLI420Converter.

Bug: 1016833
Change-Id: I7ebead5148411677765b3d4635871873b7af0018
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912907Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714733}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9577daf6673d..0db01f0fabd1

git log 9577daf6673d..0db01f0fabd1 --date=short --no-merges --format='%ad %ae %s'
2019-11-12 ehmaldonado@chromium.org git-cl: Make tests run on Python 3.

Created with:
  gclient setdep -r src/third_party/depot_tools@0db01f0fabd1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=agable@chromium.org

Bug: chromium:1002209
Change-Id: I5bcd9f0a5f50cc67d63325d68b55860b9b98f88e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913384Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#714732}

R=enne@chromium.org

Change-Id: I2b072c2a0aaaad11d04839a0efe3ba577f828040
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912652Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714731}

WebLayer had a lot of presubmit warnings related to javadocs, which I
think was causing people to forget to run "git cl format". This fixes
all warnings, so we should no longer ignore presubmit findings.

Change-Id: I68baa6f22c38fe54d65a3affc65117dbfd5ec1c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913203
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714730}

Currently, the thumbnail image for the current wallpaper is distorted
if the wallpaper image is the user's file (not provided by Google).
Instead of resizing the image to a distorted state for the current
wallpaper thumbnail, this CL ensures that the thumbnail image is scaled
properly and center cropped.

Before screenshot--
https://screenshot.googleplex.com/mBZziQFOf3W

After screenshot--
https://screenshot.googleplex.com/OjYfOhyfFSK

Fixed: 985542
Change-Id: Idf698141a7ac6b38e797d9bd91d256ce5ea02db4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911229
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714729}

This reverts commit 0319eb27.

Reason for revert: Rationale for this change was incorrect; browser-side DiscardableSharedMemory objects _always_ have their handles closed.

Original change's description:
> [base] Don't try to decommit pages if they're about to be unmapped.
> 
> DiscardableSharedMemory::Purge() attempts to proactively discard pages
> to prevent slow-to-respond clients from keeping the pages live longer.
> 
> If the instance is in-process then these kernel calls are unnecessary
> since the memory is about to be unmapped anyway.
> 
> Bug: 1023693
> Change-Id: I2bc19eb64f3fdc009c5bf8c4ed6369b2b5081045
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911487
> Auto-Submit: Wez <wez@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Commit-Queue: Wez <wez@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#714684}

TBR=dcheng@chromium.org,wez@chromium.org

Change-Id: I2b451e314a1ee73757cad5c492d6fd550eb83a09
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1023693
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913599Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714728}

This allows our client code (coming) to load in a sandboxed iframe.

Bug: 1012578, b/144121590
Change-Id: I0e3a1442a9d2959652a36737b8b22abd4d633de9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904552
Commit-Queue: Rachel Carpenter <carpenterr@google.com>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714727}

This CL is removing the unused method:
  void Canvas::DrawFadedString(...);

Change-Id: I77c279ab1de9cf587b840142563501cb870fff79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902477Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714726}

TBR=pkotwicz@chromium.org

Bug: 1023437
Change-Id: I79f0974609260af143d1956ab4ecc0ba437807c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913464Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714725}

This is in preparation of migratincg WebUI pages that depend on
it (History, Downloads, Settings) to Polymer3.

Bug: 1022215
Change-Id: I536beb13fa639ad6ecf20d2b414c5bd23f5032f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912799Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714724}

This reverts commit 5e94ee4e.

Reason for revert: ParentAccessServiceTest tests are failing on linux-chromeos-google-rel https://crbug.com/1023998

Original change's description:
> Convert ParentAccessServiceTest to LoggedInUserMixin for child login
> 
> Currently, ParentAccessServiceTest uses LoginPolicyTestBase to log in
> as child user for tests. We should deprecate LoginPolicyTestBase in
> favor of LoggedInUserMixin instead. This CL converts
> ParentAccessServiceTest to replace LoginPolicyTestBase with
> LoggedInUserMixin for logging in as child user for tests.
> 
> Bug: 1014663
> Change-Id: I66f8c308e87efd49945ac322d969d162104ff130
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909273
> Reviewed-by: Aga Wronska <agawronska@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Commit-Queue: Toby Huang <tobyhuang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#714592}

TBR=xiyuan@chromium.org,agawronska@chromium.org,tobyhuang@chromium.org

Change-Id: I0bb109845474112a545431adb5f575f135e69dfd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1014663, 1023998
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913577Reviewed-by: Aga Wronska <agawronska@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714723}

When starting animation to target drag state when sliding app window
into home screen, if target home visibility is shown,
HomeLauncherGestureHandler will hide and minimize the dragged window,
which might cause focus to move to app list, and app list visibility
to get updated before home gesture launcher animation is finished.
If the app list visibility is changed at this point, the observers
(notably shelf layout manager) will still think that the home state is
changing, and will update its state accordingly. The state would not
get updated when the animation finishes, given that another
AppListVisibilityChanged notification would be skipped after the
animation state is updated.

To avoid this, delay the AppListVisibiltiyChanged notification until
the home launcher finishes the transition.

BUG=1021253

Change-Id: I65d06cb88fd7042ca8df0a1a84d24109ccaa0e80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894750Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Manu Cornet <manucornet@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714722}

Bug: 1021948
Change-Id: I74e0975de611056948613411217b6d6b75a0e6d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912885Reviewed-by: Max Moroz <mmoroz@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714721}

The dep roll is currently blocked due to a recent change that adds a new
value to the enum:

  error: enumeration value 'InputEvent_Type_DOUBLE_TAP' not handled in
  switch [-Werror,-Wswitch]

This change unblocks the roll.

https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1873850
https://chromium-review.googlesource.com/c/chromium/src/+/1907072

Test: Build
Bug: None
Change-Id: I00e27b31d35607d094dff60f196e9b7307e9e89e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913019
Auto-Submit: Victor Hsieh <victorhsieh@chromium.org>
Reviewed-by: David Jacobo <djacobo@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Victor Hsieh <victorhsieh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714720}

As part of go/cros-sync and go/split-settings-sync we're creating a new
OOBE sync consent dialog. The main new feature is that the user can turn
OS sync off in the dialog and the OS sync system will never start.
OS sync is tied to a user profile pref that is set only when the user
closes the dialog.

This version of the dialog has placeholder strings and layout. Strings
won't be available until M81 and I suspect the layout might change.

See bug for screenshot and link to mocks.

Bug: 1023854
Test: added to browser_tests
Change-Id: I3e86a827eae1d80b8784b89b433d9aebb92eb5d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912899Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714719}

https://swiftshader.googlesource.com/SwiftShader.git/+log/e2f83aa33d88..59fa599a2a59

git log e2f83aa33d88..59fa599a2a59 --date=short --no-merges --format='%ad %ae %s'
2019-11-12 tobine@google.com Vulkan:maxPerStageDescriptorStorageBuffers = 16
2019-11-12 nicolascapens@google.com Revert "Suppress 32-bit MSVC warning."

Created with:
  gclient setdep -r src/third_party/swiftshader@59fa599a2a59

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=swiftshader-team+autoroll@google.com

Bug: chromium:b/140575360
Change-Id: I1bca610b71693702359d01326e68da6508d56335
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913208Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#714718}

Greatly simplifies the startup delay before allowing probes by moving
all the delay logic outside the contexts.  Now probes can be triggered
without any worry of conflicts between the delay logic and context
creation/removal.  No hanging delay timers with references to contexts
that may or may not be valid.

Within HostResolver/DnsClient, probes are started when requested and
cancelled when cancelled.

Bug: 1013350
Change-Id: I9189f16e13f8f3fd4b51a081bef7676f7c3330a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902236
Commit-Queue: Eric Orth <ericorth@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714717}

BUG=695115

Change-Id: I58d7e2ddbc004be6fcf16ca2b203e0f85132645f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911223
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714716}

Bug: 1001643
Change-Id: I2bf3e664a720055baa91bd062f170b70d77ee226
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893407Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Haiyang Pan <hypan@google.com>
Cr-Commit-Position: refs/heads/master@{#714715}

This reverts commit 2ef6fce8.

Reason for revert: This CL broke GPU FYI Win x64 DX12 Vulkan Builder (dbg)

https://ci.chromium.org/p/chromium/builders/ci/GPU%20FYI%20Win%20x64%20DX12%20Vulkan%20Builder%20%28dbg%29

lld-link: error: obj/gpu/vulkan/vulkan/vulkan_instance.obj: locally defined symbol imported: public: __cdecl gpu::VulkanInfo::VulkanInfo(void) (defined in obj/gpu/config/vulkan_info/vulkan_info.obj) [LNK4217]


Original change's description:
> Add vulkan information in about::gpu page
> 
> This CL adds VulkanInfo in GPUInfo, and then send it to browser
> process with GPUInfo. And it will be serialized to binary data and pass
> to about:gpu page for displaying.
> 
> This CL adds a vulkan_types.mojom generated from vulkan header file.
> The structs in that files have many fields. It increases binary size.
> The increasing is expected.
> 
> Bug: 887018
> Change-Id: I2725326091ef47c3034939b3970d0e5bbaf6dc3f
> Binary-Size: Size increase is unavoidable (see above)
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868832
> Reviewed-by: Zhenyao Mo <zmo@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
> Reviewed-by: Jonathan Backer <backer@chromium.org>
> Commit-Queue: Peng Huang <penghuang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#714424}

TBR=penghuang@chromium.org,backer@chromium.org,zmo@chromium.org,kbr@chromium.org,tsepez@chromium.org,alexmos@chromium.org

Change-Id: I3b0aff2cfcfa8b65df2ca9109325451567cf8039
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 887018
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913565Reviewed-by: Chris Blume <cblume@chromium.org>
Commit-Queue: Chris Blume <cblume@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714714}

The experiment was tested on 50% of Canary, Dev and Beta, result was
as expected. Adding to FTTC before moving to Stable.
https://screenshot.googleplex.com/wuVmDDsVOXH.png

Bug: 940648
Change-Id: If63dc8bd94703f9c59b236516d398369b4655aa8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912519
Auto-Submit: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714713}

This reverts commit 2308d074.

Reason for revert: This broke `git cl upload` with string changes.

Original change's description:
> Support grdp files in translation screenshot presubmit
> 
> Translation screenshots project requires Chrome devs to upload UI
> screenshots along with string changes in .grd and .grdp files. These
> are XML files containing all user visible strings in Chrome.
> 
> Translation screenshots has a presubmit checks that extracts the
> list of modified strings, looks for image files associated with these
> strings and warns the developer to add them if they are missing.
> 
> This presubmit parses .grds to extract the list of modified strings but
> it skips <part> tags which are used to reference .grdp files. As a
> result, the presubmit currently ignores string changes in .grdp files.
> .grdp files contain the majority of UI strings in Chrome, so the lack of
> presubmit checks for them results in low translation screenshot coverage.
> 
> This CL changes how .grdp files are loaded in the presubmit: Previously,
> they were written in a temporary directory alongside a fake .grd file
> that referenced the loaded .grdp file. The code loaded the fake .grd file
> which resulted in loading the strings in the actual .grdp file. However,
> test mocks override all os.path methods which in turn breaks temporary
> directory creation. As a result, it was not possible to properly test
> the .grdp loading code, so we skipped <part> tags as a workaround.
> 
> The new loading code writes a temporary copy of the .grdp file and wraps
> its contents with proper tags so that it can be loaded as a .grd file
> instead. This avoids the need to create a temporary directory and is
> fully testable.
> 
> The end result is that Translation Screenshots presubmit will now ask
> Chrome devs to upload screenshots for changes in .grdp files. This should
> significantly increase the coverage of strings with translation screenshots,
> leading to better quality in string localizations.
> 
> Bug: 924652
> Change-Id: Iae7933e8147cefdabc15ef21d2b6daa43d5002bc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875554
> Reviewed-by: anthonyvd <anthonyvd@chromium.org>
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#714550}

TBR=meacer@chromium.org,anthonyvd@chromium.org,jochen@chromium.org

Change-Id: I1a6ee198b1dd76e84bcf962cd2396f4d00c5c126
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 924652
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913564Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714712}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/119ab23ab620..cea09e02b1a6


Created with:
  gclient setdep -r src-internal@cea09e02b1a6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: I2e8791ba18c9dddb264bfdd3179dbd0e4069769a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912774Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#714711}

Bug: 1020530
Change-Id: I8fdbd312edb9e98ffa2f089b7d227c4065e416c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912901Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Tim Song <tengs@chromium.org>
Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714710}

This splits the webview and weblayer component strings into separate
paks, so that weblayer can include english only translations of the
necessary strings.

Bug: 1021257
Change-Id: I636586b29cdf2564cd6e7bbd5c72feeb965ce3eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912654
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714709}

https://skia.googlesource.com/skia.git/+log/581108137b46..8c1e0effbbe1

git log 581108137b46..8c1e0effbbe1 --date=short --no-merges --format='%ad %ae %s'
2019-11-12 mtklein@google.com sketch out structure for ops with immediates
2019-11-12 mtklein@google.com implement assert_true on x86
2019-11-12 mtklein@google.com add Release SkVMBlitter bot
2019-11-12 robertphillips@google.com Remove final usage of GrProgramDesc's header

Created with:
  gclient setdep -r src/third_party/skia@8c1e0effbbe1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC halcanary@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=halcanary@google.com

Bug: None
Change-Id: I7aa576f2288c0967c7adca7f312e82a431f041fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912775Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#714708}

Rather than supplying a callback when querying the Autocomplete system,
this CL makes the NTP realbox updates its UI every time
AutocompleteControllerDelegate's OnResultChanged() is called. This allows
the UI to get updated with not just the first, but also the subsequent
Autocomplete updates.

Bug: 243926
Change-Id: I435d6985487995038f41e68616bc0147f9955d52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875030
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714707}

TBR=govind@chromium.org

Change-Id: I0b67efd7e5ea32281d8dbaa3a40c1f1ff7152f8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913161Reviewed-by: Ben Mason <benmason@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714706}

The new name better reflects what this function actually does, which is
check all frames in the WebContents and return true if any of them
have *either* beforeunload *or* unload handlers.  This is purely a
rename with no behavior changes.

Bug: 1015882
Change-Id: I07962047ccb2711eeb7fe3e2272fd1476011bc38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895886Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714705}

Since the EphemeralTabToolbar's layout has been reused by
PaymentHandlerToolbar. The layout will be more readable if it
uses a more general name.

In this patch, we change the name in the following manners:
* ephemeral_tab_toolbar --> sheet_tab_toolbar
* preview_tab_toolbar_height --> sheet_tab_toolbar_height
* ephemeral_tab_text --> upper_text
* ephemeral_tab_caption --> lower_text

Bug: 999196

Change-Id: Ia993c024f192980d071461f46b73a40106457d50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911604
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714704}

Support global configuration options being read from /config/data.
This allows some WebEngine properties to be tailored to suit the
specific device and system configuration.

Initially two options are provided, to control availability of
protected memory for video playback.

Bug: fuchsia:41143
Change-Id: I5222b956fcce33ae49d575cdd308388310fa80b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907474
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714703}

This change:
1. Adds braces for all control structures according to the Google
JavaScript style guidelines: http://go/js-style.
2. Access the phase member variable (this.phase_) when checking
the current phase. The previous code was confusing because
sometimes we would check the tree walker phase using the getter
(this.phase) and other times we would directly check the member
variable (this.phase_).

Change-Id: Id2288716d7b1bb1a08fb8c06760a17a753be8081
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880178
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Anastasia Helfinstein <anastasi@google.com>
Cr-Commit-Position: refs/heads/master@{#714702}

Bug: 997885
Change-Id: I93bda4028f5dc1b59d29b8f26aa30f050e6b3eae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909284
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714701}

Since interruption is raised and caught in a separate thread,
it may take some time to get interrupted exception on the test thread.
Also, we should not feed data since the task may be executed even
before it gets interrupted.

Test: I was able to reproduce this issue when I add some delay in the
      test thread, which proves my point. With the changed logic I could
      not reproduce the issue.

Bug: 1022954
Change-Id: I48899279d5bc678a75f40b21b6adf3faf2efe2f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906639
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714700}

This CL re-implements the named test so that it is meaningful in the
context of OOPIF-based PDFs. The test (i) verifies that the embedder loads
correct boilerplate <embed> tag, and (ii) that the extension loads.

Bug: 1019367
Change-Id: I79193923d2b0572bd49bf75cb462f2db8768a901
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906181
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714699}

The test used to navigate to chrome://settings, which may take
a long time causing the test to flake. The test's intent is to
verify correct WebPrefs applied when switching to tablet mode
for internal pages; doesn't have to be the settings page.
Use chrome://version instead.

BUG=1023903
TEST=Run test locally with no flakes

Change-Id: I5bc62a1eb9d67e1d0ca62693110081d4fd512974
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913020
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714698}

https://chromium.googlesource.com/openscreen/+log/729798cc3be6..21b5adc8409a

$ git log 729798cc3..21b5adc84 --date=short --no-merges --format='%ad %ae %s'
2019-10-25 jophba Fix chrome build, add unit testing in Chrome
2019-11-06 mfoltz [Open Screen] Consolidate BUILD.gn for cast/
2019-11-05 mfoltz Roll buildtools/ cf454b247..140e4d7c4 (2 commits; 1 trivial rolls)
2019-11-05 mfoltz [Open Screen] Move mDNS code to discovery/mdns.
2019-11-05 btolsch Add virtual connections for cast socket
2019-11-05 rwkeane DNS-SD: Add new TxtRecord method
2019-11-05 rwkeane DNS-SD: More Conversions
2019-10-31 rwkeane DNS-SD: Conversions From mDNS
2019-10-30 rwkeane DnsSd: Querier Skeleton
2019-10-29 yakimakha MdnsService base interface
2019-10-25 miu Cast Streaming: Add RTP Payload Type hacks for AndroidTV.
2019-10-25 rwkeane DNS-SD: TxtRecord implementation
2019-10-25 rwkeane DnsSd: More Operators for Constants
2019-10-24 rwkeane DNS-SD: Instance Record

Created with:
  roll-dep src/third_party/openscreen/src

Change-Id: I64f4e8d5ac63657c1bac61d012321c80c5f90b7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906125Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Commit-Queue: Jordan Bayles <jophba@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714697}

The status area collapse/expand animation is currently unspec'd, so skip the
animation for now.

TEST=manually verified with --force-status-area-collapsible flag
BUG=982511

Change-Id: Idaa95fd9a2393d668ad7d154663fc1e876c184d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903937Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714696}