- 28 May, 2020 40 commits
-
-
Alex Ilin authored
This CL adds Gaia reauth as a second step after the chrome://signin-reauth dialog. A new SigninReauthViewController class is created to manage the whole reauth flow. This class is responsible for: - opening and closing dialogs - loading the Gaia reauth in background, while the confirmation dialog is shown - presenting the Gaia reauth after the user clicks Next in the confirmation dialog either in the same dialog or in a new tab - calling the reauth callback after the flow is completed Bug: 1045515 Change-Id: I7504c860af600cd0dba37616af09c894ded82d91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210464 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#772643}
-
Mark Brand authored
This is a reland of 769719f1 Original change's description: > Adding mojolpm fuzzer generators. > > This adds code that generates libprotobuf-mutator based > structure-aware fuzzers as part of the mojom compilation process. > (changes in //mojo). > > This is a cherrypick/split from > https://chromium-review.googlesource.com/c/chromium/src/+/2108507 > > Pragmatic fixes for the remaining missing dependencies. > > Change-Id: I0e0d34a4b99b31f99ee872fb95be993043aef402 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170830 > Commit-Queue: Mark Brand <markbrand@google.com> > Reviewed-by: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#771513} Change-Id: Ie477695c59001f51fb25e25b3c98291cb5cf0013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214883Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Mark Brand <markbrand@google.com> Cr-Commit-Position: refs/heads/master@{#772642}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I7e9b62abf2838bfff6bf11b4944253baa9d1cd00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219729Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772641}
-
Jan Wilken Dörrie authored
TBR=bsheedy Bug: 1087097 Change-Id: I382a3c1e7bf93f7145f7fd4b2b68a6b43da85a00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218841Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#772640}
-
Wez authored
This reverts commit 3c6e8cf6. Reason for revert: SDK roll appears to remove the "archive_manifest" output files, on which Chromium's runner scripts depend. See https://crbug.com/1087301 Original change's description: > Roll Fuchsia SDK from 0.20200520.3.1 to 0.20200527.2.1 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll > Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast > Tbr: cr-fuchsia+bot@chromium.org > Change-Id: If0eb3cf6c9a7c659b00269b77edf93116aa29990 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219230 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#772478} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,cr-fuchsia+bot@chromium.org Change-Id: Iffb91f585dcd589e6539f349c8296f3f8eb84b73 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218845Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#772639}
-
Wez authored
This reverts commit ffa84d15. Reason for revert: SDK roll appears to remove the "archive_manifest" output files, on which Chromium's runner scripts depend. See https://crbug.com/1087301 Original change's description: > Roll Fuchsia SDK from 0.20200527.2.1 to 0.20200528.0.1 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll > Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast > Tbr: cr-fuchsia+bot@chromium.org > Change-Id: Ic09ff38240ec2167c9647fde2f2c8dde7f9c653e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219633 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#772590} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,cr-fuchsia+bot@chromium.org Change-Id: I80c7cf681ddbb96cfb8399eb9fd1ee36753ff428 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219888Reviewed-by:
-
Gabriel Charette authored
Task APIs v3 will all have an explicit destination. In the past "default traits" meant ThreadPool. These CLs are thus a no-op except for the few callers that clearly wanted to post a QuitClosure() on the current thread (posting a QuitClosure() to a parallel task will merely bounce it back to the current thread anyways). Those few callers were migrated to ThreadTaskRunnerHandle::Get(). These changes are thus required to phase out task APIs v2 (post_task.h) Design doc: https://docs.google.com/document/d/1tssusPykvx3g0gvbvU4HxGyn3MjJlIylnsH13-Tv6s4/edit This specific change is a subset of https://chromium-review.googlesource.com/c/chromium/src/+/2216733 This CL was uploaded by git cl split. R=dcheng@chromium.org Bug: 1026641 Change-Id: Ifcae70690c28466e17c93ea1b122dc8c48f205f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217208 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#772637}
-
David Jean authored
Bug: 1084905 Change-Id: Icb6d886fc3954452fe86a4cc78845e052dfc272a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218109Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#772636}
-
Koji Ishii authored
Following bot results are included. 2345 2350 2366 2367 2368 2371 2374 2381 27 lines were removed and 6 lines were deflaked by consecutive results since 2286. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: I2d7281396e2098fb288278262a77b89592284fe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210185Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#772635}
-
Nigel Tao authored
Use the base/util/values/values_util.h functions instead. Bug: 1086733 Change-Id: I5fc0c88a13cd5ed9007a1dc92814c7632572a8eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217671 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/9cb2571a184c..8dfdbeff84f3 2020-05-27 rharrison@google.com Rolling 4 dependencies (#3380) 2020-05-27 stevenperron@google.com Start SPIRV-Tools v2020.4 2020-05-27 stevenperron@google.com Finalize SPIRV-Tools v2020.3 2020-05-27 stevenperron@google.com Update CHANGES 2020-05-26 andreperezmaselco.developer@gmail.com spirv-fuzz: Support bit width argument for int and float types (#3378) 2020-05-26 andreperezmaselco.developer@gmail.com Fix function use (#3372) Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers from f8bf11a0253a to ac638f181542 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,ynovikov@google.com Change-Id: I997db911ce9941b328766b68993111f79afa4690 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219730Reviewed-by:
-
Jan Wilken Dörrie authored
TBR=mcnee Bug: 947193 Change-Id: Ibff4f4d8654092a25ed05b363338ce8e3e958e8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218840Reviewed-by:
-
Denis Kuznetsov authored
Bug: 1047840 Change-Id: I261c040d3c8c6abce28686d5687d512bc648f358 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218069Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#772631}
-
Hiroki Nakagawa authored
"Navigation" is the term specific to frame loading, but ServiceWorkerNavigationLoader is used for both frame loading and web worker script loading. For avoiding confusion, this CL renames it to ServiceWorkerMainResourceLoader. In addition, this CL renames ServiceWorkerNavigationLoaderInterceptor to ServiceWorkerMainResourceLoaderInterceptor. This CL uses NoPresubmit to suppress warnings for usage of deprecated mojo::DataPipe. This is not derived from this change. Bug: 1083047 NoPresubmit: true Change-Id: I9b66316e6d35c0608094f447919dafc04e7b6d28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210292 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#772630}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/a3636ed8883d..f874525de394 2020-05-28 enga@chromium.org OpenGL: Fix rendering to a layer of a depth/stencil texture 2020-05-28 enga@chromium.org Metal: Fix rendering to a layer of a depth/stencil texture 2020-05-28 enga@chromium.org Add tests for using a subresource as output attachment If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I88cfda79baac328e275b352c0ead8cd75126fb18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219739Reviewed-by:
-
Jia authored
The new tokenization method only extracts words delimited by spaces and keep punctuations that appear within a word. Bug: 1085976 Change-Id: I61ef69db6653ecb91bb3945bad7f470bfbf00902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212293 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#772628}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6a184fe947ed..b9529e3a6998 2020-05-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from d3d89bb90cbd to 8dfdbeff84f3 (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: Id3cc3685c57a6296485ee6e17d2c65e2b5c16c8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219731Reviewed-by:
-
Jan Wilken Dörrie authored
TBR=dgozman Bug: 1087320 Change-Id: I15cd33b9338255ea339eca35d49a5d7c694158cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219501Reviewed-by:
-
Marc Treib authored
This introduces a histogram PasswordManager.StoresUsedInLast[7|28]Days that records which of the two stores (profile-scoped store and/or account-scoped store) were used for filling in the last 7/28 days. Bug: 1063852 Change-Id: I3a2bc108e2b88c960cd78f6fdc1a36fc284dbe28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207323Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#772625}
-
Hazem Ashmawy authored
Make AwNonembeddedUmaRecorder bind once MetricsBridgeService and never unbind, i.e keep the service binding for the app context lifetime. This should save the overhead of binding and then unbinding for each histogram record. Never unbinding the service should be okay, while the non-embedded process is alive, there is expected to be a consistent stream of histogram records that need to be sent to the service. AwNonembeddedUmaRecorder can be accessed concurrently from many threads making it tricky to maintain one instance of ServiceConnection given possible accidental changes in connection status by the system. In order to avoid losing histogram records and not to block the calling thread, we add incoming histogram records to a thread-safe list and when the service connection is ready we send those records to the service. If the connection is ready we send records directly to the service. Fixed: 1081262 Test: bin/run_webview_instrumentation_test_apk -f "*AwNonembeddedUmaRecorderTest*" Change-Id: If61c6cdc25c61dacbbd747179e4625acf8a98a50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207531Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Cr-Commit-Position: refs/heads/master@{#772624}
-
sandromaggi authored
This is a proposal to add a boolean to skip Autofill, entirely relying on the required fields. The purpose of this change is to give our client full, deterministic control over what happens in a |UseAddressAction|. The same change is introduced for |UseCreditCardAction|. Bug: none Change-Id: Iae4ce4fd00fec6038f5394dff7bf7dd88e2a80a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207458Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#772623}
-
Alexandre Courbot authored
Add a new QueueDMABuf() method taking a VideoFrame as argument. This method queues the VideoFrame's DMABufs, but will also keep a reference to the VideoFrame itself, which can be retrieved when the buffer is dequeued using V4L2ReadableBufferRef::GetVideoFrame(). This makes it easier to manage imported DMAbufs with V4L2, since clients don't have to keep that reference themselves (usually using a map of buffer IDs to VideoFrames). BUG=b:149663704 TEST=VDAtest --use_vd passes on Kukui. Change-Id: Id3fd7c5b62b16978553f3c99664ba688ba61451e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143427Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Fritz Koenig <frkoenig@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#772622}
-
Christoph Schwering authored
This CL appends form and field renderer IDs to the autofill-information attribute. For one thing, this helps interpret chrome://autofill-internals output. For another, it will help matching elements across rendered and browser process boundaries in unit tests. Change-Id: I0bc5d50b7aa9922362e3d34a0d786bc741bfa9c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219487Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#772621}
-
Christoph Schwering authored
The duality between FormStructure and FormData is reflected by FormStructure(const FormData&) and FormStructure::toFormData(). The relation extends to FormDataPredictions, which has a FormData member. This CL makes FormStructure:toFormData() and FormStructure::GetFieldTypePredictions() initialize all members shared among FormStructure and FormData and FormDataPredictions. More precisely, before this CL, (1) FormStructure::toFormData() didn't copy several of the members shared by FormStructure and FormData. (2) FormStructure::GetFieldTypePredictions() didn't set several of the members shared by FormStructure and FormDataPredictions's FormData and didn't set FormFieldDataPredictions's FormFieldData. Bug: 1087194 Change-Id: If0b833b52ede4d3ac86aad5c46fefd84c99cba47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218829Reviewed-by: -
Anastasiia Nikolaienko authored
Use browser proxy in account_manager_error and account_manager_welcome dialogs. Bug: 1083147 Change-Id: I4549ced7b860f4a53a6a280463d03382f0e3df0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214523 Commit-Queue: Anastasiia N <anastasiian@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#772619}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1590637846-cf66cd399b4c48375ae2ad3d18827b7a5bc0b17a.profdata to chrome-win64-master-1590652675-be69972bb8b130c690a24c0cd0561e6e4a5c40c5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Idea46c5cc1c7fa545acefb57459da126af1ca585 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219740Reviewed-by:
-
Victor-Gabriel Savu authored
Mark Cryptohome.InstallAttributesValidation and Cryptohome.InstallAttributesUsage as obsolete. Bug: chromium:1021154 Change-Id: I4d646db7a38008cdc6388fb5fca7cb463f11f18d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207194Reviewed-by:
Igor <igorcov@chromium.org> Reviewed-by:
-
arthursonzogni authored
The function NavigationRequest::IsErrorPage() returns true for error pages AFTER the navigation commit. It means it doesn't make sense to call it from: - WebContentsObserver::DidStartNavigation() - WebContentsObserver::DidRedirectNavigation() - WebContentsObserfver::ReadyToCommitNavigation() - NavigationThrottle::WillStartRequest() - NavigationThrottle::WillRedirectRequest() - NavigationThrottle::WillProcessResponse() The only meaningful way to use IsErrorPage() is from: - WebContentsObserver::DidFinishNavigation() This is easy to verify, given its implementation: ~~~ bool NavigationRequest::IsErrorPage() { return state_ == DID_COMMIT_ERROR_PAGE; } ~~~ WebContentsObserverSanityChecker is also enforcing this. The current behavior is a bit misleading. I have been tricked myself recently. This patch: 1. Update the content/public IsErrorPage() documentation. 2. Remove all the callers who are using this incorrectly. 3. Transitively remove code starting from what (2) removed. Bug: None. Change-Id: Ie6a66bf6344fc306ddd27384aab27fd002832116 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216218Reviewed-by:Matt Menke <mmenke@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#772616}
-
Vasilii Sukhanov authored
Bug: 716681 Change-Id: I640a2bff687d1a4bdc712cddbb03061587fcf3c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218093Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#772615}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590637846-f24e6c1a243316554d5b0c2334884adcb37c67bd.profdata to chrome-mac-master-1590652675-697ba00b1820dcc0607ade49043105c169de1a33.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I9123b69596be280352752c4fa2cc9203d170aa4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219736Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0c9fa494daad..872a24d0d0f9 2020-05-28 dbarcos@chromium.org Fix word duplication to align with article If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id9f6f89efa2ecd601a266efc21d586f54673c322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219728Reviewed-by:
-
manuk authored
*Rich autocompletion background* Currently, autocompletion is limited to when the user types a prefix of the URL. E.g. 'wiki' can autocomplete 'wiki.org/thecookinglist - top awesome recipes'. Rich autocompletion will allow autocompletion even when the input is from the suggestion title or middle of the URL. E.g. 'thecoo' and 'recip' will also autocomplete 'wiki.org/thecookinglist - top awesome recipes'. Design doc with further details: go/richomniboxautocompletion Previous CLs: - crrev.com/c/2107796 added chrome://flags flags - crrev.com/c/2108780 supported multiselection in textfield views. - crrev.com/c/2199859 Add complementary omnibox view. *This CL* This is the 4th CL for rich autocompletion. It wires in the omnibox view to textfield's multiselection & location bar's complementary text. This CL has no user facing changes. Followup CLs will wire in rich autocompletion to make use of these changes. Bug: 1062446 Change-Id: I919965049837fd5421fd2b8f0dabc6d3489dabf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204545 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#772612}
-
arthursonzogni authored
Only some of the browser initiated main frame navigation can have no FramePolicy assigned. The renderer-initiated and subframes ones must always have it defined. TODO(arthursonzogni): Consider always defining it in the future. This patch fixes a few cases and adds a DCHECK in the NavigationRequest to enforce this property in the future. Bug: 1086734, 1041376 Change-Id: Id2936a89193322fa609e4135820037fcbf7bd85c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216255 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#772611}
-
Mansi Awasthi authored
This change adds struct PP_PrivateAccessibilityFormFieldInfo to PP_PrivateAccessibilityPageObjects to transfer accessibility related PDF form field data from the plugin process to the mimehandler process. Made the same changes to the C++ versions of these structs and added the appropriate conversion code. This CL refactors existing PP_PrivateAccessibilityPageObjects to send text field data as part of PP_PrivateAccessibilityFormFieldInfo struct. Going forward, other form fields will also be added in PP_PrivateAccessibilityFormFieldInfo. This change is needed to avoid bloating of PP_PrivateAccessibilityPageObjects structure with multiple objects. Bug: 1030242 Change-Id: Ie55ee36645ff9df9bc57dfaa18fb4cc3f245d60b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215155Reviewed-by:
🌪 ️ <ankk@microsoft.com> Commit-Queue: Mansi Awasthi <maawas@microsoft.com> Cr-Commit-Position: refs/heads/master@{#772610} -
Takashi Toyoshima authored
This reverts commit 643474d0. Reason for revert: The change was merged to M84, and isn't needed for M85, TOT. Original change's description: > OOR-CORS: Disable kStrictAccessControlAllowListCheck for M84 > > To reduce risks for launching OOR-CORS on WebView 83/84, we temporarily > disable the kStrictAccessControlAllowListCheck for M84. > > Once this patch is merged to the M84 branch, I will quickly revert this > for M85. > > Bug: 1084376 > Change-Id: I2256eed511ea995bad91b611f976d72eb228443b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206861 > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> > Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#770000} Bug: 1084376 Change-Id: I2bd71ae24c331ea9f0b0779b851e48b73ba60127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210196 Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#772609}
-
Anders Hartvoll Ruud authored
Bug: 1057072 Change-Id: I9b50b4f02c7ceb31a406464552d2c02613f6bf5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210420 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#772608}
-
Roman Sorokin authored
Bug: 1073095 Change-Id: I3de4ae351e8d305df649071056a903a935735d0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196484 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#772607}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0a40740375ef..641fcb8099d4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tasak@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1024588,chromium:1085525 Tbr: tasak@google.com Change-Id: I905ba3accab22df5cb5083c68e5afee64ed5a1ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219629Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772606}
-
Mario Sanchez Prada authored
This CL moves this message out of frame_messages.h and adds a new method in content::mojom::Widget to allow asking the renderer to force a redraw, expecting a response when the process is completed. Bug: 1083405 Change-Id: I2ce44e25c8d82f56bc4a8d44572f8e04e60abda0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207209Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#772605}
-
Kent Tamura authored
Font-size restriction for inset amount should be applied only to LayoutRubyText. Bug: 1069817 Change-Id: I82d6ac806e3eca0bc696517678d753e3c1a53d6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217914 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#772604}
-
