GitLab

For incognito window's the in-memory DB is seeded (read only) by the DB
of the original profile. This is achieved via raw pointer to the seed
DB and the invariant that the incognito profile is always outlived by
its ancestor profile. Unfortunately, this overlooked that the ancestor
profile may destroy the DB and make a new one when asked to clear the
DB history. This caused the seed pointer to be invalid.

This CL changes the VideoDecodePerfHistory to never destroy the DB.
The DB is now a const unique_ptr, passed in during construction.

This CL also changes how clearing history works. Before, we used the
Destroy() API of the underlying ProtoDatabase to delete all entries.
This left the DB broken until re-initialized, which presents a risk
whenever that DB is seeding an incognito profile. Going forward,
clearing the DB is achieved by querying for all the keys and then
removing them. This removes the need for re-initialization and allows
the seeded in-memory DB to carry on safely unaware.

Test: Updated unit tests. Also manual e2e testing.
Bug: 881059
Change-Id: I014d76d9e04b16574fd7eea08775b1388740dd8d
Reviewed-on: https://chromium-review.googlesource.com/1220392Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593659}

Rename the minimum/target SDK version and manifest package name
variables in the WebView manifest to be consistent with the ones in the
Chrome manifest. Use the old names as a default value so as not to break
downstream until this is updated.

Change-Id: If55711db4540fc164ddd0f6bddcf30abd3da99a5
Reviewed-on: https://chromium-review.googlesource.com/1241014Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593658}

This will execute the uninstall operation via the UI and the callback
will be invoked upon completion.

BUG=chromium:849438
TEST=tast run vm.CrostiniFiles

Change-Id: I854b0563cea082a325c3c52a00e2c357cb62a295
Reviewed-on: https://chromium-review.googlesource.com/1237387
Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593657}

LayerTreeHostTestWillBeginImplFrameHasDidFinishImplFrame has been
reported as flaky on and off for a while now.

TBR=lijeffrey@chromium.org

Bug: chromium:842038, chromium:845381
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ie71c4716777812d6ebec67833d98da340962b699
Reviewed-on: https://chromium-review.googlesource.com/1241193Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593656}

The feature that allowed specifying an element id before the event name
in the listeners object is no longer supported in Polymer 2.

For example:

  listeners: {
    'id.eventName': 'onEventName_',
  }

Bug: 885294
Change-Id: Ieb468d10ebdc3ba436fdc38b8858b6a1b237e93f
Reviewed-on: https://chromium-review.googlesource.com/1237400Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593655}

This change adds a page describing the manifest file structure and
focuses on the options field that replaced "magic" service_manager
capabilities.

Bug: 866967
Change-Id: I4fbf53b8e3f821cb67c3133b21c8521a7536e429
Reviewed-on: https://chromium-review.googlesource.com/1227229Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593654}

Bug: 886860
Change-Id: I8c18e4e66bfbe1cbc8d56153bde889423fcf4554
Reviewed-on: https://chromium-review.googlesource.com/1234960Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593653}

This migrates extensions::NetworkingPrivateServiceClient from
NetworkChangeNotifier to NetworkConnectionTracker, which works with the
network service enabled.

Bug: 887043
Change-Id: I189fc631c5b4050d2e4bffab627754157e9ec20a
Reviewed-on: https://chromium-review.googlesource.com/1237382
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593652}

This reverts commit 1922e955.

Reason for revert: Causing bug 887424

Original change's description:
> Reland "Under refresh, use the same menu options for Windows/Linux as under Mac"
>
> This is a reland of 9c5131ad
>
> Cannot reproduce the flake. Relanding for more information.
>
> Original change's description:
> > Under refresh, use the same menu options for Windows/Linux as under Mac
> >
> > Use the BubbleBorder for the menus since the drop-shadow under Windows
> > doesn't track the shape of the menu. We also have much more control over
> > the shape and depth of the drop-shadow.
> >
> > Bug: 837782
> > Change-Id: I91b9340251c2cd0b60e3b3f66d450a4791113007
> > Reviewed-on: https://chromium-review.googlesource.com/1159532
> > Commit-Queue: Allen Bauer <kylixrd@chromium.org>
> > Reviewed-by: Evan Stade <estade@chromium.org>
> > Reviewed-by: Michael Wasserman <msw@chromium.org>
> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#590731}
>
> TBR=ellyjones@chromium.org
> TBR=msw@chromium.org
> TBR=estade@chromium.org
>
> Bug: 837782
> Change-Id: I80a07fb2d716c9372d18a8d48df3e7e00ff286ab
> Reviewed-on: https://chromium-review.googlesource.com/1229173
> Commit-Queue: Allen Bauer <kylixrd@chromium.org>
> Reviewed-by: Allen Bauer <kylixrd@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#592156}

TBR=ellyjones@chromium.org,msw@chromium.org,estade@chromium.org,kylixrd@chromium.org
NOTRY=true
NOPRESUBMIT=true

Bug: 837782
Change-Id: Ie834df815bd1fb1d0f49d7ddc84adecf75ea351e
Reviewed-on: https://chromium-review.googlesource.com/1240733
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593651}

There is no longer a need for AnimationWorkletProxyClient to be split
across core/ and modules/.

This patch combines the abstract interface and its single concrete impl into
a single class.

Other changes:
 - remove unnecessary include in ChromClient

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Icc49dc26de20b1059cb8be0aaa72fb39b87e2730
Reviewed-on: https://chromium-review.googlesource.com/1237147Reviewed-by: Sandra Sun <sunyunjia@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593650}

This reverts commit c551571f.

Reason for revert: Need to revert a dependent CL (https://chromium-review.googlesource.com/c/chromium/src/+/1229173), so reverting this to prevent merge conflicts

Original change's description:
> [GTK] Fix menu background color regression
>
> Regressed after 9c5131ad.  This caused the menu
> background to always render white even though the text colors would still be
> styled using the system theme.  This caused illegible text when the menu
> background was supposed to be dark.
>
> R=​pkasting
> TBR=sky
>
> Change-Id: I39b836e0941cbfc033515fe3891ecd42d89d73a4
> Reviewed-on: https://chromium-review.googlesource.com/1237519
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Peter Kasting <pkasting@chromium.org>
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#593039}

TBR=sky@chromium.org,pkasting@chromium.org,thomasanderson@chromium.org
NOTRY=true
NOPRESUBMIT=true

Change-Id: If1fa983c97f0942cea3fccad14372ed1f5922080
Reviewed-on: https://chromium-review.googlesource.com/1240713
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593649}

https://chromium.googlesource.com/catapult.git/+log/f19e5d119588..e06567b30fdd


git log f19e5d119588..e06567b30fdd --date=short --no-merges --format='%ad %ae %s'
2018-09-24 jbudorick@chromium.org Add vpython to pinpoint tasks.


Created with:
  gclient setdep -r src/third_party/catapult@e06567b30fdd

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:777865,chromium:878777
TBR=sullivan@chromium.org

Change-Id: I2d23dfdac206d7c569bfbce4d72f05eebded15fd
Reviewed-on: https://chromium-review.googlesource.com/1240510Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#593648}

An oversight in https://chromium-review.googlesource.com/1240121

TBR=jochen@chromium.org,estark@chromium.org

Bug: 888470
Change-Id: I006c76c4084bc78d3f3b3c248da28c6e13b9cef3
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1241173Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593647}

https://chromium.googlesource.com/angle/angle.git/+log/f668a4b5fb72..5272a543705e


git log f668a4b5fb72..5272a543705e --date=short --no-merges --format='%ad %ae %s'
2018-09-24 jmadill@chromium.org Vulkan: Skip BufferDataTest.RepeatedDrawDynamicBug on Win/Intel.


Created with:
  gclient setdep -r src/third_party/angle@5272a543705e

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=syoussefi@chromium.org

Change-Id: I82e96e5128ef25473349f1f3a6757345e3400118
Reviewed-on: https://chromium-review.googlesource.com/1240499Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#593646}

Bug: 874146
Change-Id: I2582d5d87c3e8839bdbe1e7939cd656eb76bc4ac
Reviewed-on: https://chromium-review.googlesource.com/1237520
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593645}

If there are more than 1 keep alive frames received before getting
the ack on request, the second will be thought as a continuation
fragment and fail with "Malformed Frame Continuation Fragment".

Change-Id: I69fb5c024f14fe19bfc60da2a2392b663bdcea66
Bug: 880053
Reviewed-on: https://chromium-review.googlesource.com/1237267
Commit-Queue: Yuankai Yu <yyk@google.com>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593644}

[Also adds a datareduction/OWNERS file as well for team self-approving such changes]

There is a different code path that the overflow menu uses that
ensures a negative savings value is not shown using Math.max.
This change applies the same technique to the code path used
to calculate the saving for the displayed graph range.

Bug: 861936
Change-Id: I7cb09da1e451271c364e9055bcbd4ae544059e87
Reviewed-on: https://chromium-review.googlesource.com/1235318
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593643}

Make the element reference proto consistent with what the backend
expects.

R=rouslan@chromium.org, szermatt@chromium.org

Bug: 806868
Change-Id: I2125add6b931d2ccce5fe2dc1986709a087237ee
Reviewed-on: https://chromium-review.googlesource.com/1240297Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Mathias Carlen <mcarlen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593642}

Normally the recommend-apps screen is only shown to first-time
Chromebook users. Adding this switch to skip the check so that testers
can reuse the same accounts for testing.

Bug: 835029
Change-Id: I61b1bef40e4b64f22f3890c64e24d3887a86b977
Reviewed-on: https://chromium-review.googlesource.com/1239249Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Yue Cen <rsgingerrs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593641}

TBR=fserb@chromium.org

Bug: 886670
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: If88bef42580f522accd6505076d75e3471a2e025
Reviewed-on: https://chromium-review.googlesource.com/1240519
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593640}

Remove references to shadow stacks from the profiling documentation and
from the shutdown signal handler.
The only remaining references are in the old tcmalloc implementation, which
will eventually be removed.

BUG=724399,b:70905156

Change-Id: I2b1a854dc2eb081ec9bfb5401fc2c5ebd1860c4e
Reviewed-on: https://chromium-review.googlesource.com/1239442Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Alexander Potapenko <glider@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Gabriel Marin <gmx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593639}

This reverts commit 95797d79.

Reason for revert: will limit the workaround to AMD gpus only, so we could merge back to Beta affecting less machines.

Original change's description:
> Disable DirectComposition on everywhere except for Intel GPUs
> 
> We only need it if hardware overlays can be used.
> 
> BUG=800950
> TEST=bots
> R=​sunnyps@chromium.org
> 
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: Id1a00799ee77f942183b55327ba21c7af65165b5
> Reviewed-on: https://chromium-review.googlesource.com/1232153
> Commit-Queue: Zhenyao Mo <zmo@chromium.org>
> Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#592267}

TBR=zmo@chromium.org,sunnyps@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 800950
Change-Id: I8bfe7d77c40a6754577719f853a3df4baf508d09
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1240509Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593638}

This CL uses ScopedBlockingCall to mark blocking calls in /chrome/browser/extensions/api/storage.

This CL was created by replacing calls to AssertBlockingAllowed()
with instantiations of ScopedBlockingCall(MAY_BLOCK).
I kindly ask the reviewer to make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See
    BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().

This CL was uploaded by git cl split.

R=rdevlin.cronin@chromium.org

Bug: 874080
Change-Id: I4de4dd7b51419500492ecce093c5e82cd9fe6b35
Reviewed-on: https://chromium-review.googlesource.com/1191809Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593637}

Bug: 880973
Change-Id: I905435107c3568d6e9f6c8eaf4c5fc9ec1173746
Reviewed-on: https://chromium-review.googlesource.com/1239622
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593636}

This was mistakenly added in crrev/c/1228308.

Bug: 888659
Change-Id: I949e02e39a3a3650fecbb464d7e2b7ea1b14eddc
Reviewed-on: https://chromium-review.googlesource.com/1240859Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593635}

+ Record dialog dismissal on Android side as kDialogClosed
+ Add metrics recording support for modal dialogs, and remove onCancel
  callback

Bug: 873236
Change-Id: Idbe990f2c70883f851bf5214dbf0a3e7b96f4260
Reviewed-on: https://chromium-review.googlesource.com/1222990Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593634}

aura::Env::GetInstance() means the Env in the client in
SingleProcessMash, which means this PreTargetHandler might not
be invoked in SingleProcessMash.

This is primarily for fixing test failures of BookmarkBarViewTest
and MenuItemViewTestRemoveWithSubmenu in interactive_ui_tests,
but I guess this will fix some keyboard operations on menu
items in normal chrome.

Bug: 883523
Test: interactive_ui_tests --enable-features=SingleProcessMash
Change-Id: I4f081b290bf6468318df3a77844efaf8410d05b7
Reviewed-on: https://chromium-review.googlesource.com/1237540
Commit-Queue: Jun Mukai <mukai@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593633}

https://android.googlesource.com/platform/external/perfetto.git/+log/e2ea26c8b521..80983c737e5b


git log e2ea26c8b521..80983c737e5b --date=short --no-merges --format='%ad %ae %s'
2018-09-24 lalitm@google.com Merge changes I8aec6ee1,I25f017c0,I4e49a5f0,Ie794521a,I22340a55, ...
2018-09-24 gkaiser@google.com trace_processor: Fix deallocation mismatch


Created with:
  gclient setdep -r src/third_party/perfetto@80983c737e5b

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: Idc01353b1112589046b142a03602468df3ed54af
Reviewed-on: https://chromium-review.googlesource.com/1240538Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#593632}

PointerWatchers aren't necessary in ash anymore. ui::EventHandler does
everything that PointerWatcher can do, plus can mutate events. Once
we eliminate PointerWatcher from ash we can delete some glue code I
added to make them work.

Also drop support for ui::EventPointerType::POINTER_TYPE_UNKNOWN,
which is never recorded in practice. (I don't think we ever generate
events with this type.)

Bug: 872450, 786214
Test: ash_unittests
Change-Id: I08f781dd6e26b34870e7947c3a14e42edaf91080
Reviewed-on: https://chromium-review.googlesource.com/1239455Reviewed-by: Xiaoyin Hu <xiaoyinh@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593631}

Bug: 888225
Change-Id: Ife7943d9e409c9cb6441ad8b83046de14ad1a3ca
No-Try: true
Tbr: jbroman@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1241093Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593630}

From the stack traces for this bug, it looks like we're trying to access
an optional value that isn't set. While we investigate why this is
happening, let's explicitly check the value exists before accessing.

Bug: 888143
Change-Id: Ifc1e47cc26e601c450f70b07dc37e764f6543802
Reviewed-on: https://chromium-review.googlesource.com/1240129Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593629}

These were added for deprecated Mash architecture plans.
Inline calls to [Add/Remove]PreTargetHandler instead.

Bug: 866529
Test: No shelf tooltip nor double-click-to-resize-window changes.
Change-Id: Ic4d376652e1e128c979cfdb6f5f219a2ed76f6ad
Reviewed-on: https://chromium-review.googlesource.com/1240212Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593628}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d786acd3..3e22586a

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I7cc513be0fa5ea1955573ca6077f9ea48b062c0b
Reviewed-on: https://chromium-review.googlesource.com/1240207Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#593627}

Because: https://wicg.github.io/origin-policy/#monkey-patching-fetch, 3.4.2 #8

This addresses deferred feedback from https://crrev.com/c/1148395

Bug: 751996
Change-Id: Iac7756bf7c6b126711f002fd94b82bfd5fcae522
Reviewed-on: https://chromium-review.googlesource.com/1221146
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593626}

This change sets up the ImageLoader to be backed by the
haredImageCache when it becomes available. In the short term, this
change all fixes the order the urls are tried such that we strictly
respect the order provided by the Feed. One downside is that more JNI
calls are made.

Bug: 840578
Change-Id: Ie3309005c995ff9e800add44de6e189752722b78
Reviewed-on: https://chromium-review.googlesource.com/1237333Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Gang Wu <gangwu@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593625}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/43650198eae8..96954b704ff5


Created with:
  gclient setdep -r src-internal@96954b704ff5

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I888ae43cdbbea3b7fba713172443dfc85f0a429a
Reviewed-on: https://chromium-review.googlesource.com/1240533Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#593624}

Split raster PDF creation into its own function. Also add a helper
function to consistently check for PDFs with no pages.

Change-Id: I693282460b4da0e80bd1c5f2c022372bb7d58bb1
Reviewed-on: https://chromium-review.googlesource.com/1238353
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593623}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/baf09271514c..8bdc1b8a0433


git log baf09271514c..8bdc1b8a0433 --date=short --no-merges --format='%ad %ae %s'
2018-09-24 tandrii@chromium.org my_activity: add --completed-issues option.


Created with:
  gclient setdep -r src/third_party/depot_tools@8bdc1b8a0433

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I1007c7575f0969e887422c141bc7d725c13c7d0e
Reviewed-on: https://chromium-review.googlesource.com/1240500Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#593622}

This CL removes the min-height CSS properties for audio elements and
video elements acting as audio elements. We had these rules to handle
the width/height-zero elements in the MediaDocument, but we have
changed how the MediaDocument sizing works, so they're no longer
needed.

Bug: 842900
Change-Id: I050aba4786f84754843ee611ead1dabe220381cb
Reviewed-on: https://chromium-review.googlesource.com/1239725Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593621}

These are modelled after the similar tests that exist for AnimationEvent
in css/css-animations, except written using more modern WPT style.

Bug: 695504
Change-Id: I63573cf48aba6821f5e22486ef18217d0f2828ee
Reviewed-on: https://chromium-review.googlesource.com/1239457Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593620}