GitLab

Switches all VR instrumentation tests for scrolling using the Daydream
controller to use the Chrome-side controller mock instead of the
VrCore-side emulation via intents. The latter has always been somewhat
flaky, so this should help reduce VR test flakiness.

Bug: 902938
Change-Id: I560cda2129357c49bdfa3d095836e6ebd1b23da8
Reviewed-on: https://chromium-review.googlesource.com/c/1341061Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613107}

See bug for more information about the problem, and solution.

This was manually tested.

Bug: 910458
Change-Id: I663a1354f12a917c478144530311b31e4bd1657f
Reviewed-on: https://chromium-review.googlesource.com/c/1357520Reviewed-by: Cathy Li <chili@chromium.org>
Commit-Queue: Dan H <harringtond@google.com>
Cr-Commit-Position: refs/heads/master@{#613106}

Effectively changes three things from r612882:
1. Reverts the checks in OnTextSelectionChanged(). This drops
   DumpWithoutCrashing(), which was louder than intended, and avoids
   potentially changing non-Touch Bar behavior.
2. Preserves the new behavior of ignoring an invalid selection instead of
   clearing the existing suggestions by removing the selection-clearing code.
3. Adds a bounds check that was removed in (1) into Touch Bar code.

Bug: 893038, 910950
Change-Id: I6fdb30a71ce64680fb06ce73072c9171da36da32
Reviewed-on: https://chromium-review.googlesource.com/c/1358695Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613105}

Bug: 894001
Change-Id: Ia0d5092b6d3dcac8455ee57ebc372ff44b2821d3
Reviewed-on: https://chromium-review.googlesource.com/c/1358439
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613104}

Bug: skia:2664
Change-Id: I3a565b6dd47e9e09deaadb7e0962d95420fe8935
Reviewed-on: https://chromium-review.googlesource.com/c/1358692Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613103}

Bug: 911138
Change-Id: Icfef4e49ed6e4755685da3b42f275037592edf78
Reviewed-on: https://chromium-review.googlesource.com/c/1358694Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613102}

Before this patch, the navigation detection logic for what happens
during a prompt (a script is running with a touchable element area) was
incorrect:
 - it was too trigger happy, disallowing navigation for other frames,
   such when fetching data in the background
 - it did not detect usage of the back button

With this patch, during a prompt, only non-renderer initiated navigation
is disabled. That includes hitting the back button or refreshing the
page through the UI, but not clicking on a link or Javascript-triggered
navigation.

From the user's point of view, with this patch, scripts won't randomly
fail during prompt anymore.

Change-Id: I0d825eeae596503e80d27e5ab032eee7e966ea4c
Bug: 911108
Reviewed-on: https://chromium-review.googlesource.com/c/1358496Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613101}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7b257ce8b3eb..0db3a5a14cd7


Created with:
  gclient setdep -r src-internal@0db3a5a14cd7

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I50e10e4ff5a5a00060eb6c30245ca784357815d2
Reviewed-on: https://chromium-review.googlesource.com/c/1358651Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#613100}

Docs have fixed their duplicate nonces b/70010257
Initial CR: https://chromium-review.googlesource.com/c/chromium/src/+/566822/
Spec: https://github.com/whatwg/html/issues/3257

Bug: 908207
Change-Id: I95be2e84d216147483bfdf816878fe4058451065
Reviewed-on: https://chromium-review.googlesource.com/c/1356984Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613099}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/6af3c5cbe4c7..67b2e1555ab6


git log 6af3c5cbe4c7..67b2e1555ab6 --date=short --no-merges --format='%ad %ae %s'
2018-12-03 dj2@everburning.com Fixup BUILD.gn from addtion of upgrade_memory_model (#2152)
2018-11-30 33432579+alan-baker@users.noreply.github.com Update memory model (#1904)


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@67b2e1555ab6

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I7498d4e83f0dc6c1e168c859286ad5eaafe6c37b
Reviewed-on: https://chromium-review.googlesource.com/c/1358711Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#613098}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/5a42884b..e89dd701

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ib9c68e388c7c7a79488fe4d00d87fb67bfbdf3b4
Reviewed-on: https://chromium-review.googlesource.com/c/1357706Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#613097}

This CL also removed the unnecessary checks since destroy the Controller won't
change the raw pointer value in UiControllerAndroid.

Bug: 806868
Change-Id: Id23c0f73f2db236462e380e47b5836affefb5ef7
Reviewed-on: https://chromium-review.googlesource.com/c/1356121Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613096}

...and into sync_ui_util, where it belongs.
This means that some ProfileSyncService unit tests can't verify it
anymore because it now lives in chrome/browser, but that seems okay
(it's still tested in sync_ui_util_unittest.cc).

Also use this chance to rename it to ShouldShowSyncConfirmation, which
better describes what it means.

Bug: 884159
Change-Id: I14149544d353491ace0590a530e65d0d7687d09f
Reviewed-on: https://chromium-review.googlesource.com/c/1356705Reviewed-by: Florian Uunk <feuunk@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613095}

This CL reenables the first set of integrations tests whose flakiness
should be resolved since the FakeKeyboard replaces the flaky, emulated
soft keyboard.

Bug: 911056
Change-Id: I096fb08df3b76f7c07bdd819f7c66f2eee099417
Reviewed-on: https://chromium-review.googlesource.com/c/1358433Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613094}

Previously, the favicons were not resized at all. Add functionality to
resize the favicons to the proper pixel width/height.

Bug: 908051
Change-Id: Ie81f1675575d5d8f66be686db2d78e40124412e8
Reviewed-on: https://chromium-review.googlesource.com/c/1357570
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613093}

Bug: 740715
Change-Id: I8fa7f98c1303d7ab0901d77df7cc3f73c9fda18a
Reviewed-on: https://chromium-review.googlesource.com/c/1342763Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613092}

This test had been disabled due to flakiness. My change to frame eviction was
the likely cause. This was fixed by https://chromium-review.googlesource.com/c/chromium/src/+/1355845

I also separately ran an experiment which confirmed that the suspected mode of
failure occurs frequently during testing. Where currently visible surfaces are
being evicted. My change invalidated the current id, with the goal of allocating
new ids closer to usage. Unfortunately on Android the eviction process itself
can be the signal of needing a new id.

Now we simply allocate if visible.

TBR=peconn@chromium.org

Bug: 906840
Change-Id: I917a2e230ee472a48858b56feca2c96dc7bd7761
Reviewed-on: https://chromium-review.googlesource.com/c/1358652Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613091}

MessageLoop will go away, eventually.

BUG=891670

Change-Id: I95af02ea3f68b674dd66097c0b9b46538fbc4ad7
Reviewed-on: https://chromium-review.googlesource.com/c/1352778Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Carlos Caballero <carlscab@google.com>
Cr-Commit-Position: refs/heads/master@{#613090}

This CL removes the debug variable |num_frames_at_client_| since it's
always equal to the difference between pictures_.size() and
available_picture_buffers_.size().

Test: Checked in crosvideo and v_d_a_unittests that the values are ==.
Bug: 721674
Change-Id: I946192bde8368210c4b65cf0084c34ee86ea3e62
Reviewed-on: https://chromium-review.googlesource.com/c/1357554Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613089}

This patch fixes a typo in https://crrev.com/612683 where the wrong
directory name was used (enable-features=... instead of
enable-blink-features=...). This typo slipped in because the
property bot is failing for infra reasons (https://crbug.com/910859).

NOTRY=true

Bug: 836884
Change-Id: I88d38247fc0501d21af058852e2694b2ee432722
Reviewed-on: https://chromium-review.googlesource.com/c/1356964
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613088}

This CL adds a scroll view containing the text displayed when the table
view is empty. It allows the user to scroll the text if the font size
used is big.
As the safe area insets aren't propagated to the empty view, this is
using dummy view to fake the safe area insets in the scroll view.

Bug: 893535
Change-Id: I63b658c1bc9d5cacdb4e86d201a2bb2ca7621a96
Reviewed-on: https://chromium-review.googlesource.com/c/1353941
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613087}

Bug: 910846
Change-Id: Ic3e11dd60d1c580a5619ce4a2cbcba3b28a60212
TBR: leszeks@chromium.org
No-Try: True
Reviewed-on: https://chromium-review.googlesource.com/c/1358445
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613086}

If we can use ...args @constructor, use strict as well.

Bug: 910991
Change-Id: I6181423d7df7ab1a376650c657bdb3d8b0636f3c
Reviewed-on: https://chromium-review.googlesource.com/c/1358323Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613085}

Remove unnecessary casts from TraceWrapperV8Reference tracing in preparation for https://chromium-review.googlesource.com/c/chromium/src/+/1356442 because blink_gc_plugin will not be able to recognize cast TraceWrapperV8References as traced.

Bug: 910023
Change-Id: Icc68c8eac74d5a7c320e6fd575cceba71951c57a
Reviewed-on: https://chromium-review.googlesource.com/c/1358318
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613084}

Current enumeration support ignores pages that don't emit any
of the desired metric so technically this will be proportion of
pages that use Blink instead of the proportion of all pages.

However, since it seems likely that the number of pages that don't
use any Blink features is incredibly small (if not outright zero),
this is acceptable for now.

Note: A recent CL will make a huge difference with the per-page
proportions so avoid looking at M72 Canary/Dev aggregations.  M73
or M72 Beta/Stable (once released) will be fine.
https://chromium-review.googlesource.com/c/chromium/src/+/1343060

Change-Id: I46b3092caa0a21e1c5e6baac9977b0efc8ae39e4
Reviewed-on: https://chromium-review.googlesource.com/c/1355486Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Luna Lu <loonybear@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613083}

Bug: 910846
Change-Id: Id761ea19b03af52c25983626e00d28d601cbfef0
TBR: leszeks@chromium.org
No-Try: True
Reviewed-on: https://chromium-review.googlesource.com/c/1358458Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613082}

Bug: 910868
Change-Id: Ib509c2b325855dd88758dee8a91203f12c640b97
TBR: tedchoc@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1358455Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613081}

Fixes a bug where the wrong registry value names where used, so that
setting policy didn't have effect. It used a hierarchical value name
  cat1_cat2_cat3_policy
This isn't necessary since the corresponding registry key already
contains the categories:
  Software\Policies\Google\Chrome\3rdparty\extensions\<extension_id>\Policy\cat1\cat2\cat3
so that the policy is guaranteed to be unique within the key. What's
worse is that the code isn't looking for 'cat1_cat2_cat3_policy', but
just for 'policy'. Hence, the policy settings were not taken.

Bug: 900517
Test: manual
Change-Id: I2e1b83fe2ff6b0997ab22e47c986a92dcb19559e
Reviewed-on: https://chromium-review.googlesource.com/c/1356699Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Lutz Justen <ljusten@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613080}

This had been introduced to simplify access to active fetches, but has
the following issues:
1. It makes match() and matchAll() inconsistent with Cache API's match()
and matchAll(), which return new independently-consumable response(s) every
time they're called.
2. It breaks retries for responses, when downloading from a server that
doesn't support resuming of downloads.

For details, see
https://docs.google.com/document/d/1CrbWrnnshhyp_SfiAeuODpnQX36GK3Bsi19rXQGez6Q/edit?usp=sharing

The CL also updates the WPT test accordingly.

Bug: 875201
Change-Id: I2c33717cbee36f0d707e814506c0bae9b5a4f31f
Reviewed-on: https://chromium-review.googlesource.com/c/1355121
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613079}

https://webrtc.googlesource.com/src.git/+log/a0f4430b3aae..9cf6ce3e1bb3


git log a0f4430b3aae..9cf6ce3e1bb3 --date=short --no-merges --format='%ad %ae %s'
2018-12-03 oprypin@webrtc.org Finish renaming another tryjob that was forgotten
2018-12-03 oprypin@webrtc.org Rename most tryjobs to avoid implied defaults
2018-12-03 kron@webrtc.org Remove color space enum value kInvalid
2018-12-03 nisse@webrtc.org Delete workaround for CreateEvent


Created with:
  gclient setdep -r src/third_party/webrtc@9cf6ce3e1bb3

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ia15551d40692f7a1b4e6393ad60247b63742e3dd
Reviewed-on: https://chromium-review.googlesource.com/c/1358213Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#613078}

Bug: 910870
Change-Id: Ic79310338050d10199e49104d188219cbe46d498
TBR: xingliu@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1358495Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613077}

Under certain combinations of whitespace-reattachment after removing
nodes, parent element being display:contents triggering anonymous
inline boxes for such parents, and ::first-letter being marked for re-
attachment, we can end up with a calculated first-letter text node
changing from non-null to null between style recalc and layout tree
rebuild. Make sure we check that the first-letter text node is still
non-null early in UpdateFirstLetterPseudoElement during the
kRebuildLayoutTree so that we nuke the first-letter pseudo instead of
re-attaching without first-letter text.

Bug: 908253
Change-Id: Ifaac75b34edce21467581b5a9e78f5287a842fe5
Reviewed-on: https://chromium-review.googlesource.com/c/1356714
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613076}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f385a96af6b5..7b257ce8b3eb


Created with:
  gclient setdep -r src-internal@7b257ce8b3eb

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I97e8899b477bdc1bdea692f16d52f6596003b65a
Reviewed-on: https://chromium-review.googlesource.com/c/1358214Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#613075}

This is a prerequisite step for using FetchAPIRequest instead of
ServiceWorkerFetchRequest. ServiceWorkerFetchRequest has a member |headers| with
CaseInsensitiveCompare, but FetchAPIRequest has a member |headers| with the
default Compare function, so that this will cause behavior changes. This CL is
to change FetchAPIRequest::headers to use CaseInsensitiveCompare.

Bug: 908344, 789854
Change-Id: I8e1736d5c5ab2d291ff7c126afa0f4025983b84d
Reviewed-on: https://chromium-review.googlesource.com/c/1356463
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613074}

This reverts commit aa21b3f5.

Reason for revert: Suspect of introducing consistent failure on Mac ASAN 64 tests.

First failed run: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20ASan%2064%20Tests%20%281%29/46988

Sample logs:
unit_tests Run on OS: 'Mac-10.13'
Shard duration: 0:07:56.378119
failures:
FileAnalyzerTest.ArchivedArchiveSetForZipNoArchive
FileAnalyzerTest.ArchivedExecutableFalseForZipNoExecutable
DownloadProtectionServiceTest.CheckClientDownloadZip
SandboxedZipAnalyzerTest.ZippedAppWithUnsignedAndSignedExecutable
SandboxedZipAnalyzerTest.NoBinaries
FileAnalyzerTest.ArchivedBinariesSkipsSafeFiles

==34531==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x700015467c14 at pc 0x00013e99c44d bp 0x700015467950 sp 0x7000154670f8
READ of size 5 at 0x700015467c14 thread T16
    #0 0x13e99c44c in __asan_after_dynamic_init ??:0:0
    #1 0x10e3ac931 in safe_browsing::UpdateArchiveAnalyzerResultsWithFile(base::FilePath, base::File*, bool, safe_browsing::ArchiveAnalyzerResults*) ??:0:0
    #2 0x10e3a6707 in safe_browsing::zip_analyzer::AnalyzeZipFile(base::File, base::File, safe_browsing::ArchiveAnalyzerResults*) ??:0:0
    #3 0x115236586 in SafeArchiveAnalyzer::AnalyzeZipFile(base::File, base::File, base::OnceCallback<void (safe_browsing::ArchiveAnalyzerResults const&)>) ??:0:0
    #4 0x10bc0b332 in chrome::mojom::SafeArchiveAnalyzerStubDispatch::AcceptWithResponder(chrome::mojom::SafeArchiveAnalyzer*, mojo::Message*, std::__1::unique_ptr<mojo::MessageReceiverWithStatus, std::__1::default_delete<mojo::MessageReceiverWithStatus> >) ??:0:0
    #5 0x115234a40 in chrome::mojom::SafeArchiveAnalyzerStub<mojo::RawPtrImplRefTraits<chrome::mojom::SafeArchiveAnalyzer> >::AcceptWithResponder(mojo::Message*, std::__1::unique_ptr<mojo::MessageReceiverWithStatus, std::__1::default_delete<mojo::MessageReceiverWithStatus> >) ??:0:0
    #6 0x1165eeb32 in mojo::InterfaceEndpointClient::HandleValidatedMessage(mojo::Message*) ??:0:0
    #7 0x1165ed1e0 in mojo::FilterChain::Accept(mojo::Message*) ??:0:0
    #8 0x1165f278b in mojo::InterfaceEndpointClient::HandleIncomingMessage(mojo::Message*) ??:0:0
    #9 0x116605686 in mojo::internal::MultiplexRouter::ProcessIncomingMessage(mojo::internal::MultiplexRouter::MessageWrapper*, mojo::internal::MultiplexRouter::ClientCallBehavior, base::SequencedTaskRunner*) ??:0:0
    #10 0x11660372b in mojo::internal::MultiplexRouter::Accept(mojo::Message*) ??:0:0
    #11 0x1165ed1e0 in mojo::FilterChain::Accept(mojo::Message*) ??:0:0
    #12 0x1165dcea8 in mojo::Connector::ReadSingleMessage(unsigned int*) ??:0:0
    #13 0x1165df32a in mojo::Connector::ReadAllAvailableMessages() ??:0:0
    #14 0x1165deda1 in mojo::Connector::OnHandleReadyInternal(unsigned int) ??:0:0
    #15 0x10d429d44 in mojo::SimpleWatcher::DiscardReadyState(base::RepeatingCallback<void (unsigned int)> const&, unsigned int, mojo::HandleSignalsState const&) ??:0:0
    #16 0x11a802cf5 in mojo::SimpleWatcher::OnHandleReady(int, unsigned int, mojo::HandleSignalsState const&) ??:0:0
    #17 0x11a803cbd in void base::internal::Invoker<base::internal::BindState<void (mojo::SimpleWatcher::*)(int, unsigned int, mojo::HandleSignalsState const&), base::WeakPtr<mojo::SimpleWatcher>, int, unsigned int, mojo::HandleSignalsState>, void ()>::RunImpl<void (mojo::SimpleWatcher::* const&)(int, unsigned int, mojo::HandleSignalsState const&), std::__1::tuple<base::WeakPtr<mojo::SimpleWatcher>, int, unsigned int, mojo::HandleSignalsState> const&, 0ul, 1ul, 2ul, 3ul>(void (mojo::SimpleWatcher::* const&)(int, unsigned int, mojo::HandleSignalsState const&), std::__1::tuple<base::WeakPtr<mojo::SimpleWatcher>, int, unsigned int, mojo::HandleSignalsState> const&, std::__1::integer_sequence<unsigned long, 0ul, 1ul, 2ul, 3ul>) ??:0:0
    #18 0x11890131c in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) ??:0:0
    #19 0x118995271 in base::MessageLoopImpl::RunTask(base::PendingTask*) ??:0:0
    #20 0x11899691f in base::MessageLoopImpl::DoWork() ??:0:0
    #21 0x118999eb3 in base::MessagePumpDefault::Run(base::MessagePump::Delegate*) ??:0:0
    #22 0x118994259 in base::MessageLoopImpl::Run(bool) ??:0:0
    #23 0x118a49a1c in base::RunLoop::Run() ??:0:0
    #24 0x118b962e2 in base::Thread::Run(base::RunLoop*) ??:0:0
    #25 0x118b96e9d in base::Thread::ThreadMain() ??:0:0
    #26 0x118c72a0d in base::(anonymous namespace)::ThreadFunc(void*) ??:0:0
    #27 0x7fff74564660 in _pthread_body ??:0:0
    #28 0x7fff7456450c in _pthread_start ??:0:0


Original change's description:
> Add util method to update ArchiveAnalyzerResults for a single file
> 
> This CL breaks out the code that inspects an individual file within a
> ZIP archive. This will be shared between the ZIP and RAR inspection,
> when RAR files begin doing content inspection.
> 
> Bug: 909778
> Change-Id: I7acf1cabd472f112f2ed7c31735688cae7a6d122
> Reviewed-on: https://chromium-review.googlesource.com/c/1354103
> Commit-Queue: Daniel Rubery <drubery@chromium.org>
> Reviewed-by: Brian White <bcwhite@chromium.org>
> Reviewed-by: Jay Civelli <jcivelli@chromium.org>
> Reviewed-by: Varun Khaneja <vakh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#612799}

TBR=jcivelli@chromium.org,bcwhite@chromium.org,vakh@chromium.org,drubery@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 909778
Change-Id: I92e193707da4a28cee94aa1277a6ca567650760f
Reviewed-on: https://chromium-review.googlesource.com/c/1358491Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613073}

MessageLoop will go away, eventually.

BUG=891670

Change-Id: I4e776d210c338961a5225b33a858d3376fb94fb8
Reviewed-on: https://chromium-review.googlesource.com/c/1353920Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Commit-Queue: Carlos Caballero <carlscab@google.com>
Cr-Commit-Position: refs/heads/master@{#613072}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/c0d45675..5a42884b

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: If22002bb471b60e049567c949f57efc5a1d43e42
Reviewed-on: https://chromium-review.googlesource.com/c/1357842Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#613071}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/96fdf7cbe6ed..a21a7c53d9b2


git log 96fdf7cbe6ed..a21a7c53d9b2 --date=short --no-merges --format='%ad %ae %s'
2018-12-03 tikuta@chromium.org [ninja] update ninja repository url


Created with:
  gclient setdep -r src/third_party/depot_tools@a21a7c53d9b2

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: Ic80a07d3fcbc13d82f4061e71ae28aef6975636c
Reviewed-on: https://chromium-review.googlesource.com/c/1358212Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#613070}

MessageLoop will go away, eventually.

BUG=891670

Change-Id: If3946be6ba9614c070e5790e6430ac91538f4311
Reviewed-on: https://chromium-review.googlesource.com/c/1353885Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Carlos Caballero <carlscab@google.com>
Cr-Commit-Position: refs/heads/master@{#613069}

When a foreign session is detected to be old enough, garbage collection
should kick in and all sync entities deleted. This includes orphan tabs
as well (i.e. tabs not referenced from the header entity because the tab
was closed).

Bug: 882489
Change-Id: I9f6e0e4505cc798466294f1fa1a247818cf004b9
Reviewed-on: https://chromium-review.googlesource.com/c/1356717
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613068}