GitLab

The use of a string literal for the channel makes it harder than it
should be to see what this is doing. Using the channel constants also
allows easy string searching for the use of the concept.

Bug: 806661
Change-Id: I1711539886f74549f4ac5db1a16108907b679bd4
Reviewed-on: https://chromium-review.googlesource.com/953071Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541835}

Prior to GTK 3.20, a background-size set to "contain" would actually behave like
it was "stretch".  This was causing frame button images to render too large on
Greybird (XFCE theme) and Breeze (KDE theme).  Since the issue the CSS override
was fixing is not applicable to GTK < 3.20 (symbolic icons were used for these
versions), only apply the CSS if the GTK version is >= 3.20.

BUG=819594
R=erg
TBR=estade

Change-Id: I91807e4b5675b56647e2da1be5284e68a7bc7c3a
Reviewed-on: https://chromium-review.googlesource.com/954419Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541834}

The ImageSanitizer would not call its callback if the data decoder
service crashes. Fixing this and introducing a test data decoder
service that unbinds when a call is made on an interface to simulate a
crasher.
That data decoder test service will be used in a subsequent CL to
simulate JSON parser crashers.

Bug: 819852
Change-Id: Idda0bef2c97513ff0d833d66af1c5777231bfa09
Reviewed-on: https://chromium-review.googlesource.com/954237Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541833}

https://skia.googlesource.com/skia.git/+log/fa303398d503..4997e14c80f1

$ git log fa303398d..4997e14c8 --date=short --no-merges --format='%ad %ae %s'
2018-03-08 fmalita Use kLow_SkFilterQuality when generating shader masks
2018-03-08 egdaniel Add testing only helper to flush and sync gpu.
2018-03-08 bsalomon Delazify wrapped backend textures/render target proxies
2018-03-08 robertphillips Additional DDL playback cleanup
2018-03-08 angle-skia-autoroll Roll skia/third_party/externals/angle2/ ed8b49195..5164b797c (1 commit)
2018-03-07 robertphillips Remove GrRestrictedAtlasManager

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=fmalita@chromium.org

Change-Id: I5cbc36d4a57b76eb23ab6066240f2cc60937edf9
Reviewed-on: https://chromium-review.googlesource.com/955743
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#541832}

Bug: 819592
Change-Id: Ic43116c52e1b401aea1f813334a5352441d6d9a9
Reviewed-on: https://chromium-review.googlesource.com/953302Reviewed-by: Siddhartha S <ssid@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541831}

This makes the behaviour of 'gn clean .' a little more shell-friendly.
Previously gn would delete the shell's current directory, which would
put the shell session into a confusing state where many commands
don't work without re-entering the directory.

Bug: 810548
Change-Id: I2f8849a770a394fe4c38ee771d0eb765dcbe1360
Reviewed-on: https://chromium-review.googlesource.com/954703
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541830}

5MiB is quite large, especially on mobile. The record size here has
analogous tradeoffs as in TLS and HTTP/2, which both use a generous
16KiB limit. Match those.

Bug: 814591
Change-Id: I7238a8b544c92f99c1753d73654a7c04497dbd29
Reviewed-on: https://chromium-review.googlesource.com/953804Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541829}

It turns out that some tests that have been removed from
FlagExpectations/site-per-process in r541649 are still failing on the
Site Isolation Win bot.  This CL re-adds these test expectations, but
makes them Windows-only.

Bug: 788390
Change-Id: Ie09e0a66221e14734f7705b364e18ca204e1f308
Reviewed-on: https://chromium-review.googlesource.com/955962Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541828}

GCC fails to resolve the default copy constructor of the flat_map, so
we add an explicit reference to use default copy constructor.

Bug: 819294

Change-Id: Ie2d69bdbe60742e9253251c965cbf0a936037871
Reviewed-on: https://chromium-review.googlesource.com/944403Reviewed-by: David Reveman <reveman@chromium.org>
Commit-Queue: José Dapena Paz <jose.dapena@lge.com>
Cr-Commit-Position: refs/heads/master@{#541827}

We currently track double and triple clicks' last click locations, and
prevent them from aggregating and "counting" as a double/triple click
if the user has moved the mouse a delta exceeding the drag threshold.

This is currently problematic for Views that move as a result of a
click, as we are tracking the location() with respect to the local
View.

This CL makes the location stored track the root_location(), which is
likely closer to what the user expects, since we don't care if the
local View moves with respect to the mouse, but rather if the mouse
moves in an absolute sense.

This also fixes triple-click for Steady State Elisions in Omnibox UI.

Bug: 797354
Change-Id: Ie29a5f61fa6ae7292dcdf854f1ace2935a640e31
Reviewed-on: https://chromium-review.googlesource.com/954014Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541826}

BUG=811828
BUG=811794
BUG=811791
BUG=811823
BUG=811871
BUG=811830
BUG=812108
BUG=811867
BUG=811817
BUG=811800
BUG=811826
BUG=811833
BUG=811805
BUG=811824
BUG=811793
BUG=811868
BUG=811783
BUG=811818
BUG=811788
BUG=811784

Change-Id: I7b4b442e8c76d1ba777145c10f0a36148f12c1f0
Reviewed-on: https://chromium-review.googlesource.com/955668
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541825}

This fixes the close button behaviour under Deep-Linked apps to exit VR
before launching a 2D Activity. Also fixes the Settings button to do the
same, and exits to DD home when the Settings Activity is closed.

Also drive-by fixes a bunch of StrictMode service leaks from DaydreamApi
usage that doesn't close the DaydreamApi instance.

Bug: 817811
Change-Id: I93b4544bf9bcfe08de690f466ff4a92d1fe69721
Reviewed-on: https://chromium-review.googlesource.com/953763Reviewed-by: Yash Malik <ymalik@chromium.org>
Reviewed-by: Biao She <bshe@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541824}

Using wpt-import in Chromium b18148a5.
With Chromium commits locally applied on WPT:
14350ac7 "[PE] Don't truncate table cell's padding"
ecd91676 "'navigate-to' directive tests"
636394fb "Introduce InputDeviceInfo interface"
b75f549c "Upstream CSS selectors tests to WPT"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13485

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=robertma

No-Export: true
Change-Id: I095314a93827ea8133b603230fa81d83e43d0c89
Reviewed-on: https://chromium-review.googlesource.com/955722
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541823}

This feature is not used anywhere.

Also fix some if/def comments related to D3D11.

Change-Id: If7b37e88e0a1e8e12d9e55667eef17cc67703fae
Reviewed-on: https://chromium-review.googlesource.com/954415Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541822}

On CL https://chromium-review.googlesource.com/c/chromium/src/+/921961
async retrieval of suggestions in Password Manager was implemented.
The problem that when there are no password forms PasswordController
doesn't call callback that there are no suggestions so in result
Autofill can't provide own suggestions. This CL fixes that.

Bug: 820072
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I4a7dce1540b2217b388caadb19fc2e563c79eb26
Reviewed-on: https://chromium-review.googlesource.com/955685
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541821}

Switch to use a base class of MdTextButton and make changes necessary
to support it.

Also includes some recent Omnibox coloring merges.

Bug: 780835
Change-Id: If3a9b007ff9ef82188f4ffa079ea8d8139d19daa
Reviewed-on: https://chromium-review.googlesource.com/949824
Commit-Queue: Kevin Bailey <krb@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541820}

Per crbug.com/755042, we aren't planning on making all
isPackageGoogleSigned() checks async, and this method isn't used.

Bug: 759574
Change-Id: I0113d8f5acf946777a33cdf4d555a351a4adb1e8
Reviewed-on: https://chromium-review.googlesource.com/953584Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541819}

BUG=819824

Change-Id: I26abb67ecd0ec8759e2e3105691cb44b2c6f23ac
Reviewed-on: https://chromium-review.googlesource.com/953978Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541818}

This reverts commit 82d6a7b4.

Reason for revert: Working on a minor refactoring for phone/tablet
layouts to keep the logic separate until we can consolidate the two.

Original change's description:
> Reland "Fix URL bar text being cropped by action buttons."
>
> A recent change to the layout of the URL bar and the action buttons
> container broke the calculation and application of margin to the URL bar
> to avoid overlap between the action buttons and the URL bar.
>
> This CL fixes the calculation of the new action container's width and
> the appropriate margin to apply to the URL bar, fixing the issue where
> text in the URL bar was hidden underneath the action container.
>
> Bug: 816432,816376
> Change-Id: Ia0c75bec98755610682505c72a145ca53adb2913
> Reviewed-on: https://chromium-review.googlesource.com/952371
> Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
> Reviewed-by: Theresa <twellington@chromium.org>
> Commit-Queue: Troy Hildebrandt <thildebr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#541606}

TBR=mariakhomenko@chromium.org,twellington@chromium.org,thildebr@chromium.org

Change-Id: Ic68d461b9bb7addf4802dfc7536e4709967e5d99
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 816432, 816376
Reviewed-on: https://chromium-review.googlesource.com/955883Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541817}

This CL builds the basic logic and setup of the empty
states in the regular and incognito grids.

A future CL (crbug.com/818198) will create a constants file
and consolidate/organize numbers as needed. This CL leaves
raw numbers in their place to minimize lookups while tweaking.

New raw strings will be internationalized through the process.

Bug: 804557, 804573
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I546e88e195e1273bc34c2f2e5d8c4c2f48930263
Reviewed-on: https://chromium-review.googlesource.com/954714
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541816}

This CL removes the toolbar's shadow during the tab side swipe if the
UI refresh is enabled.

Bug: 820097
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I31854412ea50261d3cd0c590e5f1ddd90393ec33
Reviewed-on: https://chromium-review.googlesource.com/955591Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541815}

Bug: 804686
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia6d56e8640ad946ca9e2b25629fac4f04fae7a1f
Reviewed-on: https://chromium-review.googlesource.com/954349Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541814}

Besides the initial window position and size, the user controls this
behavior. This change makes OverlayWindowViews a views::Widget, which
gives it more control over windowing behavior. Update sizing behavior
and determining window bounds, per UX guidelines.

This change also makes minor cosmetic changes (e.g. window type) to
temporarily make work in progress changes easier.

BUG: 726621
Change-Id: I4cfbacb276a14ea86e00d11dcbfa17781a02533a
Reviewed-on: https://chromium-review.googlesource.com/938580
Commit-Queue: apacible <apacible@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541813}

Change-Id: Ic8f7025c8800c7eed57b8df568f33d2ab8f79f2d
Bug: 812533
Reviewed-on: https://chromium-review.googlesource.com/949866Reviewed-by: Keishi Hattori <keishi@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541812}

https://chromium.googlesource.com/angle/angle.git/+log/ed8b49195844..5164b797cb91

$ git log ed8b49195..5164b797c --date=short --no-merges --format='%ad %ae %s'
2018-03-06 lucferron Vulkan: Support GL_LUMINANCE and GL_LUMINANCE_ALPHA

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Change-Id: I1f27a8276759009462ddb8d1355c5a05b68ba4fc
Reviewed-on: https://chromium-review.googlesource.com/955665
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#541811}

Adds information about total and free disk space to log events
for which it is relevant.

Bug: b/73277923
Test: unit_tests
Change-Id: I8448ae63ee15b4b4cacbb885bff111912c81ffa3
Reviewed-on: https://chromium-review.googlesource.com/951766Reviewed-by: Pavol Marko <pmarko@chromium.org>
Commit-Queue: Bartosz Fabianowski <bartfab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541810}

To make the drop down arrow in the contextual
promos accessible through VoiceOver the code of
DiceSigninButton is refactored.

Instead of making the arrow a child of the signin
button it is made a sibling in the new
DiceSigninButtonView.

Screenshots:
https://drive.google.com/drive/folders/1eHPeM8MtSlT5wFGlNwYCslWSZouE2APG?usp=sharing

Video before highlighting was customized:
https://drive.google.com/file/d/16UqnnqKxRtPCianDSvlqptHVt5ncaSe1/view?usp=sharing

Video after highlighting was customized:
https://drive.google.com/file/d/1BkfBdodNhYLAtcLHSLZQcDkeZuJoWRMw/view?usp=sharing

Bug: 814986, 814807, 818563
Change-Id: I7dd2e77398d84f330114dfb115aea7543ce6afe6
Reviewed-on: https://chromium-review.googlesource.com/949243
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541809}

R=dtrainor@chromium.org,twellington@chromium.org,mdjones@chromium.org,tedchoc@chromium.org,yusufo@chromium.org,bshe@chromium.org,mthiesse@chromium.org,ymalik@chromium.org

Change-Id: I7fcee7cbf2b6e622c3b89cb83d78f5a7320d0de7
Reviewed-on: https://chromium-review.googlesource.com/940130Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Yash Malik <ymalik@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541808}

If the user enters a URL with a slash e.g. 'url/', the formatter,
having no context, will reduce it to 'url' and assume that the cursor
is before the slash '/'. This CL clears the bit requesting such ellision,
preserving the slash.

Bug: 809858
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I241fb58a6ff4223818884adf61f07e801e86e851
Reviewed-on: https://chromium-review.googlesource.com/934640Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Kevin Bailey <krb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541807}

On CL https://chromium-review.googlesource.com/c/chromium/src/+/901664 added
a call of function __gCrWeb.autofill.webFormElementToFormData from
password_controller.js. On codereview it was suggested
https://chromium-review.googlesource.com/c/chromium/src/+/901664/27/ios/chrome/browser/passwords/resources/password_controller.js#296
to move this function to fill.js. It makes sense, since fill.js is supposed
to contain common parts between Autofill and Password Manager. This CL moves
webFormElementToFormData and all dependencies to fill.js. The order from
autofill_controller.js is preserved.

Bug: 807623
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ic538ac44471d19c4e899d4d3450b92bed7da5c0e
Reviewed-on: https://chromium-review.googlesource.com/951609Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541806}

The call is implemented in the base class's implementation,
ModelTypeSyncBridge::DisableSync(). Without such a call, the
processor never takes care of deleting the metadata.

Because UserEventSyncBridge is a commit-only type (in fact the
only one), it forces initial_sync_done when loading metadata. This
is now moved to the processor, because it's common for all
commit-only types and it also needs to be taken care of if
DisableSync() is followed by enable-sync.

In order to test this, some refactoring of tests was needed (and I
chose to introduce MockModelTypeChangeProcessor), because:
a) The former tests had bugs (didn't actually verify some values,
   because callbacks not being run was treated as success)

b) The DisableSync() flow (currently) destroys and recreates the
   change processor, which requires some forwarding proxy to allow
   tests to verify the state across destructions of the processor.

Bug: 819233
Change-Id: I0f1524850ef65b795b7f7082ce4e85171b8e2898
Reviewed-on: https://chromium-review.googlesource.com/951604
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541805}

It is breaking on only the chrome://version URL, but it's simpler to
disable the whole test rather than just one parameter.

Change-Id: I1341d503640058f18a914e6356de83ef8bb6fc1a
Bug: 820070
TBR: bmcquade@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/955625Reviewed-by: Matthew Cary <mattcary@chromium.org>
Commit-Queue: Matthew Cary <mattcary@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541804}

If the custom action icon is particularly small or the toolbar
particularly tall, it would otherwise appear top-aligned.

Bug: 819600
Change-Id: I7dede3da471d4b51b8ce0c290a53397092cd514b
Reviewed-on: https://chromium-review.googlesource.com/955642Reviewed-by: Peter Conn <peconn@chromium.org>
Commit-Queue: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541803}

This reverts commit 70546dc6.

Reason for revert: Causing flaky crashes on waterfall, see https://crbug.com/820075.

Original change's description:
> Fix some tab lifetime management issues in TabLifecycleUnitSource.
> 
> Move the WebContentsObserver from TabLifeCycleUnit to TabLifeCycleUnitSource,
> this allows for a better tracking of the WebContents lifetime, in some
> situation a WebContents might get detached from the TabStrip and then
> destroyed, which mean that we won't get a TabClosingAt notification for
> this tab destruction.
> 
> Another solution would be to implement the TabStripModelObserver::TabDetachedAt
> function and track the tabs which are in a detached state but this is slightly
> more complex because TabDetachedAt might be called for several reasons:
> - A TabDetachedAt usually come after a TabClosedAt event.
> - TabDetachedAt might be followed by TabInsertedAt, or not if it get destroyed.
>   because of this we won't know if we should keep the TabLifeCycleUnit for this
>   WebContents around (i.e. if it'll get re-inserted in a tab strip) or destroy
>   it because it's being destroyed.
> 
> Observing WebContentsObserver::WebContentsDestroyed and moving the logic that
> was in TabClosingAt to this method address these issues, it's the same approach
> than the one we took in TabStatsTracker.
> 
> Bug: 819352, 818454
> Change-Id: Ibd3fe49b2798ade19ee781cb70eb30e52372d686
> Reviewed-on: https://chromium-review.googlesource.com/952405
> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
> Reviewed-by: Chris Hamilton <chrisha@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#541540}

TBR=chrisha@chromium.org,sebmarchand@chromium.org

Change-Id: I0aa17b4db9f4c1468e190ef4ec0dc86aeb08c3a8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 819352, 818454
Reviewed-on: https://chromium-review.googlesource.com/955882Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541802}

Bug is identical to the last :/. No idea why it's much more frequent with mojo,
possibly a race is likely to happen when destroying a frame: |callback_| is
destroyed due to frame being destroyed, and authorization is failed for the
same reason. With the per process message filter, authorization wouldn't fail
due to the frame being destructed.

Bug: 819277
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ic17dc96d2c83a08732b43094bac2f2c3fa7035ad
Reviewed-on: https://chromium-review.googlesource.com/951774
Commit-Queue: Max Morin <maxmorin@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541801}

This adds support for encoding the launch id for the context menu item,
in a similar way as for the button index (context menu click is treated
by the Action Center as a button click).

This also removes the check for native notifications being enabled
while processing the command line at startup. Main reason for that
is that the notification activator does not enable native notifications
when it passes the command line to Chrome, but native notifications
are already implied anyway (otherwise the notification activator wouldn't
be used). So, we can remove the check.

Bug: 734095
Change-Id: I629dabaab290fba9043114bf2403daba2b8b7f0c
Reviewed-on: https://chromium-review.googlesource.com/952446
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541800}

This test appears to be causing NewTabPageTest#testRender to flake.
Spectulatively disabling.

BUG=813589

Change-Id: I0bdd566c14d1e6d3521e00e097e55a9f079e76a1
Reviewed-on: https://chromium-review.googlesource.com/954333Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541799}

This CL changes the autofill_agent in iOS so that it expects a vector of

This makes it easier to fiddle the displayed type prediction (e.g., from
overal to server) and makes the interface more similar to that of Desktop.

autofill: :FormDataPredictions instead of a vector FormStructure pointers.
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I79d45ae585d98621b03d2753829405ee47bae8d3
Reviewed-on: https://chromium-review.googlesource.com/953206Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541798}

This OWNERS file was added temporarily to fix a broken OWNERS
chain. Remove now that we no longer need it.

Part two of a two part fix for c/b/ui/views/overlay/OWNERS.

BUG: 819870
Change-Id: I5f3c280c2a97e504b96f7dbad7331ae930324fed
Reviewed-on: https://chromium-review.googlesource.com/954341Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541797}

Bug: 813821
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I82a9c0cc52f783964841ecf3ae656769620b852e
Reviewed-on: https://chromium-review.googlesource.com/954544Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541796}