GitLab

This relands the original change, fixing a use-after-free when
BrowserWindowDefaultTouchBar outlives its profile.

Original change's description:

> This is a design tweak which also enables the back and forward buttons
> to be placed separately. Existing customized Touch Bars which contain
> the grouped item still work; see the code comment for details.
>
> I used Cocoa bindings for the buttons' enabled states instead of holding
> pointers to them because I initially thought that the Touch Bar might allow the
> group and individual buttons to coexist. Turns out no, but I kept the KVO
> implementation because I like it.
>
> It also includes a couple of other changes that came up while writing
> this patch and during code review:
>
> - The unit tests no longer look for a hard-coded list of items in a
>   specific order. Instead, they verify that BrowserWindowDefaultTouchBar
>   can create the items it claims to be able to create, and that no
>   known-valid identifiers have stopped working.
>
> - BrowserWindowDefaultTouchBar returns nil if it doesn't know about an
>   identifier, instead of returning an empty Touch Bar item.
>
> Bug: 937935
> Change-Id: I8cdc6347bc667b0a24fa24fe2c6a56661747ac98
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534238
> Commit-Queue: Sidney San Martín <sdy@chromium.org>
> Reviewed-by: Leonard Grey <lgrey@chromium.org>
> Auto-Submit: Sidney San Martín <sdy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#649899}

Bug: 937935, 945772
Change-Id: I77bf9b6d14bef875f271f8fbd4468e6cdc30434e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568846
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651851}

This is a reland of
https://chromium-review.googlesource.com/c/chromium/src/+/1566685

Bug: 952231
Change-Id: Ifc193d8745fbe8ea6702b73adda6cb0f3b5a1943
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572227Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651850}

Implements the Unwinder subclass necessary to use the V8 asynchronous
unwind functionality with the StackSamplingProfiler. Does yet make use
of the unwinder.

Bug: 909957
Change-Id: I3974e0a4c2ed7eac36715d3deb84074b2c65af1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566371
Commit-Queue: Mike Wittman <wittman@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651849}

Applies the same IsProfilerEnabledForCurrentProcess() check to
ThreadProfiler::AddAuxUnwinder() as is used for the other member
functions, to avoid trying to set an aux unwinder on a null profiler.

Bug: 909957
Change-Id: I1f131132d6bf021e3502d175b068854c98856f27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570608
Commit-Queue: Mike Wittman <wittman@chromium.org>
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651848}

https://chromium.googlesource.com/external/github.com/google/shaderc/+log/59a49bc5cdff..60caf55788c6


git log 59a49bc5cdff..60caf55788c6 --date=short --no-merges --format='%ad %ae %s'
2019-04-17 fjhenigman@users.noreply.github.com Package and upload builds. (#595)


Created with:
  gclient setdep -r src/third_party/shaderc/src@60caf55788c6

The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I6d625744ffb53b862fd6f04f34cc9661970e04bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572190Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#651847}

This adds a script for taking a WebView netlog. This handles appending
to the CLI flags, choosing a suitable on-device filepath in the app's
data directory, and pulling the file off the device at the end.

This updates the markdown documentation to promote the new script.

Bug: 902039, 918221
Test: Manual - use the script with both NS on & off
Test: tools/md_browser/md_browser.py
Test: Upload to gerrit > open file > click "gitiles"
Change-Id: Iaf57bb4ab5e692e0b8467df6ce1d36cc2874339f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570198Reviewed-by: Paul Miller <paulmiller@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651846}

Change-Id: I8160bc9123cc2c4640601cbc91b19638a59cc1ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570288Reviewed-by: Wei Li <weili@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651845}

Implements an stack walking algorithm using the native and auxiliary
unwinders, to unwind stacks that contain both native and non-native
frames. When an auxiliary unwinder is in place to support v8 unwinding
this will enable walking stacks with interleaved native and v8 code.

Bug: 909957
Change-Id: I62fb9b650f53b3c0413b2e7dacf8ffa487a0e1a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566350
Commit-Queue: Mike Wittman <wittman@chromium.org>
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651844}

This is a reland of 6c1fef80

TBR=holte@chromium.org

Original change's description:
> Allow recording the app-list animation smoothness by target state
>
> This adds new uma histograms to track the animation smoothness
> by the target state.
>
> Bug: 951853
> Test: manually
> Change-Id: Iea1a7a31dc3afc6af7dae377a558b280c8ed2afe
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565532
> Commit-Queue: Jun Mukai <mukai@chromium.org>
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Reviewed-by: Steven Holte <holte@chromium.org>
> Reviewed-by: Alex Newcomer <newcomer@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#651475}

Bug: 951853
Change-Id: I194e7cf530bb2a9d517df05a98b1cb5f3e31f857
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572270
Commit-Queue: Jun Mukai <mukai@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651843}

I also had to remove the autocomplete="off" from a lot of
FormStructureBrowserTest test cases. Basically, since we're not really
querying the Autofill server during browser tests, then all of the
"server" predictions are set as NO_SERVER_DATA. Now, in conjunction
with the AutofillOffNoServerData, this means that any input in these
tests that has autocomplete="off" would have their predicted type
overwritten as UNKNOWN_TYPE. To make sure that the tests still cover
client-side heuristics (like they were intending to), I'm removing the
autocomplete="off" attributes from failing tests, which means they're
now properly testing these heuristics.

Bug: 949784
Change-Id: I2c0c3f20e5ccd01936510c2461e9ebd8c477fb45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569745
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651842}

This CL introduces ScheduledNotificationManager class which loads data from
storage and hold scheduled notifications in memory.

Bug: 930968
Change-Id: I3190cc89ab453ef231ff0ca91fbdadd5a29b49e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566213
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651841}

|has_surface_damage| is no longer used. The underlay optimization had been
replaced by occluding_damage_rect. |has_surface_damage| had been removed
from both Windows and Chrome OS overlay processors. See CL 1510075.
https://chromium-review.googlesource.com/c/chromium/src/+/1510075.

Bug:947800

Change-Id: I8ef09411db8855e150453c28d3f5a1e1c4f22074
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570630
Commit-Queue: Maggie Chen <magchen@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651840}

If the suggestion transparency flag is on, use the clock icon for search
history matches.

Bug: 929477
Change-Id: I39d33dc5139857cf6397c20762e632eeaf68f45e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572250Reviewed-by: Orin Jaworski <orinj@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651839}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/fd3e5e3a..0d449a89

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I33a38e6bf8cde155b7de2055920c858c742e5f8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572232Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#651838}

- Creates a ClipboardItem.
- Uses ClipboardItem for navigator.clipboard.{read,write}()
- Updates navigator.clipboard tests and adds ClipboardItem tests.
- Final CL for shipping new Async Clipboard API w/image support! :D

Bug: 150835
Change-Id: Ic7059fbbb87c60487af8ad0d8a9e5ab92978f8f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553383Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651837}

Bug: 783442
Change-Id: Ifcceaf981b5841872280149b882f5d3949ca9dc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553174Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651836}

The class DisableFontSmoothing is modifying a system wide setting
that affect rendering. Unfortunately, that setting is also affecting
other unittests.

The call to SystemParametersInfo is modifying a system-wide setting:
see: https://docs.microsoft.com/en-us/windows/desktop/api/winuser/nf-winuser-systemparametersinfoa

It seems to have first appeared in
  https://codereview.chromium.org/100255
to cater for the test -- RenderViewTest.PrintLayoutTest.

Chrome tests should not modify the global state of the system.
Unittests should be able to handle different configurations.

Every tests are passing correctly. If some tests are failing or disabled
because of this class, we should fix it by detecting if fonts smoothing
is activated or not.

Bug: 953293, 759870
Change-Id: Ib1899f00ba18ae530da2a078933ff8b0a0983f45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569969Reviewed-by: Wei Li <weili@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651835}

Host permissions for Manifest V3 can only be specified in the new
manifest key |host_permissions|. Hosts in |permissions| or
|optional_permissions| will trigger an install warning.

Bug: 62898
Change-Id: I5f12dfadfcdcad522cc231478ff2cb405ebd2648
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560730Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651834}

Creates ChromeActionsAppInterface to serve as the eDO interface for
actions-related helpers, following the pattern established for EG2 helpers.
Uses the C++ wrappers to handle conversions from std::string to pure ObjC
objects suitable for transfer over IPC.

BUG=922813

Change-Id: Ic9e8f31af179f3a3cedcf29e92320ef0e12db1b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569750
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651833}

Using mach_thread_self() returns a reference that must be deallocated
with a separate system call. Using the cached port stored by pthreads
means not having to issue two system calls to get the thread ticks.

Change-Id: Ic3a1e8cbe74a88f070a1c6843b03778132a53b98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572438Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651832}

This CL copies the settings-main and settings-basic polymer components
used by the currently combined OS and Browser settings page to the
future exclusive OS settings page.

This CL also renames settings-* to os-settings-* in os settings.

Bug: 950007
Change-Id: I7a0412964de498683bf329683411812503024f3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566621Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: May Lippert <maybelle@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651831}

https://android.googlesource.com/platform/external/perfetto.git/+log/854d22feaf4b..084712c40e18


git log 854d22feaf4b..084712c40e18 --date=short --no-merges --format='%ad %ae %s'
2019-04-17 ilkos@google.com Merge "Fix start_ts associations"
2019-04-17 cferris@google.com Merge "Modify initialize function for changed parameter."


Created with:
  gclient setdep -r src/third_party/perfetto@084712c40e18

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: Ia03904098cbadb1350c5024b07bd7620b4c90dc6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572187Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#651830}

Right now, when the user double-clicks a word within an elided URL, we
trigger unelision on the second mousedown. During unelision, the text
shifts. If the mouse moves at all during the second mouseup, the
selection may change unexpectedly.

This is ordinarily not a problem, but since the text has shifted
underneath the user, even tiny mouse movements can cause large
selection changes.

This CL fixes that by applying a minimum threshold to any drag
movements (8px). Any drag movements smaller than that are ignored.
This threshold is active until mouseup.

Bug: 951447
Change-Id: I584b827e408e2d03e20d76bb0bd3b038e193e80c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570571
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651829}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d7ea5259bb00..db8bc8a9d46c


Created with:
  gclient setdep -r src-internal@db8bc8a9d46c

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=etiennep@chromium.org,hayato@chromium.org,atotic@chromium.org

Change-Id: I8ec60a6ed8def71661f76398e7ace0590f012d92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572181Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#651828}

Change-Id: I41534e7523fe04c07051da087c9c5b19b332de15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572269Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651827}

This is a reland of 91a61a31

Original change's description:
> [Switch Access] Refactor focus for clarity around back button
>
> Bug: None
> Change-Id: I3318ae4d5f37d67e7fe5abb894f9edacddc785d4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549944
> Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
> Reviewed-by: Katie Dektar <katie@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#647532}

Bug: None
Change-Id: I5fbb04a2c11c7e77afc98891dc60f795bb9f2c0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553812Reviewed-by: Katie Dektar <katie@chromium.org>
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Cr-Commit-Position: refs/heads/master@{#651826}

The original UMA and UKM include subframes since crrev.com/645061.
Reporting the main frame jank separately will assist our analysis.

UKM collection review doc: go/lsukmrevmf

Bug: 581518
Change-Id: I5f9119492033a31d6896e35cd08ae848378907d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553653
Commit-Queue: Steve Kobes <skobes@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651825}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e72279d25f75..1e2cb1573bd2


git log e72279d25f75..1e2cb1573bd2 --date=short --no-merges --format='%ad %ae %s'
2019-04-17 maruel@chromium.org [roll-dep] Ignore chromium-autoroll rolls


Created with:
  gclient setdep -r src/third_party/depot_tools@1e2cb1573bd2

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I4dc48ec04dc56b694a0a2ec9d65f107c2cb82af5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572186Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#651824}

Fix a crash introduced from http://crrev/c/1556779

Bug: 942771
Change-Id: I86e05da12c15447a9ad5f551b5e39683778e3f23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570920Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651823}

Mirroring state would be sticky when the bubble anchor changed but not when the bubble would be recreated.

Bug: 910739
Change-Id: Ia9a9609b2959fe8133437da5966fdc7f41c32a3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570539Reviewed-by: Dana Fried <dfried@chromium.org>
Commit-Queue: Caroline Rising <corising@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651822}

Bug: 949773
Change-Id: I390333a7b9f5c67c4200fd28cc5d08b2719a7905
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570131Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Auto-Submit: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651821}

RenderFrameImpl::CommitSyncNavigation() runs a navigation synchronous
only if (1) the navigation will load as empty, and (2) it is the
first navigation in the frame. TestWebFrameClient::BeginNavigation
now follows the same rules.

Bug: 855189
Change-Id: Ic5858ab1d8617a359d44f5e8cbc034de5bc4bf34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548050
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Auto-Submit: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651820}

Now that Dawn is tested on the chromium.dawn waterfall, it is no
longer needed to have use_dawn=true on the gpu fyi bots.

Bug: 948902
Change-Id: I6abd029b63e5d845879baaf3eb1cca76ee7eae8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572262Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651819}

Update expectations for

http/tests/devtools/elements/styles-3/styles-add-blank-property.js
http/tests/devtools/elements/styles-4/styles-update-from-js.js

TBR: atotic@chromium.org
Bug: 938884,946716
Change-Id: Id57c4e781770a706fac559e3152c4277ea09d286
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572272Reviewed-by: Aleks Totic <atotic@chromium.org>
Commit-Queue: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651818}

Provisional document loader is going away (see step 8.d from the doc
linked to the bug), so we explicitly pass DocumentState and
ui::PageTransition to WillSendRequestInternal.

This required splitting GetTransitionType as well, since it uses
WebDocumentLoader internally.

Bug: 855189
Change-Id: I03e9f342d258e56c2eff97128fa8461f27f2fb5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522334Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651817}

The proper color should be dark red according to the specs.

BUG=953242

Change-Id: I509587210eff6422ab48a29b189785b67c103f99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570543Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651816}

This fixes a UX issue where menus that have no other content and otherwise
wouldn't be shown are shown when a screen reader is enabled. For example,
in the Files app in Chrome OS, there are some areas that have no context
menu, and just showing this one is counter intuitive.

Bug: 953063
Change-Id: Ib6516d1aa33c207b5dc66e2ecd4032faf8b50363
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568653Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651815}

The omnibox disables autocompletion if the user has backspaced - detected
by checking the current text size against the previous text size. An exception
to this is trailing selected text, which is not considered when comparing the size.

Previously only the selection_end field was used to determine the size of the selection,
which is incorrect in the case of an inverted selection (where the selection start is
greater than the end). This fixes that.

Bug: 951375
Change-Id: Ie245db06570e3b6df8d41a7645d60429973eecf6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570751Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Will Cassella <cassew@google.com>
Cr-Commit-Position: refs/heads/master@{#651814}

This turns down the following bots:

https://ci.chromium.org/p/chromium/builders/ci/Android%20Find%20Annotated%20Test
It's been red and unmaintained for a while.

https://ci.chromium.org/p/chromium/builders/ci/Android%20Remoting%20Tests
Same thing.

https://ci.chromium.org/p/chromium/builders/ci/Android%20VR%20Tests
Its tests moved to the main android waterfall.

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20Builder%20%28dbg%29
Served to only trigger the prev three testers.

Bug: 952610
Change-Id: Iafaeb7d430f9d12d8a5440b60c98cb96174139f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570658Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651813}

This patch removes the clipping portion from the rounded corner shader.
This is not needed and as the layer with the rounded corner is already
masked to bounds and clipped.

This clipping also caused bugs due to it not performing any blending for
partial pixels.

Bug: 952100
Change-Id: Ib006e1cc52144db33ed209edda42b9371963f45c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570687Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651812}