- 19 Jun, 2019 1 commit
-
-
Eric Roman authored
Bug: 972125 Change-Id: Ieba22ac128dbb4c6e24e1ff417a84c5e4f775605 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660966Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#670297}
-
- 18 Jun, 2019 39 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f91aeb259e09..7694b90eb000 git log f91aeb259e09..7694b90eb000 --date=short --no-merges --format='%ad %ae %s' 2019-06-18 bsalomon@google.com Revert "Consolidate quad optimizations into single internal function." 2019-06-18 brianosman@google.com Cast to fix Linux ANGLE builds 2019-06-18 jlavrova@google.com Refactor font resolution out of font iterator; 2019-06-18 robertphillips@google.com Add Ganesh support for RGBA_16161616 and RG_half (take 2) 2019-06-18 mtklein@google.com extract Assembler so it can be tested 2019-06-18 brianosman@google.com Revert "Interpreter: Support striped inputs for less overhead" 2019-06-18 borenet@google.com [infra] Add UpdateGoDeps bot 2019-06-18 brianosman@google.com Connect ANGLE's trace events to Skia's tracing 2019-06-18 michaelludwig@google.com Consolidate quad optimizations into single internal function. 2019-06-18 jvanverth@google.com Minimize renderstate changes and vertex buffer rebinding. 2019-06-18 egdaniel@google.com Reland "Store GrSwizzle on proxies for texturing and swizzling." 2019-06-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-06-18 mtklein@google.com start excising xbyak 2019-06-18 borenet@google.com Remove experimental Go bindings 2019-06-18 benjaminwagner@google.com Add Firestore emulator to gcloud_linux asset. 2019-06-18 rmistry@google.com [skottie-wasm-perf] Add recipe and CPU bot 2019-06-18 bungeman@google.com Remove SK_IGNORE_MAC_BLENDING_MATCH_FIX. 2019-06-18 brianosman@google.com Interpreter: Support striped inputs for less overhead 2019-06-18 brianosman@google.com Revert "Revert "Shuffle SkSL sources around so compiler and bytecode can be used w/o GPU"" 2019-06-18 borenet@google.com [infra] Fix Cloud Build Created with: gclient setdep -r src/third_party/skia@7694b90eb000 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bsalomon@google.com Change-Id: I7e9f1423aa159c1b5eaf85c11dc2bb05c635ba2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665889Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#670296}
-
Caitlin Fischer authored
1. AutofillPruneSuggestions 2. AutofillUseMobileLableDisambiguation Bug: 963157, 970351 Change-Id: I5d0870b39d5dd57ade56650a922390b0be7cb21c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660417Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#670295}
-
Evan Stade authored
Move SetQuietMode to AssistantNotificationController interface. It's only used by assistant code. Bug: 958191 Change-Id: I02e2da517e760d0c2e0cff9d2f0cc6c78f34d1e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660644 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Takuto Ikuta authored
We have occasional compile failure due to backend error. https://luci-milo.appspot.com/p/chromium/builders/luci.chromium.try/linux-rel?limit=200 Let me switch back to use old goma backend until we fixed the error. Bug: b/135145905, 976362 Change-Id: I6da5b5a94fdd9dcb2b52cf1a21aa7da9a3f82ca2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665774 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#670293}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/81b6acfb8685..32d718f3e81e git log 81b6acfb8685..32d718f3e81e --date=short --no-merges --format='%ad %ae %s' 2019-06-18 jonahr@google.com NVIDIA Shield workaround for IsNVIDIA() detection 2019-06-18 sunnyps@chromium.org Add support for D3D11 texture backed EGLImages 2019-06-18 jonahr@google.com Fix Platform.h integration with ANGLE 2019-06-18 jmadill@chromium.org Remove gl::Context parameter from Observer functions. Created with: gclient setdep -r src/third_party/angle@32d718f3e81e The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:939655 TBR=jonahr@google.com Change-Id: Ibfc216a8b5ea8c3a0b6ba5b8611c80ce0f7c71dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665709Reviewed-by:
-
James Cook authored
Also Keyboard.ShortcutViewer.SearchUpdateTimeVisual. Keyboard shortcut viewer has been in production for many milestones and its performance is adequate. Bug: 975901 Change-Id: I63c01eb253e7424ecd5bd85e17752d96c8d29b2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665297Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#670291}
-
Weilun Shi authored
With this change, users can change their variation permanent country via chrome://translate-internal and the country stored will not changed on chrome updated. Bug: 793889 Change-Id: Ifdef9c911a83c2435474bdd775d3a018b99ace57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573720 Commit-Queue: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Rachel Blum <groby@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#670290}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/84c5a537..353cbaa9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6b1212dd1e2bce049599c09045c5a06aaa112541 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665204Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#670289}
-
Xiaoqian Dai authored
And also make OverviewController::ToggleOverview() a private function. All callsites of ToggleOverview() are modified to use StartOverview() and EndOverview() instead. Bug: None Change-Id: Idf11ec78770afab33c4e1298dfee17dbb08b09b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662505Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#670288}
-
Nate Fischer authored
md_browser wasn't correctly slugifying escaped characters in header names. Gitiles shows the literal character (ex. "\_" shows as "_"), but md_browser previously slugified to "_95_" as an artifact of the python library encoding escaped chars as "\x02 (ASCII code for escaped char) \x03", where \x02 & \x03 are "start of text" and "end of text" respectively. This adds a step to decode decimal codes in-between \x02 & \x03. Bug: 974025 Test: tools/md_browser/md_browser.py android_build_instructions.md (click "Figuring out target_cpu") Test: I also tested this by comparing against https://crrev.com/c/1665854 Change-Id: I561be6f0742d11ac5188e5680573ce112b8883fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658676Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#670287}
-
Mei Liang authored
This CL adds TabSelectionEditorLayout that is a SelectableListLayout, and its visibility is controlled by TabSelectionEditorLayoutBinder, as well as the click listeners for the toolbar buttons. Change-Id: Ib3888cdf3eed9fa66c815c5196fbd460476ef224 Bug: 972299 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649122Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#670286}
-
Takuto Ikuta authored
Bug: 974660, 976362 Change-Id: Iea8ad0cef870131b1b65df1bfc4b3b35a081baa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665895 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#670285}
-
Jon Mann authored
Bug: 976384 Change-Id: Ibb18e97bd5e799a513922b81698eb5cea98b5bfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665912 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#670284}
-
Michael Spang authored
This reverts commit 0d06e98a. Reason for revert: Causes a crash: VUID_Undefined(ERROR / SPEC): msgNum: 0 - Instance Extension VK_KHR_xlib_surface is not supported by this layer. Using this extension may adversely affect validation results and/or produce undefined behavior. Objects: 1 [0] 0, type: 0, name: NULL Received signal 11 SEGV_MAPERR 000000000040 Original change's description: > Enable VK_LAYER_LUNARG_standard_validation with VK_KHR_xlib_surface > > Tested it with vulkan-validationlayers-1.0.106 > > Bug: 843346 > Change-Id: I180d690421ede3251721452334e59b35c28f0d49 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662534 > Commit-Queue: Peng Huang <penghuang@chromium.org> > Auto-Submit: Peng Huang <penghuang@chromium.org> > Reviewed-by: Jonathan Backer <backer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#669729} TBR=penghuang@chromium.org,backer@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 843346 Change-Id: I5a164b461039cdf1805594fcff697a9e99e60714 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665430Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#670283}
-
Anastasia Helfinstein authored
Bug: 974949 Change-Id: I9fac4c21281102dc4294c111763c917ecef4b340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665350Reviewed-by:
-
Martin Kreichgauer authored
FidoDeviceAuthenticator::BioEnrollFingerprint() potentially derefences a base::nullopt if an authenticator unexpectedly omits a required templateId in its response. It also users a static variable to temporarily store the templateId of on ongoing enrollment, which only works as long as only a single FidoDeviceAuthenticator is ever instantiated. Bug: 974046 Change-Id: I6ebba028ba3f214fb2ee47c0dc53b2d91fc79676 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663035 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#670281}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/baea8814b88e..26377fc5ea90 git log baea8814b88e..26377fc5ea90 --date=short --no-merges --format='%ad %ae %s' 2019-06-18 jbudorick@chromium.org devil: shorten android src link. 2019-06-18 khokhlov@google.com Fix artifact creation on Windows 2019-06-18 bsheedy@chromium.org [Devil] Restore root after system app modification 2019-06-18 perezju@chromium.org [Telemetry] Remove unused bits of PageTestResults Created with: gclient setdep -r src/third_party/catapult@26377fc5ea90 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:976274,chromium:972221,chromium:973837 TBR=eyaich@google.com Change-Id: I4d56fafc011c5b8835eed9b0aa9231572eaa652c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665291Reviewed-by:
-
Bruce Dawson authored
If a process has already gone away when you call TerminateProcess then TerminateProcess will fail with error code 5. This seems unintuitive to me and the resulting error spew when running tests can be misleading. This change avoids printing the message when GetLastError() is ERROR_ACCESS_DENIED to avoids the spuriuos debug spew. This was noticed while investigating crbug.com/861730 Change-Id: I869073bd3c6b0c00ceeee7d7f1139e3091e3a1cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662974 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#670279}
-
David Black authored
AssistantWebView's child view for embedded WebContents was not being sized during initialization due to a failed initialization condition check. Bug: b:135215741 Change-Id: I470daf60466baa3435c431f6256468c0cbc641ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665776Reviewed-by:
-
Steve Kobes authored
Also rename JankRegion to LayoutShiftRegion. (There are still many references to "jank", which will be cleaned up in follow-up patches.) Bug: 963474 Change-Id: I33683bbd95dfea135f6e30215ddd09959913e8da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644230 Commit-Queue: Steve Kobes <skobes@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#670277}
-
sczs authored
Bug: 973877 Change-Id: I546ad0782c578607ae8af99524804d07fc35577b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660786 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#670276}
-
Yuwei Huang authored
This reverts commit 5139af43. Reason for revert: Reverting this change in favor of blacklisting CFI cast check in the blacklist file. See crrev.com/c/1665554 Original change's description: > [gRPC] Suppress CFI cast checks > > ChromeOS builders build Chrome with CFI cast check enabled, so using > reinterpret_cast on invalid/uninitialized pointer will crash Chrome. > This is what happened in grpc_core::InlinedVector, which tries to use > reinterpret_cast before initializing the storage. > > While the proper fix should be calling the placement-new operator > directly on the raw (void*) pointer, the easiest and safest fix for M76 > is just to disable CFI cast checks when building the gRPC library. > > I've verified that the crash was reproducible with > ftl_signaling_strategy if I add `is_cfi=true` (and other required > arguments) to GN args, and the crash goes away once I've added these > compiler flag. > > Bug: 972108 > Change-Id: Idf874a028af002fafe3a4905d70a3bca71777e42 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660194 > Commit-Queue: Joe Downing <joedow@chromium.org> > Reviewed-by: Joe Downing <joedow@chromium.org> > Auto-Submit: Yuwei Huang <yuweih@chromium.org> > Cr-Commit-Position: refs/heads/master@{#669203} # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 972108 Change-Id: I9146543b71ab139e4a91bd9add77229c1db9a5c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665775Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Auto-Submit: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#670275}
-
Koji Ishii authored
This patch fixes computing max-content for tabulation characters when `break-word` is set. In that case, multiple tabulation characters are broken into multiple NGInlineItemResult. This patch supports such cases when computing max-content. Bug: 972000 Change-Id: I1da0cda6e61f0bc122f9d942a7a2d91d82f83a72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663900Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#670274}
-
siyua authored
Add flow to handle case when card is successfully saved to server. Details are not implemented yet, and this CL only changes the logic to save card bubble controller. Bug: 964127 Change-Id: I678e1a30cec878d6701c984434ccdc1251f91923 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650717Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#670273}
-
Archana Simha authored
The trigger is notified when a popup is blocked. If the frame causing the blocked popup is a google ad frame we send a RIND report. For more details see: go/extending-chrind-q2-2019-1 Bug: 965587 Change-Id: I8f079bd3b254a3664abd4855d9c9cb393ce2ec4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628173 Commit-Queue: Archana Simha <archanasimha@google.com> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#670272}
-
Paul Miller authored
Variations studies can have country filters so they only apply to users in certain countries. WebView must persist these prefs to support this. Studies configured for "session consistency" can use a different country on every run. These studies compare their country filter to the current country, which is stored in kVariationsCountry. Studies configured for "permanent consistency" will continue using the original country if the user moves countries. These studies compare their country filter to all the past countries listed in kVariationsPermanentConsistencyCountry. See CheckStudyCountry() in study_filtering.cc for how this works. BUG=823410 Change-Id: I76d6fc3e69a173d8b2de07ea886c215ad91f2f81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665468Reviewed-by:
-
Johannes Henkel authored
This is a reland of 65941216 TBR=lgrey@chromium.org Original change's description: > Reland "[DevTools] Roll inspector_protocol and migrate to std::vector." > > This reverts commit 3a73cee4. > > Reason for revert: <INSERT REASONING HERE> > > Original change's description: > > Revert "[DevTools] Roll inspector_protocol and migrate to std::vector." > > > > This reverts commit dc15ca61. > > > > Reason for revert: suspected to be causing link failures on android > > "ld.lld: error: thunk creation not co" when linking lib_components_browsertests__library.so > > eg: https://ci.chromium.org/p/chromium/builders/try/android-kitkat-arm-rel/288408 > > > > Original change's description: > > > [DevTools] Roll inspector_protocol and migrate to std::vector. > > > > > > New revision: 83b1154a9661d22bba9a368d368214cc20880419 > > > > > > This updates the usages of the protocol types to the new > > > definitions, using std::vector-based implementations > > > of protocol::Array. > > > - In many places we can now use the C++11 style for( : ) loops. > > > - We use std::make_unique for creation. > > > - We use emplace_back to insert elements, which sometimes > > > allows us to create strings etc. in place. > > > - Accessing strings in arrays is cheaper, since vector[i] > > > returns a reference (protocol::Array::get made a copy!). > > > - One can assert equivalence of vectors with strings > > > in tests (EXPECT_THAT(foo, testing::ElementsAre("bar", "baz")); > > > - Overall the code is shorter, as the vector API is > > > more concise. > > > > > > Change-Id: I6c8e152987fb0dcfbb01f9086ee48b284a0e5adb > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657628 > > > Commit-Queue: Johannes Henkel <johannes@chromium.org> > > > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > > > Reviewed-by: Leonard Grey <lgrey@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#669857} > > > > TBR=alph@chromium.org,caseq@chromium.org,lgrey@chromium.org,johannes@chromium.org,kvitekp@chromium.org > > > > Change-Id: Iabcd0386f28787f5042e1f252c9e330330cc525f > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663403 > > Reviewed-by: Ben Pastene <bpastene@chromium.org> > > Commit-Queue: Ben Pastene <bpastene@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#669922} > > TBR=alph@chromium.org,caseq@chromium.org,bpastene@chromium.org,lgrey@chromium.org,johannes@chromium.org,kvitekp@chromium.org > > Change-Id: Ia917b8b41af985303dbf6a129ee2d281f7cecc1f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665168 > Reviewed-by: Johannes Henkel <johannes@chromium.org> > Commit-Queue: Johannes Henkel <johannes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#670151} Change-Id: If2161c0e35c2809b746b1ec2737d068ef791eb59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664979 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Johannes Henkel <johannes@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#670270}
-
Ryan Hansberry authored
Several popular headphones (e.g., Bose QuietComforts, Sennheiser 550s, Sony WH-1000XM3s, etc.), as well as other peripherals like printers, send out BLE advertisements while on but not pairable. The current Chrome OS behavior of displaying these advertisements is confusing to users (because they try to pair them and can't) and noisy. This CL filters these advertisements out (by way of not filtering out dual mode devices whose type/appearance are not set), while still surfacing the headphones in the UI once they become truly pairable. Bug: 930229 Change-Id: I252c3e391aac3d546e455ab01e626c08af0c64b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656971 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#670269}
-
Becky Zhou authored
Add dark variant on render tests of ArticleSnippetsTest, and update golden images. Bug: 948443 Change-Id: Ib2a39f3f3b25c246b50bea000e09c6c686aa4913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656668 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
-
Marialicia Villarreal Garcia authored
This change implements HelpText property for views by exposing one of the following: 1. If Placeholder is available, set its value as the HelpText. 2. If the element has NameFrom::kTitle or NameFrom::kPlaceholder, expose StringAttribute::kName as the HelpText. 3. If Tooltip is available, set its value as the HelpText. 4. Return S_FALSE if there is no help information available. This change also adds an AXPlatformNodeWinTest to test the new implementation of HelpText property. Change-Id: I8a3d0d38273da75d7969a60f70a4627c96e8ffde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661003Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Maria Villarreal <mavill@microsoft.com> Cr-Commit-Position: refs/heads/master@{#670267}
-
Mario Bianucci authored
CursorType and WebCursorInfo were mirrors of each other, existing to avoid dependencies between ui and Blink. Recently however, other enums in a similar position were merged together in order to simplify things[1], and so it was decided that it would be best to do the same thing here. The two merged enums were in blink/public/platform/web_cursor_info.h and ui/base/cursor/cursor_type.h. blink/renderer/platform/cursor.h also had the enum, so I removed it there too. I also removed any code that was necessary for translating between them. [1]: crrev.com/e15b80b4 TBR=alexmos@chromium.org,caseq@chromium.org,oshima@chromium.org Bug: 969904 Change-Id: Ib20d0e3b003820b78a8740b4e352b289edd728f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648895 Commit-Queue: Mario Bianucci <mabian@microsoft.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#670266}
-
Lukasz Anforowicz authored
This CL goes through CORB histograms that work with and without NetworkService and: 1. Marks as obsolete and stops logging ones that are no longer needed: - SiteIsolation.XSD.Browser.Blocked.ContentLength.WasAvailable - SiteIsolation.XSD.Browser.Blocked.ContentLength.ValueIfAvailable - SiteIsolation.XSD.Browser.BytesReadForSniffing 2. Removes expiration date for ones that should be useful for the long-term: - SiteIsolation.XSD.Browser.Action" 3. Keeps temporary ones that should help evaluate the impact of protecting additional MIME types in M76: - SiteIsolation.XSD.Browser.Blocked.CanonicalMimeType Bug: 940785 Change-Id: I1272c93158587120c597e2a64cf050ad2bce6706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652371 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
-
dpapad authored
Bug: None Change-Id: Ie37d787653831c833b5ec9490fab6f79bb2ee196 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665349 Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#670264}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/872c1d7fe98a..92cdeaaf810b git log 872c1d7fe98a..92cdeaaf810b --date=short --no-merges --format='%ad %ae %s' 2019-06-18 rharrison@chromium.org Rolling 4 dependencies Created with: gclient setdep -r src/third_party/dawn@92cdeaaf810b The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Change-Id: I29d6dabb542036c08b14016aea5e1af863c07b45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665293Reviewed-by:
-
Piotr Bialecki authored
Removes old references to hit test from plane detection sample. Change-Id: I741c81fd82016c974b7a95b7bf66f5ea1a8e0f74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665908Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#670262}
-
Eugene But authored
This reverts commit 8d972fd2. This CL removes the usage of CHROME_EG_ASSERT_NO_ERROR from autofil automation tests. TBR=rohitrao@chromium.org Bug: 963613 Change-Id: I7cf6effb15c38d1b5082e016f7d2767554210dc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662838Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#670261}
-
John Lee authored
Bug: 973674 Change-Id: I2d9971b41bd2f399914a6ab57c995cb5f1ca383b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662730 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#670260}
-
Matt Simmons authored
R=yusufo@chromium.org Bug: 976213 Change-Id: Ia31e1a8c93c77e657bc7f0ca1b22d5bebe364e5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663383 Commit-Queue: Matt Simmons <mattsimmons@chromium.org> Reviewed-by:
-
Yuwei Huang authored
The CRD Android app version code had been fallback to "1" in official build for some reason. This CL explicitly sets the version code to `chrome_version_code` to be consistent with what we had been using. Bug: 976461 Change-Id: Id801c01da274eb307dcc316d4e76dd18d391b686 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666129 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Auto-Submit: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
-
