- 17 Nov, 2020 40 commits
-
-
Boris Sazonov authored
Adds ToMojoAccountKey/FromMojoAccountKey helpers to components/account_manager_core/account_manager_util.h. These methods will be used by subsequent CLs to implement observers in AccountManagerFacade. Bug: 1117472 Change-Id: I625afacc31dc2d3bd4ceb56dde70a99ed1d15e55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542903Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#828181}
-
Omar Morsi authored
This CL inlines the definitions of the constructors of the NSS operation states to make it more readable and shorter. Bug: 1131873 Change-Id: I0ff8b270fe4f1e2b653d3066e9b5dd7ebccad4b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541724Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#828180}
-
Roman Sorokin authored
This CL eliminates NOTIFICATION_KIOSK_AUTOLAUNCH_WARNING_VISIBLE and NOTIFICATION_KIOSK_AUTOLAUNCH_WARNING_COMPLETED notifications. These were used for the tests only. Replaced it with javascript waiter. Bug: none Change-Id: Iea1f187d43fc708c2c23e02e4ebfe37d8a38b329 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544138Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#828179}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4f96bf19941b..2f5d646c928e 2020-11-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 089f5a3e to d8a32653 (384 revisions) 2020-11-17 syoussefi@chromium.org Vulkan: Make ImageViewHelper a Resource 2020-11-17 amy.liu@arm.com Fix flip info of colorBlit with pre-rotation. 2020-11-17 cclao@google.com Vulkan: Remove rotation related data from driver uniform If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: I91adb3a4dce11175fcef45540021847ea112844c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542856 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828178}
-
Guido Trotter authored
Since we have an observer for the "hidden" attribute, that is going to be called anyway, inline the show() function into it, instead of having it called explicitly. One place in oobe_welcome.js already calls show() only if it exists. Change the other call to follow the same pattern, and remove the show() function altogether from that module. Signed-off-by:
Guido Trotter <ultrotter@chromium.org> Change-Id: I96ff9feb8d339ddf3aca2cf672e69eff78a15c75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537688Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#828177}
-
Yu-Hsuan Hsu authored
Check whether there is a keyboard mic. If yes, adding keyboard mic effect on lacros-chrome. BUG=b:173113548 Change-Id: I5241c11031cd5f681380f091dac23fbc82b3d75f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536661 Commit-Queue: Yu-Hsuan Hsu <yuhsuan@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#828176}
-
Tal Pressman authored
This CL introduces separate legacy IPC channels per AgentSchedulingGroup in "MBI mode". This channel is then used to associate channel-associated interfaces with, and to send legacy IPC messages. In addition it does the following: 1. Remove MaybeAssociatedRemote/Receiver, as the ASG's mojo interfaces are now always channel-associated. 2. ASG and ASGH implement IPC::Listener to handle legacy IPC message on the new channel. 3. Rename SetUpMojo/ResetMojo to SetUpIPC/ResetIPC. 4. `should_associate_` flag is replaced with an enum to make its meaning clearer. Bug: 1111231 Change-Id: I1d850aae48b4a900ab0aef24ac8a58b00cbcb218 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535954 Commit-Queue: Tal Pressman <talp@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#828175}
-
Jit Yao Yap authored
Change-Id: I995dae02a8823ce904f201501063e6a0526dab6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543922 Auto-Submit: Jit Yao Yap <jityao@google.com> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#828174}
-
Fredrik Söderqvist authored
ElementStyleResources holds a reference to the Element of the StyleResolverState that also owns the former object, so don't go across the stream for water and use |ElementStyleResources::element_| to get a reference to a proper TreeScope in GetSVGResourceFromValue(). Also make said field a reference to clearly indicate that it will be non-null. Drop StyleResolverState::GetTreeScope() since it now only has a single user. Change-Id: Ic2c994b546069001e6dd716a0d175825ceaeb96d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544183Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#828173}
-
Jan Scheffler authored
CL: https://crrev.com/c/2505657 Bug: chromium:1144127 Change-Id: I438126be535524c073fb9bcba32309ff5c81ac3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539197Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Jan Scheffler <janscheffler@chromium.org> Cr-Commit-Position: refs/heads/master@{#828172}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1d0105053a41..c4b2f38f2396 2020-11-17 szuend@chromium.org TypeScript-ify DragHandler in UIUtils.js 2020-11-17 yiorsi@gmail.com Fix the problem that there is no color picker in front of the CSS custom property 2020-11-17 jacktfranklin@chromium.org [DataGrid]: allow data-grid-controller to take an initial sort 2020-11-17 alcastano@google.com Introduce CSPViolation as pause reason (Devtools) 2020-11-17 aerotwist@chromium.org TypeScriptify create-shadow-root-with-core-styles 2020-11-17 aerotwist@chromium.org TypeScriptify register-custom-element.js 2020-11-17 aerotwist@chromium.org TypeScriptify inject-core-styles.js 2020-11-17 bmeurer@chromium.org [wasm] Turn DebuggerLanguagePluginManager into a singleton. 2020-11-17 aerotwist@chromium.org TypeScriptify append-style.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1125968,chromium:1142804,chromium:1148763 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If554bdc5eb16a7f5041254c70e4b2ba01efa1a6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544243Reviewed-by:
-
Michael Lippautz authored
Explicit template instantiations are in place to allow moving slow paths into the .cc file. Bug: 11297512 Change-Id: Id7f4c9912098ff550fae62fbe024a4cafe5fc56f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542787 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#828170}
-
Guido Trotter authored
The dropdown accessible message currently says "Open remove dialog for..." but this is not the case when the account can't be removed (e.g. on the lock screen). This commit calls it an "info dialog" in such case. Signed-off-by:
Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#828169}
-
rajendrant authored
This CL adds a fetcher that fetches robots rules from LitePages. TBR=dullweber@chromium.org Bug: 1147565 Change-Id: If7a00bf83d387d035f890e6aacd1da430672f80c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536755 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#828168}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bde2c3c32a2b..2e8c7015c00a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC melandory@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: melandory@google.com Change-Id: I824b637a81d6502103f580c3ee5a0ae476fcf08a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542811Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828167}
-
Illia Klimov authored
This reverts commit dfd6e35e. Reason for revert: As part of the Flash deprecation, this logic is no longer needed. Original change's description: > Display discarded extension patterns in settings > > Currently we throw away invalid wildcard patterns set using extension apis for Flash. > After this CL instead of throwing them away, we display them in the site settings page. > > Bug: 1102380, 1073883 > Change-Id: Ic9b1d40157cecca3db9673ee92cf208423c71bc2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282742 > Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> > Reviewed-by: Balazs Engedy <engedy@chromium.org> > Commit-Queue: Ravjit Singh Uppal <ravjit@chromium.org> > Cr-Commit-Position: refs/heads/master@{#785383} TBR=finnur@chromium.org,engedy@chromium.org,ravjit@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1149353 Change-Id: I4761ee6323388ad233817b3fb828028e8aefeb4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537643Reviewed-by:
Illia Klimov <elklm@google.com> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Illia Klimov <elklm@google.com> Cr-Commit-Position: refs/heads/master@{#828166}
-
Saurabh Nijhara authored
The browser tests related to audio sandbox are moved to a separated file. Bug: 1149697 Change-Id: Ie3a8b3b6c3f98e286da78426bd17191c64ec862a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543382Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Saurabh Nijhara <snijhara@google.com> Cr-Commit-Position: refs/heads/master@{#828165}
-
Sylvain Defresne authored
BookmarkHomeViewController uses lots of blocks that may causes reference cycles. Convert the code to consistently use weakSelf/strongSelf pattern to avoid cycles. Bug: 1113618 Change-Id: I5cf79c87588944d2fe25f8238dddc25306308c88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541082 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#828164}
-
Fabian Sommer authored
The original CL had some relative FilePaths that started with a '/'. This caused browser tests to fail when run in debug mode. This is now fixed by deleting the leading '/' characters. Original change's description: > Add mock policy option to extension install mixin > > Add an option to initialize ExtensionForceInstallMixin with a > MockConfigurationPolicyProvider. > Use this option in ForceInstalledAffiliatedExtensionApiTest. > Add mixin support to ForceInstalledAffiliatedExtensionApiTest. > > Bug: 1090941 > Change-Id: Ieea931c108e091679be607045f405b55f4186a57 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416453 > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Reviewed-by: David Bertoni <dbertoni@chromium.org> > Reviewed-by: Omar Morsi <omorsi@google.com> > Commit-Queue: Fabian Sommer <fabiansommer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#808281} Bug: 1090941 Change-Id: I4803c1de248b40e22a0194aa9e98182cb5ae1ed8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540586Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Fabian Sommer <fabiansommer@chromium.org> Cr-Commit-Position: refs/heads/master@{#828163}
-
Patrick Monette authored
This temporary class wraps a VotingChannel and provides a simpler API for submitting votes. Notably, the wrapper takes care of managing the VoteReceipts. This new API will greatly simplify the implementation of voters that observes a type of node for one property. The usual pattern will look like this: void On*NodeAdded(const Node* node) { auto initial_vote = GetVote(node->property()); voting_channel_wrapper_.SubmitVote(node, initial_vote); } void On*PropertyChanged(const Node* node) { auto new_vote = GetVote(node->property()); voting_channel_wrapper_.ChangeVote(node, new_vote); } void OnBefore*NodeRemoved(const Node* node) { voting_channel_wrapper_.InvalidateVote(node); } The goal in the future is to fold this functionality into the VotingChannel class and remove the wrapper. This will be done after each users of VotingChannel are migrated one at a time. Bug: 971272 Change-Id: I8d5cc58bb13ab4872b49e15bed6868f9a42f5136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533333 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#828162}
-
arthursonzogni authored
Reland information: --- Patchset 1 contains the original (reverted) patch. It has been reverted, because it landed together with: https://chromium-review.googlesource.com/c/chromium/src/+/2533280 [Initial code review]: https://chromium-review.googlesource.com/c/chromium/src/+/2529096 [Revert]: https://chromium-review.googlesource.com/c/chromium/src/+/2542857 --- Turn the IPC struct: FrameHostMsg_DidCommitProvisionalLoad_Params Into a mojo struct mojom::DidCommitProvisionalLoadParams This is mostly straigforward, except: 1. The functions have been updated to correctly specify whether ownership over this struct is passed or not. Use one of "const T&" / "T*", "TPtr*". 2. Mojo checks the required params are populated. This forced me to update several unittests to construct the required params. Like the referrer or the navigation_token. 3. blink::mojom::Referrer is used instead of the old content::Referrer This required adding (temporarily) the conversion between both when needed. TBR=nasko@chromium.org Fixed: 1145888 Bug: 1145888 Change-Id: I5e4a271b362db295947dea51e926114684328e16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543347Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#828161}
-
Alfonso Castaño authored
This CL moves the logic for generation the description of Node objects to Blink. Previous CLs: https://chromium-review.googlesource.com/c/v8/v8/+/2502342, https://chromium-review.googlesource.com/c/chromium/src/+/2502589 Fixed: chromium:1127115 Bug: chromium:1048143,chromium:1127115 Change-Id: Ie250cfff9eb45f5b755d7d13871d3039a8ac909b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504259 Commit-Queue: Alfonso Castaño <alcastano@google.com> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#828160}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1605560272-3c812cc827eaf1991f3c05cfa46c3374e2d6a16e.profdata to chrome-win32-master-1605571148-cd63329ec540ae538404ceac5db1a609fe603f55.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I3fbee6521ad87945c17fadea3372b00e313ab492 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544001Reviewed-by:
-
Findit authored
This reverts commit f9ad6770. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 828093 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2Y5YWQ2NzcwZjBkN2Y5MGEwMjk5NGM3MDNhMTM4YTdmZmQ5NzU3OWMM Sample Failed Build: https://ci.chromium.org/b/8863393452055084800 Sample Failed Step: browser_tests Original change's description: > Fix ExtensionPolicyTest.ExtensionRecommendedInstallationMode browsertest > > We check the list of enabled and disabled extensions in > ExtensionPolicyTest.ExtensionRecommendedInstallationMode browsertest. > In Windows, the extension is disabled by default as the user is > prompted before enabling the extension. On other platforms, the > extension is enabled by default. This CL overrides the prompting > flag to false. > > Bug: 1006342 > Change-Id: I1d783a8fc381b50e84e5ba85b5c9f37e58b7a986 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537641 > Reviewed-by: Sergey Poromov <poromov@chromium.org> > Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> > Cr-Commit-Position: refs/heads/master@{#828093} Change-Id: I6c682bb5141a3bd86517f11af90fa9761c052907 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1006342 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544071 Cr-Commit-Position: refs/heads/master@{#828158}
-
Stephen McGruer authored
This reverts commit a2352c33. Reason for revert: Broke the WPT importer (https://ci.chromium.org/p/infra/builders/cron/wpt-importer) due to failure to import requests: Traceback (most recent call last): File "/b/s/w/ir/x/w/src/third_party/blink/tools/wpt_import.py", line 10, in <module> from blinkpy.w3c.test_importer import TestImporter File "/b/s/w/ir/x/w/src/third_party/blink/tools/blinkpy/w3c/test_importer.py", line 27, in <module> from blinkpy.w3c.import_notifier import ImportNotifier File "/b/s/w/ir/x/w/src/third_party/blink/tools/blinkpy/w3c/import_notifier.py", line 21, in <module> from blinkpy.w3c.wpt_expectations_updater import WPTExpectationsUpdater File "/b/s/w/ir/x/w/src/third_party/blink/tools/blinkpy/w3c/wpt_expectations_updater.py", line 22, in <module> from blinkpy.web_tests.models.test_expectations import TestExpectations File "/b/s/w/ir/x/w/src/third_party/blink/tools/blinkpy/web_tests/models/test_expectations.py", line 38, in <module> from blinkpy.web_tests.models import typ_types File "/b/s/w/ir/x/w/src/third_party/blink/tools/blinkpy/web_tests/models/typ_types.py", line 9, in <module> from typ import json_results, expectations_parser, artifacts File "/b/s/w/ir/x/w/src/third_party/catapult/third_party/typ/typ/__init__.py", line 66, in <module> from typ.runner import Runner, TestInput, TestSet, WinMultiprocessing, main File "/b/s/w/ir/x/w/src/third_party/catapult/third_party/typ/typ/runner.py", line 43, in <module> from typ import result_sink File "/b/s/w/ir/x/w/src/third_party/catapult/third_party/typ/typ/result_sink.py", line 29, in <module> import requests ImportError: No module named requests Original change's description: > Roll Catapult from f92a7636da65 to 808ef50106ef (3 revisions) > > https://chromium.googlesource.com/catapult.git/+log/f92a7636da65..808ef50106ef > > 2020-11-17 hypan@google.com Add "third_party/gsutil" to cipd.yaml for devil > 2020-11-16 bsheedy@chromium.org [typ] Use requests for ResultSink > 2020-11-13 hypan@google.com Add CIPD create instruction cipd.yaml that packages devil > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/catapult-autoroll > Please CC rmhasan@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Bug: chromium:1108014,chromium:1147992 > Tbr: rmhasan@google.com > Change-Id: I3f3bbd92222e9e80c84939f0bdbfab39d4379318 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542748 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#828099} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,rmhasan@google.com Change-Id: I829d45a6cb43610c4c1da9f126f2ef420a4a0ce7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1108014 Bug: chromium:1147992 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543832Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#828157}
-
Jan Krcal authored
This CL adds a metric that records uniqueness of profile colors for each Chrome installation. This is a proxy for "each profile has different looks" as it ignores extension themes. This is a reasonable simplification as the new profile UIs do not promote extension themes. Bug: 1149315 Change-Id: I265957cc217915e703e0cc05aa3c9ada0e6b51dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534853Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#828156}
-
Jose Dapena Paz authored
Fix build error with libstdc++: In file included from ../../ui/gfx/x/xlib_support.cc:5: ../../ui/gfx/x/xlib_support.h:41:8: error: ‘unique_ptr’ in namespace ‘std’ does not name a template type 41 | std::unique_ptr<XlibLoader> xlib_loader_; | ^~~~~~~~~~ Bug: 957519 Change-Id: Ibd752625f76d24749d8958c5e4d9082ecf24630a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534874Reviewed-by:Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#828155}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1605560272-77c0d8d0117a28bac6ffdb0ad2fa6b677cbad6f9.profdata to chrome-win64-master-1605581968-699188875fbc74b98026cce85d5b16d698948c9f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I38e72fe2ecbe3bd7c93cf996c644078af18dbed3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543829 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
sandromaggi authored
This change adds the protos required for the mini actions. These mini actions will be added to |action_info| of the |ActionProto| in a later patch. Bug: b/172542134 Change-Id: I5f7d5112e5e2e0be0d776b9e431fa1bf04c6983d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519455Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#828153}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/67c1571570a0..1d0105053a41 2020-11-17 alexrudenko@chromium.org Use APCA for text contrast in Color Picker 2020-11-17 szuend@chromium.org [issues] Throw an error for unused replacements 2020-11-17 kimanh@chromium.org [e2e] Disable flaky wasm performance test 2020-11-17 the.derekli@gmail.com Improve _searchHighlighting performance 2020-11-17 szuend@chromium.org [ts] Replace DOMExtensions with platform features in UIUtils.js 2020-11-17 szuend@chromium.org TypeScript-ify ui/ViewManager.js 2020-11-17 petermarshall@chromium.org [typescript] TypeScript-ify profiler/ChildrenProvider.js 2020-11-17 szuend@chromium.org TypeScript-ify ui/Toolbar.js 2020-11-17 szuend@chromium.org [ts] Fix event types in ui/UIUtils.js 2020-11-17 kimanh@chromium.org Show linear memory inspector as drawer 2020-11-17 szuend@chromium.org [cleanup] Replace symbols with WeakMaps in ui/ViewManager.js 2020-11-17 aerotwist@chromium.org TypeScriptify measured-scrollbar-width.js 2020-11-17 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1110202,chromium:1121900,chromium:1125465,chromium:1149827 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0920410053d5eb7c60fa41291bf02c11c22edad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544105Reviewed-by:
-
Omar Morsi authored
This CL removes the unused dependency of KeyPermissionsService on the underlying profile policies. Bug: 1137344 Change-Id: I700356ce7b39cc58e1c4aec08ce14abafec166cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541862 Commit-Queue: Omar Morsi <omorsi@google.com> Reviewed-by:
-
Victor Hugo Vianna Silva authored
This comment should have been updated here https://chromium-review.googlesource.com/c/chromium/src/+/2476637/9/chrome/browser/ui/webui/settings/people_handler.cc#b558 TBR=rushans@google.com Bug: None Change-Id: I8d83c0ba64a0af9ad61bb4795d1ac8efc349b84c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541783 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Rushan Suleymanov <rushans@google.com> Reviewed-by:
Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#828150}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d4e6fb6573e0..9abde8c3f3a2 2020-11-17 sigurds@chromium.org Reland "Add option to git cl st to sort by committer date" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ib8ccae3e750621a3e00d8ff02315046c43fce667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544082Reviewed-by:
-
Polina Bondarenko authored
Stop ARC once all required by ArcPolicy apps are installed and take a snapshot. When MGS is successfully started in blocked UI mode, wait for all required by policy apps are installed, stop ARC instance and requirest to take a snapshot from arc-data-snapshotd daemon. BUG=b:161221001 TEST=components_unittests TEST=unit_tests Change-Id: I176f7aefea11847e80f0a9a3ae4ce0ac44d0edb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461382Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Polina Bondarenko <pbond@chromium.org> Auto-Submit: Polina Bondarenko <pbond@chromium.org> Cr-Commit-Position: refs/heads/master@{#828148}
-
Wei Lee authored
Extend it to milestone 92. Bug: 980846 Test: None Change-Id: I379a9bcafbc8b4e4c1e09287ea577a96d0beb10d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543539 Auto-Submit: Wei Lee <wtlee@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#828147}
-
Fergal Daly authored
Move validation logic into ValidateSpeculativeFrameHostForBug1146573. Also fixes the problem of dumping too often by not dumping when replacing a crashed RFH. Bug: 1146573 Change-Id: Ifcae2662ca7fa071440a5e1d069936683f763269 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538863 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
-
Daniel Cheng authored
These metrics used the legacy Blink helpers to record enumeration histograms; rather than migrating them to the preferred helpers in //base/metrics, just remove them. Bug: 1047547 Fixed: 975724, 975724, 1037132 Change-Id: I8f428f02d06b53aeaa31c5623ea776d630fa8732 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524930Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#828145}
-
Stepan Khapugin authored
I am removing myself from watchlist, and as I am the only one to use it, I'm removing the rule too. Bug: none Change-Id: I3b83556d0d03de88113142ccd4166d2522d88f98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540627 Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#828144}
-
Nazerke authored
This CL adds the add-new-tab-button, which is not tappable and which is not moving the position according to the number of tabs. Bug: 1134132,1128249 Change-Id: Ia72835684f8d65879c863041a503835dad2a67d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536469 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#828143}
-
Michael Lippautz authored
Quarantined objects do not need to be scanned at all. For larger objects with size >= kLargeScanAreaThreshold, it's beneficial to check the quarantine bit before performing a scan. Locally reduces Speedometer2 regression from ~6% to around ~2.5% with the current partition configuration (renderer + browser). Bug: 11297512 Change-Id: I97627898733f6cdb1fa7b0dc18a39b1b4566f48e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540594 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#828142}
-
