GitLab

Since upcoming changeType() work will refactor some of the current code
that creates and passes callbacks to StreamParser::Init(), this CL
modernizes related base::Bind and base::Callback usage to either
base::Bind{Once,Repeating} and base::{Once,Repeating}Callback.

Note that the encrypted media init data callback is the same underlying
type in StreamParser as in Demuxer, so this CL also modernizes the
binding for the Demuxer version of that type.

base::Bind count in //media: before=1425, after=1384

BUG=714018,751838,605134

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ie8c3ef44a836c5bfa3f34ff300da760dd7f552c1
Reviewed-on: https://chromium-review.googlesource.com/1099935Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567507}

The network:: namespace qualifiers might be an artifact because some of the files
were previously in content::.

Trivial cleanup so we have consistency between new and old files.

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ia8575841f9fb4e193e4e5e7a4620684be08db79c
Reviewed-on: https://chromium-review.googlesource.com/1101575
Commit-Queue: Helen Li <xunjieli@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567506}

This is a reland of 4a2a5c4a
with an additional check for use_xcode_clang.

Original change's description:
> build: Pass -fcomplete-member-pointers when building with clang.
>
> This prevents member pointers of incomplete base type from being used in
> cases where they might cause problems under the Microsoft ABI.
>
> Specifically, the Microsoft ABI has different kinds of member pointers with
> different sizes, and the choice of member pointer representation depends on
> the inheritance hierarchy of the member pointer's base type. C++ allows a
> member pointer's base type to be incomplete, so if it is incomplete at the
> point where a variable of that member pointer type is declared, that forces
> the compiler to pick the most general (i.e. largest) one. That can lead to
> ODR violations since the most general representation wouldn't necessarily
> be the one that would be chosen if the base type happened to be complete at
> the point where the variable was declared. It can also be less size efficient
> because the compiler will generally be able to choose a smaller representation
> than the most general one if it were complete at the point where it is needed.
>
> This flag also enables additional semantic analysis that we'll need in order
> to correctly implement -fsanitize=cfi for member function pointer calls. This
> is because the inheritance hierarchy of the base type must be available in
> order to make the CFI checks as precise as possible.
>
> Note that the flag is a -f flag rather than a -W flag. This is because
> requiring member pointer base types to be complete is technically a
> non-conforming language extension, as it may, for example, cause templates
> to be instantiated which would otherwise not be, which may be observable
> after code generation in conforming programs that were crafted to observe
> it. However, the effects of this language extension should not be observable
> in most ordinary programs.
>
> Bug: 847724
> Change-Id: I8d823fd4a6f21dfcadba55eefc0a69ef2e0c3479
> Reviewed-on: https://chromium-review.googlesource.com/1098217
> Commit-Queue: Peter Collingbourne <pcc@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#567086}

Bug: 847724
Change-Id: I1b97980691914492945d170931d33438c68e8d0b
Reviewed-on: https://chromium-review.googlesource.com/1101477Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567505}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/425d9ce2d32c..c91211414086


git log 425d9ce2d32c..c91211414086 --date=short --no-merges --format='%ad %ae %s'
2018-06-14 ehmaldonado@chromium.org gclient_scm: Use cherry-picking instead of rebasing.
2018-06-14 ehmaldonado@chromium.org gclient: Don't allow None URLs (except in .gclient files)


Created with:
  gclient setdep -r src/third_party/depot_tools@c91211414086

The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:850812,chromium:839925
TBR=agable@chromium.org

Change-Id: I8a9d2c829bf6a650fd793567fa3e122972016a09
Reviewed-on: https://chromium-review.googlesource.com/1101718Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#567504}

ByteConsumer::BeginRead() may return Result::kOK with no available
read data. FetchDataLoaderAsDataPipe should handle zero read as other
ByteConsumer::Client do.

Bug: 807954
Change-Id: I47186ccc01d10c8ff18bdf749376598ee75342a7
Reviewed-on: https://chromium-review.googlesource.com/1096515Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567503}

R=cmp@chromium.org

Change-Id: I0d2b39043d0d3a2ef7478178bc7106dc00337171
Reviewed-on: https://chromium-review.googlesource.com/1101656
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Chase Phillips <cmp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567502}

https://pdfium.googlesource.com/pdfium.git/+log/e16ffd4fc3f2..ee3e3a4f3cba


git log e16ffd4fc3f2..ee3e3a4f3cba --date=short --no-merges --format='%ad %ae %s'
2018-06-14 npm@chromium.org Merge 3 methods of CJBig2_GRDProc together
2018-06-14 dsinclair@chromium.org [formcalc] Calculate length of string when calling FXSYS_wcstof
2018-06-14 pcc@google.com Move definition of XFA_SCRIPTATTRIBUTEINFO into cjx_object.h.
2018-06-14 hnakashima@chromium.org Rewrite content stream regeneration.


Created with:
  gclient setdep -r src/third_party/pdfium@ee3e3a4f3cba

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:846104,chromium:847724
TBR=dsinclair@chromium.org

Change-Id: Ib391fca7b13757f3b2dc733c4d20fd67d42d1d96
Reviewed-on: https://chromium-review.googlesource.com/1101720Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#567501}

SurfaceHittest finds a target Surface for a point and signals whether
there should be additional hit testing done in the renderer.

Currently this only happens if there is a Surface quad and a
non-Surface DrawQuad under the point, in which case the browser
sets query_renderer in order to get a more confident target.

However, in cases where the Surface is occluded by a RenderPass that
has no DrawQuads in that location, it doesn't set query_renderer
because there does not appear to be a reason to do so. Instead, it
incorrectly thinks the RenderPass is the correct target. This is
problematic because layer squashing can create layers that are much
larger than the elements within them.

This CL changes this behavior so that it always queries when there is a
Surface at the given point.

This will increase the number of asynchronous hit tests that are
performed in general.

Bug: 851802
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I4e878101533e2794fc44cd16f36ea5cd104e59e2
Reviewed-on: https://chromium-review.googlesource.com/1101579Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567500}

R=piman@chromium.org

Bug: 844207
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I5b324498db07afdb342d555982781f922a3e3b94
Reviewed-on: https://chromium-review.googlesource.com/1101458Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567499}

Disable due to failings on linux-perf, Mojo Linux Perf, and
mac-10_13_laptop_high_end-perf.

See bug for sample builds.

Bug: 852980
Change-Id: Ifa31ba1b34d561afc12c545a8e01e1581b4b2e68
Reviewed-on: https://chromium-review.googlesource.com/1101836Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Chong Zhang <chongz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567498}

This is the start of a larger refactoring to the way file uploads are
handled when the network service is enabled. Currently a file path is
given to the network service, which then opens the file and uploads
its content. It doesn't currently check if the requester has access
to the file, and won't even be able to open files once it's sandboxed,
so the plan is to make the network service ask the browser process to
open the file for it. The renderer or browser process (whichever
wants to do the upload) will pass a file path to the network service,
which will then call a new method on NetworkServiceClient. This method
will take the file paths that it wants to upload, validate that the
originator of the request has permission to open those files (via
ChildProcessSecurityPolicy), open the files, and return the handles
back to the network service to upload them.

This CL defines just the new method, OnFileUploadRequested. Future CLs
will add its implementation.

Bug: 845612
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I9f7d0622db198a33e8f6dcdf9b8f4373d9156e2a
Reviewed-on: https://chromium-review.googlesource.com/1095653
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567497}

The main executable now invokes the SeatbeltExecServer when the feature
is enabled.

This also sets up the OuterBundle and BaseBundleID overrides, which are
required to properly find the rohitfork port.

Bug: 850735, 749839
Change-Id: Ic02df574a209213d1ca560ab2d1e947be5ae5136
Reviewed-on: https://chromium-review.googlesource.com/1099643Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567496}

https://chromium.googlesource.com/catapult.git/+log/42e9609fc92e..b520f6298c3e


git log 42e9609fc92e..b520f6298c3e --date=short --no-merges --format='%ad %ae %s'
2018-06-14 csharrison@chromium.org Add support for profile_files_to_copy in PossibleAndroidBrowser
2018-06-14 sullivan@chromium.org Added apps scripts to mail perf sheriffing info to experimental/
2018-06-14 benjhayden@chromium.org Support multiple story tags in ChartJsonConverter.


Created with:
  gclient setdep -r src/third_party/catapult@b520f6298c3e

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:823982
TBR=sullivan@chromium.org

Change-Id: I57109c7cae486eef0e69974e9cdb99dedb801c78
Reviewed-on: https://chromium-review.googlesource.com/1101719Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#567495}

Destroying a transfer buffer now requires only an ordering barrier, not
a full flush. This removes a source of unnecessary flushes and makes
resizing the transfer buffer more efficient.

Bug: 850271, 835353, 828363
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I9bfe43c46c00f8e9fc29e6450da788f86e74bc52
Reviewed-on: https://chromium-review.googlesource.com/1093580Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567494}

Tiles with missing/small favicons will display fallback icons instead, which consists of a colored circle and the first letter of the tile title. The fallback color will either be gray for missing favicons or the dominant color of the small favicon.

This change depends on https://crrev.com/c/1096670.

Screenshot: https://screenshot.googleplex.com/dbu8dxk97sX.png

Bug: 837798
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ie6ddf538396bcf8fbfd11cb9e9f0bad075301edd
Reviewed-on: https://chromium-review.googlesource.com/1096680
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567493}

Reloading an URL usually does not change its SiteInstance, however there
are a couple of exceptions - hosted apps and recently isolation of error
pages. In both of these cases, a commit for a specific URL can happen
in SiteInstance A and a subsequent reload results in a change to
SiteInstance B. With error page isolation, this can happen easily due
to timeout or some other transient network error on the initial navigation
to the URL, which ends up in an error page process. A later successful
reload then results in a different SiteInstance for the same URL.

Session history navigations are similar in behavior. When navigating
back/forward, the navigation can be redirected cross-site, resulting
in a SiteInstance change.

This CL changes ClassifyNavigation to account for these and classifies
them as NEW_PAGE with replacement. It ensures that when an entry's
SiteInstance changes, which means the security context has changed,
we don't reuse and update the existing entry, but rather we replace it
with a newly constructed one.

The CL adds a specific test for session history navigations that are
redirected and adds session history length checks to the existing test
of reloading a hosted app, which changes SiteInstances.

Bug: 840485, 848446
Change-Id: Iabacc60ce5726d5d919877b6e65e5d2f51dff3e2
Reviewed-on: https://chromium-review.googlesource.com/1086876
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567492}

linux_mojo has been switched to luci. The old bot gives me 404 and errors
when I include it in my CL commit msgs.

TBR=jam@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Iecb2b9502a2f85ef5cb62bd8c0ee74d8abefe98b
Reviewed-on: https://chromium-review.googlesource.com/1101848Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567491}

This CL adjusts the placement of the icon and text to align icons whether
MD Refresh is enabled or disabled. AiS refers to Answers in Suggest which
is what the bug was reported on.

Bug: 852450
Change-Id: I48633f3e799d50b0f0bd73a1b8ce713115142c8e
Reviewed-on: https://chromium-review.googlesource.com/1101971Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567490}

This is necessary to reland [1].  Libuuid is now a dependency of fontconfig,
which is statically linked on Linux builds.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1095538

BUG=787020
R=dpranke

Change-Id: I42a747359a4dd39e1a8ebad26e1db67467d73620
Reviewed-on: https://chromium-review.googlesource.com/1102009Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567489}

Per UX Request:
For all MenuShowSource types, show a highlight when a menu is shown.

This was already working for touch menus.

This also fixes the bug where the ink drop bubble was "Bursting"
regardless of the prior ink drop state.

Bug: 844779
Change-Id: I715300a7447ad099b6a610b34e8a30a2170d6e4c
Reviewed-on: https://chromium-review.googlesource.com/1095637Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567488}

We neither copy LazyBackgroundTaskQueue instances, nor we need to.
Delete its copy operators.

Bug: None
Change-Id: I759fe181e9c1d561769922b299043463fe7e5cd0
Reviewed-on: https://chromium-review.googlesource.com/1036613
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567487}

Minor cleanup of stale TODOs and other cruft in
ContextualSearchManager.java.

BUG=635567, 607127

Change-Id: If71b43ef07f0e2aaaa581b9481765b6ae551d315
Reviewed-on: https://chromium-review.googlesource.com/1100976Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567486}

This reverts commit ef1fe502.

Reason for revert: It's not clear that the underlying bug was fixed
and this change may have made ICU initialization failures happen
silently, leading to later misbehavior.

To be clear, this adds back code to help debug bug 445616.

I'm also taking ownership of the TODO items.

Original change's description:
> Remove code that was added to debug bug 445616
>
> Looks like the bug was fixed, so we don't need this.
>
> Bug: 445616
> Change-Id: Id33ecc6249b1e68337650c733d0877e3326732bf
> Reviewed-on: https://chromium-review.googlesource.com/885021
> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Jungshik Shin <jshin@chromium.org>
> Reviewed-by: Scott Graham <scottmg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#532612}

TBR=dcheng@chromium.org,sergeyu@chromium.org,scottmg@chromium.org,jshin@chromium.org

Bug: 445616
Change-Id: I2f5dad591791dea8d1427fdceddbf873efbf5f22
Reviewed-on: https://chromium-review.googlesource.com/1099980Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567485}

This is necessary in order for it to work when the PageAlmostIdle
feature is enabled.

BUG=829933

Change-Id: Ic3158a984713ceef849788eaa758ecaa255eba5a
Reviewed-on: https://chromium-review.googlesource.com/1097421Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567484}

https://chromium.googlesource.com/angle/angle.git/+log/75359664993b..9491e5ebed98


git log 75359664993b..9491e5ebed98 --date=short --no-merges --format='%ad %ae %s'
2018-06-14 geofflang@chromium.org Generate framebuffer IDs used in DXGISwapChainWindowSurfaceWGL.


Created with:
  gclient setdep -r src/third_party/angle@9491e5ebed98

The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:852399
TBR=cwallez@chromium.org

Change-Id: I6616599386646d5d6fc021fdb20052993c4aef84
Reviewed-on: https://chromium-review.googlesource.com/1101717Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#567483}

PromotionManager is no longer used, and there are no future plans to
use it. This CL also removes the flag that controlled the feature,
and its associated metadata.

R=khorimoto@chromium.org

TBR=jhawkins@chromium.org

Bug: 824568, 752273
Change-Id: I6ac7cfe8391ce050b1d1f9217ffc6ec95160746d
Reviewed-on: https://chromium-review.googlesource.com/1101703Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567482}

This function was already implemented in the .cc file, but it was not
declared in the .h file.

Bug: 824568, 752273
Change-Id: I5b8471bf5bd7bff54384696b38b10bb5523c82cf
Reviewed-on: https://chromium-review.googlesource.com/1101823
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567481}

Replaced DatabaseExists with new leveldb_chrome::PossiblyValidDB.

Bug: None
Change-Id: Iecb181588355c3f59953230ad0946f8e531c8a3f
Reviewed-on: https://chromium-review.googlesource.com/1090998Reviewed-by: Dmitry Titov <dimich@chromium.org>
Commit-Queue: Chris Mumford <cmumford@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567480}

Now we know why they didn't run there.

TBR=jbudorick

Bug: 852895
Change-Id: I907a26d4035e4f6f3942838cc48befe00cae5c9c
Reviewed-on: https://chromium-review.googlesource.com/1101838Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567479}

These histograms used to be recorded in google3, but are now used in
public codebase. Move them to chromium.

Bug: 852832
Change-Id: Ib5969f0b3476feb24db33362a787197f93c2151a
Reviewed-on: https://chromium-review.googlesource.com/1101314Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567478}

The spec[1] says that the boundingBox attribute should be
DOMRectReadOnly instead of DOMRect.

[1] https://wicg.github.io/shape-detection-api/#detectedface

Bug: 852838
Change-Id: I10714b27ea5cf62c27c3b4c550e3e62b9f1936d2
Reviewed-on: https://chromium-review.googlesource.com/1094674Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com>
Cr-Commit-Position: refs/heads/master@{#567477}

BUG=none
TEST=none

Change-Id: I9f8d95661e1916b86f6e57f673f2d3b17118231d
Reviewed-on: https://chromium-review.googlesource.com/1101303Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567476}

'break-word' is different from other line breaking options in
that it needs to redo the line break if the line overflows.
A very long line such as URL or data can be expensive, because
its 2nd and all following lines will also need this 2-pass line
breaking.

After CL:1095894, NextBreakOpportunity() consumes 21% and
ShapeToEnd() 28%. Mostly these are to create ShapeResult that
overflows in the first pass and thus will be discarded.

This patch suppresses creating such ShapeResult by adding a new
option to ShapingLineBreaker.

  Current engine:    469ms
  Before:         26,644ms
  CL:1095894:      2,250ms
  This patch:      1,060ms

Profile (debug) of perf_tests/layout/word-break-break-word.html
after this patch:
  ShapingLineBreaker::ShapeLine:         78%
    RunInfo::CharacterIndexForXPosition: 39%
    RunInfo::XPositionForOffset:         28%
    RunInfo::NextSafeToBreakOffset:       7%
Emil is working on these 3 RunInfo functions, and they consume
74% out of ShapeLine's 78%.

Bug: 636993
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I5bae7fe4e8256d4efaff91803690b33acd902706
Reviewed-on: https://chromium-review.googlesource.com/1100716
Commit-Queue: Koji Ishii <kojii@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567475}

This class disconnects cryptauth::SecureChannel objects, which have an
asynchronous disconnection flow. It is an error to delete
cryptauth::SecureChannel objects before they are fully disconnected, as
this can cause the underlying connection to remain open.

Bug: 824568, 752273
Change-Id: I42ebf3814f27f9f45c6d90173cb3cb8513bc800b
Reviewed-on: https://chromium-review.googlesource.com/1101515
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567474}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/de5f8a610a0a..54899e2b1191


git log de5f8a610a0a..54899e2b1191 --date=short --no-merges --format='%ad %ae %s'
2018-06-14 dgarrett@google.com chromeos_config: Make master-full internal.


Created with:
  gclient setdep -r src/third_party/chromite@54899e2b1191

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:851183
TBR=chrome-os-gardeners@chromium.org

Change-Id: I9b361d8a58e4d7ed2d365fed15745286938f444d
Reviewed-on: https://chromium-review.googlesource.com/1101659Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#567473}

This reverts commit e6db40d9.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 567445 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2U2ZGI0MGQ5MWQwYmQyYWZlYjM5Zjc4ZjZkMjI0MDRjMzUyNWI2M2MM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Builder%20%28dbg%29%2832%29/83483

Sample Failed Step: compile

Original change's description:
> Update fontconfig to 6cc99d6a
> 
> Changelog [1].  This is necessary to pick up [2] for fixing undefined-shift
> UBSAN errors detected by clusterfuzz, [3] to allow removing a build workaround,
> [4] to fix a bug and clean up some log spam, [5] to fix CFI builds, and [6] to
> fix a use-after-free.
> 
> Fontconfig also now requires libuuid as a dependency, so whitelist it as a
> dependency since we statically link fontconfig.
> 
> [1] https://chromium.googlesource.com/external/fontconfig/+log/b546940435ebfb0df575bc7a2350d1e913919c34..6cc99d6a82ad67d2f5eac887b28bca13c0dfddde
> [2] https://chromium.googlesource.com/external/fontconfig/+/c60ed9ef66e59584f8b54323018e9e6c69925c7e
> [3] https://chromium.googlesource.com/external/fontconfig/+/b8a225b3c3495942480377b7b3404710c70be914
> [4] https://chromium.googlesource.com/external/fontconfig/+/7ad010e80bdf8e41303e322882ece908f5e04c74
> [5] https://chromium.googlesource.com/external/fontconfig/+/096e8019be595c2224aaabf98da630ee917ee51c
> [6] https://chromium.googlesource.com/external/fontconfig/+/6cc99d6a82ad67d2f5eac887b28bca13c0dfddde
> 
> BUG=831146,822737,787020,829890,847323
> TBR=thestig,dnicoara
> 
> Change-Id: Ic2d1bd19af8ca131c960a30d09246827c115ccec
> Reviewed-on: https://chromium-review.googlesource.com/1095538
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#567445}

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
BUG=831146,822737,787020,829890,847323

Change-Id: I47d475941350efc76370fa5eb5043c80c5063495
Reviewed-on: https://chromium-review.googlesource.com/1101759
Cr-Commit-Position: refs/heads/master@{#567472}

Use it to implement StoragePartitionImpl::URLLoaderFactoryForBrowserProcess::Clone()

Bug: 850089
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I53798149efc69bd2566175bb248c462a2e5f4486
Reviewed-on: https://chromium-review.googlesource.com/1097214
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567471}

Document which are singletons vs. per-profile.

Collapse all the chromeos stuff into one block.

Bug: none
Change-Id: I869c1ad4b1dd889de017743571b41f3ce31affb3
Reviewed-on: https://chromium-review.googlesource.com/1101829Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567470}

Previously if you had an empty lambda, Android Studio would insert a
new line, and then git cl format would remove the newline, and the two
would fight forever. This makes them both agree that no newline is
better.

git cl format and new Android Studio format:
obj.foo(ignored -> {});

old Android Studio format:
obj.foo(ignored -> {
});

Bug: 852962
Change-Id: I785e3264454efbf0118d5fcc36c43ca88076a624
Reviewed-on: https://chromium-review.googlesource.com/1101715Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567469}

BUG=

Change-Id: I88dd7bada07824769b07d71b8669d7ba2ebe6e69
Reviewed-on: https://chromium-review.googlesource.com/1101702Reviewed-by: Pedro Amaral <amaralp@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567468}