GitLab

TouchCancel ack dispositions have no bearing on touch or gesture input
behavior.  As such, ignore the disposition, eliminating unnecessary blocking
of touch event dispatch.

BUG=302849,302852

Review URL: https://codereview.chromium.org/78263003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236849 0039d316-1c4b-4281-b951-d872f2087c98

BUG=322689
TEST=gpu waterfall
R=bajones@chromium.org
TBR=kbr@chromium.org

Review URL: https://codereview.chromium.org/83483009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236848 0039d316-1c4b-4281-b951-d872f2087c98

Feedback_private currently has a extension native handler for getting a Blob's UUID. Media Galleries API Metadata and other extensions that take a Blob will also want this.

This simply moves the function from a Feedback_private specific custom binding to a general ObjectBackedNativeHandler called BlobNativeHandler. This follows the CssNativeHandler example.

The parent class changed from ChromeV8Extension to ObjectBackedNativeHandler because ChromeV8Extension class has been deprecated.

R=thestig@chromium.org

BUG=318450

Review URL: https://codereview.chromium.org/76703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236847 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236846 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=162550:162559&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/82713006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236845 0039d316-1c4b-4281-b951-d872f2087c98

without subclassing.

BUG=none
TEST=none
R=sky@chromium.org

Review URL: https://codereview.chromium.org/81833007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236844 0039d316-1c4b-4281-b951-d872f2087c98

BUG=258671

Review URL: https://codereview.chromium.org/83123006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236843 0039d316-1c4b-4281-b951-d872f2087c98

When IndexedDBContext is destroyed it posts a task to the IDB thread to
run IndexedDBFactory::ContextDestroyed() to do some cleanup, but drops
its own reference, leading to a refcounting/threading race. Follow the
rules in base/callbacks.h to use RefCountedThreadSafe<> to fix.

R=alecflett,dgrogan
TBR=glider
BUG=321596

Review URL: https://codereview.chromium.org/77863005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236842 0039d316-1c4b-4281-b951-d872f2087c98

1. BookmarkBubbleView: added BookmarkBubbleView::GetAccessibleState() so we can say what this UI is all about
2. BookmarkBubbleView: added spoken feedback to [Name] text box
3. BookmarkBubbleView: changed spoken feedback for for [Folder] to "Bookmark folder"
4. fixed AccessibilityEventRouterViews::GetViewContext() to prevent drilling down into child elements of a dialog if the dialog defines AccessibleViewState::name already.
5. BookmarkEditorView: added BookmarkBubbleView::GetAccessibleState() so we can say what this UI is all about
6. BookmarkEditorView: changed spoken feedback for for [Name] and [URL] text edit fields


BUG=177321,127042
TEST=manual with spoken feedback turned on

Review URL: https://codereview.chromium.org/79273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236841 0039d316-1c4b-4281-b951-d872f2087c98

"ninja show" will print out the build arguments for when you can't remember the configuration of your output directory.

"ninja refresh" ignores dependencies and regenerates the ninja files.

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/82923005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236840 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/83513006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236838 0039d316-1c4b-4281-b951-d872f2087c98

This writes a generator for GYP actions to run Ninja for script targets. This does not yet include the code that actually writes the corresponding ninja files.

The GYP code also needed some output directory generation code, so this was consolidated in filesystem_utils and referenced from the existing place.

BUG=322244
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/80463004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236837 0039d316-1c4b-4281-b951-d872f2087c98

TBR=fgorski@chromium.org
BUG=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236836 0039d316-1c4b-4281-b951-d872f2087c98

TBR=fgorski@chromium.org
BUG=none



git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236835 0039d316-1c4b-4281-b951-d872f2087c98

A scroll sequence starts with a fling cancel, followed by a series of scroll
events and ends with a fling start event. In the oneshot sticky keys case, we
now modify the entire sequence with the modifier key before disabling sticky
keys.

BUG=308662
TEST=updated unit tests

Review URL: https://codereview.chromium.org/81863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236834 0039d316-1c4b-4281-b951-d872f2087c98

Fix memory leak in content_browsertests discovered by LeakSanitizer.

BUG=307043
TBR=pfeldman@chromium.org
TEST=content_browsertests:RendererOverridesHandlerTest.*

Review URL: https://codereview.chromium.org/83073008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236833 0039d316-1c4b-4281-b951-d872f2087c98

BUG=321701
R=piman@chromium.org

Review URL: https://codereview.chromium.org/84033003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236832 0039d316-1c4b-4281-b951-d872f2087c98

Ensure that the error bubble never goes outside the dialog, and that
one of the bubble edges is aligned with the corresponding edge of the
associated field. (Screenshots on bug)

BUG=305378
R=isherman@chromium.org

Review URL: https://codereview.chromium.org/82593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236831 0039d316-1c4b-4281-b951-d872f2087c98

BUG=321713

Review URL: https://codereview.chromium.org/79353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236830 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None
NOTRY=true

Review URL: https://codereview.chromium.org/83933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236829 0039d316-1c4b-4281-b951-d872f2087c98

Fixing M32 crasher where closing of a windowed V1 app on a visiting desktop will cause crashes later on

BUG=321374
TEST=unit test (and checked that the crash does not happen anymore by hand)

Review URL: https://codereview.chromium.org/83173007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236828 0039d316-1c4b-4281-b951-d872f2087c98

Alphabetical sorting, a whitespace fix and revert the logging change
from VLOG(1) to the old one LOG(INFO).

Original CL : https://codereview.chromium.org/75463005/ which was
part of the componentization effort of NaCl.

BUG=244791
R=mseaborn@chromium.org

Review URL: https://codereview.chromium.org/83553003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236827 0039d316-1c4b-4281-b951-d872f2087c98

BUG=316397

Review URL: https://codereview.chromium.org/83703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236826 0039d316-1c4b-4281-b951-d872f2087c98

* Avoid duplicate assignments.
* Don't calculate whether strong validators are present in an HTTP
  response. A spec compliant implementation of this determination is
  already present elsewhere.

BUG=7648

Review URL: https://codereview.chromium.org/66993008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236825 0039d316-1c4b-4281-b951-d872f2087c98

This reverts https://codereview.chromium.org/34603003 and disables the test correctly.

I have followed the example of https://codereview.chromium.org/42103005.

You can see that the buildbot was trying to run the test today:
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/9870/steps/chromiumtestshell_instrumentation_tests/logs/stdio

BUG=322562,309997

Review URL: https://codereview.chromium.org/83173006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236824 0039d316-1c4b-4281-b951-d872f2087c98

This file uses std::vector but does not include corresponding header file.

R=erg@chromium.org
BUG=82098

Review URL: https://codereview.chromium.org/83293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236823 0039d316-1c4b-4281-b951-d872f2087c98

The previous expansion using <(PRODUCT_DIR)/../.. did not work correctly
if one was using a different build directory layout (out-of-source
builds, or some build directory with a different number of
subdirectories).

Solve this by doing the same as the sysroot variables: stop using
relative paths from the build directory and extract absolute paths using
DEPTH.

TEST=./build/gyp_chromium -Goutput_dir=/somewhere/else
R=phajdan.jr@chromium.org,thakis@chromium.org,dpranke@chromium.org

Review URL: https://codereview.chromium.org/83673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236822 0039d316-1c4b-4281-b951-d872f2087c98

These files have no dependencies on chrome/ so they can be safely moved
to the components/ directory.

This is part of an effort to componentize NaCl code.

BUG=244791
R=brettw@chromium.org, cpu@chromium.org, jochen@chromium.org, mseaborn@chromium.org

Review URL: https://codereview.chromium.org/75463005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236821 0039d316-1c4b-4281-b951-d872f2087c98

BUG=317523

Review URL: https://codereview.chromium.org/83283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236820 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/76683003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236819 0039d316-1c4b-4281-b951-d872f2087c98

These tests cover the code path where a CDM is used in decrypt-only mode.

BUG=321420
TEST=none

Review URL: https://codereview.chromium.org/79903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236818 0039d316-1c4b-4281-b951-d872f2087c98

R=oshima@chromium.org
BUG=315944

Review URL: https://codereview.chromium.org/82573004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236817 0039d316-1c4b-4281-b951-d872f2087c98

Previously reviewed as https://codereview.chromium.org/27722003, but
moves WiFiService Windows implementation to components/wifi.

Based on infrastructure in https://codereview.chromium.org/54323003/

BUG=267667

Review URL: https://codereview.chromium.org/68503019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236816 0039d316-1c4b-4281-b951-d872f2087c98

Introduce a temporary workaround to ensure tracked preferences set to empty list/dict are not confused with those that are simply not set (i.e., NULL).

Review URL: https://codereview.chromium.org/79013003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236815 0039d316-1c4b-4281-b951-d872f2087c98

This also adds compatibility symlinks so that running browsers continue
to work (as a workaround for not everything going through the zygote).

Next steps: same change for RPM, remove remaining collisions outside of /opt.

BUG=38598
R=thestig@chromium.org

Review URL: https://codereview.chromium.org/81933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236814 0039d316-1c4b-4281-b951-d872f2087c98

PDF support is removed from skia without printing, but VectorPlatformDeviceSkia
inherits from SkPDFDevice. We need to remove VectorPlatformDeviceSkia as well.

This fixes the following undefined symbol errors.

lib/libskia.so: error: undefined reference to 'SkPDFDevice::~SkPDFDevice()'
lib/libskia.so: error: undefined reference to 'SkPDFDevice::SkPDFDevice(SkTSize<int> const&, SkTSize<int> const&, SkMatrix const&)'
lib/libskia.so: error: undefined reference to 'SkPDFDevice::getDeviceCapabilities()'
lib/libskia.so: error: undefined reference to 'SkPDFDevice::onAttachToCanvas(SkCanvas*)'
lib/libskia.so: error: undefined reference to 'SkPDFDevice::onDetachFromCanvas()'
lib/libskia.so: error: undefined reference to 'SkPDFDevice::clear(unsigned int)'
lib/libskia.so: error: undefined reference to 'SkPDFDevice::drawPaint(SkDraw const&, SkPaint const&)'
lib/libskia.so: error: undefined reference to 'SkPDFDevice::drawPoints(SkDraw const&, SkCanvas::PointMode, unsigned long, SkPoint const*, SkPaint
 const&)'
lib/libskia.so: error: undefined reference to 'SkPDFDevice::drawRect(SkDraw const&, SkRect const&, SkPaint const&)'
lib/libskia.so: error: undefined reference to 'SkPDFDevice::drawRRect(SkDraw const&, SkRRect const&, SkPaint const&)'
lib/libskia.so: error: undefined reference to 'SkPDFDevice::drawPath(SkDraw const&, SkPath const&, SkPaint const&, SkMatrix const*, bool)'
lib/libskia.so: error: undefined reference to 'SkPDFDevice::drawBitmap(SkDraw const&, SkBitmap const&, SkMatrix const&, SkPaint const&)'
lib/libskia.so: error: undefined reference to 'SkPDFDevice::drawSprite(SkDraw const&, SkBitmap const&, int, int, SkPaint const&)'
lib/libskia.so: error: undefined reference to 'SkPDFDevice::drawBitmapRect(SkDraw const&, SkBitmap const&, SkRect const*, SkRect const&, SkPaint
const&, SkCanvas::DrawBitmapRectFlags)'
lib/libskia.so: error: undefined reference to 'SkPDFDevice::drawText(SkDraw const&, void const*, unsigned long, float, float, SkPaint const&)'
lib/libskia.so: error: undefined reference to 'SkPDFDevice::drawPosText(SkDraw const&, void const*, unsigned long, float const*, float, int, SkPa
int const&)'
lib/libskia.so: error: undefined reference to 'SkPDFDevice::drawTextOnPath(SkDraw const&, void const*, unsigned long, SkPath const&, SkMatrix con
st*, SkPaint const&)'
lib/libskia.so: error: undefined reference to 'SkPDFDevice::drawVertices(SkDraw const&, SkCanvas::VertexMode, int, SkPoint const*, SkPoint const*
, unsigned int const*, SkXfermode*, unsigned short const*, int, SkPaint const&)'
lib/libskia.so: error: undefined reference to 'SkPDFDevice::drawDevice(SkDraw const&, SkBaseDevice*, int, int, SkPaint const&)'
lib/libskia.so: error: undefined reference to 'SkPDFDevice::onReadPixels(SkBitmap const&, int, int, SkCanvas::Config8888)'
lib/libskia.so: error: undefined reference to 'SkPDFDevice::allowImageFilter(SkImageFilter*)'
lib/libskia.so: error: undefined reference to 'SkPDFDevice::onCreateCompatibleDevice(SkBitmap::Config, int, int, bool, SkBaseDevice::Usage)'

TEST=build with GYP_DEFINES="embedded==1 component=shared_library"

Review URL: https://codereview.chromium.org/78713006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236813 0039d316-1c4b-4281-b951-d872f2087c98

Some accelerators don't make sense if no windows exist on the desktop.
ChromeVox users can end up in this state and not know it.
If a window-needing accelerator is issued and there is no window we
fire off an accessibiliy event to let the user know there is no
window.

This CL:
Extends Ash's AcceleratorController to intercept these accelerators.
Adds the concept of triggering an alert to AccessibilityDelegate.
Adds handling in Chrome's AccessibilityDelegate to generate an alert.

BUG=217571
TEST=All automated tests pass. Activate ChromeVox and hit ctrl-m with
no window open on Chrome OS. You should get an alert telling you to
open a window.

Review URL: https://codereview.chromium.org/77453013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236812 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236810 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=162542:162549&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/83783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236809 0039d316-1c4b-4281-b951-d872f2087c98

We weren't clearing the native pointers for these Java objects, but we
were asserting that the native pointers were 0 in the (evil) Java
finalizers. This resulted in an error in the logs (but no crash, thanks
to the beauty of finalizers).

NOTRY=true

Review URL: https://codereview.chromium.org/82483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236808 0039d316-1c4b-4281-b951-d872f2087c98