GitLab

This change will allow for the detection of tasks running in
TaskScheduler that fail to post their task in a COM STA Task Runner
instead.

BUG=706512

Change-Id: If8ea9df63cface0dc48aa11b5254ab3e6d87dc4f
Reviewed-on: https://chromium-review.googlesource.com/549223
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487269}

Bug: 741116
Change-Id: I58cbe1714808fa9a36a322ff26e65b93259e288d
Reviewed-on: https://chromium-review.googlesource.com/574874
Commit-Queue: Shivani Sharma <shivanisha@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487268}

Fixes the following minor issues:
* MSVC silently accepted runtime version of clamped negate in constexpr
  (a correctness issue that also generated marginally slower code).
* Checked negation did not use optimized builtins when available.

Change-Id: Ifd9a756d6620917a915ebdd583909824f2f86410
Reviewed-on: https://chromium-review.googlesource.com/573432
Commit-Queue: Justin Schuh <jschuh@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487267}

Currently, ExternalInstallError::RemoveError() calls
RemoveExternalInstallError() on ExternalInstallManager (its owner) which deletes
the ExternalInstallError instance. This also causes the deletion of the
extension id, which is passed as a reference. This is further accessed in
ExternalInstallManager::RemoveExternalInstallError leading to a UAF. This CL
fixes the issue by using a copy of the passed string reference in
RemoveExternalInstallError. A regression test is also added which fails on the
current master.

BUG=739142

Change-Id: I26c57a19a7d88e2a11eb17d3c45c371e95de700c
Reviewed-on: https://chromium-review.googlesource.com/572763Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487266}

BUG=710168

Review-Url: https://codereview.chromium.org/2968613002
Cr-Commit-Position: refs/heads/master@{#487265}

Modified MenuController::OnMouseDragged to turn off highlight of a
MenuItemView when the mouse exits on a drag. This fixes a small visual
bug where the highlight would turn off when the mouse was released and
subsequently moved.

Bug: 553438
Change-Id: Ib6448954870d8709af222d30f4c431036bdfb975
Reviewed-on: https://chromium-review.googlesource.com/550261
Commit-Queue: Jess Zeisloft <jzeisloft@google.com>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487264}

This CL introduces a new base::Feature to control whether the sign-in
origin (https://accounts.google.com) requires a dedicated process, to
be used for a Finch experiment.  As part of this, during
initialization content/ will call out to a new ContentBrowserClient
method to get a whitelist of origins requiring a dedicated process.
These origins will be process-isolated in all profiles for the
lifetime of the browser.

Bug: 713444, 739418
Change-Id: I308cd1eb209394a9990c5eb5793a95a78d76485a
Reviewed-on: https://chromium-review.googlesource.com/569519
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Nick Carter <nick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487263}

Revert of Remove confusing keyboard test & focus on input device (patchset #9 id:160001 of https://codereview.chromium.org/2964823002/ )

Reason for revert:
A follow up fix for a race condition on cold boot was reverted in https://chromium-review.googlesource.com/c/574731/. With only this patch the functionality is broken in the user facing scenario.

The code state without either this cl or the follow up is better than with only this cl.

Original issue's description:
> Remove confusing keyboard test & inspect input device
>
> In order to make the decision for when to trigger the OOBE display
> chooser less confusing for end users I'm removing the keyboard check.
> Instead an explicit remora requisition check is used to limit the
> effects.
>
> BUG=738885
>
> Review-Url: https://codereview.chromium.org/2964823002
> Cr-Commit-Position: refs/heads/master@{#485019}
> Committed: https://chromium.googlesource.com/chromium/src/+/c923b817665a649b4e18243116c31c68404af7dd

TBR=jdufault@chromium.org,oshima@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=738885

Review-Url: https://codereview.chromium.org/2977293002
Cr-Commit-Position: refs/heads/master@{#487262}

lock_screen_apps::StateController initialization is updated to include
LockScreenItemStorage initialization.

Adds lockScreenAppDataCryptoKey string pref to profile prefs - this pref
will store base64 encoded AES key that shoul dbe used by
LockScreenItemStorage to encrypt user data written to disk. The key is
set during StateController initialization is not already present in
prefs.

Also, add browser tests for lockScreen.data API

Bug: 715781
Change-Id: Ia7385d7938fb917053219480cb70895590772104
Reviewed-on: https://chromium-review.googlesource.com/568532
Commit-Queue: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Rahul Chaturvedi <rkc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487261}

Unfortunately, most of the check lines have appeared in the wild,
but very rarely.  It seems likely this is a memory stomp elsewhere
leading to invalid parameters here.  If this was more reproducible,
or there was some content that could trigger this more regularly
I think we'd see a lot more reports or the same client.

Removed the diagnostic checks (since they could become out of sync
with Skia) and left the original check with a comment.

This reverts https://chromium-review.googlesource.com/#/c/511182/

Bug: 721744
Change-Id: I4f6deae8535b70afb5a24dd42b9b2bfcbfc37394
Reviewed-on: https://chromium-review.googlesource.com/575021Reviewed-by: ccameron chromium <ccameron@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487260}

https://skia.googlesource.com/skia.git/+log/aa352de50c9d..c2bd631c431c

$ git log aa352de50..c2bd631c4 --date=short --no-merges --format='%ad %ae %s'
2017-07-17 fmalita Remove (now-dead) SK_LEGACY_SWEEP_GRADIENT code
2017-07-17 bsalomon Add support for GL 565 and 4444 configs to test tools
2017-07-17 brianosman Run clang-format on GrCircleBlurFP.cpp

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=caryclark@chromium.org

Change-Id: Ic387c7e5785ab23a4fb06e7b6539e4667941f5a9
Reviewed-on: https://chromium-review.googlesource.com/574930Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487259}

BUG=726108
R=gmx@chromium.org, sque@chromium.org

Change-Id: I7a87f4dedd0f722ae90ee71e9c60ce57f9a91a65
Reviewed-on: https://chromium-review.googlesource.com/563490
Commit-Queue: Chong Jiang <chongjiang@chromium.org>
Reviewed-by: Simon Que <sque@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487258}

- Adds a confirmed keyword != currently selected keyword which gets
updated after a user confirms a selection.
- Have the result depend on the above rather than the selected keyword
- Add a callback that will be called when the user dismisses dialog
with a false result.

BUG=744799

Change-Id: Ia3c2b1529204fb3f65a95b929e37a643dc482ab6
Reviewed-on: https://chromium-review.googlesource.com/574673
Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487257}

This makes floats actual children of the fragment which they belong to.

This fixes a few tests specifically for cases like:
<div id=cb><div id=float><div id=abs></div></div></div>

Here the float contains an OOF positioned element. This wasn't getting
passed up to its containing block as the float wasn't a regular
fragment.

Additionally it fixes:
<div id=has-border>text<div id=float></div>text</div>

In this case we wrapped the text and float in an anonymous fragment,
but we didn't adjust the floats position to the containing fragments
offset.

Bug: 635619
Change-Id: I806f9475a7424b83bd6a718147a9613894046de7
Reviewed-on: https://chromium-review.googlesource.com/570503Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487256}

Bug: 
Change-Id: Ib8444142e35334ae6668bb59f836d16822d4f4bd
Reviewed-on: https://chromium-review.googlesource.com/572050Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487255}

This roll CL is a copy of a previous one that failed to land due to the gerrit status of the issue itself, "Work in progress". All bots etc however, did pass.
See here: https://chromium-review.googlesource.com/c/571013/1..2

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/f21628f..beaccf9

$ git log f21628f..beaccf9 --date=short --no-merges --format=%ad %ae %s
2017-07-14 magjed@webrtc.org Revert "API for periodically regathering ICE candidates"
2017-07-14 magjed@webrtc.org Revert of iOS - Add iceRegatherIntervalRange. (patchset #1 id:1 of https://codereview.webrtc.org/2976953002/ )
2017-07-14 magjed@webrtc.org Revert "Add additional check when setting RTCConfiguration"
2017-07-14 philipel@webrtc.org Added -show_detector_state which show the detector state in the total bitrate graph.
2017-07-14 saza@webrtc.org Patch set 1: Run a script to replace occurrences of WEBRTC_TRACE logging with the new style, on webrtc/modules/audio_device/linux/audio_device_alsa_linux.cc.
2017-07-14 philipel@webrtc.org RtpFrameReferenceFinder VP8 reference calculation fix.
2017-07-14 tserng@amazon.com Reset isFirstFrameRendered on init of SurfaceViewRenderer
2017-07-13 tkchin@webrtc.org Remove OWNERS check for webrtc/sdk/BUILD.gn
2017-07-13 zijiehe@chromium.org Output DeviceName from various windows ScreenCapturer related implementations
2017-07-13 steveanton@webrtc.org Add additional check when setting RTCConfiguration
2017-07-13 brucedawson@chromium.org Fix DetectNumberOfCores for 32-bit processes
2017-07-13 andersc@webrtc.org Reland of Injectable Obj-C video codecs (patchset #1 id:1 of https://codereview.webrtc.org/2979973002/ )
2017-07-13 sprang@webrtc.org Revert of Injectable Obj-C video codecs (patchset #3 id:400001 of https://codereview.webrtc.org/2981583002/ )
2017-07-13 charujain@webrtc.org Revert of Make the default ctor of rtc::Thread, protected (patchset #3 id:40001 of https://codereview.webrtc.org/2981623002/ )
2017-07-13 andersc@webrtc.org Reland of Injectable Obj-C video codecs (patchset #1 id:1 of https://codereview.webrtc.org/2975963002/ )
2017-07-13 tommi@webrtc.org Make the default ctor of rtc::Thread, protected. The goal is to force use of Thread::Create or Thread::CreateWithSocketServer.
2017-07-13 henrika@webrtc.org Adds sanity check for sample rate on iOS
2017-07-13 sprang@webrtc.org Fix potential incorrect sync flags used with screenshare TL stream.
2017-07-13 tkchin@webrtc.org iOS - Add iceRegatherIntervalRange.
2017-07-13 ilnik@webrtc.org Add rtpdump and rtc log functionality to screenshare_loopback and video_loopback
2017-07-12 zijiehe@chromium.org Fix http://crbug.com/741252
2017-07-12 hbos@webrtc.org RTCStatsCollector: Get track IDs from senders/receivers instead of streams.
2017-07-12 jianj@google.com vp9: Use 2 threads for 360p.
2017-07-12 jianj@google.com vp9: Turn off FRAME_PARALLEL_DECODING.
2017-07-12 zstein@webrtc.org Make BaseChannel::rtp_transport_ a unique_ptr.
2017-07-10 minyue@webrtc.org Reland "Adding ANA config event to debug dump."
2017-07-12 saza@webrtc.org Set memory to all-zero floats in ExtractExtendedBlock in AEC2 if buffer is empty.
2017-07-12 saza@webrtc.org Removes internal buffer memory check in AEC module.
2017-07-11 deadbeef@webrtc.org Reland of Make "set_ignore_non_default_routes" actually use its argument. (patchset #1 id:1 of https://codereview.webrtc.org/2974193002/ )
2017-07-11 deadbeef@webrtc.org Revert of Delete SignalThread class. (patchset #20 id:380001 of https://codereview.webrtc.org/2915253002/ )
2017-07-11 tkchin@webrtc.org Revert of Injectable Obj-C video codecs (patchset #8 id:140001 of https://codereview.webrtc.org/2966023002/ )
2017-07-11 steveanton@webrtc.org API for periodically regathering ICE candidates
2017-07-11 sdefresne@chromium.org Use correct value for CFBundleExecutable and CFBundleName.
2017-07-11 ossu@webrtc.org TransmitMixer: Check GetSendCodec return value.
2017-07-11 ilnik@webrtc.org Reland of Refactor timing frame logic to work with encoders with internal sources (patchset #1 id:1 of https://codereview.webrtc.org/2980533002/ )
2017-07-11 tschumim@webrtc.org Let alr detector use a budged to detect underuse.
2017-07-11 ingemara@opera.com Suppress MissingPrefix using tools attribute
2017-07-11 jianjun.zhu@intel.com Use relative paths in GN files.
2017-07-11 tommi@webrtc.org Remove dependency on rtc::Thread and rtc_base from audio_mixer_unittests. Instead, use a TaskQueue in the only test that required it.

TBR=henrika@chromium.org,magjed@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

Bug: 
Change-Id: I3f04c06fdcb465df6bbadc66550ffac77abc62a1
Reviewed-on: https://chromium-review.googlesource.com/574909Reviewed-by: Tommi <tommi@chromium.org>
Commit-Queue: Tommi <tommi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487254}

The PaymentDetails already splited into PaymentDetailsInit and
PaymentDetailsUpdate. The updateWith() should take PaymentDetailsUpdate promise.
This change is only for fixing typo and there is no change in behavior.

Related spec link:
  https://w3c.github.io/browser-payment-api/#paymentrequestupdateevent-interface

Bug: 704162
Change-Id: Ib1d4c290220fadf8fa95d4d11b5c5bda2b9300ce
Reviewed-on: https://chromium-review.googlesource.com/572675Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#487253}

The impact on browser tests runtime should be fixed by
https://chromium-review.googlesource.com/c/571277

Bug: 531673
Change-Id: Ie60229d1f26c587a1ef092b99d3412cc8235488d
Reviewed-on: https://chromium-review.googlesource.com/574868Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Mike Wittman <wittman@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487252}

This code path is used for e.g. shift-clicks coming from subframes
(strangely). By plumbing it into LoadURLExternally / OpenURL, we can
use this information in the popup blocker.

This patch makes the additional refactor to split LoadURLExternally
into two, LoadURLExternally and DownloadURL.

Bug: 733330
Change-Id: I94476ecbf3f55ef26664d7c6a294e84fce7bba32
Reviewed-on: https://chromium-review.googlesource.com/565681Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Nick Carter <nick@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487251}

Changes:
1. Adjust the height of SearchResultTileItemView based on spec:
https://screenshot.googleplex.com/AFQ5HnrMYch
2. Adjust the height of SearchBoxView based on spec:
https://screenshot.googleplex.com/bGiXTCBUhdX
3. Adjust the width and height of SearchResultPageView based on spec:
https://screenshot.googleplex.com/ykfwoEeMPTr

Screenshot: https://screenshot.googleplex.com/8AQ0XofWAhZ

BUG=742699

Change-Id: Iad10d029241f82ccf98b3bac7e8a50c597da1aa1
Reviewed-on: https://chromium-review.googlesource.com/572365
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487250}

+ Move PopupWindow down 8dp if overflow menu is anchored at bottom

BUG=735252

Change-Id: Ic0942d979f9c686d49f8ce3e264e0d0c88cced79
Reviewed-on: https://chromium-review.googlesource.com/563956Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487249}

This CL:

* Implements a WebViewController that automatically adds a close button
  to the nav bar when it's the first VC in the nav stack, and allow
  overriding the right nav button.
* Adds the Credits button to the help center VC.
* Makes the side menu's help button work.

Bug: 740240
Change-Id: I28436ada3ea1a9e588be0cedfc2e5b874c82d4d9
Reviewed-on: https://chromium-review.googlesource.com/572602Reviewed-by: Scott Nichols <nicholss@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487248}

This test will be fixed with one of the following V8 roll:
inspector/sources/debugger/source-frame-inline-breakpoint-decorations.html

TBR=dgozman@chromium.org

Bug: chromium:744797
Change-Id: I42fdf32261d98c6723384565263693dc9948b80c
Reviewed-on: https://chromium-review.googlesource.com/575089Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487247}

Chrome Cleanup's functionality can be powered by an external company.
When this is the case, we want to show attribution in the WebUI. This is
done through the text "Powered by" followed by the company's logo inlined
in the text, then the registered trademark symbol.

Also fixes a line-split issue for the file paths to be removed and makes
some static chrome_cleaner_controller methods into class methods.

Bug: 690020
Change-Id: I87acfeb4a6ee95cbdd197318b3596f93f819c520
Reviewed-on: https://chromium-review.googlesource.com/568399
Commit-Queue: proberge <proberge@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487246}

Adds UMA to help us understand how often writes result in failure due to max-size violations.

Bug: 472740
Change-Id: I1ee875c4bc36a208d0f9a3df550cbeb6050dc567
Reviewed-on: https://chromium-review.googlesource.com/559889
Commit-Queue: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Julia Tuttle <juliatuttle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487245}

With newer Chromebooks having a dedicated key to show system tray we
want to be able to also hide it by pressing the same button.

BUG=b:63576567

Change-Id: Icd6cf6855c6d0ff8c3e587ed875869f2d2c4c91f
Reviewed-on: https://chromium-review.googlesource.com/572071Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Dmitry Torokhov <dtor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487244}

Bug: chromedriver:1879
Change-Id: I09672785cd3c2821755479a21856ff68ca9266db
Reviewed-on: https://chromium-review.googlesource.com/572367
Commit-Queue: Gauri Manikpure <gmanikpure@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487243}

CSSPreloadScannerTest and HTMLPreloadScannerTest
both use a local MockHTMLResourcePreloader class for
testing. That is normally no big deal but in jumbo builds they
can be compiled in the same translation unit and then the classes
will collide. This patch gives the classes unique prefixes.

R=fs@opera.com

Change-Id: I29cd360e919c6b708a6021b6930b3347e5ae8194
Reviewed-on: https://chromium-review.googlesource.com/574707
Commit-Queue: Daniel Bratell <bratell@opera.com>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487242}

It's banned; other approaches are preferred in C++11.

Change-Id: I9aa36d895b0d4eb9a290ba6a4df049731faf5cb3
Reviewed-on: https://chromium-review.googlesource.com/574429Reviewed-by: Joe Downing <joedow@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487241}

When search fails, the filter list may show "No results" when it should
show the pseudo sink again.  This change addresses this by re-running
the filter after the search state has been cleared in the container.

Bug: 743126
Change-Id: I74993ab95d36d2a614b4257b6d2a9ff48f99a7db
Reviewed-on: https://chromium-review.googlesource.com/571115
Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487240}

When force-sign-in policy is enabled and ProfileSigninConfirmationDialog is being displayed,
lock the profile temporarily so that there is no new browser window for that profile can be opened.

Unlock the profile after dialog being confirmed and Chrome begins to download policy.

Bug: 642059
Change-Id: Ib4ab0e9172cae3646ae855cc48a9564bc2fef0a3
Reviewed-on: https://chromium-review.googlesource.com/572425
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487239}

This adds four metrics to the PLM UKM for previews: "opt_out", set to true when the user hit "Show Original" on a preview;
"server_lofi", "client_lofi", and "lite_page" set to true when a preview was shown. When no preview is
shown, no metrics are added to the UKM.

Similarly, when the user does not opt out, nothing is added for opt_out.

This does not track offline previews yet, but may in the future.

The infobar posts an event to page_load_metrics for the web contents when the user clicks "show original" on the page.

BUG=701514,723711,728707

Review-Url: https://codereview.chromium.org/2952343004
Cr-Commit-Position: refs/heads/master@{#487238}

std::is_trivially_copyable should return false for classes with nontrivial
destructors.

C++11 standard section 9.6 says a trivially copyable class is a class that:
  — has no non-trivial copy constructors (12.8),
  — has no non-trivial move constructors (12.8),
  — has no non-trivial copy assignment operators (13.5.3, 12.8),
  — has no non-trivial move assignment operators (13.5.3, 12.8), and
  — has a trivial destructor (12.4).

The current implementation for _GNUC_VER < 501 didn't detech the destructor
case. This is important because when is_trivially_copyable returns true,
container code may implement moves as memcpy, when in fact it needs to me a
memcpy + a destructor.

Bug: 
Change-Id: I5739856ca7eaf5ddcf3eeb716bdc2dc33b0de0f2
Reviewed-on: https://chromium-review.googlesource.com/575020Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487237}

Profile sync service relies on the lifetime of
SyncSetupInProgressHandles to determine if setup is in progress.
Currently, none of these handles are alive in the period between the
closure of the sync confirmation dialog and the loading of the sync
setup page. This causes profile sync service to think that setup is both
incomplete and not in progress, which surfaces an error icon on the
avatar.

This CL causes PeopleHandler to acquire its SyncSetupInProgressHandle
earlier if it detects that it's navigating directly to the syncSetup
page.

R=
BUG=738789

Review-Url: https://codereview.chromium.org/2971353002
Cr-Commit-Position: refs/heads/master@{#487236}

pdf_plugin.html shows the file name and a View PDF link. When View PDF is
clicked, the callback function sends a message. When this message is
handled in PluginObserver, the URL for the PDF file is opened in a new
tab. However, in guest view, when the message is handled, nothing is
done.

BUG=737787

Review-Url: https://codereview.chromium.org/2972123002
Cr-Commit-Position: refs/heads/master@{#487235}

BUG=689520

Change-Id: I755c689e1de877e78f0ac22886fd330b2242bf95
Reviewed-on: https://chromium-review.googlesource.com/573604Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487234}

Also exposes counts of 'identity' transform.

Bug: 740245
Change-Id: Ia13fccbc7bab1e8f90b88a1e8e422749194e298a
Reviewed-on: https://chromium-review.googlesource.com/563595
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: Ben Greenstein <bengr@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487233}

This reverts commit 535fbc0b.

Reason for revert: Failed tests on internal.bling.main bot. Configuration updates look like they are needed in this bot as well.

https://uberchromegw.corp.google.com/i/internal.bling.main/waterfall?builder=iphone10-simulator

Original change's description:
> [Payment Request] Adds tests for accessibility on main pages of Payment Request - Reland
> 
> Two build bot json files have been edited so that they run with the appropriate 
> command line flags. Given that these build bot changes are related to adding to this
> test this is all being packaged as one CL.
> 
> From original CL description:
> "The added HTML file and JS file have been downloaded from here:
> 
> https://rsolomakhin.github.io/pr/multi/
> 
> And thus do not need to be thoroughly reviewed. The only changes made to these
> files are as follows
> 1) In the html file an "id" attribute is added to the "buy" button, the 2016
> copyright is changed to 2017, and the stylesheet and favicon links are removed.
> 2) In the js file "requestPayerEmail," "requestPayerPhone," and "requestPayerName"
> is added to options on line 106, the JSLint directives are removed from the top of
> the file, and the long line on line 137 was changed into two lines."
> 
> TBR=@lpromero@google.com -- Reviewed already in last past. Only addition here is the
> build bot changes.
> 
> Change-Id: Ia20efa783eb763ae97f7e0df2f80e710823d7482
> Reviewed-on: https://chromium-review.googlesource.com/570879
> Commit-Queue: Randall Raymond <rayraymond@google.com>
> Reviewed-by: Eugene But <eugenebut@chromium.org>
> Reviewed-by: mahmadi <mahmadi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#487162}

TBR=eugenebut@chromium.org,lpromero@chromium.org,michaeldo@chromium.org,rayraymond@google.com,mahmadi@chromium.org

Change-Id: Ib69b8365f7e45f8f7df9113fa2980052bf0cc361
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/574675Reviewed-by: Ed Chin <edchin@chromium.org>
Commit-Queue: Ed Chin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487232}

Recently we replaced the controller event timestamps with timestamps
generated by the VR Controller. However, these timestamps aren't in the
same timebase, and so cannot be used.

Bug: 732830
Change-Id: I33cb642e0008eb1676a65596c83e3982fe5a59f6
Reviewed-on: https://chromium-review.googlesource.com/568687Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487231}

GetAppOutputWithExitCode() is implemented for Windows, but not exposed.

Bug: 741926
Change-Id: Ib0518a8c6b28bc0946e6e820756e264d13028312
Reviewed-on: https://chromium-review.googlesource.com/571239Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Zijie He <zijiehe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487230}