- 11 Oct, 2019 40 commits
-
-
Juan Antonio Navarro Perez authored
This is mostly an API change (*), the underlying implementation of AddMeasurement is still the same (via legacy values in Telemetry), so no behavior changes are expected. (*) Except for a few measurement descriptions which were tweaked for clarity. Depends on: https://chromium-review.googlesource.com/c/catapult/+/1840835 TBR=hablich@chromium.org Bug: 999484 Change-Id: I01c79f1741dbbde6d179c33bb91defade8fd0155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841551 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Auto-Submit: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#705086}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3b819f3d8bbe..51bf20029462 git log 3b819f3d8bbe..51bf20029462 --date=short --no-merges --format='%ad %ae %s' 2019-10-11 danilchap@webrtc.org Reduce number of RTPVideoSender::SendVideo parameters 2019-10-11 kwiberg@webrtc.org NetEqImpl::GetDecoderFormat: Return RTP clockrate, not codec sample rate Created with: gclient setdep -r src/third_party/webrtc@51bf20029462 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Ib927efd86297943172e25bd1df20d5984daf0679 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854812Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705085}
-
Javier Ernesto Flores Robles authored
Style all the views with the UI specification. Add support for dynamic type. Wrap contents in a scroll view for the bigger font sizes. Add support for horizontal and vertical size class changes. Present as Form on iPad. Bug: 1008862 Change-Id: I9a107bb14e9bd1669462c9a383243a213a970aa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847339 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#705084}
-
Roman Sorokin authored
Bug: none Change-Id: I4e11bd9c8b81828df5b08bf9dae6788d478ebcee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855984Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#705083}
-
Henrique Ferreiro authored
Convert the implementation and all users of the chrome_cleaner::mojom::EngineScanResults, EngineCleanupResults and EngineCommands interfaces. EngineRequests and EngineFileRequests will be migrated in a different CL. Bug: 955171 Change-Id: I792cdc4753626621ba9d53d908133297f4520999 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831805Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#705082}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/464d407d..04988676 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iff6705054579dd31df7ddeb52866d2ecf1deed1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855661Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705081}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/54b0677aeba5..d0458b338358 Created with: gclient setdep -r src-internal@d0458b338358 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ifd4444a2fef6ddcef7d3c107f36744e791c19a60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854811Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705080}
-
Kamila authored
- Updated the indicator (explanation text, animation, blocked badge) for the mediastream image model, based on the state of the permissions on a system and site level according to the behavior described in the bug (#c1). - Show no indicator when: The user still has to make a decision (the system level prompt is open). - Update the location bar when the user blocks system level permissions. - Unit tests, testing the logic for camera/mic/camera+mic image model. Change-Id: Id65911e9c81c77b59e0e9678642dc95c9e31246d Bug: 1012729 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776539 Commit-Queue: Kamila Hasanbega <hkamila@google.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#705079}
-
Rayan Kanso authored
Bug: 1013568 Change-Id: I9d5cdcf2175cbdadeda5ac718ae0a9cf137c936b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831870 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#705078}
-
Javier Ernesto Flores Robles authored
Update the table view in case the user is kicked out. Or logs out in multi-window. Bug: 986322 Change-Id: I45f1979bf27dfde6568fcaa525ab7443161342c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856078 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
Javier Ernesto Flores Robles authored
Updates the detail text of the switch based on the logged in status and the preference value. Bug: 986322 Change-Id: I11f346f003e756c4ab55e75992c7fdf16f1d7492 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852090Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/561ba7ee890b..58a3ebb1bb9f git log 561ba7ee890b..58a3ebb1bb9f --date=short --no-merges --format='%ad %ae %s' 2019-10-11 matthew.clarkson@arm.com tools(gen_amalgamated): quality of life improvements Created with: gclient setdep -r src/third_party/perfetto@58a3ebb1bb9f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Iba14b7cdfd009cf80d285efe5775c455c5130307 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854810Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium db752d0b. With Chromium commits locally applied on WPT: 23748e60 "Change text directive to text=" 2f7c5562 "Fetch Metadata: Split `sec-fetch-dest` out from other headers' tests." d52a9d07 "Port IndexedDB Blob Web Tests to web-platform-tests." 6386d9d8 "Update service_worker_unregister_and_register()" 1644eff7 "Update scroll to text feature detectability API" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools jfernandez@igalia.com: external/wpt/css/css-align jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ic7968bc458ce817750a700c4fd05f752afcd02ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855660Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705074}
-
Keishi Hattori authored
Replace ScopedPersistent in V8V0CustomElementLifecycleCallbacks with TraceWrapperV8Reference. Use of ScopedPersistent is discourage in favour of TraceWrapperV8Reference which is GC aware. Bug: 1013149 Change-Id: I3b45f15616d2b206d260f45519546e845a183c5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855321 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#705073}
-
Peter E Conn authored
Bug: 1005736 Change-Id: I83b26daa7b15dd74df138c14cd58811deeb8712f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854126Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#705072}
-
Pavel Shmakov authored
Change-Id: I74d0822b697f55a9d1e53a106a60d784c352a9f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852214Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Cr-Commit-Position: refs/heads/master@{#705071}
-
Ingvar Stepanyan authored
It's not safe to cache source map object by just source map URL, because source map is always constructed with and associated with specific source URL, too, so reusing same source map object for various source URLs can end up resolving invalid locations, pointing to the first source URL it was constructed with. This change creates an aggregate source map ID, similar to the one in SDK.DebuggerModel, by concatenating source URL, ":" and source map URL. Such ID can then be used for caching and tracking purposes. There are more things that could be simplified here, but for now tried to make this change minimal and pretty much 1:1 replacement. Also removed obsolete applySourceMapEdit which doesn't seem to be used anywhere. Bug: 1012360 Change-Id: I131927a9f960526ba01412a39f22f036b1023caf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848697 Commit-Queue: Ingvar Stepanyan <rreverser@google.com> Auto-Submit: Ingvar Stepanyan <rreverser@google.com> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#705070}
-
Makoto Shimazu authored
This CL converts base::Bind to BindOnce or BindRepeating, and also changes relevant base::Callbacks or base::Closures to appropriate types. This CL is split from https://crrev.com/1831621. This CL was uploaded by git cl split. R=yangguo@chromium.org Bug: 1007760 Change-Id: Id6da42c61527457fcb365f49ce3561bc0fce3399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849542 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Ewann authored
Fixing action buttons: - Check if the location bar is in steady state. If yes, the Copy button is displayed. If not, if there is selected text the Copy button is displayed. In other cases, the Copy button is hidden. - display Paste & Search for Copied Text buttons when omnibox is empty. - hide Select & Select All buttons when omnibox is empty. - display Select All button when selected text and hide Select button. Corresponding integration tests dded. Bug: 864984 Change-Id: I321546571272235eac0b749753f041bff0922608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786639 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#705068}
-
Roman Sorokin authored
It's in fact user visible :) Bug: 1008270 Change-Id: I0b6dafea8883c9aaeb8e76f162dc427029752b93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853924Reviewed-by:
-
Antonio Gomes authored
... and the respective unittest, transceiver_state_surfacer_unittest.cc This CL works out phase 7.4 on the design document [1]. [1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/ BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: I25384e38468cdfaf5e5fa2157f8f5993f1591f7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820062 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
David Roger authored
TBR=yhirano Bug: 1013523 Change-Id: Iad71979f640ed5ae42c7fe00982da2876935fb95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855978Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#705065}
-
Makoto Shimazu authored
This CL converts base::Bind to BindOnce or BindRepeating, and also changes relevant base::Callbacks or base::Closures to appropriate types. This CL is split from https://crrev.com/c/1831621. This CL was uploaded by git cl split. R=msramek@chromium.org Bug: 1007760 Change-Id: If363fd450c6a7118b8d622e8ae3b9c2777f96524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849541 Commit-Queue: Martin Šrámek <msramek@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#705064}
-
Maksim Moskvitin authored
In theory, keystore keys might not arrive together with NigoriSpecifics, for example, in case of throttling. To make USS implementation more robust in this situation, we allow pending keys in keystore mode. Cryptographer should be properly initialized once we receive keystore key, which was used for encryption of keystore_decryptor_token. This CL extends pending keys concept to keystore_decryptor_token, because we need to store it until decryption. Note: Directory implementation implicitly had this concept, since it stored NigoriSpecifics itself as the local state. Note: this CL doesn't add support for initialization of default Nigori in case bridge has no keystore keys. Bug: 922900 Change-Id: I9a138d2190e28b617789bb0632d3751fa226d8d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840694 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#705063}
-
Michael Lippautz authored
This change moves DOMDataStore on Oilpan's heap and models wrappable->wrapper connections using an ephemeron hash map for non-main worlds. Previously, DOMDataStore would be off heap and the that maintains the references would use Untraced<> as well as custom Trace() methods for non-GCed objects. That also required callbacks on the references to manually remove the entries to compact the hash map. With ephemerons: - The hashmap is kept compact (unused buckets are deleted) by the GC which allows us to avoid callbacks on references. - There are no more GC plugin exceptions. - All trace methods will be on garbage collection objects. - There's no need to trace through all DOM worlds for each ScriptWrappable in its trace method. - References will show up in heap snapshots. Bug: 1013212 Change-Id: Id3475707d34191f9f3b6b099c2495ee0150d982e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849677 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/69077a26ccaf..1550399cc0a1 git log 69077a26ccaf..1550399cc0a1 --date=short --no-merges --format='%ad %ae %s' 2019-10-11 khokhlov@google.com [Telemetry] Save story tags in intermediate results Created with: gclient setdep -r src/third_party/catapult@1550399cc0a1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=zhanliang@google.com Bug: chromium:981349 Change-Id: I6cb9f6a0060a5464073d02cb58ba7cf346e66d19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854808Reviewed-by:
-
Lowell Manners authored
Note that as part of adding these tests, a bug was discovered (https://crbug.com/1012707). Change-Id: Ib8fe265f673bf773efc6968c743445ad3c4eb7b0 Bug: 1012707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831803Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#705060}
-
Lowell Manners authored
This test recently broke, likely due to https://crrev.com/c/1819251. TBR=ahemery@chromium.org Change-Id: Ided00fc067ec266440a02aa0c1b08a7d632f8ae8 Bug: 1013550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856038Reviewed-by:
Lowell Manners <lowell@chromium.org> Commit-Queue: Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#705059}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ic86ae666289b3f97beda457ec3d8de7d93da4812 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854806Reviewed-by:
-
Clemens Backes authored
The TransferrableModule became obsolete with https://crrev.com/c/1847366 and will be deprecated soon. This CL switches all uses to the WasmCompiledModule. R=mlippautz@chromium.org Change-Id: Ib53653c661e0381377cb1fe653f02c8a289b2141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855822Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#705057}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3a1e314b0399..67486ec24551 git log 3a1e314b0399..67486ec24551 --date=short --no-merges --format='%ad %ae %s' 2019-10-11 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 82f84c4b8f19..feb154921397 (3 commits) Created with: gclient setdep -r src/third_party/angle@67486ec24551 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: chromium:None Change-Id: I2e582fa2e38003ee6cdd9e55042b97a2e2adc515 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854807Reviewed-by:
-
Fergal Daly authored
This adds WebSchedulerTrackedFeature::kWebLocks and registers its use from LockManager::request. The test I added failed before I add the code to disable bfcache. Bug: 1013069 Change-Id: I534cb3b712875459e8e991161b444fe8a03a87c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851634 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#705055}
-
Elly Fong-Jones authored
This concept does not belong in DialogDelegate, since it is implemented only in BubbleFrameView. This change moves the policy decision of when BubbleFrameView should snap a bubble's width into BubbleFrameView itself. This change also removes the only override outside Views of ShouldSnapFrameWidth, which was on ExtensionsMenuView; this class was overriding it to return true while also returning a static width from CalculatePreferredSize, meaning that it actually has a fixed width anyway. Bug: 1011446 Change-Id: I99369e83b7c467b8cbc2927727f0d268c44e6ea1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854458Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#705054}
-
Tim van der Lippe authored
This includes rollup Bug: 1013129 Change-Id: I30147d21af77c8886a0ba83f56cd30e76a7d3dc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853225Reviewed-by:
-
Javier Ernesto Flores Robles authored
Bug: 1008862 Change-Id: I99425c705f94ef6d36df20254e8a4a219f60754b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855958 Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#705052}
-
Koji Ishii authored
This patch fixes |NGLineBreaker| to cache 'letter-/word- spacing' values when it is constructed with a break token. This seems to be an old bug. r527007 (crrev.com/c/846585) initialized |current_style_| without calling |SetCurrentStyle|. Then r590190 (crrev.com/c/1217708) skipped caching locale and letter-/word-spacing in such case. The issue has been there since then, but it seems r701601 (crrev.com/c/1826063) turned it to more frequent crashes. Bug: 963521 Change-Id: I4abe207505917f351c8074a5e7e3cb139c9515d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851625 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#705051}
-
Gauthier Ambard authored
This CL changes the matcher for the Close button, making sure that it is enabled. Bug: 1013542 Change-Id: Ibf971693cbd6f8615c64a795d76c5b6db9ad5093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855823Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#705050}
-
Elly Fong-Jones authored
Updating the cookie count every time it changes is extremely expensive (each update causes a relayout of the page info dialog) and, worse, causes the dialog to be unusable to screen readers. In the extreme case, JS-heavy websites cause this dialog to be read as endless repetitions of "Cookies" as the screen reader repeatedly cuts itself off while trying to read the changing text. This change makes the dialog text not update; other possibilities considered were: * Removing the text altogether * Collapsing the state down to "cookies in use" or "no cookies in use" I feel that this change is less intrusive and less of a design change to the dialog than either of those two, but one of them (especially the first, IMO) is probably a good direction to go later. To test this change, try https://www.washingtonpost.com: navigate to the site with a cold cache, open the page info dialog, and watch the text change rapidly. Bug: 984651 Change-Id: If7f996470a1768a7f9acadc72fcf13cec41a73a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853112Reviewed-by:
-
Elly Fong-Jones authored
This change introduces DialogDelegate::Params::button_labels and DialogDelegate::set_button_label(), and makes the default behavior of DialogDelegate::GetDialogButtonLabel() check Params::button_labels for a label assigned to the specified button. This change also converts a random handful of dialogs in //chrome to using this method to demonstrate how it will eventually look. There are many, many more to convert (~200) so subsequent CLs will be necessary. One big open question is what to do with dialogs like LocalCardMigrationDialogView, which change the reults of GetDialogButtonLabel based on the dialog's internal state... Bug: 1011446 Change-Id: Idbf9464fe32e519a2150b00a2179558cd7b78adb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853045Reviewed-by:
-
Antonio Gomes authored
... and the respective unittest, rtc_rtp_transceiver_unittest.cc This CL works out phase 7.3 on the design document [1]. [1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/ In order to avoid colliding files and classes names with existing homonyms in renderer/modules/peerconnection, the following renames were performed: - rtc_rtp_transceiver_impl.cc -> rtc_rtp_transceiver_impl.cc - rtc_rtp_transceiver_impl.h -> rtc_rtp_transceiver_impl.h.h - rtc_rtp_transceiver_unittest.cc -> rtc_rtp_transceiver_impl_test.cc Also, RTCRtpTransceiver became RTCRtpTransceiverImpl. BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: Ibd84b5911ac64b9e1ad25e139a8e31ddfdccf281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820060 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
