GitLab

In FileManager send 'on-completed' event only when a scan is completed. Send 'on-cancelled' event when a scan is cancelled. Make search & usual spinner work with these events.

BUG=141381


Review URL: https://chromiumcodereview.appspot.com/10824277

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151263 0039d316-1c4b-4281-b951-d872f2087c98

BUG=137981
TEST=Test that dropping image from third party page has no effect. Test that files from other file manager windows do drop.


Review URL: https://chromiumcodereview.appspot.com/10854117

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151262 0039d316-1c4b-4281-b951-d872f2087c98

BUG=23433
TBR=timurrrr
Review URL: https://chromiumcodereview.appspot.com/10828283

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151260 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141142

Review URL: https://chromiumcodereview.appspot.com/10825318

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151259 0039d316-1c4b-4281-b951-d872f2087c98

BUG=129203
TEST=Run chrome with --force-device-scale-factor=2 and go to bookmark manager, folder icons are high dpi.

Review URL: https://chromiumcodereview.appspot.com/10855106

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151258 0039d316-1c4b-4281-b951-d872f2087c98

This broke the WebKit Chromium Android bot.

BUG=142322

Review URL: https://chromiumcodereview.appspot.com/10829291

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151257 0039d316-1c4b-4281-b951-d872f2087c98

We deprecated it when we added RevokeFileSystemByPath but it looks we still want it.

BUG=none
TEST=IsolatedContextTest.RegisterAndRevokeTest


Review URL: https://chromiumcodereview.appspot.com/10837217

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151256 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140887


Review URL: https://chromiumcodereview.appspot.com/10855124

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151255 0039d316-1c4b-4281-b951-d872f2087c98

*) Animation time shortened to 200ms.
*) Progress bar hidden during initial transition.
*) Update screen size fixed.
*) Screens are not forced to have equal size in old UI.
*) No initial border flicking on login screen.
*) No initial network dropdown flickering in OOBE (no slightest idea why).

BUG=141560

Review URL: https://chromiumcodereview.appspot.com/10826267

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151254 0039d316-1c4b-4281-b951-d872f2087c98

(In usual call path it errors out before it calls into FileUtil)

BUG=none
TEST=IsolatedFileUtilTest.UnregisteredPathsTest


Review URL: https://chromiumcodereview.appspot.com/10825316

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151253 0039d316-1c4b-4281-b951-d872f2087c98

This CL broke the WebKit Android build bot and EWS bots by exporting
CC and CXX, which caused the global make settings as defined in gyp to be
ignored.

Original review URL: https://chromiumcodereview.appspot.com/10836192

TBR=yfriedman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10829296

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151251 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141807
TEST=Navigate to a folder in Google Drive in the File Manager. Press Ctrl+R. Ensure file the list is correct (before the fix it used to contain Google Drive root directory content). Also checked the behavior described in the issue.


Review URL: https://chromiumcodereview.appspot.com/10826260

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151250 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151248 0039d316-1c4b-4281-b951-d872f2087c98

TBR=fmalita@chromium.org
BUG=none


Review URL: https://chromiumcodereview.appspot.com/10836207

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151247 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141055

Review URL: https://chromiumcodereview.appspot.com/10854092

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151246 0039d316-1c4b-4281-b951-d872f2087c98

R=kinaba@chromium.org
BUG=126980


Review URL: https://chromiumcodereview.appspot.com/10831279

TBR=zork@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10854110

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151241 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151240 0039d316-1c4b-4281-b951-d872f2087c98

R=kinaba@chromium.org
BUG=126980


Review URL: https://chromiumcodereview.appspot.com/10831279

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151238 0039d316-1c4b-4281-b951-d872f2087c98

They were used in file_util_helper.cc and by tests only, and is not needed to exist separate implementation per FileUtil.
Can I remove it like this?

BUG=


Review URL: https://chromiumcodereview.appspot.com/10855039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151234 0039d316-1c4b-4281-b951-d872f2087c98

Failing on the ChromiumOS Dbg Bots.

BUG=141497,139117
TEST=none
TBR=jochen

Review URL: https://chromiumcodereview.appspot.com/10837188

TBR=dalecurtis@google.com
Review URL: https://chromiumcodereview.appspot.com/10825315

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151233 0039d316-1c4b-4281-b951-d872f2087c98

due to fame navigation flakiness.

TBR=jochen@chromium.org 
BUG=141497
Review URL: https://chromiumcodereview.appspot.com/10827258

TBR=mmenke@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10827294

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151232 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151227 0039d316-1c4b-4281-b951-d872f2087c98

TBR=fmalita@chromium.org
BUG=none


Review URL: https://chromiumcodereview.appspot.com/10824274

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151226 0039d316-1c4b-4281-b951-d872f2087c98

BUG=23581
R=pkasting@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10837198

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151225 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151224 0039d316-1c4b-4281-b951-d872f2087c98

TBR=fmalita@chromium.org
BUG=none


Review URL: https://chromiumcodereview.appspot.com/10827291

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151223 0039d316-1c4b-4281-b951-d872f2087c98

- DrawPoint makes gap with the next pixel, so FillRect instead
- FillRect to draw the border rather than DrawRect.  DrawRect makes thin gap
  with the contents.
- Fill the center point of the crosshair.  That is not necessary since
  we have selected color patch, and this lack of center point looks ugly
  on HiDPI devices.

BUG=139991


Review URL: https://chromiumcodereview.appspot.com/10854039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151222 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=try passed


Review URL: https://chromiumcodereview.appspot.com/10828246

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151221 0039d316-1c4b-4281-b951-d872f2087c98

We don't need to pass Profile because we can get it from Browser API, and we
are trying to reduce the usage of Profile.

R=pkasting@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10830254

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151220 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125846
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10855118

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151219 0039d316-1c4b-4281-b951-d872f2087c98

BUG=116317
TEST=manual

Changes the order that DidDestroy for the untrusted plugin and the trusted
NaCl plugin are called. This allows the plugin to initiate shutdown before
the untrusted plugin, which may hang.
Review URL: https://chromiumcodereview.appspot.com/10824220

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151217 0039d316-1c4b-4281-b951-d872f2087c98

Long term, we'd like to drop this further (i.e. 1 minute) and trust THROTTLED responses in the event of widespread backend outages.
We'd like to run some stress tests of that infrastructure (at scale / under load), but in the meantime we want to address the problem
for beta channel users / M22.  We chose 5 minutes, which is a little more aggressive than the recommended value, but we believe is
safe -- happy to discuss offline.

This patch is very low risk (stability wise). although 5 minutes is a long time to wait for users who hit this due to transient failures.
Current data suggests 500s occur around 0.02% of the time, and although backoff isn't limited to 500s it's unlikely to get hit frequently,
and the user experience doesn't break down significantly.

Effectiveness wise, We can run an experiment once it hits dev channel by returning 500s and watching for expected drops in QPS.

BUG=139733,142029

Review URL: https://chromiumcodereview.appspot.com/10826194

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151216 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151215 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10837131

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151214 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125846
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10823280

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151213 0039d316-1c4b-4281-b951-d872f2087c98

This is helpful so that instead of adding new binaries for each different test suite that runs on its own bots (and so increading build times), we can still keep the tests in the same binaries. Instead, the specific bots would add --run-manual and can pass the test suite names as a command line flag.
Review URL: https://chromiumcodereview.appspot.com/10825311

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151212 0039d316-1c4b-4281-b951-d872f2087c98

Fix the browser windows from going in a loop trying to steal focus from each other when activating a differnet window from the one that has a modal dialog. Instead, activate it in a posttask.

BUG=141650
Review URL: https://chromiumcodereview.appspot.com/10826253

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151211 0039d316-1c4b-4281-b951-d872f2087c98

WebSocket should ignore certificate errors when chromium starts with
--ignore-certificate-erros flag.

BUG=141762
TEST=SSLUITestIgnoreCertErrors.TestWSS


Review URL: https://chromiumcodereview.appspot.com/10830256

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151208 0039d316-1c4b-4281-b951-d872f2087c98

This reinforces that only certain thread/message_loop can be created, which also makes thread/message_loop access easier and more reliable.

Also use scoped_refptr<MessageLoopProxy> instead of raw MessageLoop pointer in various places.

BUG=none
TEST=media_unittest, content_unittest and normal <video> playback.


Review URL: https://chromiumcodereview.appspot.com/10855051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151204 0039d316-1c4b-4281-b951-d872f2087c98

TBR=mkearney@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10826261

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151201 0039d316-1c4b-4281-b951-d872f2087c98