- 03 Sep, 2020 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/99d869bb..6d46b6f1 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ifd4c071b99d7544b562122218f4fb7d48b781540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390546Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804318}
-
Pavel Yatsuk authored
This CL adds feature flags and about:flags entries for a couple of flags: - MessagesForAndroidInfrastructure will control initialization of infrastructure classes (MessageQueueManager, etc.) - MessagesForAndroidPasswordsName will control whether save/update password uses Infobars or Messages UI. BUG=1123947 R=lazzzis@chromium.org Change-Id: I4b3e3920d2909f8e6144cc197d8fddc029356f86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388949Reviewed-by:
Lijin Shen <lazzzis@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#804317}
-
Leonid Baraz authored
Change-Id: Ifa68ca8083ccb12602ae62f0f1e19e4827bc2afa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392711Reviewed-by:
Zach Trudo <zatrudo@google.com> Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#804316}
-
Kent Tamura authored
This is a preparation to attach LayoutSliderContainer to the slider track part, instead of the slider container part. LayoutSliderContainer adjusts the position of the thumb part, but the thumb part is not a child of the slider container part, and it's a child of the slider track part. This CL has no behavior changes. Bug: 1040826 Change-Id: Ie520e4f9fe5c474c40b55eb0e2d5d308c05300cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391893 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#804315}
-
Yicheng Li authored
If fingerprint scan failed, provide visual feedback (animation and prompt text change) to the user. Also add accessibility feedback: ChromeVox would play an alert sound and say the fingerprint auth result. These are the same effects as lock screen except that the prompt text strings mention "authenticate" instead of "unlock". Bug: b:156258540, b:144861739 Test: Tested with ChromeVox. Change-Id: If15ba95e532500f8cbf47b421a48a3be3dfb4c6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386579Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yicheng Li <yichengli@chromium.org> Cr-Commit-Position: refs/heads/master@{#804314}
-
Arnaud Mandy authored
use of test-only-api.js in preparation for launching official MojoJS support in WPT. This would not change the test results on Chromium waterfall (everything should continue to pass) or upstream WPT (tests currently fail because MojoJS isn't enabled). Bug: 1123988 Change-Id: I638c27ffe363a7011fba40e1a78339d8052ef18a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390203 Commit-Queue: Arnaud Mandy <arnaud.mandy@intel.com> Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#804313}
-
Arnaud Mandy authored
These files need to be accessible when running wpt outside chromium environment. see: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md#mojojs This is the first step towards making these tests pass outside the Chromium CI Bug: 1123992 Change-Id: I0a6fdfdd5a7c2970d3c683cc4140af3b6d1b999e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391223Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: Arnaud Mandy <arnaud.mandy@intel.com> Cr-Commit-Position: refs/heads/master@{#804312}
-
Justin DeWitt authored
This changes: * Removes the hairline around the menu * Widens the menu view so that the gear and the cog are aligned with the edges of card content New Screenshots: Feed V2 Enabled: https://screenshot.googleplex.com/7X8V4WTYgTx9EUW Feed V2 Turned Off: https://screenshot.googleplex.com/9UJLL9uDcjNGjyQ Bug: 1123996 Change-Id: I8db77160cbae5e0121dfc3397d732b81532ff56a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388261 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Vincent Boisselle <vincb@google.com> Reviewed-by:
Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#804311}
-
John Chen authored
Add information about running ChromeDriver Python integration tests targeting Android devices. Notry: true Change-Id: I6f97e77cd56ca143dac313759e5561edf7d6a697 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392265Reviewed-by:
Shengfa Lin <shengfa@google.com> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#804310}
-
Yifan Luo authored
Bug: 1116418 Change-Id: I33bd57b176c9c603d60b83ca0e020aa5f5b4abff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390910 Commit-Queue: Yifan Luo <lyf@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#804309}
-
Hidehiko Abe authored
This CL unifies those two buildflags file for Chrome OS. BUG=1114198 TEST=Build locally. Ran tryjob. Change-Id: Id7343da06ac6b17cb20cb20babdd8ab06ac40028 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377525 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#804308}
-
Karel Král authored
Implement an overloaded function to trace its argument into a given TracedValue pointer. Thus enable using type deduction to decide which way to trace a given argument. Bug: 1111787 Change-Id: I058c3436f59f3b6d98e34c1f620b467e4d5c41e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364872 Commit-Queue: Karel Král <karelkral@google.com> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#804307}
-
Antonio Sartori authored
This CL implements a unittest in the AncestorThrottle for testing the logic of the check for Content-Security-Policy: Embedded Enforcement. Bug: 1094909 Change-Id: I935110d1718b7d39d364f20e57a24e59ba141463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294801 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#804306}
-
Ben Pastene authored
This reverts commit 0839d38f. Reason for revert: chromium/ci/linux-chromeos-rel never times out All builds are < 2 hours: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel Original change's description: > [infra] Increase linux-chromeos-rel build timeout from 3 to 4 hours > > Bug: 1121834 > Change-Id: Ic98a994d225795788e10c4b161f9de1b1bde60d2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376572 > Auto-Submit: Gregory Guterman <guterman@google.com> > Reviewed-by: Erik Staab <estaab@chromium.org> > Commit-Queue: Erik Staab <estaab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801637} TBR=estaab@chromium.org,guterman@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1121834 Change-Id: Icbaf4999523e7c24bb0973b14c7517ae05c68e24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392918Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#804305}
-
Luke Zielinski authored
This rolls up to sha 7da1d0666575e5735fd1286e6b3e67e9973f4643 Just one minor change to testharness, likely a no-op Change-Id: Ia7e1318684542156d1906f1e67c7508aed903bac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392438 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Auto-Submit: Luke Z <lpz@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#804304}
-
Jinsuk Kim authored
The feature has been sunset. Remove the related flags, make some '..FeatureEnabled()' methods simply return false. Cleaning up the rest of Duet-related code will follow soon. Bug: 1081343 Change-Id: If58553cc7553b942bfbd97034efa86dc03f7aab9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386858Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202009030800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/tO_jo2xydYVZOxjRmrkRI5NL5AYbhmuV3J9LTRaaYEsC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: help-app@grotations.appspotmail.com Change-Id: Id129d7a5a29e6e14fd3455e9f45411772689a149 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392715Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804302}
-
danakj authored
This is from pre-compositing times. R=avi@chromium.org Change-Id: I95617aca135e455053130d53b357d95c0c563042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392399Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#804301}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c4bfa82e48ed..fb45a94639ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I1057be90d5501c55c72f34a982c1b20d8a4a1407 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390854Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804300}
-
Le Hoang Quyen authored
- yuv_to_rgb_converter.cc was only able to correctly handle rectangle YUV textures (GL_TEXTURE_RECTANGLE_ARB). However, it couldn't handle GL_TEXTURE_2D textures correctly (The Metal backend uses GL_TEXTURE_2D for IOSurface unlike the default OpenGL backend). - The shaders code as well as the OpenGL code were assuming the textures are rectangle whereas the 2D scenarios hadn't been tested properly. For example, the OpenGL code always passed texture size to "a_texScale" uniform to scale the texcoords, regardless of the texture being rectangle or 2D. In 2D fragment shader, the texcoords for UV texture were reduced by half as if the texcoords are for rectangle texture. - Furthermore, when binding IOSurface to 2D textures, the code forgot to disable mipmap filtering. Because by default 2D textures have mipmap filtering enabled, and IOSurface bound textures don't have mipmap, this led to the YUV textures were reported as incomplete by OpenGL. Thus decoding wouldn't be able to sample real results from the YUV textures. Bug: angleproject:4846 Bug: angleproject:2634 Bug: 1122432 Change-Id: Ie43b755c19b3dc149ddca3d68c381fee99479c00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378407 Commit-Queue: Le Hoang Quyen <le.hoang.q@gmail.com> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#804299}
-
Christian Dullweber authored
This is a reland of 1180542b The internal CL is rolled in now. Let's try again... Original change's description: > Remove BlockThirdPartyCookies preference > > The boolean BlockThirdPartyCookies preference was replaced by > CookieControlsMode enum. Existing settings were migrated since M83. > Since all usage of the preference has been removed, the preference > can be removed and existing settings cleared. > > Bug: 1104836 > Change-Id: Ie6e38b0a424981395c627459d684030ea84a58b7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387805 > Reviewed-by: Balazs Engedy <engedy@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Commit-Queue: Christian Dullweber <dullweber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803844} Tbr: engedy@chromium.org, gab@chromium.org Bug: 1104836, 1124326 Change-Id: Iebe3205beb4426cda5305eb7c69eb4e575df2cfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391073Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#804298}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/be72801f29f9..f8823b572600 2020-09-03 kjlubick@google.com Reland "[canvaskit] Change SkRects to be arrays, not objects." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: michaelludwig@google.com Change-Id: Icd68c3d5f343b5c89a103f85bf4953fc747a250b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392666Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/9e261b46a4f7..b44ca92f1cdd 2020-09-03 rharrison@chromium.org Roll 4 dependencies If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I8316ca08f28c378d68b008f4b0ae33db999f372a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392717Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1599112620-a8868b59128a8bce1a265b8451e03eb5caa355ad.profdata to chrome-win64-master-1599134104-920143836f5d72550f74eec8979ce216d37b0d87.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I6ca7bb831139297361522029ebbd3cf2e9007310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392667Reviewed-by:
-
Haiyang Pan authored
The bot pool looks sufficient for the extra traffic: http://shortn/_uTq3bMFtkS Bug: 997376 Change-Id: I19b127b71802c652137c94f54632395bf965f31c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387123Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#804294}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/72ab3787b4b4..ed9c15fc40f4 2020-09-03 wolfi@chromium.org Reland of "Fix context menu for issues banner" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1123455 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iffd0e2225e375059e693c39e2c0c7e6f9df0eb09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392671Reviewed-by:
-
K. Moon authored
Adds test fixture and some simple tests for BlinkUrlLoader. This class is still being implemented, so these tests mainly serve as examples. Also implements BlinkUrlLoader::GrantUniversalAccess(), to make the tests a little more interesting. BlinkUrlLoader::Client was changed to provide a WebAssociatedURLLoader instead of a WebLocalFrame. The former is easier to fake in unit tests. Bug: 1099022 Change-Id: I66a8132373cf61ab539321151253a20bbf7801b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391928 Commit-Queue: K. Moon <kmoon@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#804292}
-
Nicolas Ouellet-Payeur authored
This reverts commit 751a970a. Reason for revert: use-of-uninitialized-memory. crbug.com/1124805 Original change's description: > Make NGInlineNodeEditor to produce proper NGInlineItem and ShapeResult > > This patch changes |NGInlineNodeEditor| to produce |NGInlineItem| with > |ShapeResult| having same start and end offset for valid text painting. > > Before this patch, we see wrong painting, e.g. "AxXX" instead of "AxVX" > when insert "x" before "X" of "AVX". This is cause by kerning between > "A" and "V". > > Bug: 1121885 > Change-Id: I8242356ef6b865f2ad8b2e47de62d3200286e3f3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391701 > Commit-Queue: Koji Ishii <kojii@chromium.org> > Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> > Reviewed-by: Koji Ishii <kojii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#804257} TBR=yosin@chromium.org,tkent@chromium.org,kojii@chromium.org,ikilpatrick@chromium.org Change-Id: Iec0afbb96510b040fe0932000c74b2ccef0ebfe3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1121885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392770Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#804291}
-
Brandon Tolsch authored
This reverts commit 5afc937a. Reason for revert: compile failure on chromeos-amd64-generic-dbg https://ci.chromium.org/p/chromium/builders/ci/chromeos-amd64-generic-dbg/15678? Original change's description: > [CrOS PhoneHub] Add ConnectionMedium parameter to SecureChannelClient > > Additionally, update all existing clients to use the kBluetoothLowEnergy > client. > > Bug: 1106937 > Change-Id: I064abe879b2a74612ff4a096f9305eef25e5bd11 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391739 > Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> > Reviewed-by: James Vecore <vecore@google.com> > Cr-Commit-Position: refs/heads/master@{#804286} TBR=khorimoto@chromium.org,vecore@google.com Change-Id: I9c66c9f09594b4a0dec2b934d2ead408ef0d5967 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1106937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392713Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Cr-Commit-Position: refs/heads/master@{#804290}
-
ckitagawa authored
Sending these events is no longer required to paint out-of-lifecycle. When originally creating CapturePaintPreview, we would get a crash if the caller didn't send these events. However, they don't appear to be required anymore. The PhishingClassifier::ExtractVisualFeatures has been using CapturePaintPreview without sending these events successfully for a while. Unfortunately, I'm not an expert on the internals of Blink paint or printing so the reason this behavior has changed is unclear to me. That said, I've tested manually and via unit/integration tests and nothing has regressed as a result of removing these calls so I believe it is safe to do so. Bug: 1123437 Change-Id: I89819d0cf50bcb0000589e64ac497ca34fac5a36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392735 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#804289}
-
Andrew Grieve authored
Renames occurrences in //tools/grit as well as all spots that are transitively affected by the rename. Opts grit testdata out of PRESUBMIT.py checks since we don't need UI snapshots for strings in unit tests. Bug: 1097644 Change-Id: Ieca51c233447ded9d5943ad878354cbdaa1de78d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386392Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#804288}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1580d2fe0230..2e32d90fa6b3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC nicolaso@google.com,melandory@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: nicolaso@google.com,melandory@google.com Change-Id: I91a9f247c01682e3fee3af54322c0b7b573b14b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392672Reviewed-by:
-
Kyle Horimoto authored
Additionally, update all existing clients to use the kBluetoothLowEnergy client. Bug: 1106937 Change-Id: I064abe879b2a74612ff4a096f9305eef25e5bd11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391739 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#804286}
-
Becca Hughes authored
Adds caching for the frameless code. Will store the data in Media History and will clear every 24 hours or if the user signs in or out. BUG=1121360 Change-Id: I0ae9112cbd5dc272158f2e369d8807da02f0e2b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375701 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#804285}
-
Peter Boström authored
This hides |listener_| as an implementation detail, which follows style better. This is a prerequisite for replacing |listener_| with a base::RepeatingCallback. Bug: 772945 Change-Id: I875872b10a03b2349319102daa2541bc72253bf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392397 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
-
Kyle Horimoto authored
This CL adds a medium to the Mojo API, which allows clients to choose the connection medium. It also adds an EnumTraits definition for ConnectionMedium and updates tests to reflect this new parameter. Note that currently, the client code is still hard-coded to use the kBluetoothLowEnergy medium. A follow-up CL adds the ability for clients to specify the medium themselves. Bug: 1106937 Change-Id: Ic0fa8fe13d1402928c49557220f2e45135cadff0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390965 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
-
Ali Juma authored
Error pages for unsafe subframes are triggered by associating an UnsafeResource with the corresponding main frame item and reloading that item. This reload is detected in SafeBrowsingTabHelper::ShouldAllowRequest and an error decision is created. This detection logic was incorrectly also applied to subframe reloads, triggering a crash since these can happen while both the pending item and last committed item are null. More specifically, this can happen when a subframe triggers a reload using JavaScript, at the same time as the user performs a back/forward navigation to a restore_session URL. This CL fixes this logic by only applying it to main frame requests. Bug: 1124308 Change-Id: Idc485b836e88c41116f16b5b42a964585666d9cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392398Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#804282}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/598906885691..999c85ee8215 2020-09-03 courtneygo@google.com Correct PCI Device ID for Pixel1 & Pixel2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: I5ad90e5be9cb889c466153c503bff60dbc9a1e82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392668Reviewed-by:
-
Ben Kelly authored
Bug: 1124632,1035448 Change-Id: Id12d83787b2f3aa815737ec0b263641e0ed051e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392404Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#804280}
-
Dominik Röttsches authored
Follow-up to: https://chromium-review.googlesource.com/c/chromium/src/+/2375329 content::GetGlobalJavaInterfaces() requires to be scheduled on the UI thread. RenderProcessHostImpl already has a path to schedule bindings there. Move AndroidFontLookup binding to being scheduled on this thread. Testing in [1] shows that otherwise the DCHECK in GetGlobalJavaInterfaces() is hit when binding to the AndroidFontLookup service. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2387017 Bug: 1121589 Change-Id: I003b4884a2373f6fc152a616e44b6be829f9f05a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391240Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
-
