- 04 Oct, 2017 40 commits
-
-
Liquan (Max) Gu authored
Probe:v8Compile used to use null for execution context for the unavailability of execution context. Now the execution context has been available and the comment is no longer valid. Bug: 738495 Change-Id: Ic2c107e8c4f6ff22d470b56e16864c309d3d93b9 Reviewed-on: https://chromium-review.googlesource.com/701475Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Liquan Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#506562}
-
Jungshik Shin authored
The current script mixing policy (moderately restricitive) allows mixing of Latin-ASCII and one non-Latin script (unless the non-Latin script is Cyrillic or Greek). This CL tightens up the policy to block mixing of Latin-ASCII and a non-Latin script unless the non-Latin script is Chinese (Hanzi, Bopomofo), Japanese (Kanji, Hiragana, Katakana) or Korean (Hangul, Hanja). Major gTLDs (.net/.org/.com) do not allow the registration of a domain that has both Latin and a non-Latin script. The only exception is names with Latin + Chinese/Japanese/Korean scripts. The same is true of ccTLDs with IDNs. Given the above registration rules of major gTLDs and ccTLDs, allowing mixing of Latin and non-Latin other than CJK has no practical effect. In the meantime, domain names in TLDs with a laxer policy on script mixing would be subject to a potential spoofing attempt with the current moderately restrictive script mixing policy. To protect users from those risks, there are a few ad-hoc rules in place. By switching to highly restrictive those ad-hoc rules can be removed simplifying the IDN display policy implementation a bit. This is also coordinated with Mozilla. See https://bugzilla.mozilla.org/show_bug.cgi?id=1399939 . BUG=726950, 756226, 756456, 756735, 770465 TEST=components_unittests --gtest_filter=*IDN* Change-Id: Ib96d0d588f7fcda38ffa0ce59e98a5bd5b439116 Reviewed-on: https://chromium-review.googlesource.com/688825Reviewed-by:
Brett Wilson <brettw@chromium.org> Reviewed-by:
Lucas Garron <lgarron@chromium.org> Commit-Queue: Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#506561}
-
pdr authored
longer implemented. ObjectPaintProperties also had quite a few unnecessary includes that have been removed. ObjectPaintProperties: :ContentsProperties was declared but is no Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I8fa46a22866855d3e381d5b2493436f65abf620c Reviewed-on: https://chromium-review.googlesource.com/695810Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#506560}
-
Justin Schuh authored
This reverts commit ffc71c03. Reason for revert: Didn't improve the perf issue. Original change's description: > Reorder saturation calculation for ClampAddOp and ClampSupOp > > The order of operations changed in crrev.com/505494 with C++14 > constexpr optimizations. However, that change appears to have regressed > performance in some cases. So, this CL tweaks the code to match the > old structure and trigger the same compiler optimization heuristics. > > Bug: 770832 > Change-Id: I28f57ddf53825619eb73c9a92c663fc8463e16a7 > Reviewed-on: https://chromium-review.googlesource.com/696721 > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Commit-Queue: Justin Schuh <jschuh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#506078} TBR=jschuh@chromium.org,tsepez@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 770832 Change-Id: I076c93215b422e321ad4bf39a72bab144cc0195d Reviewed-on: https://chromium-review.googlesource.com/700775Reviewed-by:
Justin Schuh <jschuh@chromium.org> Commit-Queue: Justin Schuh <jschuh@chromium.org> Cr-Commit-Position: refs/heads/master@{#506559}
-
Dan Beam authored
This was needed when the "uber" page hosted multiple different iframes: <iframe src="chrome://settings"></iframe> <iframe src="chrome://extensions"></iframe> <iframe src="chrome://history"></iframe> <iframe src="chrome://about"></iframe> for code separation purposes. Because the "uber" page UI has been replaced and the replacements don't use <iframe>s, the code can be removed. R=creis@chromium.org BUG=683418,666525 Change-Id: I1ee60a3fe74af3bfc78503740cbccf134ea41bd8 Reviewed-on: https://chromium-review.googlesource.com/696718Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Dan Beam (no longer on Chrome) <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#506558}
-
Lukasz Anforowicz authored
Bug: 758075, 700535, 582522, 602497, 616905 Bug: 623268, 623265, 678492 Change-Id: I1bdc648c9aeb97cc1d16b0d8693d04e0c76030de Reviewed-on: https://chromium-review.googlesource.com/700983 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#506557}
-
Ned Nguyen authored
This reverts commit 95dd6223. Reason for revert: suspect causing compile failure BUG:771803 Original change's description: > Update V8 to version 6.3.257. > > Summary of changes available at: > https://chromium.googlesource.com/v8/v8/+log/22069a18..73d9476e > > Please follow these instructions for assigning/CC'ing issues: > https://github.com/v8/v8/wiki/Triaging%20issues > > Please close rolling in case of a roll revert: > https://v8-roll.appspot.com/ > This only works with a Google account. > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel > > TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org > > Change-Id: Ibdfcc894e660d187b6ea53cd1f8e482415911d12 > Reviewed-on: https://chromium-review.googlesource.com/700721 > Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> > Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> > Cr-Commit-Position: refs/heads/master@{#506538} TBR=v8-autoroll@chromium.org,machenbach@chromium.org,hablich@chromium.org,kozyatinskiy@chromium.org Change-Id: Idf91edeb3ff781fe302e2ca4ee72b1c800b87604 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/701408Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#506556}
-
Marijn Kruisselbrink authored
I believe this reduces the number of copies of the data to its minimum (of one copy from the SSV into a mojo message, and one copy from the mojo message into a SSV). In future CLs these same struct traits will also be used to optimize other postMessage APIs, and to ultimately have one place where serialization and deserialization of postMessage messages is done, making it easier to add things like Blob handles and possible shared array buffer handles to messages. Bug: 769907 Change-Id: Iae57c33dd9baa06fe8860b64a43846f2962e319a Reviewed-on: https://chromium-review.googlesource.com/667401Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#506555}
-
Hans Wennborg authored
TBR=wolenetz Bug: 771710 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Id2de82dfda1fc003ed3a8095ad000e7a21f3feb9 Reviewed-on: https://chromium-review.googlesource.com/701456 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#506554}
-
Daniel Cheng authored
Bug: 571784 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: Ied18e9d76e13028b7077a4ed3631f0a64ce8bdf6 Reviewed-on: https://chromium-review.googlesource.com/678058 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#506553}
-
Peter Boström authored
Permits browser_tests to look right on high-DPI monitors. This is especially important for the UI team as browser_tests can be invoked to summon dialogs that are not easy to get to, to see if they look right. Without high-DPI support Windows will upscale the normal-DPI version of Chromium and everything will look blurry. BUG=chromium:769430 Change-Id: Ia3cd12a7ec92f06302f51c234e047500ad35cefe Reviewed-on: https://chromium-review.googlesource.com/685653Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#506552}
-
smut authored
Bug: 756270 Change-Id: I7cc1dca169c2114a1f76f406134c54f34926d999 Reviewed-on: https://chromium-review.googlesource.com/699837Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#506551}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/3e3a78b68c31..985e86f297e8 $ git log 3e3a78b68..985e86f29 --date=short --no-merges --format='%ad %ae %s' 2017-10-04 dsinclair Remove friends from CPDF_TextObject 2017-10-04 dsinclair Remove CPDF_CMap friends 2017-10-04 dsinclair Make CPDF_TransferFunc members private 2017-10-04 thestig Explicitly return std::vector in CFDE_TextEditEngine. 2017-10-04 dsinclair Make CPDF_FontGlobals members private 2017-10-04 dsinclair Remove CFX_CRTFileAccess 2017-10-04 art-snake Fix Heap-use-after-free in CPDF_SecurityHandler::~CPDF_SecurityHandler. Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: If947a86c293e2167e5e5d5a6369fb5b4905bd03a Reviewed-on: https://chromium-review.googlesource.com/701406 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#506550}
-
mrefaat authored
* Converts SystemCookieStore to Async * Add Async functions to NSHTTPSystemCookieStore and keep the synchronous functions. * Move creation time management to systemCookieStore. * Update cookie_store_ios_presistent_unittest & cookie_store_ios_unittests to account for SystemCookieStore changes * (As CookieStoreIOS is using systemCookieStore internally). Another CL is in progress to add WKSystemCookieStore & unit_tests for systemCookieStore (to handle async methods) with template for both NSHTTP & WK systemCookieStore. Bug: 759229, 759227, 767948 Change-Id: If5e1fdb8d6424085d5212a3ea867968642db554f Reviewed-on: https://chromium-review.googlesource.com/700818Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#506549}
-
Yuwei Huang authored
-[RemotingClient rendererTicked] could be called right after the session is disconnected, which will call _gestureInterpreter->ProcessAnimations() when _gestureInterpreter is null and will crash the app. This CL fixes this issue by null-checking the interpreter before using it. Bug: 766698 Change-Id: Iac116f1d05e654b3b96579baa982f3652adb7642 Reviewed-on: https://chromium-review.googlesource.com/700320 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Scott Nichols <nicholss@chromium.org> Cr-Commit-Position: refs/heads/master@{#506548}
-
kylechar authored
Root CompositorFrameSinks don't use mojom::CompositorFrameSinkPtr, they use mojom::CompositorFrameSinkAssociatedPtr because it's paired with mojom::DisplayPrivateAssociatedPtr. In order to reuse ClientLayerTreeFrameSink for roots it needs to work with both. Bug: 770833 Change-Id: Iba0f020e787009d91213c071e2eb78a5a402a8c8 Reviewed-on: https://chromium-review.googlesource.com/700421Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#506547}
-
yucliu authored
The libvpx used for running test on Cast device doesn't support vp9 high bit depth, which will cause the test fail because the test stream is using profile 2. Given Cast doesn't create VpxVideoDecoder, it's safe to disable the test. BUG=internal b/65382374 TEST=media_unittests on the device. Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I047e18fea9c33dbfaf35b099f245265d6252c419 Reviewed-on: https://chromium-review.googlesource.com/696140Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#506546}
-
Xianzhu Wang authored
Bug: 771375 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I09800a720d35f82921226e76b5d5fe4442bb5d9c Reviewed-on: https://chromium-review.googlesource.com/699660Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#506545}
-
Elly Fong-Jones authored
When there is both a title and message, the padding isn't needed, since it is intended to visually take the place of the message. Bug: 771515 Change-Id: Ia29be37ae2f2049da254e4ea4874fb28f073961e Reviewed-on: https://chromium-review.googlesource.com/700400 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#506544}
-
Jonathan Metzman authored
Bug: 769582 Change-Id: I197d6ac177dd14e00faaa2ab0a54b72576197c9c Reviewed-on: https://chromium-review.googlesource.com/694641Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#506543}
-
Lucas Garron authored
Bug: 770292 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I1f3cb8d0d38503326b37adcebf3dee17856c82d4 Reviewed-on: https://chromium-review.googlesource.com/693376 Commit-Queue: Lucas Garron <lgarron@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#506542}
-
Lei Zhang authored
Also remove a redundant include. Change-Id: I2f8313263c5c8392d4d6fddb11889ba2bca9d389 Reviewed-on: https://chromium-review.googlesource.com/669685Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#506541}
-
bsheedy authored
Adds a new page for WebVR Telemetry tests meant for fill-rate testing. Also adds a new set of pages that is the same as xr.webvr.static, but with VSync alignment turned off and pages set to use a standardized render resolution across all devices. Also updates the WebVR samples repo hash to a more recent once since the standardized size option was not available in the previous version. Adds two tracing categories to the WebVR Telemetry tests that aren't used for metrics, but are useful for debugging regressions. Bug: Change-Id: Ife71aa419822a6b3d2859af2c7556749f1fa5b0b Reviewed-on: https://chromium-review.googlesource.com/692601Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#506540}
-
Emil A Eklund authored
This reverts r482803 (commit 6eddce94). Broke option hit testing when combining a select and flexbox sometimes. Bug: 771216 Original change's description: > Listbox SELECT: Do not force layout on OPTION element selection. > > Adjust scroll position in PaintLayerScrollableArea::UpdateAfterLayout(), instead of > Document::UpdateStyleAndLayoutIgnorePendingStylesheets() followed by scrolling. > > Bug: 556801, 620408 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: I2bd014b2f7950f1a51dbfa5067638013736d62dc > Reviewed-on: https://chromium-review.googlesource.com/542059 > Reviewed-by: Steve Kobes <skobes@chromium.org> > Commit-Queue: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#482803} TBR=skobes@chromium.org,tkent@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 556801, 620408 Change-Id: I6861c3ea1ab3aa4e7ee8365bc21e444a477608ca Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/699594 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#506539}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/22069a18..73d9476e Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: Ibdfcc894e660d187b6ea53cd1f8e482415911d12 Reviewed-on: https://chromium-review.googlesource.com/700721Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#506538}
-
Yuwei Huang authored
Previously if a host list fetch is not triggered by the user (refresh control) and fails, then the app will simply pop up a toast complaining about unavailable network and show nothing else. Pull-to-refresh doesn't work. This CL fixes this by providing a dialog-like view to allow user to retry in that case. Screenshot: https://drive.google.com/file/d/0BytzIZKeM8nBMmN3b3A0bUhoMFU/view?usp=sharing Bug: 771532 Change-Id: I64cb4015acc066322c3c6127b79b87d13cb06652 Reviewed-on: https://chromium-review.googlesource.com/700316Reviewed-by:
Scott Nichols <nicholss@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#506537}
-
Michael Moss authored
R=dpranke@chromium.org, phajdan.jr@chromium.org Change-Id: I2b5e743a9983788d5fdd1b5414286e7d9e134184 Reviewed-on: https://chromium-review.googlesource.com/700859Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#506536}
-
Yuwei Huang authored
The anchor is the height anchor so the constant should be 2x the margin. Bug: 770906 Change-Id: Ia82073246d8224791478781efc4e73e9f69f43f0 Reviewed-on: https://chromium-review.googlesource.com/701399Reviewed-by:
Scott Nichols <nicholss@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#506535}
-
Maks Orlovich authored
This is a reland of f9cc9601 Original change's description: > SimpleCache: Port (unsequenced) use of SequencedWorkerPool over to TaskScheduler > > This is what it does behind scenes in Chrome anyway, but always using the scheduler > in tests as well is helpful since it means a single TaskScheduler::FlushForTesting() call > rather than needing both TaskScheduler and SequencedWorkerPool versions of FlushForTesting() > as separate calls, which causes trouble when control jumps back and forth between the two. > > Bug: 766221 > Change-Id: Iab6a49cad86f1fd5a31c66c50d25e2962c538d53 > Reviewed-on: https://chromium-review.googlesource.com/697925 > Reviewed-by: Asanka Herath <asanka@chromium.org> > Reviewed-by: Scott Graham <scottmg@chromium.org> > Commit-Queue: Maks Orlovich <morlovich@chromium.org> > Cr-Commit-Position: refs/heads/master@{#506395} Bug: 766221 Change-Id: I6f76f26780f129499fe9916b717362b7a11e944f Reviewed-on: https://chromium-review.googlesource.com/700858Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#506534}
-
Mark Pearson authored
Bug: Change-Id: I8c0c222c1b498ee1a5d312affa330b38a742d242 Reviewed-on: https://chromium-review.googlesource.com/700857Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#506533}
-
Michael Giuffrida authored
If an extension cannot normally be disabled due to policy, but must be disabled for some reason internal to Chrome (e.g., corruption), then ExtensionService should clean the disable_reasons before disabling the extension. ExtensionService now removes disallowed disable reasons (like user action) when forced to disable an extension. (It is unusual to call ExtensionService::DisableExtension with multiple reasons, but it may be possible in some scenarios, perhaps when applying synced changes.) Test: ExtensionServiceTest.ManagementPolicyProhibitsDisable Change-Id: Ief9250413201ced5c68bb015575709fa3c2c0f45 Reviewed-on: https://chromium-review.googlesource.com/688454Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#506532}
-
Aaron Gable authored
R=dpranke@chromium.org Change-Id: I7a4bbd3dff59c0e399b288bffca972c3693d2cad Reviewed-on: https://chromium-review.googlesource.com/700986Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#506531}
-
Christopher Cameron authored
This is not ready to be used. Bug: 771740 Change-Id: Ia54361b4985711729b693ab13dce959924298cdf Reviewed-on: https://chromium-review.googlesource.com/701395Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: ccameron chromium <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#506530}
-
Hector Carmona authored
Bug: 764125 Change-Id: Id90db21dd9333565bee94da935df90639be082c6 Reviewed-on: https://chromium-review.googlesource.com/699567 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#506529}
-
Peter Kotwicz authored
As a result of https://chromium-review.googlesource.com/c/chromium/src/+/670359 the values of SHOW_SEARCH_ENGINE_PAGE in FirstRunActivity#mFreProperties and FirstRunFlowSequencer#shouldShowSearchEnginePage() are guaranteed to be the same. Bug=755646 Change-Id: I8a0eef268f34319af3c1129aec8066bee214582d Reviewed-on: https://chromium-review.googlesource.com/700426 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#506528}
-
Fabio Tirelo authored
Bug: Change-Id: Ib77d051ef0813cd63eafd92b578919f46982d26b Reviewed-on: https://chromium-review.googlesource.com/700992Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#506527}
-
Peter Wen authored
Update README for errorprone and add owners. Use a single jar to make maintenance easier and to pave the way to updates in the future. BUG=383646 Change-Id: Ib9e2900141baab73515c957bb274b7568ef3102a Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/700856 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#506526}
-
Lei Zhang authored
ResourceBundle became ui::ResourceBundle in r72038 but many callers still refer to it without the namespace. Change-Id: Id63635507b65d3d6ffe1fa3a779e189969030b11 Reviewed-on: https://chromium-review.googlesource.com/696138Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#506525}
-
Sergey Shekyan authored
Introduce NavigatorAutomationInformation interface that indicates if navigator is controlled by automation. It is guarded by RuntimeEnabled and exists only if AutomationControlled feature is set. https://w3c.github.io/webdriver/webdriver-spec.html#dom-navigatorautomationinformation Bug: 723900 Change-Id: If54295456a24fe8c86958c037263939ba3e44cb7 Reviewed-on: https://chromium-review.googlesource.com/665978 Commit-Queue: Sergey Shekyan <shekyan@gmail.com> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#506524}
-
Doug Steedman authored
I only verified one setting of a compile time boolean, breaking the code when it had the other setting. R=servolk@chromium.org, xhwang@chromium.org Bug: 771166 Change-Id: Id22d6dcfaed6e2ffb247000afd2b968756c05b0f Reviewed-on: https://chromium-review.googlesource.com/699056Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Doug Steedman <dougsteed@chromium.org> Cr-Commit-Position: refs/heads/master@{#506523}
-