- 23 Mar, 2018 40 commits
-
-
Bailey Berro authored
This change includes some cleanup, removing unused member variables and removing a reference to a bug that has been fixed. Bug: chromium:757625, chromium:796334 Change-Id: I6a5901f355050a47aeb59850e34ed463b79b6899 Reviewed-on: https://chromium-review.googlesource.com/978379Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#545494}
-
Julien Isorce authored
Note that this is for the ImageFactory interface. This is not for native gmbs and it is not related to --enable-native-gpu-memory-buffers flag. Bug: 584248 Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I67c9f95bbc2a5ee987cb78d7b90c279d7a1556c7 Reviewed-on: https://chromium-review.googlesource.com/970423Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: Julien Isorce <julien.isorce@chromium.org> Cr-Commit-Position: refs/heads/master@{#545493}
-
Raphael Kubo da Costa authored
Commit 115c9c57 ("Decouple fling booster from input_handler_proxy") added a conditional block to HandleInputEvent() with a seemingly bogus block that GCC warns about: ../../ui/events/blink/input_handler_proxy.cc: In member function ‘ui::InputHandlerProxy::EventDisposition ui::InputHandlerProxy::HandleInputEvent(const blink::WebInputEvent&)’: ../../ui/events/blink/input_handler_proxy.cc:384:33: warning: enum constant in boolean context [-Wint-in-bool-context] WebInputEvent::kGestureScrollUpdate) { ^~~~~~~~~~~~~~~~~~~~ ../../ui/events/blink/input_handler_proxy.cc:384:33: warning: enum constant in boolean context [-Wint-in-bool-context] Compare the enum values to event.GetType() like in the other blocks. Change-Id: I3f56888e40a0f8d6e10a6577ae7b4f36bab942e0 Reviewed-on: https://chromium-review.googlesource.com/978202Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#545492}
-
Matthew Cary authored
NoState Prefetch is a version of prerendering that should only run the preload scanner on a document. It appears that it's possible for parsing to occurr, however, when the document parser is torn down. This change prevents that from happening and adds a a DCHECK to make sure it doesn't. Bug: 823306 Change-Id: I541515e3f75d726b56f132c1c010367a4aa829d8 Reviewed-on: https://chromium-review.googlesource.com/973613 Commit-Queue: Matthew Cary <mattcary@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#545491}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2fc4f379. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/14367 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources TBR=danyao No-Export: true Change-Id: I15668772a2240f0162a72f59845092e53a4921c5 Reviewed-on: https://chromium-review.googlesource.com/978043 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#545490}
-
Mike Wasserman authored
Add PlatformDisplayMirror to represent mirroring destination displays. Have ws::DisplayManager own and manage the mirrors as directed by Ash. Add DisplayManager::OnFirstSurfaceActivation helper to notify mirrors. Add FrameGenerator::scale_and_center_ behavior for mirror displays. Minor cleanup and invert a broken conditional in ws::Display. Fix a PlatformDisplay test, add a CreatePlatformWindow helper. Remove an OzonePlatform accessor, I'll fix the test separately. TODO: Get Mash cursor mirroring enabled (via cursor compositing?) Bug: 806318,732987 Test: Ctrl+Shift+M toggles display mirroring in --enable-features=Mash Change-Id: I43453a2b76c397a31ebdd8fae7c8fda6399fa4bd Reviewed-on: https://chromium-review.googlesource.com/775653 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#545489}
-
Charlie Harrison authored
This change prepares us to run components_perftests on the perf waterfall. It does a few things: - Moves the tests to run as an isolated script - Moves the target out of chromium_gtests and into suites run by isolated_scripts - Updates BUILD files to support the perf test runner Bug: 648992 Change-Id: I898203dacc2b89754d2681952819b3104d9b95e9 Reviewed-on: https://chromium-review.googlesource.com/971163Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#545488}
-
Raphael Kubo da Costa authored
The code is currently failing to build with: ../../chrome/browser/media/router/mojo/media_router_mojo_metrics_unittest.cc:29:40: error: parameter ‘histogram_provider1’ includes reference to array of unknown bound ‘const char []’ const char (&histogram_provider2)[]) { ^ ../../chrome/browser/media/router/mojo/media_router_mojo_metrics_unittest.cc:29:40: error: parameter ‘histogram_provider2’ includes reference to array of unknown bound ‘const char []’ Fix it by using a less exotic syntax for the parameters: we just need two char arrays here. Change-Id: I3e17f233d6ad6f4c7c24df3e5dad64b32637ab25 Reviewed-on: https://chromium-review.googlesource.com/977967Reviewed-by:mark a. foltz <mfoltz@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#545487}
-
Andrew Grieve authored
This works around a bug in the multidex support library where if multiple apks are searched for secondary dexes, the caching logic breaks and files are re-extracted every time. Bug: 824523 Change-Id: I29c23fa33077428e00e2752d16a36949e8bc517c Reviewed-on: https://chromium-review.googlesource.com/977060 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#545486}
-
Adam Langley authored
Now that we are filtering inadequately batched attestation certificates, the consent really is about make, model, and batch number of the device being attested. TBR=srahim BUG=793985 Change-Id: Ib912bb850215960160a754ce2ae4db32706ae7ca Reviewed-on: https://chromium-review.googlesource.com/972374Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#545485}
-
mark a. foltz authored
This reverts commit 904a5dd4. Reason for revert: <INSERT REASONING HERE> Original change's description: > [chrome.dial] Remove chrome.dial. > > Media Router has launched in-browser discovery of DIAL devices in M63, and > removed usage of chrome.dial from the Media Router component extension. > > This removes the API from Chrome as there are no more users. > > Bug: 769348 > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: I9bde034fb42ffb05aef1a8d3666775d83cbd1337 > Reviewed-on: https://chromium-review.googlesource.com/964800 > Commit-Queue: mark a. foltz <mfoltz@chromium.org> > Reviewed-by: mark a. foltz <mfoltz@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> > Reviewed-by: Adam Parker <amp@chromium.org> > Reviewed-by: Ken Rockot <rockot@chromium.org> > Cr-Commit-Position: refs/heads/master@{#545170} TBR=lazyboy@chromium.org,mfoltz@chromium.org,isherman@chromium.org,rockot@chromium.org,amp@chromium.org Change-Id: I036449eae45fae20e3f60f43a71d9dc4e709a3b4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 769348 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/978481Reviewed-by:
-
crystallambert@chromium.org authored
Extensions management page has a new UI. Current screen shots of page are outdated. This CL updates the screen shots in the Linux Hosting to match the new UI. Bug: 824766 Change-Id: I11784c064835ce44229bb28b1117ef6e92390c86 Reviewed-on: https://chromium-review.googlesource.com/976820Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Crystal Lambert <crystallambert@chromium.org> Cr-Commit-Position: refs/heads/master@{#545483}
-
Eugene But authored
Background NSURLSession never fails due to connectivity errors. Instead that session waits for connectivity up to timeoutIntervalForResource timeout which defaults to 1 week. This CL changes the timeout to 60 seconds. Bug: 824018 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I841fc4580fa6bc6724198d825bb1736b91027fc4 Reviewed-on: https://chromium-review.googlesource.com/976623Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#545482}
-
Ian Vollick authored
With this change we show indicators describing what is being captured when entering VR presentation. It also includes a revamp of the "press app button to exit" UI. Bug: 824187 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ic302b8196d081044aa92da655553984d4da22074 Reviewed-on: https://chromium-review.googlesource.com/973687 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#545481}
-
Rouslan Solomakhin authored
This patch adds a use counter for paymentManager.instruments.set(). Setting an instrument is what makes a service worker into a payment handler. Bug: 661608 Change-Id: I86acc1aa3e07120a4470d8972232501e229ff78d Reviewed-on: https://chromium-review.googlesource.com/975833Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#545480}
-
Donn Denman authored
Adds two new features for Contextual Search ML Tap Suppression with Ranker. They are: 1) font-size: the size of the font in points. 2) portion-of-element: aka "in the flow", this is a decile that describes the portion of the element text represented by the word tapped. Large values are likely navigational elements. Adds two new tap suppression heuristics (for manual testing, etc): 1) ShortTextRunSuppression that suppresses taps on text in an element with a short text run. 2) SmallTextSuppression that suppresses taps on small fonts -- the effective size on the screen. Adds new features to the Ranker whitelist, and adds histograms for the tap suppression heuristics. Updates ukm.xml for these new features, approved in go/ukm-cs-3. BUG=754862 Change-Id: I8fa2109cb2141daf3596545ead7883a2103cbbe5 Reviewed-on: https://chromium-review.googlesource.com/952762Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Philippe Hamel <hamelphi@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#545479}
-
Daniele Castagna authored
This CL enables alpha blending at scanout for the primary plane. In this way chromecast will be able to punch a hole in the primary plane and show content underneath. Note that on platform using legacy pageflip we'll still be scanning out without alpha blending (crrev.com/c/964984). Bug: 821944, b/74997524 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I654935dc630f7a9f6cb4717cd574a21a2749c442 Reviewed-on: https://chromium-review.googlesource.com/976961Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#545478}
-
Xianzhu Wang authored
Idea from pdr@'s review comments in crrev.com/c/973808. - Extract StartEffect(), StartCombinedClip() and StartSingleClip() from the big functions SwitchToEffect() and SwitchToClip(). - Rename PopClips() to EndClips(). - Removed PopClips() from PopToParentEffect() and let the callers call PopClips(), and renamed PopToParentEffect() to EndEffect(). Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I7a4afcbbfbc88d22dbd25243853fea104ffe0734 Reviewed-on: https://chromium-review.googlesource.com/976947Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#545477}
-
Zhenyao Mo authored
not only at GPU command buffer level (state tracking cache), but also at driver level. Otherwise since we might delay the actual call of glDeleteBuffers, then on the driver side, bindings are still active, and inconsistent with the expectation. Certain calls after that, for example, TexImage, or ReadPixels, will be incorrectly affected by such inconsistency. BUG=822976 TEST=gpu_unittests, test case from the bug R=kbr@chromium.org,piman@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I737a2dcfd35bec3b7a36a0971a8437ea4e046ef8 Reviewed-on: https://chromium-review.googlesource.com/974463Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#545476}
-
https://chromium.googlesource.com/angle/angle.git/+log/d779f6a98524..49cef9a52181 $ git log d779f6a98..49cef9a52 --date=short --no-merges --format='%ad %ae %s' 2018-03-21 lucferron Vulkan: Support of A8 textures Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I53758838e777a2812642c65016313cd34ce955c0 Reviewed-on: https://chromium-review.googlesource.com/977899 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#545475}
-
https://pdfium.googlesource.com/pdfium.git/+log/aaed69853428..3ae75c2f2e57 $ git log aaed69853..3ae75c2f2 --date=short --no-merges --format='%ad %ae %s' 2018-03-23 thestig Fix IWYU errors in pdfium_test_write_helper.cc. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ic91795d152fe209b5e2645db9bb5c35c9d1d0568 Reviewed-on: https://chromium-review.googlesource.com/977897 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#545474}
-
Emily Hanley authored
TBR=ashleymarie@chromium.org NOTRY=true Bug: 825234 Change-Id: I655c56cd7d8b775005bff2d606da737fe6dbba80 Reviewed-on: https://chromium-review.googlesource.com/978376Reviewed-by:
-
Filip Gorski authored
* Adds a bridge for contextual suggestions with method signatures * Adds a cluster type that is going to be used to group contextual suggestions Bug: 824182 Change-Id: I0b8a44cd438b8e27b378d52a15e44b8fd3060044 Reviewed-on: https://chromium-review.googlesource.com/971306 Commit-Queue: Filip Gorski <fgorski@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Patrick Noland <pnoland@google.com> Cr-Commit-Position: refs/heads/master@{#545472}
-
chrome://connection-helpCarlos IL authored
Change-Id: I68fc2bcebd93fe91cf06c0c9da1a94974c7a545b Reviewed-on: https://chromium-review.googlesource.com/976537Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#545471}
-
Alexander Timin authored
Allow (and recommend) using base::CreateSequencedTaskRunner for non-main thread computations in blink (e.g. in platform/blob). Support SequencedTaskRunner instead of SingleThreadTaskRunner in PostCrossThreadTask. R=gab@chromium.org,haraken@chromium.org CC=mek@chromium.org Change-Id: I371f2fa976ef0e9eb36a2b31ad016aa46dba57ed Reviewed-on: https://chromium-review.googlesource.com/977925Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#545470}
-
https://webrtc.googlesource.com/src.git/+log/29e7bee3308d..06e363a6e608 $ git log 29e7bee33..06e363a6e --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:None,chromium:801925 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic393e84eccf47403f6854ff5fc5ad73538c1d504 Reviewed-on: https://chromium-review.googlesource.com/977890 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#545469}
-
Andrew Grieve authored
Change-Id: Ib1b039c662f63378572468cb26bf75006c92ca79 Reviewed-on: https://chromium-review.googlesource.com/978367Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#545468}
-
Fredrik Söderquist authored
When an element has incoming references that are not in the layout tree (like an element animated by [multiple] SMIL elements), the overhead of the hash set insert/erase can be noticable (like for instance in balls_svg_animation.html.) Bug: 661598, 769774, 823473 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I8a5879186dabd5e071f708ac953b8f1e91b62847 Reviewed-on: https://chromium-review.googlesource.com/978213Reviewed-by:
-
Chandan Padhi authored
This CL provides support for these constraints in mediaDevices.getSupportedConstraints(). Bug: 823831 Change-Id: I17e251b5433ad6cb23e92655cfdaf114e9b23002 Reviewed-on: https://chromium-review.googlesource.com/977801Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Chandan Padhi <c.padhi@samsung.com> Cr-Commit-Position: refs/heads/master@{#545466}
-
edchin authored
Previously, a crash was hiding the issue this CL fixes. After closing the last incognito tab, the incognito TabModel is destroyed and a new TabModel is set on the incognito TabGridMediator. When the user either taps on a tab or the "new tab" button, |-showActiveTab| is called. This method was previously using the old TabModel (which is nil), instead of the new one that is set on the incognito TabGridMediator. This CL makes sure that |self.incognitoModel| is always up-to-date with the latest model used in the incognito TabGridMediator. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I47f4dc08a3bb01d1b47865b7abd49853cf1973c2 Reviewed-on: https://chromium-review.googlesource.com/977301 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#545465}
-
Tibor Goldschwendt authored
Currently, the native UI does not align with the repositioned content quad and is visible when the exit prompt shows. This CL fixes that. Bug: 824812 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I12f546cb7c5fd4aba2d501443cd0205f59d714cd Reviewed-on: https://chromium-review.googlesource.com/976182 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#545464}
-
Lukasz Anforowicz authored
Planned modifications to SpareRenderProcessHostManager (see https://crrev.com/c/963405) require making sure that BrowserContext::NotifyWillBeDestroyed is called before destroying the context - otherwise some RenderProcessHost(s) (e.g. the spare one) can survive longer than a BrowserContext leading to UaF when the RenderProcessHost(s) are eventually destroyed later (potentially in a different unit test :-). This CL makes sure that NotifyWillBeDestroyed will be called from the destructor of TestBrowserContext (and from a few other subclasses of BrowserContext as appropriate). Destroying the BrowserContext expands the scope of the requirement to properly emulate browser threads in the tests by using TestBrowserThreadBundle in a few more places. Bug: 808114 Change-Id: I60b959e4969c39bededd6de7a3a51a8fdf12e387 Tbr: hidehiko@chromium.org Tbr: juliatuttle@chromium.org Tbr: rouslan@chromium.org Reviewed-on: https://chromium-review.googlesource.com/964804 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#545463}
-
Francois Doray authored
A window with a hidden parent is not painted on the screen. Calling Hide() or Show() on it can't immediately affect occlusion and should therefore not cause occlusion states to be recomputed. This optimization is useful for when we hide a WebContentsViewAura. When we hide a WebContentsViewAura, Hide() is called on child RenderWidgetHostViewAura. There is no reason to recompute occlusion when that happens. Bug: 668690 Change-Id: Id02c195aa5e74313fdc790e365c19337615fcf2b Reviewed-on: https://chromium-review.googlesource.com/970848 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#545462}
-
Charlie Harrison authored
A previous patch updated the ActivationState in the AsyncDocumentSubresourceFilter, but neglected to forward this update to the internal DocumentSubresourceFilter for load state filtering. Bug: 809504 Change-Id: I53d637c35e6bcfc868d0941c1abadc3627c05749 Reviewed-on: https://chromium-review.googlesource.com/976529 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#545461}
-
Michael Lippautz authored
The goal of this patch is to simplify handling of ephemeron callbacks and put the right abstraction on top of the uses. On ToT we deduplicate by storing a bit on HashTable and add two callbacks (iteration, done) to two CallbackStacks. This results in overhead of CallbackStack segments of (2048 entries, 2 words) 8KB of memory during GC with a fast check based on a bit in the datastructure. However, this version of a HashTable is only used very rarely with mostly DEFINE_STATIC_LOCAL, so always yields in singletons. Local benchmarking showed ~5-10 instances on major websites. Hence, the simplified design of - Deduplicate by using a hashmap - Store iteration callback in the hashmap to avoid 4KB of CallbackStack - Avoid iteration done callback completely - Use simple ephemeron iteration based on two data structures to avoid problems with iteration during insertion Bug: chromium:757440 Change-Id: I241c6f19fdc9a5f8dfbfdd7902608261744014eb Reviewed-on: https://chromium-review.googlesource.com/977827 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Philip Rogers authored
This patch removes a check for SPV175 that was added in [1]. It is not safe to call LayoutFlowThread::FragmentsBoundingBox if |column_sets_invalidated_|, regardless of SPV175/SPV2. column_sets_invalidated_ is a bit that tracks whether multi_column_set_list_ is up-to-date. In LayoutMultiColumnFlowThread::ColumnSetAtBlockOffset, multi_column_set_list_ is used (and there's a DCHECK that it's valid). FragmentsBoundingBox can call ColumnSetAtBlockOffset through the following: LayoutFlowThread::FragmentsBoundingBox -> LayoutMultiColumnSet::FragmentsBoundingBox -> MultiColumnFragmentainerGroup::FragmentsBoundingBox -> MultiColumnFragmentainerGroup::FlowThreadTranslationAtOffset -> LayoutMultiColumnFlowThread::FlowThreadTranslationAtOffset -> LayoutMultiColumnFlowThread::ColumnSetAtBlockOffset [1] https://codereview.chromium.org/1337233002 Bug: 823127 Change-Id: I2a6e848f4f8b449b2bf4f40cd5d70c4f801f10f6 Reviewed-on: https://chromium-review.googlesource.com/977024Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#545459}
-
Stephen Chenney authored
R=dcheng@chromium.org Bug: 790944,820163,793715,796804,799707,823345 Change-Id: I6daa6aedd8ccff792b99c228d85800dbd2dd3ec2 Reviewed-on: https://chromium-review.googlesource.com/973467Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#545458}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ce913b499c4c..31a3eb064ea3 $ git log ce913b499..31a3eb064 --date=short --no-merges --format='%ad %ae %s' 2018-03-22 achuith deploy_chrome: Finesse --board requirements. Created with: roll-dep src/third_party/chromite BUG=chromium:823996 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I769462f350386abdb114b740c59231cbfaf81da1 Reviewed-on: https://chromium-review.googlesource.com/977887 Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#545457}
-
Raphael Kubo da Costa authored
Commit ac1a8082 ("aura: changes when WindowPort::OnDidChangeTransform() is called") removed all uses of |old_transform| in the method above, but did not stop defining the variable itself. Change-Id: I4dc0fe3f113bfb0a4e3026216fdb363b2dd4d6e6 Reviewed-on: https://chromium-review.googlesource.com/978183Reviewed-by:
-
Sheriff-o-matic authored
On Win7 the test has been observed to also fail E.g. https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%28dbg%29%281%29/67059 Change-Id: I1333d2f86def289561752ab31909422bc080d3b4 No-Try: True No-Presubmit: True Bug: 626703 Reviewed-on: https://chromium-review.googlesource.com/978365Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#545455}
-
