GitLab

This patch performs multiple tasks:
  - Modify the protocol that generates a ManagedDisplayInfo to use zoom
    factor instead of ui scale. When display zoom feature is disabled,
    it reverts back to the old string format.
  - Add a DCHECK in computing the effective Ui scale to ensure that it
    is 1 when display zoom is enabled.
  - Update all tests that fail due to this assertion. This is done
    mostly by creating a new test class with the display zoom feature
    disabled. OTOH, the tests that we want to keep in display zoom
    mode are modified to fit the assertion. We want to make sure that
    both ui scale and display zoom works for a few milestones before we
    completely deprecate and remove ui scale.

Bug: 823922
Change-Id: I9bab4f6cb0884242d5f9427ba004f4c677835b64
Component: Managed Display Info, ui scale, display zoom
Reviewed-on: https://chromium-review.googlesource.com/1099476Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567878}

The renderers need to talk to the CVMS server (OpenCL compiler), which
then outputs codesigned blobs that can be loaded in to the process. This
is required for drawing the form controls.

In addition, another Metal bundle location (in /Library) is permitted.

Bug: 850021, 847518
Change-Id: I67106972baf5fc55fccd8f7deff3f47cbea076b5
Reviewed-on: https://chromium-review.googlesource.com/1103127Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567877}

For Milestone 4 of the Partial Data Project, Chrome should explicitly request that the user confirms their cardholder name (prepopulated with the name from their Google Account) when name is missing and the user does not have a Google Payments account.

This CL is actually going to be extremely similar to the original CVC fix flow, which was removed in https://chromium-review.googlesource.com/c/chromium/src/+/1034103.  Feel free to cross-reference these CLs, as most everything I took out in that CL is simply getting put back in this one, except this time it's name instead of CVC.  Surprise!

Bug: 848955
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I08e94c1a16b7b1da403ea5a8f26d1e2d423c210e
Reviewed-on: https://chromium-review.googlesource.com/1083880
Commit-Queue: Jared Saul <jsaul@google.com>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Rachel Blum <groby@chromium.org>
Reviewed-by: John Wu <jzw@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567876}

Bug: 835492
Change-Id: I172ab5075523f86eca85b4013dc0b77a82650dad
Reviewed-on: https://chromium-review.googlesource.com/1103543Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567875}

Promise for MediaCapabilities::decodingInfo() is resolved by
blink::WebMediaCapabilitiesQueryCallbacks which is passed to
WebMediaCapabilitiesClientImpl::DecodingInfo in //media/blink,
which, in some cases, means to resolve it in the callback
of an async mojo call. However, if the connections is lost meanwhile,
neither OnSuccess nor OnError is called and, in the result,
the promise resolver remains in pending state.

This patch makes sure the OnError is called when mojo connection
gets dropped.

Bug: 847211
Change-Id: I018792c56a3d3074b042e4318d9a8b85b3c16360
Reviewed-on: https://chromium-review.googlesource.com/1075308Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567874}

Suppresses log spam about "native service" failures when the service in
question is content_renderer. This is because, unlike for any other
service in the system, hitting the native service launcher codepath for
content_renderer is simply an innocuous side effect of some raciness
between browser features and renderer termination.

Bug: None
Change-Id: I8f73c7ecbe167c160e9df0f3aac3214063997d39
Reviewed-on: https://chromium-review.googlesource.com/1103155Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567873}

This reverts commit a5e2fb1d.

Reason for revert: Causes massive memory leaks when the logic is triggered. See https://bugs.chromium.org/p/chromium/issues/detail?id=851506#c26

Original change's description:
> Show favicon even if there's no enough space
>
> In this case, we will do:
> 1. Align favicon ceter.
> 2. Clip favicon to the tab's shape with 1 DIP padding.
>
> In order to do this, a mask layer is set to icon view.
> When there's a attention icon, tab shaped mask and
> circular mask will be combined and then set.
>
> Bug: 813637
> Change-Id: Idbadfcec44ef61d8a2213df4a87b533885e18a25
> Reviewed-on: https://chromium-review.googlesource.com/938875
> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> Commit-Queue: SangWoo Ko <sangwoo108@gmail.com>
> Cr-Commit-Position: refs/heads/master@{#541323}

TBR=ellyjones@chromium.org,sangwoo108@gmail.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 813637, 851506
Change-Id: I0712eeb68e84db335ead345c4aa6e39600a85c4b
Reviewed-on: https://chromium-review.googlesource.com/1103677
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567872}

Previously, the process id was just the last-bound namespace process.
With site-isolation turned on, multiple processes bind to the same
namespace, so when 'old' ones opened up their storage area, they would
check the wrong process id and fail.

This stores the process id as the 'Context' on the binding set.

Bug: 848281
Change-Id: I5d4a082494f618c361f0ce845a641679330841fe
Reviewed-on: https://chromium-review.googlesource.com/1103553Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567871}

For top level client windows, the cursor is stored in
WmNativeWidgetAura. For embed roots, it's stored in ServerWindow.
CompoundEventFilter will retrieve the stored cursor while
handling mouse events by using aura::WindowDelegate::GetCursor.
Depending on the target of the mouse event, the WindowDelegate
will be either WindowDelegateImpl (which retrieves it from
ServerWindow or delegates to the top level's delegate) or
WmNativeWidgetAura (which returns its own copy of the cursor).

To test, hover over input field of KSV via:
1. chrome --keyboard-shortcut-viewer-app  Ctrl+Alt+/
or
2. ash_shell_with_content

Bug: 837705
Change-Id: I247b41937aada5a9b161eb469d8230d06890a63b
Reviewed-on: https://chromium-review.googlesource.com/1068661
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567870}

BUG=762641
TBR=stevenjb@google.com

Change-Id: If37d7d24e9e5431a03a5e9e533dae38c8fd2f82c
Reviewed-on: https://chromium-review.googlesource.com/1103526Reviewed-by: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org>
Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567869}

This patch reduces preprocessed size of paint_layer_scrollable_area.h
from 6.3 MB to 3.8 MB, avoiding transitive inclusion of chrome_client.h
and float_clip_rect.h with tricks similar to crrev.com/567547.  (Since
crrev.com/567732, more source files include PLSA's header.)

Bug: 242216,823365
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I969088b6f75b80d3279b0beb3cc701eb16e6ed6a
Reviewed-on: https://chromium-review.googlesource.com/1103235Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567868}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=govind@chromium.org

Change-Id: I1e42ea03a697e3b78a146e9b0b996f075f676083
Reviewed-on: https://chromium-review.googlesource.com/1103528Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567867}

Bug: 829244
Change-Id: Idc426e6f0963a30340569c2d2835266d325f290e
Reviewed-on: https://chromium-review.googlesource.com/1079719Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567866}

The new location bar implementation requires that the UIRefreshPhase1
experiment also be enabled.  When UIRefreshPhase1 is disabled, also
disable RefreshLocationBar.

BUG=853408

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ia0266255cd59ca7487d766928846439a2ac8eed0
Reviewed-on: https://chromium-review.googlesource.com/1103524
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567865}

TBR=martiniss@chromium.org

Bug: 790641
Change-Id: I21d8ef56ad34ab60016edaf421c4dc0a5a0da26a
Reviewed-on: https://chromium-review.googlesource.com/1103658Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567864}

BUG=853360
TBR=robliao@chromium.org
NOTRY=true

Change-Id: Iac99d5fa87605d7a01cd2e2d232d4c154525446b
Reviewed-on: https://chromium-review.googlesource.com/1103312
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567863}

This test case tests that a session will not be migrated to a broken socket when path degrading is detected with connection migration turning on.

Bug: 843299
Change-Id: Ie5227808423b1dc9feed1344d85067a939bef133
Reviewed-on: https://chromium-review.googlesource.com/1101935Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567862}

Fix test setup in MigrateOnWriteErrorWithNetworkMadeDefaultQueuedLater to test the network disconnected notification.

Bug: 818259, 843299
Change-Id: I961c780dabc7628a598b1cab03231307fb705891
Reviewed-on: https://chromium-review.googlesource.com/1102988
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567861}

replace std::find() with base::containsValue()
at components/payments

Bug: 561800
Change-Id: Id11c844383e792b608eaa2e0bec6a389821e927c
Reviewed-on: https://chromium-review.googlesource.com/1102283Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com>
Cr-Commit-Position: refs/heads/master@{#567860}

We want to shut off most of the chromium.webkit builders
and merge their tests into the main builders, but currently
the tryserver.blink builders mirror them, and the tryserver.blink
builders need to stick around so we can generate baselines.

This CL adds a bunch of dummy builder entries on chromium.fyi so
that we can switch the tryservers to mirror them, instead.

Then we'll be free to delete the chromium.webkit builders.

This CL also adds some placeholder entries to mb_config.pyl so
that we can rename the tryserver.blink bots to match the new
naming scheme.

R=hinoka@chromium.org
BUG=853040
NOTRY=true

Change-Id: I2e10feb13473a149a74a69915fcac0d80ec6cd28
Reviewed-on: https://chromium-review.googlesource.com/1101999
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567859}

This CL replaces the usages of 'blacklist' and 'whitelist' in the Declarative
Net Request code. It introduces the following changes to the public API:
  - RuleActionType blacklist -> RuleActionType block
  - RuleActionType whitelist -> RuleActionType allow
  - MAX_NUMBER_OF_WHITELISTED_PAGES -> MAX_NUMBER_OF_ALLOWED_PAGES
  - addWhitelistedPages -> addAllowedPages
  - removeWhitelistedPages -> removeAllowedPages
  - getWhitelistedPages -> getAllowedPages

As a result of this change, existing extensions using the Declarative Net
Request API will need to be updated. Usages of these terms in enums and
preference keys are kept as-is.

BUG=850774, 842296

Change-Id: Id4aaac5ec3123fd56a1591e22025a455d7cb6941
Reviewed-on: https://chromium-review.googlesource.com/1094141
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567858}

For migrated LUCI builders.

Bug: 840631
TBR: dpapad, sky
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I8bd70004c4d90f96cac332ff2548b6d87a7f4d05
Reviewed-on: https://chromium-review.googlesource.com/1102907
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567857}

TBR=robliao@chromium.org
BUG=853360
NOTRY=true

Change-Id: Id50cc9e6fc255f2bdafad60468540209075db893
Reviewed-on: https://chromium-review.googlesource.com/1103615Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567856}

This patch records UMA metrics for any change to the internal display's
zoom factor. It does not record temporary zoom factor changes by
debouncing signals that are within a small interval and only allowing
the last signal to pass through.

Bug: 849894
Change-Id: I2dc7d31e9910855ca4a59834a56d8322641a9f5b
Component: Display Manager, UMA, Zoom
Reviewed-on: https://chromium-review.googlesource.com/1093270Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567855}

This was missed when switching from audio master AV sync to video master
AV sync.

When setting playback rate, we only set the rate of the master, and have
the AV sync detect that and adjust the follower.

TODO is to proactively tell AvSync that we changed the rate, so it
doesn't have to discover that on its own.

Bug: b/110230181, b/78193238
Test: On device
Change-Id: I734030a68e5d670ec2c35b966f931e687630458a
Reviewed-on: https://chromium-review.googlesource.com/1101997
Commit-Queue: Mina Almasry <almasrymina@chromium.org>
Reviewed-by: Sergey Volk <servolk@chromium.org>
Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567854}

* Fix to broken host tool "fvm verify" tested (outcome: works).
* SDK method rename; "zx_get_startup_handle" to "zx_take_startup_handle".

Bug: 852876,707030
Change-Id: Ib635c807ae92dedc76c65c34ab9d3829e8a7e5c0
Reviewed-on: https://chromium-review.googlesource.com/1102834Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567853}

I noticed this while reviewing some other CL.

Bug: none
Change-Id: Iab610a1e10079bc8e448eb392b2ce1229fe24fab
Reviewed-on: https://chromium-review.googlesource.com/1101574
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567852}

* Only run one configuration of EXPECT_QUIC_BUG tests
* Shrink timeouts in EndToEndTest.PreSharedKey timeout tests

Speed up net_unitttests by 15%

Bug: 806109
Change-Id: If98cbfaf300b044f01f8a1d91ec96584e43aaef5
Reviewed-on: https://chromium-review.googlesource.com/1103393Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567851}

Only CastCommandLineHelper will initialize the CommandLine
singleton, and the CommandLine.isInitialized() == true should be
a required post-condition of calling
initCommandLineWithSavedArgs().

Bug: Internal b/110021629
Test: cast_base_junit_tests
Test: cast_shell_junit_tests
Test: set command line args and install Cast apk on Android TV
Merge-With: eureka-internal/180061
Change-Id: Ieb65dba995df360d39f2793945b603156544c3aa
Reviewed-on: https://chromium-review.googlesource.com/1103446
Commit-Queue: Simeon Anfinrud <sanfin@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567850}

Heuristics for country doesn't need to check for the
value to accept the previously detected fields.
Same case for company.
The wrong output test corrected.

Bug: 853220
Change-Id: I2a271de3bc7046f0407a855fe3a9f442bed533e9
Reviewed-on: https://chromium-review.googlesource.com/1102561
Commit-Queue: Parastoo Geranmayeh <parastoog@google.com>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567849}

https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/8fd2b32dce02..7d1c88ce94

2018-06-08 kerrnel@chromium.org cryptohome: Add MountGuestEx dbus function to header.
2018-06-12 kerrnel@chromium.org cryptohome: Remove usused DoAutomaticFreeDiskSpaceControl
2018-06-12 lasoren@chromium.org Constant for bootstrapping Mojo IPC connection.
2018-06-08 amoylan@chromium.org Add ML service constant for Mojo pipe token
2018-06-07 kerrnel@chromium.org cryptohome: Add RemoveEx method and remove unused Remove.
2018-06-05 kerrnel@chromium.org cryptohome: Add MigrateKeyRequest protobuf.
2018-06-04 phweiss@google.com shill: Add new Manager property AlwaysOnVpnPackage

The TBR is an inherited +1 from CL:1099136 on cryptohome_util.cc.

Tbr: hashimoto@chromium.org
Bug: b:74589757
Bug: 842718, 799739, 211405
Change-Id: I07182858e3a96b700f335366620b9fd601c827fe
Reviewed-on: https://chromium-review.googlesource.com/1102979Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Greg Kerr <kerrnel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567848}

* Libfuzz builders use a lot of bots, let scheduler handle it.
* remove ios-webview

Bug: 840631
Change-Id: I4d7491a76863f82986c641c76118933838e755dd
Reviewed-on: https://chromium-review.googlesource.com/1103548Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567847}

Swiping up on a short/wide pdf no longer hides the toolbar.

Also disable synchronization for testSmallWidePDFScroll on iOS12,
but it's likely something larger is going on.

Bug: 852393
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Iab556064447cfe54cb498678d192a45f36b55a1a
Reviewed-on: https://chromium-review.googlesource.com/1100337
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567846}

This CL makes the edit-as-html editor remain open on "blur"
when there is no relatedTarget. This allows switching windows
without closing the editor.

Screenshot: https://imgur.com/a/FT4GxFM

Bug: 805462
Change-Id: I46f0660f7e25a34bc75be79e179f7666f5a50525
Reviewed-on: https://chromium-review.googlesource.com/1101828Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567845}

In order to allow more than one touch filter to delay the reporting of
touches, make the existing filter keep track of its own filter state.

BUG=b:69232663
TEST=manual testing with filters enabled

Change-Id: Idfc68fea22574becd920cdd599dd2e90e19bd04d
Reviewed-on: https://chromium-review.googlesource.com/1093584Reviewed-by: Michael Spang <spang@chromium.org>
Commit-Queue: Sean O'Brien <seobrien@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567844}

Bug: 847639
Change-Id: I8dd0c17453e3dc19b4101468eed73d55264448fb
Reviewed-on: https://chromium-review.googlesource.com/1098472
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567843}

This CL adds ApiCompatibilityUtils.requireNonNull method that behaves
identically to Objects.requireNonNull added in API level 19 (see
https://developer.android.com/reference/java/util/Objects). This method
does what the name says - it ensures that passed object is not null.

Bug: None
Change-Id: Ia9a1b32f34569208f2eea67fc998fe1d3fca613d
Reviewed-on: https://chromium-review.googlesource.com/1097404
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567842}

R=dmazzoni@chromium.org

Change-Id: Iaaf42a68afee1a624cdc30d3eccc92b53fc7c136
Reviewed-on: https://chromium-review.googlesource.com/1098195
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567841}

No change to production logic.

This fixes a bad test and reenables it. In the test, the server and test
were deadlocked: the server was waiting for the test to finish, while
the test couldn't finish because the server wouldn't serve the second
page.

Instead, let the server complete the request shortly after we invoke
stopLoading(). This unblocks the server, but still guarantees the load
will still be provisional at the time we invoke stopLoading().

  --num_retries=0 --break-on-failure --repeat=1000 \
  -f ClientOnPageFinishedTest#testCalledAfterRedirectedUrlIsOverridden

Bug: 683384
Test: run_webview_instrumentation_test_apk \
Change-Id: I21be548fb1fd57724351fd372cc78d00062489b2
Reviewed-on: https://chromium-review.googlesource.com/1100547Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567840}

A couple of cleanups I stumbled upon while reading the code:
- struct DecodeRequest can be made internal.
- unique_ptr<> doesn't need to be made const& (strange pattern).
- A few consts and initializing structs with = {} (ISO memset),
 using implicit initialization [1].
- Removed unnecessary |weak_this_|.

All in all, less lines of code :-)

TBR=dcastagna@chromium.org

[1] http://en.cppreference.com/w/c/language/struct_initialization

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: If1a4e781abfa7ae96b85a6d621f5c96d4effb162
Reviewed-on: https://chromium-review.googlesource.com/1100001Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567839}