- 09 May, 2018 40 commits
-
-
Erik Chen authored
There was an uninitialized read in test-only code. Not sure why this wasn't caught by MSAN prior to my original CL. This reland fixes the bug. > This CL is a refactor with no intended behavior change. Change-Id: Idae277fa5bad01cb0cf911f9acc3dacdbb7d12b2 Bug: 832879 Reviewed-on: https://chromium-review.googlesource.com/1048593Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#557345}
-
Simon Pelchat authored
R=bustamante@chromium.org Bug: 787869 Change-Id: Ib9b87b2cbbbc6b7cbb774accfd567f69cfcd58ce Reviewed-on: https://chromium-review.googlesource.com/1048726 Commit-Queue: Simon Pelchat <spelchat@google.com> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#557344}
-
Theresa authored
BUG=839537 Change-Id: Ib99e42f1940f1c58ed73ab96aa4f4a1fbb751466 Reviewed-on: https://chromium-review.googlesource.com/1050428 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#557343}
-
Olga Sharonova authored
Frame observer is registered right away on each frame initialization. Why: Sink cache lives on the main task runner, but also accepts sink requests from the media task runner (media pipeline). So the sinks can be cashed on 2 different threads. However, frame observers can be registered on the main renderer thread only. Because of the above, on-demand observer registration (i.e. registering an observer only when a sink is cached for a frame) is racy: navigation can happen before the observer is registered. BUG=836420 Change-Id: I9377201d93ae5c12e4fe05c8f23514b68bfddbe1 Reviewed-on: https://chromium-review.googlesource.com/1050127 Commit-Queue: Olga Sharonova <olka@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#557342}
-
Becky Zhou authored
Bug: 829377 Change-Id: I8034adcb1b1fd9620b10db6d8655bfaac4c8045f Reviewed-on: https://chromium-review.googlesource.com/1050967Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#557341}
-
Stephen Lanham authored
This is known to fail on Cast CQ infra. Disable the new test added here: https://chromium-review.googlesource.com/1044971 Bug: Internal b/67975693 Test: CQ Change-Id: I0b07b96f69bbad9a4289f1c58eed3485082cfd9c Reviewed-on: https://chromium-review.googlesource.com/1053211Reviewed-by:
Bailey Forrest <bcf@chromium.org> Reviewed-by:
Stephen Lanham <slan@chromium.org> Commit-Queue: Stephen Lanham <slan@chromium.org> Cr-Commit-Position: refs/heads/master@{#557340}
-
Corentin Wallez authored
BUG=angleproject:1874 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Icc5d832f7500b76bc8b7a4dfe9a99d2c61ac0b05 Reviewed-on: https://chromium-review.googlesource.com/655801 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#557339}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/97c110860758..ef4f7b4dc1e4 $ git log 97c110860..ef4f7b4dc --date=short --no-merges --format='%ad %ae %s' 2018-05-09 robertphillips Revert "Fix clipping of SkMatrixImageFilter input" 2018-05-09 reed rewrite while to for loop to avoid last increment 2018-05-09 reed check for focaldata failure 2018-05-09 reed make sure we don't set level-of-detail to zero 2018-05-09 csmartdalton ccpr: Clean up GrCoverageCountingPathRenderer 2018-05-09 bsalomon Approximate conics as quads in GrAAHairlinePathRenderer when fp32 not supported 2018-05-09 bungeman complexclip gm to clip when saving layer with bounds. 2018-05-09 halcanary Revert "Revert "SkAdvancedTypefaceMetrics: factor out GlyphToUnicode"" 2018-05-08 brianosman Add fPreferExternalImagesOverES3 to GrContextOptions 2018-05-09 robertphillips Fix clipping of SkMatrixImageFilter input 2018-05-09 fmalita [skottie] Json cleanup pass 2018-05-09 bungeman Remove SK_IGNORE_MASK_FILTER_GLYPH_FIX. Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: I01c010bf92cf5dae30e90545dc9e41c6c1c42e1b Reviewed-on: https://chromium-review.googlesource.com/1052817Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557338}
-
Esmael El-Moslimany authored
Bug: 836303 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia90801ff9d33b92d31abea4b3f65ad189d8cb72c Reviewed-on: https://chromium-review.googlesource.com/1044764Reviewed-by:
Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#557337}
-
Tom Anderson authored
LLVM has been updated in the ChromeOS sysroot, so it should be safe to enable thin archives now. BUG=801925 Change-Id: I7dc2492937a26adc4f9af61abccbdb086e3a38cb Reviewed-on: https://chromium-review.googlesource.com/1050980Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#557336}
-
Ryan Landay authored
This CL adds logging for a sparse UMA histogram Tabs.TabOffsetOfSwitch to record how many tabs forward or backward users move when switching tabs in the Android tab switcher. This will help us measure usability in experiments. Bug: 828224 Change-Id: Id7e5bb2431b30408688dbfeb02ee762e8c3facf5 Reviewed-on: https://chromium-review.googlesource.com/1050936 Commit-Queue: Ryan Landay <rlanday@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#557335}
-
Avi Drissman authored
Modern web pages have ways of getting the user's attention that are less distracting than a blue dot. In addition, aggressively adding blue dots to every pinned tab title change is distracting users. Remove this behavior. (Blue dots remain for tabs that need attention due to dialogs.) BUG=482776,817878 Change-Id: Ic68baa88c5d87b3022cefaf4c771da7c64b85818 Reviewed-on: https://chromium-review.googlesource.com/1052855 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#557334}
-
Ramya Nagarajan authored
Bug: 827404 Change-Id: I628949a3e1f8aac41ac7c76f90cf7ba0108179b5 Reviewed-on: https://chromium-review.googlesource.com/1052491Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#557333}
-
Victor Vasiliev authored
Merge internal change: 195304248 R=rch@chromium.org Change-Id: Ie06ce21c31157270ea0b3a71ce3dc64816c2761b Reviewed-on: https://chromium-review.googlesource.com/1045999 Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#557332}
-
Zhiling Huang authored
Bug: 790520 Change-Id: I048d774652366744e26b84aa2a4faa8b22567105 Reviewed-on: https://chromium-review.googlesource.com/1053090Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Zhiling Huang <hzl@chromium.org> Cr-Commit-Position: refs/heads/master@{#557331}
-
Jordy Greenblatt authored
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5475899ad089e653e7df6729d641035cc6c9ef2d Reviewed-on: https://chromium-review.googlesource.com/1045499 Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#557330}
-
Ria Jiang authored
HitTestAggregator and HitTestQuery were using shared memory for hit-test data. For OOP-D, HitTestAggregator is in Viz and HitTestQuery is in browser; so HTA can write to the memory HTQ is reading from before it receives the IPC to switch. We can modify the current shared memory scheme to fix that problem but it's more risky. This CL changes it to send hit-test data through IPC from HTA to HTQ for OOP-D, which is less risky and a good starting point. mojom related changes for AggregatedHitTestRegion is in https://chromium-review.googlesource.com/c/chromium/src/+/1044783. Bug: 803548 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Iae146594da608ffc1392834ffe663c8ea9b00729 Reviewed-on: https://chromium-review.googlesource.com/1044887Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Ria Jiang <riajiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#557329}
-
Hiroshige Hayashizaki authored
To CL applies the compile options defined in tools/grit/grit_rule.gni to media_controls_resource_loader.cc by adding a deps to a grit rule, and removes pragmas in the .cc file. Bug: 839236 Change-Id: I7838d9775e091b10d5a9369c7fce176aced7cefb Reviewed-on: https://chromium-review.googlesource.com/1043206Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#557328}
-
Kent Tamura authored
This affects |blink_tool.py pretty-diff| and |check_blink_style.py|. * blink_tool.py pretty-diff It shows renamed files as renaming diff instead of deleting-and-adding files. * check_blink_style.py It checked style against whole renamed files. After this CL, it checks only modified lines of renamed files. Change-Id: I99146c2483e96154a588087db77b12baac944cfd Reviewed-on: https://chromium-review.googlesource.com/1049468Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#557327}
-
https://pdfium.googlesource.com/pdfium.git/+log/575ceba24463..a44b288c4132 $ git log 575ceba24..a44b288c4 --date=short --no-merges --format='%ad %ae %s' 2018-05-09 thestig Add constants for PDF 1.7 spec, table 7.13. 2018-05-09 thestig Break backcolor code out of CPDF_RenderStatus::LoadSMask(). Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I887503b6a48e1afb0f464b553cc6686713a0c10a Reviewed-on: https://chromium-review.googlesource.com/1052924Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557326}
-
Kurt Horimoto authored
When the browser navigates to a new page, in-progress scrolls are cancelled. However, same-document navigations can occur mid-scroll. Bug: none Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I3dd0c8d6e8b570052ffe43676708b46643e52c41 Reviewed-on: https://chromium-review.googlesource.com/1053051 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#557325}
-
Justin Novosad authored
This change is on the path to replacing OffscreenCanvasResourceProvider with CanvasResourceProvider BUG=788439 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I34637343dbd7693cbbfe099061b18a8cfd2094b7 Reviewed-on: https://chromium-review.googlesource.com/1052923Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#557324}
-
Koji Ishii authored
This patch adds the initial support for the 'text-transform' property in ::first-line style. The common usage is just to apply it to ::first-line and it is supported in this patch. Edge cases are not supported in this patch yet, such as: 1. Base style has non-initial 'text-transform' value and ::first-line has different value. 2. When the 'text-transform' changes the length of text. 3. When only parts of ::first-line has 'text-transform' or needs reshaping; e.g., ::first-line span { text-transform: uppercase; } Supporting these cases need more code, but can probably be built on top of this change. Bug: 636993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ieb92f5a483ce12d4fe4d94deb3efb82e81546403 Reviewed-on: https://chromium-review.googlesource.com/1051066Reviewed-by:Emil A Eklund <eae@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#557323}
-
Robert Kroeger authored
This reverts commit f4544427. Reason for revert: speculative fix for https://bugs.chromium.org/p/chromium/issues/detail?id=840988&can=2&start=0&num=100&q=owner%3Ame&colspec=ID%20Pri%20M%20Stars%20ReleaseBlock%20Component%20Status%20Owner%20Summary%20OS%20Modified&groupby=&sort=&hotlist_id= Original change's description: > Call blink::WebMemoryCoordinator::OnPurgeMemory in RenderThreadImpl::ReleaseFreeMemory > > |WebMemoryCoordinator::OnPurgeMemory| has been only called in |RenderThreadImpl::OnPurgeMemory|, > and |RenderThreadImpl::OnPurgeMemory| is only able to be called by |base::MemoryCoordinatorClient|. > But, if there is no performance degradation, it would be good to purge used memory as much as > possible. |RenderThreadImpl::ReleaseFreeMemory| has been more called than |RenderThreadImpl::OnPurgeMemory| > from some callers. So we can free up more memory if we move |WebMemoryCoordinator::OnPurgeMemory| > from |RenderThreadImpl::OnPurgeMemory| to |RenderThreadImpl::ReleaseFreeMemory|. > > TEST: Covered RenderThreadImplDiscardableMemoryBrowserTest.ReleaseFreeMemory > > Bug: None > Change-Id: I225401bcd18f236265305aaf5eaf4b4219d9cde4 > Reviewed-on: https://chromium-review.googlesource.com/1049414 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> > Cr-Commit-Position: refs/heads/master@{#556728} TBR=haraken@chromium.org,gyuyoung.kim@lge.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: None Change-Id: I26910af177818011bf1aa00efeacb9bb8058f108 Reviewed-on: https://chromium-review.googlesource.com/1052987Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#557322}
-
Rintaro Kuroiwa authored
- Log the video decoder names before initialization. - Logging for D3D11 decoder initialization failures. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I9cbae9e430fe6afa1ed6d1135e4efb1bd0986ea2 Reviewed-on: https://chromium-review.googlesource.com/1052813 Commit-Queue: Rintaro Kuroiwa <rkuroiwa@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#557321}
-
Bill Orr authored
Change-Id: I76eed7cf354d7f55e5409035941b76100d772b96 Reviewed-on: https://chromium-review.googlesource.com/1053093Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#557320}
-
Chris Harrelson authored
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I928521be331c73c5e25a9e1441d0d9e6196a39f3 Reviewed-on: https://chromium-review.googlesource.com/1053107Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#557319}
-
Philip Rogers authored
This reverts commit bea7337b. Reason for revert: Might have caused https://crbug.com/841536 Original change's description: > [CI] Use LFV::VisibleContentSize() over LFV::VisibleContentRect().Size() > > This is a small cleanup to use the size directly, if available, rather > than creating the rect and then just getting the size. Found while > working on https://crbug.com/838111 > > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: I678fc42b76bcda168b8e5f68fd9c357ad57dca42 > Reviewed-on: https://chromium-review.googlesource.com/1050969 > Commit-Queue: Philip Rogers <pdr@chromium.org> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557229} TBR=wangxianzhu@chromium.org,pdr@chromium.org Change-Id: Idd9c9621607afb909622119c2ef2f301342ff51d No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/1053148Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#557318}
-
Ben Pastene authored
Bug: 732531 Change-Id: Ic29cd0a7032f707509797229d995a4a4e28b2582 Reviewed-on: https://chromium-review.googlesource.com/1052915Reviewed-by:
-
Matthew Jones authored
This is a reland of 76b70285 This patch removes the tablet specific toolbar swipe behavior that was previously causing the tests to fail. Original change's description: > Attempt to deflake TabsTest#testToolbarSwipePrevTab* > > This patch updated the toolbar swipe tests to not depend on criteria > helpers and operate on about:blank pages rather than the ntp. Most > importantly, this fixes an issue where we assert tab selection before > waiting for the callback. > > Bug: 813584 > Change-Id: I1e743291add6398bc3eebc06c03c6c69cefc21f9 > Reviewed-on: https://chromium-review.googlesource.com/1044538 > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Commit-Queue: Matthew Jones <mdjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556240} Bug: 813584 Change-Id: I08407a14b69137bee8673fa196c76012448eb6cc Reviewed-on: https://chromium-review.googlesource.com/1050387Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
-
Hiroshige Hayashizaki authored
To simplify code structure in V8ScriptRunner, this CL flattens/inlines code around SelectCompileFunction. This CL shouldn't change the behavior. Bug: 841466 Change-Id: I5ec313b451c25417c8efdbd100edd46be5a002c1 Reviewed-on: https://chromium-review.googlesource.com/1045622 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Reviewed-by:
-
Theresa authored
* Rename the flag/description * Move buttons above most likely tiles and polish UX * Add ablation arm BUG=836308 Change-Id: I42cc24c5c7e0a50edf0c4f197055c588ed083e80 Reviewed-on: https://chromium-review.googlesource.com/1047202 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
-
Vikas Soni authored
Seperate out TextureOwner interface and its implementation SurfaceTextureGLOwner from a single file. Bug : 838725 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I2d9d0aab0326aed9acd6800ad45a9f333a56cf93 Reviewed-on: https://chromium-review.googlesource.com/1045905 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#557313}
-
Fredrik Hubinette authored
Neutralize error messages and fire no progress events until media metadata has been loaded for media loaded from cross-origin locations. Bug: 828265, 826187 Change-Id: Iaf15ef38676403687d6a913cbdc84f2d70a6f5c6 Reviewed-on: https://chromium-review.googlesource.com/1015794Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
-
Martin Kreichgauer authored
This adds the FidoAuthenticator interface, which defines the basic methods from the WebAuthn authenticator model (MakeCredential and GetAssertion). FidoRequestHandler is changed to hold a map of FidoAuthenticator instances, rather than a map of FidoTasks. FidoTask and FidoDevice are moved behind a concrete FidoAuthenticator subclass called FidoDeviceAuthenticator (but remain unchanged otherwise). This allows for FidoAuthenticators that are backed by platform APIs rather than a detachable physical device. This is a purely structural change. No functional changes intended. Change-Id: Id158db5801ac4556066a1a88136d7a720b137e1b Reviewed-on: https://chromium-review.googlesource.com/1045892 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#557311}
-
dpapad authored
This is in preparation of updating cr-toggle's style for MD refresh, as well as removing paper-toggle-button from third_party/polymer. Bug: 768073 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I52690906a1f73778358cde1da605e762a44b4f78 Reviewed-on: https://chromium-review.googlesource.com/1051046Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#557310}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/7aaefdbb734f..6cf26f13cd9f $ git log 7aaefdbb7..6cf26f13c --date=short --no-merges --format='%ad %ae %s' 2018-05-02 bmgordon build_stages: Consolidate chroot reuse logic Created with: roll-dep src/third_party/chromite BUG=chromium:829665 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ide45e5f3e4d1f488100a9c9fa73554cf19c0565d Reviewed-on: https://chromium-review.googlesource.com/1052822Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557309}
-
Maks Orlovich authored
It turns out that JS -> base::Value conversion there produces doubles while the code expected it to produce ints, like desktop/android do. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I18c255597250956fbd1a224986fb806b3bb9fa11 Reviewed-on: https://chromium-review.googlesource.com/1052090 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#557308}
-
Nick Harper authored
This reverts commit 3c79bfc0. In addition to the original CL bd3d1ea0, this includes a fix to the crash when relaunching after changing about:flags. Bug: 841006 Change-Id: I04c82074bb83da7ba5854b783862ec689d7a36e0 Reviewed-on: https://chromium-review.googlesource.com/1050976Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
-
Robert Kroeger authored
This reverts commit c0e58526. Reason for revert: speculative attempt to fix http://crbug.com/840988 Original change's description: > Update V8 to version 6.8.184.1 (cherry-pick). > > Summary of changes available at: > https://chromium.googlesource.com/v8/v8/+log/e3f3bcb2..9ef8a461 > > Please follow these instructions for assigning/CC'ing issues: > https://github.com/v8/v8/wiki/Triaging%20issues > > Please close rolling in case of a roll revert: > https://v8-roll.appspot.com/ > This only works with a Google account. > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel > > TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org > > Change-Id: I1c65bbcf6ce40050b917cb288293b9226d1563ab > Reviewed-on: https://chromium-review.googlesource.com/1049367 > Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> > Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556739} TBR=v8-autoroll@chromium.org,machenbach@chromium.org,hablich@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I7108d2aecebef1e7ca0355bca571e85d1cc01499 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1052527 Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
-
