- 19 Mar, 2020 40 commits
-
-
Joel Hockey authored
System Web Apps use a domain such as chrome-untrusted://terminal which should not be shown to users. The concept of a domain for System Web Apps is not so useful, and should not be required for users to identify or differentiate between tabs in a System Web App browser. Bug: 1060863 Change-Id: Ib0fe04b6d6d982162c89d6599522da8669d2553e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108218 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#751613}
-
nancy authored
Add "Learn more" link for the PWAs unisntall dialog per UX deck: https://docs.google.com/presentation/d/1jfyLf21naKDQwe07jkhgqtI8Fd2Z88W93l1F1q3FyhY/edit#slide=id.g6e0ab3bcaa_0_0 https://docs.google.com/presentation/d/1jfyLf21naKDQwe07jkhgqtI8Fd2Z88W93l1F1q3FyhY/edit#slide=id.g7d0934dbfa_0_0 Mock dialog: https://photos.app.goo.gl/AtQfZr9RYKH5HsMi9 Move OnDialogCancelled and OnDialogAccepted to keep the consistent order as the definition in *.h file. BUG=1010303 Change-Id: I5c955940643c3753e68fca6aa9a3d07aed226615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106986 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#751612}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f955fb455585..dadeffa315e7 git log f955fb455585..dadeffa315e7 --date=short --first-parent --format='%ad %ae %s' 2020-03-19 jmadill@chromium.org Capture/Replay: Fix stride in compressed texture caching. Created with: gclient setdep -r src/third_party/angle@dadeffa315e7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: courtneygo@google.com Change-Id: I715e200fe27e3d8d5d20e5e819444a84862f6740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109265Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751611}
-
Ionel Popescu authored
The issue was caused by the fact that the color-picker style wasn't added when constructing the color-suggestion-picker popup. Added a test to validate the change and prevent future regressions. Bug: 1062501 Change-Id: Iaf561f33e18bf2f26a8f87ffd1fb549118e02764 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108091 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#751610}
-
Alan Cutter authored
Bug: 1007786 Change-Id: Idd730b35e0cead74b10ff758c1339f18c5a6e754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105187 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#751609}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I43f82417b9f711be4d69560cb6c15c8766d51b7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109211Reviewed-by:
-
Karandeep Bhatia authored
Currently the single static indexed ruleset for an extension is stored at $extension_path/_metadata/generated_indexed_ruleset. Since we plan to support multiple static rulesets, we need to store multiple indexed rulesets. This CL changes the static indexed ruleset location to $extension_path/_metadata/generated_indexed_rulesets/_ruleset$ruleset_id. This helps us move the code away from the assumption of a single static ruleset. As a result of this existing extensions with a DNR ruleset will initially fail to load the DNR ruleset. However the re-indexing logic should step in and ensure the extension works seamlessly. A side-effect for these extensions is that the old indexed ruleset will remain on disk. However this is ok since the API is still on beta and doesn't have significant usage yet. Furthermore, we do periodically clean up extension folders after extension updates. BUG=754526 Change-Id: Id3bd6c1e25fde4ceb1a34f9f84c67bfa340790ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094626 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#751607}
-
Kenichi Ishibashi authored
This CL adds a constructor of MainScriptResponse which takes URLResponseHead. Tests and ServiceWorkerNewScriptLoader use the new constructor to reduce HttpResponseInfo use in service worker codebase. Bug: 1060076 Change-Id: I884efa7c1e15789ef46fdab0998136c0f9695d94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105183 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#751606}
-
Yury Semikhatsky authored
When browser shutdown started pipe file descriptors are closed on the UI thread while there may be outstanding reads and writes on parallel threads. If such read/write operations fail error messages will only be written to the console if pipe shutdown has not begun yet. Bug: none Change-Id: I57e9b6c7f2921335cc2bb1f5289bd9347bba1f68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108825Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Yury Semikhatsky <yurys@chromium.org> Cr-Commit-Position: refs/heads/master@{#751605}
-
https://crbug.com/1006814Fergal Daly authored
Record whether we are currently in the middle of dispatching handlers for process-death as this is a stronger contender for how this is occurring. Bug: 1006814 Change-Id: I0d269c250a870c25088e92c4b207e7fa647f0bbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106987Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Auto-Submit: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#751604}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1574c49c4f09..33997f3d931a git log 1574c49c4f09..33997f3d931a --date=short --first-parent --format='%ad %ae %s' 2020-03-19 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@33997f3d931a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4a625cd533f41470a171f9027adbb58d9af9c0a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108499Reviewed-by:
-
Hiroshige Hayashizaki authored
When `spec.src.json` is modified, the order of subtests were changed and thus unncessesary diffs were generated, even if the subtest contents are not modified. This CL sorts subtests to avoid such diffs. Generated files will be modified in https://chromium-review.googlesource.com/c/chromium/src/+/2109511 Bug: 906850 Change-Id: Ic17d8122b0b5139e89ec2b4423511b933941ad65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109570Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Eriko Kurimoto <elkurin@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#751602}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8413a03c394c..df670f0bed9e git log 8413a03c394c..df670f0bed9e --date=short --first-parent --format='%ad %ae %s' 2020-03-19 fancl@chromium.org Remove the Sheriff model and related infra Created with: gclient setdep -r src/third_party/catapult@df670f0bed9e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1050891 Tbr: oysteine@google.com Change-Id: Idbf9ee38cffc3bd3b4ba4af57c9fbc11ff59cd1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108926Reviewed-by:
-
Theresa Wellington authored
The KitKat CQ bot is no longer running chrome_public_test_apk, so goldens weren't updated with in crrev.com/c/2096101. KitKat was removed as an expected version for RenderTestRule in crrev.com/c/2108912, but existing render tests with KitKat goldens still either need to be updated or have their KitKat goldens removed. BUG=1060030 TBR=wychen@chromium.org Change-Id: I3d00e00f98e4957e9ca52994ed463a3cbba26044 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108574Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#751600}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fd01ffa2b6de..f9f2f702a988 Created with: gclient setdep -r src-internal@f9f2f702a988 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I168b71781b69506a4559cfa308c95f839181498e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107513Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751599}
-
Satoshi Niwa authored
chromeos_channel value for ARC container is also extracted in the same way. (GetChromeOsChannelFromFile() in arc_setup_util.cc) This fixes the issue that "unknown" value is set for testimage (b/151289109) BUG=b:151289109 TEST="android-sh -c getprop" and check ro.boot.chromeos_channel is "testimage" Change-Id: I7d84dab2adb665f56689cb26c2cd20082d64272c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108306 Commit-Queue: Satoshi Niwa <niwa@chromium.org> Auto-Submit: Satoshi Niwa <niwa@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#751598}
-
K. Moon authored
TestDocumentLoader currently loads the entire test PDF file as soon as PDFiumEngine calls DocumentLoader::RequestData(0, 1). This change adds a new TestDocumentLoader::SimulateLoadData(uint32_t) method that allows a test to control how quickly the document loads. A future test will take advantage of this to put the PDFiumEngine into a partially-loaded state. A test can request the TestDocumentLoader by calling PDFiumTestBase's InitializeEngineWithoutLoading() method instead of InitializeEngine(). This change also removes the DocumentLoader::SetDocumentSize() method, which only was used internally by DocumentLoaderImpl anyway. Bug: 1051548 Change-Id: Ib5256aa70c468284e0f01964b409f2a85a9a066a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067692 Commit-Queue: K Moon <kmoon@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#751597}
-
Henry Jian authored
This reverts commit 3c12c3b0. Reason for revert: it breaks chrome AR, see https://crbug.com/1062910 Original change's description: > [Android] Move linker from Trichrome library to chrome > > Also, move linker loadable module inclusion from rules.gni to > chrome_public_apk_tmpl.gni > > Bug:1032062 > > Change-Id: Idfd0116321ee23b6cf8e6628553f10c569bb6b58 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091645 > Commit-Queue: Henry Jian <hzjian@google.com> > Reviewed-by: Peter Wen <wnwen@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#749845} TBR=wnwen@chromium.org,agrieve@chromium.org,hzjian@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1032062,1062910 Change-Id: I26aa95ed864410b9a721ecdc6243441fc5721e33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109252Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#751596}
-
Anand K. Mistry authored
Bug: None Change-Id: I28c0fe028f906807628e62c84a380e293b18fc9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105688Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#751595}
-
Ken Rockot authored
Bug: 1059389 Change-Id: I6fa56c1cdd6bfbc92b6954a05da232bcf61ecec8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108617Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
-
Nicholas Hollingum authored
This is a reland of 9b8ade13 Original change's description: > Crostini Upgrader: Do not proceed if user cancels backup > > Previously if the user cancelled the backup, we would proceed with the > upgrade as though the user had elected not to backup at all. > > With this change, the flow will instead return to the initial screen > when the user cancels, rather than proceed. > > Bug: 1061203 > Change-Id: I7be99a2c7a6caa4b5fd143def5ba0c6f9b4d5004 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102935 > Reviewed-by: Nicholas Verne <nverne@chromium.org> > Commit-Queue: Nic Hollingum <hollingum@google.com> > Cr-Commit-Position: refs/heads/master@{#750833} Bug: 1061203 Change-Id: I983fc82b74db8cba6f2d2acf6997c8d0a2a25bc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109431Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#751593}
-
Kelvin Jiang authored
Bug: 947591 Change-Id: I06b2ff6505ed0f1efd326df2a73cac8ee3ec35bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081363 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#751592}
-
Nancy Wang authored
This reverts commit e3e24fb5. Reason for revert: <INSERT REASONING HERE> Tree is close because of this CL: https://ci.chromium.org/p/chromium/builders/ci/linux-archive-rel/24482?blamelist=1#blamelist-tab Original change's description: > [CrOS setting] Move OS routes into os_settings_routes.js > > Before this CL, routes for both browser and OS where in routes.js file. > This CL removes routes for chromeOS to a new file os_settings_routes.js > also updates references to SettingsRoutes to OSSettingsRoutes in all > chromeOS files. > > Fixed:967861 > > Change-Id: Ib3aea093fad90188699e7325632dc93610336f99 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090794 > Reviewed-by: Rebekah Potter <rbpotter@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> > Cr-Commit-Position: refs/heads/master@{#751587} TBR=khorimoto@chromium.org,rbpotter@chromium.org,hsuregan@chromium.org,tjohnsonkanu@google.com Change-Id: I58359fa710ace42d2dc3c184d080263df8de1f51 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108452Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#751591}
-
Christopher Lam authored
This CL adds specificity to generated CSS variables. This is needed to override the variables defined in paper-styles/color.html and shared_vars_css.html. This will allow us remove deprecated colors and ensure that clashing color names will resolve to cros_palette colors. Bug: 1062154 Change-Id: I87fbd3013daae8f6553f3129ed44d27be51b18b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106041Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#751590}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d9ebe015405d..93bcaae44524 git log d9ebe015405d..93bcaae44524 --date=short --first-parent --format='%ad %ae %s' 2020-03-19 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 1386d9f5..d69529f5 (751294:751530) Created with: gclient setdep -r src/third_party/webrtc@93bcaae44524 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Icfc054cf27b77adb1fe05b4c5da2abf797261f5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108924Reviewed-by:
-
Mei Liang authored
This CL enables TabSelectionEditor to show a List for low-end devices. Change-Id: Ie60c1e7ddcda09c2f32e23c4de52be7e642e09e0 Bug: 1042889 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103313 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#751588}
-
Nnamdi Theodore Johnson-Kanu authored
Before this CL, routes for both browser and OS where in routes.js file. This CL removes routes for chromeOS to a new file os_settings_routes.js also updates references to SettingsRoutes to OSSettingsRoutes in all chromeOS files. Fixed:967861 Change-Id: Ib3aea093fad90188699e7325632dc93610336f99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090794Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Cr-Commit-Position: refs/heads/master@{#751587}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: Ibfa72892603bf293ad5777213cc02fe1e4bfb2ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107917Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751586}
-
Hitoshi Yoshida authored
NotShared/MaybeShared templates are on-stack pointer wrappers to ensure the pointed ArrayBufferView is shareable between threads or not. We could not store these pointers as a part of objects because they are on-stack objects, and had to convert to a pointer with |.View()|. class KeepNotSharedABV : public GarbageCollected { using T = DOMUint8Array; void setFoo(const NotShared<T>& v) { m_ = v.View(); } NotShared<T> getFoo() const { return NotShread<T>(m_); } Member<T> m_; }; Because of it, it was not obvious if an object holds a shareable view or not. This CL makes these templates like smart pointers, and be able to be a part of GCed objects. So now we can make it like class KeepNotSharedABV : public GarbageCollected { using T = DOMUint8Array; void setFoo(const NotShared<T>& v) { m_ = v; } NotShared<T> getFoo() const { return m_; } NotShared<T> m_; }; Bug: 839389 Change-Id: Id3d47f1d6a01953b8c82316ebc0d2af68d1685b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104787 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#751585}
-
David Dorwin authored
Reduce the severity unless/until the underlying issue is addressed. Bug: 1061262 Change-Id: I73d2b5f74bafaab182bbd36394cecb2f2d29ef75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044525Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#751584}
-
Jinsuk Kim authored
This CL moves EphemeralTabCoordinator field from ChromeActivity to TabbedRootUiCoordinator since it is UI a component for tabbed mode only. This aims to make the code structure better by slimming down ChromeActivity (no more getter for the object), hence one less usage of Tab.getActivity() in TabContextMenuItemDelegate, replaced with an injection of a dependency through the constructor. Bug: 1051184 Change-Id: I5856cb27030f3b7e7e17efd93a001d2e84335a71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102029 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
-
alanlxl authored
This CL moves json parsing to the isolated data_decoder::DataDecoder for security concerns. Bug: 1049886 Test: Pass the unittests Change-Id: Ifb41b269e219925768c69178c5af75e5048f868d Cq-Depend: chromium:1905044 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050419Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Commit-Queue: Xinglong Luan <alanlxl@chromium.org> Cr-Commit-Position: refs/heads/master@{#751582}
-
Nicholas Verne authored
Several tweaks made to upgrade flow to make it play better with the new terminal. Since the terminal launches its window prior to starting crostini, we move the upgrade availability check to an earlier phase of LaunchCrostiniApp. Also, when the user decides not to upgrade, we don't restart crostini twice. (Previously, this could happen because the upgrade process needs to shut down crostini first). Bug: 1024693 Change-Id: I46ee09877a7092d91894b80bc798ed99e4f855ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108300Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#751581}
-
Kent Tamura authored
It is referred only by ListBoxSelectType. SelectType::DidBlur(), which modifies last_on_change_selection_, is also moved to ListBoxSelectType. This CL has no behavior changes. Bug: 1052232 Change-Id: I6ccb206f3432f7c7dbc0685133ca7ae3a1abeca8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105832 Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#751580}
-
Jeremy Roman authored
This is a very common case, and this happens to produce smaller (and in theory, slightly faster) code. Change-Id: I33bbd12effe99d5890480d3d752fcd0df20f5486 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106386 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
-
Johann authored
Change-Id: I9977a7b2009c89438cf8b3191417325951d3ced1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105270Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#751578}
-
Allen Bauer authored
TBR=asvitkine@chromium.org Bug: 1056944 Change-Id: Id0b82d349e665dc91f21bf4db372fa3e5f7e58ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106813 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/41a6191ed80e..8413a03c394c git log 41a6191ed80e..8413a03c394c --date=short --first-parent --format='%ad %ae %s' 2020-03-19 fancl@chromium.org Cache image for push-on-green Created with: gclient setdep -r src/third_party/catapult@8413a03c394c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: oysteine@google.com Change-Id: Iab8305c2cdd6ba46abd649d82aecd72f3882a519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109293Reviewed-by:
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: Ie77639cc2e9de794cda6301911d9376142deb030 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109261 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#751575}
-
Demetrios Papadopoulos authored
Subpages of people_page.html are not migrated yet, and will be in later CLs. For this reason unit tests are also not ported yet. Bug: 1026426 Change-Id: I4ae2d79ab2506e420a84f726078cc4be50f329f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107961 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
-
