GitLab

BUG=1024850
TBR=adithyas@chromium.org,agrieve@chromium.org

Change-Id: Ib99f9a64f4bea821efc5bab831233aa9e8928680
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919726Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715880}

The cr-link-row element is currently described by ChromeVox as a 'link'
despite the fact when it is used as a subpage route, it stays in the
current tab instead of opening a new one like the other links in
settings. The alternative aria-roledescription 'subpage button'
preferred by the a11y team remove that ambiguity.

Examples:
https://drive.google.com/open?id=1su58VJ_AksPs44HFoNWambjqcSLIQPdv

Bug: 1012104
Change-Id: I7d591bb74b8b5828ca44e7270d7edf6ab61755c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881816Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715879}

* Modify CastRunner to handle a CastAgent disconnection without
  crashing.
* Add tests for this scenario.

Bug: 1020736
Change-Id: If94cecc4a47a2aaf88d73b35df4e696f679a424e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917981
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715878}

On device initialized before M74 (when boot lockbox was first
introduced), it requires a powerwash first to use boot lockbox. In such
case, disable the toggle and show sublabel to explain the situation.

      1) still see login screen warning indicator
      2) see settings toggle disabled, with a sublabel

Test: Force to return NEED_POWERWASH from session_manager
Test: No change if not forced
Bug: chromium:893332
Change-Id: Idf75884404769ff724be0225aa9a674e03d978ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918335
Commit-Queue: Victor Hsieh <victorhsieh@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715877}

TBR=dtseng@chromium.org

Bug: 1025339
Change-Id: I2e9b14e9bd2b58f8c349081181c0b3ec1793f980
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919574Reviewed-by: Anastasia Helfinstein <anastasi@google.com>
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Cr-Commit-Position: refs/heads/master@{#715876}

StackTrace has a bug preventing it from capturing any stack frames in
Fuchsia Official builds, so disable those checks for now.

TBR=ajwong

Bug: 1025329, 1025288
Change-Id: I2b24c7f903c345518835edc3226b15355ea1bf9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919735Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Auto-Submit: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715875}

Utilize gaia::IsGoogleInternalAccountEmail() instead of one off string checks.

Bug: n/a
Change-Id: I772ae92dbe31ca0c1bccc3c0e2fb666fa50972e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899843
Commit-Queue: Joon Ahn <joonbug@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715874}

Bug: 1025346
Tbr: afakhry@chromium.org
Change-Id: I17616eb89ff17de0ad1839e5cb95f9d319281cc7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918384Reviewed-by: Tina Wang <tinazwang@chromium.org>
Commit-Queue: Tina Wang <tinazwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715873}

All calls are test-only, but there's a presubmit check for it that
triggers even when it's used in tests. In its place, use
base::NumberToString.

BUG=None

Change-Id: I617815c2d4fb254e52edf3c92c236c335ab73a26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919720Reviewed-by: Asanka Herath <asanka@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715872}

During device emulation, the chrome WebThemeEngine implementation
may not be the mobile theme which can provide overlay scrollbar styles.
In the case we should fallback to default styles.

Bug: 1025183
Change-Id: I32b45d401e09374bf1da1967d2328867474b6cdd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919424Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715871}

To solve the issue 1012772, we need to implement an interface to
scroll the shelf view to show the icon for a given app id. This CL
provides the following helper functions:
(1) Calculates the offset distance of scrolling Shelf to the
previous/next page.
(2) Calculates the layout strategy for the given scroll distance.
(3) Calculates the first/last tappable app indices for the given
layout strategy and scroll offset.

No UI changes should be introduced by this CL.

Bug: 1012772
Change-Id: I3aa27d0fa035f9a9a3186bbe9963065afe465f89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762558Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715870}

* Remove no-longer implemented method definition in CastComponent
* Remove the old API to register MessagePorts in CastRunner.
* Remove integration and browser tests using former APIs.
* Adapt integration and browser tests to use the new API.

Bug: 953958
Change-Id: I192cd8453c3c730cb8ecab504884d46af5ad100b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917327
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715869}

The test suite already instantiates a FieldTrialList as per
https://chromium-review.googlesource.com/c/chromium/src/+/1883567 so
it's no longer necessary to do so explicitly in tests.

This patch addresses unit tests under:
/chrome/browser/ui/search

This CL was uploaded by git cl split.

R=gayane@chromium.org

Bug: 1018667
Change-Id: Icb63ab7435f32f6613a9dd06b551d6ebab960303
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917508
Auto-Submit: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715868}

This CL removes code that shares base::SharedMemoryHandle with remote.
This code is no longer used because base::SharedMemoryHandle is
deprecated and replaced with base::*SharedMemoryRegion.

Bug: 795291
Change-Id: I5974bd77b6e40bee662dc2fb4092b7a61f725afb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916827Reviewed-by: Raymes Khoury <raymes@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Auto-Submit: Alex Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715867}

Using wpt-import in Chromium 37619ed5.
With Chromium commits locally applied on WPT:
788a3004 "Fix failing Fetch Metadata WPT"
b16db925 "[Trusted Types] Add test for duplicate names in non-enforcing mode."
e83dd93c "Limit backtracking on regexp called from blink."
6e3e930c "Change `sec-fetch-mode` from `no-cors` to `navigate` for <embed> / <object>."
c8b6e1ce "Chromedriver] Fix PerformAction to support multi touch points cases"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=foolip

No-Export: true
Change-Id: If34822af50898fd25599053eaaf13d00506c6a04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917049Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#715866}

DiscardableSharedMemory::Purge() attempts to proactively de-commit pages
once the instance is unused, to free it quickly even if the peer is slow
to unmap it.

However, the DiscardableSharedMemoryManager (typically in the browser)
maps instances but then closes their handles - Purge() must therefore
be implemented without reference to the handle.

Bug: 1023693
Change-Id: Ic645232c0b24d85acb64e915bbef05804b25b001
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912698
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Auto-Submit: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715865}

https://swiftshader.googlesource.com/SwiftShader.git/+log/cc221e838b01..83ca1b9af5cc

git log cc221e838b01..83ca1b9af5cc --date=short --no-merges --format='%ad %ae %s'
2019-11-15 swiftshader.regress@gmail.com Regres: Update test lists @ cc221e83

Created with:
  gclient setdep -r src/third_party/swiftshader@83ca1b9af5cc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=swiftshader-team+autoroll@google.com

Bug: None
Change-Id: I2a94b0426f5143ddbd052b3dec9cde9f7c564971
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918376Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#715864}

It has been optional, but now that all the calls that need a meaningful
NetworkIsolationKey argument have one, can make it mandatory and fill in
the remaining callsites with an empty NIK.

Bug: 997049
Change-Id: I9cc2809a0d67fe4298b122642bf1a502759f6871
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913270Reviewed-by: Eric Orth <ericorth@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715863}

Doing this in DoPartialHeadersReceived was OK for redirects, but caused
trouble to things with bodies (e.g. 500) since the cache hit transaction
ended up still marked as a writer, and so once the cache data was exhausted,
TransitionToReadingState went to try to read from a non-existing network
transaction.

Instead, do this in DoSetupEntryForRead, to give it a chance to mark this
as a reader.

Bug: 1024918, 1015829
Change-Id: I8ddb736b2834b1e745228473402ad6584a5ffed6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918315Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Commit-Queue: Maksim Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715862}

There are some media tests that occasionally flake on many different
bots. They all have the same underlying issue that sometimes the first
frame of the video hasn't painted yet when the screenshot is taken.
Marking them as flaky for now until we can figure out a deterministic
way to make them pass.

Example failure:
https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/48598

Bug: 1024976
Change-Id: I66e970c499f6719adcfd400966cf225aced68723
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918321
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Auto-Submit: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715861}

PlatformWrapperTest used the deprecated base::SharedMemory and
base::SharedMemoryHandle classes. This CL converts the tests to use
base::UnsafeSharedMemoryRegion class.

Bug: 795291
Change-Id: Ia863616ba23e8ebe17a16fe994a9b6b3b2beafd7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919150
Commit-Queue: Ken Rockot <rockot@google.com>
Auto-Submit: Alex Ilin <alexilin@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#715860}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0b9e8ed45cb0..77c16a79405b


Created with:
  gclient setdep -r src-internal@77c16a79405b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: I2a3f3637569f5fea455fb7415374cdd4f6557c70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919488Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#715859}

Bug: 986737
Change-Id: I6faa14dcf4dad51f008b61062325e4eb0b1ab28b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917529Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715858}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/42251f9ad57e..ce2f6cfa67a4

git log 42251f9ad57e..ce2f6cfa67a4 --date=short --no-merges --format='%ad %ae %s'
2019-11-15 chrome-bot@chromium.org Update config settings by config-updater.

Created with:
  gclient setdep -r src/third_party/chromite@ce2f6cfa67a4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: I4f442dcd91a7be609cbded6c51a6be7855ba3794
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919487Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#715857}

A new test verified all keys conform to "Chrome.[Feature].[Key]":
ChromePreferenceKeysTest.testDeclaredConstantsConformToFormat()

Grandfather in the constants currently used, since none of them
conforms to the format.

Bug: 1023839
Change-Id: I7175594d9027d0160d5f102175ee4df3ff27a61a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912646
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715856}

This CL modifies the Sensors.Windows.WinRT.Activation.Result to log
HRESULT_FROM_WIN32(ERROR_NOT_FOUND) when the sensor does not
exist on this system. This brings the histogram on parity with the Win32
flavor.

Bug: 958266
Change-Id: I6406c9ef3335d7d892ba8afaaa1b1848a6461ee2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919570Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Wenjie Shi <wensh@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#715855}

This CL removes all usages of base::SharedMemory and
base::SharedMemoryHandle from media::UnalignedSharedMemory since
there are no more callers of the constructor using these classes.

UnalignedSharedMemory itself is deprecated and should be eventually
removed as part of shared memory refactoring in future CLs.

Bug: 795291
Change-Id: I808c9fff08923f3414643e6258667dba2365f621
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917376
Commit-Queue: Alex Ilin <alexilin@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715854}

* In "method count" mode, sort by symbol count (descending) rather than
  size.
* Tiebreak by name in method count mode and size view mode.

Bug: 1001765
Change-Id: I849a61ce72c9b2bd5e2348cdfcb8d54d51d33f5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919546
Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715853}

Extends the decode-webp-images-to-yuv browser flag from M80 to M88.

Bug: 966008
Change-Id: Ic27dcf609abe1af58d380417c248f90958297737
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918944Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715852}

Bug: 1021770

Change-Id: Ia7c8e3aff8aa84f05e105f161d56d7f9a0f7ef70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907775Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715851}

Found while working on Cluster Telemetry, subframes will be saved to the
wrong directory if capturing them is enabled. This CL fixes that
behavior by making the root_dir part of the document data.

Bug: 1025331
Change-Id: I39a82cca438da20368c6cb4692d628fb6aba2549
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919545
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715850}

Bug: 922145
Change-Id: I2f4259502b812e3bb4b411ca65318000bd3c7286
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918310
Commit-Queue: Yun Liu <yliuyliu@google.com>
Auto-Submit: John Budorick <jbudorick@chromium.org>
Reviewed-by: Yun Liu <yliuyliu@google.com>
Cr-Commit-Position: refs/heads/master@{#715849}

This patch makes the BottomSheet class protected. Accessors of the
view have been restricted to test methods. Most of the initialization
logic has been moved back into to BottomSheetController class with the
exception of the creation of the view and snackbar manager.

Bug: 986310, 1002277
Change-Id: I5e9cb255f89cd66add8fee93111cf09940be8452
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910288
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715848}

When the mixer is in the same process, audio buffers are sent to the
mixer service by just posting a reference. The mixer service holds the
reference until the audio is written out; the audio buffer must not be
overwritten until this occurs. Therefore, use an IOBufferPool to manage
the buffer lifetime.

Bug: internal b/143628666
Change-Id: I4bd247c806c0ec5d909ffa048dd0f8d30aeabed7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917958Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Commit-Queue: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715847}

This changes the handling of the creation flag for withholding on
install to always take preference for triggering withholding and
changing the stored pref value. It also makes it so the pref value is
always set to a default value on install / update, if a value had not
been set previously.

Bug: 984069
Change-Id: I0282ad3d159bffee0c26fecdcb47510ebfc92b97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865773
Commit-Queue: Tim Judkins <tjudkins@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715846}

https://chromium.googlesource.com/catapult.git/+log/86e9f140ce37..a6bbfb935a25

git log 86e9f140ce37..a6bbfb935a25 --date=short --no-merges --format='%ad %ae %s'
2019-11-15 cduvall@chromium.org Fix getting pixel density on emulator

Created with:
  gclient setdep -r src/third_party/catapult@a6bbfb935a25

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC simonhatch@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=simonhatch@google.com

Bug: None
Change-Id: I0ebfb8973b667c2d2eb7fe26e629c4cf1d2c2eef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918402Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#715845}

*   Updates the target drag distance at which the home screen stops
    scaling - instead of extending for a fixed point from the threshold
    at which transition is allowed, that target is set to the center of
    the screen
*   Significantly shortens the timeout to trigger transition
*   Allows transition if pointer is moving, provided that the velocity
    is below certain threshold (instead of requiring pointer to stay
    still)

BUG=1005366, 1025283

Change-Id: Ic322932a3ae519a1989ef343f6f2e960dca29709
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912993
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715844}

The call to BluetoothTaskManagerWin::DiscoverDevices runs on a loop
until either discovery stops or we find the device we are searching for.
If discovery stops this function called
BluetoothTaskManagerWin::OnStopDiscovery.  However, we call
BluetoothTaskManagerWin::OnStopDiscovery already when we stop. The
second call causes a crash. This CL removes that call.

Bug: 1022149
Change-Id: I74d977abdfd69cbde2e525a024b1f6016148ed7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915300Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715843}

Update code where NULL or 0 is assigned to a scoped_refptr to reset it. Just
call reset() instead. If operator=(std::nullptr_t) is added these assignments
become ambiguous.

This CL was uploaded by git cl split.

R=mattreynolds@chromium.org

Bug: 1024981
Change-Id: I88fc42fe0c2b6e2925b9c5da0321438f51af2dab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918201
Auto-Submit: kylechar <kylechar@chromium.org>
Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715842}

Also adds diff_test.cc.

Bug: 1011921
Change-Id: I3d678738719531d1c74e620f4fc3605cab08b325
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918027
Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715841}