GitLab

Revert of Revert of Inline sign in extracts gaia id from HTTP header and seeds account tracker (patchset #1 id:1 of https://codereview.chromium.org/671183002/)

Reason for revert:
White success page and no way to proceed only reproduces for use_athena=1 builds.

This CL fixes that: https://codereview.chromium.org/642693003/

Re-landing.

Original issue's description:
> Revert of Inline sign in extracts gaia id from HTTP header and seeds account tracker (patchset #46 id:1740001 of https://codereview.chromium.org/473153002/)
>
> Reason for revert:
> This breaks Chrome OS GAIA login.
>
> After successful GAIA authentication uses sees blank white page and nothing happens.
>
> Please build chromeos=1 build and check that sign in as new user works fine before relanding this CL. Unfortunately autotests rely on fake gaia server and doesn't check this end-to-end sign in flow.
>
> Original issue's description:
> > Inline login handler extracts gaia id from HTTP header and seeds account tracker
> > service during sign in.
> >
> > BUG=341408
> >
> > Committed: https://crrev.com/a8e7c94b1b79a0948d05a1fcfff53391d22ce37a
> > Cr-Commit-Position: refs/heads/master@{#300750}
>
> TBR=guohui@chromium.org,bartfab@chromium.org,xiyuan@chromium.org,achuith@chromium.org,davemoore@chromium.org,rogerta@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=341408
>
> Committed: https://crrev.com/bbaf207927765f4b7c7cae2a4af8db6c4c4a67ce
> Cr-Commit-Position: refs/heads/master@{#300873}

TBR=guohui@chromium.org,bartfab@chromium.org,xiyuan@chromium.org,achuith@chromium.org,davemoore@chromium.org,rogerta@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=341408

Review URL: https://codereview.chromium.org/677703002

Cr-Commit-Position: refs/heads/master@{#301099}

The version was so old that recording some modern web pages failed.

BUG=425548

Review URL: https://codereview.chromium.org/669413002

Cr-Commit-Position: refs/heads/master@{#301098}

The size of the cache on disk is used if the backend is persistent, else the size of the entries in memory is returned.

Downstream of: https://codereview.chromium.org/674873002/

BUG=420159

Review URL: https://codereview.chromium.org/672943002

Cr-Commit-Position: refs/heads/master@{#301097}

Disable AppListControllerAppInfoDialogBrowserTest.DoShowAppInfoFlow as it's still flaky. More information in bug.

TBR=sashab@chromium.org
BUG=378251
NOTRY=True

Review URL: https://codereview.chromium.org/677063003

Cr-Commit-Position: refs/heads/master@{#301096}

Notable changes (other than just moving code aruond)

* kJavaScriptMessageExpectedDelay constant has been moved from chrome_constants to javascript_dialog_manager.cc because that's the only place used.
* NOTIFICATION_APP_MODAL_DIALOG_SHOWN notification has been removed and replaced by test only waiter class. (as this notification was used only in tests)
* Moved and creates string resource for app_modal_dialog.

Next step: move dialog implementations to compoents/app_modal_dialogs (javascript_dialog_manager/  javascript_app_modal_dialogs_views/, javascript_app_modal_dialogs_cocoa ....)

BUG=422092
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/648833004

Cr-Commit-Position: refs/heads/master@{#301095}

BUG=N/A
TEST=N/A

Review URL: https://codereview.chromium.org/671343002

Cr-Commit-Position: refs/heads/master@{#301094}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/976386b..cee4ddf

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/661173003

Cr-Commit-Position: refs/heads/master@{#301093}

Chrome OS retrieves device state from DMServer during OOBE. If this
state indicates that the device should be disabled, it will show a
corresponding screen and prevent the user from proceeding further.

The feature is on by default because we are aiming for M40 but a flag
is provided that can easily be flipped to turn it off if we do not
make the deadline.

BUG=425574
TEST=Unit and browser tests

Review URL: https://codereview.chromium.org/676773002

Cr-Commit-Position: refs/heads/master@{#301092}

Enabling the unit tests again on debug.
If they still timeout, please revert.

Several changes to reduce the runtime:
- Ensure that there are no duplicate Shill profile notifications, which triggered multiple policy applications and certificate resolves.
- Ensure that each test runs at most one certificate resolve task.
- Use other certificates that are faster to load and import.

Overall this reduce on my workstation runtime in debug from ~6 seconds to <4 seconds.

Also remove the unnecessary TPMTokenLoader initialization.

BUG=418369

Review URL: https://codereview.chromium.org/679673002

Cr-Commit-Position: refs/heads/master@{#301091}

Changed the flag '--enable-extension-info-dialog' to
'--disable-extension-info-dialog', which enables the App Info dialog as
the default dialog for displaying permissions on the extensions page.
Does not affect Mac platforms (where the old-style dialog is still
used).

Contains patches from issues 668163002 and 664473005, since the CQ
couldn't land them individually.

TBR=kalman,asvitkine,benwells,mpearson
BUG=395495

Review URL: https://codereview.chromium.org/664933006

Cr-Commit-Position: refs/heads/master@{#301090}

Replace pump.py generated gin/function_template.h with variadic template version.

This results in a concise code which does not require the use
of pump preprocessor.
Similar effort for base/callback.h is happening in https://codereview.chromium.org/610423003/

BUG=

Review URL: https://codereview.chromium.org/671433004

Cr-Commit-Position: refs/heads/master@{#301089}

Cr-Commit-Position: refs/heads/master@{#301088}

Compared to the previous CL, this picks up in breakpad:
Fix breakpad on mips and x86_64 for the NDK r10c update.

Original issue's description:
> Revert of Roll android_tools and breakpad to the latest. (patchset #5 id:80001 of https://codereview.chromium.org/671633003/)
>
> Reason for revert:
> Downstream x64 and mips bots didn't like it.
>
> Original issue's description:
> > Roll android_tools and breakpad to the latest.
> >
> > This picks up in android_tools:
> > Updated SDK build tools to 21.0.1 and removed old versions.
> > Upgrade NDK to r10c.
> >
> > And in breakpad:
> > Update breakpad to support Android NDK r10c
> > Fixing the Mac Inspector build by adding the launch_report dependency to the breakpadUtilities dylib project after it got pulled out from Inspector.mm.
> > Refactor .so name detection logic in minidump/linux_dumper.
> > The process uptime computation when the Windows out-of-process Crash Generation Server is used is done by subtracting the crashing process creation time from the current time when the crash is generated.
> > Linux multiprocess crash reporter: use pipe instead of socketpair in the client.
> > Remove workaround for Linux credential-passing bug.
> >
> > TBR=brettw, danakj
> > NOTRY=true
> > BUG=424680, 425077, 358831
> >
> > Committed: https://crrev.com/79bd5f12620f81dd241984d925b87a888e1dc37b
> > Cr-Commit-Position: refs/heads/master@{#300671}
>
> TBR=brettw@chromium.org,primiano@chromium.org,rmcilroy@chromium.org,aurimas@chromium.org,danakj@chromium.org,fdegans@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=424680, 425077, 358831
>
> Committed: https://crrev.com/e6319d7f7d5c2fc96c9cb1f5a81ae16bde19f068
> Cr-Commit-Position: refs/heads/master@{#300688}

TBR=brettw@chromium.org,primiano@chromium.org,rmcilroy@chromium.org,aurimas@chromium.org,danakj@chromium.org,ppi@chromium.org
BUG=424680, 425077, 358831

Review URL: https://codereview.chromium.org/676483002

Cr-Commit-Position: refs/heads/master@{#301087}

With this call the quota manager can delete origins modified in the last X hours.

Changes:
* Plumb origin and QuotaManagerProxy through to ServiceWorkerCache.

* Call NotifyStorageModified on SWCache::Put() and SWCache::Delete() with the delta being the number of content bytes written (not including caching structure overhead).

* Update the tests to use a MockQuotaManagerProxy instead of passing a nullptr.

Upstream of: https://codereview.chromium.org/672943002

BUG=420159

Review URL: https://codereview.chromium.org/674873002

Cr-Commit-Position: refs/heads/master@{#301086}

The Task Queue Manager previously would give clients a
SingleThreadTaskRunner which held a weak pointer back to the manager in
order to post tasks. This is wrong because the task runner and hence
the weak pointer may be accessed from arbitrary threads, which is
not safe.

This patch corrects the problem by combining the task runner and the
incoming task queue into a single task queue object which owns both
the incoming task as well as the pointer back to the task queue
manager. This allows us to protect the incoming task queue and the
pointer using the same lock.

BUG=391005

Review URL: https://codereview.chromium.org/673833002

Cr-Commit-Position: refs/heads/master@{#301085}

Layout tests currently utilize a mocked NotificationPresenter implemented
in the test runner, but this won't be sufficient for Web Worker-based
notifications given that these won't be tied to a WebFrame.

Instead, pull up the layout test functionality to the browser process in
content_shell (only available when running layout tests!), similar to the
ability to request Notification permissions, so that we can allow displaying
and interacting with "displayed" notifications in layout tests as well.

The existing code path for Document-based Notifications is kept intact, but
will be removed once both Blink and Chromium switch over.

BUG=392187

Review URL: https://codereview.chromium.org/659043003

Cr-Commit-Position: refs/heads/master@{#301084}

This was a compiler error on GCC 4.9.1:
unable to deduce ‘const auto*’ from ‘((((content::PpFrameWriter::FrameWriterDelegate*)this)->content::PpFrameWriter::FrameWriterDelegate::endian_ == (content::PpFrameWriter::FrameWriterDelegate::PixelEndian)1u) ? libyuv::BGRAToI420 :  libyuv::ARGBToI420)’

Introduced in https://codereview.chromium.org/663183002

BUG=426020

Review URL: https://codereview.chromium.org/675963002

Cr-Commit-Position: refs/heads/master@{#301083}

BUG=406995
TEST=none

Review URL: https://codereview.chromium.org/676633002

Cr-Commit-Position: refs/heads/master@{#301082}

BUG=422235
R=sergiyb@chromium.org

Review URL: https://codereview.chromium.org/677023002

Cr-Commit-Position: refs/heads/master@{#301081}

Use size_t throughout, and avoid mixing size_t and uint32_t.

No behavioural effect.  Unsigned leb128 is currently used
only on 32-bit arm, and here uint32_t and size_t are equivalent.

BUG=385553

Review URL: https://codereview.chromium.org/668543003

Cr-Commit-Position: refs/heads/master@{#301080}

BUG=426020

Review URL: https://codereview.chromium.org/663183002

Cr-Commit-Position: refs/heads/master@{#301079}

BUG=

Review URL: https://codereview.chromium.org/675103003

Cr-Commit-Position: refs/heads/master@{#301078}

The removed comment speaks about StubContentSettingsClient, which was not created in https://codereview.chromium.org/646973002 after all, and thus does not exist in the ToT.

This is a comment-only change, thus skipping tests.

TBR=blundell@chromium.org
NOTRY=true
BUG=393248

Review URL: https://codereview.chromium.org/663933003

Cr-Commit-Position: refs/heads/master@{#301077}

Previously onMessage function of FileManagerBrowserTest returns a string, but
the format of the return values is not consistent among the message types.

Also the onMessage function retunrs the value even if it is fatal error, but for
the case, we can stop the test directly in the function.

The CL removes unrequired result values, and adds test assertions for fatal
errors.

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/667843005

Cr-Commit-Position: refs/heads/master@{#301076}

Remove the old SocketStream-based WebSocket implementation from
content/.

Large parts of the implementation still exist in net/. They will be
removed in a subsequent CL.

There are also a few traces in chrome/, and some interfaces in Blink
that cannot be removed until this CL is submitted.

BUG=423201
TEST=layout tests, browser_tests

Review URL: https://codereview.chromium.org/655253006

Cr-Commit-Position: refs/heads/master@{#301075}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/62c1cfd..bcef85c

TBR=kochi@chromium.org,leviw@chromium.org

Review URL: https://codereview.chromium.org/674873003

Cr-Commit-Position: refs/heads/master@{#301074}

This CL removes the 1 pixel padding around the app list main view. This
subtly changes the layout of the app list by changing the padding of
certain elements.

The dimensions of the app list window are still the same.

This is being done in preparation for the new experimental app list
layout.

BUG=425444

Review URL: https://codereview.chromium.org/676513003

Cr-Commit-Position: refs/heads/master@{#301073}

If not, it leads to a crash later because we don't expect invalied AX roles
in Chromium. We have to tolerate unknown AX roles from Blink because
otherwise there's no way for us to introduce new roles to the Blink enum.

BUG=426608
TBR=aboxhall

Review URL: https://codereview.chromium.org/673143002

Cr-Commit-Position: refs/heads/master@{#301072}

BUG=421850
TEST=None

Review URL: https://codereview.chromium.org/672173003

Cr-Commit-Position: refs/heads/master@{#301071}

Deleted the experiment to load either 200 or 1000 servers from disk.

+ Obsoleted the following histograms
  ++ Net.AlternateProtocolUsage.200Truncated
  ++ Net.AlternateProtocolUsage.1000Truncated

Reverted the changes related to the above from the following CL:
  https://codereview.chromium.org/298683010/

R=jar@chromium.org, rch@chromium.org

Review URL: https://codereview.chromium.org/675783005

Cr-Commit-Position: refs/heads/master@{#301070}

Since the features are not ready, information about the new API should not be
published on the official documentation.

TEST=Tested manually with a preview server.
BUG=425924

Review URL: https://codereview.chromium.org/663013004

Cr-Commit-Position: refs/heads/master@{#301069}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/2814a56..62c1cfd

TBR=kochi@chromium.org,leviw@chromium.org

Review URL: https://codereview.chromium.org/677623002

Cr-Commit-Position: refs/heads/master@{#301068}

Revert of Remove mojo test step from bb_device_steps.py (patchset #2 id:20001 of https://codereview.chromium.org/679553002/)

Reason for revert:
Breaks https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/16413
and
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/23666
like this:
build/android/buildbot/bb_device_steps.py '--factory-properties={"generate_gtest_json": true, "target": "Release", "gclient_env": {}, "build_url": "gs://chromium-android/android_main_rel", "clobber": false, "GYP_DEFINES": " component=static_library", "target_os": "android", "android_bot_id": "main-tests-rel"}' '--build-properties={"parentname": "Android Builder", "parent_wk_revision": "184325", "parent_got_v8_revision": "24827", "got_swarming_client_revision": "bcb3bc30328c38441d3f7656cb649b123803726c", "parent_build_archive_url": "gs://chromium-android/android_main_rel/full-build-linux_66e8568f2fc06dd2aa188d12c240ae2794b00ea0.zip", "parent_buildnumber": "39199", "got_revision": "66e8568f", "parent_revision": "66e8568f", "blamelist_real": ["blink-deps-roller@chromium.org", "brettw@chromium.org", "cjhopman@chromium.org", "dbeam@chromium.org", "hidehiko@chromium.org", "jamesr@chromium.org", "joth@chromium.org", "kelvinp@chromium.org", "kouhei@chromium.org", "ksakamoto@chromium.org", "mtomasz@chromium.org", "sashab@chromium.org", "skia-deps-roller@chromium.org", "tfarina@chromium.org", "wuchengli@chromium.org", "zsborbely.u-szeged@partner.samsung.com"], "got_webkit_revision_git": "721f3e2ce5a10cfb21d12f672bbcc2023d9a228d", "parent_slavename": "vm870-m1", "got_v8_revision_git": "26db57054e04a5b35e7ad88aecb3e05895491a5c", "project": "src", "repository": "https://chromium.googlesource.com/chromium/src", "parent_scheduler": "android", "parent_got_swarming_client_revision": "bcb3bc30328c38441d3f7656cb649b123803726c", "git_revision": "66e8568f", "slavename": "chromeperf72", "got_revision_cp": "refs/heads/master@{#301052}", "blamelist": "blink-deps-roller@chromium.org,brettw@chromium.org,cjhopman@chromium.org,dbeam@chromium.org,hidehiko@chromium.org,jamesr@chromium.org,joth@chromium.org,kelvinp@chromium.org,kouhei@chromium.org,ksakamoto@chromium.org,mtomasz@chromium.org,sashab@chromium.org,skia-deps-roller@chromium.org,tfarina@chromium.org,wuchengli@chromium.org,zsborbely.u-szeged@partner.samsung.com", "branch": "master", "patchset": "", "issue": "", "revision": "66e8568f", "workdir": "/b/build/slave/Android_Tests", "got_webkit_revision": "184325", "buildername": "Android Tests", "parent_try_job_key": "", "mastername": "chromium.linux", "parent_got_webkit_revision": "184325", "parent_builddir": "", "parent_branch": "master", "got_v8_revision_cp": "refs/heads/candidates@{#24827}", "primary_repo": "", "scheduler": "android_trigger_rel", "requester": "", "buildbotURL": "http://build.chromium.org/p/chromium.linux/", "parent_cr_revision": "66e8568f", "rietveld": "", "parent_got_nacl_revision": "", "parent_buildername": "Android Builder", "got_v8_revision": "24827", "parent_got_revision": "66e8568f", "got_webkit_revision_cp": "refs/heads/master@{#184325}", "buildnumber": 16413, "patch_url": "", "parent_git_number": "", "parentslavename": "vm870-m1", "root": ""}' -f ui -f unit -f mojo -f telemetry_perf_unittests -f chrome_proxy --cleanup --flakiness-server=test-results.appspot.com
Unknown tests ['mojo']

Please remove execution of the test from the buildbot configuration (recipe?) first, then reland this.

Original issue's description:
> Remove mojo test step from bb_device_steps.py
>
> This code is being developed and tested in the mojo repository.
>
> R=dpranke@chromium.org
> TBR=navabi@chromium.org
>
> Committed: https://crrev.com/7ec86e83523b60bab33f1739469ff0a0801c8eb4
> Cr-Commit-Position: refs/heads/master@{#301038}

TBR=dpranke@chromium.org,jbudorick@chromium.org,navabi@chromium.org,jamesr@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/646883003

Cr-Commit-Position: refs/heads/master@{#301067}

Revert of Specifies transparent background for the label in TileItemView. (patchset #2 id:10002 of https://codereview.chromium.org/655823005/)

Reason for revert:
Introduces static initializer, see https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/72389

Original issue's description:
> Specifies transparent background for the label in TileItemView.
>
> We may not use single background when it's in Athena (it's not
> used yet though).
>
> BUG=425717
> R=xiyuan@chromium.org
> TEST=manually
>
> Committed: https://crrev.com/3b74c2c950e3681a94601f61d48a6ff0e25f06f8
> Cr-Commit-Position: refs/heads/master@{#301007}

TBR=xiyuan@chromium.org,mukai@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=425717

Review URL: https://codereview.chromium.org/674083002

Cr-Commit-Position: refs/heads/master@{#301066}

BUG=chromedriver:913
TBR=stgao@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/680463002

Cr-Commit-Position: refs/heads/master@{#301065}

BUG=chromedriver:954
TBR=stgao@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/650593004

Cr-Commit-Position: refs/heads/master@{#301064}

BUG=chromedriver:955
TBR=jbudorick@chromium.org,klundberg@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/662433004

Cr-Commit-Position: refs/heads/master@{#301063}

1) Now, nacl_helper_nonsfi is built only when disable_nacl==0 and
disable_nacl_untrusted==0. Update the condition.
2) native_client/src/public/linux_syscall is now automatically
included by the PNaCl toolchain for the Non-SFI build.
3) Move include_dirs from variables to target.
4) Use relative path instead of <(DEPTH)

BUG=358465
TEST=Ran trybot.
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/656483005

Cr-Commit-Position: refs/heads/master@{#301062}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/721f3e2..2814a56

TBR=kochi@chromium.org,leviw@chromium.org

Review URL: https://codereview.chromium.org/670063007

Cr-Commit-Position: refs/heads/master@{#301061}

Along the way,
  * Tighten up //components/variations and //components/metrics DEPS.
  * Fix up metrics and variations BUILD.gn files.
  * Add unit test targets for metrics and variations.

BUG=420110
TEST=compiles
R=asvitkine@chromium.org
TBR=jochen@chromium.org, cbentzel@chromium.org

Review URL: https://codereview.chromium.org/668863002

Cr-Commit-Position: refs/heads/master@{#301060}