GitLab

The initialization of "char empty_" union-member in Optional is
redundant and causes the compiler to generate extra code to ensure
zero-initialization. Using an empty Dummy class for the union member is
more optimal, since it guarantees that no code for its initialization is
generated.

Explicitly touching this char member in the constructor also causes a
problem for conservative GC. Compiler is free to split shared and not
shared parts of the union in separate memory locations on stack (or keep
them in different registers). If a conservative GC is triggered at this
moment, stack scanning may not find the correct object (this is exactly
what happened in the bug 1044331).

This can be tested in a minimized example: https://godbolt.org/z/t5q5ry.

Bug: 1046776

Change-Id: Idab1a0acf7d7d4f45dc9435a611b23f64e3c3c79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027948
Commit-Queue: Anton Bikineev <bikineev@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737494}

https://chromium.googlesource.com/angle/angle.git/+log/c73475fb3c99..4dc1eb42a4de

git log c73475fb3c99..4dc1eb42a4de --date=short --first-parent --format='%ad %ae %s'
2020-01-31 ynovikov@chromium.org Add UWP builders to CQ
2020-01-31 jgilbert@mozilla.com Allow overriding ANGLE_PLATFORM_EXPORT.
2020-01-31 cclao@google.com Vulkan: Disable restartRenderPassAfterLoadOpClear workaround
2020-01-31 cnorthrop@google.com Capture/Replay: Implement Manhattan ES 3.0 support

Created with:
  gclient setdep -r src/third_party/angle@4dc1eb42a4de

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: tobine@google.com
Change-Id: I476f7b9130978a6dfacbd1318beb1f4d61ed8d3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033423Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#737493}

This CL adds WebTimeActivityProvider which is
BrowserListObserver, a TabStripModelObserver,
AppServiceWrapper::EventListener, and
WebTimeNavigationObserver::EventListener. It is hosted
in AppTimeController.

The instance of this class observes
the TabStripModel of each Browser in BrowserList. It also
observes the WebTimeNavigationObserver instances of each WebContent
hosted in each Browser window. The instance also observes
AppServiceWrapper to learn about the activation/deactivation of
chrome application windows.

WebTimeActivityProvider informs its observers when Chrome becomes
Active, Active with whitelisted content or inactive.

Bug: 1034551
Change-Id: I7d7dd3624ea4fb764c13e35f0ef542759cee8933
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020522Reviewed-by: Aga Wronska <agawronska@chromium.org>
Commit-Queue: Yilkal Abe <yilkal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737492}

What: Record a use counter whenever a large sticky ad is detected on
a page. Large sticky ads stands for ad iframes with size >30% browser
viewport size, and stick to the page regardless of a user’s efforts to
scroll.

Why: We’d like to learn where and how often they are used, as a signal
to Centrifuge and eventually to unload them automatically as a browser
intervention.

How: Add a StickyFrameTracker to FrameView that tracks and stores the
latest 10 viewport_offset/main_frame_scroll_offset through
FrameView::UpdateViewportIntersection, which will be called whenever
there's a scroll on the main page. Apply the detection heuristic
(see sticky_frame_tracker.h) and record a use counter as necessary.

We calculate/propagate the flag can_skip_sticky_frame_tracking to child
frames to save the cost of most rendering/sticky-tracking, as most
frames should be small so we could skip tracking its children. However
it's still hard to gauge the performance impact of those cases that
needs the extra renderings, so hide this functionality behind a feature
flag.


Bug: 1013070
Change-Id: I17d65ac915593ea3496bd6391fe6e163f0c57e82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852105
Commit-Queue: Yao Xiao <yaoxia@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737491}

After many recent changes, including the switch to Skia Gold for
maintaining baselines, this test is passing at least on the Nexus 5,
6, 5X, 6P, and 9 on the chromium.gpu.fyi waterfall. Remove the global
suppression for [android no-skia-renderer]; will re-add specific
suppressions if needed.

Bug: 927107
Change-Id: I370fa474a3bd006ae7dff6cdff92b4bfec85c55b
Tbr: ccameron@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033565Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737490}

https://skia.googlesource.com/skia.git/+log/3e98c0e1d115..c0c0522e8076

git log 3e98c0e1d115..c0c0522e8076 --date=short --first-parent --format='%ad %ae %s'
2020-01-31 mtklein@google.com let's try to fix nullptr + k
2020-01-31 robertphillips@google.com Minor GM cleanup
2020-01-31 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2020-01-31 drott@chromium.org Remove CGFontRef parameter from SkMakeTypefaceFromCTFont
2020-01-31 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2020-01-31 jvanverth@google.com Enable async MTLLibrary and MTLRenderPipelineState creation.
2020-01-31 jlavrova@google.com Small fix:
2020-01-31 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2020-01-31 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps
2020-01-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 ee07cb317579..e196bc85ac2d (3 commits)
2020-01-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 430def835f9f..79b36b640692 (6 commits)
2020-01-31 herb@google.com Add reverse iterators to SkSpan
2020-01-30 herb@google.com Cleanup GrStrike management because we do not abandon strikes
2020-01-30 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2020-01-30 fmalita@chromium.org [sksg] Clean up public headers
2020-01-30 scroggo@google.com Expose the ICC profile from SkAndroidCodec
2020-01-30 mtklein@google.com pdf rasterization
2020-01-30 egdaniel@google.com Update GrSurfaceProxy::Copy to return a view.
2020-01-30 hcm@google.com update release notes page to include M81
2020-01-30 hcm@google.com new section and formatting
2020-01-30 brianosman@google.com Reland "Fix skshaper in component builds"
2020-01-30 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps
2020-01-30 rosasco@google.com Change fidl tables from cpp to c.
2020-01-30 robertphillips@google.com Add compressed backend textures to Metal (take 2)
2020-01-30 jlavrova@google.com Fix placeholders in cache
2020-01-30 jlavrova@google.com Dead code
2020-01-30 hcm@google.com Update Skia milestone to 82
2020-01-30 halcanary@google.com decs/examples: Support more fiddle types: offscreen, srgb
2020-01-30 brianosman@google.com Revert "Fix skshaper in component builds"
2020-01-30 brianosman@google.com Revert "Use separate SKSHAPER_DLL define to activate shared library logic"
2020-01-30 fmalita@chromium.org [skottie] Cleanup: convert remaining effects to new adapter pattern

Created with:
  gclient setdep -r src/third_party/skia@c0c0522e8076

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC reed@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1033478
Tbr: reed@google.com
Change-Id: Ie0574670c81ea0aeecbd094e9f55876885334da8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033422Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#737489}

content's CSP are gone. They have been merged into network::mojom's CSP.
This patch updates the content/common/native_types.mojom to reflect this.

See UnifyCSP:
https://docs.google.com/document/d/1v5mJnXJ5dSVXE_rgvJnNM9bzH0ni0YzdhPQ7GLqyhao

Bug: 1021462
Change-Id: I1b254e196f5162844d9f9ae2b466b17259d8a07a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030963
Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737488}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: I34d9be35fa6f05f872e2f306ede93bb02f45269b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033585Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#737487}

This CL adds 2 new user actions:
 - MobileLocationBarTapped
 - MobileToolbarSearchButtonTapped

And documents MobileOmniboxFocused as not_user_triggered,
because MobileOmniboxFocused is logged far from the actual
UI action handler.

These 2 new metrics will allow to distinguish the way how
omnibox was focused (tapping search button on bottom toolbar vs.
tapping the omnibox).

This CL will help to improve the quality of breadcrumbs logs,
which is attempt to attach steps to reproduce to crashlogs.
Breadcrumbs will ignore MobileOmniboxFocused and will log
MobileLocationBarTapped, MobileToolbarSearchButtonTapped and
MobileFakeboxNTPTapped.

Bug: 1046223
Change-Id: Iae681615fb9eae491618f93f44a251e8c515eca1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031879
Auto-Submit: Eugene But <eugenebut@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Jesse Doherty <jwd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737486}

https://webrtc.googlesource.com/src.git/+log/261f792f836a..9d56b0113fff

git log 261f792f836a..9d56b0113fff --date=short --first-parent --format='%ad %ae %s'
2020-01-31 steveanton@webrtc.org Re-enable a couple PortAllocator tests under ASAN
2020-01-31 steveanton@webrtc.org Remove benwright@webrtc.org from WATCHLISTS
2020-01-31 danilchap@webrtc.org In RtpFrameReferenceFinder VP8 clean not yet received before filling it

Created with:
  gclient setdep -r src/third_party/webrtc@9d56b0113fff

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I3fd9a8efdbc97eafad63c8850d885cc8837a11ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033591Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#737485}

This patch passes the origin of the iframe that called the
PaymentRequest API to the fetcher of manifest files, which
uses it for sec-fetch-site headers. This patch is for service
worker based payment handlers on both Android and desktop.
This patch does not alter how iOS or native Android apps work.

Bug: 966507
Change-Id: I97b6ca08fd9e08d1762f95d7b78edf7d73450aee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636635
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737484}

The DCHECK passes most of the time, but not always. It is inherently
racy, as external code could change the thread priority between when
we set it and when we DCHECK it. Removing it as the failures are
not actionnable.

Bug: 1044882
Change-Id: I0adb7a801c10fb15ada3ed229175fb08c0232b8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031705Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737483}

Register it in ChromePreferenceKeys and use SharedPreferencesManager
consistently instead of SharedPreferences directly.

Bug: 1022108
Change-Id: Id810a00d8135d6e742f314bc01573aa3fe7c463c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032330
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737482}

Change-Id: Ia549368f095c81a296081aacaf8fd6a05da2b4ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026407Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: David Dorwin <ddorwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737481}

This reverts commit 57213418.

Reason for revert: Causing compile error in win-chrome builder: https://ci.chromium.org/p/chrome/builders/ci/win-chrome

Original change's description:
> [3P blocking] Fix tests accessing the ModuleDatabase on the UI thread
> 
> The ModuleDatabase was moved to its own sequence but both the
> IncompatibleApplicationsBrowserTest and ThirdPartyBlockingBrowserTest
> test fixtures were not updated.
> 
> This CL moves the accesses to the ModuleDatabase instance to the right
> sequence.
> 
> Also added an override for the OutOfProcessQuarantine feature to allow
> local testing. This was not an issue on the bots because they respect
> the fieldtrial_testing_config.json file.
> 
> Bug: 850517
> Change-Id: I2e8955b33cd7ffc75f74dd56b01df9dec96fc604
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031742
> Commit-Queue: Chris Hamilton <chrisha@chromium.org>
> Reviewed-by: Chris Hamilton <chrisha@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#737448}

TBR=chrisha@chromium.org,pmonette@chromium.org

Change-Id: I6067a3b50bb835025807ff1b81e7787cda35625d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 850517
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033634Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737480}

This adds an exemption for legacy TLS errors from being fatal errors.
This also adds a browser test (to ensure the interstitial is always
bypassable) and a unittest (to ensure that legacy TLS errors aren't
marked as fatal).

Bug: 1047777
Change-Id: Ia50bff281d7c68f4f678e9b6209f7bc7aaa495f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033644Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Christopher Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737479}

I noticed that we leave a crufty debug.log file in the directory
when our MSI is removed.  I added a custom action to clean it
up so we don't leave cruft on the system during upgrades or
uninstalls.

Change-Id: Ibbb13dcdcbc60dc95c3db4996d1243637354afe5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033625Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737478}

the editor bubble.

Bug: 1040657
Change-Id: I532ffcc9257e038292f7a3d2d33ae31a50744558
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028161Reviewed-by: Connie Wan <connily@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Charlene Yan <cyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737477}

* Remove no-longer-relevant default exclude filter for assets/unwind_cfi
* Fix diff size colorings not being correct upon first load
* Make method count mode size colorings a thing
* Add a devtools log message to show how to query the web worker

Bug: None
Change-Id: I27344c50ee0c6d1a93b97055fa7d2176fff263c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032807
Commit-Queue: Samuel Huang <huangs@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737476}

These will be used to debug extreme outlier values of the
PageLoad.InputDelay3 histogram.

First, add all event types used to calculate PageLoad.InputDelay3 to
Event.Latency.OS. Move the calls to generate the histogram into the
functions that build the events, because the calling functions for the
new event types have much more complex logic.

Second, add new versions of Event.Latency.OS without the call to
ValidateEventTimeClock(). This call fixes some potential causes of
extreme values, so adding histograms which do not include it can help
determine if it masks the problem.

Bug: 1039833
Change-Id: I48cfa3613dd7c6a1d15b75e7a91f53b3f46a90c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022346Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737475}

These are largely straightforward.

Bug: 1011446
Change-Id: Ifaf8be23c5e64743beafa0025817e3e0271788e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033437
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737474}

The C++ code generated will be used in Blink's
document_metadata_extractor.

Bug: 1044250
Change-Id: I49db529fa95bf6868eabeb6f0718476fd904898a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029010
Commit-Queue: Sam Bowen <sgbowen@google.com>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737473}

I can't repro locally nor using mb tool to repro. mb tool can
only launch jobs in chromium.tests pool which is a different
pool than internal bots.
I hope with the android id logged, we can find out what's going
on on the server side.

Bug: 1043347
Change-Id: I70ac3005b0b568284a18d76b35dee160d27c00b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031537Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Sven Zheng <svenzheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737472}

Make the smart card PIN errors being dispatched to the a11y subsystem
more reliably, by directly associating the error text with the PIN input
field.

This allows to support the scenario when the PIN keyboard is hidden
during PIN verification animation and shown back. Before this CL, the
error alert would be lost in such scenario, since it's followed by the
focus switch events.

Also do a small cleanup by removing the "aria-invalid" attribute from
the <pin-keyboard> element, since it doesn't seem to be recognized by
the a11y screen reader, meanwhile the actual useful attribute is already
set thanks to the dataflow "<pin-keyboard has-error>" => "<cr-input
invalid>" => "<input aria-invalid>".

Bug: 1001612, 1016839
Change-Id: Ib7baff4bf5d172ada92fbb035455894b1baff5ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031106
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737471}

This CL adds feature parameters that create allowlists or blocklists for
warnings, blocking and silent blocking. Finally, it updates the
triggering logic to use those parameters.

The triggering code contains default file extensions which are used when the
feature parameter is not set. These are only used when the user
explicitly enables the feature for testing.

To make testing easier, we:
 - SILENT_BLOCK on files ending in the contrived
   ".silently_block_for_testing".
 - BLOCK files that are executables or archive types, or any download
   that's explicitly user-requested (e.g. from a context menu).
 - WARN on everything else except ".dont_warn_for_testing" files.

Bug: 960819
Change-Id: I006d4e0c3f45b64e3cd84b0ef21cc506988bf5cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984703
Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737470}

Change-Id: Ib2b07973169a5cddf614b0a00f97a1edd15e67df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033590Reviewed-by: vikas soni <vikassoni@chromium.org>
Commit-Queue: vikas soni <vikassoni@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Auto-Submit: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737469}

If an there's an existent modal it means one is currently presented, or in
the process of being presented. Configuring a new one would only cause
InfobarCoordinator to hold pointers to a Modal that won't be presented.

This CL prevents that by stopping any new configuration if a Modal already
exists.

It also removes modalNavigationController since we can get the
NavigationController from the modal.

Bug: 1040066
Change-Id: Ia2da22d67804e39780b19b78af2dcba58fa8a580
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032565Reviewed-by: Chris Lu <thegreenfrog@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737468}

Mark the DeviceSamlLoginAuthenticationType policy as "future", in order
to hide it from the policy documentation.

This policy is unused. It was originally intended for configuring the
Chrome OS smart card user login feature for all users on the given
device, but the design was later changed to support users of both types
(smart card and non smart card) on the same device, by determining the
case dynamically.

BYPASS_POLICY_COMPATIBILITY_CHECK=policy was never used

Bug: 826417
Change-Id: If76b55076d09d5c09e985a3730bf954c72a9f963
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030898Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737467}

This reland fixes the sequenced task runner initialisation. Set the
task runner in the constructor and reset it for each unit test execution.

Since there may be multiple instance of DWriteFontProxyImpl instantiated
for multiple RenderProcessHosts, and
DWriteFontProxyImpl::GetUniqueNameLookupTable may access
DWriteFontLookupTableBuilder::QueueShareMemoryRegionWhenReady from
separate threads, there may be race conditions around the
pending_callbacks_ member of DWriteFontLookupTableBuilder.

Sequentialise and guard access to pending_callbacks_ with a separate
sequenced task runner.

Remove explicit configuration of the FontUniqueNameBrowserTest cache
directory as [1] introduced a callback function in
ShellContentBrowserClient which sets this correctly. This avoids
instantiating DWriteFontLookupTableBuilder too early when the ThreadPool
is not yet available in a BrowserTest.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1776358/9/content/shell/browser/shell_content_browser_client.cc#422

Fixed: 1047054
Change-Id: I38cf8b84a48315980624b68bbf55d3727be457b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032119Reviewed-by: Matthew Denton <mpdenton@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737466}

Using wpt-import in Chromium 27802b89.
With Chromium commits locally applied on WPT:
d455934d "Clamp the presentation time to a usable range"
4a9e20a2 "[ElementTiming and LargestContentfulPaint]Fix background img sizes"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: I836d46d366b37cf2e71f57ca653dc70f3ed8453f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032306Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#737465}

This fixes the following warning that was printed almost
unconditionally:

  "Ignoring untrusted value of the
  extensions.install.login_screen_extensions pref"

Also the CL removes unnecessary handling of the nullptr pref value,
as this case should never occur.

Bug: 1012892
Test: verify that no "Ignoring untrusted value" log appears in browser_tests --gtest_filter="SigninProfileExtensionsAutoUpdatePolicyTest.Test"
Change-Id: I41a18ae371b3b9a01fe9a6926731e5550fd0987f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029507Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737464}

Change-Id: I8ef8ec496ab0fb8857db60d1d8aeb55212b23bcb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033542
Commit-Queue: Peter Williamson <petewil@chromium.org>
Commit-Queue: Dan H <harringtond@chromium.org>
Auto-Submit: Peter Williamson <petewil@chromium.org>
Reviewed-by: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737463}

Bug: 1047269
Change-Id: Idc9e1547a2be65ff638429ecffcdd6c5149c1b50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031753Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Oliver Li <olivierli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737462}

The crashes caused by this DCHECK happens when a begin-impl-frame
reports no damage, and then presented without frame end. This CL
fixes it.

Bug: 1043091
Change-Id: Idaef2477f7f2904fec87b202c47a3a9be6b95c42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018084Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737461}

https://pdfium.googlesource.com/pdfium.git/+log/62c4aa446733..7b8eb884cfd6

git log 62c4aa446733..7b8eb884cfd6 --date=short --first-parent --format='%ad %ae %s'
2020-01-31 tsepez@chromium.org Make all CXFA_FFWidget observe their CXFA_FFPageview.
2020-01-31 thestig@chromium.org Fix various build/include_order lint errors.
2020-01-31 thestig@chromium.org Give some .in test files better formatting.
2020-01-31 tsepez@chromium.org Remove dwCoordinatesType arg from GetPageMatrix().
2020-01-31 thestig@chromium.org Reduce the number of calls to HasPermissions().
2020-01-31 thestig@chromium.org Move permission constants to constants/access_permissions.h.
2020-01-31 dhoss@chromium.org Run tests with --disable-xfa in coverage_report.py

Created with:
  gclient setdep -r src/third_party/pdfium@7b8eb884cfd6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1010844,chromium:1042915
Tbr: pdfium-deps-rolls@chromium.org
Change-Id: I6415f31dfba3a5156486c3f53cb14e64d455c30a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033586Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#737460}

cros_supported_configs_ is defined iff OS_CHROMEOS is defined.
However, it is used iff USE_CHROMEOS_MEDIA_ACCELERATION regardless of
OS_CHROMEOS.
This CL aligns the conditions.

BUG=1047719
TEST=Build locally.

Change-Id: I08fe8532c1778ff8c77c7a9d9cdd96ff2a83272f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030924Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737459}

This CL introduces Mojo enums for settings section names and page
visibility as well as a SettingsUserAction class and several derived
classes which encapsulate user actions in settings.

Bug: 1047062
Change-Id: I04d1648ade1f8b25dc83c2f32805a22bd4c23458
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030000Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737458}

One of these retains a callback method on the object; the other uses the
lambda-captures-&controller pattern.

Bug: 1011446
Change-Id: Ic5ea4f6231a94e3e6d14d646bb78f00220e90ad0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032231Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737457}

Bug: 1021634
Change-Id: I7ac7a2ea5a9bdcc5a244057f74bc8305773546ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026150
Commit-Queue: benjamin joyce <bjoyce@google.com>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737456}

This is a reland of 97332534

Original change's description:
> x11: Ensure XEvent translation is equivalent to ui::Event ctors
>
> This is part of the patch series migrating PlatformEvent to ui::Event
> (formerly using XEvent) in Aura/X11 in order to eliminate this
> fundamental difference/incompatibility between Ozone and non-Ozone X11
> ports. Design doc [1] describes in details such effort.
>
> This CL, particularly, is meant to ensure XEvent => ui::Event
> translation code (x11_event_translation.{h,cc}) is equivalent to
> constructing ui::*Event using the PlatformEvent ctors, the mechanism
> used so far to do such "translation".
>
> To achieve it, events_unittests have been modified to use the brand new
> X11 event translation code as well as fixing discrepancies found along
> the way. Most of them are trivial and this change does not bring any
> behavioral change.
>
> [1] https://docs.google.com/document/d/1Neh2p6f8pew9SPuEAtnJMafozAY7uhAIfhwd43CLETc
>
> Bug: 965991
> Change-Id: I1b738fd20c21233a611a0661b76da7fcdf176613
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022322
> Commit-Queue: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#736213}

Bug: 965991, 1047005
Change-Id: I07d7ced6460845faa36d91b7e38bae10ff4697c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028408
Commit-Queue: Nick Yamane <nickdiego@igalia.com>
Reviewed-by: Nick Yamane <nickdiego@igalia.com>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737455}