GitLab

NetworkProject's cleanup logic currently relies on resources in
resourceTreeFrame. This patch adds tests with scripts and
stylesheets which don't have underlying resource:
- contentscript-* tests validate bindings creating and removing
  UISourceCodes for content scripts
- dynamic-* tests validate bindings creating and removing
  UISourceCodes for dynamically-created styles

As a drive-by, the patch improves the InspectorTest.dumpWorkspace()
method to also produce a diff with the previous workspace dump.
This helps to read expectations a lot.

R=dgozman
BUG=670180

Review-Url: https://codereview.chromium.org/2738033002
Cr-Commit-Position: refs/heads/master@{#455973}

Currently, every UI.Icon sets background-position property in its
element.style.

In case of masks and gradients, this property might actually affect
the gradient position.

This patch starts using --spritesheet-position css variable to
actually set the icon position in the resources.

Drive-by: simplify classes for "force-white-icons".

R=dgozman
BUG=none

Review-Url: https://codereview.chromium.org/2740913003
Cr-Commit-Position: refs/heads/master@{#455972}

In situations where shared objects fail to install when an app is updated,
this change prevents loading of out-of-date shared objects because the shared
object name now changes with every app update.  Loading out-of-date
shared objects can crash the app.  Failing to find the shared object
(because the name has changed) gives a LibraryLoader registered with
CronetEngine.Builder.setLibraryLoader() a chance to unzip it from the APK.

R=kapishnikov
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2741773003
Cr-Commit-Position: refs/heads/master@{#455971}

Current guidelines for defining critical memory state is swapping will
occur in that situation. Update MemoryMonitorChromeOS to align the
guidelines.

- Use |available| field of base::SystemMemoryInfoKB if the OS supports it
- Don't count SwapFree as free available memory

BUG=696844

Review-Url: https://codereview.chromium.org/2731273003
Cr-Commit-Position: refs/heads/master@{#455970}

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431

Review-Url: https://codereview.chromium.org/2741023002
Cr-Commit-Position: refs/heads/master@{#455969}

Expose the already existing PrefStore implementations, which are
owned through the profile, through the new prefs service. This
new prefs service will replace the current pref service prototype
used in mash and support synchronous deletions and decoupling the
creation of the underling pref stores.

The service is gated by a default-off feature flag.

BUG=654988

Review-Url: https://codereview.chromium.org/2740493002
Cr-Commit-Position: refs/heads/master@{#455968}

Review-Url: https://codereview.chromium.org/2744553004
Cr-Commit-Position: refs/heads/master@{#455967}

This is a preparatory step for splitting MD Settings to a main
and a lazy module.

BUG=597347
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2726403003
Cr-Commit-Position: refs/heads/master@{#455966}

Per spec[1] and tests[2] the constructors for Blob and File and
their slice() methods should not throw if non-printable-ASCII type
is supplied; instead it should use "" as the type. In addition, the
type should be consistently lower-cased, by both the constructors
and slice() method.

[1] https://w3c.github.io/FileAPI/
[2] https://github.com/w3c/web-platform-tests/tree/master/FileAPI

BUG=509786
R=kinuko@chromium.org

Review-Url: https://codereview.chromium.org/1362963003
Cr-Commit-Position: refs/heads/master@{#455965}

Build: https://build.chromium.org/p/chromium.infra.cron/builders/rebaseline-o-matic/builds/627712

https://chromium.googlesource.com/chromium/src/+/246a46ddac248

BUG=697448
TBR=robhogan@gmail.com

Review-Url: https://codereview.chromium.org/2745653004 .
Cr-Commit-Position: refs/heads/master@{#455964}

moveCursorToSelectionEnd()  blocks the IME thread unnecessarily, which causes
back navigation to fail. So this CL removes moveCursorToSelectionEnd() and
replaces with mWebContents.unselect().

In RenderFrameImpl::OnUnselect(), the cursor is deleted entirely, which causes
text boxes to be unfocused as a side effect. To fix that, this CL collapses the
selection to the selection end, and renames the functions to CollapseSelection().

BUG=697756
TEST=run_chrome_public_test_apk --test-filter TabsTest.testTabSwitcherCollapseSelection

Review-Url: https://codereview.chromium.org/2734943005
Cr-Commit-Position: refs/heads/master@{#455963}

https://skia.googlesource.com/skia.git/+log/3304c447b953..94cbbba96f1a

$ git log 3304c447b..94cbbba96 --date=short --no-merges --format='%ad %ae %s'
2017-03-09 reed prealloc room for some number of Elements to avoid malloc

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=djsollen@chromium.org

Change-Id: I801e486404da0a9addb6ed8c754aa2638da96b62
Reviewed-on: https://chromium-review.googlesource.com/452666Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#455962}

Part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API.

This patch
- added CSSPropertyAPILineHeight.cpp, which implements CSSPropertyAPI.h
- added parseSingleValue method to the CSSPropertyAPILineHeight API
- removed CSSPropertyLineHeight from the switch
  statement in parseSingleValue, and calls the API instead.
- added api implementation details to CSSProperties.json5, indicating that
  CSSPropertyAPILineHeight.h is generated.

A function pointer to the parseSingleValue function from the API for the
line-height property is stored in a CSSPropertyDescriptor, and is called
from CSSPropertyParser.

Originally authored in patch 2642783005 by sashab@chromium.org

BUG=668012

Review-Url: https://codereview.chromium.org/2735093005
Cr-Commit-Position: refs/heads/master@{#455961}

BUG=697971

Review-Url: https://codereview.chromium.org/2744753002
Cr-Commit-Position: refs/heads/master@{#455960}

This patch simply inlines _drawSimplifiedBarDetails. This is because
this function's functionality will be reduced in future patches and will
make it eassier to review follup patches.

R=caseq
BUG=697668

Review-Url: https://codereview.chromium.org/2730633002
Cr-Commit-Position: refs/heads/master@{#455959}

Safe Browsing will now be enabled for any app which opts in by setting
the flag `android.webkit.WebView.EnableSafeBrowsing` to "true",
regardless of Android version or Target SDK.

BUG=699193

Review-Url: https://codereview.chromium.org/2739003002
Cr-Commit-Position: refs/heads/master@{#455958}

BUG=687806
TEST=none

Review-Url: https://codereview.chromium.org/2723843002
Cr-Commit-Position: refs/heads/master@{#455957}

BUG=693226
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2733273002
Cr-Commit-Position: refs/heads/master@{#455956}

Disable sina.com.cn as if fails as part of v8.runtime_stats.top_25 on Linux

BUG=699579

Review-Url: https://codereview.chromium.org/2744733002
Cr-Commit-Position: refs/heads/master@{#455955}

In root layer scrolling mode, the main GraphicsLayer in the LayoutView's
CompositedLayerMapping is now connected directly to the VisualViewport scroll
layer (in the main frame), or to the layer of an owning LayoutIFrame.

BUG=698464
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2728273002
Cr-Commit-Position: refs/heads/master@{#455954}

We are adding COMPONENT/TEAM information into OWNERS file
(offline_pages, etc).

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
Component lists
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
R=dewittj@chromium.org

Review-Url: https://codereview.chromium.org/2744723002
Cr-Commit-Position: refs/heads/master@{#455953}

BUG=681232

Review-Url: https://codereview.chromium.org/2736403005
Cr-Commit-Position: refs/heads/master@{#455952}

DCHECK(m_globalProxy != context()->Global()) sometimes fail. In builds
with DCHECKs turned off this issue manifests with "Type Error: no
access" errors in console and scripts not working.

Started happening approx. in M56.
Repro steps:
1. Install several extensions;
2. Visit a number of pages in a tab;
3. Do a lot of back and forward navigations quickly (not waiting till
pages load).

This is caused by setting the global object in WindowProxy after it was
initialized. This happens when WindowProxyManagerBase::setGlobals
processes a non-main world first. It sends out a didCreateScriptContext
call. ExtensionFrameHelper::DidCreateScriptContext wants to know whether
it is the main world script context, and compares with
WebLocalFrameImpl::mainWorldScriptContext(). As a result, main world
script context is initialized. At this point the call stack is like this:
1  blink::LocalWindowProxy::initialize
2  blink::ScriptController::windowProxy
3  blink::toV8Context
4  blink::ScriptState::forMainWorld
5  blink::WebLocalFrameImpl::mainWorldScriptContext
6  extensions::ExtensionFrameHelper::DidCreateScriptContext
7  content::RenderFrameImpl::didCreateScriptContext
8  blink::LocalWindowProxy::initialize
9  blink::WindowProxy::setGlobal
10 blink::WindowProxyManagerBase::setGlobals
11 blink::WebFrame::swap
12 content::RenderFrameImpl::SwapIn
13 content::RenderFrameImpl::didCommitProvisionalLoad
14 blink::FrameLoaderClientImpl::dispatchDidCommitLoad
15 blink::FrameLoader::receivedFirstData
16 blink::DocumentLoader::createWriterFor
17 blink::DocumentLoader::ensureWriter
18 blink::DocumentLoader::commitData

After that WindowProxyManagerBase::setGlobals continues its work and
sets the global object for the main world WindowProxy, and it becomes
broken.

BUG=700077

Review-Url: https://codereview.chromium.org/2743653002
Cr-Commit-Position: refs/heads/master@{#455951}

BUG=697351

Review-Url: https://codereview.chromium.org/2735293002
Cr-Commit-Position: refs/heads/master@{#455950}

Since many tests depend on just these constants, I think is better to
create a separate file for these since the Model classes might change
again and we don't wan't to keep updating these tests.

This CL removes the model code from ToolsMenuVC and fixes a bug in
ToolsMenuModel

Downstream tests compile and run successfully against these changes.

BUG=682880

Review-Url: https://codereview.chromium.org/2722693002
Cr-Commit-Position: refs/heads/master@{#455949}

Disabling it for ElCapitan does not seem to work, disabling it for all mac platforms instead as the orignal comment suggest.

Filed a catapult isuse at https://github.com/catapult-project/catapult/issues/3359

BUG=657665

Review-Url: https://codereview.chromium.org/2744513004
Cr-Commit-Position: refs/heads/master@{#455948}

Added a new utility function to clarify and simplify checking whether
hardware acceleration is currently being used.

R=emaxx@chromium.org, piman@chromium.org, jbauman@chromium.org
BUG=630728

Review-Url: https://codereview.chromium.org/2737273003
Cr-Commit-Position: refs/heads/master@{#455947}

Bug: internal b/35396333
Test: RPI3
Change-Id: Ic8803d1d8fa0571e9c73b6f294c9b45239ce5a2c
Review-Url: https://codereview.chromium.org/2745653002
Cr-Commit-Position: refs/heads/master@{#455946}

This patch makes |adjustedSelectionStartForStyleComputation()| to take
|Position| instead of |VisibleSeleciton| as a preparation of usage of
|VisibleSeleciton| for improving code health.

BUG=657237
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2739023003
Cr-Commit-Position: refs/heads/master@{#455945}

We are adding COMPONENT/TEAM information into OWNERS file
(wft/text).

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
Component lists
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
R=yutak@chromium.org

Review-Url: https://codereview.chromium.org/2739233002
Cr-Commit-Position: refs/heads/master@{#455944}

BUG=689289

Review-Url: https://codereview.chromium.org/2678233002
Cr-Commit-Position: refs/heads/master@{#455943}

There is a bug that, when a document is attached, the idle time spell
checker is requested for cold mode invocation even without the
IdleTimeSpellChecking flag.

This patch fixes the bug. To ensure that idle time spell checker is
only invoked with the flag, a DCHECK is also added to the handleEvnet()
function.

Related unit tests are disabled when there is no flag.

BUG=700081,517298

Review-Url: https://codereview.chromium.org/2744603004
Cr-Commit-Position: refs/heads/master@{#455942}

https://dom.spec.whatwg.org/#dom-range-surroundcontents
According to the DOM standard, we should not check it before starting DOM
mutation. Step 5 throws HierarchyRequestError instead.

This CL fixes 44 tests in wpt/dom/ranges/Range-surroundContents.html.

* images/element-gcd-while-generating-alt-content.html: Removed.
  This CL changes behavior of the test. The test was for a crash bug in
  pre-Olilpan era, and we don't have code for the crash fix any longer.

* fast/dom/Range/surroundContents-1.html: Removed.
  This is a pixel test to verify HierarchyRequestError which this CL removes.
  This behavior is tested well in WPT.

* shadow-dom/range-surround-contents.html: Updated
  DOM trees are modified because this CL removes a precondition check.

BUG=699861

Review-Url: https://codereview.chromium.org/2745443003
Cr-Commit-Position: refs/heads/master@{#455941}

This patch makes |SpellChecker::clearMisspellingsForMovingParagraphs| to take
|SelectionInDOMTree| instead of |VisibleSelection| as a preparation of reducing
usage of |VisibleSelection| for improving code health.

BUG=657237
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2742753002
Cr-Commit-Position: refs/heads/master@{#455940}

https://skia.googlesource.com/skia.git/+log/f1b61afbe971..3304c447b953

$ git log f1b61afbe..3304c447b --date=short --no-merges --format='%ad %ae %s'
2017-03-09 fmalita Revert "Hold sk_sp<GrAtlasTextBlob> refs in GrTextBlobCache instead of raw ptrs"
2017-03-09 halcanary FuzzCanvas: ImageFilter
2017-03-09 reed take fast case in swap() if we're using malloc OR we're empty

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=djsollen@chromium.org

Change-Id: Iaf67dbbf51d0998c930a406c9aee70ccfdedf790
Reviewed-on: https://chromium-review.googlesource.com/452790Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#455939}

Utilize EphemeralRange::commonAncestorContainer() in EditingStyleUtilities::createStyleAtSelectionStart()

This patch changes EditingStyleUtilities::createStyleAtSelectionStart()| to use
|EphemeralRange::commonAncestorContainer()| instead of |Range|'s member function
to reduce source code size for improving code health.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2739123002
Cr-Commit-Position: refs/heads/master@{#455938}

BUG=697448

Review-Url: https://codereview.chromium.org/2736003003
Cr-Commit-Position: refs/heads/master@{#455937}

Chrome has a direct dependency on a custom libprotobuf_lite in
third_party, but Xenial and Yakkety add a dependency on the system
libprotobuf-lite via Mir (which gets loaded from Gtk).

Our third_party protobuf is not compatible with the upstream protobuf.
Combine this with the fact that Xenial uses version 2 while Yakkety
uses version 3, and it's basically impossible to make our third_party
protobuf cooperate with the system one.  The solution is to always
statically link protobuf on Linux.

BUG=79722,700120
R=pkasting@chromium.org
TBR=bengr@chromium.org
CC=dpranke@chromium.org,rsimha@chromium.org

Review-Url: https://codereview.chromium.org/2746493002
Cr-Commit-Position: refs/heads/master@{#455936}

This change moves the MHTML generation step of writing the footer from
the renderer process to the browser process. Even though this spreads
MHTML code knowledge between Blink and content (a drawback) it does make
the generation process more robust and allows MHTML save operations to
become more robust to DOM changes.

The main issue we are facing with the Offline efforts is that frames can
be deleted after a MHTML save operation started and that will likely
cause it to fail completely. With this modification we can allow these
operations to optionally ignore missing frames.

I chose to still keep the footer code generation in MHTMLArchive but
make it explicit it is only used for testing purposes now. It seemed
more consistent and understandable for those tests to keep on generating
and reading fully valid MHTML files.

BUG=672292
TBR=jam@chromium.org

Review-Url: https://codereview.chromium.org/2731293004
Cr-Commit-Position: refs/heads/master@{#455935}

This patch gets rid of include-directive for "VisibleSelection.h" from
"EditCommand.h" to reduce source code size and faster compilation for
improving code health.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2744583002
Cr-Commit-Position: refs/heads/master@{#455934}