1. 29 Apr, 2009 14 commits
    • ddkilzer@apple.com's avatar
      2009-04-28 David Carson <dacarson@apple.com> · 0763416b
      ddkilzer@apple.com authored
              Reviewed by David Hyatt.
      
              Restore alignment to device pixel boundaries.
              https://bugs.webkit.org/show_bug.cgi?id=25458
      
              Adjust the adjusted destination rect to be device pixel aligned.
      
              * platform/graphics/cg/ImageCG.cpp:
              (WebCore::BitmapImage::draw):
      
      2009-04-28  David Carson  <dacarson@apple.com>
      
              Reviewed by David Kilzer.
      
              Restore alignment to device pixel boundaries.
              https://bugs.webkit.org/show_bug.cgi?id=25458
      
              Updated test results with progressions.
      
              * platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
              Yin-yang image shifted slightly to pixel boundaries.
      
              * platform/mac/svg/custom/focus-ring-expected.checksum:
              * platform/mac/svg/custom/focus-ring-expected.png:
              Focus rings drawn around rotated "focus text" and checkered
              images shifted slightly to pixel boundaries.
      
              * platform/mac/svg/custom/image-small-width-height-expected.checksum:
              * platform/mac/svg/custom/image-small-width-height-expected.png:
              Checkered images shifted slightly to pixel boundaries.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42987 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      0763416b
    • ddkilzer@apple.com's avatar
      Added missing pixel test results. · 3dac9d91
      ddkilzer@apple.com authored
              * platform/mac/fast/css-generated-content/beforeAfter-interdocument-expected.checksum: Added.
              * platform/mac/fast/css-generated-content/beforeAfter-interdocument-expected.png: Added.
              * platform/mac/fast/table/cell-coalescing-expected.checksum: Added.
              * platform/mac/fast/table/cell-coalescing-expected.png: Added.
              * platform/mac/webarchive/adopt-attribute-styled-body-webarchive-expected.checksum: Added.
              * platform/mac/webarchive/adopt-attribute-styled-body-webarchive-expected.png: Added.
              * platform/mac/webarchive/adopt-attribute-styled-node-webarchive-expected.checksum: Added.
              * platform/mac/webarchive/adopt-attribute-styled-node-webarchive-expected.png: Added.
              * platform/mac/webarchive/adopt-inline-styled-node-webarchive-expected.checksum: Added.
              * platform/mac/webarchive/adopt-inline-styled-node-webarchive-expected.png: Added.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42986 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      3dac9d91
    • weinig@apple.com's avatar
      2009-04-28 Sam Weinig <sam@webkit.org> · b69d6162
      weinig@apple.com authored
              Reviewed by Anders Carlsson.
      
              Move unimplemented captureEvents and releaseEvents from JSDOMWindow
              to DOMWindow.
      
              * bindings/js/JSDOMWindowCustom.cpp:
              * page/DOMWindow.cpp:
              (WebCore::DOMWindow::captureEvents):
              (WebCore::DOMWindow::releaseEvents):
              * page/DOMWindow.h:
              * page/DOMWindow.idl:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42985 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      b69d6162
    • ap@webkit.org's avatar
      816518f6
    • ap@webkit.org's avatar
      Reviewed by Sam Weinig. · 67ea898e
      ap@webkit.org authored
              https://bugs.webkit.org/show_bug.cgi?id=25420
              <rdar://problem/6829570> REGRESSION: XMLHttpRequest allows loading from another origin
      
              Test: http/tests/xmlhttprequest/detaching-frame-2.html
      
              This was caused by faulty DOMWindow::document(), which could return a new document from
              the window's frame after navigation.
      
              * bindings/js/JSDOMWindowCustom.h: (WebCore::JSDOMWindowBase::allowsAccessFromPrivate):
              Removed an obsolete check that allowed access when document was null. Contrary to what a
              comment said, that can happen for a window that is no longer in frame, not to one whose
              document is not constructed yet.
      
              * bindings/js/JSXMLHttpRequestConstructor.cpp: (WebCore::constructXMLHttpRequest): Bail
              out if context was not found. This currently happens due to a shortcoming in
              DOMWindow::document() - when it is fixed, the XMLHttpRequest object in included regression
              test will be constructed successfully, but won't be sent, because its context will be
              frameless.
      
              * page/DOMWindow.cpp: (WebCore::DOMWindow::document): Check that the window in frame hasn't
              been replaced yet. Added FIXME comments about how this may be better fixed in the future.
      
              * bindings/js/JSAudioConstructor.cpp:
              (WebCore::JSAudioConstructor::document):
              (WebCore::constructAudio):
              * bindings/js/JSImageConstructor.cpp:
              (WebCore::JSImageConstructor::document):
              (WebCore::constructImage):
              * bindings/js/JSMessageChannelConstructor.cpp:
              (WebCore::JSMessageChannelConstructor::construct):
              * bindings/js/JSOptionConstructor.cpp:
              (WebCore::JSOptionConstructor::document):
              (WebCore::constructHTMLOptionElement):
              Make matching changes to other constructors that hold a reference to global object.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42983 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      67ea898e
    • oliver@apple.com's avatar
      Bring back r42969, this time with correct codegen · e8420b29
      oliver@apple.com authored
      Reviewed by Gavin Barraclough.
      
      Add logic to the codegen for right shift to avoid jumping to a helper function
      when shifting a small floating point value.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42982 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      e8420b29
    • kevino@webkit.org's avatar
      wxMSW build fix. Switch JSCore build back to static. · 254d1d8f
      kevino@webkit.org authored
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42980 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      254d1d8f
    • ddkilzer@apple.com's avatar
      2009-04-28 Pierre d'Herbemont <pdherbemont@apple.com> · a199e848
      ddkilzer@apple.com authored
              Reviewed by David Kilzer.
      
              https://bugs.webkit.org/show_bug.cgi?id=25462
      
              Make sure "--pixel --add-platform-exceptions" produces platform
              specific pixel test results.
      
              * Scripts/run-webkit-tests: Support "--pixel
              --add-platform-exceptions"
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42979 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      a199e848
    • oliver@apple.com's avatar
      Roll out r42969, due to hangs in build bot. · e100184f
      oliver@apple.com authored
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42978 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      e100184f
    • eric@webkit.org's avatar
      Reviewed by Simon Fraser. · 13cfdad8
      eric@webkit.org authored
              Add a couple table hit tests
              https://bugs.webkit.org/show_bug.cgi?id=21892
      
              * svg/hittest/svg-inside-display-table-expected.txt: Added.
              * svg/hittest/svg-inside-display-table.xhtml: Added.
              * svg/hittest/svg-inside-table-expected.txt: Added.
              * svg/hittest/svg-inside-table.xhtml: Added.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42977 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      13cfdad8
    • oliver@apple.com's avatar
      Improve performance of string indexing · 45f1eb1e
      oliver@apple.com authored
      Reviewed by Geoff Garen
      
      Add a cti_get_by_val_string function to specialise indexing into a string object.
      This gives us a slight performance win on a number of string tests.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42976 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      45f1eb1e
    • eric.carlson@apple.com's avatar
      2009-04-28 Pierre d'Herbemont <pdherbemont@apple.com> · f6669c1e
      eric.carlson@apple.com authored
              Reviewed by Simon Fraser.
      
              <rdar://problem/6834830>
      
              Make sure we cover the two possible values reported by event.total that are playback engine
              specific.
      
              * media/progress-event-total-expected.txt: Match the new test.
              * media/progress-event-total.html: Test the two values.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42975 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      f6669c1e
    • timothy@apple.com's avatar
      Rename -[DOMRange lineBoxRects] to -[DOMRange textRects] and change how it · 91ebab1f
      timothy@apple.com authored
              collects the individual rects, making sure to only include RenderText.
      
              <rdar://problem/6810061>
      
              Reviewed by Sam Weinig.
      
              * bindings/objc/DOM.mm:
              (-[DOMNode textRects]): Added. Make a Range and call textRects.
              (-[DOMNode lineBoxRects]): Call textRects method.
              (-[DOMRange textRects]): Call Range::textRects.
              (-[DOMRange lineBoxRects]): Call textRects method.
              * bindings/objc/DOMPrivate.h: Add the new methods and a comment
              about lineBoxRects being deprecated.
              * dom/Range.cpp:
              (WebCore::Range::boundingBox): Call textRects (renamed from addLineBoxRects).
              (WebCore::Range::textRects): Renamed from addLineBoxRects. Iterate over the
              nodes instead of the RenderObjects to correctly account for offsets. Also
              only call absoluteRectsForRange on RenderText.
              * dom/Range.h: Renamed addLineBoxRects to textRects.
              * page/Frame.cpp:
              (WebCore::Frame::selectionTextRects): Call textRects (renamed from addLineBoxRects).
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::absoluteRectsForRange): Remove if conditions that made this
              function very specific for the lineBoxRects API. These functions are still used
              by the InspectorController, and this change improves what the Inspector shows.
              (WebCore::RenderObject::absoluteQuadsForRange): Ditto.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42974 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      91ebab1f
    • timothy@apple.com's avatar
      Remove the topLevel boolean argument from absolute{Rects,Quads}. · b2e63e4f
      timothy@apple.com authored
              This argument was default to true and no one ever passed false.
      
              Reviewed by Sam Weinig.
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::absoluteRects):
              (WebCore::RenderBlock::absoluteQuads):
              * rendering/RenderBlock.h:
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::absoluteRects):
              (WebCore::RenderBox::absoluteQuads):
              * rendering/RenderBox.h:
              * rendering/RenderInline.cpp:
              (WebCore::RenderInline::absoluteRects):
              (WebCore::RenderInline::absoluteQuads):
              * rendering/RenderInline.h:
              * rendering/RenderObject.h:
              (WebCore::RenderObject::absoluteRects):
              (WebCore::RenderObject::absoluteQuads):
              * rendering/RenderSVGHiddenContainer.cpp:
              (WebCore::RenderSVGHiddenContainer::absoluteRects):
              (WebCore::RenderSVGHiddenContainer::absoluteQuads):
              * rendering/RenderSVGHiddenContainer.h:
              * rendering/RenderSVGImage.cpp:
              (WebCore::RenderSVGImage::absoluteRects):
              (WebCore::RenderSVGImage::absoluteQuads):
              * rendering/RenderSVGImage.h:
              * rendering/RenderSVGInlineText.cpp:
              (WebCore::RenderSVGInlineText::absoluteRects):
              (WebCore::RenderSVGInlineText::absoluteQuads):
              * rendering/RenderSVGInlineText.h:
              * rendering/RenderSVGModelObject.cpp:
              (WebCore::RenderSVGModelObject::absoluteRects):
              (WebCore::RenderSVGModelObject::absoluteQuads):
              * rendering/RenderSVGModelObject.h:
              * rendering/RenderSVGTSpan.cpp:
              (WebCore::RenderSVGTSpan::absoluteRects):
              (WebCore::RenderSVGTSpan::absoluteQuads):
              * rendering/RenderSVGTSpan.h:
              * rendering/RenderSVGText.cpp:
              (WebCore::RenderSVGText::absoluteRects):
              (WebCore::RenderSVGText::absoluteQuads):
              * rendering/RenderSVGText.h:
              * rendering/RenderSVGTextPath.cpp:
              (WebCore::RenderSVGTextPath::absoluteQuads):
              * rendering/RenderSVGTextPath.h:
              * rendering/RenderText.cpp:
              (WebCore::RenderText::absoluteRects):
              * rendering/RenderText.h:
              * rendering/RenderView.cpp:
              (WebCore::RenderView::absoluteRects):
              (WebCore::RenderView::absoluteQuads):
              * rendering/RenderView.h:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42973 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      b2e63e4f
  2. 28 Apr, 2009 26 commits
    • eric.carlson@apple.com's avatar
      2009-04-28 Eric Carlson <eric.carlson@apple.com> · 9ec57c33
      eric.carlson@apple.com authored
              Reviewed by Simon Fraser.
      
              <rdar://problem/6794691> Media documents and <video controls> never show controls on Windows
      
              RenderThemeWin doesn't implement the media element controller rendering methods, so media
              controls stopped rendering when we switched from RenderThemeSafari. Rather than having copies
              of the code in both places, the logic is in a new class that is called from both.
      
              * WebCore.vcproj/WebCore.vcproj: Add RenderMediaControls.cpp.
      
              * rendering/RenderMediaControls.cpp: Added.
              (WebCore::determineState): Translate renderer state to ThemeControlState.
              (WebCore::RenderMediaControls::adjustMediaSliderThumbSize): Adjust slider thumb.
              (WebCore::parentMediaElement): Return the HTMLMediaElement parent of a controller element.
              (WebCore::RenderMediaControls::paintMediaControlsPart): Paint a media controller part.
              * rendering/RenderMediaControls.h: Added.
      
              * rendering/RenderThemeSafari.cpp:
              (WebCore::RenderThemeSafari::paintSliderTrack): Remove the MediaSliderPart case, it is never
              called for the media slider.
              (WebCore::RenderThemeSafari::adjustSliderThumbSize): Call RenderMediaControls function.
              (WebCore::RenderThemeSafari::paintMediaFullscreenButton): Ditto.
              (WebCore::RenderThemeSafari::paintMediaMuteButton): Ditto.
              (WebCore::RenderThemeSafari::paintMediaPlayButton): Ditto.
              (WebCore::RenderThemeSafari::paintMediaSeekBackButton): Ditto.
              (WebCore::RenderThemeSafari::paintMediaSeekForwardButton): Ditto.
              (WebCore::RenderThemeSafari::paintMediaSliderTrack): Ditto.
              (WebCore::RenderThemeSafari::paintMediaSliderThumb): Ditto.
      
              * rendering/RenderThemeWin.cpp:
              (WebCore::RenderThemeWin::adjustSliderThumbSize): Ditto.
              (WebCore::RenderThemeWin::paintMediaFullscreenButton): Ditto.
              (WebCore::RenderThemeWin::paintMediaMuteButton): Ditto.
              (WebCore::RenderThemeWin::paintMediaPlayButton): Ditto.
              (WebCore::RenderThemeWin::paintMediaSeekBackButton): Ditto.
              (WebCore::RenderThemeWin::paintMediaSeekForwardButton): Ditto.
              (WebCore::RenderThemeWin::paintMediaSliderTrack): Ditto.
              (WebCore::RenderThemeWin::paintMediaSliderThumb): Ditto.
              * rendering/RenderThemeWin.h:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42972 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      9ec57c33
    • bdakin@apple.com's avatar
      2009-04-28 Beth Dakin <bdakin@apple.com> · 40ff0964
      bdakin@apple.com authored
              Reviewed by Sam Weinig.
      
              Fix for <rdar://problem/6419515> REGRESSION (r31037): Positioned 
              images with % height are collapsed when printing
      
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::calcHeight): Make sure we don't ignore 
              printing here!
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42971 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      40ff0964
    • xan@webkit.org's avatar
      2009-04-28 Xan Lopez <xlopez@igalia.com> · 95c03e95
      xan@webkit.org authored
              Unreviewed: fix distcheck build, add (even more) missing files to list.
      
              * GNUmakefile.am:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42970 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      95c03e95
    • oliver@apple.com's avatar
      Improve performance of right shifts of large or otherwise floating point values. · 5216cd85
      oliver@apple.com authored
      Reviewed by Geoff Garen.
      
      Add logic to the codegen for right shift to avoid jumping to a helper function
      when shifting a small floating point value.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42969 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      5216cd85
    • adele@apple.com's avatar
      WebCore: · 180df329
      adele@apple.com authored
      2009-04-28  Adele Peterson  <adele@apple.com>
      
              Reviewed by Darin Adler.
      
              Fix for <rdar://problem/6617298> Typing delete on an unquoted blank line unquotes the preceding, quoted blank line
      
              Test: editing/deleting/type-delete-after-quote.html
      
              When a selection is deleted that contains a whole number paragraphs plus a line break, we refrain from merging paragraphs after the delete,
              since it is unclear to most users that such a selection actually ends at the start of the next paragraph.  However, when a user hits delete 
              with a caret selection, they actually do expect the start of that paragraph to be merged into the paragraph before it.  We can tell that 
              we're in this state because the TypingCommand creates the selection to delete but it doesn't change the endingSelection.  So we can tell
              that if we started with a caret selection, then we're not in this special case where we have to protect the user from unexpected behavior 
              from deleting a range they selected.
      
              * editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializePositionData):
      
      LayoutTests:
      
      2009-04-28  Adele Peterson  <adele@apple.com>
      
              Reviewed by Darin Adler.
      
              Test for <rdar://problem/6617298> Typing delete on an unquoted blank line unquotes the preceding, quoted blank line
      
              * editing/deleting/type-delete-after-quote.html: Added.
              * platform/mac/editing/deleting/delete-4038408-fix-expected.txt: This expected result change reflects a change in how the editing is done, 
                but the document structure remains the same, and there are no visible changes to the result.
              * platform/mac/editing/deleting/type-delete-after-quote-expected.checksum: Added.
              * platform/mac/editing/deleting/type-delete-after-quote-expected.png: Added.
              * platform/mac/editing/deleting/type-delete-after-quote-expected.txt: Added.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42968 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      180df329
    • xan@webkit.org's avatar
      2009-04-28 Xan Lopez <xlopez@igalia.com> · 7f0b9a10
      xan@webkit.org authored
              Unreviewed: fix distcheck build, add (more) missing files to list.
      
              * GNUmakefile.am:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42967 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      7f0b9a10
    • eric@webkit.org's avatar
      Reviewed by Simon Fraser. · eb4bff16
      eric@webkit.org authored
              Add text gradient test to cover
              https://bugs.webkit.org/show_bug.cgi?id=25403
      
              * platform/mac/svg/text/text-gradient-positioning-expected.checksum: Added.
              * platform/mac/svg/text/text-gradient-positioning-expected.png: Added.
              * platform/mac/svg/text/text-gradient-positioning-expected.txt: Added.
              * svg/text/text-gradient-positioning.svg: Added.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42966 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      eb4bff16
    • andersca@apple.com's avatar
      2009-04-28 Anders Carlsson <andersca@apple.com> · 4df7b531
      andersca@apple.com authored
              Reviewed by Kevin Decker and Darin Adler.
      
              Fix <rdar://problem/6836132>.
              
              * Plugins/Hosted/NetscapePluginHostProxy.mm:
              (WKPCCheckIfAllowedToLoadURL):
              Call the instance proxy.
              
              (WKPCCancelCheckIfAllowedToLoadURL):
              Ditto.
              
              * Plugins/Hosted/NetscapePluginInstanceProxy.h:
              * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
              (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
              Initialize the check ID counter.
              
              (WebKit::NetscapePluginInstanceProxy::checkIfAllowedToLoadURL):
              Create a WebPluginContainerCheck, add it to the map, and start it.
              
              (WebKit::NetscapePluginInstanceProxy::cancelCheckIfAllowedToLoadURL):
              Remove the check from the map.
              
              (WebKit::NetscapePluginInstanceProxy::checkIfAllowedToLoadURLResult):
              Call the WKPH MIG callback.
              
              * Plugins/Hosted/WebHostedNetscapePluginView.h:
              * Plugins/Hosted/WebHostedNetscapePluginView.mm:
              (-[WebHostedNetscapePluginView _webPluginContainerCancelCheckIfAllowedToLoadRequest:]):
              Call the instance proxy.
              
              (-[WebHostedNetscapePluginView _containerCheckResult:contextInfo:]):
              Ditto.
              
              * Plugins/Hosted/WebKitPluginClient.defs:
              * Plugins/Hosted/WebKitPluginHost.defs:
              Add MIG declarations.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42965 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      4df7b531
    • eric@webkit.org's avatar
      Reviewed by David Hyatt. · ae4051fd
      eric@webkit.org authored
              Add text repaint test to cover
              https://bugs.webkit.org/show_bug.cgi?id=16188
      
              * platform/mac/svg/text/text-repaint-rects-expected.checksum: Added.
              * platform/mac/svg/text/text-repaint-rects-expected.png: Added.
              * platform/mac/svg/text/text-repaint-rects-expected.txt: Added.
              * svg/text/text-repaint-rects.xhtml: Added.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42964 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ae4051fd
    • xan@webkit.org's avatar
      WebCore: · 44fb3bdf
      xan@webkit.org authored
      2009-04-28  Xan Lopez  <xlopez@igalia.com>
      
              Unreviewed: fix distcheck build, add missing header to file list.
      
              * GNUmakefile.am:
      
      JavaScriptCore:
      
      2009-04-28  Xan Lopez  <xlopez@igalia.com>
      
              Unreviewed: fix distcheck build, add missing header to file list.
      
              * GNUmakefile.am:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42963 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      44fb3bdf
    • kov@webkit.org's avatar
      2009-04-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> · d91c2eaf
      kov@webkit.org authored
              Unreviewed. Update gtk-doc control and base sgml files for 1.1.6.
      
              * docs/webkitgtk-docs.sgml:
              * docs/webkitgtk-sections.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42962 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      d91c2eaf
    • eric@webkit.org's avatar
      Reviewed by Sam Weinig. · 8aa9d381
      eric@webkit.org authored
              Fix foreignObject transform order
              https://bugs.webkit.org/show_bug.cgi?id=25433
      
              Transforms were being applied in the wrong order.
              When mapping from local to parent, first apply the viewport transform
              then map from the viewport box to the parent box.
      
              * rendering/RenderForeignObject.cpp:
              (WebCore::RenderForeignObject::localToParentTransform):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42961 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      8aa9d381
    • eric@webkit.org's avatar
      Reviewed by Simon Fraser. · 53203e40
      eric@webkit.org authored
              Simplify nodeAtPoint for SVG
              https://bugs.webkit.org/show_bug.cgi?id=25432
      
              Added a new nodeAtFloatPoint method which takes a FloatPoint
              instead of the *super confusing* x/y tx/ty pairs that HTML uses.
              Mostly this is just lots of minus-lines as the new code is *much* simpler.
      
              I made all the SVG renderers use the new nodeAtFloatPoint and ASSERT_NOT_REACHED
              for the nodeAtPoint HTML/CSS int x/y version.
      
              Eventually the rest of CSS/HTML render objects will follow suit
              and move to nodeAtFloatPoint (possibly renamed back to nodeAtPoint), but changing them
              over was well outside the scope of this change.
      
              SVG hit testing is not actually floating point precise yet, since its still
              passed in an integer x/y.  Certain transform hit-test edge cases are likely fixed
              by moving to FloatPoint here, but I didn't try to find one.
      
              This should not cause functional changes for common-case hit testing, thus
              no tests changed, nor should new tests be needed.
      
              * rendering/RenderForeignObject.cpp:
              (WebCore::RenderForeignObject::translationForAttributes):
              (WebCore::RenderForeignObject::paint):
              (WebCore::RenderForeignObject::computeRectForRepaint):
              (WebCore::RenderForeignObject::localToParentTransform):
              (WebCore::RenderForeignObject::layout):
              (WebCore::RenderForeignObject::nodeAtFloatPoint):
              * rendering/RenderForeignObject.h:
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::nodeAtFloatPoint):
              * rendering/RenderObject.h:
              * rendering/RenderPath.cpp:
              (WebCore::RenderPath::nodeAtFloatPoint):
              * rendering/RenderPath.h:
              * rendering/RenderSVGContainer.cpp:
              (WebCore::RenderSVGContainer::nodeAtFloatPoint):
              * rendering/RenderSVGContainer.h:
              (WebCore::RenderSVGContainer::pointIsInsideViewportClip):
              * rendering/RenderSVGHiddenContainer.cpp:
              (WebCore::RenderSVGHiddenContainer::nodeAtFloatPoint):
              * rendering/RenderSVGHiddenContainer.h:
              * rendering/RenderSVGImage.cpp:
              (WebCore::RenderSVGImage::paint):
              (WebCore::RenderSVGImage::nodeAtFloatPoint):
              * rendering/RenderSVGImage.h:
              (WebCore::RenderSVGImage::localToParentTransform):
              (WebCore::RenderSVGImage::localTransform):
              * rendering/RenderSVGModelObject.cpp:
              (WebCore::RenderSVGModelObject::nodeAtFloatPoint):
              * rendering/RenderSVGModelObject.h:
              * rendering/RenderSVGRoot.cpp:
              (WebCore::RenderSVGRoot::nodeAtFloatPoint):
              * rendering/RenderSVGText.cpp:
              (WebCore::RenderSVGText::nodeAtFloatPoint):
              * rendering/RenderSVGText.h:
              * rendering/RenderSVGViewportContainer.cpp:
              (WebCore::RenderSVGViewportContainer::pointIsInsideViewportClip):
              * rendering/RenderSVGViewportContainer.h:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42960 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      53203e40
    • eric.carlson@apple.com's avatar
      2009-04-28 Eric Carlson <eric.carlson@apple.com> · dc449487
      eric.carlson@apple.com authored
              - fix the Tiger build
      
              * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
              (WebCore::MediaPlayerPrivate::cacheMovieScale):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42959 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      dc449487
    • weinig@apple.com's avatar
      2009-04-28 Sam Weinig <sam@webkit.org> · f21bf405
      weinig@apple.com authored
              Reviewed by Beth Dakin.
      
              Consolidate ScheduleAction creation into ScheduledAction::create.
              Autogenerate JSWorkerContext.clearTimeout and clearInterval.
      
              * bindings/js/JSDOMWindowCustom.cpp:
              (WebCore::JSDOMWindow::setTimeout):
              (WebCore::JSDOMWindow::setInterval):
              * bindings/js/JSWorkerContextCustom.cpp:
              (WebCore::JSWorkerContext::setTimeout):
              (WebCore::JSWorkerContext::setInterval):
              * bindings/js/ScheduledAction.cpp:
              (WebCore::ScheduledAction::create):
              (WebCore::ScheduledAction::ScheduledAction):
              (WebCore::ScheduledAction::execute):
              * bindings/js/ScheduledAction.h:
              * workers/WorkerContext.cpp:
              (WebCore::DOMWindow::setTimeout):
              (WebCore::DOMWindow::clearTimeout):
              (WebCore::DOMWindow::setInterval):
              (WebCore::DOMWindow::clearInterval):
              * workers/WorkerContext.h:
              * workers/WorkerContext.idl:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42958 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      f21bf405
    • sfalken@apple.com's avatar
      Fix link warnings building TestNetscapePlugin on Windows due to mismatched · b5f45f1d
      sfalken@apple.com authored
              DLL name vs. LIBRARY directive name.
              
              Reviewed by Jon Honeycutt.
      
              * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.def:
              * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
              * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin_debug.def: Added.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42957 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      b5f45f1d
    • kov@webkit.org's avatar
      2009-04-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> · e0ebbf0d
      kov@webkit.org authored
              Reviewed by Xan Lopez.
      
      	Updated with news for the 1.1.6 release.
      
              * NEWS:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42956 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      e0ebbf0d
    • beidson@apple.com's avatar
      WebCore: · 27ca35a8
      beidson@apple.com authored
      2009-04-28  Brady Eidson  <beidson@apple.com>
      
              Reviewed by Darin Adler
      
              <rdar://problem/6643219> Crashes after moving nodes between documents with Safari 4 Beta installed
      
              When moving Nodes between documents we weren't properly updating style declarations.  Certain operations, such
              as creating webarchives, would tickle this bug.
      
              Tests: webarchive/adopt-attribute-styled-body-webarchive.html
                     webarchive/adopt-attribute-styled-node-webarchive.html
                     webarchive/adopt-inline-styled-node-webarchive.html
      
              * dom/Node.cpp:  Add a debug-only mechanism to insure that anyone who overrides (did/will)MoveToNewOwnerDocument
                calls their parent-class implementation after they've done their own work.
              (WebCore::setWillMoveToNewOwnerDocumentWasCalled): 
              (WebCore::setDidMoveToNewOwnerDocumentWasCalled):
              (WebCore::Node::setDocument):
              (WebCore::Node::willMoveToNewOwnerDocument):
              (WebCore::Node::didMoveToNewOwnerDocument):
      
              * dom/StyledElement.cpp:
              (WebCore::StyledElement::attributeChanged): Add a comment explaining why we don't need to walk the nameAttrMap
                to update style declarations.
              (WebCore::StyledElement::didMoveToNewOwnerDocument): Update the parent pointer for the inline style declaration.
              * dom/StyledElement.h:
      
              * html/HTMLBodyElement.cpp:
              (WebCore::HTMLBodyElement::didMoveToNewOwnerDocument): Update the parent pointer for the link declaration.
              * html/HTMLBodyElement.h:
      
      LayoutTests:
      
      2009-04-28  Brady Eidson  <beidson@apple.com>
      
              Reviewed by Darin Adler
      
              <rdar://problem/6643219> Crashes after moving nodes between documents with Safari 4 Beta installed
      
              * webarchive/adopt-attribute-styled-body-webarchive-expected.webarchive: Added.
              * webarchive/adopt-attribute-styled-body-webarchive.html: Added.
              * webarchive/resources/adopt-attribute-styled-body-iframe.html: Added.
              * webarchive/resources/adopt-attribute-styled-body-second-window.html: Added.
      
              * webarchive/adopt-attribute-styled-node-webarchive-expected.webarchive: Added.
              * webarchive/adopt-attribute-styled-node-webarchive.html: Added.
              * webarchive/resources/adopt-attribute-styled-node-second-window.html: Added.
      
              * webarchive/adopt-inline-styled-node-webarchive-expected.webarchive: Added.
              * webarchive/adopt-inline-styled-node-webarchive.html: Added.
              * webarchive/resources/adopt-inline-styled-node-second-window.html: Added.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42955 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      27ca35a8
    • sfalken@apple.com's avatar
      Fix warnings about PRODUCTION and ARCHIVE_BUILD on Windows builds · 86b0c99d
      sfalken@apple.com authored
              of ImageDiff and DumpRenderTree.
              
              Rubber stamped by Adam Roben.
      
              * DumpRenderTree/win/DumpRenderTree.vcproj:
              * DumpRenderTree/win/ImageDiff.vcproj:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42953 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      86b0c99d
    • eric.carlson@apple.com's avatar
      2009-04-28 Eric Carlson <eric.carlson@apple.com> · 7a38a06c
      eric.carlson@apple.com authored
               Reviewed by Darin Adler.
              
              <rdar://problem/6834876> Don't use BlockExceptions macros until QTKit supports 
              QTMoviePreferredTransformAttribute
      
              * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
              (WebCore::MediaPlayerPrivate::cacheMovieScale): use @try and @catch instead of 
              BEGIN_BLOCK_OBJC_EXCEPTIONS and END_BLOCK_OBJC_EXCEPTIONS for builds of QTKit 
              that throw an exception on QTMovieCurrentSizeAttribute but don't support 
              QTMoviePreferredTransformAttribute
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42952 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      7a38a06c
    • darin@apple.com's avatar
      2009-04-28 Darin Adler <darin@apple.com> · e19551fa
      darin@apple.com authored
              Reviewed by Sam Weinig.
      
              * rendering/RenderText.cpp:
              (WebCore::RenderText::RenderText): Streamline code path to avoid a bit of reference count
              churn and remove a strange unneeeded PassRefPtr typecast. Also added a comment.
              (WebCore::RenderText::setTextInternal): Ditto.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42951 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      e19551fa
    • eric@webkit.org's avatar
      Reviewed by Simon Fraser. · 9aa3af47
      eric@webkit.org authored
              Simplify how SVG containers paint
              https://bugs.webkit.org/show_bug.cgi?id=25431
      
              Moved filterBoundingBox() from RenderSVGModelObject to SVGRenderSupport to share with other classes.
              Gave RenderSVGText a modern clippedOverflowRectForRepaint and computeRectForRepaint.
              RenderSVGText now applies transforms at paint() time instead of during chunk draw time
              this should be much more efficient.
      
              Fixed the order in which RenderSVGViewportContainer applied
              transforms and clips.  We now clip to the viewport first and apply
              all transforms at once.  Also since the viewport logic is now only
              inside RenderSVGViewportContainer (instead of inside RenderSVGContainer)
              we always know we have a viewport.  We now use only viewportSize instead of
              viewport() since RenderSVGViewportContainers can't have x/y offsets.
      
              We now correctly transform the PaintInfo::rect (damage rect) when applying transforms.
              This allowed us to apply the transform during text paint() instead of at chunk paint
              time. Previously we had to apply the transform during chunk paint time because
              RenderBlock (superclass of RenderSVGBlock) would check intersection with the damageRect
              before telling any of the inlines to draw.  Now that we adjust the damage rect correctly
              we pass the intersection check correctly!  (This probably fixed some <text> redraw bugs
              but since I still have a bunch of those to fix, I've not tried to write additional tests
              to cover these potential fixes yet.)
      
              SVGRootInlineBox no longer needs to deal with transforms at chunk paint time, yay!
      
              * rendering/RenderPath.cpp:
              (WebCore::RenderPath::repaintRectInLocalCoordinates):
              (WebCore::RenderPath::paint):
              * rendering/RenderSVGContainer.cpp:
              (WebCore::RenderSVGContainer::paint):
              (WebCore::RenderSVGContainer::repaintRectInLocalCoordinates):
              * rendering/RenderSVGContainer.h:
              (WebCore::RenderSVGContainer::applyViewportClip):
              * rendering/RenderSVGImage.cpp:
              (WebCore::RenderSVGImage::layout):
              (WebCore::RenderSVGImage::repaintRectInLocalCoordinates):
              (WebCore::RenderSVGImage::clippedOverflowRectForRepaint):
              (WebCore::RenderSVGImage::computeRectForRepaint):
              * rendering/RenderSVGImage.h:
              * rendering/RenderSVGModelObject.cpp:
              * rendering/RenderSVGModelObject.h:
              * rendering/RenderSVGRoot.cpp:
              (WebCore::RenderSVGRoot::layout):
              (WebCore::RenderSVGRoot::selfWillPaint):
              (WebCore::RenderSVGRoot::paint):
              (WebCore::RenderSVGRoot::viewportSize):
              (WebCore::RenderSVGRoot::calcViewport):
              (WebCore::RenderSVGRoot::localToBorderBoxTransform):
              (WebCore::RenderSVGRoot::parentOriginToBorderBox):
              (WebCore::RenderSVGRoot::borderOriginToContentBox):
              (WebCore::RenderSVGRoot::localToRepaintContainerTransform):
              (WebCore::RenderSVGRoot::localToParentTransform):
              (WebCore::RenderSVGRoot::computeRectForRepaint):
              (WebCore::RenderSVGRoot::nodeAtPoint):
              * rendering/RenderSVGRoot.h:
              * rendering/RenderSVGText.cpp:
              (WebCore::RenderSVGText::clippedOverflowRectForRepaint):
              (WebCore::RenderSVGText::computeRectForRepaint):
              (WebCore::RenderSVGText::paint):
              (WebCore::RenderSVGText::repaintRectInLocalCoordinates):
              * rendering/RenderSVGText.h:
              (WebCore::RenderSVGText::localToParentTransform):
              (WebCore::RenderSVGText::localTransform):
              * rendering/RenderSVGViewportContainer.cpp:
              (WebCore::RenderSVGViewportContainer::applyViewportClip):
              * rendering/RenderSVGViewportContainer.h:
              * rendering/SVGRenderSupport.cpp:
              (WebCore::filterBoundingBoxForRenderer):
              (WebCore::applyTransformToPaintInfo):
              * rendering/SVGRenderSupport.h:
              * rendering/SVGRootInlineBox.cpp:
              (WebCore::SVGRootInlineBoxPaintWalker::chunkStartCallback):
              (WebCore::SVGRootInlineBox::paint):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42950 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      9aa3af47
    • cfleizach@apple.com's avatar
    • cfleizach@apple.com's avatar
    • mrowe@apple.com's avatar
      Work around <rdar://problem/6833240> by relying on static initialization to zero the entire struct. · 0e70b793
      mrowe@apple.com authored
      This removes the need for us to explicitly initialize all of the members, which have a tendency
      to change in meaning and number between versions of libxml2.
      
      Reviewed by Sam Weinig.
      
      * dom/XMLTokenizerLibxml2.cpp:
      (WebCore::):
      (WebCore::sharedXHTMLEntity):
      (WebCore::getXHTMLEntity):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42945 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      0e70b793
    • sfalken@apple.com's avatar
      Fix extraneous warning about AnalyzeWithLargeStack not being defined in Windows builds. · 2a996d8a
      sfalken@apple.com authored
              Indirected definition through a UserMacro.
              
              Reviewed by Mark Rowe.
      
              * win/tools/vsprops/common.vsprops:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42944 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      2a996d8a