GitLab

This is for legacy as well as NG.

Bug: 1083009
Change-Id: I8c11aca1d5dc03932d437f60c0d56960c28709eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208010
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Auto-Submit: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772451}

This CL replaces some foo() and hasFoo() with fooNonNull() and
hasFooNonNull(), where it will be compile failure on IDL compiler
migration.


Bug: 839389
Change-Id: I4b51fe335af0c2555c702b03f0609d71d231b296
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213655
Auto-Submit: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772450}

There is no valid implementation yet that can zip files if we don't
have NaCl.

BUG=912236
TEST=browser_tests --gtest_filter="ZipFiles/*"

Change-Id: I560dbc85982f8768c22580155eed8d08e2353809
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215384Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: François Degros <fdegros@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772449}

This cl computes digests of the underlying bytes of canvas images when
HTMLCanvasElement.toBlob, HTMLCanvasElement.ToDataURL, or
HTMLCanvasElement.convertToBlob are called.

OffscreenCanvas.convertToBlob is not recorded yet, since we do not yet have a
UKM source or Recorder in that context.

CanvasRenderingContext2D.getImageData and WebGLRenderingContext.readPixels are also not recorded yet.

Bug: 973801
Change-Id: Ic2de567b16c98b613c945afa823a078a4740a7a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207979
Commit-Queue: Chris Fredrickson <cfredric@google.com>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772448}

Adds service_sandbox_type.h header for components to consume and uses it
to supply sandbox type for PaintPreviewCompositorCollection.

Prelude to removal of WithSandboxType API. See linked bug for
rationale.  Does not change behavior.

Tests: browser_tests PaintPreviewCompositorBrowserTest.*
Bug: 1065087
Change-Id: Ie7e13e884df5c59edc850b3546d6d9b655102f79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202663Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Matthew Denton <mpdenton@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Matthew Denton <mpdenton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772447}

https://chromium.googlesource.com/angle/angle.git/+log/ca092f016532..f5dace0f1e57

2020-05-27 timvp@google.com Vulkan: Increase GLES support to 3.1
2020-05-27 jonahr@google.com GL: Support GL_OES_texture_cube_map_array in shader translator
2020-05-27 jonahr@google.com GL: Support GL_OES_texture_cube_map_array in frontend/GL backend
2020-05-27 ianelliott@google.com Vulkan: Rotate gl_FragCoord for Android pre-rotation
2020-05-27 nguyenmh@google.com Store non-string, non-enum data in binary file.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: ynovikov@google.com
Test: Test: CQ
Change-Id: I0f8d63f1d74d282923105e07439a18177a48a11a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218741Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#772446}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0c7d654c7474..cdaf0be1f4ce

2020-05-27 zhin@chromium.org Add git completion helper to cl upload

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: agable@chromium.org
Change-Id: I9fc6a7eda3673488fe8f01e6411c52b8776b2679
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218952Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#772445}

On Mac Asan,
conformance2/textures/webgl_canvas/tex-3d-rgb8ui-rgb_integer-unsigned_byte.html
started failing. Suppress the test.

TBR=kbr@chromium.org

Bug: 1087083
Change-Id: I0ece6b3d187199308e3c486f7bf927b07c59cdbf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219030Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Robert Kroeger <rjkroege@chromium.org>
Auto-Submit: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772444}

In response to an accessibility action to change the value
of a slider, we fire a DOM event. However, firing that
DOM event can result in arbitrary user code being called,
which can mean detaching the current AXObject, leading to
a crash/UAF.

Fix this by checking after firing a DOM event.

Bug: 1079445
Change-Id: Ic16b9a5312a14e57bc56a9c8124ffe64d1b69f65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211930
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Meredith Lane <meredithl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772443}

In the initial CL for Shortcuts Menu (https://crrev.com/c/2146212), we
used the WebAppIconManager::WriteData method to write both app icon
and shortcut icon data to disk.

App icons are for the web app as a whole. Shortcut icons on the other
hand, are specified for a shortcut in the web app manifest's shortcuts
member array. So, in the interest of code readability and debuggability
we should write these to disk separately.

With this in mind, I left a TODO in the initial CL to create separate
methods for writing these 2 different kinds of icon data to disk.

This CL addresses that TODO. It adds a separate
WebAppIconManager::WriteShortcutIconsData method. It also reverts
WebAppIconManager::WriteData to only write app icon specific data.

Additionally, it updates existing unittests to work with the refactored
code and adds new tests for reading and writing shortcut icon data.

Finally, it renames  occurrences of *ShortcutIcon*/*shortcut_icon* to
*ShortcutsMenuIcon*/*shortcuts_menu_icon*.

Bug: 1069308
Change-Id: I530b3af75277f1d6c5f2b0ed6a67ce469bba7fed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204972
Commit-Queue: Rahul Singh <rahsin@microsoft.com>
Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772442}

the app's launch url

This CL fixes an issue where clicking an item in a PWA's shortcuts menu
always navigates to the PWA's start_url.

To fix this, it adds a new command line switch. When registering the
shortcuts menu with the OS, it uses this switch to pass the shortcut url
as a command line argument.

In WebAppLaunchManager, when kDesktopPWAsAppIconShortcutsMenu is
enabled, it sets AppLaunchParams' override_url member to the switch's
value i.e. the shortcut url.

Note: The shortcut url that the switch is set to in the shortcuts menu
registration code has the same origin as the app's start_url. This is
validated as part of web app manifest parsing.

I verified that this fix works with Extensions based as well as WebApp
based PWAs.

Bug: 955497
Change-Id: Ib6360b16fe976e7e498bd783cf44911fe8c75b7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213344
Commit-Queue: Rahul Singh <rahsin@microsoft.com>
Reviewed-by: David Bienvenu <davidbienvenu@chromium.org>
Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772441}

QuickAnswersView never gets added as a pre-target handler, so call to
RemovePreTargetHandler in ~QuickAnswersView() is extraneous and is thus
removed.

Bug: b:150475423
Test: Tested on Chrome OS VM.
Change-Id: Id1246e27d626daa4a6da5bb32d9b1c471c410c1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216531
Commit-Queue: Abhijeet Singh <siabhijeet@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#772440}

- Adding missing = 0 to NearbyConnectionsManager abstract methods

Bug: 1087054
Change-Id: Id7386ea9c8a4f3d77cac2111142990e15592deeb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218054
Commit-Queue: Alex Chau <alexchau@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Auto-Submit: Alex Chau <alexchau@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772439}

This reverts commit a2abca78.

Reason for revert: Relanding with fix caused by original CL

Original change's description:
> Revert "[CrOS settings] Port os_reset_page/ and localized_link/ to Polymer3"
>
> This reverts commit 8603f25b.
>
> Reason for revert: metrics recorder is missing some resources in Polymer2 settings, causing some breakage

> Original change's description:
> > [CrOS settings] Port os_reset_page/ and localized_link/ to Polymer3
> >
> > - Forks TestLifetimeBrowserProxy into test_os_lifetime_browser_proxy.js
> > - create new os_settings_v3_browsertest.js
> >
> > Bug: 1045266
> > Change-Id: I4500646fda8e8208d7bc63b405594592f9a7fce2
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2190976
> > Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com>
> > Reviewed-by: dpapad <dpapad@chromium.org>
> > Reviewed-by: Regan Hsu <hsuregan@chromium.org>
> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#771716}

> TBR=khorimoto@chromium.org,dpapad@chromium.org,hsuregan@chromium.org,tjohnsonkanu@google.com
>
> Change-Id: I99a42fac621b3fd5dab766f1dbe476ba52aa58b6
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1045266
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216914
> Reviewed-by: Regan Hsu <hsuregan@chromium.org>
> Commit-Queue: Regan Hsu <hsuregan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#772083}

Bug: 1045266
Change-Id: If3f44fe98f6691c192ebf66beb74086e5b90431d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218751Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com>
Cr-Commit-Position: refs/heads/master@{#772438}

This CL adds a new histogram that is recorded whenever a user changes
which keyboard shortcut presets they are using in the DevTools, an
experimental feature that will be introduced by this [1] CL. A test for
this histogram is included in this [2] devtools-frontend CL.

Custom keyboard shortcuts design doc:
https://docs.google.com/document/d/1oOPSWPxCHvMoBZ0Fw9jwFZt6gP4lrsrsl8DEAp-Hy7o/edit

[1] https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2095859
[2] https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2173300

Bug: 174309
Change-Id: I00206839d4d55031539efbdc02b4f776cf4f054c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2172132Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Vidal Diazleal <vidorteg@microsoft.com>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Jack Lynch <jalyn@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#772437}

We still get low-volume of reports about mismatched
|request_initiator_site_lock|, but we have trouble finding their root
cause.  We hope to get more data through DwoC from the M84 Beta
(see https://crbug.com/1056949#c27).

If we fail to find the root cause in other ways, then it seems that the
best way to proceed in M85+ is to enable hard enforcement of
|request_initiator_site_lock| (i.e. reject request with a mismatch
|request_initiator| in CorsURLLoaderFactory::IsValidRequest).  This will
1) get security benefits (making it impossible to spoof
|request_initiator| and 2) might help find the root-cause for the
mismatched requests, by breaking such requests (and hopefully
encouraging bug reports with repro steps).

Bug: 920634, 1056949
Change-Id: I0c2539d10682e3c85c0f3d09763ab02646bea0d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210870Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772436}

This reverts commit 9d9ec179.

Reason for revert: https://crbug.com/1087096 -- crash in OnThermalStateChange on Mac ASAN GPU bots.

Original change's description:
> MediaStreamManager: listen to and log OnThermalStateChange
> 
> crrev.com/c/2195334 just landed PowerObserver::OnThermalStateChange,
> this CL listens to it from MediaStreamManager and logs it in the
> WebRTC log.
> 
> The utility function PowerMonitorSource::DeviceThermalStateToString
> gets #if DCHECK_IS_ON() removed to be used from the new code, which
> runs also in non-dcheck_always_on builds.
> 
> Bug: 1071431
> Change-Id: I5641ae5a96e4ca9504498821ffb3ea91adbec18a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207410
> Reviewed-by: François Doray <fdoray@chromium.org>
> Reviewed-by: Guido Urdaneta <guidou@chromium.org>
> Reviewed-by: Henrik Boström <hbos@chromium.org>
> Commit-Queue: Miguel Casas <mcasas@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#771045}

TBR=fdoray@chromium.org,mcasas@chromium.org,hbos@chromium.org,guidou@chromium.org,eshr@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1071431
Change-Id: I998eb902d70929171dacd12e7916159d47d6787a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218477Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Robert Kroeger <rjkroege@chromium.org>
Auto-Submit: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772435}

After https://crrev.com/c/2196922 we start using real coded size in
VideoFrame and SharedImageVideo. CodecImage was still using size from
CodecOutputBuffer which is visible size. This leads to validation errors
in gles2 decoder because we try to copy larger rect than CodecImage.

This CL changes CodecImage::GetSize to return coded size instead of
visible_size to be in line with VideoFrame and SharedImageVideo.

Bug: 1085359, 1076564
Change-Id: Icd92fb60e95cfbb9fa9ce916097c2b0984b13ebf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213261Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772434}

Removing because enough time has elapsed, and the banner
has been dismissed enough times that it seems users
know that Browser and OS settings have split.

Fixed: 1072514
Change-Id: I85b25fe378b6970e674e519459c66ec15828c198
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216647
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772433}

Don't call SetEmbeddedColorProfile() if profile is a null pointer.
SetEmbeddedColorProfile() sets
source_to_target_color_transform_needs_update_ to true, which causes
extra work to be done when ColorTransform() is called later.

Change-Id: I63f1097547f168ce4522240c265de1caa8e01de6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213449Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Wan-Teh Chang <wtc@google.com>
Cr-Commit-Position: refs/heads/master@{#772432}

Note that isGridTabSwitcherEnabled is already return true when the
start surface is enabled but not isStartSurfaceStackTabSwitcherEnabled

This CL adds missed changes in
https://chromium-review.googlesource.com/c/chromium/src/+/2173118

Screenshots:
https://drive.google.com/file/d/1WaqU4-N9jYOVC62eMvgOnGlQAwLzJphI/view?usp=sharing
https://drive.google.com/file/d/1uVFGZYEIguGQNlNOWjTSJCHOx5CdBFuK/view?usp=sharing

Bug: 1076449
Change-Id: Ib70134dee8d3e12f204716394c4263bb976dfbb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209391Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Auto-Submit: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772431}

QuickAnswersPreTargetHandler is added as a ViewObserver to the
QuickAnswersView. Since the view owns an instance of the handler, it
must stop observing the view when it is deleted to prevent invalid
references to it from ~QuickAnswersView() later.

The issue was observed when a failing trybot reverted a related change
in chromium/2212238.

is_debug set to true.

Bug: b:157182213
Test: Tested on Chrome OS VM and running ash:ash_unittests with
Change-Id: If59e512a45faab65a99ed4e76a1e00c5e60550aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216816Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Abhijeet Singh <siabhijeet@google.com>
Cr-Commit-Position: refs/heads/master@{#772430}

This reverts commit 2c0e0255.

Reason for revert: Necessary debug info was collected.

Original change's description:
> Add debug DumpWithoutCrashing to SurfaceTexture transform
> 
> This CL adds some debug checks to help debug crashes later on when
> creation of VideoFrame failed in VideoFrameFactoryImpl or
> StreamTextureWrapperImpl.
> 
> Bug: 1081695
> Change-Id: Ib612675066443fe01c0e897240203507cf5d9f39
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214903
> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
> Reviewed-by: Jonathan Backer <backer@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#771655}

TBR=backer@chromium.org,vasilyt@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1081695
Change-Id: I7409ef7a3788a0ccc198e956c5b51174b8c6ec3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219089Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772429}

Roll Chrome Win32 PGO profile from chrome-win32-master-1590594916-1a49bd7be838713a54921f61c31eff74f9ded2d9.profdata to chrome-win32-master-1590609462-f9ab96859e162a96cc1f1ba3f4ac827a4c53be85.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win-chrome
Tbr: jeffyoon@google.com,liaoyuke@google.com
Change-Id: Id2b5c07f685621b8f582dc5a271b5b1945e29b67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218896Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#772428}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/9990e869..64cadfcf

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I68d94f74ecf752c051f3b3c6b6ab97d823ce1ec8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217850Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#772427}

It's Android only. Trunk currently allows the user to expand into the
cutout area. With this change, it will instead allow the user to reduce
out of the cutout area.

Bug: 1077400
Change-Id: I99c15f671c0b085dcaf770e594cd06e722192a9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218453
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Auto-Submit: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772426}

This change introduces the first draft of a possible
Chrome-specific COM API for accessibility that's async-only
and could potentially lead to better performance and
more easily allow Windows assistive technology to avoid
injecting in-process.

This new interface is behind a feature flag with no intention
of launching as-is - if this proves to be successful we
should either standardize this as part of an existing
API like IAccessible2, or else create a new public spec
for it.

For now, the goal is to make something available for
experimenting and building a proof-of-concept.

Bug: 1083834
AX-Relnotes: None
Change-Id: I32fb830217f55e1b1b214b1044362d9c2c42f5b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206224Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Auto-Submit: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772425}

Bug: 1015882
Change-Id: I4cd7d39808c4e2ac6df1d159fe91da8803f5209d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216598Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772424}

Currently FocusRing calls Install() on a view and returns an
unique_ptr that is owned by the client and not the view to which it
is added.

This ends up with client classes holding a unique_ptr to the
FocusRing without any need for independent ownership.

This patch updates the view to own the FocusRing with classes holding
non-owning pointers to the FocusRing if required.

AX-Relnotes: n/a.

Bug: 1044687
Change-Id: Ib3c8a0f47df20249a750dca476ab2f73a992b53a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209402Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772423}

See attached bug and inline comments for details. The throbber is used to visually indicate that a background tab has been created, to ensure the user is aware of the activity. It is not meant to exactly represent the loading state of the background tabs.

Bug: 1085560
Change-Id: Id51096620a487eb549fe1395f3199f59fe49a806
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212812Reviewed-by: Taylor Bergquist <tbergquist@chromium.org>
Reviewed-by: Dana Fried <dfried@chromium.org>
Commit-Queue: Taylor Bergquist <tbergquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772422}

These will help confirm/eliminate whether these rare problems are at
fault when diagnosing message pump hangs in Slow Reports.

R=etienneb@chromium.org

Bug: 1074019
Change-Id: I7432ec471a9b605f36feda392207e9f5d40edfea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216032
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: Etienne Bergeron <etienneb@chromium.org>
Auto-Submit: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772421}

OmniboxPopupModel::TriggerSelectionAction will definitely crash in the
no-default-match edge case, which can definitely happen with certain
enterprise policies.

Additionally, it's possible that UI callers will pass in an invalid
|selection|, as they are an external class that could potentially be
stale. In practice, it doesn't SEEM possible for this to occur with
Views, but I'm not sure.

Philosophically, I think crashing when the UI code gets out of date
isn't a good thing, and this code should be a bit more tolerant.

Bug: 1085407, 1078183, 1052522
Change-Id: Ibe5a2b09340679d3bfb86c234bc799f0823fdaaf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216605Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772420}

https://chromium.googlesource.com/catapult.git/+log/4ad5d5733e00..369a09ac8618

2020-05-27 bsheedy@chromium.org Reland "[Telemetry] Add LocalFirstBinaryManager"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC rmhasan@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1054583
Tbr: rmhasan@google.com
Change-Id: Ife5755f369855fce406ee4597c7a8340a9c63404
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218737Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#772419}

Crash was caused by overlapping animate-out animations.

Bug: b:157521638, b:151979172, b:145136105
Change-Id: I71787905346a29a3d238d172a5660e252d3c4f01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216617
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Jeroen Dhollander <jeroendh@google.com>
Cr-Commit-Position: refs/heads/master@{#772418}

TBR=guidou@chromium.org
Bug: 984879

Change-Id: I5d68c9e97a185075daabb8dbd6791163dd1ad127
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218794Reviewed-by: Leonard Grey <lgrey@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772417}

Previously, DXVA decoding copied to RGB to avoid an Intel driver crash.
This CL allows it to copy to NV12 instead, which permits overlays.

This also enables an existing zero-copy workaround in
D3D11VideoDecoder, to avoid array textures when decoding.

Bug: 971952
Change-Id: I7bca63102cf886b29439c42660499fc9887d5b91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217037Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Ted Meyer <tmathmeyer@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772416}

This change adds setters for:
* Accessible role & title on Widget
* Initially focused view on Dialog

At first glance these might appear unrelated, but in fact bubbles use
the presence or absence of an initially focused view to decide what role
they should have.

Bug: 1011446, 1075649
Change-Id: I1ad2b8b333c46c9252cc8d5667a21d6b9b7a0d5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218688
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772415}

Prior to this CL, Chrome on desktop Linux often inconsistently used
contour fonts (e.g., DejaVu Sans and Noto Sans Symbols2) for some
emojis, even when a dedicated emoji font (e.g., Noto Color Emoji) is
available and used for all other emojis. In order to force the color
emoji font to be used always, hacks [1] have been mentioned in online
forums that prepend the color emoji font to the list of system fonts in
fonts.conf, which can have highly deletorious effects on other
applications (like normal numerals becoming their emoji versions).

The ISO locale code "und-Zsye" [2] is one of the ways of informing
fontconfig (as of version 2.12.5) that color emoji fonts should be
preferred, along with the special font family "emoji" [3]. fontconfig
also has default configurations that automatically map the locale and
the "emoji" family to any available color emoji font. By explicitly
setting the locale to "und-Zsye", this CL provides the desired
out-of-the-box experience to desktop Linux users.

While we could also specify the "emoji" font family either instead of or
in addition to the locale, doing so requires more plumbing in the code
and may be done in the future.

[1]: https://github.com/googlefonts/noto-emoji/issues/36
[2]: https://unicode.org/reports/tr51/#Emoji_Script
[3]: https://bugs.freedesktop.org/show_bug.cgi?id=94551

Bug: 767754
Change-Id: Ie8019cc0540a177c816c8131ca7c6a504952aa09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207627
Commit-Queue: Timothy Gu <timothygu@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772414}

This CL maintains the reference to the C++ instance, and handles the
null response case better.

Bug: 949269
Change-Id: I3bb453286d8a1f8c8f087787235a664570e2c259
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200045Reviewed-by: Nina Satragno <nsatragno@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Commit-Queue: Manas Verma <manasverma@google.com>
Cr-Commit-Position: refs/heads/master@{#772413}

This change adds new color values to support high contrast for scrollbars. Color values for scrollbars are now selected using GetControlColor() in order totake advantage of existing code paths for selecting unique colors based on dark mode or high contrast color schemes.

Bug: 1081921
Change-Id: I141aacbe4830544594626cc777f0183394e8c3ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207981Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Yu Han <yuzhehan@chromium.org>
Commit-Queue: Sam Sebree <sasebree@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#772412}