- 14 Aug, 2019 18 commits
-
-
Sunny Sachanandani authored
Flush on the client side to ensure the PresentSwapChain() IPC message makes it to the service, and flush device context in the service to ensure that driver flushes its command queue. Without the former, the last frame presented to low-latency webgl canvas before a pause can be delayed until canvas updates again. On https://codepen.io/miguelao/full/WKZaqd this can be seen as a delayed stroke at the last position of pointerup after starting a new touch sequence. Bug: 939655 Change-Id: I464c77fe1d25e0af73708b89963b876ec1ae7a98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747157 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#686652}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I9b1a4a9da1da370552ceab43906102b58574b737 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753087Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686651}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d550b702ac53..283aa6a07c39 Created with: gclient setdep -r src-internal@283aa6a07c39 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None,chromium:None Change-Id: I5e143aa0b05ab2bb8705fd7ffda7578e0a2ae615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753083Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686650}
-
Sergey Ulanov authored
Previously compositor supported YCbCr samplers only on Android and only for external Vulkan images. On Fuchsia sysmem APIs use Vulkan I420 formats to return decoded images and so YCbCr samplers have to be used to render them on the screen. In this CL: 1. Updated VulkanImplementation::CreateImageFromGpuMemoryHandle() to make it possible to return YCbCr info. 2. Added image_format in gpu::VulkanYCbCrInfo to remove the assumption YCbCr images are always external. 3. ExternalVkImageBacking now bundles returned YCbCr info in GrVkImageInfo when wrapping in GrBackendTexture. 4. SkiaOutputSurfaceImpl now passes image format when initializing GrVkYcbcrConversionInfo. 5. Updated VulkanDeviceQueue and VulkanImplementationScenic to enable YCbCr sampler extension on Fuchsia. Bug: 981022 Change-Id: I477ebf698d098bafefaadbf77dfa8d373f9ae076 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730311 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:Eric Karl <ericrk@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#686649}
-
dalyk authored
The kDnsOverHttps feature now has two params: Fallback and Templates. The Fallback param allows the default SecureDnsMode used by the HostResolverManager to be set to AUTOMATIC (true) or SECURE (false). The Templates param allows multiple DoH templates separated by spaces to be used in either AUTOMATIC or SECURE mode. Invalid templates are dropped, and among valid templates, the configured HTTP method is GET if the template contains a "dns" variable, and is POST otherwise. This change provides the ability to experiment easily with multiple DoH templates in different SecureDnsModes. Example usage: --enable-features="DnsOverHttps<DoHTrial" \ --force-fieldtrials="DoHTrial/Group1" --force-fieldtrial-params=\ "DoHTrial.Group1:Fallback/true/Templates/https%3A%2F%2Fcloudflare-dns.com\ %2Fdns-query" Bug: 985589 Change-Id: I0b847becebf63b9a309c81b1eeb1b788df91cc1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524304 Commit-Queue: Katharine Daly <dalyk@google.com> Reviewed-by:
Bence Béky <bnc@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#686648}
-
Sujie Zhu authored
Previously when we introduce the enum NOT_OFFERED_USE_UNSUPPORTED_LOCAL_CARD, we forgot to add the label string for the enum value: https://chromium-review.googlesource.com/c/chromium/src/+/1700298 This is a fix for that. Bug: 954367 Change-Id: I3bba1d4ed4c1879339e8baa54d600a8d319242a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753050 Commit-Queue: Sujie Zhu <sujiezhu@google.com> Auto-Submit: Sujie Zhu <sujiezhu@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#686647}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/35670f183a73..2fb628da46f1 git log 35670f183a73..2fb628da46f1 --date=short --no-merges --format='%ad %ae %s' 2019-08-13 hob@chromium.org Remove GLFW dependency for non-GL tests 2019-08-13 enga@chromium.org Add dawn_platform::Platform for handling tracing events in Dawn Created with: gclient setdep -r src/third_party/dawn@2fb628da46f1 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: chromium:993457,chromium:958013 Change-Id: Icaebab52c118104672ad837a026569a3a4824b34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752907Reviewed-by:
-
nancy authored
BUG=992839 Change-Id: Ice35146fbe8c931bbfb81e885c9a24766619e27b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750515Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#686645}
-
Alexey Baskakov authored
Plumb WebApp::launch_container_ from WebAppInstallFinalizer::FinalizeInstall. Implement persistence for launch_container_ and its enum. We don't want to change components/sync/protocol/web_app_specifics.proto for now: there will be many proto changes on our side. We will upstream them in one big CL to be approved by the sync team (i.e. we want to batch all the updates when our proto structure stabilized). Bug: 891172 Change-Id: Ia6780ddcfc4143cad3f4a74e92ac61c71b3886b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750475Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#686644}
-
Ian Kilpatrick authored
This passes border_padding of the flex-item into the size calculation calls, instead of border_scrollbar_padding. Additionally this removes two GetLayoutBox() calls (used to determine) the scrollbars from within NGFlexLayoutAlgorithm::Layout. Bug: 845235 Change-Id: Ifddca6db7e25b4c2d8851ffbcbce71b2740cd9e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752549Reviewed-by:
David Grogan <dgrogan@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#686643}
-
Vikas Soni authored
1. StreamTextureHost's |channel_| could be null while StreamTextureHost is still alive because |channel_| can be set to null on a OnChannelError() call. 2. Add a new unit test to test and make sure StreamTextureHost can handle a null |channel_|. 3. An invalid mailbox needs to be checked by calling Mailbox::IsZero(). 4. Remove previously added CHECK's for debugging. Bug: 984309 Change-Id: I1fb42855877540f1ec0ddbcec4fe5713071727a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1740168 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#686642}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/42424bf2eab6..f20959283711 git log 42424bf2eab6..f20959283711 --date=short --no-merges --format='%ad %ae %s' 2019-08-13 thestig@chromium.org Remove some checks that are always/never true in CPWL_ListCtrl. 2019-08-13 thestig@chromium.org Reuse existing methods in CPWL_ListCtrl. 2019-08-13 thestig@chromium.org Clean up some CPDF_CMap code. Created with: gclient setdep -r src/third_party/pdfium@f20959283711 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: I5b197c597f0d7265d794dac6bf4f61483f4b6766 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753047Reviewed-by:
-
Antonio Gomes authored
... placing it in service_worker_global_scope_proxy.cc, closer to the Blink -> Content barrier. This is similar to CL https://crrev.com/c/1627450. BUG=963574 R=haraken@chromium.org Change-Id: Ifc3de842f4ba6f8c2a61574c39442dcf6087ec27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752067 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#686640}
-
Julie Jeongeun Kim authored
This CL converts BroadcastChannelProvider in the browser process and BroadcastChannel in blink to new Mojo types. It keeps CreateBroadcastChannelProvider with BroadcastChannelProviderRequest since RenderProcessHostImpl still uses service_manager::BinderRegistry. Bug: 955171, 978694 Change-Id: I27a0fd6d4410a325cc86a3d9cc9c0500de4ec79d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746212Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#686639}
-
Ryan Hansberry authored
Bug: 785758 Change-Id: I35f3270d0b61b8f0e3e3bde6d64f5b1c54f1a254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752913 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#686638}
-
Balazs Engedy authored
The strings shown in the page info bubble and chrome://settings/contents now read `File editing`. Bug: 992175 Change-Id: Ib280bc84a1f48387d01af1728be3ffef46d9b297 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749192Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Auto-Submit: Balazs Engedy <engedy@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#686637}
-
Takuto Ikuta authored
recipe is added in https://chromium-review.googlesource.com/c/chromium/tools/build/+/1752403 Bug: 988833 Change-Id: I089f7f85c0691965d55a48582f0b17daa14973c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752484Reviewed-by:
-
Yi Gu authored
In HitTestManager::ValidateHitTestRegionList() we only verified regions in HitTestRegionList. However, the hit test region list itself also needs to be verified. Bug: 985786 Change-Id: Ic501de41abaa9413573b83a1fcea4da54c51f76a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752874 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#686635}
-
- 13 Aug, 2019 22 commits
-
-
sczs authored
- Changes the presentation to FormSheet and makes all presented VC conform to UIAdaptivePresentationControllerDelegate. - When editing a VC (BookmarkEditVC or BookmarkFolderEditorVC) and the user tries to dismiss by swiping down an alert is displayed. Screenshots: iPad: https://drive.google.com/open?id=1znj13pFTmKZ-STtPaVyZH6Vber_qTxcd https://drive.google.com/open?id=1aXATNB7q_y4feMQP6V5BSAsFJyHq_ZKK iPhone: https://drive.google.com/open?id=1CktzDtiE5NnXZwfKMJa1gEJ4-a3Ivh3Q https://drive.google.com/open?id=1mClWFlkpwVgOJQK53U9BvGS_SBUYbWYu Bug: 979201 Change-Id: Ide9ef511b8a4c96293f809185d1981410eca3187 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719455 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#686634}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5e2c489a335c..f75996469d02 git log 5e2c489a335c..f75996469d02 --date=short --no-merges --format='%ad %ae %s' 2019-08-13 robertphillips@google.com Make defaultBackendFormat callable from anywhere in the GrContext hierarchy 2019-08-13 halcanary@google.com SkMallocPixelRef::MakeDirect: doesn't need a release proc Created with: gclient setdep -r src/third_party/skia@f75996469d02 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@google.com Bug: None Change-Id: I0e69907bd97833fa13cfde21f18c213060f7c494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752909Reviewed-by:
-
Austin Eng authored
Bug: 948902 Change-Id: Ib393d71a20f02d8bed14181eff82e35291d8b51d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753027Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/01525f9e0338..7c6f74ab0344 git log 01525f9e0338..7c6f74ab0344 --date=short --no-merges --format='%ad %ae %s' 2019-08-13 qingsi@webrtc.org Set the usage pattern bits for adding remote ICE candidates from SDP. 2019-08-13 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 3ae2445b..6652dd41 (686310:686436) 2019-08-13 eladalon@webrtc.org Control PeerConnectionFactory's default min/starting/max bitrates from experiment 2019-08-13 nisse@webrtc.org Delete StreamDataCountersCallback from ReceiveStatistics Created with: gclient setdep -r src/third_party/webrtc@7c6f74ab0344 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Ica56c038235c210eed733d59b8a38cc2a5c9b171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752906Reviewed-by:
-
Xiaocheng Hu authored
Current |Length| class assumes that a calculated length can always be represented as a (px, %) pair. To implement CSS comparison functions, we need to augment it to hold a tree instead. This patch allows |CalculationValue| to host either a |PixelsAndPercent| or a calculation tree, to support comparison functions. There are some clients assuming that a |Length| is always a (px, %) pair. They are either changed to cope with the calculation tree, or marked as will be handled in future work. This patch is part of the implementation of CSS comparison functions min() and max(). See the all-in-one patch crrev.com/c/1737874 for reference. Bug: 825895 Change-Id: Ia83c83208c35b32e301d75b2961eeeb9ed389f1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741959 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#686630}
-
Tatiana Buldina authored
Add ability to use capability platformName with version, but in fact we check only that it starts with correct operation system e.g. for "Windows 10" we check only Windows Bug: chromedriver:3047 Change-Id: I07f2db4bff9aa39433299bab7fa673d727ab6758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750161Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#686629}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/811aead064fb..14ef7d57c13d git log 811aead064fb..14ef7d57c13d --date=short --no-merges --format='%ad %ae %s' 2019-08-13 cjmcdonald@chromium.org Enable new parallel_emerge impl for PCQ Created with: gclient setdep -r src/third_party/chromite@14ef7d57c13d The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I55b6255a30c1bcc5f89ecf4576fe4d51b047e1d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752904Reviewed-by:
-
Alex Leung authored
Multizone follower on Android is not working because insufficient time was given for pushing data to the audio pipeline. This resulted in cropped audio buffers. Bug: 117832377 Test: Tested multizone follower on atv and android things Change-Id: I92e8fbb39fa904fd3b38e4fb28d418d3e4272ac1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742995Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Alex Leung <alexleung@google.com> Cr-Commit-Position: refs/heads/master@{#686627}
-
Takumi Fujimoto authored
Remove the MediaStatus struct and typemapping, and use mojom::MediaStatus directly. Also delete the MirroringMediaRouteController class which is no longer used. Change-Id: I92ee56c3c276000948340da2c7d85248041cbf28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747740Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#686626}
-
Evan Stade authored
Bug: 268984 Change-Id: I36440e22f2d15a63aa5aba46b0f062eafdb11e33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715530 Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#686625}
-
Pete Williamson authored
Bug: 988882 Change-Id: Ie70672df41631d3c6b6cb51997fe5f4b17970045 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747072Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#686624}
-
Justin Cohen authored
Bug: 992500 Change-Id: I797068fb5d58f5ebb19231d2c77ef1d5cb60b3f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724702Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#686623}
-
Derek Schuff authored
Bug: 701326 Change-Id: If652eb76fabc09cabdd61865cdb409f72c140392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748083Reviewed-by:
Lutz Justen <ljusten@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Commit-Queue: Derek Schuff <dschuff@chromium.org> Cr-Commit-Position: refs/heads/master@{#686622}
-
Chris Lu authored
The UMA metrics logging for Infobar badges was removed in crrev.com/c/1717651. This change adds it back in BadgeActionDispatcher. A new 'accepted' property is added to the BadgeButton to determine badge state for the metrics. Bug: 976901 Change-Id: Ic81988d59f6695a1b32e1ca0b4e340cc20966d52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749602 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#686621}
-
Lan Wei authored
This reverts commit 95343512. Reason for revert: <INSERT REASONING HERE> Original change's description: > Disable flag "UpdateHoverAtBeginFrame" > > Blink.MainFrame.StyleAndLayoutRatio metrics has a significant > regression increase, we will disable flag "UpdateHoverAtBeginFrame" for > now in M78 to help identify what is the reason to cause this > regression. > > TBR=bokan@chromium.org > > Change-Id: Ic85d4c142a2a25928c3ec25a61de20649144ef50 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733037 > Reviewed-by: Lan Wei <lanwei@chromium.org> > Commit-Queue: Lan Wei <lanwei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#684518} TBR=bokan@chromium.org,lanwei@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Id6ad8e351ed45dc60d21984ef49bcbbe45dd5b2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752765Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#686620}
-
James Cook authored
ui.MashLogin and ui.SingleProcessMashLogin don't exist any more. Bug: none Change-Id: I9a0d4650a4d3887cf0592f428a2a3cf81f28b82c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752539 Commit-Queue: James Cook <jamescook@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#686619}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/772d5c6161c5..942e493326d1 git log 772d5c6161c5..942e493326d1 --date=short --no-merges --format='%ad %ae %s' 2019-08-13 simonhatch@chromium.org Pinpoint - Record the estimate along with the timing info. Created with: gclient setdep -r src/third_party/catapult@942e493326d1 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:992523 Change-Id: Iea917a9ff732fa1f5310f635897d7b6b7a1f60f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752902Reviewed-by:
-
Simon Pelchat authored
Some navigations are both forward/back and reload. As far as page_end_reason is concerned, these should be considered as history navigations. Most "true" reloads result in the user loading the same URL again (e.g. pull-to-refresh or preview opt-out button). By contrast, navigations that are both forward/back and reload navigations usually result in loading a different URL. Bug: 991741 Change-Id: Iac70ec0b62f6b9bd228419d127ae338ebb4ff5b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743129Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Simon Pelchat <spelchat@chromium.org> Cr-Commit-Position: refs/heads/master@{#686617}
-
Derek Schuff authored
This mirrors the announcement that was sent to native-client-discuss. Bug: 918374 Change-Id: I2e82c60533a2215bdc08ab6668031cba8e94498d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750204Reviewed-by:
Sam Clegg <sbc@chromium.org> Commit-Queue: Derek Schuff <dschuff@chromium.org> Cr-Commit-Position: refs/heads/master@{#686616}
-
Antonio Gomes authored
... when posting tasks. A task posted runs once, so CrossThreadBindRepeating is not strictly correct. This is now possible, after [1]. [1] crrev.com/c/1750043 BUG=964922 R=jbroman@chromium.org Change-Id: Ic3a7cf2fbcd6c07b92efaeab206e45a0cd1e418f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752077 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#686615}
-
Philip Rogers authored
Now that BlinkGenPropertyTrees (BGPT) has launched, we can remove the pre-BGPT code. Bug: 989251 Change-Id: I7c64da9fd5e593436301936abcef3e39198ccbe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752244 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#686614}
-
Sunny Sachanandani authored
Bug: 892874 Change-Id: I15a63a95302d8cf55935f1287d4e9b8fb458ada5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747070Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#686613}
-
