- 13 Apr, 2020 40 commits
-
-
Istiaque Ahmed authored
Some users were passing bool (false), turn them to 0. Bug: None Change-Id: I375e7fff03ec074f6be528c9779809e4aaddcbe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134398Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#758579}
-
Anders Hartvoll Ruud authored
Implementing the base functionality for this is just a matter of resolving the CSSRevertValue using the StyleCascade. However, the existence of the base computed style optimization makes things more complicated, as we can't use this optimization if 'revert' exists in a keyframe. (We don't even match selectors when that optimization is in use, so we wouldn't know what to revert to). In order to fix that, it's necessary to know if an ongoing animation contains a 'revert' or not, and if so disable the optimization in that case. This CL also adds a ConversionChecker for 'revert', which covers the (very) edge case of an extension dynamically changing what is reverted to in the user origin. In MaybeConvertCustomPropertyDeclaration, it was difficult to get the necessary behavior for RuntimeEnabledFeatures::CSSCascadeEnabled() while also leaving the non-cascade path intact. Therefore I re- implemented that function as a "top-level branch" on CSSCascadeEnabled(), which leads to some duplication. Hopefully that's OK since we're anyway going to remove the non-cascade path soon. Bug: 579788, 1068515 Change-Id: I8cbe267b75658ace3f566638bb6ecf10027bdcf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132249 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#758578}
-
Xiaohan Wang authored
Previously this was disabled on ChromeOS, but it's actually flaky on all platforms. Bug: 1070302 Tbr: caseq@chromium.org Change-Id: I27664adcec4c636ad3f25a293fb4634cae29e0bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147546Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#758577}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I5e00ffd3eeab8435d256ea0bace8cd9f543204c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147754Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#758576}
-
kdillon authored
Deleted the config for the old experiments, which are no longer active and were testing various prioritization schemes. Now that we have chosen a method of prioritizing rendering, this experiment is expanding on that by prioritizing rendering until we specifically see a frame as opposed to any rendering task. Change-Id: I4da364bb32269c92c68730cc5be68c1c9c71c356 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133270 Commit-Queue: Katie Dillon <kdillon@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#758575}
-
Lukasz Anforowicz authored
Before this CL: *) GURL port_zero("http://example.com:0") would be considered a valid URL (in conformance with https://url.spec.whatwg.org/#port-state which allows port 0). *) SchemeHostPort constructed out of such GURL would be considered invalid. *) The inconsistency between GURL and SchemeHostPort would lead to bizarre results such as url::Origin::Resolve(url=http://foo.com:0, base_origin=http://bar.com) returning an opaque origin with a precursor origin set to http://bar.com. This in turn would lead to browser process crashes via CHECK(...CanAccessDataForOrigin...). After this CL: *) SchemeHostPort allows port=0 *) url::Origin::Resolve works as expected (verified by a new unit test) *) No browser-process crashes (verified by a new browser test) Also after this CL: *) Navigating to port=0 still doesn't quite work, because Blink treats this as an invalid port (in KURL and SecurityOrigin) which results in the port round-tripping to the browser in DidCommitProvisionalLoad IPC as port=80 (and the mismatch leads to a renderer kill). Bug: 1065532 Change-Id: I719fcfb0a027187805c3766d5e4b0365553067f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128829Reviewed-by:Nasko Oskov <nasko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#758574}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 569eab89. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" c53a40f4 "Update size.attributes.parse.trailingjunk" 86131ac4 "Add a test for ReplaceTrack that verifies video track content." 380347e7 "[css-masking] Migrate clip-path-columns-svg-clippath-usou.html to WPT" 2f3bb77d "[device-orientation] Upstream web tests to WPT" 1992b7fe "Do not set integrity metadata in preload scanner for <link rel=preload as=image>" 9e22b2c7 "[css-flexbox] Move negative-flex-rounding-assert.html to WPT" 67963d34 "[css-flexbox] Move negative-margins-assert.html to WPT" d53acfce "[css-grid] Migrate positioned-grid-items-crash.html to WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-flexbox NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I85747ea4ac16c1eb0bbd3998dc3ea5abf702f819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144995Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758573}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0780cae6bf8d..ac2a401164e1 git log 0780cae6bf8d..ac2a401164e1 --date=short --first-parent --format='%ad %ae %s' 2020-04-13 bsheedy@chromium.org Reland "[Telemetry] Standardize CrOS quoting" Created with: gclient setdep -r src/third_party/catapult@ac2a401164e1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1068708 Tbr: sadrul@google.com Change-Id: Id5dc6c78b69100f6969bfe0ead87c00034d75a08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147892Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758572}
-
Dan Harrington authored
Bug: 1070141 Change-Id: If483f5c4c85dcd5ff7a20d75a87ea7d6be16d8a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145250Reviewed-by:
Jian Li <jianli@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#758571}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4f3aff5fc2f6..925cedba7bad git log 4f3aff5fc2f6..925cedba7bad --date=short --first-parent --format='%ad %ae %s' 2020-04-13 qyearsley@chromium.org Run spellchecker on depot_tools Created with: gclient setdep -r src/third_party/depot_tools@925cedba7bad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Iaab4ed439be5ee463ef77e888c70bdc4a55edb9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147074Reviewed-by:
-
Allen Bauer authored
Upon more detailed inspection of previous code, the DCHECK doesn't serve the same purpose and should be removed. Bug: 1070132 Change-Id: Iaa1f175b3685c5e91f7910f7911839f4708525e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145246Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#758569}
-
Timothy Gu authored
This reverts commit 7920b6e8. It turns out that this change is not web compatible. In addition to reverting the original change, we will seek to change the spec to reflect this web reality. Only the changes to Blink code are fully reverted. The tests are kept, but adapted to reflect this change. A comment update is also kept. Original change's description: > Treat any HTML element with a tabindex attribute as interactive content > > According to the HTML Standard [1]: > > > An element with the tabindex attribute specified is interactive > > content. > > In a subsequent review [2], this clause is reaffirmed by the editor of > HTML. Thus, we implement this accordingly. > > This commit also adds comprehensive testing for all kinds of interactive > content, which have differential treatment by the <label> element > relative to other elements. > > [1]: https://html.spec.whatwg.org/C/#the-tabindex-attribute > [2]: https://github.com/whatwg/html/issues/5414 > > Fixed: 1065048 > Change-Id: I8deff810fead2c9170e18dd4d06dc642f68e6742 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122369 > Commit-Queue: Timothy Gu <timothygu@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Reviewed-by: Mason Freed <masonfreed@chromium.org> > Cr-Commit-Position: refs/heads/master@{#757590} Bug: 1065048 Change-Id: Ic32dbb9ac8eafb9b92a131fde71c5459029260e2 Fixed: 1069615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146089Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#758568}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/984c85e7..1d21ad03 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I473763a1a53bf05d7d305440543071dd611c6297 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144994Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758567}
-
Oriol Brufau authored
This reverts commit be7909b4. Reason for revert: This appears to be breaking site authoring tools which were relying on the previous behaviour. WPT tests are not reverted for now. Bug: 1069866 Original change's description: > [css-grid] Exclude implicit grid tracks from the resolved value > > https://github.com/w3c/csswg-drafts/issues/4475 resolved to try to stop > including implicit tracks in the resolved value of grid-template-columns > and grid-template-rows. > > This implies that the resolved values will have less information now, > which affects lots of tests. I have edited them depending on the case: > - When the size of the track was irrelevant (e.g. just checking whether > some value was syntactically valid), I have just updated the expected > value. > - When the size of the track was relevant, but it wasn't important for > the tracks to be implicit, I have made them explicit in order to get > the same value. > - When the test was about the sizes of implicit tracks, I have added > new checks for the size and position of the grid items. > > Intent to Implement and Ship: > https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/EKvyx2lZJXI > > Spec: https://drafts.csswg.org/css-grid/#resolved-track-list > > Bug: 1024927 > > Change-Id: I4677c184be263eaab08d4aee95bb868306d58228 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897931 > Commit-Queue: Oriol Brufau <obrufau@igalia.com> > Reviewed-by: Manuel Rego <rego@igalia.com> > Cr-Commit-Position: refs/heads/master@{#728894} TBR=jfernandez@igalia.com,rego@igalia.com,obrufau@igalia.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1024927 Change-Id: I8ef626b6ed84a9ee581d542072bda63685a46c42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147814 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#758566}
-
Avery Musbach authored
Test: ash_unittests All/OverviewWindowDragHistogramTest* Bug: 1059477 Change-Id: Icf320197f38a1644fc205bfc5096880a65e8ac5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131041Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#758565}
-
Xida Chen authored
The flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=%0Avirtual%2Fthreaded%2Ftransitions%2Fcomposited-with-hit-testing.html The flake-portal: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyWwsSBUZsYWtlIlBjaHJvbWl1bUBibGlua193ZWJfdGVzdHNfZXhwYXJjaGl2ZUB0cmFuc2l0aW9ucy9jb21wb3NpdGVkLXdpdGgtaGl0LXRlc3RpbmcuaHRtbAw Both shows that this test is no longer flaky. Bug: 988252 Change-Id: Ifc3c5853f2014c9e1ea41c44432d1afdf850b7b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146786Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#758564}
-
Robert Sesek authored
Bug: 977637 Change-Id: I0f4695f9ed12f08b96712fc7a5a3a58b0c7ebe67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146930Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#758563}
-
Min Qin authored
BUG=1036916 Change-Id: If55baf98b48c7ecc95b95b85630a45e33cb5be8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989971 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#758562}
-
siashah authored
Follow up: Populating and retrieving the card_issuer. Please refer to the bug for design doc. Bug: 1063426 Change-Id: I3fb9fa0fc468bdb565dd5cba1218b379664d442a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142617Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Siddharth Shah <siashah@chromium.org> Cr-Commit-Position: refs/heads/master@{#758561}
-
Rohit Rao authored
BUG=1061431 Change-Id: I68651bde5441c009c12b400e99ebc615277b3345 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146934 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#758560}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/cef0af8e6c7f..b0f7984519b7 git log cef0af8e6c7f..b0f7984519b7 --date=short --first-parent --format='%ad %ae %s' 2020-04-13 jalyn@microsoft.com Fix tab order regression in Application panel Created with: gclient setdep -r src/third_party/devtools-frontend/src@b0f7984519b7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1068502 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I892c2559d26a6d899bde255ecbb565a8897c4443 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147068Reviewed-by:
-
Lijin Shen authored
Incognito icons on shortcut menu are out of date. All new pngs have been optimized by tools/resources/optimize-png-files.sh. Bug: 1067127 Change-Id: I9658692507363cb569dab99b4743f4c5a0ae0c08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145969Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#758558}
-
Xianzhu Wang authored
In the following case: effect group { PaintChunk composited ScrollHitTest PaintChunk A PaintChunk B SkBlendMode::kScreen } we should allow B to be decomposited and merged into A because the blend mode doesn't apply to the ScrollHitTest layer and the merge will keep the correct backdrop (which is A) of the blending. This prepares for crrev.com/c/2143511 which will create more ScrollHitTest paint chunks for LayoutViews which would cause unnecessary composited effects without this CL. Change-Id: Ie5b4e26757d12ceb6379c4733c2675e3c98c9e75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144861Reviewed-by:Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#758557}
-
chromium-autoroll authored
Roll broadwell AFDO profile from 83-4091.0-1586169176-benchmark-83.0.4103.7-r1 to 84-4091.0-1586169474-benchmark-84.0.4111.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I601bcd1b9f61cd3ce09c0a344e14aef8292600d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147895Reviewed-by:
-
chromium-autoroll authored
Roll silvermont AFDO profile from 83-4099.3-1586168020-benchmark-83.0.4103.7-r1 to 84-4099.3-1586167754-benchmark-84.0.4111.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I899ed2526e97d0cecce9281b25a63f597200bf13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147894Reviewed-by:
-
Yi Gu authored
This test is no longer timeout after crrev.com/c/2110830 where the test was given more time to finish. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=blink_web_tests%20(with%20patch)&tests=virtual/threaded/external/wpt/animation-worklet/idlharness.any.html Bug: 1045329 Change-Id: Iea17d1053f241f0f36394df7caef947ddace711a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147061Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#758554}
-
chromium-autoroll authored
Roll airmont AFDO profile from 83-4099.3-1586165807-benchmark-83.0.4103.7-r1 to 83-4099.3-1586165807-benchmark-84.0.4111.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: If86f1ce2e2e774ab6c9dd1da406c61cf2ee2215f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147893Reviewed-by:
-
Nick Diego Yamane authored
XWindow can be destroyed in the middle of a delayed resize closure execution. It may happen when that window is snapped into a tab bar. More specifically when a nested move loop, used to intercept and forward the mouse events during a tab dragging session, is triggered by a bounds change event notified from a delayed resize task. To fix it, this uses a weak pointer to verify whether the window instance is still alive after notifying the bounds change in the delayed resize function implementation. Bug: 1068755, 1021490 Change-Id: I08eff38d5f5f28ec54e489dc183f3f0cfdde2480 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144996Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#758552}
-
Kai Ninomiya authored
This seems to be necessary to capture them in a test isolate (instead of capturing hollow symlinks). Bug: 1069302 Change-Id: If2c3b2594d05b647d3f6e6a947f5dc0ab26a6444 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145702Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#758551}
-
Ben Schwartz authored
If a DNS probe happens before the previous probe completes, the previous callback will never be called, leading to a JS stack leak. This change resolves the first callback to free up the stack. This leak is unlikely in practice. If a leak does occur, it persists until the user closes the settings page. Change-Id: Id12a4181bdbe1274c7441d9be9bf223d2a457406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132589 Commit-Queue: Ben Schwartz <bemasc@chromium.org> Auto-Submit: Ben Schwartz <bemasc@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#758550}
-
Devlin Cronin authored
Rename ShowToolbarActionPopup() and ShowExtensionActionPopup() to ShowToolbarActionPopupForAPICall() and ShowExtensionActionPopupForAPICall(). These methods were only used when displaying a popup in response to an API call (outside of tests), and this name makes it more obvious. Additionally, this lets us get rid of the additional "grant_active_tab" bool, which was always (outside of tests) set to false. Bug: None Change-Id: I02b4c489586f6cbec3ac99b02ce15413f2ceff40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145858Reviewed-by:
Caroline Rising <corising@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#758549}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f61ee1ecac14..ecd82d832f4f git log f61ee1ecac14..ecd82d832f4f --date=short --first-parent --format='%ad %ae %s' 2020-04-13 csmartdalton@google.com ccpr: Ensure stencil buffer gets fully reset to zero 2020-04-13 robertphillips@google.com Allow path renderers to self-identify 2020-04-13 robertphillips@google.com Make GrTextStrike::addGlyphToAtlas a static method in GrTextBlob.cpp 2020-04-13 brianosman@google.com Remove threaded code Created with: gclient setdep -r src/third_party/skia@ecd82d832f4f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: I1831816b7a30cf865f580c4b02a052389d74ebb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147066Reviewed-by:
-
Jenny Zhang authored
The corner case happens when user type a query in search box then quickly press DOWN or RIGHT key to change the selection to another result, but right after this, search box publish results again, search results UI were updated, and default selection were changed back to the first visible app. But the search box text remained as the previous user selected result's title or url. Fix the issue by restoring the search box text to the original query user typed in the search box to make UI look consistent. Bug: 1065454 Change-Id: I9b773869b89825ec11744bfc997456bbd05779a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146449Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#758547}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I299208728a97706bcfed67fe6f1fc8934cc2bf12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147070Reviewed-by:
-
Kevin Babbitt authored
This is a reland of 50fbc87a The CL got reverted due to flakiness on Win7. From the logs it appears that the flakes were caused by test content sometimes extending beyond window bounds, resulting in incorrect hit test results. To address this issue, existing tests have been rewritten to use smaller content. I ran the rewritten tests 100x on a Win7 VM and saw 0 failures. Several cleanups were made along the way: - Update comments and code to reflect the fact that BrowserAccessibilityManager.HitTest takes a point in frame coordinates. - Increase device scale factor in scaled tests from 1.25 back to 2. - AccessibilityHitTestingBrowserTest.HitTestingInIframes: This test was almost identical to AccessibilityHitTestingZoomBrowserTest.HitTest, with the addition of testing with a different event. Combined the two into a single test: AccessibilityHitTestingBrowserTest.HitTest. - AccessibilityHitTestingCrossProcessBrowserTest.*: these two tests were also nearly identical. Combined into a single test which validates both the frame tree and the scrolling case with the same content. - AccessibilityHitTestingBrowserTest.*WithPinchZoom: these tests were not actually exercising accessibility hit testing paths - they were generating input events which got sent directly to Blink. Replaced these with tests that exercise accessibility hit test paths in the presence of pinch zoom. Original change's description: > Parameterize existing accessibility hit-testing tests > > https://crrev.com/c/2117330 added tests for cross-platform > accessibility hit testing code using parameterized combinations of > simulated device scale factor and use-zoom-for-dsf on or off. This CL > expands the parameterization to other existing hit-testing tests. > > To fix issues running these tests on cast_shell_linux I also made two > changes to the tests themselves: > - Reduce the scale factor from 2 to 1.25 > - Relocate one test point to be within the screen size > > Bug: 1007488 > Change-Id: I715270064365458ac9ec69f3c3ac81a674d2718c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135017 > Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#756884} Bug: 1007488, 1069850 Change-Id: I01fcb7d2b7f6a764ccd76da3e97778dfc184960e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140198 Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#758545}
-
Maks Orlovich authored
What matters here is the policy for the top-level frame, as filtered by Feature Policy; we were simply not using any persistent settings at all. Change-Id: I1435bdc9dfcc6f6643ea737a135e8c0e07e7ecde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083671Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#758544}
-
Rainhard Findling authored
Bug: 1015841 Change-Id: I7d08cbad60569da8221d58835c59d6793d612208 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139692 Commit-Queue: Rainhard Findling <rainhard@chromium.org> Reviewed-by:
-
David Bertoni authored
The ExtensionCannotFetchHostedResourceWithoutHostPermissions is no longer flaky. Bug: 1038156 Change-Id: Iecadf163ddd5be64e296188352ae3a268fe715a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140777Reviewed-by:
Archana Simha <archanasimha@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#758542}
-
Anton Bershanskiy authored
Added getScanRecord_getAdvertiseFlags() to ScanResultWrapper to be called by ScanCallback.onScanResult to pass to ChromeBluetoothAdapterJni.get().createOrUpdateDeviceOnScan() which sends them to UpdateAdvertisementData(). Bug: 661814 Change-Id: Iad8c49936a796d4ca4ec39782c0f28ea66286271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144153Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#758541}
-
yilkal authored
This Cl ensures that the blocking page title is the same as the previous page title if the previous page title has been set. Bug: 1061626 Change-Id: Ia9f813323b09d42aa5c2c12b139aabadea589ba1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142136 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#758540}
-
