GitLab

BUG=424599

Review URL: https://codereview.chromium.org/667423002

git-svn-id: svn://svn.chromium.org/blink/trunk@184192 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=skia:2889

Review URL: https://codereview.chromium.org/660083002

git-svn-id: svn://svn.chromium.org/blink/trunk@184191 bbb929c8-8fbe-4397-9dbb-9b2b20218538

"copy" also needs temp layer, but we optimized it via clearing the canvas.
It's why we missed handling "copy" when we fix the bug related to shadow with "source-in".
This CL optimizes shadow with "copy" by not-drawing a shadow.

TEST=layout test fast/canvas/canvas-composite-shadow.html
BUG=417409

Review URL: https://codereview.chromium.org/672593002

git-svn-id: svn://svn.chromium.org/blink/trunk@184190 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/669113002

git-svn-id: svn://svn.chromium.org/blink/trunk@184189 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=dgozman
BUG=425911

Review URL: https://codereview.chromium.org/662393007

git-svn-id: svn://svn.chromium.org/blink/trunk@184188 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently the srcset resource selection simply picks the first candidate with a density that's equal or larger than DPR.

That results in cases where slight zooming causes a DPR of 1.1 and the download of a 2x resource, 
even though the 1x resource would have been enough.

This CL fixes that, by making sure that a higher resolution resource is downloaded only if 
the DPR is larger than the geometric mean of that resource's density and the density of the resource that preceded it in the sorted candidate list.

The srcset resource selection is intentionally defined as UA specific in the spec:
https://html.spec.whatwg.org/multipage/embedded-content.html#the-img-element:image-source-2

That is in order to allow browsers to play around with resource selection logic heuristics.

Geometric mean was proposed by Tab Atkins as a "decent first draft":
http://ircbot.responsiveimages.org/bot/log/respimg/2014-04-22#T66515

BUG=425511

Review URL: https://codereview.chromium.org/667763004

git-svn-id: svn://svn.chromium.org/blink/trunk@184187 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=184176

BUG=425552
TBR=rune@opera.com

Review URL: https://codereview.chromium.org/666383002

git-svn-id: svn://svn.chromium.org/blink/trunk@184186 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=424453

Review URL: https://codereview.chromium.org/647933003

git-svn-id: svn://svn.chromium.org/blink/trunk@184185 bbb929c8-8fbe-4397-9dbb-9b2b20218538

 * Use standards mode.
 * Make test small enough to fit in content_shell.
 * Use fixed widths columns to simplify ref.

R=mstensho@opera.com
BUG=386567

Review URL: https://codereview.chromium.org/671433002

git-svn-id: svn://svn.chromium.org/blink/trunk@184184 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In patch https://codereview.chromium.org/263853008
WebViewImpl::resetSavedScrollAndScaleState() function definition was removed but not function declaration.

Review URL: https://codereview.chromium.org/670143002

git-svn-id: svn://svn.chromium.org/blink/trunk@184183 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=415082

Review URL: https://codereview.chromium.org/663083007

git-svn-id: svn://svn.chromium.org/blink/trunk@184182 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Section 10.4 of the specs describe how to resolve content based track sizing
functions. Among others it describes the "distribute extra space" algorithm.
The 3rd bullet of that algorithm specifies how to distribute (and also in which
subset of tracks) the extra space once all the tracks have reached their grow
limits.

Our implementation had 2 problems. First we were not passing a valid subset of
tracks (instead we were using all of them). Secondly the algorithm that was
distributing the extra space was not using that list of passed in tracks,
instead it was using all of them.

Now we use a function that filters the right tracks to be the target of the
extra space distribution depending on whether we're computing the min track
function or max track function.

Review URL: https://codereview.chromium.org/582733003

git-svn-id: svn://svn.chromium.org/blink/trunk@184181 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=loislo, yurys

Review URL: https://codereview.chromium.org/666343002

git-svn-id: svn://svn.chromium.org/blink/trunk@184180 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is made in preparation for enabling selection auto scroll using touch
handles.

BUG=340658

Review URL: https://codereview.chromium.org/653383002

git-svn-id: svn://svn.chromium.org/blink/trunk@184179 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=390486
TEST=Added layout tests based on checkValidity tests, with added focus check

Review URL: https://codereview.chromium.org/660783002

git-svn-id: svn://svn.chromium.org/blink/trunk@184177 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Align with CSS UI spec[1] and Gecko.

[1] http://dev.w3.org/csswg/css-ui/#resize

R=andersr@opera.com,timloh@chromium.org
BUG=425552

Review URL: https://codereview.chromium.org/639293008

git-svn-id: svn://svn.chromium.org/blink/trunk@184176 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/645443003

git-svn-id: svn://svn.chromium.org/blink/trunk@184175 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/WebKit/Source/bindings

This step is to move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/WebKit/Source/bindings
(Ref: binding-methods changed:
static PassOwnPtr<ArrayBufferContentsArray> transferArrayBuffers(ArrayBufferArray&, ExceptionState&, v8::Isolate*)
void addHiddenValueToArray(v8::Handle<v8::Object>, v8::Local<v8::Value>, int cacheIndex, v8::Isolate*)
void removeHiddenValueFromArray(v8::Handle<v8::Object>, v8::Local<v8::Value>, int cacheIndex, v8::Isolate*)
void moveEventListenerToNewWrapper(v8::Handle<v8::Object>, EventListener* oldValue, v8::Local<v8::Value> newValue, int cacheIndex, v8::Isolate*)
PassRefPtr<TraceEvent::ConvertableToTraceFormat> devToolsTraceEventData(ExecutionContext*, v8::Handle<v8::Function>, v8::Isolate*))

BUG=424446

Review URL: https://codereview.chromium.org/668673002

git-svn-id: svn://svn.chromium.org/blink/trunk@184174 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=425451
R=vsevik@chromium.org

Review URL: https://codereview.chromium.org/659403006

git-svn-id: svn://svn.chromium.org/blink/trunk@184173 bbb929c8-8fbe-4397-9dbb-9b2b20218538

There are traceviewer-compliant WASD shortcuts in FlameChart for
convenient navigation. However, they are not functional unless the
FlameChart is manually selected via mouse click on an *empty* place in
flamechart (clicks on flamechart entries send you to sources view).

The patch does two things:
- makes sidebarPane unselectable so that resizing sidebar won't grab
focus
- focuses flamechart as it gets displayed

R=pfeldman, yurys

Review URL: https://codereview.chromium.org/672553002

git-svn-id: svn://svn.chromium.org/blink/trunk@184172 bbb929c8-8fbe-4397-9dbb-9b2b20218538

According to a post by Darin Adler [1], OSX older than SnowLeopard had the
ceil() bug. We don't support the older versions of OSX.

This CL also renames LayoutUnit::wtf_ceil and Decimal::ceiling.

[1] https://bugs.webkit.org/show_bug.cgi?id=78032#c8

BUG=

Review URL: https://codereview.chromium.org/673583002

git-svn-id: svn://svn.chromium.org/blink/trunk@184171 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=425514

Review URL: https://codereview.chromium.org/672573002

git-svn-id: svn://svn.chromium.org/blink/trunk@184170 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Extend committed pages counting to direct mapped allocations as well. We
already did adjust the total committed pages size when reallocating a
direct mapped allocation to reflect the difference, but since we didn't do
any counting when initially mapping or when unmapping, this would just
result in accounting errors.

Review URL: https://codereview.chromium.org/649583004

git-svn-id: svn://svn.chromium.org/blink/trunk@184169 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=424171
R=dgozman@chromium.org

Review URL: https://codereview.chromium.org/670123002

git-svn-id: svn://svn.chromium.org/blink/trunk@184168 bbb929c8-8fbe-4397-9dbb-9b2b20218538

SVGAnimatedOrder is introduced to handle parse errors for SVGFEConvolveMatrixElement's orderAttr in setBaseValueToString.

This is to replace the existing |SVGElement::parseAttribute| implementation,
but as there are many callers, we would like to proceed this incrementally.
a) Introduce |SVGElement::parseAttributeNew| *LANDED*
b) Convert all overrides |SVGElement::parseAttribute| to
   a |parseAttributeNew| call. <-- This patch
c) Replace existing |parseAttribute| with |parseAttributeNew|, and remove all
   overrides simply calling |parseAttributeNew|

This patch is (b).

BUG=397902

Review URL: https://codereview.chromium.org/668113003

git-svn-id: svn://svn.chromium.org/blink/trunk@184167 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently HRTFDatabaseLoader::m_threadLock is acquired when accessing
m_databaseLoaderThread, but the lock is not needed because m_databaseLoaderThread
is not accessed by multiple threads.

What we need to protect is not m_databaseLoaderThread but m_hrtfDatabase,
which is accessed by multiple threads. This CL makes the fix.

BUG=415305

Review URL: https://codereview.chromium.org/666213003

git-svn-id: svn://svn.chromium.org/blink/trunk@184166 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Oherwise retained size of an object would be affected by the references.

BUG=425905

Review URL: https://codereview.chromium.org/674443003

git-svn-id: svn://svn.chromium.org/blink/trunk@184165 bbb929c8-8fbe-4397-9dbb-9b2b20218538

[DevTools] Disallow use of global properties "document", "addEventListener" and "removeEventListener".

BUG=424188

Review URL: https://codereview.chromium.org/659973003

git-svn-id: svn://svn.chromium.org/blink/trunk@184164 bbb929c8-8fbe-4397-9dbb-9b2b20218538

XMLHttpRequest implementation has methods to set line number and URL of
send() method call to pass to
InspectorInstrumentation::didFinishXHRLoading(), but they are not used.
We can just remove this code. See below.

Since WebInspector.ConsoleMessage gets the corresponding request object
in its constructor using the requestId parameter and extracts the line
number and URL of send() method call, we don't need to remember and
pass them from the XMLHttpRequest class as far as we pass the request
identifier given on XMLHttpRequest::didFinishLoading() call to
InspectorInstrumentation::didFinishXHRLoading().

R=sigbjornf,eustas
BUG=none

Review URL: https://codereview.chromium.org/667393002

git-svn-id: svn://svn.chromium.org/blink/trunk@184163 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=425523
R=pfeldman, vsevik

Review URL: https://codereview.chromium.org/666163003

git-svn-id: svn://svn.chromium.org/blink/trunk@184162 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=none

Review URL: https://codereview.chromium.org/663693005

git-svn-id: svn://svn.chromium.org/blink/trunk@184161 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Instrument postMessage() to determine usage of the overload

  postMessage(data, origin, transferables)

R=mkwst
BUG=425896

Review URL: https://codereview.chromium.org/670893003

git-svn-id: svn://svn.chromium.org/blink/trunk@184160 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The FileSetFileHandle was only used by the ZipFileSet
which have already been removed from the webkitpy.

Review URL: https://codereview.chromium.org/641813008

git-svn-id: svn://svn.chromium.org/blink/trunk@184159 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use python platform-dependent methods for this.

+ cleanup imports
+ fix execution bit

BUG=425468

Review URL: https://codereview.chromium.org/662393004

git-svn-id: svn://svn.chromium.org/blink/trunk@184158 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This function was used by build-webkit according to it's comment.
Currently it is used by FlakyTests and some unit tests but it can
be replaced with run_command

Review URL: https://codereview.chromium.org/663023008

git-svn-id: svn://svn.chromium.org/blink/trunk@184157 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=424188

Review URL: https://codereview.chromium.org/663083004

git-svn-id: svn://svn.chromium.org/blink/trunk@184156 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The new descriptions make it easier to quickly determine what each test is
doing. There should be no performance impact on the tests themselves as
setting the description is not in the critical section of the tests.

BUG=404274

Review URL: https://codereview.chromium.org/478003002

git-svn-id: svn://svn.chromium.org/blink/trunk@184155 bbb929c8-8fbe-4397-9dbb-9b2b20218538

If the author specifies an absurdly large number of repetitions it might
happen that the double value contained in the CSSParserValue does not fit in
a size_t, so it is clamped down to 0 during the type casting.

From now on we limit the value of repetitions to kGridMaxTracks (1 million)
before casting the double value to a size_t.

BUG=425001

Review URL: https://codereview.chromium.org/645793005

git-svn-id: svn://svn.chromium.org/blink/trunk@184154 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It's really this easy because of the Script(Runner|Loader)
refactoring (r183984).

Note that this feature is behind the --enable-v8-script-streaming flag.

BUG=

Review URL: https://codereview.chromium.org/645443004

git-svn-id: svn://svn.chromium.org/blink/trunk@184153 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=None

Review URL: https://codereview.chromium.org/643533003

git-svn-id: svn://svn.chromium.org/blink/trunk@184152 bbb929c8-8fbe-4397-9dbb-9b2b20218538