- 22 Jan, 2021 40 commits
-
-
Jinsuk Kim authored
The purpose of the test was to ensure gesture events triggered after the navigation handler destruction can still be handled gracefully without causing crash. Destroying the entire gesture navigation MVC component in the test to simulate the situation became tricky, which marked the test disabled. This CL destroys the NavigationHandler (a mediator) only, which still serves the purpose of the test, to check the case. Bug: 1147553 Change-Id: I1cca3c895404a883c441a314b4b55f0bfd3a20cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642644Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#845982}
-
Kenton Lam authored
- Changed tab buttons to be cr-icon-buttons for Chrome-esque styling. - Change variations indicator to grey triangle in bottom-right. - Smooth scrolling on emoji group button click. - Minor changes to tests to match element structure changes. Googlers: http://screen/7PbkwwPcqKRCmw8.png Bug: 1152237 Change-Id: Ib82f28c57428b54ca104d3abd9535fb77fcccf4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641690Reviewed-by:
John Palmer <jopalmer@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: Kenton Lam <kentonlam@google.com> Cr-Commit-Position: refs/heads/master@{#845981}
-
Kenton Lam authored
Gets and stores the current TextInputClient and selection range when the emoji dialog is opened. Inserting emoji will insert into that TextInputClient. Because the emoji picker window closes when it loses focus, this *should* always be correct. One edge case is if the TextInputClient disappears after the emoji picker is opened (one example of this is the launcher's search box). Change-Id: I1fedd494a36603b252fcff3a5e9b0d8df63a004c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626482Reviewed-by:
-
Clark DuVall authored
Since the shell APK needs to be loaded for perf tests, it can affect metrics like memory usage if it has too much java code. This shrinks the size of the shell APK dex from ~9MB to <1MB. Bug: 1146438 Change-Id: Ife6ddac73ef9fd80995240b23cc6e6760cf833d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644102 Commit-Queue: Clark DuVall <cduvall@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#845979}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c09761f57605..e4652059389f 2021-01-22 csmartdalton@google.com Remove the offthread triangulation from GrPathTessellateOp If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: I6316d8c707779322a06409310e3648ba31f3a48d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642874Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845978}
-
Yuki Shiino authored
ArrayBufferView is a partial view to the underlying ArrayBuffer. When parsing PushSubscriptionOptionsInit.applicationServerKey given an ArrayBufferView, the partial view of the ArrayBufferView should be processed instead of the entire underlying buffer. Change-Id: I87156f41e50e7615bc19ac00df92a8cca2843c75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641829 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#845977}
-
Yoshifumi Inoue authored
This patch marks following tests to slow: - http/tests/devtools/sources/source-frame-toolbar-items.js - http/tests/devtools/profiler/cpu-profiler-bottom-up-large-tre TBR=petermarshall@chromium.org Bug: 1046784 No-Tree-Checks: true No-Try: true Change-Id: I373f94c76b2c70e05da13d442d64182b4136a775 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643675Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#845976}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/be163e76ce9c..028c0da21c9e 2021-01-22 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I602bbcaee3381eca20c89bd59b5cbae24c51dc30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642873Reviewed-by:
-
Miguel Casas authored
This CL removes the VP9.2 video decoding workaround after some other CLs paved the way for it (see bug). Verified on my local Zork. Bug: b/1695991197 Change-Id: Ie1f5343ad3f181103d550e5061cfd54ea2477fd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644290 Commit-Queue: Miguel Casas <mcasas@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Auto-Submit: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#845974}
-
Amr Aboelkher authored
It's preferred to use the common/well-known abbreviations directly instead of its full name whenever it's possible in Chromium. This CL is unifying the usage of PSM abbreviation everywhere PSM is being used, instead of it's full name. That is going to make a lot of PSM related tests more readable. Before that, it was suffering from long tests names which made it difficult to read. BUG=chromium:1168699 Change-Id: I4c8202800e9a896a63ca448917315eb8f57f6357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642617 Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#845973}
-
Jiewei Qian authored
Speculative fix PlatformAppBrowserTest.OpenLink by registering TabAddedWaiter before launching the App. Bug: 1164123, 1000234 Change-Id: Ie1a303974d50941ca4cdc8382837e0ca86dd914e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642645 Auto-Submit: Jiewei Qian <qjw@chromium.org> Commit-Queue: Ben Wells <benwells@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#845972}
-
Minju Kim authored
Now that it is called directly from the single place, lambda 'add_region' is not needed anymore. Bug: 1126828 Change-Id: Ia3f21359fda9a06c05ce0307171340728f2e532d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641687 Commit-Queue: MINJU KIM <mkim@igalia.com> Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#845971}
-
Giovanni Ortuño Urquidi authored
There are three related changes: 1. Change ManifestUpdateManagerSystemAppBrowserTest.CheckUpdateSkipped to closer match how installs are done for System Web Apps i.e. we no longer use a manifest for the initial install. 2. Remove set_manifest() which the test used to change the manifest of the SWA 3. Remove a couple of other unnecessary methods now that we removed set_manifest(). We don't completely remove the manifest because a test still uses it. Bug: 1158686 Change-Id: Ib9ed2f81c0b3ba877f2bc74151fc0dd9c4c1c291 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641786 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Jiewei Qian <qjw@chromium.org> Cr-Commit-Position: refs/heads/master@{#845970}
-
Daniel Hosseinian authored
De facto enable the feature by default. Meanwhile: - Add a check that the plugin never starts in edit mode on non-CrOS platforms. - Update and clean up some tests. Fixed: 1169292 Change-Id: If34290490f6eec6cf2bcefb1ec15eaa7d51e2f5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643267Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#845969}
-
Alan Cutter authored
This CL adds a test for having multiple query params in the launch query params for a web app. Change-Id: I28475fd7b81355a9cca1077767e8a0e2380dd2e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639335Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#845968}
-
Andrew Grieve authored
Using function pointers rather than lambdas to address binary size regression from the introduction of ForEachObserver. Recovers 11,468 of the original 15,600 regression. Bug: 1116531 Change-Id: I56352c559931859610b00a7dfad615052147ffbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639396 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#845967}
-
Joe DeBlasio authored
This CL changes the local allowlist, used when a user ignores a safety tip or interstitial, to apply eTLD+1-wide instead of just to a particular origin. This is particular important for the interstitial to avoid multiple warnings on sites that redirect, for instance from a bare domain (google.com) to a subdomain (www.google.com), or from nonsecure (http://google.com) to secure (https://google.com). A future CL, not merged back to M89, will adjust this allowlist to handle pairs of domains (i.e. (lookalike domain, canonical domain) pairs). Bug: 1154702 Change-Id: Ic112ca11b4fd66ebbe393822da0651ee832f6aca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640741 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#845966}
-
Wojciech Bielawski authored
Python 3 doesn't define 'long', but has 'int' type capable to store python's 2 'long' values. In addition most of places where 'long' is used seems to be not relevant, so 'long' can be relpacled with 'int' anyhow. Bug: 1168119 Change-Id: I971ea9044ce6dc5f084df122ba6d2571a8bb68cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640256Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#845965}
-
Anupam Snigdha authored
This CL is a continuation of crrev.com/c/2619002. We are planning to remove |VisiblePosition| usages in editing commands and selection because it leads to issues related to positions being snapped to incorrect location. Bug: 669811 Change-Id: I2f1f668033d3e1bc2d4209c9610878beaefd2c0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643708 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/302f83f07614..5b2a5204087d 2021-01-22 ythjkt@google.com Merge "Enable subprocess support for chrome os." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I95e438a0d5fb1f223da12ff067a84de706d22a91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644289Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/70f493d6e6ab..ff5f715e5c4a 2021-01-22 stevenan@google.com Properly fail upon program binary version mismatch 2021-01-22 timvp@google.com Capture/Replay: Capture all indexed buffer bindings during MEC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: Ide69ed962820cc01f2a979c29d47abec3b8f8681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643246Reviewed-by:
-
Minju Kim authored
SkPath from |PlatformWindowDelegate::GetWindowMaskForWindowShape| needs to be transformed in DIPs by the given |buffer_scale_| before converted to rectangles. TEST: test with --force-device-scale-factor Bug: 1126828 Change-Id: I268e7266ba9131cf8eba481b1c30b93d2f1c3788 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637098Reviewed-by:
-
Luciano Pacheco authored
Bug: 1133186 Change-Id: Ib1bdd895ef7872d940cebcf8825a90f575db5082 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643671 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#845960}
-
Adam Rice authored
They are now enabled by default. BUG=614302 Change-Id: Ied5e70e3bd6405e296d9b6fa0fccec5beb9ce1aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643419 Auto-Submit: Adam Rice <ricea@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#845959}
-
Peter Kotwicz authored
src/third_party/guava dependency in DEPS is redundant with src/third_party/android_deps/libs/com_google_guava_guava BUG=None Change-Id: I6b3fa4f90cb73ea90474c249c2e23e2c52463b56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642940Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#845958}
-
Victor Vasiliev authored
https://quiche.googlesource.com/quiche.git/+log/9aef115356ce..47d67c37230e $ git log 9aef11535..47d67c372 --date=short --no-merges --format='%ad %ae %s' 2021-01-21 haoyuewang Add PeerIssuedConnectionIdManager that handles NewConnectionId Frame. 2021-01-21 bnc Add TlsServerHandShaker::GetAcceptChValueForOrigin() to configure ACCEPT_CH value. 2021-01-21 bnc Parse received ALPS data in QuicSpdySession. 2021-01-20 vasilvv Disable feature flags that broke Chromium unit tests in order to move the roll forward. 2021-01-20 fayang Add debugging logging for b/177651625. 2021-01-19 renjietang In QuicConnection, log the most recent frame type in a packet. 2021-01-19 danzh Refactor QuicConnection::OnConnectionMigration() to use active_effective_peer_migration_type_ instead of passing in the address change type as a parameter. 2021-01-19 bnc Internal QUICHE change 2021-01-19 fayang Internal QUICHE change 2021-01-19 wub Internal QUICHE change 2021-01-19 fayang Internal QUICHE change 2021-01-19 fayang Internal QUICHE change 2021-01-19 fayang Internal QUICHE change 2021-01-19 fayang Internal QUICHE change 2021-01-19 ianswett Internal QUICHE change 2021-01-18 ianswett Internal QUICHE change Created with: roll-dep src/net/third_party/quiche/src Change-Id: I0d83d35fbde4d6ffd5a426f2d4969ea3f8d772c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642861Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#845957}
-
Hiroki Nakagawa authored
This CL is a preparation for implementing the Omnibox trigger. This removes dependencies on the initiator RenderFrameHost from PrerenderHost(Registry) so that the Omnibox trigger that doesn't have a concept of the initiator frame will be able to trigger prerendering. Before this CL, PrerenderProcessor passed the identifier of the initiator frame up to PrerenderHost in order to retrieve BrowserContext. After this CL, StoragePartitionImpl passes BrowserContext when instantiating PrerenderHostRegistry, so the registry and hosts no longer need the initiator frame. Bug: 1166085 Change-Id: I0da9a95427c10ef65be7f2539311d50c002d68db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639352 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#845956}
-
spdonghao authored
This CL does some refactoring work: 1. Save existing MV tiles info instead of only SiteSuggestion data. 2. Remove MV tiles favicons saving codes - the cached favicons are not always consistent with post-native ones so we show the default grey background icon instead. 3. Since favicons are no longer cached, we don't need to keep |mUrlToIdMap| and |mUrlsToUpdateFavicon|. 4. SiteSuggestion#faviconId is no longer needed. Bug: 1067386 Change-Id: I2f05ea32a04c30ef8ed21504a78a77771edb4043 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611670Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Hao Dong <spdonghao@chromium.org> Cr-Commit-Position: refs/heads/master@{#845955}
-
Adam Rice authored
The README file for chromium-specific stream web tests made reference to the SimpleQueue class, which no longer exists. Update it to reflect the current situation. Change-Id: Iea48716869617d2963dc2e7a13c465a83d44da44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644417 Commit-Queue: Adam Rice <ricea@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Auto-Submit: Adam Rice <ricea@chromium.org> Reviewed-by:
-
Hongbo Song authored
UKM privacy review: https://docs.google.com/document/d/1Vmbwz9ehnM-XHV2ueYj2nESTyTm57Inel0CLyX1ehXY/edit?usp=sharing&resourcekey=0-57VBdHDe9OSSTynCVtpatg Change-Id: I8055032fd2ce0b88667abb81248476690ba4c331 Bug: 1167755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640900Reviewed-by:
Hongbo Song <hbsong@google.com> Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Hongbo Song <hbsong@google.com> Cr-Commit-Position: refs/heads/master@{#845953}
-
Reilly Grant authored
This change converts callbacks from base::Bind and base::Callback to Once/Repeating in //chrome/browser/chromeos/arc. Code previously using base::AdaptCallbackForRepeating now uses the more purpose-specific base::SplitOnceCallback. Bug: 1148570 Change-Id: Ie087afe3f6be92b267f2e36a7785052107344580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644344 Commit-Queue: Reilly Grant <reillyg@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#845952}
-
Ken MacKay authored
In Cast code, we often use a SequenceBound instance to handle calls from multiple sequences and forward them to a single sequence for execution (for example for methods that need to run on an IO thread, or simply to avoid thread-safety issues by running all business logic in a single sequence). A typical usage looks like: * A wrapper class exposes some API that is called in several places in our codebase, from multiple sequences. * The implementation of the wrapper class forwards the API calls to a SequenceBound<T> instance (using Post()) that implements the actual logic. * The wrapper class creates the SequenceBound<T> in its constructor, and deletes it in its destructor. Since we have to ensure that callers do not call into the wrapper after it is destroyed anyway, this usage of SequenceBound is safe. Change-Id: I40d67cd56e34a938492a8c528ec87bc25332fd52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639652Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#845951}
-
Joel Hockey authored
The FileSystemURL from ConvertPathInsideVMToFileSystemURL will be used with the clipboard to copy and paste files between VMs and FilesApp. It needs to be valid with the real FilesApp Origin in order for this to work. Bug: b/162602338 Change-Id: I3ac2961e762dd26104b5f2461997b3175a5f7367 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643737 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#845950}
-
Ye Kuang authored
Bug: 1141780 Change-Id: I2c3dc3a97b6c6a3ba70744e4b38475144b406897 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639435 Commit-Queue: Ye Kuang <yekuang@google.com> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Fumitoshi Ukai <ukai@google.com> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Cr-Commit-Position: refs/heads/master@{#845949}
-
Yoshifumi Inoue authored
This reverts commit 8e907715. Reason for revert: Build failed on mac-arm64-rel bot. https://ci.chromium.org/p/chromium/builders/ci/mac-arm64-rel/3537 ../../third_party/swiftshader/third_party/marl/include/marl/pool.h:236:27: error: aligned deallocation function of type 'void (void *, std::align_val_t) noexcept' is only available on macOS 10.14 or newer MARL_NO_EXPORT inline ~Storage(); ^ Original change's description: > Roll SwiftShader from 1d5174b9dc3b to 5b36fbc5ed2b (3 revisions) > > https://swiftshader.googlesource.com/SwiftShader.git/+log/1d5174b9dc3b..5b36fbc5ed2b > > 2021-01-21 capn@google.com Target macOS 10.12 when building LLVM > 2021-01-21 capn@google.com Use aligned allocation for classes with aligned members > 2021-01-21 nicolascapens@google.com Enable and require C++17 compilation > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/swiftshader-chromium-autoroll > Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 > Bug: None > Tbr: swiftshader-team+autoroll@google.com > Change-Id: I986f61efb56c3c3ca18b0100ae6ca3dfee2fed7b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643117 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#845830} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,swiftshader-team+autoroll@google.com Change-Id: I318bd80475234a7b9b7b5ef3d61602182f2f6dc8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644401Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=lakpamarthy@chromium.org Change-Id: I66bf05e42815ba0bd51b0769b784a2aefe2f9570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643169Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845947}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ife65dd1f215e0bb5afaa22ef0763644f8acc2c4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644002Reviewed-by:
-
Austin Tankiang authored
This is part of the plumbing to allow DriveFS to display confirmation dialogs in Files App. Now, when DriveFS calls into Chrome to display a dialog, this called is plumbed via DriveFsEventRouter to the Files UI as a fileManagerPrivate API event. This also exposes an interface, notifyDriveDialogResult, for the UI to send the result of the dialog back to DriveFS. Bug: 1166058 Change-Id: I25d1bc97eafb38e140cd20af152b53929550eb47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637124 Commit-Queue: Austin Tankiang <austinct@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#845945}
-
Joel Hockey authored
Refactor only change. Refactor GetFilenames to return internal FileInfo struct which includes FilePath and FileSystemURL so that it can be reused by CreateClipboardFilenamesPickle in crrev.com/c/2638967. By keeping the FileSystemURL in addition to the FilePath, it saves duplicating the code to crack the URL from the path. Bug: b/162602338 Change-Id: I91356840303bc6f15e11fcf43cad75c06e29fe7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643736 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
-
dpapad authored
- Delete testOpenCloseBookmarks() test case in basic_test.js (bookmarks no longer shown in a popup). - Make testToolbarDropdownShowHide() test case only run on CrOS in material_elements_test.js, since viewer-toolbar-dropdown will only be included on CrOS as a dependency of viewer-annotations-bar. - Remove references to the "pdf-viewer-update-enabled" HTML attribute. Bug: 1164004 Change-Id: Ic88fad7d01266a007005a18d37e4f3d3c39fb04e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642128 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
-
