GitLab

This change causes sites using SSLv3 to show a "mixed content" level warning on
the lock icon and for the section in the connection status to go red.

There's no message added to the connection status because, if we plan on
removing SSLv3 by default in Chrome 40, then we want to merge this to Chrome 39
and thus there's no time to get a translation.

BUG=419870

Review URL: https://codereview.chromium.org/662883002

Cr-Commit-Position: refs/heads/master@{#300346}

Disable direct write if font count in registry is greater than or equal to threshold (currently 1750).

R=scottmg,ananta,cpu,asvitkine
BUG=421305

Review URL: https://codereview.chromium.org/667013003

Cr-Commit-Position: refs/heads/master@{#300345}

This will pave the way for a future CL that completely removes all //content
dependencies from the class.

TBR=ben@google.com
BUG=371476
TEST=No visible impact.

Review URL: https://codereview.chromium.org/658073004

Cr-Commit-Position: refs/heads/master@{#300344}

Also move a class implementation out of feature_channel.h.

BUG=424746

Review URL: https://codereview.chromium.org/661593005

Cr-Commit-Position: refs/heads/master@{#300343}

BUG=425248
TBR=nasko@chromium.org

Review URL: https://codereview.chromium.org/657993004

Cr-Commit-Position: refs/heads/master@{#300342}

Define a new macro S_MODEBITS to represent the
mode bits settable by chmod/fchmod.

Add test to verify that file type cannot be changed
with chmod.

Review URL: https://codereview.chromium.org/671513002

Cr-Commit-Position: refs/heads/master@{#300341}

This fixes keypresses on Logitech K400. There's no key repeat yet.

BUG=412996

Review URL: https://codereview.chromium.org/654073002

Cr-Commit-Position: refs/heads/master@{#300340}

Don't spam the logs on Windows, Mac, or Android when
GetFontRenderParams() is called with a non-empty query;
RenderTextHarfBuzz sends non-empty queries and is being
enabled for more platforms now.

Continue to log an error if a family name is requested on
these platforms, though.

BUG=424971

Review URL: https://codereview.chromium.org/645073004

Cr-Commit-Position: refs/heads/master@{#300339}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/83506e0..c6bd766

TBR=dstockwell@chromium.org,aboxhall@chromium.org

Review URL: https://codereview.chromium.org/665913003

Cr-Commit-Position: refs/heads/master@{#300338}

Handle STAGE_INITIALIZATION_ERROR with a logging message

BUG=420111
TEST=manual

Review URL: https://codereview.chromium.org/656503005

Cr-Commit-Position: refs/heads/master@{#300337}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/33e6466..43b8b36

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/664203002

Cr-Commit-Position: refs/heads/master@{#300336}

Extensions: Split the constants from the extensions_common target into its own extensions_common_constants target.

The extensions constants are used in too many places and very hard to
get rid of. Making it into its own target so it can be included in all
builds, even when extensions are not enabled.

BUG=424746

Review URL: https://codereview.chromium.org/652623003

Cr-Commit-Position: refs/heads/master@{#300335}

Some of the updated files got accidentally stashed and I needed to pop
and recheck that the content was up-to-date.

Review URL: https://codereview.chromium.org/647763004

Cr-Commit-Position: refs/heads/master@{#300334}

Revert of Revert of Drop CreateChildFrame messages when swapping out. (patchset #1 id:1 of https://codereview.chromium.org/663183003/)

Reason for revert:
This revert was supposed to be on a branch but happened on master.

Original issue's description:
> Revert of Drop CreateChildFrame messages when swapping out. (patchset #1 id:1 of https://codereview.chromium.org/649683007/)
>
> Reason for revert:
> It broke compile since this CL relies on https://crrev.com/cce56cd951f6685a0120db63418aa7e6d3df28f2 and it isn't in this branch.
>
> Original issue's description:
> > Drop CreateChildFrame messages when swapping out.
> >
> > There is a race condition in the current state of the code where in cross-process navigation we swap the existing RenderFrameHost with a new RenderFrameHost. If the existing host sends an IPC message to create a new child frame, it arrives on the IO thread, allocates a routing id based of the existing process (p1) and does a PostTask to the UI thread. If there is a CommitPending event either executing on the UI thread or in the task queue before the task posted from the IO thread, it will end up putting the existing RenderFrameHost in swapped out state (or waiting for swapped out). When the task to create a child frame is executed after that, it creates a new RenderFrameHost, but it uses the "current" process (p2), which is different than the process that sent the message (p1). This manifests sometimes as adding duplicate routing ids to RenderProcessHost and is in general really bad bug.
> >
> > BUG=415059, 423691, 381990
> >
> > Review URL: https://codereview.chromium.org/642813007
> >
> > Cr-Commit-Position: refs/heads/master@{#299939}
> > (cherry picked from commit dcdb02fa)
> >
> > Conflicts:
> > 	content/browser/frame_host/navigator_impl_unittest.cc
> >
> > R=creis@chromium.org
> >
> > Committed: https://chromium.googlesource.com/chromium/src/+/a6a21983b1a29ad11d30782c66d95facca65ab55
>
> TBR=creis@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=415059, 423691, 381990
>
> Committed: https://crrev.com/d2c7272b80fe61a11cd2f04f17fb6caf52631010
> Cr-Commit-Position: refs/heads/master@{#300332}

TBR=creis@chromium.org,nasko@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=415059, 423691, 381990

Review URL: https://codereview.chromium.org/667813002

Cr-Commit-Position: refs/heads/master@{#300333}

Revert of Drop CreateChildFrame messages when swapping out. (patchset #1 id:1 of https://codereview.chromium.org/649683007/)

Reason for revert:
It broke compile since this CL relies on https://crrev.com/cce56cd951f6685a0120db63418aa7e6d3df28f2 and it isn't in this branch.

Original issue's description:
> Drop CreateChildFrame messages when swapping out.
>
> There is a race condition in the current state of the code where in cross-process navigation we swap the existing RenderFrameHost with a new RenderFrameHost. If the existing host sends an IPC message to create a new child frame, it arrives on the IO thread, allocates a routing id based of the existing process (p1) and does a PostTask to the UI thread. If there is a CommitPending event either executing on the UI thread or in the task queue before the task posted from the IO thread, it will end up putting the existing RenderFrameHost in swapped out state (or waiting for swapped out). When the task to create a child frame is executed after that, it creates a new RenderFrameHost, but it uses the "current" process (p2), which is different than the process that sent the message (p1). This manifests sometimes as adding duplicate routing ids to RenderProcessHost and is in general really bad bug.
>
> BUG=415059, 423691, 381990
>
> Review URL: https://codereview.chromium.org/642813007
>
> Cr-Commit-Position: refs/heads/master@{#299939}
> (cherry picked from commit dcdb02fa)
>
> Conflicts:
> 	content/browser/frame_host/navigator_impl_unittest.cc
>
> R=creis@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/a6a21983b1a29ad11d30782c66d95facca65ab55

TBR=creis@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=415059, 423691, 381990

Review URL: https://codereview.chromium.org/663183003

Cr-Commit-Position: refs/heads/master@{#300332}

We don't actually use the embedded test server and we don't need most
of what the file path conversion utilities provide. We only need to
support very simple URLs for loading off of file paths and we do not
need to support windows at all for mojo_shell.

Review URL: https://codereview.chromium.org/640403002

Cr-Commit-Position: refs/heads/master@{#300331}

BUG=424755
R=oshima@chromium.org
TEST=manually && athena_unittests

Review URL: https://codereview.chromium.org/668443002

Cr-Commit-Position: refs/heads/master@{#300330}

The default URLFileRequestJob::IsRedirectResponse implementation is incorrect
for URLRequestExtensionJob (chrome-extension:-scheme) and ExtensionResourcesJob (chrome-extension-resource:-scheme).

BUG=388852,424961

Review URL: https://codereview.chromium.org/650453003

Cr-Commit-Position: refs/heads/master@{#300329}

These tests currently crash.

R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/637953009

Cr-Commit-Position: refs/heads/master@{#300328}

BUG=399090

Review URL: https://codereview.chromium.org/661653002

Cr-Commit-Position: refs/heads/master@{#300327}

Note: This change is a prerequisite for an upcoming change that will add
extensive interactive UI testing around Flash fullscreen, including the
Fullscreen-Within-Tab UI.

For all interactive_ui_tests, the UI widget being referenced by
VIEW_ID_TAB_CONTAINER was wrong whenever Flash fullscreen mode was
engaged.  This change tags the correct NSView with the identifier, and
gives it some simple focus-passing behavior, similar to
ui::views::WebView, to ensure that tests checking focus and/or
simulating a click on the tab container get the desired behavior.

Because the code changes to TabContentsContainerView are pretty much the
same, this change also addresses bug 421728, which makes clicking in the
"gray area" during Fullscreen-Within-Tab mode a request to give the tab
contents the focus.

BUG=403641,421728

Review URL: https://codereview.chromium.org/642143004

Cr-Commit-Position: refs/heads/master@{#300326}

NOTRY=true

Review URL: https://codereview.chromium.org/663823004

Cr-Commit-Position: refs/heads/master@{#300325}

In r298580, I added a bug where jumps to the very beginning of the data (bit
offset zero) would be rejected. This was found by fuzzing.

BUG=none

Review URL: https://codereview.chromium.org/663903002

Cr-Commit-Position: refs/heads/master@{#300324}

When the number of font files exceeds 1750, we fallback to this list.
Include Verdana, Georgia, and Trebuchet MS in this list until font
loading is properly fixed.

R=shrikant@chromium.org,ananta@chromium.org
BUG=421305

Review URL: https://codereview.chromium.org/668743002

Cr-Commit-Position: refs/heads/master@{#300323}

This is a reland of https://codereview.chromium.org/659533002/

Previous CL broke telemetry unittests and perf unittests because it
didn't handle properly shell commands which may end with a newline
character when check_rc is not None.

This revised patch strips any whitespace at the end of shell commands
to prevent this.

BUG=267773

Review URL: https://codereview.chromium.org/669573003

Cr-Commit-Position: refs/heads/master@{#300322}

I stumbled on this while working on the dff change.  It looks
like the only place this function is used is in the test.

I removed the test as well, since its only purpose was to check
that calling leak would indeed leak.

Review URL: https://codereview.chromium.org/652583002

Cr-Commit-Position: refs/heads/master@{#300321}

At that occasion, make it owned by rvargas@.

BUG=none

Review URL: https://codereview.chromium.org/662273003

Cr-Commit-Position: refs/heads/master@{#300320}

We will be using that function.

BUG=424244

Review URL: https://codereview.chromium.org/669753002

Cr-Commit-Position: refs/heads/master@{#300319}

changes to disk every 500ms instead of 5secs. We are hoping if QUIC is
used as an alternate protocol, we will persist that information to disk
quicker. Hopefully, this would improve the QUIC winning the alternate
protocol race.

R=rch@chromium.org

Review URL: https://codereview.chromium.org/667473003

Cr-Commit-Position: refs/heads/master@{#300318}

The old way involved start-up code reading a value and setting a global
in template_url_prepopulate_data. Since the value can be computed
on-demand from device-information, just fetch it as needed instead.

BUG=169106
TBR=thakis

Review URL: https://codereview.chromium.org/628263004

Cr-Commit-Position: refs/heads/master@{#300317}

When it retried uploads using Channels, it would restart the upload with
data from the middle of the file, since Channels can't be rewound.  It
now just fails those requests instead.

Also, it was impossible to set the method for uploads - the default
value (POST) would overwrite any method set by the embedder.

Adds a new set of upload tests using the embedded test server, as
uploads were basically untested before.  Chunked uploads are still not
being tested, as the test server doesn't support them yet.

BUG=424712

Review URL: https://codereview.chromium.org/640593004

Cr-Commit-Position: refs/heads/master@{#300316}

Review URL: https://codereview.chromium.org/660493002

Cr-Commit-Position: refs/heads/master@{#300315}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/7541f2d..83506e0

TBR=dstockwell@chromium.org,aboxhall@chromium.org

Review URL: https://codereview.chromium.org/667003002

Cr-Commit-Position: refs/heads/master@{#300314}

It was previously failing with EISDIR. This is because
utime() internally acquires the node as O_WRONLY in
order to call the Futimens method.  This was failing
because the check for opening a directory for write
was done in Open() rather than CanOpen().

Review URL: https://codereview.chromium.org/660353003

Cr-Commit-Position: refs/heads/master@{#300313}

In Yosemite, the owner of a nib file is retain/autoreleased during the
initialization of the nib. I wrapped the constructor of the
BookmarkBarController in an @autoreleasepool block to allow the test to control
the destruction timing of the BookmarkBarController.

BUG=390276

Review URL: https://codereview.chromium.org/660063004

Cr-Commit-Position: refs/heads/master@{#300312}

This might-maybe-hope-not crash, and so has debugging statements.

BUG=407376
TEST=no crashing, we hope
TBR=rsesek@chromium.org

Review URL: https://codereview.chromium.org/669613005

Cr-Commit-Position: refs/heads/master@{#300311}

Recently class was refactored https://codereview.chromium.org/651253002 ,
and there was an unexpected functional change.

BUG=424816

Review URL: https://codereview.chromium.org/669443002

Cr-Commit-Position: refs/heads/master@{#300310}

This makes some sense, since as we potentially output more and more files
(instead of a single results.html), we want to store them all in the same
location.

SHERIFFS: If error "This flag is deprecated. Please use --output-dir instead."
arises, this patch can be safely reverted.

Original discussion at https://codereview.chromium.org/616063004/

BUG=

Review URL: https://codereview.chromium.org/651383002

Cr-Commit-Position: refs/heads/master@{#300309}

Servers do not reliably send close_notify. This regressed in
https://codereview.chromium.org/367963007 which had a side effect of making us
sensitive to this.

BUG=422246

Review URL: https://codereview.chromium.org/655813003

Cr-Commit-Position: refs/heads/master@{#300308}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/a71aee6..33e6466

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/667013002

Cr-Commit-Position: refs/heads/master@{#300307}