- 19 Mar, 2018 40 commits
-
-
edchin authored
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I808e52f47db5dbc9ddc609b123be1e10dabde996 Reviewed-on: https://chromium-review.googlesource.com/967889Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#544083}
-
https://skia.googlesource.com/skia.git/+log/8d2ba44c9cba..c9a642edf2d1 $ git log 8d2ba44c9..c9a642edf --date=short --no-merges --format='%ad %ae %s' 2018-03-19 bsalomon New read pixels implementation that is simpler but does all conversions on CPU. 2018-03-19 reed handle divide by zero in paint 2018-03-19 herb Remove a ctor from SkAutoGlyphCache; removal continues. 2018-03-19 egdaniel Make sure we set stencil layout when doing copy as draw 2018-03-19 robertphillips Fix GrTextureStripAtlasManager cleanup order bug 2018-03-16 kdonev Support x86 build with VS 2015 2018-03-14 kjlubick [skpbench] Use android's perf settings for Pixel C 2018-03-19 kjlubick Avoid bad alloc in SkReadBuffer 2018-03-19 angle-skia-autoroll Roll skia/third_party/externals/angle2/ dfebe9b2d..3761dc7bf (1 commit) 2018-03-19 caryclark fix op fuzz Created with: roll-dep src/third_party/skia BUG=chromium:820703 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: I6e098e7b7056791ccf28d22a30e854bc24312c1e Reviewed-on: https://chromium-review.googlesource.com/969117 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544082}
-
Qiang Xu authored
Bug: 818364 Test: manual test Change-Id: I2ca24231dd40478e3ad269d04bde02b613073fc3 Reviewed-on: https://chromium-review.googlesource.com/966490Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Qiang Xu <warx@google.com> Cr-Commit-Position: refs/heads/master@{#544081}
-
erikchen authored
This CL is a refactor and has no intended behavior change. * Rename REFRESH_TYPE_MEMORY_DETAILS to REFRESH_TYPE_SWAPPED_MEM. * Remove MemoryUsageStats and replace with int64_t. Change-Id: I75276508cbdbc67cb6b2d6642e0285733ebcca01 Reviewed-on: https://chromium-review.googlesource.com/965104 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Nick Carter <nick@chromium.org> Cr-Commit-Position: refs/heads/master@{#544080}
-
Emily Hanley authored
Bug: 779634 Change-Id: I3ee375b4118b29a1080f5c0859d617e4c4bb624a Reviewed-on: https://chromium-review.googlesource.com/959053Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#544079}
-
edchin authored
This CL pulls a non-trivial amount of code out of TabGridViewController and encapsulates it in a separate UIView subclass. This CL also changes the layout based on orientation for the empty state. Bug: 804557 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ic1f03445b014a331bdf383e999b522fcbe1b3143 Reviewed-on: https://chromium-review.googlesource.com/967731Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#544078}
-
Daniel Bratell authored
Both the new and old code use an identical ClientImpl test class. In jumbo builds those end up in the same translation unit and it won't compile. This patch moves the class to a shared file WorkerFetchTestHelper.h Bug: 680046 Change-Id: Iabe58f2f2c93e4d77fb36c8c454952af994d302c Reviewed-on: https://chromium-review.googlesource.com/968363 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#544077}
-
Matt Mueller authored
Unused since f0747fdc. Change-Id: Ibe0d24c416107f754bf3e835fd1a63000a37a42d Reviewed-on: https://chromium-review.googlesource.com/964983Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#544076}
-
Kai Uwe Broulik authored
R=mukai@chromium.org, thomasanderson@chromium.org Change-Id: Ibacf61f28fde4e6e1e0b52a65c3412118eb96e49 Reviewed-on: https://chromium-review.googlesource.com/955323 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#544075}
-
John Budorick authored
This reverts commit 3ee20833. Reason for revert: crbug.com/323342. This only partially removed harfbuzz-ng/src, resulting in weird overlays of files from src.git and harbuzz.git Original change's description: > Manage HarfBuzz dependency using DEPS mechanism > > Remove src/ from Chromium repo and retrieve HarfBuzz sources from the > mirror at [1]. > > Cherry picks can be done by HarfBuzz OWNERS by pushing new branches to > refs/heads/chromium/ of [1]. > > This was tested and confirmed working in:: > https://chromium-review.googlesource.com/c/chromium/src/+/937502 > > [1] https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz/ > > Bug: 814305 > Change-Id: I8760f734839012b1c9c9b9b07f11fa71000e5531 > Reviewed-on: https://chromium-review.googlesource.com/928761 > Reviewed-by: Ben Wagner <bungeman@chromium.org> > Reviewed-by: Behdad Esfahbod <behdad@chromium.org> > Reviewed-by: Emil A Eklund <eae@chromium.org> > Commit-Queue: Dominik Röttsches <drott@chromium.org> > Cr-Commit-Position: refs/heads/master@{#544043} TBR=bungeman@chromium.org,eae@chromium.org,drott@chromium.org,behdad@chromium.org Change-Id: I1fb32862c33154ac91d6475e8c1b6416fbc330ff No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 814305 Reviewed-on: https://chromium-review.googlesource.com/969185Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#544074}
-
Karan Bhatia authored
BUG=812296 TBR=sergeyu@chromium.org Change-Id: I7992566c41b6ab650738d190a6980c8640b29487 Reviewed-on: https://chromium-review.googlesource.com/969096 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#544073}
-
jonross authored
Currently RenderFrameMetadata is communicated from the renderer to the browser. The messages are processed right away, even if Viz may have not yet completed the processing of the frame associated to the data. This is racy. This change adds a FrameToken to all of the RenderFrameMetadata messages. The browser side then uses FrameTokenMessageQueue to synchronize these messages. They will now be processed once Viz has completed processing the frame and has notified the browser. TEST=existing viz_content_browsertests TBR=piman@chromium.org Bug: 775103 Change-Id: I52e6d023be5591946c589400374236a2a8e979d6 Reviewed-on: https://chromium-review.googlesource.com/962711Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#544072}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c71ecd04. With Chromium commits locally applied on WPT: 78822c6d "Fix sizing of orthogonal elements with percentage margins" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/14189 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: ksakamoto@chromium.org: external/wpt/resource-timing TBR=kereliuk No-Export: true Change-Id: I24f2885853158fa3717e0e572c2a1613169f94d2 Reviewed-on: https://chromium-review.googlesource.com/969021 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#544071}
-
https://chromium.googlesource.com/catapult.git/+log/fa0f0f2dd7e9..d0c8b3b7d24c $ git log fa0f0f2dd..d0c8b3b7d --date=short --no-merges --format='%ad %ae %s' 2018-03-17 malets Properly handle benchmarks disabled with no named reason. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I4f2b1a7a567ba0b75ecec8d59085eb75f25627ac Reviewed-on: https://chromium-review.googlesource.com/968667 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544070}
-
Sorin Jianu authored
Since the UpdateContext is now a ref counted type, using the iterator adds an unnecessary level of obfuscation. Also, to implement task cancellation, a mechanism is needed to relate the update task and its context, and the iterator is not appropriate for that. TBR: waffles Bug: 822990 Change-Id: I8db51b24e4ef0f9b30f434820fa6d3bd1b066e98 Reviewed-on: https://chromium-review.googlesource.com/966966 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#544069}
-
Julia Tuttle authored
Change-Id: I8cfdb966b329d62aed531e0d22be98424e1928c4 Reviewed-on: https://chromium-review.googlesource.com/957165 Commit-Queue: Julia Tuttle <juliatuttle@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#544068}
-
https://webrtc.googlesource.com/src.git/+log/9fa35e528528..d2c8332e2b03 $ git log 9fa35e528..d2c8332e2 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib212b904fc2c7a61b831fddb0a713b07f3f7e01f Reviewed-on: https://chromium-review.googlesource.com/968710 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544067}
-
jonross authored
The usage of RenderFrameSubmissionObserver in TouchActionBrowserTest is racy. This change updates the ownership of the observer to avoid that. Bug: 760181 Change-Id: I23eaab201d478a6a8948893f10158e8c9c4c4d44 Reviewed-on: https://chromium-review.googlesource.com/964241Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#544066}
-
Stephen McGruer authored
This CL aligns Chromium with the URL spec, such that we consider '#' to mark the end of the content and the start of the fragment section only. GURL::GetContent was updated to reflect this, with a special case for javascript URLs specifically (as their spec mentions including '#' in the URL content). Bug: 123004 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I49c6f4d739a2dd42eecc9947f8e75071b84e9be7 TBR: boliu@chromium.org, pfeldman@chromium.org, thakis@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I49c6f4d739a2dd42eecc9947f8e75071b84e9be7 Reviewed-on: https://chromium-review.googlesource.com/738395 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#544065}
-
Jan Krcal authored
This reverts commit 2464913f. Reason for revert: crasher due to semantic changes between nano and lite and lacking unit-tests (crbug.com/822845) Original change's description: > [protobuf] Convert serialized_invalidation from nano to lite > > Bug: 782237 > Change-Id: I030322a93c71eec70fc4a53a4cb21458c63678ee > Reviewed-on: https://chromium-review.googlesource.com/856796 > Reviewed-by: Tommy Nyquist <nyquist@chromium.org> > Commit-Queue: Jan Krcal <jkrcal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#543322} TBR=nyquist@chromium.org,jkrcal@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 782237 Change-Id: Id448b779470070a5e0e2f55708f1a1a194064d02 Reviewed-on: https://chromium-review.googlesource.com/968961Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#544064}
-
Scott Violet authored
This only works for Ozone and is necessary for both UserActivityDetector and remoting. Long term we need to rewrite both of these to use something else, but for now this accomplishes what they need. BUG=822577 TEST=covered by tests Change-Id: I432cbdcce17bb199bf8bb0f00ec51de81d3c71f0 Reviewed-on: https://chromium-review.googlesource.com/967447Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#544063}
-
https://chromium.googlesource.com/angle/angle.git/+log/dfebe9b2d5d9..3761dc7bf683 $ git log dfebe9b2d..3761dc7bf --date=short --no-merges --format='%ad %ae %s' 2018-03-19 jmadill Fix infra.cq to point to new Linux configs. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I4ea3d545c27d0f0c81d50f9da9b548d04d1eb326 Reviewed-on: https://chromium-review.googlesource.com/968543Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544062}
-
Ian Vollick authored
Previously, we would reposition using the backplane, but with this change, we introduce a frame around the content window that can be dragged. This change also fixes the positioning of the fullscreen toast and the close button so that they adapt to a resized window. It also removes some now-useless code for setting the center position of a gradient quad and fixes a bug in the "bounds contain children" code where we weren't updating positioning correctly for children with asymmetric padding. Bug: 799270 Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ia6d9759b3e8b6fc80bc0d1ae2f0c739cc9cd0f7f Reviewed-on: https://chromium-review.googlesource.com/967350 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#544061}
-
Owen Min authored
This is a new implmentation of CloudPolicyManager. It will initialize the policy and always try to load store immediately if possible. Bug: 812641 Change-Id: I0c23fdeda4093123f7859682cd43669fefe37cfd Reviewed-on: https://chromium-review.googlesource.com/957817 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#544060}
-
Andrew Grieve authored
Reduces main dex by 4500 methods TBR=agrieve # Trivial change to DecoderService Bug: 820570 Change-Id: Ifeeb0cc768dd762c58c6a11061a17e73e12e38a1 Reviewed-on: https://chromium-review.googlesource.com/966877Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#544059}
-
Rouslan Solomakhin authored
Before this patch, Chrome would crawl for installable payment apps even when the merchant supported "basic-card" payments. This may slow down user experience unnecessarily and caused browser tests to issue network requests. This patch changes Chrome to crawl for installable payment apps only when the merchant does not support "basic-card" payments. After this patch, if merchant supports "basic-card", Chrome does not crawl for installable payment apps, so the vast majority of browser tests don't issue network requests anymore. Bug: 814740 Change-Id: I79eb156a76ef4f23b953bf399c4f616eee8ac7ad Reviewed-on: https://chromium-review.googlesource.com/963163 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#544058}
-
Jamie Madill authored
The whole set of tests seems to be flaky on Windows. Bug: 822733 Tbr: kbr@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ia99bdec79e9a3c363c10d469b134e5e076c07218 Reviewed-on: https://chromium-review.googlesource.com/968761Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#544057}
-
Dan Elphick authored
This space will be added to V8 in: https://chromium-review.googlesource.com/c/v8/v8/+/925703 TBR=ssid@chromium.org Bug: v8:7464 Change-Id: I8be023d38e717e9a55f811a4856407a09c25e403 Reviewed-on: https://chromium-review.googlesource.com/927621Reviewed-by:
Dan Elphick <delphick@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#544056}
-
Sandra Sun authored
Currently, we parse the two values in scroll-snap-align for x and y. However, according to the spec, https://drafts.csswg.org/css-scroll-snap-1/#scroll-snap-align, the two values specify the alignment in the inline axis and block axis. This patch renames the two values and handles the vertical writing mode for inline and block alignments. Bug: 821645 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I78acff0df4698b3f9c0f7443e61e3bad75379b14 Reviewed-on: https://chromium-review.googlesource.com/967890 Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#544055}
-
David Tseng authored
This reverts commit 2f8d70bb. Reason for revert: breaks text input in ARC++ Bug: 823233 Original change's description: > Reland: Better support crosh > > Rich editables should be skipped entirely (and not fall through to output). > > Original change: > - value change events often fire on richly editable text fields. We do not really use this in the state machine for rich text, so ignore it. It often causes poor state transitions e.g. speaking "deleted" in crosh when typing. > - use the AutomationRichEditableText class in more cases. This acknowledges the usage in the wild where a page author can set role textbox on any node. When they do this it is assumed they manage a DOM selection unless they set the role on either an input or textarea where the browser does this on their behalf. > > TBR=dmazzoni@chromium.org, dtseng@chromium.org > > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: If555f157a7eeafe836929e9433891b2e7ae181df > Reviewed-on: https://chromium-review.googlesource.com/953980 > Commit-Queue: David Tseng <dtseng@chromium.org> > Reviewed-by: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#541684} TBR=dmazzoni@chromium.org,dtseng@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ic585ad279e461b2b7144904180e3b1cb140e1588 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/968741Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#544054}
-
Eero Häkkinen authored
This also improves const correctness of FFTFrame. Bug: 822721 Change-Id: I49668b37b0ecca278ce35af293eee6e324d88f4c Reviewed-on: https://chromium-review.googlesource.com/962223Reviewed-by:
Raymond Toy <rtoy@chromium.org> Commit-Queue: Eero Häkkinen <eero.hakkinen@intel.com> Cr-Commit-Position: refs/heads/master@{#544053}
-
Stephen Chenney authored
TBR=eae@chromium.org Change-Id: Ic07dfd6318001b512e2ecf2d5ff2906234a35335 Reviewed-on: https://chromium-review.googlesource.com/968712Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#544052}
-
Anthony Berent authored
Merge the screenshot descriptions produced by the instrumentation tests into a single description. If the tests are run locally print a link to this description, if the are run remotely add a link to the description to the json file produced by test_results_presentation. Revert was https://chromium-review.googlesource.com/c/chromium/src/+/964931. The revert was because it appears that, on Android L and M, the instrumentation tests are not allowed to create, from Java, files on /data/local/tmp. This seems to be caused by an SELinux restriction. TBR=bauerb@chromium.org Bug: NONE Change-Id: Ic9352289a6eea12e95f9126d038c0fbaab295988 Reviewed-on: https://chromium-review.googlesource.com/968527Reviewed-by:
Anthony Berent <aberent@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Anthony Berent <aberent@chromium.org> Cr-Commit-Position: refs/heads/master@{#544051}
-
https://skia.googlesource.com/skia.git/+log/fe0253f8bb64..8d2ba44c9cba $ git log fe0253f8b..8d2ba44c9 --date=short --no-merges --format='%ad %ae %s' 2018-03-16 ethannicholas SPIR-V output now always includes DescriptorSet for uniforms 2018-03-19 caryclark detect deprecated methods 2018-03-19 caryclark fix fuzz 2018-03-19 borenet [recipes] Band-aid on top of a hack: pin depot_tools Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: I2ba9613f128c75c33e4fc94b1d81eff065dd4b5f Reviewed-on: https://chromium-review.googlesource.com/968701 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544050}
-
Hiroki Nakagawa authored
For consistency with ModuleScript, this CL renames... - WillEvaluateWorkerScript to WillEvaluateClassicScript, - DidEvaluateWorkerScript to DidEvaluateClassicScript, and - WillEvaluateImportedScript to WillEvaluateImportedClassicScript. Bug: 680046 Change-Id: I9120f1ed9d3923d901f32801d551a61bafba04ee Reviewed-on: https://chromium-review.googlesource.com/967627 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#544049}
-
Reza.Zakerinasab authored
In a few locations inside canvas code we are passing nullptr color space to SkImage::readPixels() for two purposes: - Avoid color conversion - Enforce premul / unpremul to happen in linear space This CL removes these calls and passes the correct color space. To avoid color conversion, we should always pass the color space of the source image to readPixels(). Bug: 811318 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I6be1791d2d1ce82c7c444c140a4f43e572096150 Reviewed-on: https://chromium-review.googlesource.com/946678Reviewed-by:
Justin Novosad <junov@chromium.org> Reviewed-by:
Olivia Lai <xlai@chromium.org> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#544048}
-
Manuel Rego Casasnovas authored
LayoutBox::FillAvailableMeasure() was not considering the case of orthogonal elements when computing the margins. The margins ended up being properly calculated but the size of the orthogonal elements was wrong, as they considered to have more or less space than the available one. The method is modified in order to use the containing block inline size in order to resolve the percentages: https://www.w3.org/TR/css-writing-modes-3/#dimension-mapping BUG=808758 TEST=external/wpt/css/css-writing-modes/sizing-orthogonal-percentage-margin-00*.html Change-Id: Ib8c81dcd14589b3fefe806de3f8f75c000b1cac9 Reviewed-on: https://chromium-review.googlesource.com/968522 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#544047}
-
sczs authored
- Moves the New Mediator and Coordinator files to this new directory. - Also renames RecentTabsTableCoordinator to RecentTabsCoordinator. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7080f890e6232b796db1a3d548ee0f0624b17ec9 Reviewed-on: https://chromium-review.googlesource.com/963846Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#544046}
-
Harald Alvestrand authored
Bug: 793766 Change-Id: Ie82fc929ae81c3894f10fa0efa0867c21258f392 Reviewed-on: https://chromium-review.googlesource.com/966842Reviewed-by:
Jungshik Shin <jshin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#544045}
-
Raphael Kubo da Costa authored
GCC is stricter than clang when it comes to class members' names and how they can change the meaning of a previously existing symbol with the same name: ../../third_party/WebKit/Source/core/layout/ScrollbarsTest.cpp:45:3: error: declaration of ‘blink::EventHandler& blink::{anonymous}::ScrollbarsTest::EventHandler()’ [-fpermissive] } ^ In file included from ../../third_party/WebKit/Source/core/layout/ScrollbarsTest.cpp:10:0: ../../third_party/WebKit/Source/core/input/EventHandler.h:79:19: error: changes meaning of ‘EventHandler’ from ‘class blink::EventHandler’ [-fpermissive] class CORE_EXPORT EventHandler final ^~~~~~~~~~~~ https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84709 contains a longer explanation, but essentially having an |EventHandler()| method can change the meaning of references to |EventHandler| in the code depending on where it is declared, which contradicts the C++ standard. Fix it by renaming the method to |GetEventHandler()|. Change-Id: Ie2fbab48e3e1f68a80f07d95ccf07bd048df1451 Reviewed-on: https://chromium-review.googlesource.com/968512 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#544044}
-