GitLab

The crash reason is |geolocation| got std::move() first before it calls
the QueryNextPosition(). It is better to save the InterfacePtr of geolocation
and geolocation_context as class member.

BUG=791445

Change-Id: I694853a0bc37f53d879419e7b0ab2d8943e98509
Reviewed-on: https://chromium-review.googlesource.com/807759
Commit-Queue: Ke He <ke.he@intel.com>
Reviewed-by: Colin Blundell (OOO Dec 7) <blundell@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522345}

Missed a case for part 1 (https://chromium-review.googlesource.com/c/chromium/src/+/797681).
After both snap, press F5 to return to one snap + overview. Snapped
windows header is not shown. This is because on entering overview mode
or switching from split view states happen when overview is starting,
not when it is entered (IsSelecting() returns false in OnOverviewModeStarting),
so remove that check.

Test: manual, ash_unittests CustomFrameViewAshTest.HeaderVisibility
Bug: 789378
Change-Id: I1f1589b359983dcc6a2db65be62cd185121411c0
Reviewed-on: https://chromium-review.googlesource.com/809757Reviewed-by: Tao Wu <wutao@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522344}

This change is for files in the path
//third_party/WebKit/Source/core/fullscreen/.

Added the include for base/macros.h where needed and moved the macro to the
end of the class as per the code guidelines enforced by lint.

This CL introduces no logic changes.

Bug: 565932
Change-Id: Ie21a0b3893a158189f8ae9f7d3f628152c64bbe3
Reviewed-on: https://chromium-review.googlesource.com/813395Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Commit-Queue: Eve Martin-Jones <evem@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522343}

CastMediaRouteProvider and RemotingMediaRouteProvider have very similar
code that can be generalized into a base class.

This CL extracts the common logic behind observing media sinks and adds
it to the new BaseMediaRouteProvider.

Bug: 790766
Change-Id: I92a2fec95dc5cf32f132e295dc8e95b0604217e4
Reviewed-on: https://chromium-review.googlesource.com/784121
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Zhiqiang Zhang <zqzhang@chromium.org>
Reviewed-by: Anton Vayvod <avayvod@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522342}

mus should no longer host viz for browser_tests --mus. So it should not have
--mus=viz flag set. With this change, the browser_tests no longer need the
filter file. So remove it (from main and fyi waterfalls).

BUG=786453, 785536

Change-Id: Ia9ecfdc8f667bb07cf53debbc98f960938f6d452
Reviewed-on: https://chromium-review.googlesource.com/812169Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522341}

Several places in the code I'd overlooked were referring to "paletteContainer", so I felt it was safest to just put it back the way it was.

Bug: 792348, 792342
Change-Id: I144752c1436500d4167190060f675b0115ee8a14
Reviewed-on: https://chromium-review.googlesource.com/812584Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522340}

This CL converts the chromium waterfall config to be
auto-generated using the new generate_buildbot_json framework.

R=kbr@chromium.org, jbudorick@chromium.org
BUG=662541

Change-Id: I56c403369b4e0811fe604930d8da97048d434eda
Reviewed-on: https://chromium-review.googlesource.com/809958Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522339}

Help measure the overhead of retrieving apps during navigations.

Bug: 785661
Change-Id: I8e31ba9373744e6d68942e96f207d3eac1bb67f0
Reviewed-on: https://chromium-review.googlesource.com/809920
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522338}

https://chromium.googlesource.com/catapult.git/+log/82cfea0e3cd5..db654910e39e

$ git log 82cfea0e3..db654910e --date=short --no-merges --format='%ad %ae %s'
2017-11-30 spang Fix rendering of full height UI features
2017-12-06 simonhatch Dashboard - Copy histogram level diagnostics in /add_histograms

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I3ebea557e96eba03b19f395099437efd921c0877
Reviewed-on: https://chromium-review.googlesource.com/813236
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522337}

Bug: 792774
Change-Id: I2507ec439d43880de311edc9bc8131bc774edc3d
Reviewed-on: https://chromium-review.googlesource.com/807684
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522336}

This CL adds support for extra post processing after package_resources
is complete, including modifying the R.java files that are used.

Bug: 762130
Change-Id: I25fdc9a4bd9f2a13620036cb6988dced8d2602ea
Reviewed-on: https://chromium-review.googlesource.com/761676
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522335}

x86 and x64 have different default alignment for 'long long' and
'double'. The browser and renderer processes of Android webview
run in 64-bit and 32-bit modes respectively. So we need to
deliberately arrange buffer fields to avoid misalignment.

BUG=781095

Change-Id: Icb6bade57d6d977468fe9c83a77f1e56d8875f90
Reviewed-on: https://chromium-review.googlesource.com/752428
Commit-Queue: Jie A Chen <jie.a.chen@intel.com>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522334}

Add a test for the timeout in the authenticator impl.
Necessitates refactoring //device/u2f test code into a
test_support target to set up a service_manager::Connector.

Bug: 785950, 785950
Change-Id: Idfd132a54909ceb8e7104e278434227ecac2c34c
Reviewed-on: https://chromium-review.googlesource.com/775912
Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522333}

TBR=amineer@chromium.org

Change-Id: Ie61f3176458a5d4fd0c9daf7534ef3a0a9fc2c31
Reviewed-on: https://chromium-review.googlesource.com/813376Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522332}

This change is for files in the path
//third_party/WebKit/Source/core/intersection_observer/.

Added the include for base/macros.h where needed and moved the macro to the
end of the class as per the code guidelines enforced by lint.

This CL introduces no logic changes.

Bug: 565932
Change-Id: I2bb5d2856d322a761ee810b0e573a0880c0a2b25
Reviewed-on: https://chromium-review.googlesource.com/813354Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Commit-Queue: Eve Martin-Jones <evem@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522331}

Not necessary since spellcheck was componentized.

Bug: 791632
Change-Id: I442a50cc15d1fc63714f65a2abbf62b8b254938c
Reviewed-on: https://chromium-review.googlesource.com/808984Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522330}

For ResourceLoadScheduler experiment, we plan to add more aggressively
targeted variants of PageLoad.Clients.MultiTabLoading.* metrics that
will only be logged if there are more than X loading tabs.

This will give us the distribution of number of loading tabs, and will
help us determine the threshold of the targeted metrics.

Bug: 792759
Change-Id: I8aefd59f52cefd4c1e449795cfdace4fc44fdf98
Reviewed-on: https://chromium-review.googlesource.com/807866
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522329}

https://chromium.googlesource.com/angle/angle.git/+log/43fd0d44d2a6..030017a4855c

$ git log 43fd0d44d..030017a48 --date=short --no-merges --format='%ad %ae %s'
2017-12-06 kainino Mark StaticType related functions as constexpr

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=geofflang@chromium.org

Change-Id: I6c652e1bfd589baf3fa99824cf976994e43e0a8b
Reviewed-on: https://chromium-review.googlesource.com/813176Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522328}

Some observers can have code that computes policy in an expensive way.

Bug: 792524
Change-Id: I4787f295e946efe889528a0a7df19421791856f4
Reviewed-on: https://chromium-review.googlesource.com/811367
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522327}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/ee13fe4b..5ce45836

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: Icd31f3446c5ddde57f7719bc73bb22e13028372b
Reviewed-on: https://chromium-review.googlesource.com/812215Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522326}

https://skia.googlesource.com/skia.git/+log/409506c4c978..5031e5f8b77f

$ git log 409506c4c..5031e5f8b --date=short --no-merges --format='%ad %ae %s'
2017-12-07 angle-deps-roller Roll skia/third_party/externals/angle2/ 43fd0d44d..030017a48 (1 commit)

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=rmistry@chromium.org

Change-Id: I51ca44960d6bf5517cc1e6828bae8751410031f5
Reviewed-on: https://chromium-review.googlesource.com/813194Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522325}

Something that significant should trigger compiles and tests.

Bug: 792130
Change-Id: Ia6c467f97e54ac4b8e8b6c6bc8ab00ff4a9acd65
Reviewed-on: https://chromium-review.googlesource.com/812503Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Benjamin Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522324}

This CL deletes viz::FrameSinkManagerClient. FrameSinkManagerImpl has a
pointer to each CompositorFrameSinkSupport directly now since this is
needed anyways. The FrameSinkManagerImpl::clients_ map is removed as a
result.

SinkAndSupport will always contain a CompositorFrameSinkSupport* while
the CompositorFrameSinkSupport object exists. SinkAndSupport::sink will
be non-null when FrameSinkManagerImpl owns the compositor frame sink.

CompositorFrameSinkSupport::Init()/Create() are also no longer needed
since SetBeginFrameSource() is no longer virtual. Remove Init() and make
the constructor public. Create() is left since it's widely used for now
but is marked deprecated.

Also remove some old/wrong forward definitions and fix some style guide
violations.

Bug: 792192
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I14f9662c9db485ce18edf1d358493648997d3648
Reviewed-on: https://chromium-review.googlesource.com/810866Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522323}

Anonymous IO surfaces that are only used on the gpu service as render
targets don't need to be cleared on initialization. vmiura@ found that
this quadruples the cost of binding the io surface and that this cost is
deferred to the flush.

R=piman
BUG=781586

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: If7d0425a57fec4772f05daaf04dee9aaee0c730f
Reviewed-on: https://chromium-review.googlesource.com/804597
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522322}

https://webrtc.googlesource.com/src.git/+log/cc65bd018d54..40f0b37d3b9a

$ git log cc65bd018..40f0b37d3 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG=None


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: If518287f5bad040339c3f43276f92653d4ed6d6c
Reviewed-on: https://chromium-review.googlesource.com/812981Reviewed-by: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522321}

Moved to CastBrowserMainParts, per the bug.

Bug: internal b/27811461
Test: none
Change-Id: Ic3fd8f7ed51473e8a61caff62c5caa762af03b84
Reviewed-on: https://chromium-review.googlesource.com/811286Reviewed-by: Sergey Volk <servolk@chromium.org>
Commit-Queue: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522320}

Currently https scheme will not be highlighted if toolbar uses brand
color. However, security icon does not apply the same rule which makes
them inconsistent when there is a brand color. This CL updates the
security icon to use the same rule for highlight as https scheme.

Bug: 646676
Change-Id: I2d974eaf6c6f9ca36e39a78c2a6a43c6a8e07489
Reviewed-on: https://chromium-review.googlesource.com/807327Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Lei Tian <ltian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522319}

These were added in r522197 (from r522122) and are failing.

Bug: 777879
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ia969cea09329d027b88d6eacbd3c50f322bbe52e
NOTRY: true
TBR: kinuko
Reviewed-on: https://chromium-review.googlesource.com/812586
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522318}

This change puts a prompt string into the omnibox whenever the field is
empty.  Once a character is entered, or when the field later becomes
empty, the hint is shown.

BUG=
R=bshe
TBR=cpu@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ib05f091fb339a4c06d83a0502e1d0d1b51b0d277
Reviewed-on: https://chromium-review.googlesource.com/812208Reviewed-by: Biao She <bshe@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522317}

TBR=olivierrobin@chromium.org,jwd@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I82ddd62efc5a9911b7454359c1b39eb118e40e84
Reviewed-on: https://chromium-review.googlesource.com/807641Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: François Degros <fdegros@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522316}

Holding a weak reference to activities is the preferred approach
in a lot of client code, so making this support null seems OK
to me.  I think it would be fine to update each client as well...
don't have a strong preference.

The gotcha (which I wasn't aware of) is that ConcurrentHashMap
does not handle null keys/calls of get(<key>).

BUG=792377

Change-Id: I34549aecf68c04f6140bbc4eaaa3405409347cba
Reviewed-on: https://chromium-review.googlesource.com/811431Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522315}

crrev.com/517091 switched the backup settings sync path from ArcIntentHelper
to a new special apk. This CL cleans up the legacy ArcIntentHelper path now.

BUG=783567
TEST=Manual: (un)tick backup in ARC optin and confirm it in Android settings

Change-Id: I77c123cc4be1e310303cad329249162e2ecd900b
Reviewed-on: https://chromium-review.googlesource.com/807487
Commit-Queue: Kazuhiro Inaba <kinaba@chromium.org>
Reviewed-by: Shuhei Takahashi <nya@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522314}

Previously, there was a 30s timeout to wait for memory dump providers to emit
data, and for the profiling service to emit a memory dump. Now, we wait 10s for
memory dump providers to emit data, and then upload as soon as the heap dump is
added.

Bug: 
Change-Id: I18a334fd59a30fc6021cf8f4e343a19907abc546
Reviewed-on: https://chromium-review.googlesource.com/810052
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522313}

Change-Id: Ie3b80db7f3b8f1048002f76d5ada29bce74e193d
Reviewed-on: https://chromium-review.googlesource.com/790041Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Sasha Morrissey <sashab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522312}

These were added in r522067 and are failing.

Bug: 792776
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I512e7a63765f9a8911d7271a9458aa699e902eaa
NOTRY: true
TBR: jam
Reviewed-on: https://chromium-review.googlesource.com/813315Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522311}

BUG=584597
R=thestig@chromium.org

Change-Id: Ie131b7eb5f994fef3a0808992ec02fa8aa6beed7
Reviewed-on: https://chromium-review.googlesource.com/803738Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522310}

EXPECT_TRUE(ptr); ptr->Dereference(); is a bad idea.
Also remove old TODOs and switch to raw string literals.

Change-Id: I50fdf7bce646c1099a7538d655c87fa6032eff17
Reviewed-on: https://chromium-review.googlesource.com/810041
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522309}

Bug: 761419
Change-Id: I1a789861540ae8be495bca4e67b42fa132c1a1fe
Reviewed-on: https://chromium-review.googlesource.com/812212Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522308}

If the time difference is small, then we probably opened an app window
in response to a client side redirect and left the tab opened. This
will let us know how common this problem is.

Bug: 785661
Change-Id: Icc5a015cd5c0ae9fda5ad457ad564ead4b812332
Reviewed-on: https://chromium-review.googlesource.com/798951
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522307}

NotificationDelegate has a method DisableNotification, which blocks
notifications from the same origin.
Currently, this method is only used by NotificationMenuModel, which is
right click menu of the notification.
This will also be used by inline settings.

To call the delegate method, NotificationMenuModel currently stores
the reference to the Notification instance.
The view should neither have the Notification reference nor call the
NotificationDelegate directly.

This CL adds MessageCenter::DisableNotification and corresponding
delegate methods to resolve this.

TEST=manual
BUG=782533

Change-Id: I0688a00cf3e7fbdda23e74a885a455109811763c
Reviewed-on: https://chromium-review.googlesource.com/795413Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522306}