- 09 Aug, 2019 40 commits
-
-
arthursonzogni authored
Understand for every failing content_browsertests, why they are failing with the BackForwardCache. Bug: 991488 Change-Id: I71feeea5432d44896d5f03503d43ac61829b343e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741681 Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Arthur Hemery <ahemery@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#685516}
-
Daniel Vogelheim authored
This is a purely speculatively fix for an item reported by fuzzers, but not (easily) reproducible. See bug for details. Bug: 970282 Change-Id: I5b04cbe5b6e8b5fe2013aaf1a0e9b2f34c4f607b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742087Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#685515}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e94c274fe0f7..2bd4849cc139 Created with: gclient setdep -r src-internal@2bd4849cc139 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I81b77b09809862b1118d2fb38bc337e0d3cc1121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746196Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#685514}
-
Javier Ernesto Flores Robles authored
MDCCollectionView uses a white background by default. This overrides the default color with one that supports dark mode. Bug: 976675 Change-Id: I3b2f6688698c90f29093cb17dbc9d30e9e3a45ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741913Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#685513}
-
Friedrich Horschig authored
This is a reland of e9756386 It failed on test builds since UNIT_TEST is never defined in CC files. This causes the definition to exist without declaration which resulted in the linker error. Inlining the operator<< definition into the header allows to keep the test and non-Release scoping and fixes the error. (The "inline" keyword prevent duplicate symbols caused by the repeated inclusion of the headers in different CC files.) Original change's description: > [MFill Android] Allow warnings in credit card controller > > This CL allows to add a warning to the credit card accessory sheet. It > is used if a form is deemed to insecure to allow filling. > If this warning is set, it means the context isn't secure enough to fill > a card. Therefore, the input chips are disabled and don't allow inputs*. > If there is no warning, we still check whether the current frame uses > HTTPS. In case the frame doesn't use HTTPS, we disable the chips*. > > * The chips are not disabled _yet_. This requires an update on the > Android side. > > Bug: 965500 > Change-Id: Ia8d5dce9d7d3f540e789f73f383b49a3b42d63d1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729592 > Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> > Reviewed-by: Christos Froussios <cfroussios@chromium.org> > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#684744} Bug: 965500 Change-Id: I4b90ecf6609f5e3f9f2608535e3d60e65f0f07c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741916Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#685512}
-
arthursonzogni authored
This is a follow-up of: https://chromium-review.googlesource.com/c/chromium/src/+/1688957 One comment was backward. Bug: 981339 Change-Id: I27e58a0b6a115fc4d7f3a7e9edcb9ff934dd6213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746246Reviewed-by:
Lowell Manners <lowell@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#685511}
-
arthursonzogni authored
Browser Side Navigation (aka PlzNavigate) has been the only navigation code path since M65, so this file has not been used for a while. Bug: 789577 Change-Id: I923f9dfe244d88d8c90079f66dd1a4a0992bad9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744430Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/16ae3f04949b..e00548aa79c7 git log 16ae3f04949b..e00548aa79c7 --date=short --no-merges --format='%ad %ae %s' 2019-08-09 crouleau@chromium.org [Telemetry] Remove dead code from console logging system. 2019-08-09 perezju@chromium.org [Telemetry] Add file name extensions to trace files Created with: gclient setdep -r src/third_party/catapult@e00548aa79c7 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=oysteine@google.com Bug: chromium:991620,chromium:966835 Change-Id: Ida77e61d6a40c413664c480fd267641d6f89b0b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746198Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#685509}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/b029d3697ea3..22ce39c8e1ec git log b029d3697ea3..22ce39c8e1ec --date=short --no-merges --format='%ad %ae %s' 2019-08-08 stevenperron@google.com Start SPIRV-Tools v2019.5 2019-08-08 stevenperron@google.com Finalize SPIRV-Tools v2019.4 2019-08-08 stevenperron@google.com Add descriptor array scalar replacement (#2742) 2019-08-08 stevenperron@google.com Update CHANGES 2019-08-08 greg@lunarg.com Add SPV_EXT_physical_storage_buffer to opt whitelists (#2779) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@22ce39c8e1ec The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,ynovikov@chromium.org Bug: None Change-Id: Ieb665251f1d72a5a83dce0ab9b8f29518b252cba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746197Reviewed-by:
-
Morten Stenshorne authored
TBR=kojii@chromium.org Change-Id: I9247107dce27e4df96dae755561e05335146f97b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745987 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#685507}
-
Rafał Godlewski authored
Change-Id: I927f539f7a9df969596f106530aa440d3b03c718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744148 Commit-Queue: Rafał Godlewski <rgod@google.com> Reviewed-by:
-
Balazs Engedy authored
Bug: 991463 Change-Id: I5fbfdbd3b15930ed36a747e5226da98375439bf0 TBR: mek@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745470Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#685505}
-
Pâris MEULEMAN authored
As found in //base/android/jni_generator/README.md, the convention of marking method with "native" is deprecated and instead the new convention is to mark an interface with @NativeMethods. This Converts IdentityServicesProvider.java to the new JNI invocation convention. Bug: 934688 Change-Id: Id080c86546ce09457f34c21a8ddf9870625b60a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738368 Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#685504}
-
Jared Saul authored
This needs to be enabled by default only for a specific set of 50 countries, which we'll accomplish via the VariationsService. Until then, it should not expire. Bug: 983940 Change-Id: I600269299eed0ecc63be7642171161928182975c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745550 Auto-Submit: Jared Saul <jsaul@google.com> Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#685503}
-
Michael van Ouwerkerk authored
Bug: 971725 Change-Id: I7201dc535cffee8a4955370ffcf15fa3fe0212bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742165Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#685502}
-
George Burgess IV authored
As noted in the bug, we recently swapped to a new device for profile generation. Somehow this materially impacts our profiles. While this is going to be quite interesting to investigate, it's probably best to do that while Chrome is humming along happily with a known good, even if a bit old, profile. TBR=agrieve@chromium.org Bug: 992188 Change-Id: I0af6777c248019a71941afec722693c43383d58d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746200Reviewed-by:
George Burgess <gbiv@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#685501}
-
Marc Treib authored
PasswordsPrivateDelegate contained two member function declarations that were only used internally by the implementation: SendPasswordExceptionsList and SendSavedPasswordsList. This CL removes them from the interface and makes their implementations private. Bug: none Change-Id: I9550d680c25077978cb30ed06c0f36622ceb2cc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741977Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#685500}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/ef2fac0b9447..ebb05399c09a git log ef2fac0b9447..ebb05399c09a --date=short --no-merges --format='%ad %ae %s' 2019-08-09 iannucci@google.com Rolling 5 dependencies Created with: gclient setdep -r src/third_party/dawn@ebb05399c09a The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: chromium:973721 Change-Id: Id77f6632f657035a2c8a34b37ce44ad7a4118c67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746190Reviewed-by:
-
Alexandre Courbot authored
at_client == true is strictly equivalent to num_times_sent_to_client > 0. Use this latter condition consistently instead of maintaining the same state twice, which is error-prone. Bug: None Test: VDA unittest passes on Minnie. Change-Id: I9d0d396c6a53a7fc594d9208f7b7b6b3b0e26033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743436Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#685498}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/059bf776c184..b2151310068b git log 059bf776c184..b2151310068b --date=short --no-merges --format='%ad %ae %s' 2019-08-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 7424fe8b79c3..eb0479e245f0 (16 commits) 2019-08-09 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps 2019-08-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 2cf71a3e..d9af708a (369 commits) Created with: gclient setdep -r src/third_party/skia@b2151310068b The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@google.com Bug: chromium:None,chromium:None Change-Id: I9046808a93168e577e0eef1342d72264c9e2fe01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746186Reviewed-by:
-
Mohamed Amir Yosef authored
Before this CL: PRESUBMIT.py would block any CL that contains the string NULL. This has been added sometime ago, but only active recently [1]. This is however too strict. It blocks CLs that contains SQL statement like "CREATE TABLE tablename(column TEXT NOT NULL)". After this CL: This is downgraded to a warning instead of an error. [1] https://crrev.com/c/1693398 Change-Id: I431eebf791f0c236cbfe5ee0d8a492118935c624 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742349Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#685496}
-
Vasilii Sukhanov authored
The code is a subset of the library containing ECCommutativeCipher. Unused files were removed. The rest is modified to exclude unnecessary dependencies. The library is branched at 375be83109e10b32441483dbd0f1ac493488d197. Bug: 986298 Change-Id: I3c15cc994b493182e2b7b7661ace2efa339f538f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720874Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/30604c6c8ec1..16ae3f04949b git log 30604c6c8ec1..16ae3f04949b --date=short --no-merges --format='%ad %ae %s' 2019-08-09 dberris@chromium.org Pinpoint: Increase logging for debugging Created with: gclient setdep -r src/third_party/catapult@16ae3f04949b The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=oysteine@google.com Bug: None Change-Id: Iccedbf21c41b8ff0ee128e48d9a97da6a9e47e1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746188Reviewed-by:
-
shrekshao authored
Bug: 992231 Change-Id: I916838267b6a5112d74ede2f5a36286a4891db1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745620 Commit-Queue: Shrek Shao <shrekshao@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#685493}
-
Alexandre Courbot authored
MM21 is a proprietary pixel format used on Kukui devices. This CL adds the hooks necessary for the V4L2 decoder and IP to use it. Bug: b:123551776 Test: VDA unittest passing on Kukui Change-Id: I3da9f7b316d31feb5c1a8b99dfc7bf4cf8adf71e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743298 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I77390e1e5abdaa14ffb5bf2a7f77bef03ab4fdf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746193Reviewed-by:
-
Pâris MEULEMAN authored
IdentityManager.java provides read access to the C++ IdentityManager. This introduces this new class, built and owned by its C++ namesake. This includes identity_manager.h APIs used in java: Observers (OnPrimaryAccountCleared/OnPrimaryAccountSet), HasPrimaryAccount. Follow ups will integrate this in existing code and expose further APIs, details here: https://docs.google.com/document/d/1_ks5kg3qr6TVq7NT6MFg6lh5Yiv-1lic6Rsd9nu5ubI/edit?usp=sharing Bug: 934688 Change-Id: I74111b20d68fccf88e342df9726b6551e4d460fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722968Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#685490}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0f851e59ee6e..e94c274fe0f7 Created with: gclient setdep -r src-internal@e94c274fe0f7 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: Ifc5926e5eea00b17e7f7aab8e5e7bfb0ed266252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745725Reviewed-by:
-
Hiroki Nakagawa authored
WorkerShadowPage is no longer used for shared workers. This CL removes it from WebSharedWorkerImpl. In addition, this CL merges ContinueStartWorkerContext() and StartWorkerThread() into StartWorkerContext() for code simplification. These were called asynchronously because of asynchronous WorkerShadowPage initialization. After WorkerShadowPage is removed, these are called synchronously and mergeable. This merge enables to remove temporary class members (e.g., |name_|) that were used for getting over asynchronous function calls. Bug: 538751 Change-Id: I351faeea06adcc71c80a89067956a819f9f84205 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743853 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#685488}
-
Kinuko Yasuda authored
This reverts commit 44835a1f. Reason for revert: <INSERT REASONING HERE> Original change's description: > Replace Platform::Current() with TestingPlatformSupport to call GetURLLoaderMockFactory. > > This patch is for replacing Platform::Current()->GetURLLoaderMockFactory() > calls with TestingPlatformSupport's GetURLLoaderMockFactory() > under "third_party/blink/renderer/core/" > > Bug: 751425 > Change-Id: Ifd944b5a5ce743f281aa42b2ef92d917fcdeeeb0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567711 > Commit-Queue: DongJun Kim <djmix.kim@samsung.com> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#685442} TBR=kinuko@chromium.org,toyoshim@chromium.org,haraken@chromium.org,djmix.kim@samsung.com Change-Id: I1e8e7b1c0777d35e9e0db0c1393d18723e9647b1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 751425 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746117Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Iaf767d8eef67704b1a2b6b16d59636bc429585f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746187Reviewed-by:
-
Michael Lippautz authored
PermissionObserver kept receiving messages after the object was considered dead (and thus being poisoned) by the garbage collector. Actual destruction of the object is deferred which means the receiver should be cleared on Dispose. Bug: 991085 Change-Id: I701dfa9aad19b30b95cc42f00195668c33393a96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743727Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#685485}
-
Abhijeet Kandalkar authored
In previous CL, all mojom files services/media_session/public/mojom/* are ported to use the new mojo type. The primary goal of this CL is to port remaining usage of old types to new types away from .h/.cc files. Bug: 955171 Change-Id: I8398df352c2f22e5d3f273908e119ecd2b019be6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720789 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#685484}
-
Jeremy Roman authored
It is an ODR violation for conflicting specializations for std::string to exist. Since this is safe and reasonable, write a single std::basic_string<...> specialization in cross_thread_copier.h to apply to std::string (and, should it come up in the future, other specializations of basic_string). Change-Id: I39b796aaf4c86edc00f46239da008e15110cebc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743100 Auto-Submit: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Wez authored
Bug: 49580 Change-Id: I9907d3ea7ccda4de77bcb800ff788255d3824057 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732674 Auto-Submit: Wez <wez@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Brandon Wylie authored
Bug: 970031 Change-Id: I0c8800b3f4ded92230990817261f7212a0f49b50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730955Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
-
Yutaka Hirano authored
There are only two callers, and one actually doesn't need SkData. Also we can implement it only with SharedBuffer public functions. Hence this CL removes the function. Bug: None Change-Id: I6709150b6e4b7708c161b3d83740f0cc7dfbcbd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743871Reviewed-by:
-
Darwin Huang authored
No logic changes. Updates enum values' names. (acronyms are capitalized as single words, as per [1]) [1]: https://google.github.io/styleguide/cppguide.html#General_Naming_Rules Change-Id: I4a73939546094fc6dcacfbc0753f85cc6dc683c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745549 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
-
Antonio Gomes authored
... where it is possible. The remaining WebString occurrences in both files are because they are still used in calls to public API methods. BUG=704136 R=guidou@chromium.org, haraken@chromium.org Change-Id: Iec1736d1911cf94b284beb1af677a9bd35ef98e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744368 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Hiroshige Hayashizaki authored
As a preparation for updating the behavior according to the draft spec, this CL adds spec comments and TODOs, with some renaming and aligning method boundaries with the spec concepts. This CL doesn't change the behavior. Bug: 990561 Change-Id: I79a995ef69c71a71f7aa6b11b78d64b2436163d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734170 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#685477}
-
