- 26 Oct, 2020 40 commits
-
-
Olivier Li authored
Remove the thread check that would never pass and make the variable that is used by multiple threads thread safe. Bug: 1142155 Change-Id: Iae33e15733eb78a47a664515e1abec671edbb64d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495579Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#820817}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b5ba693316fd..5dafe107a36e 2020-10-26 jmadill@chromium.org Output nullptr pointer parameters correctly. 2020-10-26 jmadill@chromium.org Re-enable crash testing in angle_unittests. 2020-10-26 jmadill@chromium.org Fix uninitialize state in ProgramState. 2020-10-26 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 69f07da41b3b to abe2eff36f3c (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: Ib3d7352035280fa5353870f3a71267127938e34c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498848Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820816}
-
Andre Le authored
Update PhoneHub icon in the tray and icons in quick actions. Screenshot: https://screenshot.googleplex.com/3LdU4GYbkHyUWrx https://screenshot.googleplex.com/5NMfjT4ZjQuzcDx BUG=1106937,1126208 Change-Id: Ib4a5e1bdcb38c513f637f2c992c47e7ac7ccd4a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495640Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Andre Le <leandre@chromium.org> Cr-Commit-Position: refs/heads/master@{#820815}
-
Viktor Semeniuk authored
Bug: 1075494 Change-Id: I521f4bf8999b2103fde3c930b96fa013dfae0a12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498603Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Cr-Commit-Position: refs/heads/master@{#820814}
-
Javier Ernesto Flores Robles authored
Bug: 1138710 Change-Id: Ie9b9e3598d87cfa4cf6bdec46121b06d2e06f885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495833 Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#820813}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/42103bc2e911..8036d9953123 2020-10-26 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from f81c1081ea7d to 1bafdc3c45e7 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: rharrison@google.com Change-Id: I33d87de9ce24c59ad8e26f2e91a6cbe07ef121d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498134Reviewed-by:
-
cfredric authored
This CL also removes one UKM collection point, since it is redundant with the UKM collection done by CanvasAsyncBlobCreator. Change-Id: If985fd00bb4d24a7064e8f1252a0131cf1890fbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481445 Commit-Queue: Chris Fredrickson <cfredric@google.com> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/master@{#820811}
-
Peter Kasting authored
Bug: 772945 Change-Id: Ied5542ce1b9eb317d95646a834a6d4633e6b8f09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495862Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#820810}
-
Benoit Lize authored
The alignment directives were not unified across platforms, and didn't compile on Linux (due to a missing semicolon). Use "alignas()" everywhere, which is also semantically closer to what we want. Bug: 1141752 Change-Id: I3553932ac3a0fdeee989eba4b8eae83ffa281098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498466Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#820809}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/011139094ec7..813ef3dc0d5e 2020-10-26 antiagainst@google.com Handle alias libraries in shaderc_combined to avoid duplicated symbols (#1141) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: I95c1996c98d78f67bd72e9be3fb125d348da3f37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498137Reviewed-by:
-
Philip Rogers authored
This patch adds a UseCounter metric for composited (accelerated) SVG content which is enabled by the CompositeSVG experiment. Bug: 1101002 Change-Id: I42d50caf5ae86e60c74082cb4b21846b46557390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498821 Auto-Submit: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#820807}
-
Patrick Noland authored
This reverts commit 7f3e4855. Reason for revert: Breaks the build at _generate_buildfiles step Original change's description: > Roll GN from e002e68a..f5f465b5 > > Generated by //tools/gn/roll_gn.py > > https://gn.googlesource.com/gn/+log/e002e68a..f5f465b5 > > f5f465b5 Fix runtime_deps for elided targets > 3d165b90 Correct the `gn format --dump-tree=json ...` command to write to stdout instead of stderr. > ad0a7ada Remove support for set_sources_assignment_filter function > e1ac69b1 Add a command line to define/overwrite "root" in ".gn" > 7b2a04d5 VS: Use most recently installed Windows 10 SDK. > 132588e1 Revert "gn recipe: Link GN with rpmalloc to speed it up." > 3281c669 Add "framework_dirs" and "frameworks" to syntax highlighting rules > 4323e701 gn recipe: Link GN with rpmalloc to speed it up. > c808630c Move runtime_deps file for phony targets to /obj > 8855c522 Update Clang and Xcode SDK to 12B5025f > 76f9b6ad Use fetch instead of cherry-pick for Gerrit changes > a3d69e87 Don't return if package is up-to-date > 36ff17cb Switch back to the older Clang version > 7bcc0eb3 Revert "Update Xcode SDK to 12B5025f" > e5f1f587 Update Xcode SDK to 12B5025f > 6453c5de Support cross-compiling GN for other targets > 42d6de6e Don't classify Rust static libraries as final > a9eaeb80 Switch remaining stamp targets to phony targets > ff45cf2a Show config.visibility in `gn desc` > de5a8348 [rust project] removing obsolete std libraries > 4c684398 Fix "gn outputs" for bundle data. > 99f72f88 Switch source_set stamp targets to phony targets > 5233fa13 Remove extra * in gn output docs > > As of 99f72f88 and a9eaeb80, GN's usage of stamp files for intermediate > steps in the build graph have been replaced with phony aliases. As a > result, this CL also updates the MB tool to look for ".runtime_deps" > files instead of ".stamp.runtime_deps". > > Change-Id: I4ab46ee211c7dd45bba655c946e24684b0cfcf9a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485444 > Reviewed-by: Dirk Pranke <dpranke@google.com> > Commit-Queue: RJ Ascani <rjascani@google.com> > Cr-Commit-Position: refs/heads/master@{#820799} TBR=dpranke@google.com,rjascani@google.com Change-Id: Icbad43cbaf7f622fb15f8e47693e01fc9eb234d8 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499364Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#820806}
-
Sébastien Séguin-Gagnon authored
Bug: 1136043 Change-Id: I8245fd9ad0a3242c191660a52f10c277b2ba9093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495912Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Auto-Submit: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#820805}
-
Daniel Murphy authored
Stops syncing page and launch ordinals of webapps back to the shadow extension installations. R=loyso@chromium.org Bug: 1099615 Change-Id: I520b1c375b07743b330e376b81705a5cfd56c8b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485435Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#820804}
-
Patrick Noland authored
This reverts commit d42c900a. Reason for revert: Flaking on android-pie-x86-rel: https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel/2682 Original change's description: > Re-enable testOpenManyTabsQuickly > > Bug: 223587 > Change-Id: I1b61f97f9c864d467593c490fa4fc5b7efd16989 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493001 > Reviewed-by: Theresa <twellington@chromium.org> > Commit-Queue: Matthew Jones <mdjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#820745} TBR=twellington@chromium.org,mdjones@chromium.org Change-Id: Ifabbdbba158a3e9b6d49b696c5c1391cdfbda701 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 223587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498949Reviewed-by:
-
harrisonsean authored
Fix an issue where SafetyCheckMediator instances are not being released due to use of self instead of weakself. Bug: 1140923 Change-Id: I1bda7052e504d5e294b4321b48064eede463b6e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498502Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#820802}
-
Lukasz Anforowicz authored
This CL changes how PrefetchURLLoaderService::IsValidCrossOriginPrefetch compares network::ResourceRequest::request_initiator argument with content::RenderFrameHostImpl::GetLastCommittedOrigin. The comparison needs to take into account differences with how Blink and //content layer compute origins of file: URLs. Fixed: 1140947 Change-Id: I261959bd1df346e9d1a7144892ce06d62a453e43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493283 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#820801}
-
Ramin Halavati authored
Updates TestingProfile for better support of ephemeral Guest profiles. Please see go/ephemeral-guest-profiles for more context. Bug: 1125474 Change-Id: Ibfce3a9df1ab3b17a517b05635c11a4d4dce86b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494721Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#820800}
-
RJ Ascani authored
Generated by //tools/gn/roll_gn.py https://gn.googlesource.com/gn/+log/e002e68a..f5f465b5 f5f465b5 Fix runtime_deps for elided targets 3d165b90 Correct the `gn format --dump-tree=json ...` command to write to stdout instead of stderr. ad0a7ada Remove support for set_sources_assignment_filter function e1ac69b1 Add a command line to define/overwrite "root" in ".gn" 7b2a04d5 VS: Use most recently installed Windows 10 SDK. 132588e1 Revert "gn recipe: Link GN with rpmalloc to speed it up." 3281c669 Add "framework_dirs" and "frameworks" to syntax highlighting rules 4323e701 gn recipe: Link GN with rpmalloc to speed it up. c808630c Move runtime_deps file for phony targets to /obj 8855c522 Update Clang and Xcode SDK to 12B5025f 76f9b6ad Use fetch instead of cherry-pick for Gerrit changes a3d69e87 Don't return if package is up-to-date 36ff17cb Switch back to the older Clang version 7bcc0eb3 Revert "Update Xcode SDK to 12B5025f" e5f1f587 Update Xcode SDK to 12B5025f 6453c5de Support cross-compiling GN for other targets 42d6de6e Don't classify Rust static libraries as final a9eaeb80 Switch remaining stamp targets to phony targets ff45cf2a Show config.visibility in `gn desc` de5a8348 [rust project] removing obsolete std libraries 4c684398 Fix "gn outputs" for bundle data. 99f72f88 Switch source_set stamp targets to phony targets 5233fa13 Remove extra * in gn output docs As of 99f72f88 and a9eaeb80, GN's usage of stamp files for intermediate steps in the build graph have been replaced with phony aliases. As a result, this CL also updates the MB tool to look for ".runtime_deps" files instead of ".stamp.runtime_deps". Change-Id: I4ab46ee211c7dd45bba655c946e24684b0cfcf9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485444Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: RJ Ascani <rjascani@google.com> Cr-Commit-Position: refs/heads/master@{#820799}
-
Andreea Costinas authored
Also fix a use case where user credentials are always being sent for user traffic, regardless of the `ArcEnabled` setting. Bug: 1139905 Test: unit test Change-Id: Ia010653ea13cedd87049ca5537efbd107905151a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485091Reviewed-by:
Andreea-Elena Costinas <acostinas@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Omar Morsi <omorsi@google.com> Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> Cr-Commit-Position: refs/heads/master@{#820798}
-
Christoph Schwering authored
This CL adds sorting of MatchingPatterns in PatternProvider. Bug: 1141654 Change-Id: I1ec0bc1bba489fe2217b55fb3711cee63749aac4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493381 Commit-Queue: Christoph Schwering <schwering@google.com> Reviewed-by:
Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#820797}
-
chrome://discards/graphSigurdur Asgeirsson authored
This was broken in https://crrev.com/c/2472484. Bug: 1142423 Change-Id: Ia75b428c5e3aa0fccca0563d8cb071852faca0e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498861Reviewed-by:
-
Christoph Schwering authored
The MatchFieldTypes enum starts at 1<<2 instead of 1<<0 temporarily. Since the lowest two bits are used nowhere at the moment, and MatchFieldTypes will be shifted to the right once the PatternProvider is launched, we can shift the values in the JSON to the right, and shift them to the left only at load time in order to match the MatchFieldTypes enum. This CL also changes the compression algorithm from gzip to brotli, which saves about 18% space. Bug: 1140775 Change-Id: I171d4b67391da7b7934993fd7611a8acecce7fdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489080Reviewed-by:
-
Adam Norberg authored
This is sort of a draft but it may not get refined more than this. The code itself is commented, this is intended more as orientation so someone trying to use it can figure out what they're looking at enough that the comments are of any use. ScopedXPCServiceMock interposes a mock that is then _implicitly_ picked up by the code under test, so directly tracing it is not likely to be the best place to start... Change-Id: Ia851b3005788b3200a08ae572ee48fc29f822f47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491222 Commit-Queue: Adam Norberg <norberg@google.com> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#820794}
-
Patrick Noland authored
Bug: 1141442 Change-Id: I3dd0b01a6c5dfa2d3c7cb4ec634f34e4b140c4e2 TBR: ntfschr@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498832Reviewed-by:
-
Lily Chen authored
This removes the feature and param for an emergency setting that was never used. This is now obsolete because SameSite-by-default cookies is now enabled by default. Bug: 1045122 Change-Id: I6528907276c986c8de7c69e3bad71c08b4f3d6d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495352Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#820792}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e6fa238f76e5..71002a226ac5 2020-10-26 danilchap@webrtc.org Add layer skipping to L2T2_KEY_SHIFT structure 2020-10-26 hta@webrtc.org Break circular dependency on WebRtcSessionDescriptionFactory 2020-10-26 hta@webrtc.org Change PeerConnection creation to use a static "Create" method 2020-10-26 nisse@webrtc.org Delete unneeded includes of system_wrappers/include/sleep.h 2020-10-26 hta@webrtc.org Remove forwarding header media_stream_track.h If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I1b72f328833fc629a9301e42d98e80a478662c05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498087Reviewed-by:
-
W. James MacLean authored
Re-enables SitePerProcessBrowserTest.TouchEventAckQueueOrdering in order to collect data on failures directly on the bots, since I can't get it to flake locally. Bug: 945025 Change-Id: I5f6352456164013f48e7034045aa44977b9c5435 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499083Reviewed-by:
-
Morten Stenshorne authored
Bug: 800764 Change-Id: Ifc90f2c225effbec98f5997bbce77f2135bea971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484445Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#820789}
-
Wei Li authored
FocusableLabelButton already sets its own focus ring. It is meant to be focusable as well. So explicitly set its focus behavior in this class instead of setting it for each instance. Bug: 1001103 Change-Id: Ie2169e9bf8a3d27200444c03da86f69eae6ee725 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495702Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#820788}
-
Geoff Lang authored
TBR=kbr@chromium.org Bug: chromium:982292 Bug: angleproject:5221 Bug: angleproject:5222 Bug: angleproject:5223 Bug: angleproject:5224 Bug: angleproject:5225 Bug: angleproject:5226 Bug: angleproject:5227 Change-Id: I5f0bc53c2f6a2f207b5e53799ece6a733736728c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495284Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Auto-Submit: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#820787}
-
Guillaume Jenkins authored
In preparation for CBCM reporting unit tests, this extends the mock infrastructure for policy objects that will be involved. In particular: - A new mock BrowserStatePolicyConnector was added - The TestChromeBrowserState builder now supports building the browser state with a mock BrowserStatePolicyConnector - The TestChromeBrowserStateManager can return a TestChromeBrowserState by path - The TestingApplicationContext now creates a real BrowserPolicyConnector if its accessor is called These are all needed for the ProfileReportGeneratorIOS unit tests, which will come in a separate CL. Bug: 1055318 Change-Id: I3428e56d695c014d63245be6493d527787343cce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495265Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#820786}
-
Henrik Boström authored
The pixel_buffer_transferer_mac_unittest.mm defines several helper functions for creating ARGB and YUVS buffers from a single color or with a checker pattern, converting between the two formats, and verifying the color or number of tiles of a pixel buffer. Because these are useful for sanity checks involving creating or modifying pixel buffers, we move these to a separate utilities file (only available in testing). To be used by future CLs' unittests. Bug: chromium:1132299 Change-Id: Idd6c3f8918b540240f515e2761695e9b5bc9caa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498564 Commit-Queue: Markus Handell <handellm@google.com> Reviewed-by:
Markus Handell <handellm@google.com> Cr-Commit-Position: refs/heads/master@{#820785}
-
Toni Barzic authored
BUG=1137452 Change-Id: Ic9796c43893f63142835a78d4b5bfc08b8b67b90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495421Reviewed-by:
-
Robin Lewis authored
This is the exact change (after conflict resolution) as the one reviewed in https://chromium-review.googlesource.com/c/chromium/src/+/2446546 which was reverted in https://chromium-review.googlesource.com/c/chromium/src/+/2453393 due to breaking component builds. That issue has been fixed. When cloud policies is enabled, GCPW will try to read the list of allowed domains from Omaha policy if they have been fetched already. If not it will fall back to the registry entry as before. Bug: 1134817 Change-Id: If4e50a4c9532e897fabf7470688a83b3653a56bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496183Reviewed-by:
S. Ganesh <ganesh@chromium.org> Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Yusuf Sengul <yusufsn@google.com> Commit-Queue: Robin Lewis <wrlewis@google.com> Cr-Commit-Position: refs/heads/master@{#820783}
-
Nicolas Ouellet-Payeur authored
With the DestroyProfileOnBrowserClose experiment, there may be a lot more use-after-free bugs in ~PrefChangeRegistrar(), so add a comment explaining this and giving a point-of-contact. Bug: 1141952 Change-Id: Ie3887151d511fdd965763598d6fc33599cdf60dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497989 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#820782}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/f81c1081ea7d..1bafdc3c45e7 2020-10-26 dneto@google.com spirv-writer: Generate load for return value, when needed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: rharrison@google.com Change-Id: Iac9aae898db8826b961557681ca52dce7aa682a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498843Reviewed-by:
-
Matt Menke authored
It's one of two tests across all of Chrome using BrowserTestBase::spawned_test_server(), which we should remove. Also re-enable the test on Windows. It was disabled due to https://crbug.com/1140928, the underlying cause of which has now been fixed. Fixed: 997823 Bug: 492672 Change-Id: I2eb43613aac3b05299fbb15d37967a3de30a2380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499081Reviewed-by:
Steven Valdez <svaldez@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#820780}
-
Andreas Haas authored
This CL brings WebAssembly UMA metrics to the v8-browsing benchmark in Telemetry. R=mythria@chromium.org, clemensb@chromium.org Bug: chromium:1084929 Change-Id: I28e72378774c3d599da1ad670ba036a3f0ea84e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497164Reviewed-by:
Mythri Alle <mythria@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#820779}
-
Reda Tawfik authored
Bug: 1138612, 1104132, 1006430 Change-Id: Ie9cb6105cb7612f56caa2d23b4cae010702f443d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497441 Commit-Queue: Reda Tawfik <redatawfik@google.com> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#820778}
-
