GitLab

Cr-Commit-Position: refs/heads/master@{#441314}

This patch rejects setting invalid values for registered properties via
the CSSStyleDeclaration::setProperty function. The behaviour which we
decided on is that we will retain any values set prior to registration
and compute them as if they were the unset keyword if they are invalid
after registration, but disallow setting such values after registration.

CSS Typed OM is not yet hooked up aside from the filtered computed map
for custom paint, so we don't yet make any changes there.

BUG=641877

Review-Url: https://codereview.chromium.org/2607403002
Cr-Commit-Position: refs/heads/master@{#441313}

BUG=

Review-Url: https://codereview.chromium.org/2608023002
Cr-Commit-Position: refs/heads/master@{#441312}

- CSSSelectorWatch is used to implement a Blink public API that supports
  the chrome.declarativeContent [1] extension API. This is an internal
  implementation detail of Chrome, and has been moved to the unspecced
  timer task source.
- The presentation attribute [2] cache cleaner remains as-is, since it's
  a static cleaner shared among different frames.

[1] https://developer.chrome.com/extensions/declarativeContent
[2] e.g. bgcolor, topmargin, etc attributes on a body element

BUG=624694

Review-Url: https://codereview.chromium.org/2614603002
Cr-Commit-Position: refs/heads/master@{#441311}

BUG=612542
TEST=gl_tests
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2602563002
Cr-Commit-Position: refs/heads/master@{#441310}

This adds some basic java tests for the new disclosure UI.

BUG=675858

Review-Url: https://codereview.chromium.org/2593393002
Cr-Commit-Position: refs/heads/master@{#441309}

BUG=660907
TEST=ScrollingCoordinatorTest.StyleRelatedMainThreadScrollingReasonTest
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2599043003
Cr-Commit-Position: refs/heads/master@{#441308}

Revert of Fix TabCaptureApiTest.FullscreenEvents flakiness (patchset #2 id:20001 of https://codereview.chromium.org/2604133002/ )

Reason for revert:
TabCaptureApiTest.FullscreenEvents is now timing out consistently on the Win7 Tests (dbg)(1) bot (build #56178 and later) so I don't think we're ready to re-enable it yet: https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29

Original issue's description:
> Fix TabCaptureApiTest.FullscreenEvents flakiness
>
> Fixes flakiness caused by a subtle distinction in document fullscreen
> state change: The tabCapture.onStatusChanged API can sometimes report a
> fullscreen state change before the document itself is aware the change
> occurred. This is because the tabCapture API's listener reports on the
> browser's fullscreen state, whereas the document is only aware of its
> own internal fullscreen state (which is updated only after the browser
> notifies it of a change).
>
> The flakiness was due to the C++ side of the test being notified that
> the page had entered fullscreen before the page itself was aware of it.
> This caused the simulated mouse click (to toggle fullscreen mode) to be
> made early, and then both the C++ and JS sides of the test became
> out-of-sync and froze, each waiting on the other to do something.
>
> This change fixes the issue by always using the document's fullscreen
> change listeners, to ensure the out-of-sync condition cannot occur.
> This change also "freshens up" the JavaScript code in this test, using
> newer ES6 syntax.
>
> BUG=675851
>
> Committed: https://crrev.com/c52ce18fd8f6db97c62737f0924bd61a2727c5d3
> Cr-Commit-Position: refs/heads/master@{#441252}

TBR=xjz@chromium.org,miu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=675851

Review-Url: https://codereview.chromium.org/2611593005
Cr-Commit-Position: refs/heads/master@{#441307}

Some animation events are dispatched on the DOM manipulation task
source. However, the spec [1] doesn't seem to say much about timelines
and their animations, so dispatch them on the unspeced timer source.

[1] https://w3c.github.io/web-animations/#document-timelines

BUG=624694

Review-Url: https://codereview.chromium.org/2616593002
Cr-Commit-Position: refs/heads/master@{#441306}

Create BaseSafeBrowsingService in the components layer and derive
SafeBrowsingService from that.

BUG=488675

Review-Url: https://codereview.chromium.org/2605213002
Cr-Commit-Position: refs/heads/master@{#441305}

Add setter and getter methods for accessing m_didSetLooping so that we
can access it atomically. The audio thread was reading this while the
main thread could be writing it.

Manually verified the test case from the bug that this fix works. (Need to reload the page a few times to trigger the original bug.)

BUG=676874
TEST=

Review-Url: https://codereview.chromium.org/2615463002
Cr-Commit-Position: refs/heads/master@{#441304}

https://skia.googlesource.com/skia.git/+log/7551898f8eba..9ea894b4d030

$ git log 7551898f8..9ea894b4d --date=short --no-merges --format='%ad %ae %s'
2017-01-03 mtklein Revert "trim another instruction off SkRasterPipeline overhead"
2017-01-03 bungeman Specify "/utf-8" with Visual C++.
2017-01-03 senorblanco Quality and performance fixes for AA tessellating path renderer.
2017-01-03 senorblanco Revert "Quality and performance fixes for AA tessellating path renderer."
2017-01-03 senorblanco Quality and performance fixes for AA tessellating path renderer.
2017-01-03 ethannicholas fixed a divide-by-zero bug in skslc
2017-01-03 ethannicholas switched GrVkPipelineStateCache over to use SkLRUCache
2017-01-03 herb Fix: when pos is not finite, text pointer not advanced.
2017-01-03 reed validate deserialized path verbs
2016-12-22 scroggo GIF: Better check for frame dependency
2017-01-03 ethannicholas Force classic locale when parsing floats in skslc.
2016-12-29 ethannicholas fix for Vulkan SPIR-V crash on some systems
2016-12-29 mtklein trim another instruction off SkRasterPipeline overhead

BUG=660893,660893,676755

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=csmartdalton@google.com

Review-Url: https://codereview.chromium.org/2602323004
Cr-Commit-Position: refs/heads/master@{#441303}

committed.

BUG=668342

Review-Url: https://codereview.chromium.org/2611873002
Cr-Commit-Position: refs/heads/master@{#441302}

Previously, we had two SurfaceInfo objects:

ui/aura/mus/surface_id_handler.h's SurfaceInfo

and cc/surfaces/surface_info.h

This CL switches to using cc::SurfaceInfo instead, transmitting it over
mojo and replaces all call sites where the fields are passed
individually.

SurfaceInfo becomes part of the Mus API: It is the bundle of state
necessary to embed a Surface across processes.

BUG=676375
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2610723002
Cr-Commit-Position: refs/heads/master@{#441301}

BUG=567770
R=eroman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
NO_DEPENDENCY_CHECKS=true

Review-Url: https://codereview.chromium.org/2602473003
Cr-Commit-Position: refs/heads/master@{#441300}

BUG=677885

Review-Url: https://codereview.chromium.org/2614553002
Cr-Commit-Position: refs/heads/master@{#441299}

BUG=673820

Review-Url: https://codereview.chromium.org/2595503002
Cr-Commit-Position: refs/heads/master@{#441298}

These are some reasons to do this:
1. Code can be shared between ES2 and ES3 tests.
2. We don't always create GL_TEXTURE_2D textures in test.
3. We may create textures many times in a single test. In such case,
  it's ugly to delete the textures created in Setup at the beginning of
  each test round.

BUG=612542
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2602933002
Cr-Commit-Position: refs/heads/master@{#441297}

https://pdfium.googlesource.com/pdfium.git/+log/d654d7854951..4741b291f462

$ git log d654d7854..4741b291f --date=short --no-merges --format='%ad %ae %s'
2017-01-03 tsepez Add CFX_RetainPtr Leak() and Unleak() methods

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2615553002
Cr-Commit-Position: refs/heads/master@{#441296}

ChooserContentView[Cocoa] class name is too generic for //chrome/browser/ui/views/
and //chrome/browser/ui/cocoa directories. So change them to
DeviceChooserContentView[Cocoa] to be more specific.

BUG=651568

Review-Url: https://codereview.chromium.org/2595083002
Cr-Commit-Position: refs/heads/master@{#441295}

This test is timing dependent. We now allow more time.

BUG=248938

Review-Url: https://codereview.chromium.org/2606133002
Cr-Commit-Position: refs/heads/master@{#441294}

It's no longer used. There is a more cleanup to be done around
renaming files. I'll do that after this.

This also removes what was views_mus_unittests and renames what was views_aura_mus_unittests to views_mus_unittests.

BUG=671363
TEST=none
R=ben@chromium.org

Review-Url: https://codereview.chromium.org/2611773002
Cr-Commit-Position: refs/heads/master@{#441293}

I'm starting to run clang-format on things, and it's miraculously
not blowing up on <if> or <include> in .js files.  It IS, however,
changing " to ', as JavaScript generally prefers '.

This helps handle that.

R=thakis@chromium.org
BUG=567770

Review-Url: https://codereview.chromium.org/2598863002
Cr-Commit-Position: refs/heads/master@{#441292}

Changes:
Because now ui_test_utils::BringBrowserWindowToFront now supports activation waiter, let us reopen these tests for Linux_aura.

BUG=163931
TEST=automated tests

Review-Url: https://codereview.chromium.org/2600473003
Cr-Commit-Position: refs/heads/master@{#441291}

This CL-
  - Adds support for multi-line text selection to RenderTextHarfBuzz. To do this
    RenderTextHarfBuzz::FindCursorPosition and
    RenderTextHarfBuzz::GetSubstringBounds are reimplemented.
  - RenderTextHarfBuzz::FindCursorPosition now returns valid grapheme boundaries
    hence fixing issue 673986.
  - RenderTextHarfBuzz::GetSubstringBounds did already support multiline but the
    implementation was flawed. It relied on the text space bounds intersection
    computed from LineSegment's x_range paramater and from TextRunHarfBuzz.
    However these were not in sync if some newline segments were popped or if
    some text was truncated.
  - Enables multi-line text selection for views::Labels.
  - Corrects the behavior for RTL when mouse is dragged above/below the text
    bounds on MacViews.
  - Adds lots of tests.

BUG=650120, 630365, 600166, 673986
TEST= Open views_examples_with_content_exe. Select Labels from the dropdown.
Enter a large string in the "Content" textfield. Enable the Multiline and Text
Selection checkboxes. Ensure text selection works correctly on the Label.

Review-Url: https://codereview.chromium.org/2541313002
Cr-Commit-Position: refs/heads/master@{#441290}

Currently, the Form-Not-Secure warning shows up in the autofill dropdown
when the autofill suggestions are shown, but it should also show up on page
load when a password form is autofilled.

This CL adds a ShowNotSecureWarning method that roughly mirrors the
Fill-On-Account-Select flow. When a password form is autofilled on page load,
and when the PasswordFormFillData indicates that the warning should be shown,
the renderer calls ShowNotSecureWarning() to tell the browser to show the
autofill popup with the form-not-secure warning (and no autofill suggestions).

BUG=672668
TEST=Save a password on http://rsolomakhin.github.io/autofill/ in the
Name/Password form. Load the page again and observe that the field
is autofilled with a "Login not secure" autofill dropdown.

Review-Url: https://codereview.chromium.org/2604453003
Cr-Commit-Position: refs/heads/master@{#441289}

Removes a bunch of dead code that was relevant years ago before Chromium
even had a compositor, including a capture from the "backing store" and
a separate "render thread" for scaling and YUV conversion. Also,
gutted-out and simplified the unit tests.

In addition, BUILD files were modified so that only the platforms that
have implementation build/link the relevant modules.

BUG=159234

Review-Url: https://codereview.chromium.org/2605973002
Cr-Commit-Position: refs/heads/master@{#441288}

When double tapping on Forward navigation button the following happens:
- loadRequest: is called for the first Forward Tap (WKNavigation #1)
- loadRequest: is called for the second Forward Tap (WKNavigation #2)
- didStartProvisionalNavigation: is called for WKNavigation #1
- didFailProvisionalNavigation: is called for WKNavigation #1

CRWWebController used to record WKNavigation #1 as latest navigation
in didStartProvisionalNavigation: overriding WKNavigation #2.

Later inside didFailProvisionalNavigation: CRWWebController cancelled
the load because WKNavigation #1 was determined as latest.

This CL replaces _latestWKNavigation object with CRWWKNavigationStates
object which allows better tracking of latest WKNavigation object.

BUG=677327

Review-Url: https://codereview.chromium.org/2601083003
Cr-Commit-Position: refs/heads/master@{#441287}

Layout tests and blink perf tests will run with SlimmingPaintInvalidation
enabled.

BUG=646176

Review-Url: https://codereview.chromium.org/2595323003
Cr-Commit-Position: refs/heads/master@{#441286}

Note also the change made to CustomFrameView. Seems odd that this issue exists there after all these years. Maybe I should be making that change somewhere else?

R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2613613002
Cr-Commit-Position: refs/heads/master@{#441285}

This is a re-land of half of the code in
https://codereview.chromium.org/2605743002
which was reverted because it changed layout test color.

TBR=avi,esprehn
BUG=634102

Review-Url: https://codereview.chromium.org/2615523002
Cr-Commit-Position: refs/heads/master@{#441284}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/4ffd54d31cd5..a067dd2f2b17

$ git log 4ffd54d31..a067dd2f2 --date=short --no-merges --format='%ad %ae %s'
2017-01-03 jbudorick [systrace] Stop the browser after each test.

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2611893002
Cr-Commit-Position: refs/heads/master@{#441283}

Reported crashes suggest a situation where we may double-free a
BrowserWindowController. Stacks show a UAF while trying to release a
reference to |self| held by an ObjC closure. The free occurs on an
autorelease triggered by a closure.

Most likely these are happening on the same closure. That is
__NSFireDelayedPerform "free()s" and its __delayedPerformCleanup
immediately tries to access to free again.

One hypothetical way this could occur would be if AppKit invoked
-[BrowserWindowController windowWillClose:] multiple times. Each time
would post a delayed autorelease closure. When the second is executed,
it would create the situation described.

Protect against this with an early exit in windowWillClose: if it's
already been called.

BUG=671213

Review-Url: https://codereview.chromium.org/2597023002
Cr-Commit-Position: refs/heads/master@{#441282}

We currently allow AC3/EAC3 codec id variants lower-case OTIs,
i.e. mp4a.a5 and mp4a.a6 in most places (e.g. stream_parser_factory.cc
and mime_util_internal.cc). We also need to support those lower-case
variants in StringToAudioCodec, since otherwise they won't get
recognized when an app adds a source buffer with that codec id and it's
checked in SourceBufferState::Init.

BUG=internal b/33554560

Review-Url: https://codereview.chromium.org/2587413004
Cr-Commit-Position: refs/heads/master@{#441281}

This fix memory corruption crash when app is launched from shelf
shortcut.

TEST=Manually, crash is no longer observed.
BUG=676392

Review-Url: https://codereview.chromium.org/2612453002
Cr-Commit-Position: refs/heads/master@{#441280}

BUG=675987
TEST=realtimeanalyser-basic.html

Review-Url: https://codereview.chromium.org/2598683002
Cr-Commit-Position: refs/heads/master@{#441279}

No need to hardcode to vector as that exposes more implementation
details that needed.  It can easily support all types.

BUG=

Review-Url: https://codereview.chromium.org/2616503002
Cr-Commit-Position: refs/heads/master@{#441278}

Add AudioScheduledSourceNode as a base class of schedulable source nodes to capture
the common features of these source nodes.

Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/Vr6XJNfVAK4/RU3AP19WAQAJ

BUG=661207
TEST=audio-scheduled-source-basic.html

Review-Url: https://codereview.chromium.org/2471353004
Cr-Commit-Position: refs/heads/master@{#441277}

This CL:
* Cleans up the network-proxy HTML and JS files
* Adds a 'Save' button for configuring manual proxy configurations
  since a partial configuration might be invalid.
* Prevents updates from overwriting in-progress manual config changes.
* Fixes the mechanism for saving other proxy configurations also.
* Fixes logic determining when fields are editable.

BUG=677357
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2605373002
Cr-Commit-Position: refs/heads/master@{#441276}

In Chrome OS launcher's start page, we recreate the app tile views
if we need to display different numbers of apps compared with the
previous time (e.g., install a new app or uninstall an existing app).
We need to make sure the number of the displayed apps is properly
updated. Otherwise, it might cause browser crash because of retrieving
a stale pointer in StartPageView::StartPageTilesContainer::GetTileItemView().

This simple CL is a temporary fix that meant to merge back to M56. It
will be reverted later on Tot and a better but more complicated fix
will be landed.

BUG=675150

Review-Url: https://codereview.chromium.org/2605463003
Cr-Commit-Position: refs/heads/master@{#441275}