GitLab

if some format is supported or not.IsReadbackConfigSupported
takes care of validating this.

BUG=376769, 415131

Review URL: https://codereview.chromium.org/570003002

Cr-Commit-Position: refs/heads/master@{#295656}

If user right clicks immediately on entering a bookmark button, then open the
folder without delay so that context menu appears over the folder menu.

BUG=168758
R=asvitkine@chromium.org

TEST=
1. Add a bookmark folder to Bookmarks Bar (folder1).
2. Add a subfolder (folder2) inside folder1.
3. Add few bookmarks to folder2.
4. Click on folder1 and immediately right click on folder2 and observe.
5. Context Menu should appear over the folder menu (folder contents window).

Review URL: https://codereview.chromium.org/581053002

Cr-Commit-Position: refs/heads/master@{#295655}

The following supressions are no longer needed:
bug_233541
bug_238547
bug_241044
bug_243132
bug_243753

BUG=233541,238547,241044,243132,243753
TBR=groby@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/587563002

Cr-Commit-Position: refs/heads/master@{#295654}

Refactoring PasswordAutofillAgent::FillUserNameAndPassword for early return if password_element is not autocompleteable.

PasswordAutofillAgent::FillUserNameAndPassword function refactor done for early return as we chould check this at start only.

BUG=398436

Review URL: https://codereview.chromium.org/557703002

Cr-Commit-Position: refs/heads/master@{#295653}

Move declaration of AttachmentServiceProxyForTest's destructor to make
it clear the WeakPtrFactory is the last data member.

BUG=303818

Review URL: https://codereview.chromium.org/575383002

Cr-Commit-Position: refs/heads/master@{#295652}

and added proper history change notification on history data change.

BUG=None

Review URL: https://codereview.chromium.org/579753002

Cr-Commit-Position: refs/heads/master@{#295651}

The following supressions are no longer needed:
bug_180381
bug_184264
bug_222363
bug_222898
bug_224747
bug_225596

BUG=180381,184264,222363,222898,224747,225596
TBR=groby@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/585783002

Cr-Commit-Position: refs/heads/master@{#295650}

The following supressions are no longer needed:
bug_170340
bug_172025
bug_173096
bug_175100
bug_175985
bug_176270

BUG=170340,172025,173096,175100,175985,176270
TBR=groby@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/585773002

Cr-Commit-Position: refs/heads/master@{#295649}

The following supressions are no longer needed:
bug_162828
bug_164198
bug_166470
bug_166470c
bug_166470d
bug_166709
bug_166709b
bug_166709c
bug_166976a
bug_166976b

BUG=162828,164198,166470,166709,166976
TBR=groby@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/585753002

Cr-Commit-Position: refs/heads/master@{#295648}

The following supressions are no longer needed:
bug_150995
bug_151006
bug_151007
bug_151908
bug_155404
bug_156829
bug_158514
bug_159005
bug_160877

BUG=150995,151006,151007,151908,155404,156829,158514,159005,160877
TBR=groby@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/586603002

Cr-Commit-Position: refs/heads/master@{#295647}

It's currently hard for the AppListService to access the model. The
model is now profile keyed. However, to get the "right" profile, the
AppListViewDelegate is the current source of truth. And to get this,
AppListService needs to dig into its platform-specific parts to get it
via the platform-specific view.

However, the AppListView can be destroyed, so the delegate doesn't
always exist. Therefore the AppListViewDelegate doesn't always exist --
it is created each time the AppListView is created. On ChromeOS, this is
each time the app list is shown.

Before the model was profile-keyed, some state was tricky to store.
E.g., some is stored in ExtensionAppModelBuilder, and updated via
notifications (e.g. NOTIFICATION_APP_INSTALLED_TO_APPLIST). Also, since
the model must now outlive the AppListView for sync, it makes less sense
for the AppListViewDelegate to be owned by the view. Currently showing
the app list can create a new ALVD, which must be re-attached to the
model each time.

This change moves ownership of the AppListViewDelegate into the
AppListServiceIpml or test/shell controllers, which will create it
lazily and then cache the result.

BUG=403647, 404535

Review URL: https://codereview.chromium.org/508813002

Cr-Commit-Position: refs/heads/master@{#295646}

BUG=384041
TEST=new tests added

Committed: https://crrev.com/3c23f4a188e171998f3042ad62f4aa5717e66d63
Cr-Commit-Position: refs/heads/master@{#295524}

Review URL: https://codereview.chromium.org/561943002

Cr-Commit-Position: refs/heads/master@{#295645}

The target_arch should be ia32 for x86 builders. This is causing the x86 try and
fyi bots to fail during runhooks because it doesnt match a case in common.gypi.

BUG=359644
TBR=cmp@chromium.org

Review URL: https://codereview.chromium.org/581173004

Cr-Commit-Position: refs/heads/master@{#295644}

R=dbeam@chromium.org
BUG=393873
TEST=./third_party/closure_compiler/bump_compiler_version

Review URL: https://codereview.chromium.org/582193002

Cr-Commit-Position: refs/heads/master@{#295643}

They were used only in tests, so change those tests to set a global state instead.

Review URL: https://codereview.chromium.org/547003002

Cr-Commit-Position: refs/heads/master@{#295642}

This changes OOP PDF to use BrowserPlugin which allows it to be loaded without
navigating to the extension page.

BUG=303491

Review URL: https://codereview.chromium.org/582583002

Cr-Commit-Position: refs/heads/master@{#295641}

BUG=408765
TEST=back-to-back requests don't bypass the cache lock.

Review URL: https://codereview.chromium.org/579393002

Cr-Commit-Position: refs/heads/master@{#295640}

BUG=318404,320774
R=newt@chromium.org

Review URL: https://codereview.chromium.org/582303002

Cr-Commit-Position: refs/heads/master@{#295639}

* Previous behavior is to cancel only one item.
* After Issue 400636, this behavior doesn't make sense because only the
  number is decreased.

BUG=414610
TEST=manually
1. Copy the file from Download to Drive.
2. Push the button in syncing status.
3. Confirm all jobs are canceled.

Review URL: https://codereview.chromium.org/576063002

Cr-Commit-Position: refs/heads/master@{#295638}

R=dbeam@chromium.org
BUG=393873
TEST=GYP_GENERATORS=ninja gyp --depth . chrome/browser/resources/options/compiled_resources.gyp && ninja -C out/Default | grep ERROR | wc -l

Review URL: https://codereview.chromium.org/559423003

Cr-Commit-Position: refs/heads/master@{#295637}

This is breaking after r295514 which enforces that every file listed in an isolate file exists.

BUG=414808
R=dbeam@chromium.org

Review URL: https://codereview.chromium.org/587503002

Cr-Commit-Position: refs/heads/master@{#295636}

In order to contain the newer timing information, net::LoadTimingInfo::ServiceWorkerTiming is defined and contained in net::LoadTimingInfo. Of course this struct is widely used, so is this okey? or is there some another solution?

1st patch: https://codereview.chromium.org/515583005/

BUG=401389
TEST=N/A

Review URL: https://codereview.chromium.org/515753003

Cr-Commit-Position: refs/heads/master@{#295635}

This allows us to read MSRs on Windows Vista+.
Also move ReadMsr into PlatformBackend.

BUG=336558
TEST=tools/telemetry/run_tests msr

Review URL: https://codereview.chromium.org/578123002

Cr-Commit-Position: refs/heads/master@{#295634}

BUG=411009

Review URL: https://codereview.chromium.org/581803002

Cr-Commit-Position: refs/heads/master@{#295633}

The GYP build was updated in
https://crrev.com/5926b3d223f5c183b3341a01b522875aceae2ed9

BUG=none
TBR=brettw

Review URL: https://codereview.chromium.org/585693002

Cr-Commit-Position: refs/heads/master@{#295632}

Changes the trace to output to include;
 * How much the deadline was missed by.
 * The full BeginFrameArgs that was dropped.

BUG=346230

Review URL: https://codereview.chromium.org/579083002

Cr-Commit-Position: refs/heads/master@{#295631}

The tile priority visible rect is sometimes expected to be not
intersecting the layer bounds. That's expected, since the layer
might be offscreen. In those cases we should still be correctly
prioritizing and creating tiles. This fix addresses that.

BUG=414521
R=danakj

Review URL: https://codereview.chromium.org/577753002

Cr-Commit-Position: refs/heads/master@{#295630}

- Add helper buffer for sending IOBuffer
- Add initialization error states.
- Make the device name more human-readable.

BUG=405744,405774

Review URL: https://codereview.chromium.org/575273002

Cr-Commit-Position: refs/heads/master@{#295629}

BUG=313244
R=dbeam@chromium.org

Review URL: https://codereview.chromium.org/514503002

Cr-Commit-Position: refs/heads/master@{#295628}

Instrumental test for BookmarksBridge. It currently tests these functionalities: addBookmark, addFolder and getAllFoldersWithDepths.

BUG=411545

Review URL: https://codereview.chromium.org/550543003

Cr-Commit-Position: refs/heads/master@{#295627}

This CL fixes the memory leak bug in CL 462423004.
See https://codereview.chromium.org/462423004/ for previous code reviews.

-------------------------
 Original CL description
-------------------------

Revert CL 117933003. Re-add speculative resource prefetching code.
https://codereview.chromium.org/117933003/

The speculative resource prefetching code was experimental code developed by
shishir@. He found that it has little improvement on desktop Chrome (win). We
though this should be beneficial to mobile browsers. After discussing with
tburkard@ and kenjibaheux@, we decided to bring the code back and do more
analysis on mobile devices. Reverting the patchset to re-add the code is the
first step.

The following design doc has discussed all related approaches and action items.
https://docs.google.com/a/google.com/document/d/1ie3hu-zNNXvmTXm3aJAtKUGOh6nZfbNjA0aZE1bzzIg/edit?usp=sharing

BUG=408399, 405690

Review URL: https://codereview.chromium.org/576313002

Cr-Commit-Position: refs/heads/master@{#295626}

Otherwise initialization that occurs offscreen can load incorrect screen
metric information. E.g. a RenderView will assume it is on the primary
display when loaded in a bubble, which results in it being created with
an incorrect scale factor in some screen setups.

This CL adds a call to -[BaseBubbleController setAnchorPosition] in the
non-NIB initializer to give the window a good estimate of the position
it will eventually be shown at.

BUG=324748

Review URL: https://codereview.chromium.org/573143002

Cr-Commit-Position: refs/heads/master@{#295625}

BUG=410082

Review URL: https://codereview.chromium.org/535343003

Cr-Commit-Position: refs/heads/master@{#295624}

And also add error validation to the tabs.query method (while we're at it).

BUG=128924
TEST=ExtensionApiTest.TabQuery

Review URL: https://codereview.chromium.org/569803004

Cr-Commit-Position: refs/heads/master@{#295623}

The following supressions are no longer needed:
bug_101125a
bug_101125b
bug_101125c
bug_101145b
bug_101145c
bug_101145d
bug_101146d

BUG=101125,101145,101146
R=timurrrr@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/578773002

Cr-Commit-Position: refs/heads/master@{#295622}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/2dc4bc6..34469ea

TBR=dpranke@chromium.org,apavlov@chromium.org

Review URL: https://codereview.chromium.org/584703002

Cr-Commit-Position: refs/heads/master@{#295621}

BUG=414880
R=brettw

Review URL: https://codereview.chromium.org/576293003

Cr-Commit-Position: refs/heads/master@{#295620}

The following supressions are no longer needed:
bug_102257
bug_102327b
bug_102327c
bug_102614
bug_104578
bug_105715

BUG=102257,102327,102614,104578,105715
R=timurrrr@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/552343004

Cr-Commit-Position: refs/heads/master@{#295619}

This is done in a comparable way to NativeViewHostAura, but using a
ReparentNSView helper function which reparents an NSView to a
NativeWidgetMac's BridgedContentView (or to `nil`).

Earlier attempts tried to use NativeWidgetPrivate::ReparentNativeView()
which turns out to be a bad idea, since it's really designed to reparent
windows (aura::Windows or HWNDs). Mac's child window support is
insufficient for what toolkit-views expects, and WebContents on Mac are
managed by an NSView in any case, not an NSWindow.

Along with logic currently in render_widget_host_view_mac.mm and
web_contents_view_mac.mm, reparenting renderer views needs to be done in
the native view hierarchy, not the window hierarchy.

This CL no longer tries to enable the current
native_view_host_unittest.cc (tests there assume ReparentNativeView is
used), but adds native_view_host_mac_unittest.mm to give test coverage,
and to inspect properties at the Cocoa layer. Common parts of the 3
_unittest.* files are refactored into a NativeViewHostTestBase class.

Some other views_unittests are also made passing by implementing a
NativeViewHost::CreateWrapper that doesn't just return NULL:
4xFocusTraverslTest and NativeWidgetTest.GetTopLevelNativeWidget2

Before: 455 tests run 22 tests failed 21 tests crashed. After: 458 tests
run 22 tests failed 16 tests crashed.

BUG=378134, 415024

Review URL: https://codereview.chromium.org/530933002

Cr-Commit-Position: refs/heads/master@{#295618}

BUG=415745
R=oshima@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/583503003

Cr-Commit-Position: refs/heads/master@{#295617}