- 17 Sep, 2013 40 commits
-
-
sergeyu@chromium.org authored
The new proxy is based on ppapi::proxy::PluginResource and ppapi::host::ResourceHost which simplifies code significantly. Also the permission check is consistent with socket APIs now. BUG=281781 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223482 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223494 R=brettw@chromium.org, yzshen@chromium.org Review URL: https://codereview.chromium.org/23819033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223535 0039d316-1c4b-4281-b951-d872f2087c98
-
hirono@chromium.org authored
Originally, the file browser private filesystem APIs parse the arguments and generate the results manually. This CL lets the APIs use the auto generated helper classes to parse the arguments. BUG=241693 TEST=file_manager_browsertests Review URL: https://chromiumcodereview.appspot.com/23766029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223534 0039d316-1c4b-4281-b951-d872f2087c98
-
garykac@chromium.org authored
(Migrated from crrev.com/21133002) This imports the GTK WebInputEvent factory into content as a set of WebInputEventBuilders. The functionality should be exacly the same except for the handling of the following keycodes which changed due to moving from the WebCore GDK -> windows keycode mapping to ui/base: 0xD7 (XK_multiply) is mapped to 0xA6 (VKEY_MULTIPLY) instead of 0 (VKEY_UKNOWN). 0xA6 (XK_brokenbar), 0xAB (XK_guillemotleft), 0xB0 (XK_degree), 0xBB (XK_guillemotright), 0xD9 (XK_Ugrave) and 0xF9 (XK_ugrave) map to 0xE2 (VKEY_OEM_102) instead of 0 (VKEY_UNKNOWN). I think these are progressions. BUG=263189 Review URL: https://chromiumcodereview.appspot.com/23815005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223533 0039d316-1c4b-4281-b951-d872f2087c98
-
karenlees@chromium.org authored
Disable all activity log end to end tests on windows. BUG=245594 NOTRY=true Review URL: https://chromiumcodereview.appspot.com/23708045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223532 0039d316-1c4b-4281-b951-d872f2087c98
-
zelidrag@chromium.org authored
This should help us tune absolute timeouts for this process better. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/23444077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223531 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-release@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223529 0039d316-1c4b-4281-b951-d872f2087c98
-
nyquist@chromium.org authored
The DOM Distiller component will contain code for an experimental prototype for distilling the core part of a web page. To enable this feature, use the command line flag --enable-distiller. The webui/ folder depends on content, but given iOS at the time being supports the usage of WebUI, it is kept a a top level folder in the component instead of in content/. BUG=288015 Review URL: https://chromiumcodereview.appspot.com/23503042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223528 0039d316-1c4b-4281-b951-d872f2087c98
-
ccameron@chromium.org authored
The determination of whether or not to put up a sad tab page is made based on the termination status of the renderer process. The termination status of the renderer process is checked when the channel between the browser and the renderer stops working. There is a race here because there is no reason to believe that the renderer process has finished terminating at the time that the browser detects that its channel to the renderer is dead. If renderer process is believed to be still running at the moment when the decision to put up the sad tab page is taken, then no sad tab will be put up, the view of the renderer will be removed (eventually), and a transparent window will result. This bug was previously fixed on Linux with with https://chromiumcodereview.appspot.com/11316261 this patch expands that fix to Mac. In particular, if the renderer process is known to be dead, wait for the process to terminate before taking its termination status. To be sure that the browser does not wait forever on a renderer that is not exiting, send a kill signal to the renderer before doing the wait. BUG=167538 Review URL: https://chromiumcodereview.appspot.com/23866011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223526 0039d316-1c4b-4281-b951-d872f2087c98
-
groby@chromium.org authored
Autofill suggestions were popping up in the wrong place, due to a bad coordinate system conversion. BUG=286521 R=isherman@chromium.org Review URL: https://chromiumcodereview.appspot.com/24072005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223524 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
BUG=258647,285585 Review URL: https://chromiumcodereview.appspot.com/23672040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223523 0039d316-1c4b-4281-b951-d872f2087c98
-
asvitkine@chromium.org authored
Found by the Mac OS X 'leaks' tool; fixed on a plane. BUG=292905 Review URL: https://chromiumcodereview.appspot.com/23503065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223522 0039d316-1c4b-4281-b951-d872f2087c98
-
tommycli@chromium.org authored
NativeMediaFileUtil allows GetInfoSync to be called with a NULL |platform_path|. This change brings PicasaFileUtil behavior in line with that. BUG=151701 Review URL: https://chromiumcodereview.appspot.com/23442026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223521 0039d316-1c4b-4281-b951-d872f2087c98
-
isherman@chromium.org authored
BUG=285458 TEST=(see bug) R=estade@chromium.org Review URL: https://chromiumcodereview.appspot.com/23882013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223519 0039d316-1c4b-4281-b951-d872f2087c98
-
timvolodine@chromium.org authored
Add support for Device Orientation in the default data fetcher. The default data fetcher is only compiled for platforms where we don't have proper fetchers available, i.e. platforms other than Android, Windows or Mac. BUG=261165 Review URL: https://chromiumcodereview.appspot.com/23542018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223518 0039d316-1c4b-4281-b951-d872f2087c98
-
sadrul@chromium.org authored
Make sure when a number is released, the |min_available_slot_| is updated accordingly, so that subsequent allocations are set correctly to the lowest available ID. BUG=292929 R=sky@chromium.org Review URL: https://codereview.chromium.org/23654045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223517 0039d316-1c4b-4281-b951-d872f2087c98
-
ikarienator@chromium.org authored
Pointer returned by vector::begin is not checked before use. BUG=291012, 288070 Review URL: https://chromiumcodereview.appspot.com/23475048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223516 0039d316-1c4b-4281-b951-d872f2087c98
-
lambroslambrou@chromium.org authored
This CL draws the mouse cursor shape on the client, at the most recent position of an injected mouse move event (or the center of the screen if no events have been injected yet). BUG=270347 TEST=manual, verify mouse cursor appears and moves as expected. Review URL: https://chromiumcodereview.appspot.com/23532072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223515 0039d316-1c4b-4281-b951-d872f2087c98
-
karenlees@chromium.org authored
BUG=293126 NOTRY=true Review URL: https://chromiumcodereview.appspot.com/23514063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223514 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223513 0039d316-1c4b-4281-b951-d872f2087c98
-
eseidel@chromium.org authored
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=157847:157863&mode=html TBR= BUG= Review URL: https://chromiumcodereview.appspot.com/24147005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223512 0039d316-1c4b-4281-b951-d872f2087c98
-
rouslan@chromium.org authored
Use the system-default fixed font family in rac dialog, instead of hard coding it. BUG=291272 Review URL: https://chromiumcodereview.appspot.com/24105005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223511 0039d316-1c4b-4281-b951-d872f2087c98
-
eroman@chromium.org authored
Review URL: https://chromiumcodereview.appspot.com/23530064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223510 0039d316-1c4b-4281-b951-d872f2087c98
-
avi@chromium.org authored
BUG=54748 TEST=load a password-protected PDF on Windows, see fancy new UI Review URL: https://chromiumcodereview.appspot.com/23478036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223509 0039d316-1c4b-4281-b951-d872f2087c98
-
huangs@chromium.org authored
We wish to make MostLikely URL recommendations use local thumbnail. To increase the likelihood of a hit, this CL enables a thumbnail request to perform URL prefix match. For example, if thumbnail is stored for ==> http://www.chromium.org/Home but not ==> http://www.chromium.org/ then previously the request ==> chrome://thumb/http://www.chromium.org/ would fail. This CL aims to create a fallback, by adding "thumb2" that matches prefix, i.e.: ==> chrome://thumb2/http://www.chromium.org/ would match "http://www.chromium.org/Home" and display the corresponding thumbnail. Details: - We consider "URL prefix" match, which is not same as "string prefix" match. Specifics: --- Need identical protocol/scheme, host, and port (GURL is smart about this). --- Query strings are ignored. --- For path, we require entire path components to match. E.g., "base/test" is a prefix of "base/test/sub", but is NOT a prefix of "base/testing" or "best/test-case". - If multiple matches exist, the first URL-lexicographical match is taken. This allows the "nearest" children to be matched, but favors siblings that are alphabetically closer. For example, "base" prefers "base/test" over "base/test/sub", but also prefers "base/deep/sub/dir/" over "base/test" (since "deep" < "test"). - To implement the above match, a new comparator is used in the thumbnail cache. - Adding new test TopSitesCacheTest, which also tests existing code. - Adding url_utils.cc in chrome\browser\history, along with unit tests. - Adding the "chrome://thumb2" path, which causes most of the 1-2-line changes in files. BUG=284634 TEST=TopSitesCacheTest.* Review URL: https://chromiumcodereview.appspot.com/23477033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223508 0039d316-1c4b-4281-b951-d872f2087c98
-
jennyz@chromium.org authored
Fix the bluetooth audio device id changing on the fly issue and the active device inconsistent issue caused by multiple NodesChanged signal received for the same node change. BUG=290485 Review URL: https://chromiumcodereview.appspot.com/23620055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223507 0039d316-1c4b-4281-b951-d872f2087c98
-
bryaneyler@google.com authored
BUG=245025 R=eroman@chromium.org,ellyjones@chromium.org Review URL: https://chromiumcodereview.appspot.com/23569007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223506 0039d316-1c4b-4281-b951-d872f2087c98
-
asvitkine@chromium.org authored
Found by the Mac OS X 'leaks' tool; fixed on a plane. BUG=292905 Review URL: https://chromiumcodereview.appspot.com/23503064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223505 0039d316-1c4b-4281-b951-d872f2087c98
-
dshi@chromium.org authored
In run_test.Main, there are two places that logging level may be changed: 1. BrowserFinderOptions, when calling parser.parse_args, in which logging level is set based on verbosity's value. 2. run_test.Main, in which logging level is set to WARN if verbosity is 0. Such change on logging level causes problem to caller like autotest, which relies on logging level to log details during the test, and output messages from different logging level to different log file, e.g., client.DEBUG, client.INFO etc. This CL added some fix to: 1. Cache the logging level at the beginning of the Main method. 2. Always restore logging level at the end of the Main method. BUG=chromium:284763 TEST=verified in local dut with autotest: test_that --fast -b lumpy 172.22.75.225 telemetry_UnitTests Review URL: https://chromiumcodereview.appspot.com/23458027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223504 0039d316-1c4b-4281-b951-d872f2087c98
-
asvitkine@chromium.org authored
Found by the Mac OS X 'leaks' tool; fixed on a plane. BUG=292905 Review URL: https://chromiumcodereview.appspot.com/24188002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223503 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
Heapcheck: Remove suppressions for SafeBrowsingDatabaseManagerTest.CheckCorrespondsListType because the bug has been fixed. BUG=289509 NOTRY=true TBR=noamsml@chromium.org Review URL: https://chromiumcodereview.appspot.com/23950009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223502 0039d316-1c4b-4281-b951-d872f2087c98
-
shadi@chromium.org authored
BUG=291379 Review URL: https://chromiumcodereview.appspot.com/24159003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223501 0039d316-1c4b-4281-b951-d872f2087c98
-
danakj@chromium.org authored
This moves the release callback out of the TextureMailbox so that we can use it for other resource types than just texture mailboxes. While doing this, we make a SingleReleaseCallback class that is held in a scoped_ptr. This class DCHECKs that the callback is run before it is destroyed, and ensures clear ownership semantics as you must Pass() the callback around. No change in behaviour, covered by existing tests. R=piman BUG=263069 Review URL: https://chromiumcodereview.appspot.com/23648014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223500 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=291236 NOTRY=true TBR=yangguo@chromium.org Review URL: https://chromiumcodereview.appspot.com/23620056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223499 0039d316-1c4b-4281-b951-d872f2087c98
-
asvitkine@chromium.org authored
Fixed at altitude 12000 meters. BUG=227391 TEST=See bug. Review URL: https://chromiumcodereview.appspot.com/23591052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223498 0039d316-1c4b-4281-b951-d872f2087c98
-
sergeyu@chromium.org authored
TBR=sergeyu@chromium.org BUG=281781 Review URL: https://codereview.chromium.org/23514062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223497 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
- Move a WontFix leak to the intentional section, and update the suppression to match the only current instance of the leak. - Widen a suppression for an inspector memory error. - Add new suppression for a WebCore::Document::decoder NULL deref. BUG=73299,288801,293088 NOTRY=true TBR=thakis@chromium.org Review URL: https://chromiumcodereview.appspot.com/23902038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223496 0039d316-1c4b-4281-b951-d872f2087c98
-
rkc@chromium.org authored
The feedback manifest doesn't contain the correct icons to show on the app shelf. Add them. R=xiyuan@chromium.org BUG=291381 Review URL: https://chromiumcodereview.appspot.com/23866010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223495 0039d316-1c4b-4281-b951-d872f2087c98
-
sergeyu@chromium.org authored
The new proxy is based on ppapi::proxy::PluginResource and ppapi::host::ResourceHost which simplifies code significantly. Also the permission check is consistent with socket APIs now. BUG=281781 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223482 Review URL: https://chromiumcodereview.appspot.com/23819033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223494 0039d316-1c4b-4281-b951-d872f2087c98
-
jsbell@chromium.org authored
When porting the transaction back-end from Blink we brought along an AVLTree implementation for the in-memory key/value store for transactions. Replace this with a std::map since it provides similar performance guarantees (red-black tree) and we like to delete code. TBR=jam@chromium.org R=alecflett@chromium.org Review URL: https://chromiumcodereview.appspot.com/17462005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223493 0039d316-1c4b-4281-b951-d872f2087c98
-
ananta@chromium.org authored
Currently the Tooltip widget is created in the tooltip timer which also handles setting the tooltip text on the Tooltip object. There is a timing window between this and the mouse event coming in, which ends up causing the tooltips to not show up if the underlying root changes in between. Fixes bug https://code.google.com/p/chromium/issues/detail?id=292530 BUG=292530 R=sky@chromium.org, sky Review URL: https://codereview.chromium.org/23958012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223492 0039d316-1c4b-4281-b951-d872f2087c98
-